Re: [PATCH v2 17/17] power: supply: olpc_battery: Add OLPC XO 1.75 support

2018-12-02 Thread Darren Hart
/* XO 1.75 */ > + data->new_proto = 1; > + data->little_endian = 1; > } else if (ecver < 0x44) { > /* >* We've seen a number of EC protocol changes; this driver > -- > 2.19.1 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

2018-12-02 Thread Darren Hart
The code previously supported xo1.5 (it seems), and the commit message doesn't mention changing the compatible string. Was this an intentional change? If so, it should be mentioned in the commit message. > {} > }; > MODULE_DEVICE_TABLE(of, olpc_battery_ids); > -- > 2.19.1 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 07/17] Platform: OLPC: Avoid a warning if the EC didn't register yet

2018-12-02 Thread Darren Hart
+ if (WARN_ON(!ec_driver->ec_cmd)) > return -ENODEV; > > if (!ec) > -- > 2.19.1 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 06/17] Platform: OLPC: Add XO-1.75 EC driver

2018-12-02 Thread Darren Hart
anges. > > Basically all of the above is based on the review by Andy Shevchenko. Andy, what was your intent for Lubomir here? From the above, this looks like it should be several patches to me. Thanks, -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device

2018-11-28 Thread Darren Hart
deal with this? There are two > instances of the same bus type, each of which would like to have a > device called "70FE8229-D03B-4214-A1C6-1F884B1A892A". Can we somehow > rename the symlinks without renaming the device, or are we just > supposed to prefix the device name like Mario is doing here? > Mario, if this is still a concern (I presume it is) would you please resend the patch Cc gregkh directly? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: dell-laptop: Mark expected switch fall-throughs

2018-11-28 Thread Darren Hart
value *= 60; > unit = KBD_TIMEOUT_SECONDS; > -- > 2.7.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list

2018-11-13 Thread Darren Hart
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"), > + }, > + }, > { > .ident = "Lenovo Yoga 3 1170 / 1470", > .matches = { > -- > 2.17.1 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] scripts/kconfig/merge_config: don't redefine 'y' to 'm'

2018-11-07 Thread Darren Hart
echo New value: $NEW_VAL > + echo Will use previous value. echo "-y passed, will not demote y to m" Or something along those lines. > + echo > + elif [ "x$PREV_VAL" != "x$NEW_VAL" ] ; then > echo Value of $CFG is redefined by fragment $MERGE_FILE: > echo Previous value: $PREV_VAL > echo New value: $NEW_VAL > -- > 2.11.0 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] scripts/kconfig/merge_config: don't redefine 'y' to 'm'

2018-11-07 Thread Darren Hart
something like: $ make arm64-selftest.config drm.config where arm64-selftest.config defines DRM=y and drm.config defines DRM=m, the result should be "DRM=y". So the first step is to make merge_config.sh support it. A follow up step would be to integrate this into the kernel Makefile system if we determine this is the correct behavior, or to provide a parameter if we don't want to change the default behavior. -- Darren Hart VMware Open Source Technology Center

Re: Linux 4.20-rc1

2018-11-06 Thread Darren Hart
hose that might not want it, and reduces the number of times you have to explain your preference as new maintainers come and go. -- Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.20-1

2018-10-31 Thread Darren Hart
Hi Linus, This tag has a few merge conflicts with some x86/cpu id changes. Stephen Rothwell's merge in next/master is correct, and I have provided an example here as well: git://git.infradead.org/linux-platform-drivers-x86.git pdx86-v4.20-1-merge Thanks, Darren Hart VMware Open Source

[GIT PULL] platform-drivers-x86 for 4.19-2

2018-09-18 Thread Darren Hart
changes up to ff0e9f26288d2daee4950f42b37a3d3d30d36ec1: platform/x86: alienware-wmi: Correct a memory leak (2018-09-10 13:45:43 -0700) Thanks, Darren Hart VMware Open Source Technology Center platform-drivers-x86 for v4.19-2 Free

Re: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak

2018-09-12 Thread Darren Hart
On Wed, Sep 12, 2018 at 12:14:34PM +, mario.limoncie...@dell.com wrote: > Darren, > > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Monday, September 10, 2018 3:52 PM > > To: Limonciello, Mario > > Cc: An

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-09-11 Thread Darren Hart
On Sun, Jul 08, 2018 at 03:56:17AM +0900, Mattia Dongili wrote: > On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote: > > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch ca

Re: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak

2018-09-10 Thread Darren Hart
t;buf->std.output[1], > priv->buf->std.output[2], priv->buf->std.output[3]); > + kfree(output.pointer); > > return 0; > } > -- > 2.7.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-09 Thread Darren Hart
On Mon, Jul 09, 2018 at 09:08:56PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Monday, July 9, 2018 4:07 PM > > To: Limonciello, Mario > > Cc: srinivas.pandruv...@linux.intel.

Re: [PATCH] dell-laptop: Fix backlight detection

2018-07-09 Thread Darren Hart
_fill_request(, token->location, 0, 0, 0); > ret = dell_send_request(, > CLASS_TOKEN_READ, > SELECT_TOKEN_AC); > - if (ret) > + if (ret == 0) > max_intensity = buffer.output[3]; > } > > -- > 2.17.1 > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86/toshiba_acpi.c: fix defined but not used build warnings

2018-07-09 Thread Darren Hart
'version_proc_show' > defined but not used [-Wunused-function] > > Signed-off-by: Randy Dunlap > Cc: Azael Avalos > Cc: platform-driver-...@vger.kernel.org > Cc: Darren Hart > Cc: Andy Shevchenko Thanks Randy, queued. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-09 Thread Darren Hart
On Mon, Jul 09, 2018 at 04:38:16AM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com] > > Sent: Saturday, July 7, 2018 8:44 AM > > To: Darren Hart; Andy Shevchenko > > Cc:

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-06 Thread Darren Hart
rs to have more control over their drivers, but this scenario really frustrates me. I don't think I can justify this to Linus as a fix. But before we just say "no" (because hey, I want these fixes available as early as possible too), let's ask Rafael if he has an opinion or if there is precedent for this in his experience with ACPI drivers in general: Rafael? Finally, we can also just ask Linus. The firmware update broke the power button, we can get it working again by supporting the new API with this patch... see what he says. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-06 Thread Darren Hart
ional. Either way, from what I can see, the final line in the function: return AE_CTRL_TERMINATE; Is unreachable as there are no "break" statements in the switch, and the default falls through to return AE_OK. Something doesn't seem right here. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: acer-wmi: mark expected switch fall-throughs

2018-07-06 Thread Darren Hart
WMID_get_u32(value, cap); > break; > @@ -1386,6 +1388,7 @@ static acpi_status set_u32(u32 value, u32 cap) > > return AMW0_set_u32(value, cap); > } > + /* else: fall through */ I suspect you ar

Re: [PATCH 1/2] platform/x86: wmi: prefix sysfs files in /sys/bus/wmi with the ACPI device

2018-07-06 Thread Darren Hart
e Mario is doing here? > Mario, This one has been lingering at the bottom of my patch stack for a while now - sorry for not poking on this earlier. Is this still something you have a need for? If so, would you resend and add Greg to Cc - specifically directing Andy's question above to him? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-26 Thread Darren Hart
On Sat, Jun 23, 2018 at 08:24:26AM +0200, Julia Lawall wrote: > > > On Fri, 22 Jun 2018, Darren Hart wrote: > > > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > The function dell_smbios_smm_cal

Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-26 Thread Darren Hart
On Tue, Jun 26, 2018 at 10:32:17PM +0300, Andy Shevchenko wrote: > On Sat, Jun 23, 2018 at 3:22 AM, Darren Hart wrote: > > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The function dell_smbios_smm_call and po

Re: [PATCH] platform/x86: dell-smbios: make a function and a pointer static

2018-06-22 Thread Darren Hart
about the "static" suggesting to someone reading the code that this data is not used outside of this file, when it is. I'm not finding a position on this in coding-style. Andy, do you care to weigh in on this? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: ideapad-laptop: Apply no_hw_rfkill to Y20-15IKBM, too

2018-06-22 Thread Darren Hart
ll. > > Trim the last letter from the string so that it matches to both > Y20-15IKBN and Y20-15IKBM models. > > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1098626 > Cc: > Signed-off-by: Takashi Iwai Thanks Takashi, queued. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: dell-smbios-base: Support systems without tokens

2018-06-22 Thread Darren Hart
On Fri, Jun 15, 2018 at 12:12:51PM -0500, Mario Limonciello wrote: > Some Dell servers can use dell-smbios but they don't support the > token interface. Make it optional. > > Signed-off-by: Mario Limonciello Thanks Mario, queued. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-22 Thread Darren Hart
On Thu, Jun 21, 2018 at 01:24:34AM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Wednesday, June 20, 2018 7:17 PM > > To: Kees Cook > > Cc: LKML; Andy Shevchenko; Platform Dr

Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-20 Thread Darren Hart
On Wed, Jun 20, 2018 at 04:43:14PM -0700, Kees Cook wrote: > On Wed, Jun 20, 2018 at 4:37 PM, Darren Hart wrote: > > On Wed, Jun 20, 2018 at 02:31:41PM -0700, Kees Cook wrote: > >> The probe handler_data was being allocated with __get_free_pages() > >> for no reason I

Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-20 Thread Darren Hart
ree_pages((unsigned long)wblock->handler_data, > -get_order(wblock->req_buf_size)); > + kfree(wblock->handler_data); > } > > if (wdriver->remove) > -- > 2.17.1 > > > -- > Kees Cook > Pixel Security > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v6 6/8] platform/mellanox: Introduce support for Mellanox register access driver

2018-06-19 Thread Darren Hart
ng queue. Once the builds complete, I'll move these to for-next. Vadim, I see you've already updated the kernel version in the sys documentation to 4.19, so I won't attempt to push these into the 4.18 RC cycle. -- Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.18-1

2018-06-13 Thread Darren Hart
to 26ed9d1c07efa5c3a3810dbb7c668e132e91d426: platform/x86: silead_dmi: Add entry for Chuwi Hi8 tablet touchscreen (2018-06-08 14:22:15 +0300) Thanks, Darren Hart VMware Open Source Technology Center platform-drivers-x86 for v4.18

Re: linux-next: build failure after merge of the drivers-x86 tree

2018-06-11 Thread Darren Hart
Thank you Stephen. We caught this earlier, but failed to remove it from for-next while repairing the series. Our apologies. I have removed this series back to the known good patch in for-next: 26ed9d1 platform/x86: silead_dmi: Add entry for Chuwi Hi8 tablet touchscreen Andy has this reworked already and is working on completing testing before pushing the update to for-next. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH resend v2] dcdbas: Add support for WSMT ACPI table

2018-06-08 Thread Darren Hart
+ smi_data_buf_size = (unsigned long) min(eps->num_of_4k_pages * 4096 > > - 8, > > + (u64) ULONG_MAX); > > This is too twisted code. First, it needs explanation. > Second, it might need some refactoring. > > (Yes, I got the idea, but would it be better implementation?) > > > + max_smi_data_buf_size = smi_data_buf_size; > > + wsmt_enabled = true; > > + dev_info(_pdev->dev, > > +"WSMT found, using firmware-provided SMI buffer.\n"); > > + return 1; > > +} > > > #define SMI_CMD_MAGIC (0x534D4931) > > > > +#define SMM_EPS_SIG"$SCB" > > Just integer like above and put the sting as a comment. > (Side note: above magic also looks like string) Given the above, I think we can use the more recognizable string - since that is clearly how they think of this label. Otherwise, agree with a follow-up to all of Andy's feedback. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-08 Thread Darren Hart
cycle being handled in the kernel. 2) Why is a module option preferable to a compile time option? It seems to me the policy will be largely distro dependent, and the same kernel needing to support both modes seems likely to be pretty rare. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v5 8/8] Documentation/ABI: Add documentation mlxreg-io sysfs interfaces

2018-06-08 Thread Darren Hart
> Signed-off-by: Vadim Pasternak No further comments on patch 7 or 8. Thanks for the updates. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v5 6/8] platform/mellanox: Introduce support for Mellanox register access driver

2018-06-08 Thread Darren Hart
r = mlxreg_io_attr_init(priv); > + if (err) { > + dev_err(>pdev->dev, "Failed to allocate attributes: %d\n", > + err); > + return err; > + } > + > + priv->hwmon = devm_hwmon_device_register_with_groups(>dev, > + "mlxreg_io", > + priv, > + priv->groups); > + if (IS_ERR(priv->hwmon)) { > + dev_err(>dev, "Failed to register hwmon device %ld\n", > + PTR_ERR(priv->hwmon)); > + return PTR_ERR(priv->hwmon); > + } > + > + dev_set_drvdata(>dev, priv); > + > + return 0; > +} > + > +static struct platform_driver mlxreg_io_driver = { > + .driver = { > + .name = "mlxreg-io", > + }, > + .probe = mlxreg_io_probe, > +}; > + > +module_platform_driver(mlxreg_io_driver); > + > +MODULE_AUTHOR("Vadim Pasternak "); > +MODULE_DESCRIPTION("Mellanox regmap I/O access driver"); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:mlxreg-io"); > -- > 2.1.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH resend v2] dcdbas: Add support for WSMT ACPI table

2018-06-08 Thread Darren Hart
ister(_driver); > > } > > diff --git a/drivers/firmware/dcdbas.h b/drivers/firmware/dcdbas.h > > index ca3cb0a54ab6..7ea5b3e070b9 100644 > > --- a/drivers/firmware/dcdbas.h > > +++ b/drivers/firmware/dcdbas.h > > @@ -54,6 +54,8 @@ > > > > #define SMI_CMD_MAGIC (0x534D4931) > > > > +#define SMM_EPS_SIG"$SCB" > > + > > #define DCDBAS_DEV_ATTR_RW(_name) \ > > DEVICE_ATTR(_name,0600,_name##_show,_name##_store); > > > > @@ -103,5 +105,14 @@ struct apm_cmd { > > > > int dcdbas_smi_request(struct smi_cmd *smi_cmd); > > > > +struct smm_eps_table { > > + char smm_comm_buff_anchor[4]; > > + u8 length; > > + u8 checksum; > > + u8 version; > > + u64 smm_comm_buff_addr; > > + u64 num_of_4k_pages; > > +} __packed; > > + > > #endif /* _DCDBAS_H_ */ > > > > -- > > 2.14.2 > > Darren, Andy, > > Stuart and I were hoping you guys could bring this through the > platform-driver-x86 tree. > The logic behind this is that the only consumer for dcdbas in kernel is > dell-smbios. > > There isn't a subsystem maintainer for someone to pull in dcdbas even though > the > current maintainer (Doug W) has acked it. Apologies for the delay. I'm OK bringing it in in general. I'm reviewing patches today and tomorrow to try and close out the backlog. Should have a review by EOD tomorrow. I've been wondering about drivers/firmware anyway - that is almost by definition platform specific and might make more sense as part of the platform drivers, especially if it is currently without a maintainer (although akpm will often take such things). -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-04 Thread Darren Hart
gt; dimming / auto-off of the kbd backlight when the no keys are > touched for x seconds. This would seriously get in the way of that. > > So sorry, but NACK to this series. So if instead of modifying the LED value, the kernel platform drivers converted the TOGGLE into a cycle even by conve

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-04 Thread Darren Hart
(code == NOTIFY_KBD_BRTDWN) { kbd_led_set(>kbd_led, asus->kbd_led_wk - 1); goto exit; } if (code == NOTIFY_KBD_BRTUP) { kbd_led_set(>kbd_led, asus->kbd_led_wk + 1); goto exit; } > if (is_display_toggle(code) && > asus->driver->quirks->no_display_toggle) > goto exit; > -- > 2.11.0 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

2018-06-04 Thread Darren Hart
rectly show the OSD when this is done. This makes sense. Userspace can't be aware of every platforms sys files, so there needs to be a common mechanism. LED_BRIGHT_HW_CHANGED makes sense. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v4 8/8] Documentation/ABI: Add documentation mlxreg-io sysfs interfaces

2018-06-04 Thread Darren Hart
:May 2018 > +KernelVersion: 4.18 > +Contact: Vadim Pasternak > +Description: These files allow assert system's power cycling and PS units > + on/off switching. This Description is awkward. Consider: These files allow asserting system power cycling and switching power supply units on and off. > + The files are write only. Please provide usage and resulting behavior. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v4 6/8] platform/mellanox: Introduce support for Mellanox register access driver

2018-06-04 Thread Darren Hart
iv) ... > + for (i = 0; i < priv->pdata->counter; i++) { > + priv->mlxreg_io_attr[i] = > + >mlxreg_io_dev_attr[i].dev_attr.attr; > + memcpy(>mlxreg_io_dev_attr[i].dev_attr, > +_io_devattr_rw, sizeof(struct device_attribute)); > + > + /* Set attribute name as a label. */ :-) OK, so this comment is rather obvious from the code but where things are really opaque in the processing above, there are no comments. Let's focus the comments where the code is non-obvious. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v3 6/7] platform/mellanox: Introduce support for Mellanox register access driver

2018-06-01 Thread Darren Hart
are defined per system type bases and includes the registers > > > > related > > > > + to system resets operation, system reset causes monitoring > > > > and some > > > > + kinds of mux selection. > > > > > > No Documentation/ABI/ entries for these new sysfs files? Not good :( > > > > > > > Thanks Greg for your comment. > > > > Should I call doc file like: > > Documentation/ABI/stable/sysfs-driver-mlxreg-io > > ? > > What ever matches the naming scheme for the driver, yes. Vadim, I'm happy to help out with the docs if you like. Will you be able to document this in a static way, or is this likely to change significantly from platform to platform? I ask because of the automated attribute creation in the code. -- Darren Hart VMware Open Source Technology Center

Re: [RESEND] [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-06-01 Thread Darren Hart
r Darren's queue, but for some reason > didn't processed yet. Thanks for getting this one Andy. I'm traveling, but am working through these currently. I'll assume you are handling this one. -- Darren Hart VMware Open Source Technology Center

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2018-06-01 Thread Darren Hart
ant the > "gitk" invocation if you are doing this automatically, of course. The > script just takes a commit range. Thanks for sharing Stephen. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 6/7] platform/mellanox: Introduce support for Mellanox register access driver

2018-05-26 Thread Darren Hart
On Sat, May 26, 2018 at 11:15:35AM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Friday, May 25, 2018 3:31 AM > > To: Vadim Pasternak <vad...@mellanox.com> &g

Re: media: uvcvideo: Support realtek's UVC 1.5 device

2018-05-24 Thread Darren Hart
). Took a looking at linux-next today, I didn't see it. Anything else needed to get this queued up? We'd love to get this in the 4.18 merge window, and stable if possible. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 6/7] platform/mellanox: Introduce support for Mellanox register access driver

2018-05-24 Thread Darren Hart
mlxreg_io_attr_show; > + priv->mlxreg_io_dev_attr[i].dev_attr.store = > + mlxreg_io_attr_store; > + break; If this is necessary, we can simplify this by checking for the read mask and the write mask and setting each once - rather than duplicating this for r, w, and rw. As it is a 0400 would not assign the show function, even though it is readable by somebody. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 5/7] platform/x86: mlx-platform: Add LED platform driver activation

2018-05-24 Thread Darren Hart
unctions from mlxreg.h file; Please remember to put the patch changelog below the --- line below. > --- Here Queued up for testing, thanks. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 3/7] platform/mellanox: mlxreg-hotplug: add extra cycle for hotplug work queue

2018-05-24 Thread Darren Hart
sider dependencies. I've fixed the sha in the commit message, and queued for testing. Thanks, -- Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.17-3

2018-05-18 Thread Darren Hart
ing for this Kconfig to try and catch more of this - and of course I've learned a few things to look out for as well. Thanks, Darren Hart VMware Open Source Technology Center The following changes since commit 7fe3fa3b5ec8e75389cce4bf5d052a52e6198d59: platform/x86: Kconfig: Fix dell-laptop dependenc

Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

2018-05-12 Thread Darren Hart
On Sat, May 12, 2018 at 11:51:02AM -0700, Randy Dunlap wrote: > On 05/12/2018 11:32 AM, Darren Hart wrote: > > On Sat, May 12, 2018 at 05:28:05PM +0800, kbuild test robot wrote: > >> Hi Mario, > >> > >> FYI, the error/warning still remains. > >> >

Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

2018-05-12 Thread Darren Hart
tristate "Dell SMBIOS driver" + depends on DCDBAS || DCDBAS=n -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 0/7] platform/x86: Mellanox add fixes and new features

2018-05-11 Thread Darren Hart
Activation of Mellanox LED driver from mlx-platform. > > Introduction of new mlxreg-io driver. > > Activation of mlxreg-io driver from mlx-platform. Patches 1,2 are queued up. Dropping 3-7 and reviewing them now from v2. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides

2018-05-11 Thread Darren Hart
t;sh...@kernel.org> I was concerned because this override was a deliberate decision made in: 9705315b7562 selftests/futex: Update Makefile to use lib.mk But reviewing lib.mk today, the RUN_TESTS and EMIT_TESTS perform the same function running TEST_PROGS. Reviewed-by: Darren Hart (VMware)

Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

2018-05-06 Thread Darren Hart
On Fri, May 04, 2018 at 06:27:00PM +, mario.limoncie...@dell.com wrote: > Darren, > > Is this with that fix of mine merged? FYI: This fix has now been merged to linus/master. -- Darren Hart VMware Open Source Technology Center

[GIT PULL] platform-drivers-x86 for 4.17-2

2018-05-05 Thread Darren Hart
figuration for 4.17 and 4.16 via stable. Thanks, Darren Hart VMware Open Source Technology Center The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the git repository at: git://git.infradead.org/linux-platfo

Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

2018-05-04 Thread Darren Hart
-- Darren > > > -Original Message- > > From: kbuild test robot [mailto:l...@intel.com] > > Sent: Friday, May 4, 2018 1:24 PM > > To: Limonciello, Mario > > Cc: kbuild-...@01.org; linux-kernel@vger.kernel.org; Darren Hart (VMware) > > Subject: drivers/platfo

Re: drivers/platform/x86/dell-smbios-wmi.c:66: undefined reference to `wmidev_evaluate_method'

2018-04-27 Thread Darren Hart
gt; DELL_LAPTOP=y, > its select DELL_SMBIOS incorrectly makes DELL_SMBIOS=y. > > > so if we can get your patch merged, we can see if any more breakage > happens... :) Sorry, comms fail on my part. This will be merged to for-next by tomorrow. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.

2018-04-20 Thread Darren Hart
ile in but this > > > causes dell-smbios to compile in which breaks if dcdbas is a module. > > > > > > Dell laptop shouldn't select dell-smbios anymore, but depend on it. > > > > > > Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency error on > >

Re: [PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.

2018-04-20 Thread Darren Hart
uot; avoids the dependency check causing this failure (I'm surprised and dismayed this made it through all the config permutation testing this saw). I'll apply this patch, and I guess it should go to stable, and for the next version I think it's time for a new "CONFIG DELL_EXTRAS" which will allow us to default DELL_SMBIOS to y and make the menu more consistent. Thank you for the catch. Grr :-( -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v3 3/5] platform/x86: Rename silead_dmi to touchscreen_dmi

2018-04-19 Thread Darren Hart
one > > Taking above into attention, and assuming it will go via some other tree, > Acked-by: Andy Shevchenko <andy.shevche...@gmail.com> This driver is all kinds of a special case, so no objection here either. :-) -- Darren Hart VMware Open Source Technology Center

Re: [PATCH 40/61] platform: x86: simplify getting .drvdata

2018-04-19 Thread Darren Hart
--- > > Build tested only. buildbot is happy. Please apply individually. Queued up for testing. (I'm not sure what you mean by "Please apply individually") -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2] platform/x86: asus-wireless: Fix NULL pointer dereference

2018-04-19 Thread Darren Hart
On Thu, Apr 19, 2018 at 07:04:34AM -0700, João Paulo Rechi Vita wrote: > When the module is removed the led workqueue is destroyed in the remove > callback, before the led device is unregistered from the led subsystem. Queued up, thanks. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: dell-smbios: Match on www.dell.com in OEM strings too

2018-04-19 Thread Darren Hart
t instead supported www.dell.com in OEM strings. Match both of these to indicate that this driver is running on a Dell system. Reported-by: Sergey Kubushyn <k...@koi8.net> Tested-by: Sergey Kubushyn <k...@koi8.net> Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> [dvhar

Re: [PATCH v1 4/7] platform: mellanox: add new ODM system types to mlx-platform

2018-04-13 Thread Darren Hart
ompanies can't change DMI_BOARD_NAME". Is that an assumption, or is that how ODMs work with Mellanox? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 3/7] platform/mellanox: mlxreg-hotplug: add extra cycle for hotplug work queue

2018-04-13 Thread Darren Hart
} > + if (!aggr_asserted) We seem to check aggr_asserted in several places in this routine now. Looks like something we could simplify. If you check it here, can you drop the check lower in the routine? Can you remove it from the for loop if conditional entirely? Please consider how to simplify. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 2/7] platform/mellanox: mlxreg-hotplug: Document fixes for hotplug private data

2018-04-13 Thread Darren Hart
struct regmap *regmap; > struct delayed_work dwork_irq; > - struct delayed_work dwork; > spinlock_t lock; /* sync with interrupt */ > struct device *hwmon; > struct attribute *mlxreg_hotplug_attr[MLXREG_HOTPLUG_ATTRS_MAX + 1]; > -- > 2.1.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 1/7] platform_data/mlxreg: Document fixes for hotplug device

2018-04-13 Thread Darren Hart
ccess mask; > - * @mode: access mode; > * @bit: attribute effective bit; > + * @mode: access mode; > * @np - pointer to node platform associated with attribute; > * @hpdev - hotplug device data; > * @health_cntr: dynamic device health indication counter; > -- > 2.1.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 0/7] platform/x86: Mellanox add fixes and new features

2018-04-13 Thread Darren Hart
| 66 - > 6 files changed, 765 insertions(+), 4 deletions(-) > create mode 100644 drivers/platform/mellanox/mlxreg-io.c > > -- > 2.1.4 > > -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v3 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-13 Thread Darren Hart
any kind of indicator for a PCI device if it is a removable device? Only disabling those PCI devices which are wholly integrated with the platform would be ideal. Failing that, is there an indicator in the PCI configuration which will distinguish such devices? Are the integrated devices using specific lanes, are the external devices behind a switch? etc. And can we do this in a generic way for all relevant platforms. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h

2018-04-07 Thread Darren Hart
reasonable. So I'm waiting for v3 from Kai-Heng - unless I've misunderstood the conclusion of this thread. -- Darren Hart VMware Open Source Technology Center

Re: [PATCH] platform/x86: asus-wireless: Fix NULL pointer dereference

2018-04-07 Thread Darren Hart
iff the workqueue is successfully created. It seems like it would make sense to move the devm_led_classdev_unregister() call within the 'if (data->wq)' condition block. This should also cc stable. Thanks, -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and auto detection functionalities

2018-03-23 Thread Darren Hart
On Fri, Mar 23, 2018 at 03:59:22PM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Friday, March 23, 2018 1:56 AM > > To: Vadim Pasternak <vad...@mellanox.com> &g

[PATCH] platform/x86: fujitsu-laptop: Simplify soft key handling

2018-03-22 Thread Darren Hart (VMware)
Glogowski <glo...@fbihome.de> Cc: Michał Kępień <ker...@kempniu.pl> Cc: Jonathan Woithe <jwoi...@just42.net> Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org> --- Note: this applies on top of Jan-Marek's recent RFKILL and MICMUTE hotkey patch. I'd really appreci

Re: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and auto detection functionalities

2018-03-22 Thread Darren Hart
ommit messages for the top 4 commits: http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/review-dvhart-mellanox Does this still match your intent? -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 2/4] platform/x86: mlx-platform: Add differed bus functionality

2018-03-22 Thread Darren Hart
On Thu, Mar 22, 2018 at 10:04:51AM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 21, 2018 at 03:58:18PM -0700, Darren Hart wrote: > > On Tue, Feb 13, 2018 at 10:09:34PM +, Vadim Pasternak wrote: > > > Add deferred bus functionality in order to enforce probing flow exe

Re: [PATCH] platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int

2018-03-21 Thread Darren Hart
> drivers/platform/x86/fujitsu-laptop.c:816 acpi_fujitsu_laptop_add() warn: > > impossible condition '(priv->flags_supported == (1 << (31))) => > > (0-2147483647,18446744071562067968-u64max == 2147483648)' > > > > Fixes: 819cddae7cfa ("platform/x86: fujits

Re: [PATCH 0/7] fujitsu-laptop: Consistent naming of constants

2018-03-21 Thread Darren Hart
ding - but I don't have a preference and I think overall the code is more readable for this series. Based on feedback on a couple of the patches, a respin appears to be pending, so I'm marking this series as "changes requested" and will await the v2. Thanks, -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v1 2/4] platform/x86: mlx-platform: Add differed bus functionality

2018-03-21 Thread Darren Hart
eg_core_platform_data { > * @mask: top aggregation interrupt common mask; > * @cell_low: location of low aggregation interrupt register; > * @mask_low: low aggregation interrupt common mask; > + * @deferred_nr: I2C adapter number must be exist prior probing execution; > */ > struct mlxreg_core_hotplug_platform_data { > struct mlxreg_core_item *items; > @@ -139,6 +140,7 @@ struct mlxreg_core_hotplug_platform_data { > u32 mask; > u32 cell_low; > u32 mask_low; > + int deferred_nr; > }; > > #endif /* __LINUX_PLATFORM_DATA_MLXREG_H */ > -- > 2.1.4 > > -- Darren Hart VMware Open Source Technology Center

Re: drivers/platform/x86/dell-smbios-smm.c:99: undefined reference to `dcdbas_smi_request'

2018-03-20 Thread Darren Hart
or on ACPI_WMI 32d7b19bad96 platform/x86: dell-smbios: Resolve dependency error on DCDBAS 329d58b890be platform/x86: Allow for SMBIOS backend defaults Thanks, -- Darren Hart VMware Open Source Technology Center

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Darren Hart
On Fri, Mar 16, 2018 at 07:03:53PM +, Andy Lutomirski wrote: > On Fri, Mar 16, 2018 at 6:43 PM, Darren Hart <dvh...@infradead.org> wrote: > > On Thu, Mar 15, 2018 at 08:04:56PM +0100, Dominik Brodowski wrote: > >> sys_futex() is a wrapper to do_futex() which does no

Re: [PATCH v2 03/36] mm: use do_futex() instead of sys_futex() in mm_release()

2018-03-16 Thread Darren Hart
efore, val2 is always 0. > > - as utime is set to NULL, *timeout is NULL > > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Ingo Molnar <mi...@redhat.com> > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: Darren Hart <dvh...@infradead.org> > C

[GIT PULL] platform-drivers-x86 for 4.16-7

2018-03-14 Thread Darren Hart
-smbios source to dell-smbios-base Thanks, Darren Hart VMware Open Source Technology Center The following changes since commit 32d7b19bad9695c4c9026b0ceb3a384561ddee70: platform/x86: dell-smbios: Resolve dependency error on DCDBAS (2018-03-09 09:35:46 -0800) are available in the git repository

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-14 Thread Darren Hart
On Wed, Mar 14, 2018 at 10:23:16AM -0700, Linus Torvalds wrote: > On Tue, Mar 13, 2018 at 8:34 PM, Darren Hart <dvh...@infradead.org> wrote: > > > > At RC5, we're certainly further into the RC cycle than I want to see > > these changes. So if you just want to call it

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-13 Thread Darren Hart
On Mon, Mar 12, 2018 at 04:33:11PM -0700, Darren Hart wrote: > On Mon, Mar 12, 2018 at 03:17:57PM -0700, Linus Torvalds wrote: > > On Mon, Mar 12, 2018 at 3:07 PM, Dominik Brodowski > > <li...@dominikbrodowski.net> wrote: > > > > > > I'm awfully sorry,

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-13 Thread Darren Hart
On Tue, Mar 13, 2018 at 07:07:26AM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Dominik Brodowski [mailto:li...@dominikbrodowski.net] > > Sent: Tuesday, March 13, 2018 2:44 PM > > To: Limonciello, Mario <mario_limoncie...@dell

Re: [PATCH] platform/x86: dell-smbios: fix DCDBAS dependency, better

2018-03-13 Thread Darren Hart
nds on ACPI_VIDEO || ACPI_VIDEO = n > + depends on DELL_SMBIOS > select DELL_WMI_DESCRIPTOR > - select DELL_SMBIOS > select INPUT_SPARSEKMAP > ---help--- > Say Y here if you want to support WMI-based hotkeys on Dell laptops. > -- > 2.9.0 > > -- Darren Hart VMware Open Source Technology Center

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-13 Thread Darren Hart
his order (items on the same line have no dependency): 1. DCDBAS, ACPI_WMI 2. DELL_SMBIOS, DELL_RBTN 3. DELL_LAPTOP, DELL_WMI Currently: subsys_initcall: ACPI_WMI, DELL_SMBIOS module_init: DCDBAS, DELL_WMI late_initcall: DELL_LAPTOP >From a quick naive glance, it appears as though we might be able to addres

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Darren Hart
this properly in 4.17, preferably in a way that we can apply to stable. Pending an "oops, nevermind, the patch works" from Dominik by tomorrow morning, I'll submit the pull request to revert dell-smbios changes back to and including 25d47027e10. Apologies for the noise on this one Linus, it got away from me. -- Darren Hart VMware Open Source Technology Center

[PATCH v2] platform/x86: dell-smbios: Resolve dependency error on ACPI_WMI

2018-03-12 Thread Darren Hart
cie...@dell.com> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> Cc: Dominik Brodowski <li...@dominikbrodowski.net> Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org> --- Since v1: Split depends line into two per Andy Shevchenko's feedback drivers/platform/x86/Kco

Re: [PATCH] platform/x86: dell_smbios: Resolve dependency error on ACPI_WMI

2018-03-12 Thread Darren Hart
On Mon, Mar 12, 2018 at 11:23:20AM +0200, Andy Shevchenko wrote: > On Sun, Mar 11, 2018 at 2:28 AM, Darren Hart <dvh...@infradead.org> wrote: > > Similarly to DCDBAS for DELL_SMBIOS_SMM, if DELL_SMBIOS_WMI is enabled, > > DELL_SMBIOS becomes dependent on ACPI_WMI. Up

Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Darren Hart
IOS_WMI is not set > > Any ideas? We're working on a dependency fix, but I think the problem you have here is likely to be ACPI_WMI=m instead of =y while you have DELL_SMBIOS=y The fix won't allow that configuration. I'll include you in Cc of v2 of that fix which I'll send shortly. -- Darren Hart VMware Open Source Technology Center

[PATCH] platform/x86: dell_smbios: Resolve dependency error on ACPI_WMI

2018-03-10 Thread Darren Hart
cie...@dell.com> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org> --- Linus, just a heads up on this. Unlikely you would encounter this in your builds, but just in case, I wanted you to know we (0-day) caught it and are

[GIT PULL] platform-drivers-x86 for 4.16-6

2018-03-09 Thread Darren Hart
at: git://git.infradead.org/linux-platform-drivers-x86.git tags/platform-drivers-x86-v4.16-6 for you to fetch changes up to 32d7b19bad9695c4c9026b0ceb3a384561ddee70: platform/x86: dell-smbios: Resolve dependency error on DCDBAS (2018-03-09 09:35:46 -0800) Thanks, Darren Hart VMware Open

Re: [PATCH AUTOSEL for 4.9 025/190] platform/x86: asus-nb-wmi: Add wapf4 quirk for the X302UA

2018-03-08 Thread Darren Hart
On Thu, Mar 08, 2018 at 06:15:27PM +, Sasha Levin wrote: > On Thu, Mar 08, 2018 at 09:47:54AM -0800, Greg KH wrote: > >On Thu, Mar 08, 2018 at 09:39:14AM -0800, Darren Hart wrote: > >> On Thu, Mar 08, 2018 at 04:59:01AM +, Sasha Levin wrote: > >> > From: S

Re: [PATCH AUTOSEL for 4.9 025/190] platform/x86: asus-nb-wmi: Add wapf4 quirk for the X302UA

2018-03-08 Thread Darren Hart
apf=4 to fix the problem. > > Signed-off-by: Santeri Toivonen <santeri.toivo...@vatsul.com> > Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org> > Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> Hi Sasha, I'm curious about this AUTOSEL tag, and w

Re: [PATCH v2] selftests: futex Makefile add top level TAP header echo to RUN_TESTS

2018-03-05 Thread Darren Hart
ers could cause problems for some parsers. > > Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Reviewed-by: Darren Hart (VMware) <dvh...@infradead.org> -- Darren Hart VMware Open Source Technology Center

  1   2   3   4   5   6   7   8   9   10   >