Re: [PATCH] net: stmmac: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread David Miller
From: Yangtao Li Date: Mon, 3 Dec 2018 09:22:09 -0500 > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Applied.

[GIT] IDE

2018-12-02 Thread David Miller
A missing of_node_put() and a small cleanup. Please pull, thanks! The following changes since commit 2595646791c319cadfdbf271563aac97d0843dc7: Linux 4.20-rc5 (2018-12-02 15:07:55 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide.git

Re: [PATCH] Malformatted switch statment

2018-12-02 Thread David Miller
From: Joris Gutjahr Date: Sun, 28 Oct 2018 17:45:46 +0100 > I fixed this coding style error I got after running > checkpatch --file on this file. > The problem was that the whole case block was on one line. > > Signed-off-by: Joris Gutjahr Frankly I think the existing code is more compact and

[GIT] Sparc

2018-12-02 Thread David Miller
1) Some implicit switch fallthrough fixes from Stephen Rothwell. 2) Missing of_node_put() in various sparc drivers from Yangtao Li. Please pull, thanks! The following changes since commit 25e19c1fe421280a47f37c3571aa379e6e67966c: Merge tag 'libnvdimm-fixes-4.20-rc3' of

Re: [PATCH] serial/sunsu: add missing of_node_put()

2018-12-02 Thread David Miller
From: Yangtao Li Date: Wed, 21 Nov 2018 11:06:15 -0500 > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > This place is not doing this, so fix it. > > Signed-off-by: Yangtao Li Several coding style problems and

Re: [PATCH] sbus: char: add of_node_put()

2018-12-02 Thread David Miller
From: Yangtao Li Date: Tue, 20 Nov 2018 08:30:40 -0500 > use of_node_put() to release the refcount. > > Signed-off-by: Yangtao Li Applied.

Re: [PATCH] drivers/tty: add missing of_node_put()

2018-12-02 Thread David Miller
From: Yangtao Li Date: Wed, 21 Nov 2018 10:22:54 -0500 > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > This place is not doing this, so fix it. > > Signed-off-by: Yangtao Li Applied.

Re: [PATCH] drivers/sbus/char: add of_node_put()

2018-12-02 Thread David Miller
From: Yangtao Li Date: Tue, 20 Nov 2018 08:38:26 -0500 > use of_node_put() to release the refcount. > > Signed-off-by: Yangtao Li Applied.

Re: [PATCH 2/3] net/x25: fix null_x25_address handling

2018-11-29 Thread David Miller
From: Martin Schiller Date: Tue, 27 Nov 2018 09:50:28 +0100 > o x25_find_listener(): the compare for the null_x25_address was wrong. >We have to check the x25_addr of the listener socket instead of the >x25_addr of the incomming call. > > o x25_bind(): it was not possible to bind a

Re: [PATCH 12/27] net/core: Assign a name to devnet_rename_seq.dep_map

2018-11-28 Thread David Miller
From: Bart Van Assche Date: Wed, 28 Nov 2018 15:43:10 -0800 > This patch makes lockdep reports about devnet_rename_seq more informative. > > Cc: David S. Miller > Signed-off-by: Bart Van Assche Acked-by: David S. Miller

Re: [PATCH] amd-xgbe: set skb to NULL after freeing it

2018-11-28 Thread David Miller
From: Pan Bian Date: Wed, 28 Nov 2018 16:09:45 +0800 > @@ -2754,6 +2754,7 @@ static int xgbe_rx_poll(struct xgbe_channel *channel, > int budget) > netif_err(pdata, rx_err, netdev, > "error in received packet\n"); >

Re: [PATCH] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

2018-11-20 Thread David Miller
aFrom: Vincent Chen Date: Tue, 20 Nov 2018 13:37:46 +0800 > + /* Disable interrupts for polling */ > + ftmac100_disable_all_int(priv); > if (likely(netif_running(netdev))) { > - /* Disable interrupts for polling */ > - ftmac100_disable_all_int(priv); >

Re: [PATCH 00/12] perf top: Rework processing code

2018-11-19 Thread David Miller
From: Jiri Olsa Date: Mon, 19 Nov 2018 13:20:04 +0100 > David reported issues with perf top loosing side band events > so we moved mmap reading and hists processing into separated > threads. > > This patchset also adds dropping sample logic when the processing > falls behind the reader thread.

Re: [PATCH RFC] hist lookups

2018-11-18 Thread David Miller
From: Namhyung Kim Date: Mon, 19 Nov 2018 15:28:37 +0900 > Hello David, > > On Sun, Nov 18, 2018 at 08:52:43PM -0800, David Miller wrote: >> From: Jiri Olsa >> Date: Tue, 13 Nov 2018 11:40:54 +0100 >> >> > I pushed/rebased what I have to perf/fixes branc

Re: [PATCH RFC] hist lookups

2018-11-18 Thread David Miller
From: Jiri Olsa Date: Tue, 13 Nov 2018 11:40:54 +0100 > I pushed/rebased what I have to perf/fixes branch again > > please note I had to change our compile changes, because > they wouldn't compile on x86, but I can't verify on sparc, > so you might see some compile fails again I just checked

Re: [PATCH] rhashtable: detect when object movement between tables might have invalidated a lookup

2018-11-18 Thread David Miller
From: Herbert Xu Date: Mon, 19 Nov 2018 12:06:34 +0800 > On Mon, Nov 19, 2018 at 11:56:35AM +0800, Herbert Xu wrote: >> >> I take that back. Because of your shift which cancels out the >> shift in NULLS_MARKER, it would appear that this should work just >> fine with RHT_NULLS_MARRKER(0), no?

[GIT] Networking

2018-11-18 Thread David Miller
1) Fix some potentially uninitialized variables and use-after-free in kvaser_usb can drier, from Jimmy Assarsson. 2) Fix leaks in qed driver, from Denis Bolotin. 3) Socket leak in l2tp, from Xin Long. 4) RSS context allocation fix in bnxt_en from Michael Chan. 5) Fix cxgb4 build errors,

Re: [PATCH] arch/sparc: Use kzalloc_node

2018-11-18 Thread David Miller
From: Sabyasachi Gupta Date: Sat, 3 Nov 2018 10:54:52 +0530 > Replaced kmalloc_node + memset with kzalloc_node > > Signed-off-by: Sabyasachi Gupta Applied.

Re: [PATCH v3 0/4] sparc: system call table generation support

2018-11-18 Thread David Miller
From: Firoz Khan Date: Wed, 14 Nov 2018 10:56:27 +0530 > The purpose of this patch series is, we can easily > add/modify/delete system call table support by cha- > nging entry in syscall.tbl file instead of manually > changing many files. The other goal is to unify the > system call table

Re: [PATCH] arch/sparc: Use kzalloc_node

2018-11-15 Thread David Miller
From: Sabyasachi Gupta Date: Thu, 15 Nov 2018 23:23:42 +0530 > On Sat, Nov 3, 2018 at 10:54 AM Sabyasachi Gupta > wrote: >> >> Replaced kmalloc_node + memset with kzalloc_node >> >> Signed-off-by: Sabyasachi Gupta > > Any comment on this patch? Just too busy to get to it and am at plumbers

Re: [PATCH RFC] hist lookups

2018-11-11 Thread David Miller
From: Jiri Olsa Date: Mon, 12 Nov 2018 00:26:27 +0100 > On Sun, Nov 11, 2018 at 03:08:01PM -0800, David Miller wrote: >> From: Jiri Olsa >> Date: Sun, 11 Nov 2018 20:41:32 +0100 >> >> > On Thu, Nov 08, 2018 at 05:07:21PM -0800, David Miller wrote: >> >&g

Re: [PATCH RFC] hist lookups

2018-11-11 Thread David Miller
From: Jiri Olsa Date: Sun, 11 Nov 2018 20:41:32 +0100 > I added the dropping logic, it's simple so far.. How do you maintain your perf/fixes branch? Do you rebase? :-/ I just pulled after a previous pull and got nothing but conflicts on every single file.

Re: [PATCH RFC] hist lookups

2018-11-11 Thread David Miller
From: Jiri Olsa Date: Sun, 11 Nov 2018 20:41:32 +0100 > On Thu, Nov 08, 2018 at 05:07:21PM -0800, David Miller wrote: >> From: Jiri Olsa >> Date: Thu, 8 Nov 2018 08:13:03 +0100 >> >> > we could separated fork/mmaps to separate dummy event map, or just >>

Re: [PATCH RFC] hist lookups

2018-11-11 Thread David Miller
From: Jiri Olsa Date: Sun, 11 Nov 2018 23:43:36 +0100 > On Sun, Nov 11, 2018 at 02:32:08PM -0800, David Miller wrote: >> From: Jiri Olsa >> Date: Sun, 11 Nov 2018 20:41:32 +0100 >> >> > I added the dropping logic, it's simple so far.. >> >> How do yo

Re: [PATCH 2/8] of: Drop full path from Sparc PDT full_name

2018-11-09 Thread David Miller
From: Rob Herring Date: Fri, 9 Nov 2018 14:30:01 -0600 > That is the intent. With this change we stop storing the full path for > every node. Everywhere that needs the full path, generates it with the > %pOF printf specifier. Other than users in arch/sparc converted in > this series all the

Re: [PATCH 3/8] sparc: prom: use property "name" directly to construct node names

2018-11-09 Thread David Miller
From: Rob Herring Date: Fri, 9 Nov 2018 07:02:46 -0600 > On Thu, Nov 8, 2018 at 9:13 PM David Miller wrote: >> >> From: Rob Herring >> Date: Wed, 7 Nov 2018 16:31:46 -0600 >> >> > In preparation to remove direct accesses to the device_node.name >&

Re: [PATCH 3/8] sparc: prom: use property "name" directly to construct node names

2018-11-08 Thread David Miller
From: Rob Herring Date: Wed, 7 Nov 2018 16:31:46 -0600 > In preparation to remove direct accesses to the device_node.name > pointer, retrieve the node name from the "name" property instead. > > Cc: "David S. Miller" > Cc: sparcli...@vger.kernel.org > Signed-off-by: Rob Herring On some

Re: [PATCH 2/8] of: Drop full path from Sparc PDT full_name

2018-11-08 Thread David Miller
From: Rob Herring Date: Wed, 7 Nov 2018 16:31:45 -0600 > @@ -32,24 +32,7 @@ unsigned int of_pdt_unique_id __initdata; > > static char * __init of_pdt_build_full_name(struct device_node *dp) > { > - int len, ourlen, plen; > - char *n; > - > - dp->path_component_name =

Re: [PATCH RFC] hist lookups

2018-11-08 Thread David Miller
From: Jiri Olsa Date: Thu, 8 Nov 2018 08:13:03 +0100 > we could separated fork/mmaps to separate dummy event map, or just > parse them out in the read thread and create special queue for them > and drop just samples in case we are behind What you say at the end here is basically what I am

Re: [PATCH] dpaa_eth: add ethtool coalesce control

2018-11-07 Thread David Miller
From: Madalin Bucur Date: Wed, 7 Nov 2018 15:53:43 +0200 > +static int dpaa_set_coalesce(struct net_device *dev, > + struct ethtool_coalesce *c) > +{ > + const cpumask_t *cpus = qman_affine_cpus(); > + struct qman_portal *portal; > + u32 period; > + u8

Re: [PATCH RFC] hist lookups

2018-11-07 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Wed, 7 Nov 2018 17:28:15 -0300 > So perhaps we should tell the kernel that is ok to lose SAMPLEs but not > the other events, and make userspace ask for PERF_RECORD_!SAMPLE in all > ring buffers? Duplication wouldn't be that much of a problem? I think we

Re: [PATCH RFC] hist lookups

2018-11-07 Thread David Miller
From: Jiri Olsa Date: Wed, 7 Nov 2018 20:43:44 +0100 > I pushed new version in my perf/fixes branch Thanks, I'll check it out later today for sure! This is pretty exciting work. Just some random thoughts as I've been thinking about this whole situation a lot lately: Something to consider

Re: [PATCH RFC] hist lookups

2018-11-06 Thread David Miller
From: Jiri Olsa Date: Tue, 6 Nov 2018 21:42:55 +0100 > I pushed that fix in perf/fixes branch, but I'm still occasionaly > hitting the namespace crash.. working on it ;-) Jiri, how can this new scheme work without setting copy_on_queue for the queued_events we use here? I don't see

Re: [PATCH V2 1/3] perf tools: Add fallback functions for cases where cpumode is insufficient

2018-11-06 Thread David Miller
From: Adrian Hunter Date: Tue, 6 Nov 2018 23:07:10 +0200 > For branch stacks or branch samples, the sample cpumode might not be > correct because it applies only to the sample 'ip' and not necessary to > 'addr' or branch stack addresses. Add fallback functions that can be used > to deal with

Re: [PATCH v2] ISDN: eicon: Remove driver

2018-11-06 Thread David Miller
From: Olof Johansson Date: Fri, 2 Nov 2018 15:00:26 -0700 > I started looking at the history of this driver, and last time the > maintainer was active on the mailing list was when discussing how to > remove it. This was in 2012: > > https://lore.kernel.org/lkml/4f4de175.30...@melware.de/ > >

Re: [PATCH RFC] hist lookups

2018-11-05 Thread David Miller
Jiri, Because you now run queued_events__queue() lockless with that condvar trick, it is possible for top->qe.in to be seen as one past the data[] array, this is because the rotate_queues() code goes: if (++top->qe.in > >qe.data[1]) top->qe.in = >qe.data[0]; So for a

Re: [PATCH RFC] hist lookups

2018-11-05 Thread David Miller
From: David Miller Date: Mon, 05 Nov 2018 19:45:42 -0800 (PST) > Build fix for sparc below, I'm playing with this now. I get various assertion failures and crashes during make -j128 kernel builds on my sparc64 box: perf: Segmentation fault backtrace /

Re: [PATCH RFC] hist lookups

2018-11-05 Thread David Miller
From: Jiri Olsa Date: Mon, 5 Nov 2018 21:34:47 +0100 > I pushed it in perf/fixes branch in: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git Build fix for sparc below, I'm playing with this now. perf: Use PRIu64 for printing top lost events count. Signed-off-by: David S.

Re: [PATCH RFC] hist lookups

2018-11-05 Thread David Miller
From: Jiri Olsa Date: Mon, 5 Nov 2018 21:34:47 +0100 > I put something together.. still testing, but it's already > showing 0 lost events when for 'overwrite = 0' case even > for high load.. the old code shows ~1500 for same workload > > I'm printing lost event counts in stdio output header: >

Re: [PATCH 1/5] perf tools: Add fallback functions for cases where cpumode is insufficient

2018-11-05 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Mon, 5 Nov 2018 14:29:46 -0300 >> @@ -2542,6 +2542,46 @@ int machine__get_kernel_start(struct machine *machine) >> return err; >> } >> >> +/* >> + * machine__single_ku_as - Machine has same address space for kernel and >> user. >> + * @machine:

Re: [PATCH RFC] hist lookups

2018-11-04 Thread David Miller
From: Jiri Olsa Date: Sun, 4 Nov 2018 21:18:21 +0100 > do you have some code I could check on? All I have is this patch which parallelizes the mmap readers in perf top. It's not complete and you need to add proper locking, particularly around the machine__resolve() call. diff --git

Re: [PATCH] net: skbuff.h: remove unnecessary unlikely()

2018-11-04 Thread David Miller
Networking patches must be submitted to net...@vger.kernel.org Thank you.

Re: [PATCH RFC] hist lookups

2018-11-03 Thread David Miller
From: David Miller Date: Wed, 31 Oct 2018 09:08:16 -0700 (PDT) > From: Jiri Olsa > Date: Wed, 31 Oct 2018 16:39:07 +0100 > >> it'd be great to make hist processing faster, but is your main target here >> to get the load out of the reader thread, so we dont lose even

[PATCH] perf: Remove strchr() in map__process_kallsyms_symbol().

2018-11-03 Thread David Miller
This is looking for '[vdso]', '[vsyscall]' or similar to force the "kernel" boolean arg to __symbols__insert() to false. But such things never show up in kallsyms. This check was added by commit 608c34de0b3d ("perf symbols: Mark if a symbol is idle in the library") Signed-off-by: David S.

Re: [PATCH v2 3/4] sparc: add system call table generation support

2018-11-01 Thread David Miller
From: Firoz Khan Date: Thu, 1 Nov 2018 19:23:10 +0530 > +141 common getpeername sys_getpeername > sys_nis_syscall ... > +150 common getsockname sys_getsockname > sys_nis_syscall The sys_nis_syscall in these two entries is

PLEASE READ: kernelci.org bot email problems

2018-11-01 Thread David Miller
The b...@kernelci.org emails are being bounced by vger.kernel.org The reason is that there are always syntax errors in the SMTP headers. Specifical, the From address is: From: kernelci.orgbot By SMTP rules, when special characters such a '.' appear in headers, the string must be

[GIT] Sparc

2018-10-31 Thread David Miller
Two small fixes, please pull. Thanks! The following changes since commit 4b42745211af552f170f38a1b97f4a112b5da6b2: Merge tag 'armsoc-soc' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2018-10-29 15:37:33 -0700) are available in the Git repository at:

[tip:perf/urgent] perf tools: Don't clone maps from parent when synthesizing forks

2018-10-31 Thread tip-bot for David Miller
Commit-ID: 4f8f382e635707ddaddf8269a116e4f8cc8835c0 Gitweb: https://git.kernel.org/tip/4f8f382e635707ddaddf8269a116e4f8cc8835c0 Author: David Miller AuthorDate: Tue, 30 Oct 2018 22:24:04 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 31 Oct 2018 10:18:01 -0300 perf tools

[tip:perf/urgent] perf top: Start display thread earlier

2018-10-31 Thread tip-bot for David Miller
Commit-ID: ff27a06af6ffd3f49b9e193eb68f487ad76651e1 Gitweb: https://git.kernel.org/tip/ff27a06af6ffd3f49b9e193eb68f487ad76651e1 Author: David Miller AuthorDate: Tue, 30 Oct 2018 22:30:03 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 31 Oct 2018 10:10:11 -0300 perf top

Re: [PATCH RFC] hist lookups

2018-10-31 Thread David Miller
From: Jiri Olsa Date: Wed, 31 Oct 2018 16:39:07 +0100 > it'd be great to make hist processing faster, but is your main target here > to get the load out of the reader thread, so we dont lose events during the > hist processing? > > we could queue events directly from reader thread into another

[PATCH RFC] perf: Go back to by-hand proc mmap parsing and kill timeout

2018-10-30 Thread David Miller
This goes back to by-hand parsing of the proc mmap file, and removes the timeout. In my measurements this makes the parsing about twice as fast. Profiling thread synthesizing shows that most of the time is spent in the sscanf() call. Processing samples is critical for perf top and perf record

[PATCH RFC] perf: Start 'top' display thread earlier.

2018-10-30 Thread David Miller
If events are coming in at a rate such that the event processing thread can barely keep up, our initial run of the event ring will almost never terminate and this delays the starting of the display thread. The screen basically stays black until the event thread can get out of it's endless loop.

[PATCH] perf: Don't clone maps from parent when synthesizing forks

2018-10-30 Thread David Miller
When synthesizing FORK events, we are trying to create thread objects for the already running tasks on the machine. Normally, for a kernel FORK event, we want to clone the parent's maps because that is what the kernel just did. But when synthesizing, this should not be done. If we do, we end

[PATCH RFC] hist lookups

2018-10-30 Thread David Miller
So when a cpu is overpowered processing samples, most of the time is spent in the histogram code. It seems we initialize a ~262 byte structure on the stack to do every histogram entry lookup. This is a side effect of how the sorting code is shared with the code that does lookups and insertions

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-30 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 10:33:06 -0400 > The problem is that users have to wait tens of minutes to see perf > top results on the screen in KNL. Before that, there is nothing but > a black screen. I'm actually curious why so I started digging last night. First, I made perf top

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 18:32:40 -0400 > - struct annotation_options *annotation_options > __maybe_unused) > + struct annotation_options *annotation_options __maybe_unused, > + atomic_t *nr_rb_read __maybe_unused) >

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 14:20:15 -0400 > You didn't see any warning before the patch. I think it is just > because perf top hides the problem. Quite honestly, the last time I played around with this: 1) The new ring buffer mode didn't exist 2) perf started up much more

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 13:42:56 -0400 > > > On 10/29/2018 1:40 PM, David Miller wrote: >> From: "Liang, Kan" >> Date: Mon, 29 Oct 2018 10:33:06 -0400 >> >>> I just realized that the problem in KNL will be back if

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 11:11:25 -0400 > The processing time for each perf_top__mmap_read_idx() should not that > long. We may check it after each perf_top__mmap_read_idx(). Also > change the ui_warning to one-time warning. The patch as below can do > that (not test). You

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-29 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 10:33:06 -0400 > I just realized that the problem in KNL will be back if we switch > back to non-overwrite mode. What is KNL?

[GIT] Networking

2018-10-28 Thread David Miller
1) GRO overflow entries are not unlinked properly, resulting in list poison pointers being dereferenced. 2) Fix bridge build with ipv6 disabled, from Nikolay Aleksandrov. 3) Direct packet access and other fixes in BPF from Daniel Borkmann. 4) gred_change_table_def() gets passed the wrong

Re: [PATCH] ptp: drop redundant kasprintf() to create worker name

2018-10-28 Thread David Miller
From: Rasmus Villemoes Date: Fri, 26 Oct 2018 23:22:59 +0200 > Building with -Wformat-nonliteral, gcc complains > > drivers/ptp/ptp_clock.c: In function ‘ptp_clock_register’: > drivers/ptp/ptp_clock.c:239:26: warning: format not a string literal and no > format arguments [-Wformat-nonliteral]

Re: linux-next: build failure in Linus' tree

2018-10-28 Thread David Miller
From: Linus Torvalds Date: Sun, 28 Oct 2018 15:45:16 -0700 > On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell > wrote: >> >> After merging the origin tree, today's linux-next build (powerpc >> ppc64_defconfig) failed like this: > > linux-next is back! Wheee.. > >> 5a2de63fd1a5 ("bridge: do

perf synthesized mmap timeouts

2018-10-27 Thread David Miller
If I understand the commit message for: commit 8cc42de736b617827a4e7664fb8d7a325bc125bc Author: Kan Liang Date: Thu Jan 18 13:26:32 2018 -0800 perf top: Check the latency of perf_top__mmap_read() properly, the problem is that a malicious or out of control app can be doing endless mmaps

UI messages in event thread hangs perf top

2018-10-27 Thread David Miller
If I run perf top with a "make -j128" kernel build, I get ring buffer event processing timeouts which results in: ui__warning("Too slow to read ring buffer.\n" "Please try increasing the period (-c) or\n" "decreasing the

[GIT] Sparc

2018-10-26 Thread David Miller
) David Miller (1): sparc64: Make corrupted user stacks more debuggable. David S. Miller (2): sparc64: Export __node_distance. sparc64: Rework xchg() definition to avoid warnings. arch/sparc/include/asm/cmpxchg_64.h | 7 ++- arch/sparc/include/asm/switch_to_64.h | 3

A concern about overflow ring buffer mode

2018-10-26 Thread David Miller
Since the last time I looked deeply into perf I notice that perf top now uses a new ring buffer mode by default. Basically, events are written in reverse order, and when fetching events the tool uses an ioctl to "pause" the ring buffer. I understand some of the reasons for pursing this kind of

[tip:perf/urgent] perf symbols: Set PLT entry/header sizes properly on Sparc

2018-10-26 Thread tip-bot for David Miller
Commit-ID: d6afa561e1471ccfdaf7191230c0c59a37e45a5b Gitweb: https://git.kernel.org/tip/d6afa561e1471ccfdaf7191230c0c59a37e45a5b Author: David Miller AuthorDate: Wed, 17 Oct 2018 12:08:59 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 18 Oct 2018 11:19:44 -0300 perf symbols

[tip:perf/urgent] perf annotate: Add Sparc support

2018-10-26 Thread tip-bot for David Miller
Commit-ID: 0ab41886648bb75b951bd41d8b5cecaca8e0ad66 Gitweb: https://git.kernel.org/tip/0ab41886648bb75b951bd41d8b5cecaca8e0ad66 Author: David Miller AuthorDate: Tue, 16 Oct 2018 20:55:55 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 18 Oct 2018 11:16:38 -0300 perf

[tip:perf/urgent] perf jitdump: Add Sparc support.

2018-10-26 Thread tip-bot for David Miller
Commit-ID: d87b9790b3deb7601872d34fd05af3da78147583 Gitweb: https://git.kernel.org/tip/d87b9790b3deb7601872d34fd05af3da78147583 Author: David Miller AuthorDate: Tue, 16 Oct 2018 21:15:45 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 18 Oct 2018 11:16:38 -0300 perf jitdump

[GIT] Sparc

2018-10-25 Thread David Miller
Please pull to get this build regression fix. Thank you. The following changes since commit 44adbac8f7217040be97928cd19998259d9d4418: Merge branch 'work.tty-ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs (2018-10-24 14:43:41 +0100) are available in the Git repository

Re: perf overlapping maps...

2018-10-24 Thread David Miller
From: Jiri Olsa Date: Wed, 24 Oct 2018 13:34:16 +0200 > On Tue, Oct 23, 2018 at 11:15:03AM -0700, David Miller wrote: >> From: Arnaldo Carvalho de Melo >> Date: Tue, 23 Oct 2018 15:05:03 -0300 >> >> > IIRC this was first done for 'perf record', where we h

[GIT] Sparc

2018-10-23 Thread David Miller
Mostly VDSO cleanups and optimizations. Please pull, thanks a lot! The following changes since commit 91b15613ce7fb3e724ca0d433eef8e6bf15322af: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2018-10-19 09:16:20 +0200) are available in the Git repository at:

Re: perf overlapping maps...

2018-10-23 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Tue, 23 Oct 2018 15:05:03 -0300 > IIRC this was first done for 'perf record', where we have to stash those > events in the perf.data file, to then, later, 'perf report' to process > those, so when working on 'perf top', it just reuses that machinery. > >

Re: [PATCH] bonding:avoid repeated display of same link status change

2018-10-23 Thread David Miller
From: mk.si...@oracle.com Date: Tue, 23 Oct 2018 20:59:24 +0530 > @@ -229,6 +229,7 @@ struct bonding { > struct dentry *debug_dir; > #endif /* CONFIG_DEBUG_FS */ > struct rtnl_link_stats64 bond_stats; > + atomic_t rtnl_needed; As mentioned by others, if the only operations you

Re: [PATCH] Revert "be2net: remove desc field from be_eq_obj"

2018-10-23 Thread David Miller
From: Ivan Vecera Date: Tue, 23 Oct 2018 16:40:26 +0200 > The mentioned commit needs to be reverted because we cannot pass > string allocated on stack to request_irq(). This function stores > uses this pointer for later use (e.g. /proc/interrupts) so we need > to keep this string persistently. >

Re: perf overlapping maps...

2018-10-23 Thread David Miller
From: Jiri Olsa Date: Tue, 23 Oct 2018 08:34:52 +0200 > I'm not sure about using the misc field bit defined/used by userland, > in case there's some new one comming in future for fork event.. > > but the only other way I can think of now is adding new 'user' event > for that, but that ended up

Re: [PATCH v2 net-next] net: ethernet: ti: cpsw: unsync mcast entries while switch promisc mode

2018-10-22 Thread David Miller
From: Ivan Khoronzhuk Date: Mon, 22 Oct 2018 21:51:36 +0300 > After flushing all mcast entries from the table, the ones contained in > mc list of ndev are not restored when promisc mode is toggled off, > because they are considered as synched with ALE, thus, in order to > restore them after

Re: perf overlapping maps...

2018-10-22 Thread David Miller
From: Jiri Olsa Date: Mon, 22 Oct 2018 18:16:13 +0200 > I think the fix might actualy speed things up, > but yes, there could be other report regressions I was about to say the same thing, it could actually speed things up. In the best case, less work is done (clone avoided, and overlapping

perf handling of unknown symbols...

2018-10-20 Thread David Miller
I was able to, I think, track down why I get unknown symbols with perf top. It happens for processes that start up while perf is running. It's due to races if a process changes it's address space really quickly while perf is processing all of the events. If we are probing procfs and/or sysfs

Re: perf overlapping maps...

2018-10-19 Thread David Miller
From: David Miller Date: Fri, 19 Oct 2018 21:05:49 -0700 (PDT) > One solution I've come up with is: > > 1) When synthesizing a fork event, set PERF_RECORD_MISC_COMM_EXEC in >header->misc. > > 2) Use this to elide the map groups clone in >thread__clone_map_grou

perf overlapping maps...

2018-10-19 Thread David Miller
Symbols aren't exactly right all the time on sparc and even the owner of a sample is set to "unknown" from time to time so I turned on some debugging to investigate. One thing that stands out is that we get overlapping maps all the time. So I tried to narrow down how this happens. Here is one

[GIT] Sparc

2018-10-18 Thread David Miller
The main bit here is fixing how fallback system calls are handled in the sparc vDSO. Unfortunately, I fat fingered the commit and some perf debugging hacks slipped into the vDSO fix, which I revert in the very next commit. Please pull, thanks a lot! The following changes since commit

[tip:perf/urgent] perf cpu_map: Align cpu map synthesized events properly.

2018-10-18 Thread tip-bot for David Miller
Commit-ID: 0ed149cf5239cc6e7e65bf00f769e8f1e91076c0 Gitweb: https://git.kernel.org/tip/0ed149cf5239cc6e7e65bf00f769e8f1e91076c0 Author: David Miller AuthorDate: Thu, 11 Oct 2018 22:46:55 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 16 Oct 2018 12:30:03 -0300 perf cpu_map

[PATCH] perf: Set PLT entry/header sizes properly on Sparc.

2018-10-17 Thread David Miller
Using the sh_entsize for both values isn't correct. It happens to be correct on x86... For both 32-bit and 64-bit sparc, there are four PLT entries in the PLT section. Signed-off-by: David S. Miller --- tools/perf/util/symbol-elf.c | 12 +++- 1 file changed, 11 insertions(+), 1

Re: [PATCH] perf: Add Sparc annotate support.

2018-10-17 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Wed, 17 Oct 2018 09:39:02 -0300 > Em Tue, Oct 16, 2018 at 08:55:55PM -0700, David Miller escreveu: > > Great! > > Could you try something like: > > # perf record some_workload > # perf annotate --stdio2 hot_function > >

[PATCH] perf: Add Sparc jitdump support.

2018-10-16 Thread David Miller
Signed-off-by: David S. Miller --- tools/perf/arch/sparc/Makefile | 2 ++ tools/perf/util/genelf.h | 6 ++ 2 files changed, 8 insertions(+) diff --git a/tools/perf/arch/sparc/Makefile b/tools/perf/arch/sparc/Makefile index 7fbca175099e..275dea7ff59a 100644 ---

[PATCH] perf: Add Sparc annotate support.

2018-10-16 Thread David Miller
Signed-off-by: David S. Miller --- tools/perf/arch/sparc/annotate/instructions.c | 169 ++ tools/perf/util/annotate.c| 8 + 2 files changed, 177 insertions(+) create mode 100644 tools/perf/arch/sparc/annotate/instructions.c diff --git

Re: perf's handling of unfindable user symbols...

2018-10-16 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Tue, 16 Oct 2018 15:45:06 -0300 > Exec summary: yeah, drop that hack, I agree, patch at the end of the > message. > > So, I thought something had changed and in the past we would somehow > find that address in the kallsyms, but I couldn't find anything to

Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-16 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 16 Oct 2018 10:49:36 +0200 > Hi, > > On 10/10/18 10:34 AM, Quentin Schulz wrote: >> Hi Gustavo, >> >> On Wed, Oct 10, 2018 at 10:31:39AM +0200, Gustavo A. R. Silva wrote: >>> In case memory resources for *fw* were successfully allocated, >>> release them

Re: [PATCH net] r8169: Enable MSI-X on RTL8106e

2018-10-15 Thread David Miller
From: Jian-Hong Pan Date: Mon, 15 Oct 2018 16:51:12 +0800 > 2018-10-02 13:57 GMT+08:00 Jian-Hong Pan : >> David Miller 於 2018年10月2日 週二 下午1:51寫道: >>> >>> From: Jian-Hong Pan >>> Date: Thu, 27 Sep 2018 12:09:48 +0800 >>> >>> > However, the

[GIT] Sparc

2018-10-15 Thread David Miller
1) Revert the %pOF change, it causes regressions. 2) Wire up io_pgetevents(). 3) Fix perf events on single-PCR sparc64 cpus. 4) Do proper perf event throttling like arm and x86. Please pull, thanks a lot! The following changes since commit 0854ba5ff5c938307cd783e996b62c83f1ce923b: Merge

Re: perf's handling of unfindable user symbols...

2018-10-15 Thread David Miller
From: Arnaldo Carvalho de Melo Date: Mon, 15 Oct 2018 19:25:46 -0300 > But I think we should have it as a property of 'struct machine', because we > may > be processing on, say, x86, a perf.data file recorded on a Sparc machine, so > we > need to save this property on the perf.data file, humm,

Re: net: dsa: b53: Keep CPU port as tagged in all VLANs - merge request

2018-10-15 Thread David Miller
From: Gerhard Wiesinger Date: Mon, 15 Oct 2018 07:08:53 +0200 > Hello David, > > The dsa b53 net driver is broken since 4.15 kernels. This patch hasn't > been merged into 4.18.latest yet (is already in net.git). Can you > please integrate it in 4.18.15. > >

perf's handling of unfindable user symbols...

2018-10-14 Thread David Miller
Perf has this hack where it uses the kernel symbol map as a backup when a symbol can't be found in the user's symbol table(s). This causes problems because the tests driving this code path use machine__kernel_ip(), and that is completely meaningless on Sparc. On sparc64 the kernel and user

Re: [PATCH v2 2/2] mm: speed up mremap by 500x on large regions

2018-10-12 Thread David Miller
From: "Kirill A. Shutemov" Date: Fri, 12 Oct 2018 14:30:56 +0300 > I looked into the code more and noticed move_pte() helper called from > move_ptes(). It changes PTE entry to suite new address. > > It is only defined in non-trivial way on Sparc. I don't know much about > Sparc and it's hard

[PATCH] perf: Align cpu map events properly.

2018-10-11 Thread David Miller
The size of the resulting cpu map can be smaller than a multiple of sizeof(u64), resulting in SIGBUS on cpus like Sparc as the next event will not be aligned properly. Fixes: 6c872901af07 ("perf cpu_map: Add cpu_map event synthesize function") Signed-off-by: David S. Miller diff --git

Re: [PATCH net-next 0/4] Adds support of RSS to HNS3 Driver for Rev 2(=0x21) H/W

2018-10-10 Thread David Miller
From: Salil Mehta Date: Wed, 10 Oct 2018 20:05:33 +0100 > This patch-set mainly adds new additions related to RSS for the new > hardware Revision 0x21. It also adds support to use RSS hash value > provided by the hardware along with descriptor. Series applied.

Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check in serdes_probe()

2018-10-10 Thread David Miller
From: Wei Yongjun Date: Wed, 10 Oct 2018 02:00:24 + > In case of error, the function syscon_node_to_regmap() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot

Re: fore200e DMA cleanups and fixes

2018-10-10 Thread David Miller
From: Christoph Hellwig Date: Tue, 9 Oct 2018 16:57:13 +0200 > The fore200e driver came up during some dma-related audits, so > here is the fallout. Compile tested (x86 & sparc) only. Series applied to net-next.

  1   2   3   4   5   6   7   8   9   10   >