Add a space before the binary operator "|" to comply with kernel coding
style. Identified by checkpatch.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712
Remove the unnecessary space immediately after a cast. Identified by
checkpatch: CHECK: No space is necessary after a cast.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8712/rtl8712_xmit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712
A duplicate blank line is removed so that only a single blank line
separates two functions. Identified by checkpatch.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8712/rtl8712_xmit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c
b/drivers
Add a period to separate repeated words in a comment. The period preserves
the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'fw'.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8712/rtl8712_xmit.c | 4 ++--
1 file changed, 2
These patches make changes to clean up style issues identified
by checkpatch.
Deborah Brouwer (4):
staging: rtl8712: add period within a comment
staging: rtl8712: remove a blank line
staging: rtl8712: remove space after cast
staging: rtl8712: add space before binary operator
drivers
On Sun, Apr 04, 2021 at 11:54:40AM +0200, Greg KH wrote:
> On Sat, Apr 03, 2021 at 10:40:08PM -0700, Deborah Brouwer wrote:
> > To conform with Linux kernel coding style, replace goto statement that
> > does no cleanup with a direct return. To preserve meaning, copy comments
> &
Move the const after static to conform with kernel preference for
static const declaration style instead of static const.
Identified by checkpatch: WARNING: Move const after static - use 'static
const char'.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 4
are not
generally useful.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index 391c59490718..d21f21857c20 100644
To conform to Linux kernel coding style, a tab replaces the two spaces
that were previously used to indent brackets. Identified by the
checkpatch warning: WARNING: please, no spaces at the start of a line.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8188eu/core/rtw_security.c | 6
On Sat, Apr 03, 2021 at 11:16:16PM +0200, Julia Lawall wrote:
>
>
> On Sat, 3 Apr 2021, Deborah Brouwer wrote:
>
> > Add a comma to separate repeated words in a comment. The comma preserves
> > the meaning of the comment while also stopping the checkpatch warning:
> &
Add a comma to separate repeated words in a comment. The comma preserves
the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
1 file changed, 1
Add a comma to separate repeated words in a comment. The comma preserves
the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +-
1 file changed, 1
Add * at the beginning of each line in block comments to conform to the
Linux kernel coding style. Issue detected using checkpatch.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 59 +++
1 file changed, 28 insertions(+), 31 deletions(-)
diff
Remove empty comment because it provides no information.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 428c71ce0334
Style changes to block comments.
Changes since v2:
- add subsystem/driver prefix into 0/X email subject line
Changes since v1:
- all commit messages more accurately describe changes
Deborah Brouwer (3):
staging: rtl8723bs: core: add comma within a comment
staging: rtl8723bs
Remove empty comment because it provides no information.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index cb8d19e4dd3c
Add * at the beginning of each line in block comments to conform to the
Linux kernel coding style. Issue detected using checkpatch.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 58 +++
1 file changed, 27 insertions(+), 31 deletions(-)
diff
Add a comma to separate repeated words in a comment. The comma preserves
the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +-
1 file changed, 1
Style changes to block comments.
Changes since v1:
- all commit messages have changed to be more accurate
Deborah Brouwer (3):
staging: rtl8723bs: core: add comma within a comment
staging: rtl8723bs: core: add * to block comments
staging: rtl8723bs: core: remove empty comment
Fix checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 59 +++
1 file changed, 28 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b
Remove empty comment instead of fixing the checkpatch warning that it was
generating.
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core
Fix checkpatch warning:
WARNING: Possible repeated word: 'very'
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers/staging/rtl8723bs/core/rtw_xmit.c
This patchset fixes checkpatch warnings arising
from the block comments
Deborah Brouwer (3):
staging: rtl8723bs: core: fix repeated word warning
staging: rtl8723bs: core: fix block comment warning
staging: rtl8723bs: core: remove empty comment
drivers/staging/rtl8723bs/core/rtw_xmit.c
Remove empty comment and fix checkpatch warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Possible repeated word: 'very'
Signed-off-by: Deborah Brouwer
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 61 +++
1 file changed, 28 insertions(+), 33 deletions
24 matches
Mail list logo
