RE: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates

Dear Sudeep-san, >-Original Message- >From: Sudeep Holla >Sent: Thursday, July 9, 2020 3:39 PM >To: Dien Pham >Cc: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; Stephen >Boyd ; linux-kernel@vger.kernel.org; Michael Turquette >; Sudeep Holla &g

RE: [PATCH 1/2] firmware: arm_scmi: Keep the discrete clock rates sorted

for line > > >+ sort(rate, tot_rate_cnt, sizeof(*rate), rate_cmp_func, NULL); But, I think that it is affected by 'break' of below line. And for fixing this warning, I think we should fix inside this 'if' block. > > if (tot_rate_cnt + num_returned > SCMI_MAX_NUM_RATES) { > > dev_err(handle->dev, "No. of rates > > > MAX_NUM_RATES"); > > break; > > } Best regard, DIEN Pham

RE: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates

Hi Sudeep, Thanks for your patch. >-Original Message- >From: Sudeep Holla >Sent: Thursday, July 9, 2020 3:17 PM >To: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; Stephen >Boyd >Cc: Sudeep Holla ; linux-kernel@vger.kernel.org; Michael >

RE: [PATCH 1/2] firmware: arm_scmi: Keep the discrete clock rates sorted

); ^~~~ >-Original Message- >From: Sudeep Holla >Sent: Wednesday, July 8, 2020 6:07 PM >To: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; Stephen >Boyd >Cc: Sudeep Holla ; linux-kernel@vger.kernel.org; Michael >Turquette