Re: [PATCH] vme: Fix integer overflow checking in vme_check_window()

st U64_MAX. > > Anyway, I put one integer overflow check at the start of the function > and deleted all existing checks. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> > > diff --git a/drivers/vme/v

Re: [PATCH] vme: Fix integer overflow checking in vme_check_window()

I put one integer overflow check at the start of the function > and deleted all existing checks. > > Signed-off-by: Dan Carpenter Acked-by: Dmitry Kalinkin > > diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c > index 6a3ead42aba8..5b4c898d7509 100644 > --- a/drivers/vme/vm

Re: [PATCHv5] staging: vme_user: provide DMA functionality

> On 2015/10/18, at 18:04, Martyn Welch wrote: > > > > On 18/10/15 18:53, Dmitry Kalinkin wrote: >> On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch wrote: >>> >>> On 11/10/15 01:13, Dmitry Kalinkin wrote: >>>> This introduces

Re: [PATCHv5] staging: vme_user: provide DMA functionality

> On 2015/10/18, at 18:04, Martyn Welch <mar...@welchs.me.uk> wrote: > > > > On 18/10/15 18:53, Dmitry Kalinkin wrote: >> On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch <mar...@welchs.me.uk> wrote: >>> >>> On 11/10/15 01:13, Dmitry Ka

[PATCHv6] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- v5: Added a validation for dma_op argument in vme_user_sg_to_dma_list(). It is already checked in caller

Re: [PATCHv5] staging: vme_user: provide DMA functionality

On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch wrote: > > > On 11/10/15 01:13, Dmitry Kalinkin wrote: >> >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write functionality to the user space. >> >> Sign

Re: [PATCH] vme: 8-bit status/id takes 256 values, not 255

On Sun, Oct 18, 2015 at 9:30 AM, Martyn Welch wrote: > On 10 October 2015 at 23:00, Dmitry Kalinkin > wrote: >> Fixes an off by one array size. >> > > The Status/ID is an 8-bit value (OK, the standard states it can be a > 8, 16 or 32-bit value, however both

Re: [PATCH] vme: 8-bit status/id takes 256 values, not 255

On Sun, Oct 18, 2015 at 9:30 AM, Martyn Welch <mar...@welchs.me.uk> wrote: > On 10 October 2015 at 23:00, Dmitry Kalinkin <dmitry.kalin...@gmail.com> > wrote: >> Fixes an off by one array size. >> > > The Status/ID is an 8-bit value (OK, the standard states

Re: [PATCHv5] staging: vme_user: provide DMA functionality

On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch <mar...@welchs.me.uk> wrote: > > > On 11/10/15 01:13, Dmitry Kalinkin wrote: >> >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write functionality to the user s

[PATCHv6] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Cc: Igor Alekseev <igor.aleks...@itep.ru> --- v5: Added a validation for dma

Re: [PATCHv5] staging: vme_user: provide DMA functionality

> On 2015/10/17, at 23:52, Greg Kroah-Hartman > wrote: > > On Sun, Oct 11, 2015 at 03:13:25AM +0300, Dmitry Kalinkin wrote: >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write functionality to the user space. >

Re: [PATCHv5] staging: vme_user: provide DMA functionality

> On 2015/10/17, at 23:52, Greg Kroah-Hartman <gre...@linuxfoundation.org> > wrote: > > On Sun, Oct 11, 2015 at 03:13:25AM +0300, Dmitry Kalinkin wrote: >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write f

[PATCHv5] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev

[PATCHv4 RESEND] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- In the last reply Martyn suggested a rework of this to make it use existing bus/vme/ctl instead of creating

[PATCH] vme: 8-bit status/id takes 256 values, not 255

Fixes an off by one array size. Signed-off-by: Dmitry Kalinkin --- drivers/vme/vme_bridge.h | 4 +++- include/linux/vme.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/vme/vme_bridge.h b/drivers/vme/vme_bridge.h index 397578a..b59cbee 100644 --- a/drivers

Re: [PATCH] vme: tsi148: silence uninitialized variable warning

Hi Martyn, Sorry, your comment is too late. This patch is already in staging-next. Dmitri > On 2015/10/10, at 17:35, Martyn Welch wrote: > > On 5 October 2015 at 04:59, Dmitry Kalinkin wrote: >> The warning is a false positive. >> > > That seems very likely.

[PATCH] vme: 8-bit status/id takes 256 values, not 255

Fixes an off by one array size. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> --- drivers/vme/vme_bridge.h | 4 +++- include/linux/vme.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/vme/vme_bridge.h b/drivers/vme/vme_bridge.h index 3

[PATCHv5] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Cc: Igor Alekseev <igor.aleks..

[PATCHv4 RESEND] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Cc: Igor Alekseev <igor.aleks...@itep.ru> --- In the last reply Martyn sugges

Re: [PATCH] vme: tsi148: silence uninitialized variable warning

Hi Martyn, Sorry, your comment is too late. This patch is already in staging-next. Dmitri > On 2015/10/10, at 17:35, Martyn Welch <mar...@welchs.me.uk> wrote: > > On 5 October 2015 at 04:59, Dmitry Kalinkin <dmitry.kalin...@gmail.com> wrote: >> The

[PATCH] vme: tsi148: silence uninitialized variable warning

: 0b0496625715 ("vme: change bus error handling scheme") Signed-off-by: Dmitry Kalinkin --- drivers/vme/bridges/vme_tsi148.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index d1e383b..6052483 100644 ---

[PATCH] vme: tsi148: silence uninitialized variable warning

: 0b0496625715 ("vme: change bus error handling scheme") Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> --- drivers/vme/bridges/vme_tsi148.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:55, Dmitry Kalinkin wrote: > > >> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman >> wrote: >> >> On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: >>> >>>> On 05 Aug 2015, at 16:12, Greg Kroah-Hartm

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman > wrote: > > On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: >> >>> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman >>> wrote: >>> >>> On Mon, Jul 06, 2015 a

Re: [PATCH 0/3] VME bus error handling overhaul

> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman > wrote: > > On Mon, Jul 06, 2015 at 01:31:47PM +0100, Martyn Welch wrote: >> Hi Dmitry, >> >> These are looking good to me. > > Can I get an "Acked-by:" or something so that I know it's ok to apply > these? > > thanks, > > greg k-h- Now that

Re: [PATCH 0/3] VME bus error handling overhaul

> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman > wrote: > > On Mon, Jul 06, 2015 at 01:31:47PM +0100, Martyn Welch wrote: >> Hi Dmitry, >> >> These are looking good to me. > > Can I get an "Acked-by:" or something so that I know it's ok to apply > these? > >

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman <gre...@linuxfoundation.org> > wrote: > > On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: >> >>> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman <gre...@linuxfoundation.org> >>> wr

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:55, Dmitry Kalinkin <dmitry.kalin...@gmail.com> wrote: > > >> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman <gre...@linuxfoundation.org> >> wrote: >> >> On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: &

[RFC] Generic VME UIO

he ease of review, it's code is intended for the merge into vme_user. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/staging/vme/devices/Kconfig | 10 +++ drivers/staging/vme/devices/Makefile | 1 + drivers/staging/vme/devices/vme_uio.c | 158

[RFC] Generic VME UIO

is intended for the merge into vme_user. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/Kconfig | 10 +++ drivers/staging/vme/devices/Makefile | 1 + drivers/staging/vme/devices/vme_uio.c | 158

[PATCH] staging: android: ion: reorder variable definitions

Prevents false positive "missing empty line after a definition" checkpatch warning. Signed-off-by: Dmitry Kalinkin --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android

[PATCH] staging: android: ion: reorder variable definitions

Prevents false positive missing empty line after a definition checkpatch warning. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers

Generic VME UIO driver

> On 08 Jul 2015, at 16:22, Martyn Welch wrote: > > On 06/07/15 18:24, Dmitry Kalinkin wrote: >>> Some functionality was dropped as it was not good practice >>> >(such as receiving VME interrupts in user space, it's not really doable if >>> >the slave

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

> On 08 Jul 2015, at 16:57, Martyn Welch wrote: > > > > On 07/07/15 11:52, Dmitry Kalinkin wrote: >> The API I had in mind would have only vme_master_read and >> vme_master_write that would take absolute addresses (not relative to >> any window). These v

[PATCH] vme: lower alignment requirement in pci bridge drivers

is excessive, alignment by granularity should be enough. This changes alignment constraint from size to a fixed constraint of 64K. Signed-off-by: Dmitry Kalinkin --- drivers/vme/bridges/vme_ca91cx42.c | 2 +- drivers/vme/bridges/vme_tsi148.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

> On 08 Jul 2015, at 16:41, Martyn Welch wrote: > > On 07/07/15 13:51, Alessio Igor Bogani wrote: >>> Current VME stack links windows not to the boards, but to device drivers. >>> >Driver >>> >could potentially minimise window usage within it’s scope (any sort of >>> >window >>> >reusing, like

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 08 Jul 2015, at 16:57, Martyn Welch martyn.we...@ge.com wrote: On 07/07/15 11:52, Dmitry Kalinkin wrote: The API I had in mind would have only vme_master_read and vme_master_write that would take absolute addresses (not relative to any window). These variants of access functions

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 08 Jul 2015, at 16:41, Martyn Welch martyn.we...@ge.com wrote: On 07/07/15 13:51, Alessio Igor Bogani wrote: Current VME stack links windows not to the boards, but to device drivers. Driver could potentially minimise window usage within it’s scope (any sort of window reusing, like

[PATCH] vme: lower alignment requirement in pci bridge drivers

is excessive, alignment by granularity should be enough. This changes alignment constraint from size to a fixed constraint of 64K. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/vme/bridges/vme_ca91cx42.c | 2 +- drivers/vme/bridges/vme_tsi148.c | 2 +- 2 files changed, 2

Generic VME UIO driver

On 08 Jul 2015, at 16:22, Martyn Welch martyn.we...@ge.com wrote: On 06/07/15 18:24, Dmitry Kalinkin wrote: Some functionality was dropped as it was not good practice (such as receiving VME interrupts in user space, it's not really doable if the slave card is Release On Register Access

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

> On 07 Jul 2015, at 15:51, Alessio Igor Bogani > wrote: > >> Current VME stack links windows not to the boards, but to device drivers. >> Driver >> could potentially minimise window usage within it’s scope (any sort of >> window >> reusing, like mapping whole A16 once to be used with all

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

Hi Alessio, [Sorry for double post] > On 07 Jul 2015, at 10:08, Alessio Igor Bogani > wrote: > > Hi Dmitry, > > On 6 July 2015 at 19:24, Dmitry Kalinkin wrote: > [...] > I'm not a VME expert, but it seems that VME windows are a quiet limited > resource > n

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

Hi Alessio, [Sorry for double post] On 07 Jul 2015, at 10:08, Alessio Igor Bogani alessioigorbog...@gmail.com wrote: Hi Dmitry, On 6 July 2015 at 19:24, Dmitry Kalinkin dmitry.kalin...@gmail.com wrote: [...] I'm not a VME expert, but it seems that VME windows are a quiet limited

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 07 Jul 2015, at 15:51, Alessio Igor Bogani alessioigorbog...@gmail.com wrote: snip Current VME stack links windows not to the boards, but to device drivers. Driver could potentially minimise window usage within it’s scope (any sort of window reusing, like mapping whole A16 once to be

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 5:48 PM, Martyn Welch wrote: > > > On 06/07/15 14:50, Dmitry Kalinkin wrote: >> >> On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote: >>> >>> >>> Sorry about the *really* late reply, loads of emails some how missed my >

[PATCH] vme: print unhandled VME access errors

This will enable error messages for accesses done through mmap. Signed-off-by: Dmitry Kalinkin --- This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset. --- drivers/vme/vme.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index

Re: [PATCH 0/3] VME bus error handling overhaul

spatch such errors to the userspace in a more direct way. Not sure how, though. Cheers, Dmitry > > > On 02/07/15 15:11, Dmitry Kalinkin wrote: >> This moves tsi148 error handling into VME subsystem so it can be shared with >> the other bridge driver. Then there is a change to c

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote: > > Sorry about the *really* late reply, loads of emails some how missed my > periodic search of the mailing list. > > I'm happy with the addition of DMA, just not sure whether it's worth adding > an extra device file just to handle DMA. Could

Re: [PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch wrote: > On 26/06/15 21:39, Dmitry Kalinkin wrote: >> >> Signed-off-by: Dmitry Kalinkin >> --- >> drivers/staging/vme/devices/vme_user.c | 47 >> -- >> 1 file changed, 11 in

Re: [PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch martyn.we...@ge.com wrote: On 26/06/15 21:39, Dmitry Kalinkin wrote: Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch martyn.we...@ge.com wrote: Sorry about the *really* late reply, loads of emails some how missed my periodic search of the mailing list. I'm happy with the addition of DMA, just not sure whether it's worth adding an extra device file just to handle

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 5:48 PM, Martyn Welch martyn.we...@ge.com wrote: On 06/07/15 14:50, Dmitry Kalinkin wrote: On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch martyn.we...@ge.com wrote: Sorry about the *really* late reply, loads of emails some how missed my periodic search of the mailing

Re: [PATCH 0/3] VME bus error handling overhaul

to the userspace in a more direct way. Not sure how, though. Cheers, Dmitry On 02/07/15 15:11, Dmitry Kalinkin wrote: This moves tsi148 error handling into VME subsystem so it can be shared with the other bridge driver. Then there is a change to close a fixme on separating errors by address space

[PATCH] vme: print unhandled VME access errors

This will enable error messages for accesses done through mmap. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset. --- drivers/vme/vme.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/vme/vme.c

[PATCH 1/3] vme: move tsi148 error handling into VME subsystem

in a rare case when err_chk=1 and kmalloc fails. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_tsi148.c | 93 +++- drivers/vme/vme.c| 86 + drivers/vme/vme_bridge.h | 6

[PATCH 0/3] VME bus error handling overhaul

in this direction would be to add error handling support to ca91cx42 and make it unconditional for tsi148. It also makes much sense to add synchronization to error-related list operations (spinlocks, rcu). Dmitry Kalinkin (3): vme: move tsi148 error handling into VME subsystem vme: include address

[PATCH 3/3] vme: change bus error handling scheme

. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_ca91cx42.c | 3 +- drivers/vme/bridges/vme_tsi148.c | 83 +- drivers/vme/vme.c | 92 ++ drivers/vme/vme_bridge.h | 23

[PATCH 2/3] vme: include address space in error filtering

Also changes vme_bus_error_handler to take generic address modifier code instead of raw contents of a device-specific attribute register. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- drivers/vme/bridges/vme_tsi148.c | 4 ++- drivers/vme/vme.c| 61

[PATCH 0/3] VME bus error handling overhaul

in this direction would be to add error handling support to ca91cx42 and make it unconditional for tsi148. It also makes much sense to add synchronization to error-related list operations (spinlocks, rcu). Dmitry Kalinkin (3): vme: move tsi148 error handling into VME subsystem vme: include address

[PATCH 1/3] vme: move tsi148 error handling into VME subsystem

in a rare case when err_chk=1 and kmalloc fails. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_tsi148.c | 93 +++- drivers/vme/vme.c| 86

[PATCH 3/3] vme: change bus error handling scheme

. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_ca91cx42.c | 3 +- drivers/vme/bridges/vme_tsi148.c | 83 +- drivers/vme/vme.c | 92

[PATCH 2/3] vme: include address space in error filtering

Also changes vme_bus_error_handler to take generic address modifier code instead of raw contents of a device-specific attribute register. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_tsi148.c | 4 ++- drivers/vme

[PATCHv3 5/9] staging: vme_user: allow large read()/write()

-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 73 +++--- 1 file changed, 24 insertions(+), 49 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 3467cde..a2345db 100644 --- a/drivers/staging/vme

[PATCHv3 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 947a38e..7ca943c 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers

[PATCHv3 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ef876a4..947a38e 100644 --- a/drivers/staging/vme/devices

[PATCHv3 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 7ca943c..b3e3c2d 100644 --- a/drivers/staging

[PATCHv3 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers/staging/vme/devices

[PATCHv3 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644 --- a/drivers/staging/vme

[PATCHv3 0/9] vme_user checkpatch fixes and read()/write() rework

AL instead of EFAULT in a couple of places. v3 fixes ("allow large read()/write()") to also remove the comment right above resource_to_user() v3 also renames ("vme_user: return -EFAULT on __copy_*_user errors") to ("switch to returning -EFAULT on __copy_*_user error

[PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index a2345db..ef876a4 100644

[PATCHv3 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 9cca97a..ccf9602 100644

[PATCHv3 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers/staging/vme/devices

[PATCHv3 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers

[PATCHv3 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644

[PATCHv3 5/9] staging: vme_user: allow large read()/write()

-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 73 +++--- 1 file changed, 24 insertions(+), 49 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 3467cde..a2345db 100644

[PATCHv3 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 947a38e..7ca943c 100644 --- a/drivers/staging/vme/devices

[PATCHv3 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ef876a4..947a38e 100644

[PATCHv3 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 7ca943c..b3e3c2d

[PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCHv3 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCHv3 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers

[PATCHv3 0/9] vme_user checkpatch fixes and read()/write() rework

of EFAULT in a couple of places. v3 fixes (allow large read()/write()) to also remove the comment right above resource_to_user() v3 also renames (vme_user: return -EFAULT on __copy_*_user errors) to (switch to returning -EFAULT on __copy_*_user errors) Dmitry Kalinkin (9): staging: vme_user: fix

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

> On 25 Jun 2015, at 15:05, Dmitry Kalinkin wrote: > > >> On 25 Jun 2015, at 14:27, Sudip Mukherjee wrote: >> >> On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: >>> Signed-off-by: Dmitry Kalinkin >>> --- &g

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

> On 25 Jun 2015, at 14:27, Sudip Mukherjee wrote: > > On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: >> Signed-off-by: Dmitry Kalinkin >> --- >> drivers/staging/vme/devices/vme_user.c | 47 >> -- >&g

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

On 25 Jun 2015, at 14:27, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

On 25 Jun 2015, at 15:05, Dmitry Kalinkin dmitry.kalin...@gmail.com wrote: On 25 Jun 2015, at 14:27, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers

[PATCHv2 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index de9eda5..efed9c7 100644 --- a/drivers/staging

[PATCHv2 5/9] staging: vme_user: allow large read()/write()

-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 67 -- 1 file changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 3467cde..101f7b9 100644 --- a/drivers/staging/vme

[PATCHv2 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 070e63f..cf47649 100644 --- a/drivers/staging/vme/devices

[PATCHv2 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers/staging/vme/devices

[PATCHv2 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index cf47649..de9eda5 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers

[PATCHv2 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 9cca97a..ccf9602 100644

[PATCHv2 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers/staging/vme/devices

[PATCHv2 0/9] vme_user checkpatch fixes and read()/write() rework

AL instead of EFAULT in a couple of places. Dmitry Kalinkin (9): staging: vme_user: fix code alignment staging: vme_user: fix blank lines staging: vme_user: fix NULL comparison style staging: vme_user: fix kmalloc style staging: vme_user: allow large read()/write() staging: vme_us

[PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 101f7b9..070e63f 100644

[PATCHv2 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644 --- a/drivers/staging/vme

Re: [PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

> On 23 Jun 2015, at 16:51, Dan Carpenter wrote: > > On Tue, Jun 23, 2015 at 03:42:30PM +0300, Dmitry Kalinkin wrote: >> @@ -178,38 +167,24 @@ static ssize_t buffer_to_user(unsigned int minor, char >> __user *buf, >>size_t count, loff

Re: [PATCH 1/9] staging: vme_user: fix code alignment

> On 23 Jun 2015, at 16:21, Frans Klaver wrote: > > You left one in the function declarations (vme_user_write). If you mean forward declarations, they are already gone in Greg’s tree:

[PATCH 0/9] vme_user checkpatch fixes and read()/write() rework

First four patches are fixes for various checpatch warnings. Next there is a change to drop large read()/write() stub followed by a change to rework user copy error codes. Last three changes are refactorings. Dmitry Kalinkin (9): staging: vme_user: fix code alignment staging: vme_user: fix

[PATCH 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 6f5bbc4..14f9554 100644 --- a/drivers/staging

  1   2   3   >