Re: [PATCH v3 1/8] Input: add `REL_WHEEL_HI_RES` and `REL_HWHEEL_HI_RES`

2018-12-06 Thread Dmitry Torokhov
e (and most granular) data is available > through the new axes. > > Signed-off-by: Peter Hutterer Acked-by: Dmitry Torokhov > --- > No changes since v1 > > Documentation/input/event-codes.rst| 21 - > include/uapi/linux/input-event-codes.h | 2 +

Re: [PATCH] Input: restore EV_ABS ABS_RESERVED

2018-12-06 Thread Dmitry Torokhov
ake it through the HID one. > > fwiw, patch was made on top of v4.20-rc5, so it shouldn't conflict. My tree is behind that ;) so I would actually prefer if Benjamin/Jiri would take it through their tree with my: Acked-by: Dmitry Torokhov Thanks. -- Dmitry

Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-04 Thread Dmitry Torokhov
On December 4, 2018 11:09:32 AM PST, Tony Lindgren wrote: >Hi, > >* Dmitry Torokhov [181204 04:00]: >> Hi Tony, >> >> On Mon, Dec 03, 2018 at 03:12:51PM -0800, Tony Lindgren wrote: >> > >> > With PM enabled, I noticed that pressing a key on the

Re: [PATCH] Revert "mfd: cros_ec: Use devm_kzalloc for private data"

2018-12-04 Thread Dmitry Torokhov
xit+0x1c/0x2d8 [cros_ec_dev] > > __arm64_sys_delete_module+0x16c/0x1f8 > > el0_svc_common+0x84/0xd8 > > el0_svc_handler+0x2c/0x80 > > el0_svc+0x8/0xc > > ---[ end trace a57c4625f3c60ae8 ]--- > > > > Cc: sta...@vger.kernel.org > > Fixes:

Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-03 Thread Dmitry Torokhov
ilar to what > we already do for the GPIO controller. Can you show me where exactly we are doing this? I can't seem to find the matching code. Thanks! > > And there's no need to keep enabling and disabling interrupts and > wake-up events for normal use if we use IRQF_ONESHOT as sugges

[git pull] Input updates for v4.20-rc5

2018-12-03 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Mostly new IDs for Elan/Synaptics touchpads, plus a few small fixups. Changelog: - Adam Wong (1): Input: elan_i2c - add support

Re: [PATCH 1/1] Input: synaptics - enable SMBus for HP 15-ay000 (SYN3221).

2018-12-03 Thread Dmitry Torokhov
On Fri, Nov 16, 2018 at 01:04:59PM +0900, Teika Kazura wrote: > SMBus works fine for the touchpad with id SYN3221, used in the HP 15-ay000 > series, > > This device has been reported in these messages in the "linux-input" mailing > list: > * https://marc.info/?l=linux-input=152016683003369=2 >

Re: [PATCH 1/2] Input: omap-keypad: Fix keyboard debounce configuration

2018-12-03 Thread Dmitry Torokhov
On Sun, Dec 02, 2018 at 05:29:32PM -0800, Tony Lindgren wrote: > I noticed that the Android v3.0.8 kernel on droid4 is using different > keypad values from the mainline kernel and does not have issues with > keys occasionally being stuck until pressed again. Turns out there was > an earlier patch

Re: [PATCH 2/2] Input: omap-keypad: Fix idle configration to not block SoC idle states

2018-12-03 Thread Dmitry Torokhov
On Sun, Dec 02, 2018 at 05:29:33PM -0800, Tony Lindgren wrote: > With PM enabled, I noticed that pressing a key on the droid4 keyboard will > block deeper idle states for the SoC. Looks like we can fix this by > managing the idle register to gether with the interrupt similar to what > we already

Re: [PATCH] Input: i8042 add of_node_put()

2018-11-29 Thread Dmitry Torokhov
Hi Yangtao, On Wed, Nov 21, 2018 at 09:35:13AM -0500, Yangtao Li wrote: > use of_node_put() to release the refcount. > > Signed-off-by: Yangtao Li > --- > drivers/input/serio/i8042-sparcio.h | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH] Input: xpad - quirk all PDP Xbox One gamepads

2018-11-29 Thread Dmitry Torokhov
On Tue, Nov 27, 2018 at 06:47:10PM -0800, Cameron Gutman wrote: > Since we continue to find tons of new variants [0,1,2,3,4,5,6] that > need the PDP quirk, let's just quirk all devices from PDP. > > [0]: https://github.com/paroj/xpad/pull/104 > [1]: https://github.com/paroj/xpad/pull/105 > [2]:

Re: [PATCH] Input: mouse: elan_i2c_core: Added support for ELAN0621 touchpad.

2018-11-29 Thread Dmitry Torokhov
On Thu, Nov 29, 2018 at 12:38:24PM -0500, a...@adamwong.me wrote: > From: Adam Wong > > Added the ability to detect the ELAN0621 touchpad found in some Lenovo > laptops. > > Signed-off-by: Adam Wong Applied, thank you. > --- > drivers/input/mouse/elan_i2c_core.c | 1 + > 1 file changed, 1

Re: [PATCH 0/7] HID: revert the Logitech High Resolution wheel support

2018-11-21 Thread Dmitry Torokhov
is patch series has informally been acked by Dmitry, Harry, Jiri, Nestor > > and Peter, but I wouldn't mind a public ack before I push this to > > the for-linus branch. > > Thanks Benjamin! > > For the series: > Acked-by: Harry Cutts Acked-by: Dmitry Torokhov Thanks! -- Dmitry

Re: [PATCH v2 0/6] OLPC 1.75 Keyboard/Touchpad fixes

2018-11-15 Thread Dmitry Torokhov
On Mon, Nov 12, 2018 at 03:30:23AM +0100, Lubomir Rintel wrote: > This makes keyboard/touchpad work on a DT MMP2 platform. > > Changes since v1: > - Collected Acks > - Replaced "Input: olpc_apsp: depend on CONFIG_OF" patch with "Input: > olpc_apsp: drop CONFIG_OLPC dependency", since it was

Re: [PATCH RESEND] hyper-v: Fix wakeup from suspend-to-idle

2018-11-15 Thread Dmitry Torokhov
On Thu, Nov 15, 2018 at 07:09:33PM +0100, Vitaly Kuznetsov wrote: > It makes little sense but still possible to put Hyper-V guests into > suspend-to-idle state. To wake them up two wakeup sources were registered > in the past: hyperv-keyboard and hid-hyperv. However, since > commit eed4d47efe95

Re: [PATCH v2] HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

2018-11-14 Thread Dmitry Torokhov
On Wed, Nov 14, 2018 at 3:00 PM Eric Biggers wrote: > > Hi Dmitry, > > On Wed, Nov 14, 2018 at 02:28:56PM -0800, 'Dmitry Torokhov' via > syzkaller-bugs wrote: > > On Wed, Nov 14, 2018 at 2:05 PM Jann Horn wrote: > > > > > > On Wed, Nov 1

Re: [PATCH v2] HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

2018-11-14 Thread Dmitry Torokhov
On Wed, Nov 14, 2018 at 2:38 PM Jann Horn wrote: > > On Wed, Nov 14, 2018 at 11:29 PM Dmitry Torokhov wrote: > > On Wed, Nov 14, 2018 at 2:05 PM Jann Horn wrote: > > > On Wed, Nov 14, 2018 at 10:55 PM Eric Biggers wrote: > > > > When a UHID_CREATE command i

Re: [PATCH v2] HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

2018-11-14 Thread Dmitry Torokhov
On Wed, Nov 14, 2018 at 2:05 PM Jann Horn wrote: > > On Wed, Nov 14, 2018 at 10:55 PM Eric Biggers wrote: > > > > From: Eric Biggers > > > > When a UHID_CREATE command is written to the uhid char device, a > > copy_from_user() is done from a user pointer embedded in the command. > > When the

Re: [PATCH] HID: uhid: prevent uhid_char_write() under KERNEL_DS

2018-11-14 Thread Dmitry Torokhov
On Wed, Nov 14, 2018 at 10:03 AM Eric Biggers wrote: > > From: Eric Biggers > > When a UHID_CREATE command is written to the uhid char device, a > copy_from_user() is done from a user pointer embedded in the command. > When the address limit is KERNEL_DS, e.g. as is the case during > sendfile(),

Re: [PATCH v3 18/20] Input: hp_sdc_rtc - Switch to use %ptR

2018-11-13 Thread Dmitry Torokhov
On Tue, Nov 13, 2018 at 07:17:27PM +0200, Andy Shevchenko wrote: > Use %ptR instead of open coded variant to print content of > struct rtc_time in human readable format. > > Cc: Dmitry Torokhov > Signed-off-by: Andy Shevchenko Acked-by: Dmitry Torokhov Please feel free to merg

Re: [PATCH] driver: input: fix UBSAN warning in input_defuzz_abs_event

2018-11-12 Thread Dmitry Torokhov
Hi, On Fri, Nov 02, 2018 at 09:48:51PM +0800, liujian wrote: > syzkaller triggered a UBCAN warning: > > [ 196.188950] UBSAN: Undefined behaviour in drivers/input/input.c:62:23 > [ 196.188958] signed integer overflow: > [ 196.188964] -2147483647 - 104 cannot be represented in type 'int [2]' >

Re: [PATCH] input: atkbd: clean up indentation issue, add missing tab in an if statement

2018-11-12 Thread Dmitry Torokhov
On Thu, Nov 01, 2018 at 03:12:24PM +, Colin King wrote: > From: Colin Ian King > > Trivial fix to clean up indentation issues, add missing tab > > Signed-off-by: Colin Ian King Applied, thank you. > --- > drivers/input/keyboard/atkbd.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] dt-bindings: input: Fix a typo in file input-reset.txt

2018-11-12 Thread Dmitry Torokhov
On Wed, Nov 07, 2018 at 05:58:19AM +, Ding Tao wrote: > Replace sysrq-reset-seq with keyset. > > Signed-off-by: Ding Tao Applied, thank you. > --- > Documentation/devicetree/bindings/input/input-reset.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] input: cros_ec_keyb: fix button/switch capability reports

2018-11-12 Thread Dmitry Torokhov
On Wed, Nov 07, 2018 at 02:38:13PM -0800, Brian Norris wrote: > The cros_ec_keyb_bs array lists buttons and switches together, expecting > that its users will match the appropriate type and bit fields. But > cros_ec_keyb_register_bs() only checks the 'bit' field, which causes > misreported input

[git pull] Input updates for v4.20-rc0

2018-10-26 Thread Dmitry Torokhov
example Dmitry Torokhov (1): Input: synaptics - avoid using uninitialized variable when probing George G. Davis (1): Input: atmel_mxt_ts - fix multiple includes Gustavo A. R. Silva (3): Input: cyapa - mark expected switch fall-throughs Input: atmel_mxt_ts - mark expected

Re: [PATCH] mmc: sdhci-pci: Try "cd" for card-detect lookup before using NULL

2018-10-24 Thread Dmitry Torokhov
Hi Andy, On Wed, Oct 24, 2018 at 3:02 AM Andy Shevchenko wrote: > > On Mon, Oct 22, 2018 at 04:34:55PM -0700, Rajat Jain wrote: > > On Fri, Oct 19, 2018 at 2:13 AM Andy Shevchenko > > wrote: > > > On Fri, Oct 19, 2018 at 12:53 AM Rajat Jain wrote: > > > > > across other users of this API

Re: Is Fixes line enough?

2018-10-23 Thread Dmitry Torokhov
On Tue, Oct 23, 2018 at 10:38 AM Theodore Y. Ts'o wrote: > > On Tue, Oct 23, 2018 at 06:36:26PM +0200, Jiri Kosina wrote: > > FWIW, I brought this up already at KS 2016, see Jon's coverage here: > > > > https://lwn.net/Articles/705220/ > > > > My primary motivation to bring that up back

Re: [PATCH AUTOSEL 4.18 08/27] Input: evdev - add a schedule point in evdev_write()

2018-10-22 Thread Dmitry Torokhov
Hi Sasha, On Mon, Oct 22, 2018 at 06:19:05AM -0400, Sasha Levin wrote: > From: Dmitry Torokhov > > [ Upstream commit 36d2582ff235b4e01ad64a734c877a52dc762d9c ] > > Large writes to evdev interface may cause rcu stalls. Let's add > cond_resched() to the loop to avoid this.

Re: [PATCH AUTOSEL 4.18 04/27] Input: i8042 - enable keyboard wakeups by default when s2idle is used

2018-10-22 Thread Dmitry Torokhov
@mail.gmail.com > Reviewed-by: Rafael J. Wysocki > Signed-off-by: Daniel Drake > Signed-off-by: Dmitry Torokhov > Signed-off-by: Sasha Levin > --- > drivers/input/serio/i8042.c | 29 - > include/linux/suspend.h | 2 ++ > kernel/powe

[git pull] Input updates for v4.19-rc8

2018-10-19 Thread Dmitry Torokhov
Hi Greg, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Just an addition to elan touchpad driver ACPI table. Changelog: - Mikhail Nikiforov (1): Input: elan_i2c - add ACPI ID for Lenovo

Re: [PATCH] Input: pm8941-pwrkey - Add pms405 pwrkey support

2018-10-18 Thread Dmitry Torokhov
On Thu, Oct 18, 2018 at 10:54:37AM +0530, Vinod wrote: > On 19-09-18, 18:49, Bjorn Andersson wrote: > > From: Vinod Koul > > > > Update the binding and driver for pms405 pwrkey. > > Rob, Dmitry > > Gentle reminder for this patch... > > > Signed-off-by: Vinod Koul > > Signed-off-by: Bjorn

Re: [PATCH] Input: uinput - fix Spectre v1 vulnerability

2018-10-18 Thread Dmitry Torokhov
On Thu, Oct 18, 2018 at 12:43 PM Alan Cox wrote: > > On Tue, 16 Oct 2018 20:12:43 +0200 > "Gustavo A. R. Silva" wrote: > > > On 10/16/18 8:09 PM, Dmitry Torokhov wrote: > > > > > > > > /dev/uinput > > > > I've got it. This expl

Re: [RFC PATCH 0/5] device property: Introducing software nodes

2018-10-17 Thread Dmitry Torokhov
Hi Heikki, On Wed, Oct 17, 2018 at 04:36:12PM +0300, Heikki Krogerus wrote: > @@ -189,7 +210,7 @@ static int cht_int33fe_probe(struct i2c_client *client) > memset(_info, 0, sizeof(board_info)); > strlcpy(board_info.type, "typec_fusb302", I2C_NAME_SIZE); > board_info.dev_name =

Re: WARNING: kmalloc bug in input_mt_init_slots

2018-10-17 Thread Dmitry Torokhov
On October 17, 2018 8:35:15 AM PDT, Christopher Lameter wrote: >On Tue, 16 Oct 2018, Dmitry Torokhov wrote: > >> On Thu, Sep 27, 2018 at 07:35:37AM -0700, Matthew Wilcox wrote: >> > On Mon, Sep 24, 2018 at 11:41:58AM -0700, Dmitry Torokhov wrote: >> > > >

[PATCH] Input: synaptics - avoid using uninitialized variable when probing

2018-10-16 Thread Dmitry Torokhov
+13cb3b01d0784e4ff...@syzkaller.appspotmail.com Signed-off-by: Dmitry Torokhov --- drivers/input/mouse/synaptics.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 55d33500d55e..5e85f3cca867 100644 --- a/drivers/input

Re: [PATCH] Input: xen-kbdfront - mark expected switch fall-through

2018-10-16 Thread Dmitry Torokhov
On Mon, Oct 08, 2018 at 04:07:48PM +0200, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I placed the "fall through" > part at the beginning of the code comment,

Re: WARNING: kmalloc bug in input_mt_init_slots

2018-10-16 Thread Dmitry Torokhov
On Thu, Sep 27, 2018 at 07:35:37AM -0700, Matthew Wilcox wrote: > On Mon, Sep 24, 2018 at 11:41:58AM -0700, Dmitry Torokhov wrote: > > > How large is the allocation? AFACIT nRequests larger than KMALLOC_MAX_SIZE > > > are larger than the maximum allowed by the

Re: [PATCH 6/7] Input: sx8654 - add sx8650 support

2018-10-16 Thread Dmitry Torokhov
On Tue, Oct 16, 2018 at 09:34:26PM +0200, Richard Leitner wrote: > > On 10/16/18 7:48 PM, Dmitry Torokhov wrote: > > On Tue, Oct 16, 2018 at 11:22:48AM +0200, Richard Leitner wrote: > > > The sx8654 and sx8650 are quite similar, therefore add support for the > > > s

Re: [PATCH] Input: uinput - fix Spectre v1 vulnerability

2018-10-16 Thread Dmitry Torokhov
On October 16, 2018 10:52:58 AM PDT, "Gustavo A. R. Silva" wrote: >Hi Dmitry, > >On 10/16/18 7:21 PM, Dmitry Torokhov wrote: >> Hi Gustavo, >> >> On Tue, Oct 16, 2018 at 01:13:13PM +0200, Gustavo A. R. Silva wrote: >>> setup.code can be indi

Re: [PATCH 7/7] Input: sx8654 - use common of_touchscreen functions

2018-10-16 Thread Dmitry Torokhov
On Tue, Oct 16, 2018 at 11:23:10AM +0200, Richard Leitner wrote: > of_touchscreen.c provides a common interface for a axis invertion and > swapping of touchscreens. Therefore use it in the sx8654 driver. > > Signed-off-by: Richard Leitner > --- > drivers/input/touchscreen/sx8654.c | 37

Re: [PATCH 6/7] Input: sx8654 - add sx8650 support

2018-10-16 Thread Dmitry Torokhov
On Tue, Oct 16, 2018 at 11:22:48AM +0200, Richard Leitner wrote: > The sx8654 and sx8650 are quite similar, therefore add support for the > sx8650 within the sx8654 driver. > > Signed-off-by: Richard Leitner > --- > drivers/input/touchscreen/sx8654.c | 186 >

Re: [PATCH 2/7] Input: sx8654 - add reset-gpio support

2018-10-16 Thread Dmitry Torokhov
Hi Richard, On Tue, Oct 16, 2018 at 11:16:48AM +0200, Richard Leitner wrote: > The sx8654 features a NRST input which may be connected to a GPIO. > Therefore add support for hard-resetting the sx8654 via this NRST. > > If the reset-gpio property is provided the sx8654 is resetted via NRST >

Re: [PATCH] Input: uinput - fix Spectre v1 vulnerability

2018-10-16 Thread Dmitry Torokhov
Hi Gustavo, On Tue, Oct 16, 2018 at 01:13:13PM +0200, Gustavo A. R. Silva wrote: > setup.code can be indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > >

Re: [RFC PATCH 0/5] device property: Introducing software nodes

2018-10-16 Thread Dmitry Torokhov
Hi Heikki, On Fri, Oct 12, 2018 at 02:39:29PM +0300, Heikki Krogerus wrote: > Hi guys, > > To continue the discussion started by Dmitry [1], this is my proposal > that I mentioned in my last mail. In short, the idea is that instead > of trying to extend the support for the currently used struct

Re: [PATCH] Input: atmel_mxt_ts - mark expected switch fall-through

2018-10-15 Thread Dmitry Torokhov
On Mon, Oct 08, 2018 at 07:03:55PM +0200, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied, thank you. > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 2

Re: [PATCH] Input: cyapa - mark expected switch fall-throughs

2018-10-15 Thread Dmitry Torokhov
On Mon, Oct 08, 2018 at 05:38:24PM +0200, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the "Fallthrough state" > commern with a proper "Fall through",

Re: [PATCH] input: touchscreen: fix wm97xx-ts exit path

2018-10-15 Thread Dmitry Torokhov
ers/base/driver.c:193 > driver_unregister+0x30/0x40 > > Fix this by only calling driver_unregister() with the same > condition that driver_register() is called. > > Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support") > > Signed-off-by: Randy Dunlap &

Re: [git pull] Input updates for v4.19-rc7

2018-10-12 Thread Dmitry Torokhov
On Fri, Oct 12, 2018 at 12:51:52PM +0200, Greg KH wrote: > On Thu, Oct 11, 2018 at 04:57:36PM -0700, Dmitry Torokhov wrote: > > Hi Greg, > > > > Please pull from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus > >

Re: [PATCH 0/5] Fix Elan I2C touchpads in latest generation from Lenovo

2018-10-12 Thread Dmitry Torokhov
On Fri, Oct 12, 2018 at 04:24:08PM +0200, Benjamin Tissoires wrote: > Since v4.18, we unconditionally switch the I2C capable touchpads over I2C. > In the model I had (a pre-prod t480s I guess), the touchpad was behaving > fine. > However, it occurs that later production models don't expose the

Re: [PATCH AUTOSEL 4.18 24/58] Input: atakbd - fix Atari CapsLock behaviour

2018-10-11 Thread Dmitry Torokhov
Hi Geert, On Wed, Oct 10, 2018 at 09:04:08PM +0200, Geert Uytterhoeven wrote: > Hi Dmitry, > > On Wed, Oct 10, 2018 at 7:03 PM Dmitry Torokhov > wrote: > > Same goes for patches that deal with error handling in probe() functions > > that your AUTOSEL scripts like to pi

[git pull] Input updates for v4.19-rc7

2018-10-11 Thread Dmitry Torokhov
/2 keyboards as wakeup devices on newer platforms - added a new Xbox gamepad ID. Changelog: - Daniel Drake (1): Input: i8042 - enable keyboard wakeups by default when s2idle is used Dmitry Torokhov (2): Input: evdev - add a schedule point in evdev_write() Input: uinput

Re: [PATCH v2] Input: elants_i2c - Use DMA safe i2c when possible

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 01:00:17PM -0700, Stephen Boyd wrote: > This irq handler is always reading bytes from the device into a > kmalloced buffer, so it's safe to mark this transaction as DMA safe. > This avoids bouncing the buffer when an i2c controller decides to use > DMA for a transaction. >

Re: [PATCH AUTOSEL 4.18 24/58] Input: atakbd - fix Atari CapsLock behaviour

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 02:49:47PM -0400, Sasha Levin wrote: > On Wed, Oct 10, 2018 at 11:40:39AM -0700, Dmitry Torokhov wrote: > > On Wed, Oct 10, 2018 at 08:28:40PM +0200, Greg KH wrote: > > > On Wed, Oct 10, 2018 at 02:11:48PM -0400, Sasha Levin wrote: > > > >

Re: [PATCH AUTOSEL 4.18 24/58] Input: atakbd - fix Atari CapsLock behaviour

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 08:28:40PM +0200, Greg KH wrote: > On Wed, Oct 10, 2018 at 02:11:48PM -0400, Sasha Levin wrote: > > I think Greg's last estimate was that about 1/3 of the kernels in the > > wild are custom based on a kernel.org stable kernel, which means that we > > have no visibility as

Re: [PATCH AUTOSEL 4.18 24/58] Input: atakbd - fix Atari CapsLock behaviour

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 02:11:48PM -0400, Sasha Levin wrote: > On Wed, Oct 10, 2018 at 10:02:19AM -0700, Dmitry Torokhov wrote: > > On Wed, Oct 10, 2018 at 10:29:58AM -0400, Sasha Levin wrote: > > > On Mon, Oct 08, 2018 at 12:20:26PM -0700, Dmitry Torokhov wrote:

Re: [PATCH v2 5/8] Input: olpc_apsp: depend on CONFIG_OF

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 04:25:01PM +0200, Lubomir Rintel wrote: > This is a device-tree enabled driver. Moreover CONFIG_OLPC is specific > to the x86 platform code, while the driver is for an ARM-based laptop. > > Signed-off-by: Lubomir Rintel > --- > drivers/input/serio/Kconfig | 2 +- > 1

Re: [PATCH v2 8/8] Input: olpc_apsp: allocate the GPIOs used

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 10:10:13AM -0700, Dmitry Torokhov wrote: > On Wed, Oct 10, 2018 at 04:25:04PM +0200, Lubomir Rintel wrote: > > Take the GPIO lines are used by the SP. The driver doesn't touch the > > lines -- this is done to disallow anything else from fiddling with &

Re: [PATCH v2 8/8] Input: olpc_apsp: allocate the GPIOs used

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 04:25:04PM +0200, Lubomir Rintel wrote: > Take the GPIO lines are used by the SP. The driver doesn't touch the > lines -- this is done to disallow anything else from fiddling with > them because that would confuse the SP firmware. > > Also, the lines are now nicely visible

Re: [PATCH v2 7/8] Input: olpc_apsp: enable the SP clock

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 04:25:03PM +0200, Lubomir Rintel wrote: > Without the clock, the keyboard controller won't operate. > Tested on an OLPC XO 1.75. > > Signed-off-by: Lubomir Rintel > --- > drivers/input/serio/olpc_apsp.c | 13 + > 1 file changed, 13 insertions(+) > > diff

Re: [PATCH] Input: elants_i2c - Use DMA safe i2c when possible

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 09:55:17AM -0700, Stephen Boyd wrote: > This irq handler is always reading bytes from the device into a > kmalloced buffer, so it's safe to mark this transaction as DMA safe. > This avoids bouncing the buffer when an i2c controller decides to use > DMA for a transaction. >

Re: [PATCH AUTOSEL 4.18 24/58] Input: atakbd - fix Atari CapsLock behaviour

2018-10-10 Thread Dmitry Torokhov
On Wed, Oct 10, 2018 at 10:29:58AM -0400, Sasha Levin wrote: > On Mon, Oct 08, 2018 at 12:20:26PM -0700, Dmitry Torokhov wrote: > > Hi Michael, > > > > On Mon, Oct 8, 2018 at 12:09 PM Michael Schmitz > > wrote: > > > > > > Dmitry, > > >

Re: [PATCH] HID: google: drop superfluous const before SIMPLE_DEV_PM_OPS()

2018-10-09 Thread Dmitry Torokhov
skers") > Signed-off-by: Jiri Kosina FWIW Acked-by: Dmitry Torokhov > --- > > In hid.git#for-4.20/google > > drivers/hid/hid-google-hammer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/

Re: [PATCH AUTOSEL 4.18 24/58] Input: atakbd - fix Atari CapsLock behaviour

2018-10-08 Thread Dmitry Torokhov
ion on behalf of > the maintainer. Unstable patches are a little harder to get accepted. > > Cheers, > > Michael > > > > On 09/10/18 06:11, Dmitry Torokhov wrote: > > On Mon, Oct 8, 2018 at 8:25 AM Sasha Levin wrote: > >> From: Michael Sc

Re: [PATCH AUTOSEL 4.18 24/58] Input: atakbd - fix Atari CapsLock behaviour

2018-10-08 Thread Dmitry Torokhov
psLock toggle handling code, which did cause the CapsLock > key to merely act as a Shift key. This has been broken for 10+ years. Does it really make sense to promote it to stable? > > Tested-by: Michael Schmitz > Signed-off-by: Michael Schmitz > Signed-off-by: Andreas Schwab >

Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards

2018-10-05 Thread Dmitry Torokhov
Hi Heikki, On Tue, Sep 25, 2018 at 03:19:27PM +0300, Heikki Krogerus wrote: > On Mon, Sep 24, 2018 at 11:45:43AM -0700, Dmitry Torokhov wrote: > > I think we are talking about totally different use cases and that is why > > we are having hard time coming to a mutually agreeable

[PATCH v2] cpufreq: dt-platdev: allow RK3399 to have separate tunables per cluster

2018-10-05 Thread Dmitry Torokhov
RK3899 has one cluster with 4 small cores, and another one with 2 big cores, with cores in different clusters having different OPPs and thus needing separate set of tunables. Let's enable this via "have_governor_per_policy" platform data. Signed-off-by: Dmitry Torokhov --- v2 chang

Re: [PATCH] input: st1232: set INPUT_PROP_DIRECT property

2018-10-05 Thread Dmitry Torokhov
On Fri, Oct 05, 2018 at 10:14:07AM +0200, Martin Kepplinger wrote: > This is how userspace checks for touchscreen devices most reliably. > > Signed-off-by: Martin Kepplinger Applied, thank you. > --- > drivers/input/touchscreen/st1232.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[PATCH v2 1/2] mfd: cros: add "base attached" MKBP switch definition

2018-10-05 Thread Dmitry Torokhov
This adds a "base attached" switch definition to the MKBP protocol that is used by Whiskers driver to properly determine device state (clamshell vs tablet mode). Signed-off-by: Dmitry Torokhov --- v2 changes: None Lee, I was wondering if it would be OK for cros_ec_commands.h to

[PATCH v2 2/2] HID: google: add support tablet mode switch for Whiskers

2018-10-05 Thread Dmitry Torokhov
Whiskers is a foldable base, and thus requires combining "base presence" signal coming from EC with base state signal (folded/unfolded) coming from USB/HID interface to produce proper SW_TABLET_MODE event. Signed-off-by: Nicolas Boichat Signed-off-by: Dmitry Torokhov --- v2 changes (

[PATCH] Input: uinput - add a schedule point in uinput_inject_events()

2018-10-04 Thread Dmitry Torokhov
Large writes to uinput interface may cause rcu stalls. Let's add cond_resched() to the loop to avoid this. Signed-off-by: Dmitry Torokhov --- drivers/input/misc/uinput.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c index

[PATCH] Input: evdev - add a schedule point in evdev_write()

2018-10-04 Thread Dmitry Torokhov
Large writes to evdev interface may cause rcu stalls. Let's add cond_resched() to the loop to avoid this. Signed-off-by: Dmitry Torokhov --- drivers/input/evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index 370206f987f9..f48369d6f3a0

Re: [PATCH] Input: mousedev - add a schedule point in mousedev_write()

2018-10-04 Thread Dmitry Torokhov
On Thu, Oct 04, 2018 at 12:34:07PM -0700, Paul E. McKenney wrote: > On Thu, Oct 04, 2018 at 11:59:49AM -0700, Dmitry Torokhov wrote: > > Hi Eric, > > > > On Thu, Oct 04, 2018 at 08:47:49AM -0700, Eric Dumazet wrote: > > > syzbot was able to trigger rcu stalls by ca

Re: [PATCH] Input: mousedev - add a schedule point in mousedev_write()

2018-10-04 Thread Dmitry Torokhov
On October 4, 2018 12:28:56 PM PDT, Eric Dumazet wrote: >On Thu, Oct 4, 2018 at 11:59 AM Dmitry Torokhov > wrote: >> >> Hi Eric, >> >> On Thu, Oct 04, 2018 at 08:47:49AM -0700, Eric Dumazet wrote: >> > syzbot was able to trigger rcu stalls by calling

Re: [PATCH v2] Input: reserve 2 events code because of HID

2018-10-04 Thread Dmitry Torokhov
are reserved and should not > be used so userspace can properly work around those old kernels. > > Signed-off-by: Benjamin Tissoires > --- > > Dmitry, I did not take your Acked-by, as I added 2 new events and wanted to > be sure you are still OK. Yes, this is still fine. Ac

Re: [PATCH] Input: mousedev - add a schedule point in mousedev_write()

2018-10-04 Thread Dmitry Torokhov
org/lkml/2018/8/23/1106 > Signed-off-by: Eric Dumazet > Reported-by: syzbot+9436b02171ac0894d...@syzkaller.appspotmail.com > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > --- > drivers/input/mousedev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [PATCH] cpufreq: dt-platdev: mark RK3399 as having separate policies per cluster

2018-10-02 Thread Dmitry Torokhov
On Tue, Oct 2, 2018 at 9:41 PM Viresh Kumar wrote: > > On 01-10-18, 13:21, Dmitry Torokhov wrote: > > RK3399 has one cluster with 4 small cores, and another one with 2 big > > cores, with cores in different clusters having different OPPs and thus > > different policie

Re: [PATCH 2/2] HID: google: add Whiskers driver to handle tablet mode properly

2018-10-02 Thread Dmitry Torokhov
Hi Benjamin, On Tue, Oct 2, 2018 at 1:53 AM Benjamin Tissoires wrote: > > Hi Dmitry, > > On Mon, Oct 1, 2018 at 11:39 PM Dmitry Torokhov wrote: > > > > This adds dedicated "Whiskers" driver that hooks both into HID and EC to > > produce proper SW_TABLET_

Re: [PATCH] input: xilinx_ps2: Convert to using %pOFn instead of device_node.name

2018-10-01 Thread Dmitry Torokhov
On Mon, Oct 01, 2018 at 04:43:49PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Dmitry Torokhov > Cc: Michal Simek > Cc: linux-in...@vger.kernel.org &

[PATCH 1/2] mfd: cros: add "base attached" MKBP switch definition

2018-10-01 Thread Dmitry Torokhov
This adds a "base attached" switch definition to the MKBP protocol that is used by Whiskers driver to properly determine device state (clamshell vs tablet mode). Signed-off-by: Dmitry Torokhov --- Lee, I was wondering if it woudl be OK for cros_ec_commands.h to be merged throug

[PATCH 2/2] HID: google: add Whiskers driver to handle tablet mode properly

2018-10-01 Thread Dmitry Torokhov
This adds dedicated "Whiskers" driver that hooks both into HID and EC to produce proper SW_TABLET_SWITCH event from base presence bit from EC and base state (folded/unfolded) coming from USB/HID. Signed-off-by: Nicolas Boichat Signed-off-by: Dmitry Torokhov --- drivers/h

[PATCH] cpufreq: dt-platdev: mark RK3399 as having separate policies per cluster

2018-10-01 Thread Dmitry Torokhov
RK3399 has one cluster with 4 small cores, and another one with 2 big cores, with cores in different clusters having different OPPs and thus different policies. Let's enable this via "have_governor_per_policy" platform data. Signed-off-by: Dmitry Torokhov --- Not tested, but we h

Re: [PATCH] Input: Support for Xbox1 PDP Camo series gamepad

2018-09-28 Thread Dmitry Torokhov
On Tue, Aug 28, 2018 at 12:48:11AM -0500, Ramses Ramírez wrote: > The "Xbox One PDP Wired Controller - Camo series" has a different > product-id than the regular PDP controller and the PDP stealth series, > but it uses the same initialization sequence. This patch adds the > product-id of the camo

Re: [PATCH] input: sun4i-lradc: Convert to using %pOFn instead of device_node.name

2018-09-28 Thread Dmitry Torokhov
On Mon, Aug 27, 2018 at 08:52:24PM -0500, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Hans de Goede > Cc: Dmitry Torokhov > Cc: Maxime Ripard > Cc: linux-

[git pull] Input updates for v4.19-rc5

2018-09-28 Thread Dmitry Torokhov
Hi Greg, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Just a few driver fixes. Changelog: - Aaron Ma (1): Input: elantech - enable middle button of touchpad on ThinkPad P72 Andreas

Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards

2018-09-24 Thread Dmitry Torokhov
On Mon, Sep 24, 2018 at 04:20:50PM +0300, Heikki Krogerus wrote: > Hi Dmitry, > > On Fri, Sep 21, 2018 at 04:31:19PM -0700, Dmitry Torokhov wrote: > > > > + if (!parent_pset) > > > > + return ERR_PTR(-EINVAL); > > > > + &

Re: WARNING: kmalloc bug in input_mt_init_slots

2018-09-24 Thread Dmitry Torokhov
On Mon, Sep 24, 2018 at 03:55:04PM +, Christopher Lameter wrote: > On Mon, 24 Sep 2018, Dmitry Vyukov wrote: > > > On Mon, Sep 24, 2018 at 5:08 PM, Christopher Lameter wrote: > > > On Sun, 23 Sep 2018, Dmitry Vyukov wrote: > > > > > >> What was the motivation behind that WARNING about large

Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards

2018-09-21 Thread Dmitry Torokhov
On Thu, Sep 20, 2018 at 01:16:48PM +0300, Heikki Krogerus wrote: > On Wed, Sep 19, 2018 at 10:13:26AM -0700, Dmitry Torokhov wrote: > > > > diff --git a/drivers/base/pset_property.c b/drivers/base/pset_property.c > > > > index 08ecc13080ae..63f2377aefe8 100644

Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards

2018-09-21 Thread Dmitry Torokhov
Hi Heikki, On Thu, Sep 20, 2018 at 04:53:48PM +0300, Heikki Krogerus wrote: > Hi Dmitry, > > On Mon, Sep 17, 2018 at 11:16:00AM -0700, Dmitry Torokhov wrote: > > +/** > > + * device_add_child_properties - Add a collection of properties to a > > device object.

Re: WARNING: kmalloc bug in input_mt_init_slots

2018-09-21 Thread Dmitry Torokhov
On Fri, Sep 21, 2018 at 10:24 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:234b69e3e089 ocfs2: fix ocfs2 read block panic > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=131f761a40 > kernel config:

Re: [RESEND PATCH V6 3/3] Input: new da7280 haptic driver

2018-09-19 Thread Dmitry Torokhov
Hi Roy, On Wed, Sep 19, 2018 at 07:35:04PM +0900, Roy Im wrote: > > Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with > multiple mode and integrated waveform memory and wideband support. > It communicates via an I2C bus to the device. > > Signed-off-by: Roy Im > > --- > v6: No

Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards

2018-09-19 Thread Dmitry Torokhov
Hi Heikki, On Wed, Sep 19, 2018 at 06:10:26PM +0300, Heikki Krogerus wrote: > Hi, > > On Mon, Sep 17, 2018 at 11:16:00AM -0700, Dmitry Torokhov wrote: > > Several drivers rely on having notion of sub-nodes when describing > > hardware, let's allow static board-defined

Re: [PATCH 01/20] Input: iforce - remove "being used" silliness

2018-09-19 Thread Dmitry Torokhov
On Wed, Sep 19, 2018 at 04:51:26PM +0200, Tim Schumacher wrote: > On 18.09.18 02:47, Dmitry Torokhov wrote: > > The kernel is supposed to handle multiple devices, static flags > > in packet handling code will never work. > > > > Signed-off-by: Dmitry Torokhov > &

Re: linux-next: build failure after merge of the input-current tree

2018-09-18 Thread Dmitry Torokhov
On Tue, Sep 18, 2018 at 3:25 PM Stephen Rothwell wrote: > > Hi Dmitry, > > After merging the input-current tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > ERROR: "mem_sleep_current" [drivers/input/serio/i8042.ko] undefined! > > Caused by commit > > 1685830e59d4

Re: [PATCH] Input: uinput - allow for max == min during input_absinfo validation

2018-09-18 Thread Dmitry Torokhov
On Tue, Sep 18, 2018 at 01:13:47PM +0200, Martin Kepplinger wrote: > On 9/18/18 7:22 AM, Peter Hutterer wrote: > > These values are inclusive, so a range of 1 requires min == max. > > > > Signed-off-by: Peter Hutterer > > true, nice catch. > > Reviewed-by: Martin Kepplinger Applied, thank

Re: [RFC/PATCH 4/5] gpiolib: add support for fetching descriptors from static properties

2018-09-18 Thread Dmitry Torokhov
Hi Mika, On Tue, Sep 18, 2018 at 12:02:19PM +0300, Mika Westerberg wrote: > Hi, > > On Mon, Sep 17, 2018 at 11:16:02AM -0700, Dmitry Torokhov wrote: > > Now that static device properties understand notion of child nodes, let's > > teach gpiolib to tie such children and ma

Re: [PATCH RESEND] phy: phy-twl4030-usb: fix denied runtime access

2018-09-18 Thread Dmitry Torokhov
On Tue, Sep 18, 2018 at 06:16:19PM +0200, Andreas Kemnade wrote: > Hi, > > On Mon, 17 Sep 2018 15:23:45 -0700 > Dmitry Torokhov wrote: > > > On Mon, Sep 17, 2018 at 08:56:34PM +0200, Andreas Kemnade wrote: > > > Hi Dmitry, > > > > > > On Mon,

Re: [PATCH] Input: elantech - enable middle button of touchpad on ThinkPad P72

2018-09-18 Thread Dmitry Torokhov
On Fri, Sep 07, 2018 at 03:06:51PM +0800, Aaron Ma wrote: > Adding 2 new touchpad IDs to support middle button support. > > Cc: sta...@vger.kernel.org > Signed-off-by: Aaron Ma Applied, thank you. > --- > drivers/input/mouse/elantech.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[PATCH 03/20] Input: iforce - move get_id to the transport operations

2018-09-17 Thread Dmitry Torokhov
To avoid #ifdef-ing out parts of the code and having conditionals in normal control flow, let's define "get_id" transport method and move implementation into respective transport modules. Signed-off-by: Dmitry Torokhov --- .../input/joystick/iforce/iforce-packets

[PATCH 13/20] Input: iforce - signal command completion from transport code

2018-09-17 Thread Dmitry Torokhov
into individual transport modules. Signed-off-by: Dmitry Torokhov --- drivers/input/joystick/iforce/iforce-packets.c | 2 -- drivers/input/joystick/iforce/iforce-serio.c | 9 ++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/input/joystick/iforce/iforce-packets.c b

[PATCH 10/20] Input: iforce - update formatting of switch statements

2018-09-17 Thread Dmitry Torokhov
According to our coding style case labels in switch statements should be aligned with the switch keyword. Signed-off-by: Dmitry Torokhov --- drivers/input/joystick/iforce/iforce-ff.c | 18 +-- drivers/input/joystick/iforce/iforce-main.c | 70 +-- .../input/joystick/iforce/iforce

  1   2   3   4   5   6   7   8   9   10   >