Re: Future of dosfstools project (FAT)

2018-10-12 Thread Doug Goldstein
> On Oct 12, 2018, at 7:40 AM, Pali Rohár wrote: > >> On Friday 12 October 2018 11:19:41 Andreas Henriksson wrote: >> Hello everyone, >> >>> On Tue, Oct 02, 2018 at 04:44:10AM -0400, Jaroslav Skarvada wrote: >>> I am downstream maintainer of dosfstools in Fedora/RHEL. My personal opinion >>>

Re: Future of dosfstools project (FAT)

2018-10-12 Thread Doug Goldstein
> On Oct 12, 2018, at 7:40 AM, Pali Rohár wrote: > >> On Friday 12 October 2018 11:19:41 Andreas Henriksson wrote: >> Hello everyone, >> >>> On Tue, Oct 02, 2018 at 04:44:10AM -0400, Jaroslav Skarvada wrote: >>> I am downstream maintainer of dosfstools in Fedora/RHEL. My personal opinion >>>

Re: [Xen-devel] [PATCHv3 0/2] libfs, xenfs: replace /proc/xen/xenbus with a symlink

2016-08-22 Thread Doug Goldstein
kernel release go out the door where the default behavior with Xen 4.6 and earlier is to deadlock domUs. -- Doug Goldstein signature.asc Description: OpenPGP digital signature

Re: [Xen-devel] [PATCHv3 0/2] libfs, xenfs: replace /proc/xen/xenbus with a symlink

2016-08-22 Thread Doug Goldstein
kernel release go out the door where the default behavior with Xen 4.6 and earlier is to deadlock domUs. -- Doug Goldstein signature.asc Description: OpenPGP digital signature

Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs

2016-02-04 Thread Doug Goldstein
>> Lots of hard-coded values here. Should this be #defined somewhere? > > We also don't need to set bases to zero since hctxt is kzalloc'd. I'll > remove that and add a comment. > > As for macros --- I couldn't find the bits defined symbolically anywhere > and since

Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs

2016-02-04 Thread Doug Goldstein
>> Lots of hard-coded values here. Should this be #defined somewhere? > > We also don't need to set bases to zero since hctxt is kzalloc'd. I'll > remove that and add a comment. > > As for macros --- I couldn't find the bits defined symbolically anywhere > and since

Re: [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-02 Thread Doug Goldstein
On 12/2/15 4:35 AM, David Vrabel wrote: > On 26/11/15 20:32, Doug Goldstein wrote: >> When allocating a pciback device fails, avoid the possibility of a >> use after free. > > We should not require clearing drvdata for correctness. We should > ensure we retain drvdata for

Re: [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-02 Thread Doug Goldstein
On 12/2/15 4:35 AM, David Vrabel wrote: > On 26/11/15 20:32, Doug Goldstein wrote: >> When allocating a pciback device fails, avoid the possibility of a >> use after free. > > We should not require clearing drvdata for correctness. We should > ensure we retain drvdata for

Re: [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Doug Goldstein
On 12/1/15 1:35 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 01, 2015 at 11:47:17AM -0500, Konrad Rzeszutek Wilk wrote: >> On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: >>> When allocating a pciback device fails, avoid the possibility of a >>> use

Re: [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Doug Goldstein
On 12/1/15 10:47 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: >> When allocating a pciback device fails, avoid the possibility of a >> use after free. > > Reviewed-by: Konrad Rzeszutek Wilk > > Ugh, and it

Re: [Xen-devel] [PATCH 1/2] xen: wrap xenbus on xenfs with COMPAT option

2015-12-01 Thread Doug Goldstein
On 12/1/15 4:44 AM, David Vrabel wrote: > On 01/12/15 10:42, David Vrabel wrote: >> On 30/11/15 21:35, Doug Goldstein wrote: >>> Since Xen 4.6.0, using xenbus via xenfs (/proc/xen/xenbus) is deprecated >>> and /dev/xen/xenbus via pvops is used instead. This is an ef

Re: [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Doug Goldstein
On 12/1/15 1:35 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 01, 2015 at 11:47:17AM -0500, Konrad Rzeszutek Wilk wrote: >> On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: >>> When allocating a pciback device fails, avoid the possibility of a >>> use

Re: [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-01 Thread Doug Goldstein
On 12/1/15 10:47 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 26, 2015 at 02:32:39PM -0600, Doug Goldstein wrote: >> When allocating a pciback device fails, avoid the possibility of a >> use after free. > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>

Re: [Xen-devel] [PATCH 1/2] xen: wrap xenbus on xenfs with COMPAT option

2015-12-01 Thread Doug Goldstein
On 12/1/15 4:44 AM, David Vrabel wrote: > On 01/12/15 10:42, David Vrabel wrote: >> On 30/11/15 21:35, Doug Goldstein wrote: >>> Since Xen 4.6.0, using xenbus via xenfs (/proc/xen/xenbus) is deprecated >>> and /dev/xen/xenbus via pvops is used instead. This is an ef

[PATCH 1/2] xen: wrap xenbus on xenfs with COMPAT option

2015-11-30 Thread Doug Goldstein
Since Xen 4.6.0, using xenbus via xenfs (/proc/xen/xenbus) is deprecated and /dev/xen/xenbus via pvops is used instead. This is an effort to eventually drop this interface after a reasonable amount of time. Signed-off-by: Doug Goldstein --- drivers/xen/Kconfig | 12 drivers

[PATCH 2/2] xen: wrap privcmd on xenfs with COMPAT option

2015-11-30 Thread Doug Goldstein
Since Xen 4.7.0, using privcmd via xenfs (/proc/xen/privcmd) is deprecated and /dev/xen/privcmd via pvops is used instead. This is an effort to eventually drop this interface after a reasonable amount of time. Signed-off-by: Doug Goldstein --- drivers/xen/Kconfig | 12

[PATCH 2/2] xen: wrap privcmd on xenfs with COMPAT option

2015-11-30 Thread Doug Goldstein
Since Xen 4.7.0, using privcmd via xenfs (/proc/xen/privcmd) is deprecated and /dev/xen/privcmd via pvops is used instead. This is an effort to eventually drop this interface after a reasonable amount of time. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- drivers/xen/Kconfig

[PATCH 1/2] xen: wrap xenbus on xenfs with COMPAT option

2015-11-30 Thread Doug Goldstein
Since Xen 4.6.0, using xenbus via xenfs (/proc/xen/xenbus) is deprecated and /dev/xen/xenbus via pvops is used instead. This is an effort to eventually drop this interface after a reasonable amount of time. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- drivers/xen/Kconfig

[PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-11-26 Thread Doug Goldstein
When allocating a pciback device fails, avoid the possibility of a use after free. Reported-by: Jonathan Creekmore Signed-off-by: Doug Goldstein --- drivers/xen/xen-pciback/xenbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/xenbus.c b

[PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-11-26 Thread Doug Goldstein
When allocating a pciback device fails, avoid the possibility of a use after free. Reported-by: Jonathan Creekmore <jonathan.creekm...@gmail.com> Signed-off-by: Doug Goldstein <car...@cardoe.com> --- drivers/xen/xen-pciback/xenbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

2015-03-25 Thread Doug Goldstein
On Wed, Mar 25, 2015 at 3:44 AM, Johan Hovold wrote: > On Mon, Mar 23, 2015 at 08:34:48PM -0500, Doug Goldstein wrote: >> This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order >> to avoid attaching a TTY to the JTAG port as this board is based on the >> CA

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

2015-03-25 Thread Doug Goldstein
On Wed, Mar 25, 2015 at 3:44 AM, Johan Hovold jo...@kernel.org wrote: On Mon, Mar 23, 2015 at 08:34:48PM -0500, Doug Goldstein wrote: This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order to avoid attaching a TTY to the JTAG port as this board is based on the CALAO Systems

[PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

2015-03-23 Thread Doug Goldstein
This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order to avoid attaching a TTY to the JTAG port as this board is based on the CALAO Systems reference design and needs the same fix up. Signed-off-by: Doug Goldstein CC: stable --- drivers/usb/serial/ftdi_sio.c | 3 ++- 1 file

[PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

2015-03-23 Thread Doug Goldstein
This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order to avoid attaching a TTY to the JTAG port as this board is based on the CALAO Systems reference design and needs the same fix up. Signed-off-by: Doug Goldstein car...@cardoe.com CC: stable sta...@vger.kernel.org --- drivers

[PATCH] USB: ftdi_sio: Added custom PID for Synapse Wireless product

2015-03-15 Thread Doug Goldstein
Synapse Wireless uses the FTDI VID with a custom PID of 0x9090 for their SNAP Stick 200 product. Signed-off-by: Doug Goldstein --- drivers/usb/serial/ftdi_sio.c | 1 + drivers/usb/serial/ftdi_sio_ids.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/usb/serial/ftdi_sio.c

[PATCH] USB: ftdi_sio: Added custom PID for Synapse Wireless product

2015-03-15 Thread Doug Goldstein
Synapse Wireless uses the FTDI VID with a custom PID of 0x9090 for their SNAP Stick 200 product. Signed-off-by: Doug Goldstein car...@cardoe.com --- drivers/usb/serial/ftdi_sio.c | 1 + drivers/usb/serial/ftdi_sio_ids.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/usb

Re: [BUG 3.7-rc5] NULL pointer deref when using a pcie-pci bridged pci device and intel-iommu

2012-11-12 Thread Doug Goldstein
6:3432 +-16.3 8086:3433 +-16.4 8086:3429 +-16.5 8086:342a +-16.6 8086:342b +-16.7 8086:342c +-1a.0 8086:3a37 +-1a.1 8086:3a38 +-1a.2 8086:3a39 +-1a.7 8086:3a3c +-1d.0

Re: [BUG 3.7-rc5] NULL pointer deref when using a pcie-pci bridged pci device and intel-iommu

2012-11-12 Thread Doug Goldstein
+-1d.7 8086:3a3a +-1e.0-[07]01.0 102b:0532 +-1f.0 8086:3a16 +-1f.2 8086:3a22 \-1f.3 8086:3a30 If someone can craft the correct patch that'd be great or answer the above question and I'll gladly craft it. Thanks. -- Doug Goldstein

Re: [PATCH] vlan: set sysfs device_type to 'vlan'

2012-11-04 Thread Doug Goldstein
On Sun, Nov 4, 2012 at 11:53 PM, David Miller wrote: > From: Doug Goldstein > Date: Sun, 4 Nov 2012 23:45:56 -0600 > >> As Ben Greear pointed out this would allow shell scripts and other >> scripting languages to better detect vlans. Kay pointed out that this >> would

Re: [PATCH] vlan: set sysfs device_type to 'vlan'

2012-11-04 Thread Doug Goldstein
On Tue, Oct 23, 2012 at 1:36 AM, David Miller wrote: > From: Doug Goldstein > Date: Mon, 22 Oct 2012 00:53:57 -0500 > >> Sets the sysfs device_type to 'vlan' for udev. This makes it easier for >> applications that query network information via udev to identify vlans >&g

Re: [PATCH] vlan: set sysfs device_type to 'vlan'

2012-11-04 Thread Doug Goldstein
On Tue, Oct 23, 2012 at 1:36 AM, David Miller da...@davemloft.net wrote: From: Doug Goldstein car...@cardoe.com Date: Mon, 22 Oct 2012 00:53:57 -0500 Sets the sysfs device_type to 'vlan' for udev. This makes it easier for applications that query network information via udev to identify vlans

Re: [PATCH] vlan: set sysfs device_type to 'vlan'

2012-11-04 Thread Doug Goldstein
On Sun, Nov 4, 2012 at 11:53 PM, David Miller da...@davemloft.net wrote: From: Doug Goldstein car...@cardoe.com Date: Sun, 4 Nov 2012 23:45:56 -0600 As Ben Greear pointed out this would allow shell scripts and other scripting languages to better detect vlans. Kay pointed out that this would

[PATCH] vlan: set sysfs device_type to 'vlan'

2012-10-21 Thread Doug Goldstein
Sets the sysfs device_type to 'vlan' for udev. This makes it easier for applications that query network information via udev to identify vlans instead of using strrchr(). Signed-off-by: Doug Goldstein --- Pre-patch output: swanson ~ # udevadm info -q all -p /sys/devices/virtual/net/br0.4 P

[PATCH] vlan: set sysfs device_type to 'vlan'

2012-10-21 Thread Doug Goldstein
Sets the sysfs device_type to 'vlan' for udev. This makes it easier for applications that query network information via udev to identify vlans instead of using strrchr(). Signed-off-by: Doug Goldstein car...@cardoe.com --- Pre-patch output: swanson ~ # udevadm info -q all -p /sys/devices/virtual