Re: [Xen-devel] [PATCH v2 4/4] xen-blkif: drop struct blkif_request_segment_aligned

2014-02-12 Thread Egger, Christoph
d patch 2 and 3. > Tested-by: Christoph Egger Reviewed-by: Christoph Egger Christoph -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Xen-devel] [PATCH v2 3/4] xen-blkback: fix shutdown race

2014-02-12 Thread Egger, Christoph
safely free xen_blkif, which >> was not the case before. > > Tested-by: Matt Rushton > Reviewed-by: Matt Rushton Tested-by: Christoph Egger Reviewed-by: Christoph Egger Christoph -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [Xen-devel] [PATCH v2 2/4] xen-blkback: fix memory leaks

2014-02-12 Thread Egger, Christoph
grants to the >> persistent_gnts red-black tree. Fixed by moving the persistent >> grants and free_pages cleanup code to xen_blkif_free. >> >> Also, add some checks in xen_blkif_free to make sure we are cleaning >> everything. > > Tested-by: Matt Rushton >

Re: [Xen-devel] [PATCH v2 2/4] xen-blkback: fix memory leaks

2014-02-12 Thread Egger, Christoph
On 07.02.14 04:15, Matthew Rushton wrote: On 04/02/14 10:26, Roger Pau Monne wrote: I've at least identified two possible memory leaks in blkback, both related to the shutdown path of a VBD: - blkback doesn't wait for any pending purge work to finish before cleaning the list of

Re: [Xen-devel] [PATCH v2 3/4] xen-blkback: fix shutdown race

2014-02-12 Thread Egger, Christoph
On 07.02.14 04:23, Matthew Rushton wrote: On 04/02/14 10:26, Roger Pau Monne wrote: Introduce a new variable to keep track of the number of in-flight requests. We need to make sure that when xen_blkif_put is called the request has already been freed and we can safely free xen_blkif, which was

Re: [Xen-devel] [PATCH v2 4/4] xen-blkif: drop struct blkif_request_segment_aligned

2014-02-12 Thread Egger, Christoph
On 07.02.14 04:38, Matthew Rushton wrote: This was wrongly introduced in commit 402b27f9, the only difference between blkif_request_segment_aligned and blkif_request_segment is that the former has a named padding, while both share the same memory layout. Also correct a few minor glitches in

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Egger, Christoph
On 23.01.14 20:28, Matt Wilson wrote: > From: Matt Rushton > > Currently shrink_free_pagepool() is called before the pages used for > persistent grants are released via free_persistent_gnts(). This > results in a memory leak when a VBD that uses persistent grants is > torn down. This memory

Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used

2014-01-24 Thread Egger, Christoph
On 23.01.14 20:28, Matt Wilson wrote: From: Matt Rushton mrush...@amazon.com Currently shrink_free_pagepool() is called before the pages used for persistent grants are released via free_persistent_gnts(). This results in a memory leak when a VBD that uses persistent grants is torn down.

Re: [Xen-devel] [PATCH RFC 4/4] xen-block: introduce a new request type to unmap grants

2013-07-10 Thread Egger, Christoph
On 10.07.13 11:19, Roger Pau Monné wrote: > On 08/07/13 21:41, Konrad Rzeszutek Wilk wrote: >> On Mon, Jul 08, 2013 at 03:03:27PM +0200, Roger Pau Monne wrote: >>> Right now blkfront has no way to unmap grant refs, if using persistent >>> grants once a grant is used blkfront cannot assure if

Re: [Xen-devel] [PATCH RFC 4/4] xen-block: introduce a new request type to unmap grants

2013-07-10 Thread Egger, Christoph
On 10.07.13 11:19, Roger Pau Monné wrote: On 08/07/13 21:41, Konrad Rzeszutek Wilk wrote: On Mon, Jul 08, 2013 at 03:03:27PM +0200, Roger Pau Monne wrote: Right now blkfront has no way to unmap grant refs, if using persistent grants once a grant is used blkfront cannot assure if blkback will