I prepared a proposed patch to address these concerns:
https://lists.oasis-open.org/archives/virtio-dev/202104/msg7.html
Feedback will be much appreciated
Thanks,
- Enrico
On Tue, Apr 20, 2021 at 4:08 AM Michael S. Tsirkin wrote:
>
> On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellw
in the same manner as the files of the same name
for the eMMC driver, in line with the VirtIO specification.
Signed-off-by: Enrico Granata
---
Changes in v2:
- Removed redudnant buffer size checks
- Renamed variables for consistency
- Cleaned up endianness
drivers/block/virtio_blk.c
First and foremost thanks for the feedback on the code. I will send
out an up-to-date patch with those comments addressed ASAP
As for the broader issue, I am definitely happy to incorporate any
feedback and work to improve the spec, but looking at embedded storage
devices both eMMC and UFS seem to
in the same manner as the files of the same name
for the eMMC driver, in line with the VirtIO specification.
Signed-off-by: Enrico Granata
---
drivers/block/virtio_blk.c | 76 -
include/uapi/linux/virtio_blk.h | 11 +
2 files changed, 86 insertions(+), 1
it may be that I was the only one
confused by that. If so, feel free to disregard the patch.
Thanks,
- Enrico
Thanks,
- Enrico
On Sat, Aug 10, 2019 at 1:15 AM Christoph Hellwig wrote:
>
> On Wed, Aug 07, 2019 at 05:52:55PM -0700, egran...@chromium.org wrote:
> > From: Enrico Grana
On Mon, Jul 29, 2019 at 2:03 PM Brian Norris wrote:
>
> On Mon, Jul 29, 2019 at 1:54 PM Nathan Chancellor
> wrote:
> > On Mon, Jul 29, 2019 at 01:49:54PM -0700, Brian Norris wrote:
> > > Side note: it might have helped alleviate some of this pain if there
> > > were email notifications to the mai
ically
>documents (and enforces) that 0 is not a valid return value (noted on
>the v3 review)
> * adding a small comment
>
> Reported-by: Brian Norris
> Reported-by: Salvatore Bellizzi
> Cc: Enrico Granata
> Cc:
> Fixes: daaef255dc96 ("driver: platform: S
On Thu, Jun 13, 2019 at 11:54 PM Ting Shen wrote:
>
> http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to
> the event_type field, the receiver side should mask out this extra bit when
> processing the event.
>
> Signed-off-by: Ting Shen
Reviewed-
Because I did not know about it till right now. Thanks for the
suggestion. Will upload a v2 as soon as I get a chance.
On Wed, Apr 3, 2019 at 12:53 PM Guenter Roeck wrote:
>
> On Wed, Apr 3, 2019 at 12:40 PM Enrico Granata wrote:
> >
> > I can certainly add a "did_print_e
ks
Enrico Granata | egran...@google.com | ChromeOS | MTV1600
On Wed, Apr 3, 2019 at 11:51 AM Guenter Roeck wrote:
>
> On Wed, Apr 3, 2019 at 11:31 AM wrote:
> >
> > From: Enrico Granata
> >
> > As new transfer mechanisms are added to the EC codebase, they m
contract about returning -ENXIO specifically).
I am happy to post a PATCH v3 to that effect if this seems amenable.
Thanks
Enrico Granata | egran...@google.com | ChromeOS | MTV1600
On Wed, Feb 20, 2019 at 10:05 AM Brian Norris wrote:
>
> Hi,
>
> On Mon, Feb 11, 2019 at 11:01:12AM
s below.
>
> > On Thu, Feb 7, 2019 at 7:59 PM wrote:
> > >
> > > From: Enrico Granata
> > >
> > > ACPI 5 added support for GpioInt resources as a way to provide
> > > information about interrupts mediated via a GPIO controller.
> > >
From: Enrico Granata
This driver allows interfacing with the Semtech sx9320, sx9321 and sx9324
proximity sensors via the IIO subsystem.
Signed-off-by: Enrico Granata
---
.../bindings/iio/proximity/sx932x.txt | 54 +
drivers/iio/proximity/Kconfig | 36 +-
drivers
From: Enrico Granata
This commit allows cros_ec_lpc to register a direct IRQ instead of relying
on the ACPI notification chain to receive MKBP events.
This change is done in the interest of allowing reduced jitter in the
communication path between the CrOS EC and the host for receiving sensor
From: Enrico Granata
This commit allows cros_ec_lpc to register a direct IRQ instead of relying
on the ACPI notification chain to receive MKBP events.
This change is done in the interest of allowing reduced jitter in the
communication path between the CrOS EC and the host for receiving sensor
From: Enrico Granata
Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.
Signed-off-by: Enrico Granata
Signed-off-by: Enrico Granata
---
drivers/mfd/cros_ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Enrico Granata
If one builds the Chrome EC support as modules, there is no explicit
dependency chain amongst the several modules (LPC, CHARDEV, CORE, ...)
This makes it possible - for instance - to rmmod cros_ec_core, even though
cros_ec_dev actively uses it for data transport to the EC
From: Enrico Granata
If one builds the Chrome EC support as modules, there is no explicit
dependency chain amongst the several modules (LPC, CHARDEV, CORE, ...)
This makes it possible - for instance - to rmmod cros_ec_core, even though
cros_ec_dev actively uses it for data transport to the EC
From: Enrico Granata
If one builds the Chrome EC support as modules, there is no explicit
dependency chain amongst the several modules (LPC, CHARDEV, CORE, ...)
This makes it possible - for instance - to rmmod cros_ec_core, even though
cros_ec_dev actively uses it for data transport to the EC
19 matches
Mail list logo
