Re: [RFC PATCH] overlayfs: support more than one read-only layer

Indeed, Miklos, changing layers dynamically is VERY tricky. Unionfs supports that, but a good amount of its code all over is dedicated to handling dynamic layer changes. I advise you to avoid supporting this feature for a while, if ever: get a small, functional, working overlayfs first. I

Re: [RFC PATCH] overlayfs: support more than one read-only layer

Indeed, Miklos, changing layers dynamically is VERY tricky. Unionfs supports that, but a good amount of its code all over is dedicated to handling dynamic layer changes. I advise you to avoid supporting this feature for a while, if ever: get a small, functional, working overlayfs first. I

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

I tend to agree with Al's and Linus's POV regarding whiteouts. There are three general techniques to implementing whiteouts: 1. namespace: special file names, hard/symlinks, or special "hidden" dot files. 2. extended attributes. 3. DT_WHT dirent flags. (there's actually a 4th method I've tried

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

I tend to agree with Al's and Linus's POV regarding whiteouts. There are three general techniques to implementing whiteouts: 1. namespace: special file names, hard/symlinks, or special hidden dot files. 2. extended attributes. 3. DT_WHT dirent flags. (there's actually a 4th method I've tried

Re: [2.6 patch] make vfs_ioctl() static

In message <[EMAIL PROTECTED]>, Christoph Hellwig writes: > On Sun, Feb 17, 2008 at 10:18:42AM +0200, Adrian Bunk wrote: > > This patch makes the needlessly global vfs_ioctl() static. > > I think the point was toa eventually export it for stackable filesystem > use. But until they start using it

Re: [2.6 patch] make vfs_ioctl() static

In message [EMAIL PROTECTED], Christoph Hellwig writes: On Sun, Feb 17, 2008 at 10:18:42AM +0200, Adrian Bunk wrote: This patch makes the needlessly global vfs_ioctl() static. I think the point was toa eventually export it for stackable filesystem use. But until they start using it marking

Re: unionfs_copy_attr_times oopses

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > Hi Erez, > > Aside from the occasional "unionfs: new lower inode mtime" messages > on directories (which I've got into the habit of ignoring now), the > only problem I'm still suffering with unionfs over tmpfs (not tested > any other fs's

[PATCH 11/17] Unionfs: lock parents' branch configuration fixes

Ensure that we lock the branch configuration of parent and child dentries in operations which need it, and in the right order. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 31 +--- fs/unionfs/dentry.c | 26 +-

[PATCH 14/17] Unionfs: stop using iget() and read_inode()

error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c | 11 +-- fs/unionfs/super.c | 19 +++

[PATCH 06/17] Unionfs: extend dentry branch configuration lock in open

Dentry branch configuration "info node" lock should extend to calls to copy_attr_times. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/fs/unionfs/commonfop

[PATCH 15/17] Unionfs: embed a struct path into struct nameidata instead of nd dentrymnt

From: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/ino

[PATCH 13/17] Unionfs: use dget_parent in revalidation code

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index a956b94..f8f65e1 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs/dentry.c @@ -410,15 +

[PATCH 05/17] Unionfs: initialize path_save variable

This is not strictly necessary, but it helps quiet a gcc-4.2 warning (a good optimizer may optimize this initialization away). Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/inode.c |2 +- 1 files changed, 1 inse

[PATCH 10/17] Unionfs: factor out revalidation routine

To be used by rest of revalidation code, as well a callers who already locked the child and parent dentry branch-configurations. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 87 +++--- fs/unionfs/union.h |3 ++ 2

[PATCH 08/17] Unionfs: improve debugging in copy_attr_times

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/subr.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c index 68a6280..1a40f63 100644 --- a/fs/unionfs/subr.c +++ b/fs/unionfs/subr.c @@ -247,8 +247,14 @

[PATCH 16/17] Unionfs: use the new path_put

k <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c |2 +- fs/unionfs/super.c

[PATCH 12/17] Unionfs: branch management/configuration fixes

Remove unnecessary calls to update branch m/ctimes, and use them only when needed. Update branch vfsmounts after operations that could cause a copyup. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |9 +++-- fs/unionfs/copyup.c |3 ++- fs/u

[PATCH 04/17] Unionfs: uninline unionfs_copy_attr_times and unionfs_copy_attr_all

This reduces text size by about 6k. Cc: Hugh Dickins <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/fanout.h | 50 -- fs/unionfs/subr.c | 50 ++

[PATCH 17/17] VFS/Unionfs: use generic path_get/path_put functions

Remove unionfs's versions thereof. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c | 10 +- fs/unionfs/super.c| 27 ++- include/linux/namei.h | 12 3 files changed, 19 insertions(+), 30 deletions(-) diff --gi

[PATCH 09/17] Unionfs: revalidation code cleanup and refactoring

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 55 -- 1 files changed, 35 insertions(+), 20 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index cd15243..afa2120 100644 --- a/fs/unionfs/dentry.c

[PATCH 02/17] Unionfs: ensure consistent lower inodes types

TED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/lookup.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index b9ee072..755158e 100644 --- a/fs/unionfs/lookup.c +++ b/fs/unionfs/lookup.c @@ -2

[PATCH 07/17] Unionfs: follow_link locking fixes

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 8d939dc..6377533 100644 --- a/fs/unionfs/inode.c +++ b/fs/unionfs/inode.c @@ -820,7 +820,11 @@

[PATCH 03/17] Unionfs: document behavior when the lower topology changes

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- Documentation/filesystems/unionfs/concepts.txt | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Documentation/filesystems/unionfs/concepts.txt b/Documentation/filesystems/unionfs/concepts.txt index b

[PATCH 01/17] Unionfs: grab lower super_block references

This prevents the lower super_block from being destroyed too early, when a lower file system is being unmounted with MNT_FORCE or MNT_DETACH. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c |3 +++ fs/unionfs/super.c | 14 ++ fs/unionfs/union.h |2

[GIT PULL -mm] 00/17 Unionfs updates/fixes/cleanups

): Unionfs: embed a struct path into struct nameidata instead of nd dentrymnt David Howells (1): Unionfs: stop using iget() and read_inode() Erez Zadok (14): Unionfs: grab lower super_block references Unionfs: ensure consistent lower inodes types Unionfs: document behavior

[PATCH -mmotm] fs/sysfs/file.c d_path fix

it for me. Cheers, Erez. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 02223e2..a57b024 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -329,9 +329,11 @@ static int sysfs_open_file(struct inode *inode, struct file *file)

[PATCH -mmotm] one more reject fix in arch/x86/Kconfig

Using mmotm-2008-02-15-11-03, I get $ make ARCH=i386 HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/kxgettext.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf -s arch/x86/Kconfig arch/x86/Kconfig:24: unknown option "HEAD" arch/x86/Kconfig:30:

[PATCH -mmotm] one more reject fix in arch/x86/Kconfig

Using mmotm-2008-02-15-11-03, I get $ make ARCH=i386 HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/kxgettext.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf -s arch/x86/Kconfig arch/x86/Kconfig:24: unknown option HEAD arch/x86/Kconfig:30:

[PATCH -mmotm] fs/sysfs/file.c d_path fix

it for me. Cheers, Erez. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 02223e2..a57b024 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -329,9 +329,11 @@ static int sysfs_open_file(struct inode *inode, struct file *file) struct

[GIT PULL -mm] 00/17 Unionfs updates/fixes/cleanups

): Unionfs: embed a struct path into struct nameidata instead of nd dentrymnt David Howells (1): Unionfs: stop using iget() and read_inode() Erez Zadok (14): Unionfs: grab lower super_block references Unionfs: ensure consistent lower inodes types Unionfs: document behavior

[PATCH 01/17] Unionfs: grab lower super_block references

This prevents the lower super_block from being destroyed too early, when a lower file system is being unmounted with MNT_FORCE or MNT_DETACH. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c |3 +++ fs/unionfs/super.c | 14 ++ fs/unionfs/union.h |2 +- 3

[PATCH 03/17] Unionfs: document behavior when the lower topology changes

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/concepts.txt | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Documentation/filesystems/unionfs/concepts.txt b/Documentation/filesystems/unionfs/concepts.txt index bed69bd

[PATCH 07/17] Unionfs: follow_link locking fixes

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 8d939dc..6377533 100644 --- a/fs/unionfs/inode.c +++ b/fs/unionfs/inode.c @@ -820,7 +820,11 @@ static void

[PATCH 09/17] Unionfs: revalidation code cleanup and refactoring

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 55 -- 1 files changed, 35 insertions(+), 20 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index cd15243..afa2120 100644 --- a/fs/unionfs/dentry.c +++ b

[PATCH 02/17] Unionfs: ensure consistent lower inodes types

-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index b9ee072..755158e 100644 --- a/fs/unionfs/lookup.c +++ b/fs/unionfs/lookup.c @@ -256,6 +256,19 @@ struct

[PATCH 04/17] Unionfs: uninline unionfs_copy_attr_times and unionfs_copy_attr_all

This reduces text size by about 6k. Cc: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/fanout.h | 50 -- fs/unionfs/subr.c | 50 ++ fs/unionfs/union.h

[PATCH 17/17] VFS/Unionfs: use generic path_get/path_put functions

Remove unionfs's versions thereof. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c | 10 +- fs/unionfs/super.c| 27 ++- include/linux/namei.h | 12 3 files changed, 19 insertions(+), 30 deletions(-) diff --git a/fs

[PATCH 16/17] Unionfs: use the new path_put

] Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Acked-by: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c |2 +- fs/unionfs/super.c | 12 ++-- 2 files changed, 7 insertions

[PATCH 12/17] Unionfs: branch management/configuration fixes

Remove unnecessary calls to update branch m/ctimes, and use them only when needed. Update branch vfsmounts after operations that could cause a copyup. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |9 +++-- fs/unionfs/copyup.c |3 ++- fs/unionfs

[PATCH 10/17] Unionfs: factor out revalidation routine

To be used by rest of revalidation code, as well a callers who already locked the child and parent dentry branch-configurations. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 87 +++--- fs/unionfs/union.h |3 ++ 2 files

[PATCH 08/17] Unionfs: improve debugging in copy_attr_times

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/subr.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c index 68a6280..1a40f63 100644 --- a/fs/unionfs/subr.c +++ b/fs/unionfs/subr.c @@ -247,8 +247,14 @@ void

[PATCH 13/17] Unionfs: use dget_parent in revalidation code

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index a956b94..f8f65e1 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs/dentry.c @@ -410,15 +410,10

[PATCH 05/17] Unionfs: initialize path_save variable

This is not strictly necessary, but it helps quiet a gcc-4.2 warning (a good optimizer may optimize this initialization away). Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 06/17] Unionfs: extend dentry branch configuration lock in open

Dentry branch configuration info node lock should extend to calls to copy_attr_times. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c

[PATCH 15/17] Unionfs: embed a struct path into struct nameidata instead of nd dentrymnt

From: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 2e791fd

[PATCH 11/17] Unionfs: lock parents' branch configuration fixes

Ensure that we lock the branch configuration of parent and child dentries in operations which need it, and in the right order. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 31 +--- fs/unionfs/dentry.c | 26 +--- fs/unionfs

[PATCH 14/17] Unionfs: stop using iget() and read_inode()

when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c | 11 +-- fs/unionfs/super.c | 19 ++- fs/unionfs/union.h

Re: unionfs_copy_attr_times oopses

In message [EMAIL PROTECTED], Hugh Dickins writes: Hi Erez, Aside from the occasional unionfs: new lower inode mtime messages on directories (which I've got into the habit of ignoring now), the only problem I'm still suffering with unionfs over tmpfs (not tested any other fs's below it

Re: [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH

In message <[EMAIL PROTECTED]>, Sam Ravnborg writes: > On Thu, Feb 14, 2008 at 03:54:04PM -0500, Erez Zadok wrote: > > Using: v2.6.25-rc1-120-ge760e71 > > > > In a normal compilation, I might this message: > > > > ... > > MODPOST vmlinux.o >

[PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH

CONFIG_DEBUG_SECTION_MISMATCH=y on the command line, but I can't turn on the option in my .config. That's because the option depends on "UNDEFINED". (Was that an attempt to "hide" the option? Why?) The following small patch allows me to set the option in my .config. Cheers, Erez. Signe

[PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH

CONFIG_DEBUG_SECTION_MISMATCH=y on the command line, but I can't turn on the option in my .config. That's because the option depends on UNDEFINED. (Was that an attempt to hide the option? Why?) The following small patch allows me to set the option in my .config. Cheers, Erez. Signed-off-by: Erez Zadok [EMAIL

Re: [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH

In message [EMAIL PROTECTED], Sam Ravnborg writes: On Thu, Feb 14, 2008 at 03:54:04PM -0500, Erez Zadok wrote: Using: v2.6.25-rc1-120-ge760e71 In a normal compilation, I might this message: ... MODPOST vmlinux.o WARNING: modpost: Found 4 section mismatch(es). To see full

Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit

In message <[EMAIL PROTECTED]>, Christoph Hellwig writes: > - remove non-standard in/out markers > - use tabs for formatting > > > Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> > > Index: linux-2.6/fs/ioctl.c > === > ---

Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit

In message [EMAIL PROTECTED], Christoph Hellwig writes: - remove non-standard in/out markers - use tabs for formatting Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ioctl.c === ---

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message <[EMAIL PROTECTED]>, Al Viro writes: > On Sat, Jan 26, 2008 at 12:08:30AM -0500, Erez Zadok wrote: [concerns about lower directories moving around...] > You are thinking about non-interesting case. _Files_ are not much > of a problem. Directory tree is. The real pr

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message [EMAIL PROTECTED], Al Viro writes: On Sat, Jan 26, 2008 at 12:08:30AM -0500, Erez Zadok wrote: [concerns about lower directories moving around...] You are thinking about non-interesting case. _Files_ are not much of a problem. Directory tree is. The real problems with all

Re: unionfs_copy_attr_times oopses

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > Hi Erez, > > Aside from the occasional "unionfs: new lower inode mtime" messages > on directories (which I've got into the habit of ignoring now), the > only problem I'm still suffering with unionfs over tmpfs (not tested > any other fs's

Re: unionfs_copy_attr_times oopses

In message [EMAIL PROTECTED], Hugh Dickins writes: Hi Erez, Aside from the occasional unionfs: new lower inode mtime messages on directories (which I've got into the habit of ignoring now), the only problem I'm still suffering with unionfs over tmpfs (not tested any other fs's below it

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message <[EMAIL PROTECTED]>, Al Viro writes: > After grep for locking-related things: > > * lock_parent(): who said that you won't get dentry moved > before managing to grab i_mutex on parent? While we are at it, > who said that you won't get dentry moved between fetching d_parent > and

[PATCH 4/4] Unionfs: lock_rename related locking fixes

CC: Mike Halcrow <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/rename.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c index 9306a2b..5ab13f9 100644 --- a/fs/unio

[PATCH 2/4] Unionfs: remove unnecessary call to d_iput

This old code was to fix a bug which has long since been fixed in our copyup_permission and unionfs_d_iput. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/copyup.c | 13 - 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/u

[PATCH 3/4] Unionfs: d_parent related locking fixes

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/copyup.c |3 +-- fs/unionfs/union.h |4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 8663224..9beac01 100644 --- a/fs/unionfs/copyup.c +++ b/fs/u

[PATCH 1/4] Unionfs: use first writable branch (fix/cleanup)

Cleanup code in ->create, ->symlink, and ->mknod: refactor common code into helper functions. Also, this allows writing to multiple branches again, which was broken by an earlier patch. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs

[GIT PULL -mm] 0/4 Unionfs updates/fixes/cleanups

/unionfs.git to receive the following: Erez Zadok (4): Unionfs: use first writable branch (fix/cleanup) Unionfs: remove unnecessary call to d_iput Unionfs: d_parent related locking fixes Unionfs: lock_rename related locking fixes copyup.c | 16 -- inode.c | 395

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message [EMAIL PROTECTED], Al Viro writes: After grep for locking-related things: * lock_parent(): who said that you won't get dentry moved before managing to grab i_mutex on parent? While we are at it, who said that you won't get dentry moved between fetching d_parent and doing

[PATCH 4/4] Unionfs: lock_rename related locking fixes

CC: Mike Halcrow [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rename.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c index 9306a2b..5ab13f9 100644 --- a/fs/unionfs/rename.c +++ b

[PATCH 3/4] Unionfs: d_parent related locking fixes

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c |3 +-- fs/unionfs/union.h |4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 8663224..9beac01 100644 --- a/fs/unionfs/copyup.c +++ b/fs/unionfs

[GIT PULL -mm] 0/4 Unionfs updates/fixes/cleanups

/unionfs.git to receive the following: Erez Zadok (4): Unionfs: use first writable branch (fix/cleanup) Unionfs: remove unnecessary call to d_iput Unionfs: d_parent related locking fixes Unionfs: lock_rename related locking fixes copyup.c | 16 -- inode.c | 395

[PATCH 2/4] Unionfs: remove unnecessary call to d_iput

This old code was to fix a bug which has long since been fixed in our copyup_permission and unionfs_d_iput. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 13 - 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs

[PATCH 1/4] Unionfs: use first writable branch (fix/cleanup)

Cleanup code in -create, -symlink, and -mknod: refactor common code into helper functions. Also, this allows writing to multiple branches again, which was broken by an earlier patch. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 395

Re: [patch 01/26] mount options: add documentation

In message <[EMAIL PROTECTED]>, Miklos Szeredi writes: > From: Miklos Szeredi <[EMAIL PROTECTED]> > > This series addresses the problem of showing mount options in > /proc/mounts. > > Several filesystems which use mount options, have not implemented a > .show_options superblock operation.

Re: [PATCH] Fix procfs task exe symlink

In message <[EMAIL PROTECTED]>, Jan Engelhardt writes: > > On Jan 23 2008 10:29, Matt Helsley wrote: > > > >For executables on the stackable MVFS filesystem the current procfs > >methods for implementing a task's exe symlink do not point to the > >correct file and applications relying on the

Re: [patch 01/26] mount options: add documentation

In message [EMAIL PROTECTED], Miklos Szeredi writes: From: Miklos Szeredi [EMAIL PROTECTED] This series addresses the problem of showing mount options in /proc/mounts. Several filesystems which use mount options, have not implemented a .show_options superblock operation. Several others

Re: [PATCH] block2mtd lockdep_init_map warning

In message <[EMAIL PROTECTED]>, =?utf-8?B?SsO2cm4=?= Engel writes: [...] > Patch didn't compile due to function ordering. Here is an updated version. Joern/Peter, I've tested this updated patch with v2.6.24-rc8-74-ga7da60f. It worked fine for me. Thanks, Erez. > Acked-and-tested-by: Joern

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message <[EMAIL PROTECTED]>, Al Viro writes: > After grep for locking-related things: [...] Thanks. I'll start looking at these issues asap. Erez. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message <[EMAIL PROTECTED]>, Michael Halcrow writes: > On Thu, Jan 10, 2008 at 10:57:46AM -0500, Erez Zadok wrote: [...] > Would the inclusion of Unionfs in mainline really slow down or damage > the union mount effort? If not, then I think the pragmatic approach > would be to

Re: unionfs, cow, and whiteout

[I recommend we direct future discussions in this thread to the unionfs ML. -ezk] In message <[EMAIL PROTECTED]>, Paul Albrecht writes: [...] > I'm not sure we're talking about the same problem. What I do is union > mount a write enabled file system like tmpfs over a read only file > system like

Re: unionfs, cow, and whiteout

In message <[EMAIL PROTECTED]>, Paul Albrecht writes: > Hi, > > I have a question about how unionfs handles file deletion when a write > enabled file system is union mounted over a read only file system. For > example, I do something like the following: > > mount -t unionfs -o

Re: unionfs, cow, and whiteout

In message [EMAIL PROTECTED], Paul Albrecht writes: Hi, I have a question about how unionfs handles file deletion when a write enabled file system is union mounted over a read only file system. For example, I do something like the following: mount -t unionfs -o dirs=/cow=rw:/rofs=ro

Re: unionfs, cow, and whiteout

[I recommend we direct future discussions in this thread to the unionfs ML. -ezk] In message [EMAIL PROTECTED], Paul Albrecht writes: [...] I'm not sure we're talking about the same problem. What I do is union mount a write enabled file system like tmpfs over a read only file system like

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message [EMAIL PROTECTED], Michael Halcrow writes: On Thu, Jan 10, 2008 at 10:57:46AM -0500, Erez Zadok wrote: [...] Would the inclusion of Unionfs in mainline really slow down or damage the union mount effort? If not, then I think the pragmatic approach would be to make it available

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message [EMAIL PROTECTED], Al Viro writes: After grep for locking-related things: [...] Thanks. I'll start looking at these issues asap. Erez. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message <[EMAIL PROTECTED]>, Christoph Hellwig writes: > On Thu, Jan 10, 2008 at 09:59:19AM -0500, Erez Zadok wrote: > > > > Dear Linus, Al, Christoph, and Andrew, > > > > As per your request, I'm posting for review the unionfs code (and related > &g

[PATCH 20/29] Unionfs: super_block operations

Includes read_inode, delete_inode, put_super, statfs, remount_fs (which supports branch-management ops), clear_inode, alloc_inode, destroy_inode, write_inode, umount_begin, and show_options. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/super.c

[PATCH 11/29] Unionfs: lower-level lookup routines

Includes lower nameidata support routines. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/lookup.c | 652 +++ 1 files changed, 652 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/lookup.c diff --git a/fs/u

[PATCH 06/29] Unionfs: main header file

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/union.h | 602 1 files changed, 602 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/union.h diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h new file mode

[PATCH 21/29] Unionfs: extended attributes operations

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/xattr.c | 153 1 files changed, 153 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/xattr.c diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c new file mode

[PATCH 07/29] Unionfs: common file copyup/revalidation operations

Includes open, ioctl, and flush operations. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 835 +++ 1 files changed, 835 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/commonfops.c diff --git a/fs/u

[PATCH 10/29] Unionfs: dentry revalidation

Includes d_release methods and cache-coherency support for dentries. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 548 +++ 1 files changed, 548 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dentry.c

[PATCH 13/29] Unionfs: directory reading file operations

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dirfops.c | 290 ++ 1 files changed, 290 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dirfops.c diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c new fil

[PATCH 26/29] Unionfs: common header file for user-land utilities and kernel

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- include/linux/union_fs.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 include/linux/union_fs.h diff --git a/include/linux/union_fs.h b/include/linux/union_fs.h new file mode 100644

[PATCH 24/29] Unionfs: debugging infrastructure

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c | 533 1 files changed, 533 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/debug.c diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c new file mode

[PATCH 12/29] Unionfs: rename method and helpers

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/rename.c | 531 +++ 1 files changed, 531 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/rename.c diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c new file mode

[PATCH 19/29] Unionfs: mount-time and stacking-interposition functions

Includes read_super and module-linkage routines. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c | 794 + 1 files changed, 794 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/main.c diff --git a/fs/u

[PATCH 28/29] VFS: export release_open_intent symbol

Needed to release the resources of the lower nameidata structures that we create and pass to lower file systems (e.g., when calling vfs_create). Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/namei.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/namei.

[PATCH 14/29] Unionfs: readdir helper functions

Includes whiteout handling for directories. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dirhelper.c | 267 1 files changed, 267 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dirhelper.c diff --git a/fs/u

[PATCH 25/29] Unionfs file system magic number

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- include/linux/magic.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/magic.h b/include/linux/magic.h index 1fa0c2c..67043ed 100644 --- a/include/linux/magic.h +++ b/include/linux/magic.h @@ -35,6

[PATCH 16/29] Unionfs: inode operations

Includes create, lookup, link, symlink, mkdir, mknod, readlink, follow_link, put_link, permission, and setattr. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c | 1174 1 files changed, 1174 insertions(+), 0 del

[PATCH 18/29] Unionfs: address-space operations

Includes writepage, writepages, readpage, prepare_write, and commit_write. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c | 343 + 1 files changed, 343 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/

[PATCH 23/29] Unionfs: miscellaneous helper routines

Mostly related to whiteouts. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/subr.c | 242 + 1 files changed, 242 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/subr.c diff --git a/fs/unionfs/subr.c b/fs/u

  1   2   3   4   5   6   7   8   9   >