Re: [PATCH v7 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-27 Thread Eric Long
Hi Guenter, Thanks again for you review. I am very glad that this patch has been accepted. Best Regards, Eric Long On Mon, Nov 27, 2017 at 08:09:18PM -0800, Guenter Roeck wrote: > On 11/27/2017 06:18 PM, Eric Long wrote: > >This patch adds the documentation for Spreadtrum watchd

Re: [PATCH v7 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-27 Thread Eric Long
Hi Guenter, Thanks again for you review. I am very glad that this patch has been accepted. Best Regards, Eric Long On Mon, Nov 27, 2017 at 08:09:18PM -0800, Guenter Roeck wrote: > On 11/27/2017 06:18 PM, Eric Long wrote: > >This patch adds the documentation for Spreadtrum watchd

[PATCH v7 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-27 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v6: - No updates. Changes since v5: - No updates. Changes since v4: - No updates. Changes since v3:

[PATCH v7 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-27 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long Acked-by: Rob Herring --- Changes since v6: - No updates. Changes since v5: - No updates. Changes since v4: - No updates. Changes since v3: - No updates. Changes since v2: - Add acked tag from Rob

[PATCH v7 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-27 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- Changes since v6: - Add reviewed tag from Guenter. Changes since v5: - Modify the "irq" type as int

[PATCH v7 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-27 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long Reviewed-by: Guenter Roeck --- Changes since v6: - Add reviewed tag from Guenter. Changes since v5: - Modify the "irq" type as int type. - Delete unused api sprd_wdt_is_running(). Change

Re: [PATCH v6 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-14 Thread Eric Long
Hi, Thanks for Guenter's review and detail comments. Please help to apply this patch if there is no any other comments. Best regards, Eric Long On Fri, Nov 10, 2017 at 01:00:32PM -0800, Guenter Roeck wrote: > On Mon, Nov 06, 2017 at 10:46:28AM +0800, Eric Long wrote: > > This p

Re: [PATCH v6 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-14 Thread Eric Long
Hi, Thanks for Guenter's review and detail comments. Please help to apply this patch if there is no any other comments. Best regards, Eric Long On Fri, Nov 10, 2017 at 01:00:32PM -0800, Guenter Roeck wrote: > On Mon, Nov 06, 2017 at 10:46:28AM +0800, Eric Long wrote: > > This p

[PATCH v6 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-05 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- Changes since v5: - Modify the "irq" type as int type. - Delete unused api sprd_wdt_is_running(). Changes since v4: - Remove sprd_wdt_remove(). - Add

[PATCH v6 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-05 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long --- Changes since v5: - Modify the "irq" type as int type. - Delete unused api sprd_wdt_is_running(). Changes since v4: - Remove sprd_wdt_remove(). - Add devm_add_action() for sprd_w

[PATCH v6 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-05 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v5: - No updates. Changes since v4: - No updates. Changes since v3: - No updates. Changes since v2: - A

[PATCH v6 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-05 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long Acked-by: Rob Herring --- Changes since v5: - No updates. Changes since v4: - No updates. Changes since v3: - No updates. Changes since v2: - Add acked tag from Rob. Changes since v1: - No updates

Re: [v5,2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-05 Thread Eric Long
On Fri, Nov 03, 2017 at 06:48:26AM -0700, Guenter Roeck wrote: > On Fri, Nov 03, 2017 at 07:18:28PM +0800, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > > Signed-off-by: Eric Long <eric.l...@spreadtrum.com> &

Re: [v5,2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-05 Thread Eric Long
On Fri, Nov 03, 2017 at 06:48:26AM -0700, Guenter Roeck wrote: > On Fri, Nov 03, 2017 at 07:18:28PM +0800, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > > Signed-off-by: Eric Long > > --- > > Changes since

[PATCH v5 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-03 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- Changes since v4: - Remove sprd_wdt_remove(). - Add devm_add_action() for sprd_wdt_disable(). Changes since v3: - Update Kconfig SPRD_WATCHDOG help messages. - C

[PATCH v5 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-03 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long --- Changes since v4: - Remove sprd_wdt_remove(). - Add devm_add_action() for sprd_wdt_disable(). Changes since v3: - Update Kconfig SPRD_WATCHDOG help messages. - Correct the wrong spell words

[PATCH v5 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-03 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v4: - No updates. Changes since v3: - No updates. Changes since v2: - Add acked tag from Rob. Chan

[PATCH v5 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-11-03 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long Acked-by: Rob Herring --- Changes since v4: - No updates. Changes since v3: - No updates. Changes since v2: - Add acked tag from Rob. Changes since v1: - No updates. --- .../devicetree/bindings

Re: [PATCH v4 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-02 Thread Eric Long
On Wed, Nov 01, 2017 at 01:46:36PM +, Guenter Roeck wrote: > On 10/31/2017 01:16 AM, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > > Signed-off-by: Eric Long <eric.l...@spreadtrum.com> > > --- > > C

Re: [PATCH v4 2/2] watchdog: Add Spreadtrum watchdog driver

2017-11-02 Thread Eric Long
On Wed, Nov 01, 2017 at 01:46:36PM +, Guenter Roeck wrote: > On 10/31/2017 01:16 AM, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > > Signed-off-by: Eric Long > > --- > > Changes since v3: > > - Upd

[PATCH v4 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-31 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- Changes since v3: - Update Kconfig SPRD_WATCHDOG help messages. - Correct the wrong spell words. - Rename SPRD_WDT_CNT_HIGH_VALUE as SPRD_WDT_CNT_HIGH_SHIFT. -

[PATCH v4 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-31 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long --- Changes since v3: - Update Kconfig SPRD_WATCHDOG help messages. - Correct the wrong spell words. - Rename SPRD_WDT_CNT_HIGH_VALUE as SPRD_WDT_CNT_HIGH_SHIFT. - Remove unused macor. - Update

[PATCH v4 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-10-31 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v3: - No updates. Changes since v2: - Add acked tag from Rob. Changes since v1: - No updates. --- ..

[PATCH v4 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-10-31 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long Acked-by: Rob Herring --- Changes since v3: - No updates. Changes since v2: - Add acked tag from Rob. Changes since v1: - No updates. --- .../devicetree/bindings/watchdog/sprd-wdt.txt | 19

Re: [PATCH v3 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-27 Thread Eric Long
Hi Guenter, Thanks for you commonts. On Thu, Oct 26, 2017 at 10:23:40PM -0700, Guenter Roeck wrote: > On 10/26/2017 07:28 PM, Eric Long wrote: > >This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > >Signed-off-by: Eric Long <eric.l...@spreadtrum.com

Re: [PATCH v3 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-27 Thread Eric Long
Hi Guenter, Thanks for you commonts. On Thu, Oct 26, 2017 at 10:23:40PM -0700, Guenter Roeck wrote: > On 10/26/2017 07:28 PM, Eric Long wrote: > >This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > >Signed-off-by: Eric Long > >--- > >C

[PATCH v3 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-26 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- Change since v2: - Rename all the macors, add SPRD tag at the head of the macro names. - Rename SPRD_WDT_CLK as SPRD_WTC_CNT_STEP. - Remove the code which check t

[PATCH v3 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-10-26 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes since v2: - Add acked tag from Rob. Changes since v1: - No updates. --- .../devicetree/bindings/watchdog/

[PATCH v3 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-10-26 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long Acked-by: Rob Herring --- Changes since v2: - Add acked tag from Rob. Changes since v1: - No updates. --- .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 +++ 1 file changed

[PATCH v3 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-26 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long --- Change since v2: - Rename all the macors, add SPRD tag at the head of the macro names. - Rename SPRD_WDT_CLK as SPRD_WTC_CNT_STEP. - Remove the code which check timeout value at the wrong place

Re: [v2,2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-25 Thread Eric Long
Hi Guenter, Sorry for late reply, and thanks for your detail comments. On Sun, Oct 22, 2017 at 09:07:29AM -0700, Guenter Roeck wrote: > On Tue, Sep 12, 2017 at 07:40:09PM +0800, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > >

Re: [v2,2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-25 Thread Eric Long
Hi Guenter, Sorry for late reply, and thanks for your detail comments. On Sun, Oct 22, 2017 at 09:07:29AM -0700, Guenter Roeck wrote: > On Tue, Sep 12, 2017 at 07:40:09PM +0800, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > >

Re: [PATCH v2 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-11 Thread Eric Long
Hi, On Tue, Sep 12, 2017 at 07:40:09PM +0800, Eric Long wrote: > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > Signed-off-by: Eric Long <eric.l...@spreadtrum.com> > --- > Changes since v1: > - Use pretimeout instead of own implementation. &g

Re: [PATCH v2 2/2] watchdog: Add Spreadtrum watchdog driver

2017-10-11 Thread Eric Long
Hi, On Tue, Sep 12, 2017 at 07:40:09PM +0800, Eric Long wrote: > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > Signed-off-by: Eric Long > --- > Changes since v1: > - Use pretimeout instead of own implementation. > - Fix timeout loop when l

Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-09-18 Thread Eric Long
On Mon, Sep 18, 2017 at 05:31:11PM -0500, Rob Herring wrote: > On Tue, Sep 12, 2017 at 07:40:08PM +0800, Eric Long wrote: > > This patch adds the documentation for Spreadtrum watchdog driver. > > > > Signed-off-by: Eric Long <eric.l...@spreadtrum.com> &

Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-09-18 Thread Eric Long
On Mon, Sep 18, 2017 at 05:31:11PM -0500, Rob Herring wrote: > On Tue, Sep 12, 2017 at 07:40:08PM +0800, Eric Long wrote: > > This patch adds the documentation for Spreadtrum watchdog driver. > > > > Signed-off-by: Eric Long > > --- > > ch

[PATCH v2 2/2] watchdog: Add Spreadtrum watchdog driver

2017-09-12 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- Changes since v1: - Use pretimeout instead of own implementation. - Fix timeout loop when loading timeout values. - use the infrastructure to read and set "

[PATCH v2 2/2] watchdog: Add Spreadtrum watchdog driver

2017-09-12 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long --- Changes since v1: - Use pretimeout instead of own implementation. - Fix timeout loop when loading timeout values. - use the infrastructure to read and set "timeout-sec" property. - Add

[PATCH v2 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-09-12 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- changes since v1: - No updates. --- .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 +++ 1 file changed, 19 insertions(+) create mode

[PATCH v2 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-09-12 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long --- changes since v1: - No updates. --- .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH 2/2] watchdog: Add Spreadtrum watchdog driver

2017-09-12 Thread Eric Long
On Sat, Sep 09, 2017 at 03:32:48AM +, Guenter Roeck wrote: > On 09/05/2017 10:38 PM, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > > Signed-off-by: Eric Long <eric.l...@spreadtrum.com> > > --- > &

Re: [PATCH 2/2] watchdog: Add Spreadtrum watchdog driver

2017-09-12 Thread Eric Long
On Sat, Sep 09, 2017 at 03:32:48AM +, Guenter Roeck wrote: > On 09/05/2017 10:38 PM, Eric Long wrote: > > This patch adds the watchdog driver for Spreadtrum SC9860 platform. > > > > Signed-off-by: Eric Long > > --- > > drivers/watchdog/Kconfig| 8

[PATCH 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-09-05 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bi

[PATCH 2/2] watchdog: Add Spreadtrum watchdog driver

2017-09-05 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long <eric.l...@spreadtrum.com> --- drivers/watchdog/Kconfig| 8 + drivers/watchdog/Makefile | 1 + drivers/watchdog/sprd_wdt.c | 366 3 files c

[PATCH 1/2] dt-bindings: watchdog: Add Spreadtrum watchdog documentation

2017-09-05 Thread Eric Long
This patch adds the documentation for Spreadtrum watchdog driver. Signed-off-by: Eric Long --- .../devicetree/bindings/watchdog/sprd-wdt.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/sprd-wdt.txt diff --git

[PATCH 2/2] watchdog: Add Spreadtrum watchdog driver

2017-09-05 Thread Eric Long
This patch adds the watchdog driver for Spreadtrum SC9860 platform. Signed-off-by: Eric Long --- drivers/watchdog/Kconfig| 8 + drivers/watchdog/Makefile | 1 + drivers/watchdog/sprd_wdt.c | 366 3 files changed, 375 insertions(+) create

[PATCH v2 1/2] coresight: "DEVICE_ATTR_RO" should defined as static.

2016-01-25 Thread Eric Long
Signed-off-by: Eric Long --- drivers/hwtracing/coresight/coresight-etm4x.c |2 +- drivers/hwtracing/coresight/of_coresight.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm

[PATCH v2 2/2] coresight: etm4x: Check every parameter used by dma_xx_coherent.

2016-01-25 Thread Eric Long
pected unsigned long long [unsigned] [usertype] dma_handle coresight-tmc.c:769:50:got restricted gfp_t Signed-off-by: Eric Long --- drivers/hwtracing/coresight/coresight-tmc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresi

[PATCH v2 0/2] Modify static defined and wrong parameter used.

2016-01-25 Thread Eric Long
Both of the two patches optimize the code and remove the mistakes and warnings detected by the check tools. Changes since v1: - Adjust the patch by the changes not by the check tools. Eric Long (2): coresight: "DEVICE_ATTR_RO" should defined as static. coresight: etm4x: C

[PATCH v2 1/2] coresight: "DEVICE_ATTR_RO" should defined as static.

2016-01-25 Thread Eric Long
Signed-off-by: Eric Long <eric.l...@linaro.org> --- drivers/hwtracing/coresight/coresight-etm4x.c |2 +- drivers/hwtracing/coresight/of_coresight.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwt

[PATCH v2 2/2] coresight: etm4x: Check every parameter used by dma_xx_coherent.

2016-01-25 Thread Eric Long
pected unsigned long long [unsigned] [usertype] dma_handle coresight-tmc.c:769:50:got restricted gfp_t Signed-off-by: Eric Long <eric.l...@linaro.org> --- drivers/hwtracing/coresight/coresight-tmc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwt

[PATCH v2 0/2] Modify static defined and wrong parameter used.

2016-01-25 Thread Eric Long
Both of the two patches optimize the code and remove the mistakes and warnings detected by the check tools. Changes since v1: - Adjust the patch by the changes not by the check tools. Eric Long (2): coresight: "DEVICE_ATTR_RO" should defined as static. coresight: etm4x: C

Re: [RESEND PATCH 0/2] Remove the mistakes detected by the check tools.

2016-01-22 Thread Eric Long
On 22 January 2016 at 00:56, Mathieu Poirier wrote: > > Please run checkpath.pl on your patches. Also if the changes are of a > different nature, ex. indentation problem and wrong argument to a > function, please provide two separate patches. > Hi Mathieu, I had already ran checkpath.pl, and

Re: [RESEND PATCH 0/2] Remove the mistakes detected by the check tools.

2016-01-22 Thread Eric Long
On 22 January 2016 at 00:56, Mathieu Poirier wrote: > > Please run checkpath.pl on your patches. Also if the changes are of a > different nature, ex. indentation problem and wrong argument to a > function, please provide two separate patches. > Hi Mathieu, I had