Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2018-01-02 Thread Erick Chen
_PWR_WR_PROT and > SC2731_WR_UNLOCK_VALUE instead. > > Signed-off-by: Axel Lin <axel@ingics.com> Reviewed-by: Erick Chen <erick.c...@spreadtrum.com> >

Re: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2018-01-02 Thread Erick Chen
_PWR_WR_PROT and > SC2731_WR_UNLOCK_VALUE instead. > > Signed-off-by: Axel Lin Reviewed-by: Erick Chen >

Re: [PATCH] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2017-12-31 Thread Erick Chen
Hi Axel, O 五, 12月 29, 2017 at 02:12:18下午 +0800, Axel Lin wrote: > The define for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE are > swapped, so the code calling regmap_write() looks strange. Fix it. > regmap_write takes reg parameter first then val. > > Signed-off-by: Axel Lin

Re: [PATCH] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE

2017-12-31 Thread Erick Chen
Hi Axel, O 五, 12月 29, 2017 at 02:12:18下午 +0800, Axel Lin wrote: > The define for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE are > swapped, so the code calling regmap_write() looks strange. Fix it. > regmap_write takes reg parameter first then val. > > Signed-off-by: Axel Lin > --- > Hi

[PATCH v2 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-04 Thread Erick Chen
Add regulator driver for Spreadtrum SC2731 device. It has 17 general purpose LDOs, BUCKs generator and digital output to control regulators. Signed-off-by: Erick Chen <erick.c...@spreadtrum.com> Reviewed-by: Baolin Wang <baolin.w...@spreadtrum.com> --- Changes since v1: - Remove

[PATCH v2 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-04 Thread Erick Chen
Add regulator driver for Spreadtrum SC2731 device. It has 17 general purpose LDOs, BUCKs generator and digital output to control regulators. Signed-off-by: Erick Chen Reviewed-by: Baolin Wang --- Changes since v1: - Remove of_device_id table. - Change subsys_init() to module_init(). - Change

[PATCH v2 1/2] dt-bindings: regulator: Add Spreadtrum SC2731 regulator documentation

2017-12-04 Thread Erick Chen
This patch adds support for the Spreadtrum SC2731 voltage regulator device. Signed-off-by: Erick Chen <erick.c...@spreadtrum.com> --- Changes since v1: - Remove reg property. - Remove regulators sub-node. --- .../bindings/regulator/sprd,sc2731-regulator.txt | 43

[PATCH v2 1/2] dt-bindings: regulator: Add Spreadtrum SC2731 regulator documentation

2017-12-04 Thread Erick Chen
This patch adds support for the Spreadtrum SC2731 voltage regulator device. Signed-off-by: Erick Chen --- Changes since v1: - Remove reg property. - Remove regulators sub-node. --- .../bindings/regulator/sprd,sc2731-regulator.txt | 43 1 file changed, 43 insertions

Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-04 Thread Erick Chen
Hi Philippe, On Fri, Dec 01, 2017 at 10:13:27AM +0100, Philippe Ombredanne wrote: > Erik, > > On Fri, Dec 1, 2017 at 9:58 AM, Erick Chen <erick.c...@spreadtrum.com> wrote: > > Add regulator driver for Spreadtrum SC2731 device. > > It has 17 general purpose LDOs, BUCK

Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-04 Thread Erick Chen
Hi Philippe, On Fri, Dec 01, 2017 at 10:13:27AM +0100, Philippe Ombredanne wrote: > Erik, > > On Fri, Dec 1, 2017 at 9:58 AM, Erick Chen wrote: > > Add regulator driver for Spreadtrum SC2731 device. > > It has 17 general purpose LDOs, BUCKs generator and > > digital o

Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-04 Thread Erick Chen
Hi Mark, On Fri, Dec 01, 2017 at 01:01:37PM +, Mark Brown wrote: > On Fri, Dec 01, 2017 at 04:58:16PM +0800, Erick Chen wrote: > > > +static const struct of_device_id sc2731_regulator_of_match[] = { > > + {.compatible = "sprd,sc2731-regulator",}, > > + {

Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-04 Thread Erick Chen
Hi Mark, On Fri, Dec 01, 2017 at 01:01:37PM +, Mark Brown wrote: > On Fri, Dec 01, 2017 at 04:58:16PM +0800, Erick Chen wrote: > > > +static const struct of_device_id sc2731_regulator_of_match[] = { > > + {.compatible = "sprd,sc2731-regulator",}, > > + {

[PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-01 Thread Erick Chen
Add regulator driver for Spreadtrum SC2731 device. It has 17 general purpose LDOs, BUCKs generator and digital output to control regulators. Signed-off-by: Erick Chen <erick.c...@spreadtrum.com> Reviewed-by: Baolin Wang <baolin.w...@spreadtrum.com> --- drivers/regulator/Kconfig

[PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

2017-12-01 Thread Erick Chen
Add regulator driver for Spreadtrum SC2731 device. It has 17 general purpose LDOs, BUCKs generator and digital output to control regulators. Signed-off-by: Erick Chen Reviewed-by: Baolin Wang --- drivers/regulator/Kconfig|7 + drivers/regulator/Makefile |1

[PATCH 1/2] dt-bindings: regulator: Add Spreadtrum SC27xx regulator documentation

2017-12-01 Thread Erick Chen
This patch adds support for the Spreadtrum SC2731 voltage regulator device. Signed-off-by: Erick Chen <erick.c...@spreadtrum.com> --- .../bindings/regulator/sprd,sc2731-regulator.txt | 45 1 file changed, 45 insertions(+) create mode 100644 Documentation/devi

[PATCH 1/2] dt-bindings: regulator: Add Spreadtrum SC27xx regulator documentation

2017-12-01 Thread Erick Chen
This patch adds support for the Spreadtrum SC2731 voltage regulator device. Signed-off-by: Erick Chen --- .../bindings/regulator/sprd,sc2731-regulator.txt | 45 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/sprd,sc2731