Re: [PATCH v3 2/5] w1_therm: adding sysfs entry to check device power

2020-04-29 Thread Evgeniy Polyakov
Hi 29.04.2020, 16:47, "Greg KH" : >>  +What: /sys/bus/w1/devices/.../w1_slave >>  +Date: Apr 2020 >>  +Contact: Akira Shimahara >>  +Description: >>  + (RW) return the temperature in 1/1000 degC. >>  + *read*: return 2 lines with the hexa output data sent on the >>  + bus, return the CRC check

Re: [PATCH 2/2] w1: fix the resume command API

2019-03-19 Thread Evgeniy Polyakov
Hi everyone Mariusz, thank you for the patch, a small comment on it logic 19.03.2019, 16:21, "Jean-Francois Dagenais" : >>  --- >>  drivers/w1/w1_io.c | 11 +-- >>  1 file changed, 9 insertions(+), 2 deletions(-) >> >>  diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c >>  index

Re: [PATCH 18/18] w1: w1_io.c: fix a kernel-doc warning

2018-05-10 Thread Evgeniy Polyakov
d to, or folks from linux doc will pick >> it up? >>  > >>  > Acked-by: Evgeniy Polyakov <z...@ioremap.net> >> >>  Jon prefers if this could go via the usual maintainer's tree. >> >>  So, could you send it via yours? > > With the ack I can pick it up, n

Re: [PATCH 18/18] w1: w1_io.c: fix a kernel-doc warning

2018-05-10 Thread Evgeniy Polyakov
Hi 09.05.2018, 16:11, "Jonathan Corbet" : > On Wed, 9 May 2018 09:32:18 -0300 > Mauro Carvalho Chehab wrote: > >>  > Looks good to me, thank you! >>  > What tree should this be forwarded to, or folks from linux doc will pick >> it up? >>  >

Re: [PATCH 18/18] w1: w1_io.c: fix a kernel-doc warning

2018-05-08 Thread Evgeniy Polyakov
o Carvalho Chehab <mchehab+sams...@kernel.org> Looks good to me, thank you! What tree should this be forwarded to, or folks from linux doc will pick it up? Acked-by: Evgeniy Polyakov <z...@ioremap.net> > --- >  drivers/w1/w1_io.c | 1 + >  1 file changed, 1 insertion(+) > > di

Re: [PATCH 18/18] w1: w1_io.c: fix a kernel-doc warning

2018-05-08 Thread Evgeniy Polyakov
ank you! What tree should this be forwarded to, or folks from linux doc will pick it up? Acked-by: Evgeniy Polyakov > --- >  drivers/w1/w1_io.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c > index 075d120e7b88..0364d3329c5

Re: [PATCH v2] w1: mxc_w1: Enable clock before calling clk_get_rate() on it

2018-05-08 Thread Evgeniy Polyakov
w1: add 1-wire master driver for i.MX27 / i.MX31") > Signed-off-by: Stefan Potyra <stefan.pot...@elektrobit.com> Looks good to me, thank you! Greg, please pull it into your tree, this also sounds like stable material, is it? Acked-by: Evgeniy Polyakov <z...

Re: [PATCH v2] w1: mxc_w1: Enable clock before calling clk_get_rate() on it

2018-05-08 Thread Evgeniy Polyakov
or i.MX27 / i.MX31") > Signed-off-by: Stefan Potyra Looks good to me, thank you! Greg, please pull it into your tree, this also sounds like stable material, is it? Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/mxc_w1.c | 20 +--- >  1 file changed, 13 inserti

Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

2018-05-01 Thread Evgeniy Polyakov
ed-off-by: Ingo Flaschberger <ingo.flaschber...@gmail.com> Greg, please pull this patch into your tree. Should it be stable material? Acked-by: Evgeniy Polyakov <z...@ioremap.net> > --- >   drivers/w1/w1.c | 2 +- >   1 file changed, 1 insertion(+), 1 deletion(-) > > diff --

Re: [PATCH] 1wire: family module autoload fails because of upper/lower case mismatch.

2018-05-01 Thread Evgeniy Polyakov
please pull this patch into your tree. Should it be stable material? Acked-by: Evgeniy Polyakov > --- >   drivers/w1/w1.c | 2 +- >   1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index ab0931e..aa458f2 100644 > --- a/drivers/

Re: [PATCH] Enable clock before calling clk_get_rate() on it.

2018-04-30 Thread Evgeniy Polyakov
Fixes: a5fd9139f74c w1: add 1-wire master driver for i.MX27 / i.MX31 > Signed-off-by: Stefan Potyra <stefan.pot...@elektrobit.com> Acked-by: Evgeniy Polyakov <z...@ioremap.net> Greg, please pull it into your tree. Is this a stable material? > --- >  drivers/w1/masters/mxc_

Re: [PATCH] Enable clock before calling clk_get_rate() on it.

2018-04-30 Thread Evgeniy Polyakov
r driver for i.MX27 / i.MX31 > Signed-off-by: Stefan Potyra Acked-by: Evgeniy Polyakov Greg, please pull it into your tree. Is this a stable material? > --- >  drivers/w1/masters/mxc_w1.c | 8 >  1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dr

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-30 Thread Evgeniy Polyakov
ow arch where pid is larger currently, so it looks safe. David, please pull it into your tree, or should it go via different path? Acked-by: Evgeniy Polyakov <z...@ioremap.net> >>  I don't see how it breaks UAPI. The point is that structures >>  coredump_proc_event and exit_pr

Re: [PATCH] connector: add parent pid and tgid to coredump and exit events

2018-04-30 Thread Evgeniy Polyakov
ntly, so it looks safe. David, please pull it into your tree, or should it go via different path? Acked-by: Evgeniy Polyakov >>  I don't see how it breaks UAPI. The point is that structures >>  coredump_proc_event and exit_proc_event are members of *union* >>  event_

Re: [PATCH] Fixed typo in onewire generic doc

2018-04-08 Thread Evgeniy Polyakov
Hi everyone I'm really sorry for that long delay. Was this patch accepted or should I push it upstream? 20.12.2017, 22:09, "Gergo Huszty" : > Onewire devices has 6 byte long unique serial numbers, 1 byte family > code and 1 byte CRC. Linux sysfs presents the device

Re: [PATCH] Fixed typo in onewire generic doc

2018-04-08 Thread Evgeniy Polyakov
Hi everyone I'm really sorry for that long delay. Was this patch accepted or should I push it upstream? 20.12.2017, 22:09, "Gergo Huszty" : > Onewire devices has 6 byte long unique serial numbers, 1 byte family > code and 1 byte CRC. Linux sysfs presents the device folder in the > form of

Re: [PATCH] w1: w1-gpio: Convert to use GPIO descriptors

2017-12-05 Thread Evgeniy Polyakov
Hi Linus Sorry for late reply 20.11.2017, 11:47, "Linus Walleij" : > The w1 master driver includes a complete open drain emulation > reimplementation among other things. > > This converts the driver and all board files using it to use > GPIO descriptors associated with

Re: [PATCH] w1: w1-gpio: Convert to use GPIO descriptors

2017-12-05 Thread Evgeniy Polyakov
Hi Linus Sorry for late reply 20.11.2017, 11:47, "Linus Walleij" : > The w1 master driver includes a complete open drain emulation > reimplementation among other things. > > This converts the driver and all board files using it to use > GPIO descriptors associated with the device to look up the

Re: [PATCH] w1: remove redundant assignments to search_bit and last_rn

2017-12-05 Thread Evgeniy Polyakov
s good, thank you. Please pull it into janitors tree if you haven't yet. > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Evgeniy Polyakov <z...@ioremap.net> > --- >  drivers/w1/w1.c | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/drivers/w1/w

Re: [PATCH] w1: remove redundant assignments to search_bit and last_rn

2017-12-05 Thread Evgeniy Polyakov
't yet. > Signed-off-by: Colin Ian King Acked-by: Evgeniy Polyakov > --- >  drivers/w1/w1.c | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 0c2a5a8327bd..c29f6c5dda3c 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/

Re: [PATCH v2] w1: driver for serial linkUSB, linkOEM, LINK devices

2017-12-05 Thread Evgeniy Polyakov
pull it into your tree > Signed-off by: Hans-Frieder Vogt <hfv...@gmx.net> Acked-by: Evgeniy Polyakov <z...@ioremap.net> >  Documentation/w1/masters/00-INDEX   |    2 >  Documentation/w1/masters/linkserial |   44 ++ >  drivers/w1/masters/Kconfig  |   10 >

Re: [PATCH v2] w1: driver for serial linkUSB, linkOEM, LINK devices

2017-12-05 Thread Evgeniy Polyakov
cal code > areas has therefore been changed from local spinlocks to a more toplevel > mutex-based system to enforce serialisation. I have not run into any problems > with unexpected feedback from the link device since. This looks good to me, thank you! Greg, please pull it into your tr

Re: [PATCH] w1 driver for serial linkUSB, linkOEM, LINK devices

2017-10-30 Thread Evgeniy Polyakov
Hi 17.10.2017, 23:01, "Hans-Frieder Vogt" : > attached is a driver that supports the serial OneWire masters from > iButtonLink(TM) in the w1 kernel driver. In order to be usable it needs an > updated userland tool (patch included in documentation file). The patch is > against

Re: [PATCH] w1 driver for serial linkUSB, linkOEM, LINK devices

2017-10-30 Thread Evgeniy Polyakov
Hi 17.10.2017, 23:01, "Hans-Frieder Vogt" : > attached is a driver that supports the serial OneWire masters from > iButtonLink(TM) in the w1 kernel driver. In order to be usable it needs an > updated userland tool (patch included in documentation file). The patch is > against linux-next.

Re: [PATCH] w1: keep balance of mutex locks and refcnts

2017-10-09 Thread Evgeniy Polyakov
messy - we drop the lock while sleeping waiting for the bus master to complete operation, and during this period family driver has to be referenced. But we can easily grab the reference earlier and then try to lock the bus, so the second variant will work. > -- > Alexey > > On 01.10.2017

Re: [PATCH] w1: keep balance of mutex locks and refcnts

2017-10-09 Thread Evgeniy Polyakov
k while sleeping waiting for the bus master to complete operation, and during this period family driver has to be referenced. But we can easily grab the reference earlier and then try to lock the bus, so the second variant will work. > -- > Alexey > > On 01.10.2017 08:55, Evgeniy Polyakov wro

Re: [PATCH v5 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

2017-10-01 Thread Evgeniy Polyakov
8E17 Onewire to I2C master bridge. > > Signed-off-by: Jan Kandziora <j...@gmx.de> > Acked-by: Evgeniy Polyakov <z...@ioremap.net> > --- > Changes in v5 against v4 in this subpatch: >   - adapted to linux-4.14-rc1 > > Changes in v4 against v3 in this subpatch: >

Re: [PATCH v5 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

2017-10-01 Thread Evgeniy Polyakov
to I2C master bridge. > > Signed-off-by: Jan Kandziora > Acked-by: Evgeniy Polyakov > --- > Changes in v5 against v4 in this subpatch: >   - adapted to linux-4.14-rc1 > > Changes in v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 > > Changes in v3 against v

Re: [PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs

2017-09-30 Thread Evgeniy Polyakov
Hi 26.09.2017, 20:59, "Mauro Carvalho Chehab" : > Describe nested struct/union fields > > NOTE: This is a pure test patch, meant to validate if the > parsing logic for nested structs is working properly. > > I've no idea if the random text I added there is correct! It

Re: [PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs

2017-09-30 Thread Evgeniy Polyakov
Hi 26.09.2017, 20:59, "Mauro Carvalho Chehab" : > Describe nested struct/union fields > > NOTE: This is a pure test patch, meant to validate if the > parsing logic for nested structs is working properly. > > I've no idea if the random text I added there is correct! It looks correct, although I

Re: [PATCH] w1: keep balance of mutex locks and refcnts

2017-09-30 Thread Evgeniy Polyakov
Hi Alex 29.09.2017, 23:23, "Alexey Khoroshilov" : > w1_therm_eeprom() and w1_DS18B20_precision() decrement THERM_REFCNT > on error paths, while they did not increment it yet. > > read_therm() unlocks bus mutex on some error paths, > while it is not acquired. > > The patch

Re: [PATCH] w1: keep balance of mutex locks and refcnts

2017-09-30 Thread Evgeniy Polyakov
Hi Alex 29.09.2017, 23:23, "Alexey Khoroshilov" : > w1_therm_eeprom() and w1_DS18B20_precision() decrement THERM_REFCNT > on error paths, while they did not increment it yet. > > read_therm() unlocks bus mutex on some error paths, > while it is not acquired. > > The patch makes sure all the

Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu

2017-09-05 Thread Evgeniy Polyakov
Hi 28.08.2017, 12:25, "chen.l...@zte.com.cn" : > Hi > > Q: > > But w1_reg_num has a different layout for be/le systems, isn't it enough? > > A: > > sure, it's right only under the assumption that 'rn' is a  correct layout id. > > Here's my example in be system which I

Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu

2017-09-05 Thread Evgeniy Polyakov
Hi 28.08.2017, 12:25, "chen.l...@zte.com.cn" : > Hi > > Q: > > But w1_reg_num has a different layout for be/le systems, isn't it enough? > > A: > > sure, it's right only under the assumption that 'rn' is a  correct layout id. > > Here's my example in be system which I encounter before. > > buf[0]

Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error

2017-09-05 Thread Evgeniy Polyakov
ix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Looks good to me, thank you kernel-janitors@ please queue this up Acked-by: Evgeniy Polyakov <z...@ioremap.net> > --- >  drivers

Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error

2017-09-05 Thread Evgeniy Polyakov
space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Looks good to me, thank you kernel-janitors@ please queue this up Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/ds2490.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH v4 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

2017-09-05 Thread Evgeniy Polyakov
e quite for a while and failed to be merged previously since I missed it. Acked-by: Evgeniy Polyakov <z...@ioremap.net> > --- > Changes in v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 > > Changes in v3 against v2 in this subpatch: >   - fixed a bug in using the i2

Re: [PATCH v4 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

2017-09-05 Thread Evgeniy Polyakov
previously since I missed it. Acked-by: Evgeniy Polyakov > --- > Changes in v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 > > Changes in v3 against v2 in this subpatch: >   - fixed a bug in using the i2c_adapter_quirks structure > > Changes in v2 against v1 i

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-09-05 Thread Evgeniy Polyakov
t; > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Looks good to me, thanks Markus. There is virtually zero useful information in this print if we are in the situation, when kernel can not allocate a few bytes

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-09-05 Thread Evgeniy Polyakov
ned-off-by: Markus Elfring Looks good to me, thanks Markus. There is virtually zero useful information in this print if we are in the situation, when kernel can not allocate a few bytes to run connector queue. Acked-by: Evgeniy Polyakov kernel-janitors@ please queue this patch up > --

Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu

2017-08-27 Thread Evgeniy Polyakov
Hi Chen 19.07.2017, 10:58, "Chen Lin" : > The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must > be the same with the byterorder defined in struct w1_reg_num. > > The rn read from 'rv = w1_read_block(dev, (u8 *), 8)' is a byte > serial and not cpu endian

Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu

2017-08-27 Thread Evgeniy Polyakov
Hi Chen 19.07.2017, 10:58, "Chen Lin" : > The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must > be the same with the byterorder defined in struct w1_reg_num. > > The rn read from 'rv = w1_read_block(dev, (u8 *), 8)' is a byte > serial and not cpu endian relative, it need to

Re: [PATCH linux v5 0/3] Export 1-wire thermal sensors as hwmon device

2017-08-27 Thread Evgeniy Polyakov
Hi 18.07.2017, 02:09, "Jaghathiswari Rankappagounder Natarajan" : > Hi Greg, > Please pull in this patchset into the tree. Thanks! Here is a patchset, is it visible in your mailbox? If so, please pull it into your tree. > Summary of what this patchset does: > > Our board has 4

Re: [PATCH linux v5 0/3] Export 1-wire thermal sensors as hwmon device

2017-08-27 Thread Evgeniy Polyakov
Hi 18.07.2017, 02:09, "Jaghathiswari Rankappagounder Natarajan" : > Hi Greg, > Please pull in this patchset into the tree. Thanks! Here is a patchset, is it visible in your mailbox? If so, please pull it into your tree. > Summary of what this patchset does: > > Our board has 4 DS18B20 1-wire

Re: [PATCH v4 1/2] wire: export w1_touch_bit

2017-08-27 Thread Evgeniy Polyakov
ra <j...@gmx.de> > --- > Changes in v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 Greg, please pull this patch series into the tree, it has been adopted to the latest vanilla tree to date. Acked-by: Evgeniy Polyakov <z...@ioremap.net>

Re: [PATCH v4 1/2] wire: export w1_touch_bit

2017-08-27 Thread Evgeniy Polyakov
in v4 against v3 in this subpatch: >   - adapted to linux-4.12.0 Greg, please pull this patch series into the tree, it has been adopted to the latest vanilla tree to date. Acked-by: Evgeniy Polyakov

Re: [PATCH v4 0/5] w1: ds1wm: register access patch

2017-08-27 Thread Evgeniy Polyakov
Hi everyone 25.07.2017, 14:27, "Johannes Poehlmann" : > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit) > with a register offset multiplier of 4 I had to make some changes to > Version 4 of the patchset >    work on Greg Kroah-Hartmanns

Re: [PATCH v4 0/5] w1: ds1wm: register access patch

2017-08-27 Thread Evgeniy Polyakov
Hi everyone 25.07.2017, 14:27, "Johannes Poehlmann" : > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit) > with a register offset multiplier of 4 I had to make some changes to > Version 4 of the patchset >    work on Greg Kroah-Hartmanns comments: > o added changelog

Re: [PATCH v2 1/2] power: supply: move HDQ interface for bq27xxx from w1 to power/supply

2017-08-27 Thread Evgeniy Polyakov
Hi everyone Sorry for long delay 25.07.2017, 16:48, "Sebastian Reichel" : > Here is a signed immutable branch for Andrew's patch, which moves > bq27000 w1 driver to the power-supply subsystem. I guess git will > figure everything out without this, but better

Re: [PATCH v2 1/2] power: supply: move HDQ interface for bq27xxx from w1 to power/supply

2017-08-27 Thread Evgeniy Polyakov
Hi everyone Sorry for long delay 25.07.2017, 16:48, "Sebastian Reichel" : > Here is a signed immutable branch for Andrew's patch, which moves > bq27000 w1 driver to the power-supply subsystem. I guess git will > figure everything out without this, but better safe than sorry :) > > The following

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

2017-07-13 Thread Evgeniy Polyakov
Hi 13.07.2017, 18:36, "Evgeniy Polyakov" <z...@ioremap.net>: > I believe this is a resend of your previous patchet, isn't it? > Greg, if you hadn't yet, please pull it into the tree. Aaand it looks like we have a discussion now, so please postpone it for a while :)

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

2017-07-13 Thread Evgeniy Polyakov
Hi 13.07.2017, 18:36, "Evgeniy Polyakov" : > I believe this is a resend of your previous patchet, isn't it? > Greg, if you hadn't yet, please pull it into the tree. Aaand it looks like we have a discussion now, so please postpone it for a while :)

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

2017-07-13 Thread Evgeniy Polyakov
Hi 13.07.2017, 00:41, "Jaghathiswari Rankappagounder Natarajan" : > Our board has 4 DS18B20 1-wire temperature sensors. Each 1-wire bus and the > sensor under it is already configured against the Linux 1-wire driver > (called w1). They have a sysfs file(e.g. >

Re: [PATCH linux v2 0/3] Export 1-wire thermal sensors as hwmon device

2017-07-13 Thread Evgeniy Polyakov
Hi 13.07.2017, 00:41, "Jaghathiswari Rankappagounder Natarajan" : > Our board has 4 DS18B20 1-wire temperature sensors. Each 1-wire bus and the > sensor under it is already configured against the Linux 1-wire driver > (called w1). They have a sysfs file(e.g. >

Re: [PATCH v4 1/2] wire: export w1_touch_bit

2017-07-13 Thread Evgeniy Polyakov
May be also useful later for writing drivers for other Onewire chips > which do single-bit communication. > > Signed-off-by: Jan Kandziora <j...@gmx.de> Greg, please pull this patchset into the tree, I missed it last time and it stuck in the queues for a too long. T

Re: [PATCH v4 1/2] wire: export w1_touch_bit

2017-07-13 Thread Evgeniy Polyakov
later for writing drivers for other Onewire chips > which do single-bit communication. > > Signed-off-by: Jan Kandziora Greg, please pull this patchset into the tree, I missed it last time and it stuck in the queues for a too long. Thank you. Acked-by: Evgeniy Polyakov > --- > F

Re: [PATCH v2 0/4] w1: ds1wm: register access patch

2017-06-29 Thread Evgeniy Polyakov
Hi everyone Greg, please pull this into your tree 23.06.2017, 13:47, "Johannes Poehlmann" : > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit) > with a register offset multiplier of 4 I had to make some changes to > >    

Re: [PATCH v2 0/4] w1: ds1wm: register access patch

2017-06-29 Thread Evgeniy Polyakov
Hi everyone Greg, please pull this into your tree 23.06.2017, 13:47, "Johannes Poehlmann" : > To make the ds1wm driver work on a powerpc architecture (big endian, 32bit) > with a register offset multiplier of 4 I had to make some changes to > >    drivers/w1/masters/ds1wm.c > and

Re: [PATCH linux v1 0/3] Export 1-wire thermal sensors as hwmon device

2017-06-17 Thread Evgeniy Polyakov
sion v4.10. Looks good to me, thank you. Acked-by: Evgeniy Polyakov <z...@ioremap.net>

Re: [PATCH linux v1 0/3] Export 1-wire thermal sensors as hwmon device

2017-06-17 Thread Evgeniy Polyakov
ooks good to me, thank you. Acked-by: Evgeniy Polyakov

Re: [PATCH] w1: w1-gpio: Fix double-free of platform_data

2017-04-29 Thread Evgeniy Polyakov
Hi Alexey 25.03.2017, 20:08, "Alexey Ignatov" : > struct w1_gpio_platform_data was allocated using devres when using > device tree. Then it was assigned to dev.platform_data, which leaded > to double free on device removal by devres and by direct > kfree(platform_data) in

Re: [PATCH] w1: w1-gpio: Fix double-free of platform_data

2017-04-29 Thread Evgeniy Polyakov
Hi Alexey 25.03.2017, 20:08, "Alexey Ignatov" : > struct w1_gpio_platform_data was allocated using devres when using > device tree. Then it was assigned to dev.platform_data, which leaded > to double free on device removal by devres and by direct > kfree(platform_data) in platform_device_release)

Re: [PATCH v2 21/23] MAINTAINERS: Add file patterns for w1 device tree bindings

2017-03-13 Thread Evgeniy Polyakov
and which tree should it come into. If it is ok, Greg, please pull it into your one, or I see devicetree@ mail in copy... Stumbled > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Evgeniy Polyakov <z...@ioremap.net> > Cc: Greg Kroah-Hartman <gre...@linuxf

Re: [PATCH v2 21/23] MAINTAINERS: Add file patterns for w1 device tree bindings

2017-03-13 Thread Evgeniy Polyakov
nto. If it is ok, Greg, please pull it into your one, or I see devicetree@ mail in copy... Stumbled > Signed-off-by: Geert Uytterhoeven > Cc: Evgeniy Polyakov > Cc: Greg Kroah-Hartman > --- > Please apply this patch directly if you want to be involved in device > tree bindin

Re: [PATCH v2 0/4] w1: add DS2438 support, documentation and small fixes

2017-02-23 Thread Evgeniy Polyakov
Hi everyone 23.02.2017, 09:38, "Mariusz Bialonczyk" : > This is my second version of my w1 patchset. > It mainly adds support for the DS2438. There is also a documentation > for it and also a missing one for DS2413. Looks good to me, thank you Greg, please pull it into your

Re: [PATCH v2 0/4] w1: add DS2438 support, documentation and small fixes

2017-02-23 Thread Evgeniy Polyakov
Hi everyone 23.02.2017, 09:38, "Mariusz Bialonczyk" : > This is my second version of my w1 patchset. > It mainly adds support for the DS2438. There is also a documentation > for it and also a missing one for DS2413. Looks good to me, thank you Greg, please pull it into your tree

Re: [PATCH] i2c: w1: Add devicetree match for DS2482

2017-01-23 Thread Evgeniy Polyakov
Hi Colin 22.01.2017, 20:55, "Colin Godsey" <crgod...@gmail.com>: > Adds the OF devicetree match for the DS2482 I2C-1wire master and adds a > listing to the I2C trivial devicetree bindings doc. Based on a proposed patch > by Hector Palacios. Looks good to me. Acke

Re: [PATCH] i2c: w1: Add devicetree match for DS2482

2017-01-23 Thread Evgeniy Polyakov
Hi Colin 22.01.2017, 20:55, "Colin Godsey" : > Adds the OF devicetree match for the DS2482 I2C-1wire master and adds a > listing to the I2C trivial devicetree bindings doc. Based on a proposed patch > by Hector Palacios. Looks good to me. Acked-by: Evgeniy Polyakov

Re: [PATCH] w1: omap_hdq: Free resources on error path

2017-01-23 Thread Evgeniy Polyakov
es the > error code returned by '_omap_hdq_reset()' instead of returning -EINVAL > unconditionally. > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Looks good to me. If kernel-janitors@ will not push it upstream feel free to send to to GregKH <g...@kroah.com

Re: [PATCH] w1: omap_hdq: Free resources on error path

2017-01-23 Thread Evgeniy Polyakov
omap_hdq_reset()' instead of returning -EINVAL > unconditionally. > > Signed-off-by: Christophe JAILLET Looks good to me. If kernel-janitors@ will not push it upstream feel free to send to to GregKH and add me to copy. Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/omap_hdq

Re: [PATCH] [RFC] proc connector: add namespace events

2016-09-12 Thread Evgeniy Polyakov
Hi everyone 08.09.2016, 18:39, "Alban Crequy" : > The act of a process creating or joining a namespace via clone(), > unshare() or setns() is a useful signal for monitoring applications. > + if (old_ns->mnt_ns != new_ns->mnt_ns) > + proc_ns_connector(tsk, CLONE_NEWNS,

Re: [PATCH] [RFC] proc connector: add namespace events

2016-09-12 Thread Evgeniy Polyakov
Hi everyone 08.09.2016, 18:39, "Alban Crequy" : > The act of a process creating or joining a namespace via clone(), > unshare() or setns() is a useful signal for monitoring applications. > + if (old_ns->mnt_ns != new_ns->mnt_ns) > + proc_ns_connector(tsk, CLONE_NEWNS, PROC_NM_REASON_CLONE,

Re: [PATCH v2] w1: fix typo in parameter description

2016-08-12 Thread Evgeniy Polyakov
Hi 11.08.2016, 03:03, "Wei Yongjun" <weiyj...@gmail.com>: > Fix typo in parameter description. > > Signed-off-by: Wei Yongjun <weiyj...@gmail.com> Looks good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov <z...@ioremap.net>

Re: [PATCH v2] w1: fix typo in parameter description

2016-08-12 Thread Evgeniy Polyakov
Hi 11.08.2016, 03:03, "Wei Yongjun" : > Fix typo in parameter description. > > Signed-off-by: Wei Yongjun Looks good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov > --- > v1 -> v2: make it as one line, comments from Evgeniy Polya

Re: [PATCH] w1: fix timeout_us parameter description

2016-08-10 Thread Evgeniy Polyakov
Hi 10.08.2016, 06:22, "Wei Yongjun" : >>  08.08.2016, 16:52, "Wei Yongjun" : >>>  Fix 'timeout_us' parameter description. >>>   MODULE_PARM_DESC(timeout, "time in seconds between automatic slave >>> searches"); >>>   module_param_named(timeout_us,

Re: [PATCH] w1: fix timeout_us parameter description

2016-08-10 Thread Evgeniy Polyakov
Hi 10.08.2016, 06:22, "Wei Yongjun" : >>  08.08.2016, 16:52, "Wei Yongjun" : >>>  Fix 'timeout_us' parameter description. >>>   MODULE_PARM_DESC(timeout, "time in seconds between automatic slave >>> searches"); >>>   module_param_named(timeout_us, w1_timeout_us, int, 0); >>>  

Re: [PATCH] w1: fix timeout_us parameter description

2016-08-09 Thread Evgeniy Polyakov
Hi 08.08.2016, 16:52, "Wei Yongjun" : > Fix 'timeout_us' parameter description. > > Signed-off-by: Wei Yongjun > --- >  drivers/w1/w1.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index

Re: [PATCH] w1: fix timeout_us parameter description

2016-08-09 Thread Evgeniy Polyakov
Hi 08.08.2016, 16:52, "Wei Yongjun" : > Fix 'timeout_us' parameter description. > > Signed-off-by: Wei Yongjun > --- >  drivers/w1/w1.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index bb34362..e213c67 100644 > ---

Re: [PATCH] w1: Remove unneeded header file

2016-06-28 Thread Evgeniy Polyakov
Hi 28.06.2016, 16:50, "Julia Lawall" : >>  24.06.2016, 09:18, "Amitoj Kaur Chawla" : >>  > The Coccinelle semantic patch used to make this change is as follows: >>  > @ includesmodule @ >>  > @@ >>  > >>  > #include >>  > >>  > @ depends on

Re: [PATCH] w1: Remove unneeded header file

2016-06-28 Thread Evgeniy Polyakov
Hi 28.06.2016, 16:50, "Julia Lawall" : >>  24.06.2016, 09:18, "Amitoj Kaur Chawla" : >>  > The Coccinelle semantic patch used to make this change is as follows: >>  > @ includesmodule @ >>  > @@ >>  > >>  > #include >>  > >>  > @ depends on includesmodule @ >>  > @@ >>  > >>  > - #include >>  >

Re: [PATCH] w1: Remove unneeded header file

2016-06-28 Thread Evgeniy Polyakov
Hi 24.06.2016, 09:18, "Amitoj Kaur Chawla" : > Drop redundant include of moduleparam.h > > The Coccinelle semantic patch used to make this change is as follows: > @ includesmodule @ > @@ > > #include > > @ depends on includesmodule @ > @@ > > - #include > > Signed-off-by:

Re: [PATCH] w1: Remove unneeded header file

2016-06-28 Thread Evgeniy Polyakov
Hi 24.06.2016, 09:18, "Amitoj Kaur Chawla" : > Drop redundant include of moduleparam.h > > The Coccinelle semantic patch used to make this change is as follows: > @ includesmodule @ > @@ > > #include > > @ depends on includesmodule @ > @@ > > - #include > > Signed-off-by: Amitoj Kaur Chawla

Re: [PATCH] connector: fix out-of-order cn_proc netlink message delivery

2016-06-28 Thread Evgeniy Polyakov
Hi Aaron 24.06.2016, 16:07, "Aaron Campbell" : > The proc connector messages include a sequence number, allowing userspace > programs to detect lost messages. However, performing this detection is > currently more difficult than necessary, since netlink messages can be >

Re: [PATCH] connector: fix out-of-order cn_proc netlink message delivery

2016-06-28 Thread Evgeniy Polyakov
Hi Aaron 24.06.2016, 16:07, "Aaron Campbell" : > The proc connector messages include a sequence number, allowing userspace > programs to detect lost messages. However, performing this detection is > currently more difficult than necessary, since netlink messages can be > delivered to the

Re: [PATCH] w1: add ability to set (SRAM) and store (EEPROM) configuration for temp sensors like DS18B20

2016-04-27 Thread Evgeniy Polyakov
precision when running on a kernel based device (unlike the Dallas > 1Wire library for e.g. Arduino, which supports writing the > configuration/scratchpad). This looks good to me, Greg, please pull it into your tree > Signed-off-by: x29a <0.x29...@gmail.com> Acked-by: Evgeniy

Re: [PATCH] w1: add ability to set (SRAM) and store (EEPROM) configuration for temp sensors like DS18B20

2016-04-27 Thread Evgeniy Polyakov
precision when running on a kernel based device (unlike the Dallas > 1Wire library for e.g. Arduino, which supports writing the > configuration/scratchpad). This looks good to me, Greg, please pull it into your tree > Signed-off-by: x29a <0.x29...@gmail.com> Acked-by: Evgeniy

Re: [patch] w1: silence an uninitialized variable warning

2016-04-27 Thread Evgeniy Polyakov
Hi Dan 14.04.2016, 12:36, "Dan Carpenter" : > If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Looks good to me, please pull it into janitors tree > Signed-off-by: Dan Carpenter Acked-by: Evgeniy Polaykov >

Re: [patch] w1: silence an uninitialized variable warning

2016-04-27 Thread Evgeniy Polyakov
Hi Dan 14.04.2016, 12:36, "Dan Carpenter" : > If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Looks good to me, please pull it into janitors tree > Signed-off-by: Dan Carpenter Acked-by: Evgeniy Polaykov > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 89a7847..bb34362

Re: [PATCH] w1: w1_process() is not freezable kthread

2015-11-05 Thread Evgeniy Polyakov
Hi 28.10.2015, 08:26, "Jiri Kosina" : > On Tue, 27 Oct 2015, Evgeniy Polyakov wrote: > >>  > w1_process() calls try_to_freeze(), but the thread doesn't mark itself >>  > freezable through set_freezable(), so the try_to_freeze() call is useless. >> >>

Re: [PATCH] w1: w1_process() is not freezable kthread

2015-11-05 Thread Evgeniy Polyakov
Hi 28.10.2015, 08:26, "Jiri Kosina" <ji...@kernel.org>: > On Tue, 27 Oct 2015, Evgeniy Polyakov wrote: > >>  > w1_process() calls try_to_freeze(), but the thread doesn't mark itself >>  > freezable through set_freezable(), so the try_to_freeze() call i

Re: [PATCH] w1: w1_process() is not freezable kthread

2015-10-27 Thread Evgeniy Polyakov
Hi 26.10.2015, 08:53, "Jiri Kosina" : > From: Jiri Kosina > > w1_process() calls try_to_freeze(), but the thread doesn't mark itself > freezable through set_freezable(), so the try_to_freeze() call is useless. I believe it is better to mark it freezable, what do you think? Its task is useless

Re: [PATCH] w1: w1_process() is not freezable kthread

2015-10-27 Thread Evgeniy Polyakov
Hi 26.10.2015, 08:53, "Jiri Kosina" : > From: Jiri Kosina > > w1_process() calls try_to_freeze(), but the thread doesn't mark itself > freezable through set_freezable(), so the try_to_freeze() call is useless. I believe it is better to mark it freezable, what

Re: [PATCH] w1: Use module_pci_driver

2015-07-11 Thread Evgeniy Polyakov
Hi everyone Patch looks good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov 07.07.2015, 09:55, "Vaishali Thakkar" : > Use module_pci_driver for drivers whose init and exit functions > only register and unregister, respectively. > Sign

Re: [PATCH] w1: Drop owner assignment from i2c_driver

2015-07-11 Thread Evgeniy Polyakov
Hi Krzysztof Patch looks good to me, thank you. Greg, please pull it into your tree. Acked-by: Evgeniy Polyakov 10.07.2015, 09:38, "Krzysztof Kozlowski" : > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-b

Re: [PATCH] w1: Drop owner assignment from i2c_driver

2015-07-11 Thread Evgeniy Polyakov
Hi Krzysztof Patch looks good to me, thank you. Greg, please pull it into your tree. Acked-by: Evgeniy Polyakov z...@ioremap.net 10.07.2015, 09:38, Krzysztof Kozlowski k.kozlow...@samsung.com: i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off

Re: [PATCH] w1: Use module_pci_driver

2015-07-11 Thread Evgeniy Polyakov
Hi everyone Patch looks good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov z...@ioremap.net 07.07.2015, 09:55, Vaishali Thakkar vthakkar1...@gmail.com: Use module_pci_driver for drivers whose init and exit functions only register and unregister, respectively

Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show()

2015-06-11 Thread Evgeniy Polyakov
y: Dan Carpenter Looks good to me, Greg please pull this serie into your tree, if you hadn't yet. Am I right that this is a stable tree material too? Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord..

Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-06-11 Thread Evgeniy Polyakov
Hi 25.05.2015, 08:15, "Vignesh R" : >>  HDQ mode remains unchanged. >> >>  Signed-off-by: Vignesh R I have no experience with omap_hdq platform, but there are quite a few questions related to IO - you never check whether write was successful or read returned actually valid data, is it ok? I

Re: [PATCH v2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-06-11 Thread Evgeniy Polyakov
Hi 25.05.2015, 08:15, Vignesh R vigne...@ti.com:  HDQ mode remains unchanged.  Signed-off-by: Vignesh R vigne...@ti.com I have no experience with omap_hdq platform, but there are quite a few questions related to IO - you never check whether write was successful or read returned actually

Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show()

2015-06-11 Thread Evgeniy Polyakov
, Greg please pull this serie into your tree, if you hadn't yet. Am I right that this is a stable tree material too? Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

  1   2   3   4   5   6   7   8   9   10   >