Re: [PATCH v3 3/4] arm: dts: imx: Add i.mx6q DaSheng COM-9XX SBC board support

2021-04-20 Thread Fabio Estevam
Hi Dillon, On Thu, Apr 15, 2021 at 1:05 AM wrote: > + green { > + gpios = <&gpio4 8 0>; Please use GPIO_ACTIVE_HIGH label instead: gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>; > +&clks { > + assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>, > +

Re: [PATCH] imx-sc: remove .read_alarm

2021-04-19 Thread Fabio Estevam
Hi Alexandre, On Sat, Apr 17, 2021 at 8:52 PM Alexandre Belloni wrote: > > The RTC core properly handles RTC without .read_alarm and doesn't use it to > set alarms. .read_alarm can be safely dropped. > > Signed-off-by: Alexandre Belloni Reviewed-by: Fabio Estevam

Re: [PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Fabio Estevam
Hi Greg, On Sat, Apr 10, 2021 at 6:15 AM Greg Kroah-Hartman wrote: > What is the git commit id of it in Linus's tree? It is b41ba2ec54a70908067034f139aa23d0dd2985ce Thanks

Re: [PATCH v2 0/7] remove different PHY fixups

2021-03-30 Thread Fabio Estevam
Hi Andrew, On Tue, Mar 30, 2021 at 11:30 AM Andrew Lunn wrote: > Hi Fabio > > I think it should be merged, and we fixup anything which does break. > We are probably at the point where more is broken by not merging it > than merging it. Thanks for your feedback. I agree. Shawn wants to collect

Re: [PATCH v2 0/7] remove different PHY fixups

2021-03-30 Thread Fabio Estevam
ity to break old dtb's. Reviewed-by: Fabio Estevam Andrew, what do you think? Thanks

Re: [PATCH] usb: dwc3: imx8mp: fix incorrect kernel-doc comment syntax

2021-03-29 Thread Fabio Estevam
ype was for USB_WAKEUP_CTRL() > instead" > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava It looks good, thanks: Reviewed-by: Fabio Estevam

Re: [PATCH v2 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing

2021-03-29 Thread Fabio Estevam
ned-off-by: Stefan Riedmueller Thanks for the respin: Reviewed-by: Fabio Estevam

Re: [PATCH 3/3] ARM: dts: imx6: pbab01: Set vmmc supply for both SD interfaces

2021-03-29 Thread Fabio Estevam
It seems that this deserves a Fixes tag. Reviewed-by: Fabio Estevam

Re: [PATCH 2/3] ARM: dts: imx6: pbab01: Set USB OTG port to peripheral

2021-03-29 Thread Fabio Estevam
> Signed-off-by: Stefan Riedmueller Reviewed-by: Fabio Estevam

Re: [PATCH 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing

2021-03-29 Thread Fabio Estevam
Hi Stefan, On Mon, Mar 29, 2021 at 8:28 AM Stefan Riedmueller wrote: > - pinctrl_usbh1: usbh1grp { > + pinctrl_usbh1_vbus: usbh1vbusgrp { > fsl,pins = < > - MX6QDL_PAD_GPIO_0__USB_H1_PWR > 0x8000 > +

Re: [PATCH v2] arm64: dts: imx8mm/q: Fix pad control of SD1_DATA0

2021-03-24 Thread Fabio Estevam
address access. > > Signed-off-by: Oliver Stäbler Thanks for the fix: Reviewed-by: Fabio Estevam

Re: [PATCH] arm64: dts: imx8mm: Fix pad control of SD1_DATA0

2021-03-23 Thread Fabio Estevam
address access. > > Signed-off-by: Oliver Stäbler I checked in the RM and your patch is correct, thanks: Reviewed-by: Fabio Estevam I will send a patch fixing imx8mq-pinfunc.h as it has the same error.

Re: [PATCH] drm/imx: fix out of bounds array access warning

2021-03-23 Thread Fabio Estevam
Hi Arnd, On Tue, Mar 23, 2021 at 10:05 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/im

Re: [PATCH v2 1/2] dt-bindings: arm: imx: add imx8mm gw7901 support

2021-03-21 Thread Fabio Estevam
; > Acked-by: Rob Herring > Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam

Re: [PATCH v2 2/2] arm64: dts: imx: Add i.mx8mm Gateworks gw7901 dts support

2021-03-21 Thread Fabio Estevam
pto Authentication > - USB 2.0 > - Microchip GbE Switch > - Multiple multi-protocol RS232/RS485/RS422 Serial ports > - onboard 802.11ac WiFi / BT > - microSD socket > - miniPCIe socket with PCIe, USB 2.0 and dual SIM sockets > - Wide range DC power input > - 802.3at PoE

Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-21 Thread Fabio Estevam
Hi Alistair, On Mon, Mar 15, 2021 at 11:27 PM Alistair Francis wrote: > > The reMarkable2 (https://remarkable.com) is an e-ink tablet based on > the imx7d SoC. > > This commit is based on the DTS provide by reMarkable but ported to the > latest kernel (instead of 4.14). I have removed references

Re: [PATCH V1] arm64: dts: imx8mp: fix FEC can't work when attached to generic phy driver

2021-03-18 Thread Fabio Estevam
Hi Joakim, On Thu, Mar 18, 2021 at 8:04 AM Joakim Zhang wrote: > Hi Shawn, > > Seems you prefer to 2, is it possible to buildin Realtek > PHY(CONFIG_REALTEK_PHY=y)? If not, it is going to be tricky. Yes, we should select the driver as built-in and describe the reset timing requirements as per

Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards

2021-03-17 Thread Fabio Estevam
Hi Heiko, On Wed, Mar 17, 2021 at 8:52 AM Heiko Thiery wrote: > > Do we really want it to be built-in? If so, it would be nice to have some > > comments about that in commit log. > > Why would you not want it? I see other SOC PCI controllers are also > enabled. I would like to have it because w

Re: [PATCH] sound: soc: fsl: Remove unnecessary THIS_MODULE

2021-03-13 Thread Fabio Estevam
Hi Wang, On Sat, Mar 13, 2021 at 5:25 AM Wang Qing wrote: > > As THIS_MODULE has been set in module_platform_driver(), so remove it. > > Signed-off-by: Wang Qing Thanks for the patch, but someone else has already sent the same.

Re: [PATCH v2] ASoC: imx-hdmi: fix platform_no_drv_owner.cocci warnings

2021-03-13 Thread Fabio Estevam
Hi Yang, On Thu, Mar 4, 2021 at 6:08 AM Yang Li wrote: > > ./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core > will do it. > > Remove .owner field if calls are used which set it automatically > > Reported-by: Abaci Robot > Signed-off-by: Yang

Re: [PATCH] arm64: configs: Enable PCIe support for imx8mq boards

2021-03-11 Thread Fabio Estevam
Hi Heiko, On Thu, Mar 11, 2021 at 1:13 PM Heiko Thiery wrote: > > > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk, > > > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. This increases the image > > > by 64k. > > > > The growth of 64k is not right. Please resend this patch

Re: [PATCH] ARM: dts: imx6ull: fix ubi filesystem mount failed

2021-03-09 Thread Fabio Estevam
13:4096, read 22528 bytes > > Fixes: f9ecf10cb88c ("ARM: dts: imx6ull: add MYiR MYS-6ULX SBC") > Signed-off-by: dillon min Reviewed-by: Fabio Estevam

Re: [PATCH 1/1] arm64: dts: imx8mm-nitrogen-r2: add espi2 support

2021-03-08 Thread Fabio Estevam
Hi Adrien, On Mon, Mar 8, 2021 at 9:40 AM Adrien Grassein wrote: > > Add the description for espi support. Nit: In the subject and commit log, it should be ecspi2 instead of espi. With that fixed: Reviewed-by: Fabio Estevam

Re: [PATCH V2] arm64: dts: imx8mp: add wdog2/3 nodes

2021-03-07 Thread Fabio Estevam
On Sun, Mar 7, 2021 at 7:42 AM wrote: > > From: Peng Fan > > There is wdog[2,3] in i.MX8MP, so add them. > > Signed-off-by: Peng Fan Reviewed-by: Fabio Estevam

Re: [PATCH] arm64: dts: imx8mp: add wdog2/3 nodes

2021-03-06 Thread Fabio Estevam
Hi Peng, On Sat, Mar 6, 2021 at 8:41 AM wrote: > > From: Peng Fan > > There is wdog[2,3] in i.MX8MP, so add them, all wdogs share the > same clock root, so use the wdog1 clk here. The patch looks good, but I don't understand this sentence where you state that "all wdogs share the same clock roo

Re: [PATCH] ARM: dts: colibri-imx6ull: Change drive strength for usdhc2

2021-03-04 Thread Fabio Estevam
t; those traces. > > This commit changes the source-impedance to 52 Ohms to better match our > hardware design. > > The impedances given in this commit message refer to 3.3V operation. > > Signed-off-by: Philippe Schenker Reviewed-by: Fabio Estevam

Re: [PATCH v4 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-03-03 Thread Fabio Estevam
Hi Heiko, On Wed, Mar 3, 2021 at 6:11 PM Heiko Thiery wrote: > > The Kontron pitx-imx8m board is based on an i.MX8MQ soc. > > Signed-off-by: Heiko Thiery > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Michael Walle Reviewed-by: Fabio Estevam

Re: [PATCH] ASoC: hdmi-codec: fix platform_no_drv_owner.cocci warnings

2021-03-03 Thread Fabio Estevam
Hi Yang, On Wed, Mar 3, 2021 at 5:54 AM Yang Li wrote: > > ./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core > will do it. > > Remove .owner field if calls are used which set it automatically > > Reported-by: Abaci Robot > Signed-off-by: Yang Li The patch looks good, but

Re: [PATCH v2 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-03-03 Thread Fabio Estevam
Hi Heiko, On Wed, Mar 3, 2021 at 9:54 AM Heiko Thiery wrote: > > reg_usdhc2_vmmc: regulator-usdhc2-vmmc { > > I used the same name as used on imx8mq-evk. Do you think a better name > is the one you proposed? Yes, the way I proposed is the preferred one. Thanks

Re: [PATCH v2 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-03-02 Thread Fabio Estevam
Hi Heiko, On Mon, Feb 22, 2021 at 11:08 AM Heiko Thiery wrote: > + reg_usdhc2_vmmc: regulator-v-3v3-sd { reg_usdhc2_vmmc: regulator-usdhc2-vmmc { > + tpm_reset: tpm-reset { > + compatible = "gpio-reset"; I don't see this compatible string documented. > +

Re: [PATCH v2 3/7] ASoC: dt-bindings: fsl_rpmsg: Add binding doc for rpmsg cpu dai driver

2021-02-24 Thread Fabio Estevam
On Thu, Feb 18, 2021 at 4:21 AM Shengjiu Wang wrote: > > rpmsg is a protocol. What's the h/w block? > > On Linux side this driver is a virtual driver, it is running > on Arm Cortex-A core. The h/w block is controlled by > another core (cortex-M core). so this driver actually > doesn't touch any h

Re: [PATCH AUTOSEL 5.11 05/67] can: flexcan: add CAN wakeup function for i.MX8QM

2021-02-24 Thread Fabio Estevam
Hi Sasha, On Wed, Feb 24, 2021 at 10:35 PM Sasha Levin wrote: > > From: Joakim Zhang > > [ Upstream commit 812f0116c66a3ebaf0b6062226aa85574dd79f67 ] > > The System Controller Firmware (SCFW) is a low-level system function > which runs on a dedicated Cortex-M core to provide power, clock, and >

Re: [PATCH] pinctrl: imx: imx8mm: fix pad offset of SD1_DATA0 pin

2021-02-11 Thread Fabio Estevam
Hi Claudius, On Thu, Feb 11, 2021 at 7:15 AM Claudius Heine wrote: > > Hi, > > can you please add: > > Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm") Yes, I was about to suggest the same. Thanks for the fix: Reviewed-by: Fabio Estevam

Re: [PATCH v3] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-02-04 Thread Fabio Estevam
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Reported-by: Martin Kaiser > Signed-off-by: Saravana Kannan > Tested-by: Martin Kaiser Thanks for the respin: Reviewed-by: Fabio Estevam

Re: [PATCH v2] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-02-04 Thread Fabio Estevam
Hi Saravana, On Thu, Feb 4, 2021 at 7:56 PM Saravana Kannan wrote: > > Remove a lot of boilerplate code. Also address boot issues on imx25 with > fw_devlink=on that were reported by Martin. The commit message could be improved. It starts like it was just a clean-up and then it says it fixes a b

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-04 Thread Fabio Estevam
; + .height = 86, > + }, > + .delay = { > + .prepare = 20 + 20 + 10 + 10, Adding the datasheet label like Marco suggested make it clearer where these numbers come from : /* T0 + T2 + T3 + T4 */ Glad you got it working on your imx6ul board: Reviewed-by: Fabio Estevam

Re: [PATCH] spi: Fix the logic around the maximum speed

2021-02-03 Thread Fabio Estevam
Hi Miquel, On Wed, Feb 3, 2021 at 2:06 PM Miquel Raynal wrote: > > Commit 9326e4f1e5dd ("spi: Limit the spi device max speed to controller's max > speed") > rationaly introduced a new condition on which the device's maximum > speed would be set to the controller's one: if the device advertizes a

Re: [PATCH] pinctrl: Support pin that does not support configuration option

2021-02-01 Thread Fabio Estevam
Hi Michael, On Sat, Jan 30, 2021 at 5:21 AM Michael Trimarchi wrote: > > Some of the iMX25 pins have not an associated configuration register so > when they are configured the standard way through the device tree the > kernel complains with: > > imx25-pinctrl 43fac000.iomuxc: Pin(MX25_PAD_EXT_ARM

Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Fabio Estevam
Hi Saravana, On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan wrote: > +static int __init imx_avic_init(struct device_node *node, > + struct device_node *parent) > +{ > + void __iomem *avic_base; > + > + avic_base = of_iomap(node, 0); > + BUG_ON(!avi

Re: [PATCH] ARM: dts: imx6qdl-wandboard: add scl/sda gpios definitions for i2c bus recovery

2021-01-31 Thread Fabio Estevam
and no audio. > > This scenario is improved by adding scl/sda gpios definitions to implement the > i2c bus recovery mechanism. > > Signed-off-by: Dima Azarkin Reviewed-by: Fabio Estevam

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-26 Thread Fabio Estevam
Hi Oliver, On Mon, Jan 25, 2021 at 7:17 PM Oliver Graute wrote: > I would prefer mine, because I got a wrong colored penguin on bootup > with yours :-) I have originally passed .bpc = 8, but looking at the panel datasheet, this should be: .bpc = 6 instead. In your patch, you pass the timing pa

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-25 Thread Fabio Estevam
Hi Oliver, On Mon, Jan 25, 2021 at 6:29 PM Oliver Graute wrote: > Ok I fixed the pin conflict with regulator-gpio and added a 5V > regulator node in my dts file. Now the display is working fine! That's good news :-) > I'll post the dts files soon and check if there is something to > improve fo

Re: [PATCH] mmc: core: Apply trim broken quirk to R1J57L

2021-01-25 Thread Fabio Estevam
Hi Haibo, Could you please take a look? Thanks On Thu, Jan 21, 2021 at 10:26 AM Ulf Hansson wrote: > > + Fabio, Haibo > > On Thu, 21 Jan 2021 at 10:54, Wang, Xiaolei > wrote: > > > > Hi > > > > >Are you sure this is an eMMC problem and not a mmc host driver issue? > > > > >Can you elaborate m

Re: [PATCH v2 6/7] ARM: dts: imx6dl-prtvt7: fix PWM cell count for the backlight node.

2021-01-21 Thread Fabio Estevam
Hi Oleksij, On Thu, Jan 21, 2021 at 3:12 AM Oleksij Rempel wrote: > > At some point PWM cell count was changed, but it didn't triggered any It changed in this commit: commit fa28d8212ede9c533ae87a737571a9d3b3eebb29 Author: Uwe Kleine-König Date: Fri Jul 10 07:19:37 2020 +0200 ARM: dts:

Re: [PATCH v2] clk: imx6q: demote warning about pre-boot ldb_di_clk reparenting

2021-01-18 Thread Fabio Estevam
> > While at it, add the words "possible glitch" into the log message, to > make it more user-friendly. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Fabio Estevam

Re: [PATCH] spi: imx: Don't print error on -EPROBEDEFER

2021-01-18 Thread Fabio Estevam
quot;) > Signed-off-by: Guido Günther Reviewed-by: Fabio Estevam

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-16 Thread Fabio Estevam
On Sat, Jan 16, 2021 at 9:49 AM Oliver Graute wrote: > > power-supply = <®_touch_3v3> is not correct, as the reg_touch_3v3 > > does not power the LCD. > > yes, but how is the LCD correctly powered then? J4 is powered by VCC_5V and VCC_3V#. > [7.795980] pwm-backlight backlight: supply power

Re: [PATCH] drm/bridge: nwl-dsi: Avoid potential multiplication overflow on 32-bit

2021-01-11 Thread Fabio Estevam
copied for a new driver. This IP is also present on i.MX7ULP, which is 32-bit, but not supported yet. Thanks for taking care of this. Reviewed-by: Fabio Estevam

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-10 Thread Fabio Estevam
On Sun, Jan 10, 2021 at 5:09 PM Oliver Graute wrote: > here the schematics and my dts. The board is using a LVDS connector for > the display. The schematics shows the GKTW70SDAD1SD panel in the J4 connector, not the LVDS J7 connector. > https://www.variscite.de/wp-content/uploads/2017/12/VAR-6U

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-10 Thread Fabio Estevam
Hi Oliver, On Sun, Jan 10, 2021 at 12:35 PM Oliver Graute wrote: > the first two errors are gone. But I still get this: > > [ 42.387107] mxsfb 21c8000.lcdif: Cannot connect bridge: -517 > > The panel is still off perhaps I miss something else. Some suggestions: - Take a look at arch/arm/boot

Re: [PATCH v3 3/3] dt-bindings: arm: fsl: Add Variscite i.MX6UL compatibles

2021-01-09 Thread Fabio Estevam
On Fri, Jan 8, 2021 at 7:23 PM Oliver Graute wrote: > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > b/Documentation/devicetree/bindings/arm/fsl.yaml > index 05906e2..5f74d78 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/ar

Re: [PATCH v8 2/3] ARM: dts: Add support for i.MX6 UltraLite DART Variscite Customboard

2021-01-09 Thread Fabio Estevam
On Fri, Jan 8, 2021 at 7:23 PM Oliver Graute wrote: > + panel1: panel-lcd { > + compatible = "sgd,gktw70sdad1sd"; > + > + backlight = <&backlight_lcd>; > + power-supply = <®_touch_3v3>; > + label = "gktw70sdad1sd"; > + > +

Re: [PATCH v8 1/3] ARM: dts: imx6ul: Add Variscite DART-6UL SoM support

2021-01-09 Thread Fabio Estevam
Hi Oliver, On Fri, Jan 8, 2021 at 7:22 PM Oliver Graute wrote: > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet1>; > + phy-mode = "rmii"; > + phy-handle = <ðphy0>; > + phy-reset-gpios=<&gpio5 10 1>; > + phy-reset-duration=<100>; These

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-09 Thread Fabio Estevam
Hi Oliver, On Fri, Jan 8, 2021 at 7:24 PM Oliver Graute wrote: > > On 19/12/20, Oliver Graute wrote: > > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD > > to panel-simple. > > > > The panel spec from Variscite can be found at: > > https://www.variscite.com/wp-content/uploads/

Re: [PATCH 3/4] ARM: imx6q: Fix missing need_resched() check after rcu_idle_enter()

2021-01-04 Thread Fabio Estevam
Hi Frederic, On Mon, Jan 4, 2021 at 12:21 PM Frederic Weisbecker wrote: > > Entering RCU idle mode may cause a deferred wake up of an RCU NOCB_GP > kthread (rcuog) to be serviced. > > Usually a wake up happening while running the idle task is spotted in > one of the need_resched() checks carefull

Re: [PATCH v2] spi: fix the divide by 0 error when calculating xfer waiting time

2021-01-02 Thread Fabio Estevam
On Sat, Jan 2, 2021 at 12:07 AM Xu Yilun wrote: > > The xfer waiting time is the result of xfer->len / xfer->speed_hz. This > patch makes the assumption of 1khz xfer speed if the xfer->speed_hz is You missed to update the commit log to 100kHz.

Re: [PATCH] Revert "clk: imx: fix composite peripheral flags"

2020-12-31 Thread Fabio Estevam
Hi Martin, On Thu, Dec 31, 2020 at 11:22 AM Martin Kepplinger wrote: > > This reverts commit 936c383673b9e3007432f17140ac62de53d87db9. > > It breaks clock reparenting via devfreq on the imx8mq used in the > Librem 5 phone. When switching dram frequency (which worked before) > the system now hangs

Re: [PATCH 3/3] ARM: dts: imx28: Add DTS description of imx28 based XEA board

2020-12-22 Thread Fabio Estevam
Hi Lukasz, On Wed, Nov 25, 2020 at 1:19 PM Lukasz Majewski wrote: > diff --git a/arch/arm/boot/dts/imx28-lwe.dtsi > b/arch/arm/boot/dts/imx28-lwe.dtsi > new file mode 100644 > index ..cb2eb4377d9c > --- /dev/null > +++ b/arch/arm/boot/dts/imx28-lwe.dtsi > @@ -0,0 +1,185 @@ > +// SPD

Re: [PATCH v2] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

2020-12-22 Thread Fabio Estevam
On Wed, Dec 9, 2020 at 7:10 PM Lukasz Majewski wrote: > > From: Mans Rullgard > > Add pinmux setting for USB1 overcurrent on pwm2 pad. > > Signed-off-by: Mans Rullgard > Signed-off-by: Lukasz Majewski Reviewed-by: Fabio Estevam

Re: [PATCH -next] i2c: busses: use DIV_ROUND_UP macro to do calculation

2020-12-22 Thread Fabio Estevam
Hi Zheng, On Tue, Dec 22, 2020 at 10:31 AM Zheng Yongjun wrote: > > Don't open-code DIV_ROUND_UP() kernel macro. > > Signed-off-by: Zheng Yongjun Reviewed-by: Fabio Estevam

Re: [PATCH v9 4/4] soc: imx8m: change to use platform driver

2020-12-22 Thread Fabio Estevam
Hi Alice, On Tue, Dec 22, 2020 at 5:11 AM Alice Guo (OSS) wrote: > - soc_uid = readl_relaxed(ocotp_base + OCOTP_UID_HIGH); > - soc_uid <<= 32; > - soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW); > + if (dev) { > + int ret = 0; No need to initialize re

Re: [PATCH] i2c-imx.c: Synthesize end of transaction events without idle interrupts

2020-12-19 Thread Fabio Estevam
Hi Kevin, On Fri, Dec 18, 2020 at 2:53 PM Kevin Herbert wrote: > > From feaf638fb9b9a483c0d6090b277f34db21160885 Mon Sep 17 00:00:00 2001 > From: Kevin Paul Herbert > Date: Tue, 15 Dec 2020 16:50:34 -0800 > Subject: [PATCH] i2c-imx.c: Synthesize end of transaction events without idle > interrup

Re: [PATCH 1/1] ARM: dts: opos6ul: add ksz8081 phy properties

2020-12-17 Thread Fabio Estevam
On Thu, Dec 17, 2020 at 7:49 AM Sébastien Szymanski wrote: > > Set clock mode and the LED mode in the device tree instead of relying on > the fixup in mach-imx6ul. > > Signed-off-by: Sébastien Szymanski Reviewed-by: Fabio Estevam

Re: [PATCH] ASoC: imx-hdmi: Fix warning of the uninitialized variable ret

2020-12-16 Thread Fabio Estevam
by: shengjiu wang > Reported-by: kernel test robot Thanks for the fix. This should have: Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver") Reviewed-by: Fabio Estevam

Re: [PATCH v3 0/2] Add support of nxp pf8x00 regulator

2020-12-15 Thread Fabio Estevam
commit/drivers?h=next-20201215&id=d3795d6321ecaa55d94dc24c3b1e3cce608aabd6 Regards, Fabio Estevam

[PATCH] regulator: pfuze100: Convert the driver to DT-only

2020-12-10 Thread Fabio Estevam
Since 5.10-rc1 i.MX is a devicetree-only platform, so simplify the code by removing the unused non-DT support. Signed-off-by: Fabio Estevam --- drivers/regulator/Kconfig | 2 +- drivers/regulator/pfuze100-regulator.c | 34 +- include/linux/regulator

Re: [PATCH v1] ARM: imx: mach-imx6ul: remove 14x14 EVK specific PHY fixup

2020-12-09 Thread Fabio Estevam
i-ref"; > ... > }; > > The board which was referred in the initial patch is already fixed. > See: arch/arm/boot/dts/imx6ul-14x14-evk.dtsi > > Signed-off-by: Oleksij Rempel Reviewed-by: Fabio Estevam

Re: [PATCH 08/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0

2020-12-02 Thread Fabio Estevam
On Wed, Dec 2, 2020 at 2:45 PM Krzysztof Kozlowski wrote: > You have multiple DTSI files to only include one DTSI. I was trying to > follow the logic here but I failed... Agreed. It is hard to understand the purpose of so many dts files in this patch series. Regards, Fabio Estevam

[PATCH v4] media: coda: Convert the driver to DT-only

2020-12-02 Thread Fabio Estevam
Since 5.10-rc1 i.MX is a devicetree-only platform, so simplify the code by removing the unused non-DT support. Signed-off-by: Fabio Estevam --- Changes since v3: - Add a explicit OF dependency - Andy drivers/media/platform/Kconfig| 2 +- drivers/media/platform/coda/coda-common.c

[PATCH v3] media: coda: Convert the driver to DT-only

2020-12-02 Thread Fabio Estevam
Since 5.10-rc1 i.MX is a devicetree-only platform, so simplify the code by removing the unused non-DT support. Signed-off-by: Fabio Estevam --- Changes since v2: - Forgot to Cc linux-media list. Changes since v1: - Drop include/linux/platform_data/media/coda.h and pdata - Hans drivers/media

[PATCH v2] media: coda: Convert the driver to DT-only

2020-12-02 Thread Fabio Estevam
Since 5.10-rc1 i.MX is a devicetree-only platform, so simplify the code by removing the unused non-DT support. Signed-off-by: Fabio Estevam --- Changes since v1: - Drop include/linux/platform_data/media/coda.h and pdata - Hans drivers/media/platform/coda/coda-common.c | 27

Re: [PATCH v1 2/2] ARM: dts: add Protonic MVT board

2020-11-30 Thread Fabio Estevam
Hi Oleksij, On Mon, Nov 30, 2020 at 10:14 AM Oleksij Rempel wrote: > +&ecspi1 { > + cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>; Shouldn't this be GPIO_ACTIVE_LOW instead?

Re: [PATCH] rtc: mxc{,_v2}: enable COMPILE_TEST

2020-11-21 Thread Fabio Estevam
On Sat, Nov 21, 2020 at 7:45 PM Alexandre Belloni wrote: > > Extend code coverage for the rtc-mxc and rtc-mxc-v2 drivers. > > Signed-off-by: Alexandre Belloni Reviewed-by: Fabio Estevam

Re: drivers/media/platform/fsl-viu.c:253:2: error: implicit declaration of function 'out_be32'

2020-11-19 Thread Fabio Estevam
On Wed, Nov 18, 2020 at 10:15 PM kernel test robot wrote: > > Hi Fabio, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: c2e7554e1b85935d962127efa3c2a76483b0b3b6 > commit: 17621758e53f0e6bf1ac469cca2a59fa64

Re: [PATCH] rtc: mxc: use of_device_get_match_data

2020-11-17 Thread Fabio Estevam
On Tue, Nov 17, 2020 at 5:30 PM Alexandre Belloni wrote: > > Use of_device_get_match_data to simplify mxc_rtc_probe. > > Signed-off-by: Alexandre Belloni Reviewed-by: Fabio Estevam

Re: [PATCH] spi: imx: enable runtime pm support

2020-11-13 Thread Fabio Estevam
Hi Nikita, On Fri, Nov 13, 2020 at 6:18 AM Nikita Shubin wrote: > > Hello Clark, > > This patch breaks spi-imx on imx7d. > Toradex Colibri imx7d spi reports with: > > [4.258468] inv-mpu6000-spi spi2.0: I/O Error in PIO > [4.264269] inv-mpu6000-spi spi2.0: SPI transfer failed: -110

Re: [PATCH] ARM: mxs: Add serial number support for i.MX23, i.MX28 SoCs

2020-11-11 Thread Fabio Estevam
23 provides 32-bit long unique id in HW_OCOTP_OPS3. > Though not clearly documented, there is a clue in sec. 35.9.3. > > The unique id is reported in /sys/devices/soc0/serial_number > and in /proc/cpuinfo > > Signed-off-by: Ivan Zaentsev > Suggested-by: Evgeny Boger It looks good, thanks: Reviewed-by: Fabio Estevam

Re: [PATCH v1] ARM: imx: mach-imx6q: correctly identify i.MX6QP SoCs

2020-11-04 Thread Fabio Estevam
ally an i.MX6QP. > > Signed-off-by: Sven Van Asbroeck Reviewed-by: Fabio Estevam

Re: [PATCH AUTOSEL 5.9 131/147] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling

2020-10-26 Thread Fabio Estevam
Hi Sasha, On Mon, Oct 26, 2020 at 8:56 PM Sasha Levin wrote: > > From: Anson Huang > > [ Upstream commit b663b798d04fb73f1ad4d54c46582d2fde7a76d6 ] > > dev_err_probe() can reduce code size, uniform error handling and record the > defer probe reason etc., use it to simplify the code. > > Signed-o

Re: [PATCH] arm64: defconfig: enable CONFIG_GPIO_MXC

2020-10-21 Thread Fabio Estevam
Hi Peng, On Wed, Oct 21, 2020 at 3:38 AM wrote: > > From: Peng Fan > > To i.MX8MP, always met "Waiting for root device /dev/mmcblk1p2...", > it is because the gpio driver not enabled. So enable CONFIG_GPIO_MXC > to make sure it could boot well. > > Signed-off-by: Peng Fan Anson has already sub

Re: [PATCH 2/3] arm64: dts: imx8mm: Add node for SPDIF

2020-10-19 Thread Fabio Estevam
Hi Krzysztof, On Mon, Oct 12, 2020 at 2:00 PM Krzysztof Kozlowski wrote: > > + spdif1: spdif@3009 { > > + compatible = "fsl,imx8mm-spdif", > > "fsl,imx35-spdif"; > > This does not pass the dtschema validation, so only "fsl,imx35-spdif". Shoul

Re: [PATCH] clk: imx8mq: Fix usdhc parents order

2020-10-15 Thread Fabio Estevam
esa > Reported-by: Cosmin Stefan Stoica Thanks for the fix: Reviewed-by: Fabio Estevam

Re: arm-smmu 5000000.iommu: Cannot accommodate DMA offset for IOMMU page tables

2020-10-14 Thread Fabio Estevam
n. I had originally reported it for an imx27 board and now I also pointed out that it also affects Layerscape: https://lore.kernel.org/linux-mtd/20201013193652.0c535c7c@xps13/T/#m09fad7eacdf86aee0834bbd8863d6d5ee2e69f8c Thanks, Fabio Estevam

Re: PHY reset question

2020-10-07 Thread Fabio Estevam
Hi Oleksij, On Tue, Oct 6, 2020 at 5:05 AM Oleksij Rempel wrote: > > Hello PHY experts, > > Short version: > what is the proper way to handle the PHY reset before identifying PHY? > > Long version: > I stumbled over following issue: > If PHY reset is registered within PHY node. Then, sometimes,

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-05 Thread Fabio Estevam
Hi Marco, On Fri, Oct 2, 2020 at 5:41 AM Marco Felsch wrote: > Question is what was the author's intention? @Fabio do you have any > comments here? Krzysztof's patch looks good: Reviewed-by: Fabio Estevam Thanks

Re: [PATCH] arm64: dts: fix endianness of rcpm

2020-09-28 Thread Fabio Estevam
Hi Ran, On Mon, Sep 28, 2020 at 6:14 AM Ran Wang wrote: > > From: Biwen Li > > Add little-endian property of rcpm for ls1028a,ls1088a,ls208xa > > Signed-off-by: Biwen Li You missed your Signed-off-by tag. What about adding a Fixes tag?

Re: [PATCH 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present

2020-09-24 Thread Fabio Estevam
Hi Alexandre, On Thu, Sep 24, 2020 at 5:16 PM Alexandru Gagniuc wrote: > + ret = regulator_enable(sii902x->cvcc12); > + if (ret < 0) { > + dev_err(dev, "Failed to enable cvcc12 supply: %d\n", ret); > + regulator_disable(sii902x->iovcc); > + r

Re: [PATCH v3 16/16] ARM: Remove custom IRQ stat accounting

2020-09-24 Thread Fabio Estevam
Hi Guillaume, On Thu, Sep 24, 2020 at 6:01 AM Guillaume Tucker wrote: > This appears to be causing a NULL pointer dereference on > beaglebone-black, it got bisected automatically several times. > None of the other platforms in the KernelCI labs appears to be > affected. Actually imx53-qsb is al

Re: [PATCH V2 0/4] imx: support i.MX7ULP HSRUN mode

2020-09-22 Thread Fabio Estevam
Hi Peng, On Tue, Sep 15, 2020 at 11:55 PM wrote: > > From: Peng Fan > > V2: > Update to use pmc0/pmc1 following hardware naming > > This patchset is to add HSRUN mode support. > Patch 1,2 is to add binding doc and dts node > Patch 3 is to support HSRUN mode > Patch 4 is to use wait mode when HS

Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel

2020-09-21 Thread Fabio Estevam
Hi Guido, On Mon, Sep 21, 2020 at 1:56 PM Guido Günther wrote: > > We need to reset both for the panel to show an image. There is a typo in "resets" in the Subject line.

Re: [PATCH v2 0/3] ASoC: fsl_sai: update the register list

2020-09-17 Thread Fabio Estevam
oC: fsl_sai: Set MCLK input or output direction > > changes in v2: > - update commit message for first commit > - Add acked-by Nicolin For the whole series: Reviewed-by: Fabio Estevam

Re: [PATCH 1/3] ASoC: fsl_sai: Add new added registers and new bit definition

2020-09-16 Thread Fabio Estevam
Hi Shengjiu, On Wed, Sep 16, 2020 at 7:23 AM Shengjiu Wang wrote: > > On i.MX850/i.MX815/i.MX845 platform, the sai IP is upgraded. Please avoid such internal SoC namings and use i.MX8MQ/i.MX8MN/iMX8MM instead.

Re: [PATCH 0/3] ASoC: fsl_sai: update the register list

2020-09-16 Thread Fabio Estevam
On Wed, Sep 16, 2020 at 8:47 AM Fabio Estevam wrote: > > Knob kmg Please ignore. It seems my cellphone wanted to write something.

Re: [PATCH -next] clk: imx35: Make mx35_clocks_init static

2020-09-15 Thread Fabio Estevam
Hi YueHaibing, On Tue, Sep 15, 2020 at 11:02 AM YueHaibing wrote: > > Fix sparse warning: > > drivers/clk/imx/clk-imx35.c:251:12: warning: > symbol 'mx35_clocks_init' was not declared. Should it be static? This is not the correct fix. mx35_clocks_init() was only used by imx35 board files. Now

Re: [PATCH 3/3] clk: imx31: Make mx31_clocks_init static

2020-09-15 Thread Fabio Estevam
On Tue, Sep 15, 2020 at 11:02 AM YueHaibing wrote: > > Fix sparse warning: > > drivers/clk/imx/clk-imx31.c:135:12: warning: > symbol 'mx31_clocks_init' was not declared. Should it be static? Same as the other comment for mx35, This function should be removed. I will send a patch removing it.

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4

2020-09-13 Thread Fabio Estevam
Hi Matthias, On Mon, Sep 7, 2020 at 4:40 AM Matthias Schiffer wrote: > My rationale here is the following: As broken as the native CS of these > controllers is, it isn't an unreasonable assumption that it is working > fine with *some* devices or for some usecases - after all the support > was im

Re: [PATCH] i2c: mxs: use MXS_DMA_CTRL_WAIT4END instead of DMA_CTRL_ACK

2020-09-11 Thread Fabio Estevam
g, completely breaking I2C > transactions using DMA. > > Fixes: ceeeb99cd821 ("dmaengine: mxs: rename custom flag") > Signed-off-by: Matthias Schiffer Thanks for the fix: Reviewed-by: Fabio Estevam

Re: [PATCH v2] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Fabio Estevam
Hi Stefan, On Tue, Sep 8, 2020 at 9:56 AM Stefan Agner wrote: > > The lcdif IP does not support a framebuffer pitch (stride) other than > framebuffer width. Check for equality and reject the framebuffer > otherwise. > > This prevents a distorted picture when using 640x800 and running the > Mesa g

Re: (EXT) Re: (EXT) Re: [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4

2020-09-04 Thread Fabio Estevam
Hi Mark, On Fri, Sep 4, 2020 at 12:05 PM Mark Brown wrote: > > On Fri, Sep 04, 2020 at 04:34:43PM +0200, Matthias Schiffer wrote: > > > Nevertheless, I don't see why we should deliberately remove the native > > CS support - my understanding was that we try to avoid breaking changes > > to DT inte

Re: (EXT) Re: [PATCH] spi-imx: remove num-cs support, set num_chipselect to 4

2020-09-04 Thread Fabio Estevam
On Fri, Sep 4, 2020 at 10:02 AM Matthias Schiffer wrote: > This would make num_chipselect default to 1 again (set by > __spi_alloc_controller()), breaking every i.MX board that uses more > than 1 native CS. Which boards are that? Are you referring to non-DT i.MX boards? If so, I have sent a pat

  1   2   3   4   5   6   7   8   9   10   >