Re: omap5: dwc3 interface status in /sys

2018-10-18 Thread Felipe Balbi
Hi, On Tue, Oct 16, 2018 at 1:27 PM Roger Quadros wrote: > > Felipe, > > On 16/10/2018 12:29, H. Nikolaus Schaller wrote: > > Hi, > > > >> Am 17.09.2018 um 10:24 schrieb H. Nikolaus Schaller : > >> > >> Hi Felipe, > >> I have made otg mode work on the omap5-uevm with help from Roger > >> and now

Re: [PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-05-15 Thread Felipe Balbi
Krzysztof Kozlowski writes: > On Tue, May 15, 2018 at 2:12 PM, Andrzej Hajda wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete >> extcon property can

Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-05-15 Thread Felipe Balbi
onvert the percpu_ida users to the sbitmap API. > > Signed-off-by: Matthew Wilcox <mawil...@microsoft.com> > --- [...] > drivers/usb/gadget/function/f_tcm.c | 8 +++--- for drivers/usb/gadget/function/f_tcm.c Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

2018-05-15 Thread Felipe Balbi
Andrzej Hajda writes: > extcon device is used to detect host/device connection. Since extcon > OF property is deprecated, alternative method should be added. > This method uses OF graph bindings to locate extcon. > > Signed-off-by: Andrzej Hajda > --- >

Re: [PATCH] usb: gadget: composite: fill bcdUSB as 0x0320 for SuperSpeed or higher speeds

2018-05-15 Thread Felipe Balbi
Hi, Chunfeng Yun <chunfeng@mediatek.com> writes: > On Wed, 2018-05-09 at 14:33 +0300, Felipe Balbi wrote: >> Hi, >> >> Chunfeng Yun <chunfeng@mediatek.com> writes: >> > The USB3CV version 2.1.80 (March 26, 2018) requires all devices >> &

Re: [PATCH] usb: gadget: composite: fill bcdUSB as 0x0320 for SuperSpeed or higher speeds

2018-05-09 Thread Felipe Balbi
Hi, Chunfeng Yun writes: > The USB3CV version 2.1.80 (March 26, 2018) requires all devices > ( gen1, gen2, single lane, dual lane) to return the value of 0x0320 > in the bcdUSB field this sounds really odd. What happens when I get a USB 3.1 compliant device

Re: [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

2018-04-25 Thread Felipe Balbi
Romain Izard writes: > When converting to GPIO descriptors, gpiod_get_value automatically > handles the line inversion flags from the device tree. > > Do not invert the line twice. > > Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870 your fixes line is incorrect.

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-04-10 Thread Felipe Balbi
Hi, Minas Harutyunyan writes: >>> Actually to fix this issue I updated condition of wait function >>> from: >>> !(dep->flags & DWC3_EP_END_TRANSFER_PENDING) >>> to: >>> !(dep->flags & DWC3_EP_END_TRANSFER_PENDING & DWC3_EP_ENABLED) >>

Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-04 Thread Felipe Balbi
Hi, Masahiro Yamada writes: >>> Each DWC3 instance is connected with >>> multiple HS PHYs and multiple SS PHYs, >>> depending on the number of ports. >> >> in that case, you shouldn't need dwc3 at all. A Host-only dwc3 is xHCI >> compliant. If you really don't

Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-04 Thread Felipe Balbi
Hi, Masahiro Yamada <yamada.masah...@socionext.com> writes: > 2018-04-04 14:36 GMT+09:00 Felipe Balbi <felipe.ba...@linux.intel.com>: >> >> Hi, >> >> Masahiro Yamada <yamada.masah...@socionext.com> writes: >>> Currently, DWC3 core IP (driv

Re: Multiple generic PHY instances for DWC3 USB IP

2018-04-03 Thread Felipe Balbi
Hi, Masahiro Yamada writes: > Currently, DWC3 core IP (drivers/usb/dwc3/core.c) > can take only one PHY phandle for each of SS, HS. > (phy-names DT property is "usb2-phy" and "usb3-phy" for each) We never had any other requirements :-) > The DWC3 core IP is

RE: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

2018-03-23 Thread Felipe Balbi
(please configure your email client to break lines at 80 columns ;-) Hi, Anurag Kumar Vulisha writes: > Hi Felipe, > > Thanks for reviewing the patch , please find my comments inline no issues :-) >>Anurag Kumar Vulisha writes: >>> This

Re: linux-next: Tree for Mar 21 (usb/dwc3)

2018-03-22 Thread Felipe Balbi
Hi, Randy Dunlap writes: > On 03/21/2018 01:25 AM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20180320: >> > > > on i386: > > ERROR: "__tracepoint_dwc3_gadget_generic_cmd" [drivers/usb/dwc3/dwc3.ko] > undefined! > ERROR: "__tracepoint_dwc3_ep_queue"

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-19 Thread Felipe Balbi
Hi, Minas Harutyunyan writes: >> Thanks for picking this for -next. >> Is it better to have this in v4.16-rc fixes? >> and also stable? v4.12+ > > Well, there was no "Fixes: foobar" or "Cc: stable" lines in the commit > log ;-) > >

Re: [PATCH] usb: dwc3: gadget: Correct the logic for queuing sgs

2018-03-19 Thread Felipe Balbi
Hi, Anurag Kumar Vulisha writes: > This patch fixes two issues > > 1. The code logic in dwc3_prepare_one_trb() incorrectly uses the address > and length given in req packet even for scattergather lists. This patch > correct's the code to use sg->address and

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-16 Thread Felipe Balbi
Hi, Minas Harutyunyan writes: On 09/03/18 14:47, Roger Quadros wrote: > In the following test we get stuck by sleeping forever in _dwc3_set_mode() > after which dual-role switching doesn't work. > > On dra7-evm's dual-role port, > - Load

Re: [PATCH v2] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-16 Thread Felipe Balbi
Hi, Roger Quadros writes: > Hi Felipe, > > On 09/03/18 14:47, Roger Quadros wrote: >> In the following test we get stuck by sleeping forever in _dwc3_set_mode() >> after which dual-role switching doesn't work. >> >> On dra7-evm's dual-role port, >> - Load g_zero gadget driver

Re: [PATCH][usb-next] usb: dwc2: ix spelling mistake: "genereted" -> "generated"

2018-03-14 Thread Felipe Balbi
Hi, Colin King writes: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_warn warning message text. > > Signed-off-by: Colin Ian King seems like we need a patch to fix your subject ;-) I'll fix it

Re: [PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-03-14 Thread Felipe Balbi
Hi, Manu Gautam <mgau...@codeaurora.org> writes: > Hi, > > > On 3/13/2018 4:38 PM, Felipe Balbi wrote: >> Hi, >> >> +Andy >> >> Manu Gautam <mgau...@codeaurora.org> writes: >>> DWC3 controller on Qualcomm SOCs has a Qscratch wrap

Re: [PATCH v1 2/2] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-03-13 Thread Felipe Balbi
Hi, +Andy Manu Gautam writes: > DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. > Some of its uses are described below resulting in need to > have a separate glue driver instead of using dwc3-of-simple: > - It exposes register interface to override

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-09 Thread Felipe Balbi
Hi, Roger Quadros writes: >> When we set up the DWC3_DEPCMD_ENDTRANSFER command in >> dwc3_stop_active_transfer(), we can do not set DWC3_DEPCMD_CMDIOC, >> then there will no endpoint command complete interrupts I think. >> >> cmd |= DWC3_DEPCMD_CMDIOC; >

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-09 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> This is what the v3.10 databook says >>> >>> "When issuing an End Transfer command, software must set the CmdIOC >>> bit (field 8) so that an Endpoint Command Complete event is generated >>> after the transfer ends. This is necessary to synchronize

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-09 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> When we set up the DWC3_DEPCMD_ENDTRANSFER command in >>> dwc3_stop_active_transfer(), we can do not set DWC3_DEPCMD_CMDIOC, >>> then there will no endpoint command complete interrupts I think. >>> >>> cmd |= DWC3_DEPCMD_CMDIOC; >> >> I remember

Re: [PATCH] usb: dwc2: Print error if unable to set DMA coherent mask

2018-03-09 Thread Felipe Balbi
Stefan Wahren writes: >> Stefan Wahren hat am 12. Februar 2018 um 21:20 >> geschrieben: >> >> >> We better print an error in case probing of dwc2 fails on >> setting the DMA coherent mask. >> >> Signed-off-by: Stefan Wahren

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

2018-03-09 Thread Felipe Balbi
Hi, Masahiro Yamada writes: > +static void dwc3u_reset_init(struct dwc3u_priv *priv) > +{ > + dwc3u_maskwrite(priv, RESET_CTL, LINK_RESET, 0); > + usleep_range(1000, 2000); > + dwc3u_maskwrite(priv, RESET_CTL, LINK_RESET, LINK_RESET);

Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core

2018-03-09 Thread Felipe Balbi
Hi, Roger Quadros <rog...@ti.com> writes: > Hi, > > On 08/03/18 18:49, Brian Norris wrote: >> Hi, >> >> On Thu, Mar 08, 2018 at 12:43:40PM +0200, Felipe Balbi wrote: >>> William Wu <william...@rock-chips.com> writes: >>>>

Re: [PATCH v2 2/2] usb: dwc3: add dual role support using OTG block

2018-03-08 Thread Felipe Balbi
Hi, Roger Quadros <rog...@ti.com> writes: > Felipe, > > On 08/03/18 12:39, Felipe Balbi wrote: >> Roger Quadros <rog...@ti.com> writes: >> >>> This is useful on platforms (e.g. TI AM437x) that don't >>> have ID available on a GPIO but do hav

Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core

2018-03-08 Thread Felipe Balbi
Hi Roger, William Wu writes: > The dwc3_core_init() gets the PHYs and initializes the PHYs with > the usb_phy_init() and phy_init() functions before initializing > core, and power on the PHYs after core initialization is done. > > However, some platforms (e.g.

Re: [PATCH v2 2/2] usb: dwc3: add dual role support using OTG block

2018-03-08 Thread Felipe Balbi
Roger Quadros writes: > This is useful on platforms (e.g. TI AM437x) that don't > have ID available on a GPIO but do have the OTG block. > > We can obtain the ID state via the OTG block and use it > for dual-role switching. > > Signed-off-by: Roger Quadros patch

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Baolin Wang writes: > void dwc3_gadget_exit(struct dwc3 *dwc) > { > + int epnum; > + unsigned long flags; > + > + spin_lock_irqsave(>lock, flags); > + for (epnum = 2; epnum < DWC3_ENDPOINTS_NUM; epnum++) {

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Roger Quadros <rog...@ti.com> writes: > On 05/03/18 13:06, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang <baolin.w...@linaro.org> writes: >>>>> Roger Quadros <rog...@ti.com> writes: >>>>>>> Roger Quadro

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> Roger Quadros writes: > Roger Quadros writes: >> In the following test we get stuck by sleeping forever in >> _dwc3_set_mode() >> after which dual-role switching doesn't work. >> >> On

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-03-05 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: >>> In the following test we get stuck by sleeping forever in _dwc3_set_mode() >>> after which dual-role switching doesn't work. >>> >>> On dra7-evm's dual-role port, >>> - Load g_zero gadget driver and enumerate

Re: HRTimer causing rtctest to fail

2018-02-28 Thread Felipe Balbi
Hi, Thomas Gleixner <t...@linutronix.de> writes: > On Wed, 28 Feb 2018, Felipe Balbi wrote: >> Thomas Gleixner <t...@linutronix.de> writes: >> > All numbers in micro seconds! What happens if you load the system or >> > restrict C-States? >> >>

Re: HRTimer causing rtctest to fail

2018-02-28 Thread Felipe Balbi
Thomas Gleixner <t...@linutronix.de> writes: > On Wed, 28 Feb 2018, Felipe Balbi wrote: >> Thomas Gleixner <t...@linutronix.de> writes: >> > Enable the hrtimer and scheduling tracepoints. That should give you a hint >> > what's going on. >> >> T

Re: HRTimer causing rtctest to fail

2018-02-28 Thread Felipe Balbi
Hi, Thomas Gleixner <t...@linutronix.de> writes: > On Tue, 27 Feb 2018, Felipe Balbi wrote: >> I'm facing an odd problem with v4.16-rc2 (also reproducible on v4.15 >> final) where rtctest fails sometimes which PIE coming too late with >> frequencies >= 1024 Hz.

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

2018-02-27 Thread Felipe Balbi
Hi, Roger Quadros writes: > In the following test we get stuck by sleeping forever in _dwc3_set_mode() > after which dual-role switching doesn't work. > > On dra7-evm's dual-role port, > - Load g_zero gadget driver and enumerate to host > - suspend to mem > - disconnect USB cable

HRTimer causing rtctest to fail

2018-02-27 Thread Felipe Balbi
Hi folks, I'm facing an odd problem with v4.16-rc2 (also reproducible on v4.15 final) where rtctest fails sometimes which PIE coming too late with frequencies >= 1024 Hz. I've modified rtctest.c a bit so that it continues running even after first failure just so I could get a glimpse of how

Re: [PATCH v2] usb: host: ehci-platform: add support for optional external vbus supply

2018-02-20 Thread Felipe Balbi
Hi, Amelie Delaunay writes: > On some boards, especially when vbus supply requires large current, > and the charge pump on the PHY isn't enough, an external vbus power switch > may be used. > Add support for this optional external vbus supply in ehci-platform. > >

Re: [PATCH v2] usb: core: introduce per-port over-current counters

2018-02-20 Thread Felipe Balbi
Hi, Richard Leitner writes: > From: Richard Leitner > > For some userspace applications information on the number of > over-current conditions at specific USB hub ports is relevant. > > In our case we have a series of USB hardware (using the cp210x

Re: [PATCH] usb: core: introduce per-port over-current counters

2018-02-19 Thread Felipe Balbi
Hi, Richard Leitner writes: > From: Richard Leitner > > For some userspace applications information on the number of > over-current conditions at specific USB hub ports is relevant. Therefore > introduce a oc_counter in the usb port struct which

Re: [PATCH/RFC 6/6] Treewide: Remove depends on HAS_DMA in case of platform dependency

2018-02-15 Thread Felipe Balbi
ncy on HAS_DMA, as they are selected from > SND_SOC_APQ8016_SBC. > > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> for drivers/usb/gadget/: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH/RFC 3/6] usb: gadget: Add NO_DMA dummies for DMA mapping API

2018-02-15 Thread Felipe Balbi
-by: Geert Uytterhoeven <ge...@linux-m68k.org> Should I take this or is it going with the rest of the series? If you wanna take it through Trivial or something like that: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume

2018-02-12 Thread Felipe Balbi
Hi, Roger Quadros writes: > Adding/removing host/gadget controller before .pm_complete() > causes a lock-up. Let's prevent any dual-role state change > between .pm_prepare() and .pm_complete() to fix this. > > Signed-off-by: Roger Quadros > --- >

Re: [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup

2018-02-12 Thread Felipe Balbi
Hi, Christophe JAILLET writes: > This serie aims to fix 2 issues. (path 2 & 4) > > The 2nd patch fixes a memory leak. It uses devm_ function a simplify the > handling of the memory. > > The 4th patch fixes a potential invalid pointer dereference. > > The 2 other

Re: [PATCH v2] usb: dwc3: core: Fix ULPI PHYs and prevent phy_get/ulpi_init during suspend/resume

2018-02-12 Thread Felipe Balbi
Roger Quadros writes: > In order for ULPI PHYs to work, dwc3_phy_setup() and dwc3_ulpi_init() > must be doene before dwc3_core_get_phy(). > > commit 541768b08a40 ("usb: dwc3: core: Call dwc3_core_get_phy() before > initializing phys") > broke this. > > The other issue is that

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

2018-01-24 Thread Felipe Balbi
Hi, Kunihiko Hayashi writes: > Hello Felipe, > > Thank you for your comments. > > On Tue, 23 Jan 2018 15:12:36 +0200 wrote: > >> >> Hi, >> >> Kunihiko Hayashi writes: >> > Add a specific glue layer for

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

2018-01-23 Thread Felipe Balbi
Hi, Kunihiko Hayashi writes: > Add a specific glue layer for UniPhier SoC platform to support > USB host mode. It manages hardware operating sequences to enable multiple > clock gates and assert resets, and to prepare to use dwc3 controller > on the SoC. > > This

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

2018-01-11 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: >> -ret = dwc3_core_soft_reset(dwc); >> +ret = dwc3_core_get_phy(dwc); > > we can get_phy in dwc3_core_init() as it will get called on resume(). > This was the $subject of this

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2018-01-11 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> In host mode runtime suspend/resume could happen very often with >>> device connected, and resetting h/w on every runtime_resume might not >>> be desired. And PHYs drivers can also support runtime_suspend which >>> would be preferred instead of

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2018-01-11 Thread Felipe Balbi
Hi, Manu Gautam writes: On 27/09/17 14:19, Manu Gautam wrote: > Driver powers-off PHYs and reinitializes DWC3 core and gadget on > resume. While this works fine for gadget mode but in host > mode there is not re-initialization of host stack. Also,

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

2018-01-11 Thread Felipe Balbi
Hi, Roger Quadros writes: - ret = dwc3_core_soft_reset(dwc); + ret = dwc3_core_get_phy(dwc); >>> >>> we can get_phy in dwc3_core_init() as it will get called on resume(). >>> This was the $subject of this patch. >> >> indeed. thanks :-) >> > > oops sorry. I meant we

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2018-01-11 Thread Felipe Balbi
Hi, Manu Gautam writes: >> On 27/09/17 14:19, Manu Gautam wrote: >>> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >>> resume. While this works fine for gadget mode but in host >>> mode there is not re-initialization of host stack. Also, resetting >>>

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

2018-01-10 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: >>> Felipe, >>> >>> On 10/01/18 15:11, Roger Quadros wrote: The USB PHYs should be requested only once during the life cycle of this driver. As dwc3_core_init() is called during system

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

2018-01-10 Thread Felipe Balbi
Hi, Roger Quadros writes: > Felipe, > > On 10/01/18 15:11, Roger Quadros wrote: >> The USB PHYs should be requested only once during the life cycle of >> this driver. >> >> As dwc3_core_init() is called during system suspend/resume >> it will result in multiple calls to

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2018-01-10 Thread Felipe Balbi
Hi, Roger Quadros writes: > Hi Manu, > > On 27/09/17 14:19, Manu Gautam wrote: >> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >> resume. While this works fine for gadget mode but in host >> mode there is not re-initialization of host stack. Also, resetting >>

Re: [usb_add_gadget_udc_release] BUG: KASAN: double-free or invalid-free in (null)

2018-01-09 Thread Felipe Balbi
e7: >> slab_free at mm/slub.c:2973 >> (inlined by) kfree at >> mm/slub.c:3899 >> [ 38.605034] usb_add_gadget_udc_release+0x693/0x6ca: >>

Re: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

2018-01-08 Thread Felipe Balbi
QUESTS 8 if you want to be taken seriously, the bare minimum you can do is to use scripts/get_maintainer.pl to help with a proper Cc list: $ scripts/get_maintainer.pl -f drivers/usb/gadget/function/uvc.h Laurent Pinchart <laurent.pinch...@ideasonboard.com> (maintainer:USB WEBCAM GA

Re: [PATCH] usb: dwc3: gadget: decrease the queued_requests in removal

2018-01-08 Thread Felipe Balbi
Hi, Lipengcheng writes: > In removal requests, it is necessary to make the corresponding trb > disable state (HWO = 1) and dep->queued_requests a corresponding reduction. > It is better to use a alone funtion to disable trb (HWO = 0). this shouldn't be necessary. What

RE: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

2018-01-08 Thread Felipe Balbi
Hi, Lipengcheng writes: >> Lipengcheng writes: >> >> > Iso transmission, the current process is that all trb(HWO=1) is handled. >> > Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin >> > refill trb, this will produce 0 length

Re: [PATCH] usb:dwc3:fix access poisoned list_head in dwc3_gadget_giveback

2018-01-08 Thread Felipe Balbi
Hi, Yu Chen writes: > From: Yu Chen > > Unable to handle kernel paging request at virtual address dead0108 > pgd = fff7a3179000 > [dead0108] *pgd=230e0003, *pud=230e0003, > *pmd= > Internal error:

Re: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

2017-12-21 Thread Felipe Balbi
Hi, Lipengcheng writes: > Iso transmission, the current process is that all trb(HWO=1) is handled. > Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin refill > trb, this will produce 0 length package, the patch is to achieve the core > consumes a trb, and

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-20 Thread Felipe Balbi
Hi, Joe Perches <j...@perches.com> writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: linux-next: Tree for Dec 14 (usb/dwc3)

2017-12-15 Thread Felipe Balbi
Hi, Randy Dunlap writes: > On 12/13/2017 11:06 PM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20171213: >> > > on i386: > > ERROR: "__tracepoint_dwc3_writel" [drivers/usb/dwc3/dwc3.ko] undefined! > ERROR: "__tracepoint_dwc3_readl" [drivers/usb/dwc3/dwc3.ko]

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-12 Thread Felipe Balbi
Hi, Douglas Anderson writes: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating points (like > 100 MHz / 200 MHz). > >

RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

2017-12-11 Thread Felipe Balbi
Hi, (please break your lines at 80-characters) Yinbo Zhu writes: >>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index >>> 5cb3f6795b0b..071e7cea8cbb 100644 >>> --- a/drivers/usb/dwc3/core.c >>> +++ b/drivers/usb/dwc3/core.c >>> @@ -1106,6 +1106,9 @@

Re: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

2017-12-08 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: > On Fri, Dec 08, 2017 at 05:49:41PM +0800, yinbo@nxp.com wrote: >> From: "yinbo.zhu" >> >> Description: This is a occasional problem where the software > > No need for a "Description:" word. That's just

Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

2017-12-08 Thread Felipe Balbi
26:59 +0800 >> > Chunyan Zhang <zhang.chun...@linaro.org> wrote: >> > >> > > On 17 May 2017 at 16:05, Felipe Balbi <felipe.ba...@linux.intel.com> >> > > wrote: >> > > > That way, users don't need to keep a global static pointe

Re: [PATCH v3 35/36] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2017-12-04 Thread Felipe Balbi
as hrtimer mode. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de> > Cc: Felipe Balbi <ba...@kernel.org> > Cc: linux-...@vger.kernel.org This doesn't compile, so I'm assuming it depends on previ

Re: [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

2017-12-04 Thread Felipe Balbi
44: dwc3_event: event (0901): > Erratic Error [U0] > > Signed-off-by: Roger Quadros <rog...@ti.com> FWIW: Acked-by: Felipe Balbi <felipe.balbi@linux/intel.com> I'm taking the dwc3 counterpart to v4.16 -- balbi signature.asc Description: PGP signature

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-12-04 Thread Felipe Balbi
Hi, Ruslan Bilovol writes: > On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol > wrote: >> Hi, >> >> This patch adds USB Audio Device Class 3.0 [1] function >> support to gadget subsystem. >> I didn't add UAC3 support to legacy gadget as it

Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer

2017-11-28 Thread Felipe Balbi
Hi, Lu Baolu writes: > The kernel FIFO implementation, kfifo, provides interfaces to manipulate > a first-in-first-out circular buffer. Use kfifo instead of the homemade > one to make the code more concise and readable. > > Signed-off-by: Lu Baolu

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-27 Thread Felipe Balbi
Hi, John Keeping <j...@metanate.com> writes: > On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: >> Good point. Then how about we just force the value to 1 in f_fs.c and >> remove the check? > > That seems reasonable. Something like this? > > -- >8 --

RE: [PATCH] usb: dwc3: Enable the USB snooping

2017-11-15 Thread Felipe Balbi
Hi, Ran Wang writes: >> Ran Wang writes: >> > Add support for USB3 snooping by asserting bits in register >> > DWC3_GSBUSCFG0 for data and descriptor. >> >> we know *how* to enable a feature :-) It's always the same, you fiddle with >> some registers

Re: [PATCH] usb: dwc3: Enable the USB snooping

2017-11-15 Thread Felipe Balbi
Hi, Ran Wang writes: > Add support for USB3 snooping by asserting bits > in register DWC3_GSBUSCFG0 for data and descriptor. we know *how* to enable a feature :-) It's always the same, you fiddle with some registers and it works. What you failed to tell us is: a) WHY do

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-13 Thread Felipe Balbi
Hi, Mathias Nyman writes: >> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >> +{ >> +db->buf_buf = kzalloc(size, GFP_KERNEL); >> +if (!db->buf_buf) >> +return -ENOMEM; >> + >> +db->buf_size = size; >> +db->buf_put =

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-13 Thread Felipe Balbi
Hi, John Keeping <j...@metanate.com> writes: > On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote: > >> John Keeping <j...@metanate.com> writes: >> > This check has gone through several incompatible variations in commits >> > 53642399aa71 ("

Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface

2017-11-10 Thread Felipe Balbi
Hi, abhij...@vger.kernel.org, ku...@vger.kernel.org writes: these emails don't exist. Fix your email client. > From: abhijeet kumar capitalize names > Runtime resume USB device in order to ensure that PM framework > knows that the we might be using the device in a

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-10 Thread Felipe Balbi
Hi, John Keeping writes: > This check has gone through several incompatible variations in commits > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of > OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix ExtCompat > descriptor validation") and

Re: [PATCH] usb: gadget: f_fs: Fix use-after-free in ffs_free_inst

2017-11-09 Thread Felipe Balbi
t; Cc: sta...@vger.kernel.org >> Signed-off-by: Andrew Gabbasov <andrew_gabba...@mentor.com> >> --- >> drivers/usb/gadget/function/f_fs.c | 1 + >> 1 file changed, 1 insertion(+) > > Felipe, want me to take this directly? If you can still squeeze it into the merge window, sure: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> Thanks -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 3/3] usb: dwc3: Enable USB 3.0 phy driver

2017-11-07 Thread Felipe Balbi
Hi, Ran Wang writes: > Adds entry point at dwc3 core init function to enable > USB 3.0 PHY driver. > > Signed-off-by: Ran Wang > --- > Change in v2: > - New file > > drivers/usb/dwc3/core.c | 15 +++ > 1 file changed, 15 insertions(+)

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-03 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> > >> Greg Kroah-Hartman writes: >> >>> > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 >> >>> > >> >> > controllers) >> >>> > >> >> > can be implemented with the

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-03 Thread Felipe Balbi
s Gleixner <t...@linutronix.de> > Cc: Kate Stewart <kstew...@linuxfoundation.org> > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: mtu3: fix dma_addr_t printk output again

2017-11-02 Thread Felipe Balbi
> > Fixes: 1a46dfea0841 ("usb: mtu3: support 36-bit DMA address") > Signed-off-by: Arnd Bergmann <a...@arndb.de> oh, so it wants a pointer afterall :-) sorry. Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-02 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> Greg Kroah-Hartman writes: >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> >> > can be implemented with the Debug Capability(DbC). It presents a debug >> >> > device

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-02 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> > can be implemented with the Debug Capability(DbC). It presents a debug >> > device which is fully compliant with the USB framework and provides the >> >

Re: [PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

2017-10-31 Thread Felipe Balbi
Roger Quadros writes: > UDC core calls .udc_set_speed() with the speed parameter > containing the maximum speed supported by the gadget function > driver. This might very well be more or less than that > supported by the dwc3 controller driver. > > Select the lesser of the 2

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-31 Thread Felipe Balbi
Doug Anderson <diand...@chromium.org> writes: > Hi, > > On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <ba...@kernel.org> wrote: >> >> Hi, >> >> Doug Anderson <diand...@chromium.org> writes: >>> Hi, >>> >>> On Sat, Oct 2

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-30 Thread Felipe Balbi
Hi, Doug Anderson writes: > Hi, > > On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren wrote: >> Hi Doug, >> >> [add Felipe since this should go through his tree] > > Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past No problems

Re: [PATCH] usb: gadget: composite: mark expected switch fall-throughs

2017-10-26 Thread Felipe Balbi
"Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Felipe B

Re: [PATCH] usb: gadget: udc: dummy_hcd: mark expected switch fall-throughs

2017-10-26 Thread Felipe Balbi
"Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Felipe B

Re: [PATCH 3/3] usb: phy: remove phy-qcom-8x16-usb.c

2017-10-26 Thread Felipe Balbi
Alex Elder writes: > No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver > support any more, so remove the code. > > Suggested-by: Stephen Boyd > Signed-off-by: Alex Elder > Acked-by: Bjorn Andersson

Re: [PATCH] usb: gadget: f_phonet: mark expected switch fall-throughs

2017-10-25 Thread Felipe Balbi
off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Greg, I have already sent you my pull request. If you want, I can prepare a part 2, otherwise: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: gadget: zero: Convert timers to use timer_setup()

2017-10-24 Thread Felipe Balbi
h the timer global. > > Cc: Felipe Balbi <ba...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: linux-...@vger.kernel.org > Signed-off-by: Kees Cook <keesc...@chromium.org> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: usbtest: Convert timers to use timer_setup()

2017-10-24 Thread Felipe Balbi
roy_timer_on_stack(); > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Felipe Balbi <felipe.ba...@linux.intel.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: "Gustavo A. R. Silva" <garsi...@embeddedor.com> > Cc: linux-...@vger.kernel.or

Re: [PATCH 25/25] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2017-10-24 Thread Felipe Balbi
as hrtimer base. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de> > Cc: Felipe Balbi <ba...@kernel.org> > Cc: linux-...@vger.kernel.org Acked-by: Felipe Balbi <felipe.ba...@linus.intel.com> -- balbi signature.asc Description: PGP signature

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-10-24 Thread Felipe Balbi
Hi, Manu Gautam writes: > Hi Felipe, > > Let me know if patches in this series look fine to you. It does, I just don't have means to test this as intel's platform doesn't give SW access to PHYs. I was hoping someone from TI would give a tested-by, but it's too late.

Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

2017-10-24 Thread Felipe Balbi
Hi, Yu Chen writes: > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 > Controller. > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on > board Hikey960. > > Signed-off-by: Yu Chen > Signed-off-by:

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Felipe Balbi
Hi, Philipp Zabel <p.za...@pengutronix.de> writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel <p.za...@pengutronix.de> writes: >> >> > From: Vivek Gautam <vivek.gau...@codeaurora.org> >>

Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-10-19 Thread Felipe Balbi
Hi, Philipp Zabel <p.za...@pengutronix.de> writes: > Hi Felipe, > > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote: >> Philipp Zabel <p.za...@pengutronix.de> writes: >> >> > From: Vivek Gautam <vivek.gau...@codeaurora.org> >>

  1   2   3   4   5   6   7   8   9   10   >