[PATCH] Fix detectition of kernel git repository in setlocalversion script [take #2]

2013-12-02 Thread Franck Bui-Huu
. This patch just fixes this by using 'git rev-parse --show-cdup' to check that the current directory is the kernel git topdir. This has the advantage to not test and rely on git internal infrastructure directly. Signed-off-by: Franck Bui-Huu --- scripts/setlocalversion | 3 ++- 1 file changed, 2

Re: [PATCH] Fix detectition of kernel git repository in setlocalversion script

2013-12-02 Thread Franck Bui-Huu
On 12/02/2013 04:16 PM, Michal Marek wrote: > On 2.12.2013 16:14, Franck Bui-Huu wrote: >> On 12/02/2013 03:57 PM, Michal Marek wrote: >>> On 2.12.2013 14:21, Franck Bui-Huu wrote: >>>> diff --git a/scripts/setlocalversion b/scripts/setlocalversion >

Re: [PATCH] Fix detectition of kernel git repository in setlocalversion script

2013-12-02 Thread Franck Bui-Huu
On 12/02/2013 03:57 PM, Michal Marek wrote: > On 2.12.2013 14:21, Franck Bui-Huu wrote: >> diff --git a/scripts/setlocalversion b/scripts/setlocalversion >> index 0b5ccf3..c16e65d 100755 >> --- a/scripts/setlocalversion >> +++ b/scripts/setlocalversion >> @@ -43,7

[PATCH] Fix detectition of kernel git repository in setlocalversion script

2013-12-02 Thread Franck Bui-Huu
. This patch just fixes this by using 'git rev-parse --show-cdup' to check that the current directory is the kernel git topdir. This has the advantage to not test and rely on git internal infrastructure directly. Signed-off-by: Franck Bui-Huu --- scripts/setlocalversion | 3 ++- 1 file changed, 2

[PATCH] Fix detectition of kernel git repository in setlocalversion script

2013-12-02 Thread Franck Bui-Huu
. This patch just fixes this by using 'git rev-parse --show-cdup' to check that the current directory is the kernel git topdir. This has the advantage to not test and rely on git internal infrastructure directly. Signed-off-by: Franck Bui-Huu fbui...@gmail.com --- scripts/setlocalversion | 3 ++- 1 file

Re: [PATCH] Fix detectition of kernel git repository in setlocalversion script

2013-12-02 Thread Franck Bui-Huu
On 12/02/2013 03:57 PM, Michal Marek wrote: On 2.12.2013 14:21, Franck Bui-Huu wrote: diff --git a/scripts/setlocalversion b/scripts/setlocalversion index 0b5ccf3..c16e65d 100755 --- a/scripts/setlocalversion +++ b/scripts/setlocalversion @@ -43,7 +43,8 @@ scm_version() fi

Re: [PATCH] Fix detectition of kernel git repository in setlocalversion script

2013-12-02 Thread Franck Bui-Huu
On 12/02/2013 04:16 PM, Michal Marek wrote: On 2.12.2013 16:14, Franck Bui-Huu wrote: On 12/02/2013 03:57 PM, Michal Marek wrote: On 2.12.2013 14:21, Franck Bui-Huu wrote: diff --git a/scripts/setlocalversion b/scripts/setlocalversion index 0b5ccf3..c16e65d 100755 --- a/scripts

[PATCH] Fix detectition of kernel git repository in setlocalversion script [take #2]

2013-12-02 Thread Franck Bui-Huu
. This patch just fixes this by using 'git rev-parse --show-cdup' to check that the current directory is the kernel git topdir. This has the advantage to not test and rely on git internal infrastructure directly. Signed-off-by: Franck Bui-Huu fbui...@gmail.com --- scripts/setlocalversion | 3 ++- 1 file

Re: + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree

2008-02-26 Thread Franck Bui-Huu
Hi, Josh Triplett wrote: > [I did not see this patch go by on any mailing list, so I replied to > the -mm mail and CCed LKML.] > Well I'm pretty sure to have always CC'ed LKML, see for example: http://lkml.org/lkml/2008/2/19/150 http://lkml.org/lkml/2008/2/19/151 Thanks,

Re: + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree

2008-02-26 Thread Franck Bui-Huu
Hi, Josh Triplett wrote: [I did not see this patch go by on any mailing list, so I replied to the -mm mail and CCed LKML.] Well I'm pretty sure to have always CC'ed LKML, see for example: http://lkml.org/lkml/2008/2/19/150 http://lkml.org/lkml/2008/2/19/151 Thanks,

[PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-19 Thread Franck Bui-Huu
From: Franck Bui-Huu <[EMAIL PROTECTED]> This patch moves rcu-protected lists from list.h into a new header file rculist.h. This is done because list are a very used primitive structure all over the kernel and it's currently impossible to include other header files in this list.h w

[PATCH 2/2] rculist.h: use the rcu API

2008-02-19 Thread Franck Bui-Huu
From: Franck Bui-Huu <[EMAIL PROTECTED]> This patch makes almost all list mutation primitives use rcu_assign_pointer(). The main point of this being readability improvement. Signed-off-by: Franck Bui-Huu <[EMAIL PROTECTED]> --- include/linux/rculist.h | 23 +---

[PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-19 Thread Franck Bui-Huu
From: Franck Bui-Huu [EMAIL PROTECTED] This patch moves rcu-protected lists from list.h into a new header file rculist.h. This is done because list are a very used primitive structure all over the kernel and it's currently impossible to include other header files in this list.h without creating

[PATCH 2/2] rculist.h: use the rcu API

2008-02-19 Thread Franck Bui-Huu
From: Franck Bui-Huu [EMAIL PROTECTED] This patch makes almost all list mutation primitives use rcu_assign_pointer(). The main point of this being readability improvement. Signed-off-by: Franck Bui-Huu [EMAIL PROTECTED] --- include/linux/rculist.h | 23 +-- 1 files

Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-03 Thread Franck Bui-Huu
Andrew Morton wrote: > On Sun, 03 Feb 2008 09:45:25 +0100 Franck Bui-Huu <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >>> On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu <[EMAIL PROTECTED]> wrote: >>>> Do you think it's better ? >>

Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-03 Thread Franck Bui-Huu
Andrew Morton wrote: > On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu <[EMAIL PROTECTED]> wrote: >> Do you think it's better ? > > Could. I'd suggest that you redo the header-file split patch around the > 2.6.25-rc1 timeframe, test it carefully then let's get it in th

Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-03 Thread Franck Bui-Huu
Andrew Morton wrote: On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu [EMAIL PROTECTED] wrote: Do you think it's better ? Could. I'd suggest that you redo the header-file split patch around the 2.6.25-rc1 timeframe, test it carefully then let's get it in then. Does the mm tree also have

Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-03 Thread Franck Bui-Huu
Andrew Morton wrote: On Sun, 03 Feb 2008 09:45:25 +0100 Franck Bui-Huu [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Sat, 02 Feb 2008 14:32:41 +0100 Franck Bui-Huu [EMAIL PROTECTED] wrote: Do you think it's better ? Could. I'd suggest that you redo the header-file split patch around

Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-02 Thread Franck Bui-Huu
Andrew Morton wrote: > On Thu, 17 Jan 2008 21:47:38 +0100 > Franck Bui-Huu <[EMAIL PROTECTED]> wrote: > >> This patch moves rcu-protected lists from list.h into a new header >> file rculist.h. > > I'm getting way too many compilation errors from this, perhaps

Re: [PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-02-02 Thread Franck Bui-Huu
Andrew Morton wrote: On Thu, 17 Jan 2008 21:47:38 +0100 Franck Bui-Huu [EMAIL PROTECTED] wrote: This patch moves rcu-protected lists from list.h into a new header file rculist.h. I'm getting way too many compilation errors from this, perhaps because of new rcu-list usages which weren't

[PATCH 2/2] rculist.h: use the rcu API

2008-01-17 Thread Franck Bui-Huu
From: Franck Bui-Huu <[EMAIL PROTECTED]> This patch makes almost all list mutation primitives use rcu_assign_pointer(). The main point of this being readability improvement. Signed-off-by: Franck Bui-Huu <[EMAIL PROTECTED]> --- include/linux/rculist.h | 23 +---

[PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-01-17 Thread Franck Bui-Huu
From: Franck Bui-Huu <[EMAIL PROTECTED]> This patch moves rcu-protected lists from list.h into a new header file rculist.h. This is done because list are a very used primitive structure all over the kernel and it's currently impossible to include other header files in this list.h w

[PATCH 0/2] Make RCU lists use the RCU API

2008-01-17 Thread Franck Bui-Huu
Hi, After reading the nice article contributed by Paul on LWN, I took a look to the kernel RCU-protected list implementation to get a good idea on how RCU protection mechanism can be used. And it appears that the implementation doesn't use the RCU API as much as it could: every updates of

[PATCH 2/2] rculist.h: use the rcu API

2008-01-17 Thread Franck Bui-Huu
From: Franck Bui-Huu [EMAIL PROTECTED] This patch makes almost all list mutation primitives use rcu_assign_pointer(). The main point of this being readability improvement. Signed-off-by: Franck Bui-Huu [EMAIL PROTECTED] --- include/linux/rculist.h | 23 +-- 1 files

[PATCH 0/2] Make RCU lists use the RCU API

2008-01-17 Thread Franck Bui-Huu
Hi, After reading the nice article contributed by Paul on LWN, I took a look to the kernel RCU-protected list implementation to get a good idea on how RCU protection mechanism can be used. And it appears that the implementation doesn't use the RCU API as much as it could: every updates of -next

[PATCH 1/2] Split list.h and move rcu-protected lists into rculist.h

2008-01-17 Thread Franck Bui-Huu
From: Franck Bui-Huu [EMAIL PROTECTED] This patch moves rcu-protected lists from list.h into a new header file rculist.h. This is done because list are a very used primitive structure all over the kernel and it's currently impossible to include other header files in this list.h without creating

Re: apm emulation driver broken ?

2007-11-19 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: > On Sunday, 18 of November 2007, Franck Bui-Huu wrote: >> Rafael J. Wysocki wrote: >> See the call to wait_even() made by apm_ioctl(). If any processes >> run this, it will prevent the system to suspend... > > True, but does it actually h

Re: apm emulation driver broken ?

2007-11-19 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: On Sunday, 18 of November 2007, Franck Bui-Huu wrote: Rafael J. Wysocki wrote: See the call to wait_even() made by apm_ioctl(). If any processes run this, it will prevent the system to suspend... True, but does it actually happen in practice? when several

Re: apm emulation driver broken ?

2007-11-18 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: > On Saturday, 17 of November 2007, Franck Bui-Huu wrote: >> ok so now we agreed on this point, can we assert that a user >> land thread waiting for an event in an UNINTERRUPTIBLE state >> will prevent a suspend to happen ? > > Yes. > So t

Re: apm emulation driver broken ?

2007-11-18 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: On Saturday, 17 of November 2007, Franck Bui-Huu wrote: ok so now we agreed on this point, can we assert that a user land thread waiting for an event in an UNINTERRUPTIBLE state will prevent a suspend to happen ? Yes. So this driver seems really broken

Re: apm emulation driver broken ?

2007-11-17 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: > On Saturday, 17 of November 2007, Franck Bui-Huu wrote: >> Rafael J. Wysocki wrote: >>> However, using PF_NOFREEZE to prevent this from happening doesn't seem to be >>> a good idea. >>> >> Indeed but... >> >

Re: apm emulation driver broken ?

2007-11-17 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: > However, using PF_NOFREEZE to prevent this from happening doesn't seem to be > a good idea. > Indeed but... > I'd probably use wait_event_freezable() (defined in > include/linux/freezer.h) for that. ...I would just revert this bits from now to make sure this driver

Re: apm emulation driver broken ?

2007-11-17 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: However, using PF_NOFREEZE to prevent this from happening doesn't seem to be a good idea. Indeed but... I'd probably use wait_event_freezable() (defined in include/linux/freezer.h) for that. ...I would just revert this bits from now to make sure this driver work

Re: apm emulation driver broken ?

2007-11-17 Thread Franck Bui-Huu
Rafael J. Wysocki wrote: On Saturday, 17 of November 2007, Franck Bui-Huu wrote: Rafael J. Wysocki wrote: However, using PF_NOFREEZE to prevent this from happening doesn't seem to be a good idea. Indeed but... I'd probably use wait_event_freezable() (defined in include/linux/freezer.h

Re: apm emulation driver broken ?

2007-11-16 Thread Franck Bui-Huu
On Nov 16, 2007 5:20 PM, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > The freezer doesn't regard the current task as freezable. > Hmm, I don't get your point. If I understood this driver correctly, several processes can be waiting for a suspend event by reading /dev/apm_bios, apmd (the

apm emulation driver broken ?

2007-11-16 Thread Franck Bui-Huu
Rafael, Looking at commit: 831441862956fffa17b9801db37e6ea1650b0f69 Freezer: make kernel threads nonfreezable by default it seems that you broke the apm emulation driver. You removed PF_NOFREEZE flag setting in apm_ioctl(), which is definitely not part of the apm kernel daemon

apm emulation driver broken ?

2007-11-16 Thread Franck Bui-Huu
Rafael, Looking at commit: 831441862956fffa17b9801db37e6ea1650b0f69 Freezer: make kernel threads nonfreezable by default it seems that you broke the apm emulation driver. You removed PF_NOFREEZE flag setting in apm_ioctl(), which is definitely not part of the apm kernel daemon

Re: apm emulation driver broken ?

2007-11-16 Thread Franck Bui-Huu
On Nov 16, 2007 5:20 PM, Rafael J. Wysocki [EMAIL PROTECTED] wrote: The freezer doesn't regard the current task as freezable. Hmm, I don't get your point. If I understood this driver correctly, several processes can be waiting for a suspend event by reading /dev/apm_bios, apmd (the _user_

[PATCH] Break ELF_PLATFORM and stack pointer randomization dependency

2007-09-28 Thread Franck Bui-Huu
to be useless and allows platforms such MIPS to do the randomization. Signed-off-by: Franck Bui-Huu <[EMAIL PROTECTED]> --- Andrew, I tried several times to poke people on the list to understand why this dependency exists at all, but unfortunately got no answers. So I'm subm

[PATCH] Break ELF_PLATFORM and stack pointer randomization dependency

2007-09-28 Thread Franck Bui-Huu
to be useless and allows platforms such MIPS to do the randomization. Signed-off-by: Franck Bui-Huu [EMAIL PROTECTED] --- Andrew, I tried several times to poke people on the list to understand why this dependency exists at all, but unfortunately got no answers. So I'm submitting

ELF randomization questions

2007-09-15 Thread Franck Bui-Huu
Hello, I have a couple questions about the process stack randomization but I'm not sure who should be CCed for such questions. I submitted a patch to enable 'inside the page' stack randomization on MIPS few weeks ago and which has been now committed. But I noticed that this patch is actually

ELF randomization questions

2007-09-15 Thread Franck Bui-Huu
Hello, I have a couple questions about the process stack randomization but I'm not sure who should be CCed for such questions. I submitted a patch to enable 'inside the page' stack randomization on MIPS few weeks ago and which has been now committed. But I noticed that this patch is actually

Re: [PATCH] i386 and x86_64: randomize brk()

2007-09-03 Thread Franck Bui-Huu
Hi, Jiri Kosina wrote: > > [snip] > > +/* overriden by architectures supporting brk randomization */ > > +void __weak arch_randomize_brk(struct mm_struct *mm) { } I was actually suggesting in my last email: unsigned long randomize_brk(unsigned long brk) therefore arch specific code

Re: [PATCH] i386 and x86_64: randomize brk()

2007-09-03 Thread Franck Bui-Huu
Hi, Jiri Kosina wrote: [snip] +/* overriden by architectures supporting brk randomization */ +void __weak arch_randomize_brk(struct mm_struct *mm) { } I was actually suggesting in my last email: unsigned long randomize_brk(unsigned long brk) therefore arch specific code don't

Re: [PATCH] i386 and x86_64: randomize brk()

2007-09-01 Thread Franck Bui-Huu
Hello Andrew, Andrew Morton wrote: > On Thu, 30 Aug 2007 17:10:03 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> > wrote: >> Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK >> macro instead please? >> > > Not strongly, but the general opinion seems to be that ARCH_HAS_FOO

Re: [PATCH] i386 and x86_64: randomize brk()

2007-09-01 Thread Franck Bui-Huu
Hello Andrew, Andrew Morton wrote: On Thu, 30 Aug 2007 17:10:03 +0200 (CEST) Jiri Kosina [EMAIL PROTECTED] wrote: Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK macro instead please? Not strongly, but the general opinion seems to be that ARCH_HAS_FOO is sucky.

Re: [PATCH] i386 and x86_64: randomize brk()

2007-08-30 Thread Franck Bui-Huu
Jiri Kosina wrote: > On Thu, 30 Aug 2007, Mike Frysinger wrote: > >> Blackfin too please :) i think v850 also falls into this category, but >> i'm not terribly familiar with it ... > > Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK > macro instead please? > you might

Re: arch_align_stack() seems useless

2007-08-30 Thread Franck Bui-Huu
Arjan, Franck Bui-Huu wrote: > Arjan van de Ven wrote: >> arch_align_stack aligns, on x86, within a 2 page range (this is for >> cache coloring). > > OK, but for elf case this seems useless since the top of the stack is > already randomized. > > It seems tha

Re: arch_align_stack() seems useless

2007-08-30 Thread Franck Bui-Huu
Arjan, Franck Bui-Huu wrote: Arjan van de Ven wrote: arch_align_stack aligns, on x86, within a 2 page range (this is for cache coloring). OK, but for elf case this seems useless since the top of the stack is already randomized. It seems that the randomization stuff (top of the stack

Re: [PATCH] i386 and x86_64: randomize brk()

2007-08-30 Thread Franck Bui-Huu
Jiri Kosina wrote: On Thu, 30 Aug 2007, Mike Frysinger wrote: Blackfin too please :) i think v850 also falls into this category, but i'm not terribly familiar with it ... Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK macro instead please? you might want to use

Re: arch_align_stack() seems useless

2007-08-28 Thread Franck Bui-Huu
Hello Arjan, Arjan van de Ven wrote: > arch_align_stack aligns, on x86, within a 2 page range (this is for > cache coloring). OK, but for elf case this seems useless since the top of the stack is already randomized. It seems that the randomization stuff (top of the stack + stack pointer inside

Re: arch_align_stack() seems useless

2007-08-28 Thread Franck Bui-Huu
Hello Arjan, Arjan van de Ven wrote: arch_align_stack aligns, on x86, within a 2 page range (this is for cache coloring). OK, but for elf case this seems useless since the top of the stack is already randomized. It seems that the randomization stuff (top of the stack + stack pointer inside a

arch_align_stack() seems useless

2007-08-27 Thread Franck Bui-Huu
Hello folks, I recently pick up the implementation of arch_align_stack() from x86 architectures to make it available for mips. But now I just realised that this function seems useless because of the way it's used. Currently, this function seems to be only used to randomize the stack pointer

arch_align_stack() seems useless

2007-08-27 Thread Franck Bui-Huu
Hello folks, I recently pick up the implementation of arch_align_stack() from x86 architectures to make it available for mips. But now I just realised that this function seems useless because of the way it's used. Currently, this function seems to be only used to randomize the stack pointer

Re: [2.6 patch] include/asm-mips/processor.h: "extern inline" -> "static inline"

2007-07-09 Thread Franck Bui-Huu
Hi, On 7/9/07, Ralf Baechle <[EMAIL PROTECTED]> wrote: On Sat, Jul 07, 2007 at 03:03:30AM +0200, Adrian Bunk wrote: > "extern inline" will have different semantics with gcc 4.3, > and "static inline" is correct here. The idea was to have a linker error in case gcc should deciede for some

Re: [2.6 patch] include/asm-mips/processor.h: extern inline - static inline

2007-07-09 Thread Franck Bui-Huu
Hi, On 7/9/07, Ralf Baechle [EMAIL PROTECTED] wrote: On Sat, Jul 07, 2007 at 03:03:30AM +0200, Adrian Bunk wrote: extern inline will have different semantics with gcc 4.3, and static inline is correct here. The idea was to have a linker error in case gcc should deciede for some reason not

Re: [2.6 patch] more MOMENCO_JAGUAR_ATX removal

2007-06-20 Thread Franck Bui-Huu
Hi, On 6/19/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: This patch removes the few leftovers of the MOMENCO_JAGUAR_ATX removal. thanks for catching it, Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/Kconfig|2 +- include/asm-mips/war.h |7 +++ 2 files

Re: [2.6 patch] more MOMENCO_JAGUAR_ATX removal

2007-06-20 Thread Franck Bui-Huu
Hi, On 6/19/07, Adrian Bunk [EMAIL PROTECTED] wrote: This patch removes the few leftovers of the MOMENCO_JAGUAR_ATX removal. thanks for catching it, Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/Kconfig|2 +- include/asm-mips/war.h |7 +++ 2 files changed,

Re: [patch-mm 14/25] NTP: Move the cmos update code into ntp.c

2007-06-19 Thread Franck Bui-Huu
Hi Thomas, Thomas Gleixner wrote: > i386 and sparc64 have the identical code to update the cmos clock. > Move it into kernel/time/ntp.c as there are other architectures > coming along with the same requirements. > > Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]> > Cc: Chris Wright <[EMAIL

Re: [patch-mm 14/25] NTP: Move the cmos update code into ntp.c

2007-06-19 Thread Franck Bui-Huu
Hi Thomas, Thomas Gleixner wrote: i386 and sparc64 have the identical code to update the cmos clock. Move it into kernel/time/ntp.c as there are other architectures coming along with the same requirements. Signed-off-by: Thomas Gleixner [EMAIL PROTECTED] Cc: Chris Wright [EMAIL PROTECTED]

[PATCH] Don't force frame pointers for lockdep on MIPS

2007-04-19 Thread Franck Bui-Huu
From: Franck Bui-Huu <[EMAIL PROTECTED]> Stacktrace support on MIPS doesn't use frame pointers. Since this option considerably increases the size of the kernel code, force lockdep to not use it. Signed-off-by: Franck Bui-Huu <[EMAIL PROTECTED]> --- lib/Kconfig.debug |2 +- 1 f

[PATCH] Don't force frame pointers for lockdep on MIPS

2007-04-19 Thread Franck Bui-Huu
From: Franck Bui-Huu [EMAIL PROTECTED] Stacktrace support on MIPS doesn't use frame pointers. Since this option considerably increases the size of the kernel code, force lockdep to not use it. Signed-off-by: Franck Bui-Huu [EMAIL PROTECTED] --- lib/Kconfig.debug |2 +- 1 files changed, 1

Re: revert "Fix up" of mmap_kmem

2007-01-23 Thread Franck Bui-Huu
On 1/22/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: Please revert 2.6.19's 99a10a60ba9bedcf5d70ef81414d3e03816afa3f (shown below) for 2.6.20. Nadia Derbey has reported that mmap of /dev/kmem no longer works with the kernel virtual address as offset, and Franck has confirmed that his patch came

Re: revert Fix up of mmap_kmem

2007-01-23 Thread Franck Bui-Huu
On 1/22/07, Hugh Dickins [EMAIL PROTECTED] wrote: Please revert 2.6.19's 99a10a60ba9bedcf5d70ef81414d3e03816afa3f (shown below) for 2.6.20. Nadia Derbey has reported that mmap of /dev/kmem no longer works with the kernel virtual address as offset, and Franck has confirmed that his patch came

Re: unable to mmap /dev/kmem

2007-01-20 Thread Franck Bui-Huu
On 1/19/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: Apology surely accepted, it's a confusing area (inevitably: in a driver for mem, the distinction between addresses and offsets become blurred). But please note, the worst of it was, that your patch comment gave no hint that you were knowingly

Re: unable to mmap /dev/kmem

2007-01-20 Thread Franck Bui-Huu
On 1/19/07, Hugh Dickins [EMAIL PROTECTED] wrote: Apology surely accepted, it's a confusing area (inevitably: in a driver for mem, the distinction between addresses and offsets become blurred). But please note, the worst of it was, that your patch comment gave no hint that you were knowingly

Re: unable to mmap /dev/kmem

2007-01-19 Thread Franck Bui-Huu
Hi, Hugh Dickins wrote: On Thu, 18 Jan 2007, Nadia Derbey wrote: Trying to mmap /dev/kmem with an offset I take from /boot/System.map, I get an EIO error on a 2.6.20-rc4. This is something that used to work on older kernels. Had a look at mmap_kmem() in drivers/char/mem.c, and I'm wondering

Re: unable to mmap /dev/kmem

2007-01-19 Thread Franck Bui-Huu
Hi, Hugh Dickins wrote: On Thu, 18 Jan 2007, Nadia Derbey wrote: Trying to mmap /dev/kmem with an offset I take from /boot/System.map, I get an EIO error on a 2.6.20-rc4. This is something that used to work on older kernels. Had a look at mmap_kmem() in drivers/char/mem.c, and I'm wondering

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-22 Thread Franck Bui-Huu
On 12/20/06, Franck Bui-Huu <[EMAIL PROTECTED]> wrote: - when mmaping your frame buffer , be sure that the virtual address returned by mmap() to the application shares the same cache lines than the ones the kernel is using. Well thinking more about it, this wouldn'

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-22 Thread Franck Bui-Huu
On 12/20/06, Franck Bui-Huu [EMAIL PROTECTED] wrote: - when mmaping your frame buffer , be sure that the virtual address returned by mmap() to the application shares the same cache lines than the ones the kernel is using. Well thinking more about it, this wouldn't work

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-20 Thread Franck Bui-Huu
On 12/17/06, Jaya Kumar <[EMAIL PROTECTED]> wrote: Ok. I now see what you mean. In typical cases, only one path is used to write. Meaning an app will decide to use the mmap path or the slow write path and the kernel only ever reads from its pte entry (unless fbcon is used which is not suited for

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-20 Thread Franck Bui-Huu
On 12/17/06, Jaya Kumar [EMAIL PROTECTED] wrote: Ok. I now see what you mean. In typical cases, only one path is used to write. Meaning an app will decide to use the mmap path or the slow write path and the kernel only ever reads from its pte entry (unless fbcon is used which is not suited for

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-13 Thread Franck Bui-Huu
On 12/12/06, Jaya Kumar <[EMAIL PROTECTED]> wrote: I think that PTEs set up by vmalloc are marked cacheable and via the above nopage end up as cacheable. I'm not doing DMA. So the accesses are through the cache so I don't think cache aliasing is an issue for this case. Please let me know if I

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-13 Thread Franck Bui-Huu
On 12/12/06, Jaya Kumar [EMAIL PROTECTED] wrote: I think that PTEs set up by vmalloc are marked cacheable and via the above nopage end up as cacheable. I'm not doing DMA. So the accesses are through the cache so I don't think cache aliasing is an issue for this case. Please let me know if I

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-11 Thread Franck Bui-Huu
Hi, [EMAIL PROTECTED] wrote: > Hi Geert, James, FBdev, MM folk, > > Appended is my attempt to support the Hecuba/E-Ink display. I've added > some code to do deferred IO. This is there in order to hide the latency > associated with updating the display (500ms to 800ms). The method used > is to

Re: [RFC 2.6.19 1/1] fbdev,mm: hecuba/E-Ink fbdev driver v2

2006-12-11 Thread Franck Bui-Huu
Hi, [EMAIL PROTECTED] wrote: Hi Geert, James, FBdev, MM folk, Appended is my attempt to support the Hecuba/E-Ink display. I've added some code to do deferred IO. This is there in order to hide the latency associated with updating the display (500ms to 800ms). The method used is to fake a

Re: [Linux-fbdev-devel] fbmem: is bootup logo broken for monochrome LCD ?

2006-11-17 Thread Franck Bui-Huu
On 11/17/06, James Simmons <[EMAIL PROTECTED]> wrote: Are those actually numbers? If they are the problem isn't byte reversal but bit shifting. 1010100 = 54 0101010 = 2A It's not byte reversal, but _bits_ of each bytes have been inversed (bit7->bit0, bit6->bit1, bit5->bit2, bit4->bit3,

Re: [Linux-fbdev-devel] fbmem: is bootup logo broken for monochrome LCD ?

2006-11-17 Thread Franck Bui-Huu
On 11/17/06, James Simmons [EMAIL PROTECTED] wrote: Are those actually numbers? If they are the problem isn't byte reversal but bit shifting. 1010100 = 54 0101010 = 2A It's not byte reversal, but _bits_ of each bytes have been inversed (bit7-bit0, bit6-bit1, bit5-bit2, bit4-bit3, bit3-bit4,

Re: [PATCH] bootmem.c clean up bad pfn convertions

2005-04-11 Thread Franck Bui-Huu
Dave Hansen wrote: The only arch with phys_to_pfn() defined is UML, so the patch simply won't compile anything but UML on current kernels (unless I'm missing something). oops, I forgot to send the part of the patch that defines these macros, sorry. Could you try to give us a more complete

Re: [PATCH] bootmem.c clean up bad pfn convertions

2005-04-11 Thread Franck Bui-Huu
Dave Hansen wrote: The only arch with phys_to_pfn() defined is UML, so the patch simply won't compile anything but UML on current kernels (unless I'm missing something). oops, I forgot to send the part of the patch that defines these macros, sorry. Could you try to give us a more complete

[PATCH] bootmem.c clean up bad pfn convertions

2005-04-08 Thread Franck Bui-Huu
Hi, As I described in my previous email, bootmem.c does improper pfn convertions into phys addr. This simple patch fixes that. Regards, Franck. --- This message contains confidential information and is intended only

[PATCH] bootmem.c clean up bad pfn convertions

2005-04-08 Thread Franck Bui-Huu
Hi, As I described in my previous email, bootmem.c does improper pfn convertions into phys addr. This simple patch fixes that. Regards, Franck. --- This message contains confidential information and is intended only

Re: [BOOTMEM] bad physical address convertions.

2005-04-06 Thread Franck Bui-Huu
Dave Hansen wrote: I suggest using something like discontigmem (or even sparsemem for that matter) to properly handles holes in your address space. I don't agree with you. First I don't see any advantages to use "discontigmem" just because physical ram address doesn't start to 0. I would embed

Re: [BOOTMEM] bad physical address convertions.

2005-04-06 Thread Franck Bui-Huu
Dave Hansen wrote: I suggest using something like discontigmem (or even sparsemem for that matter) to properly handles holes in your address space. I don't agree with you. First I don't see any advantages to use discontigmem just because physical ram address doesn't start to 0. I would embed

[BOOTMEM] bad physical address convertions.

2005-04-05 Thread Franck Bui-Huu
Hi, I'm porting linux on an embedded system based on MIPS proc. I've encountered several problems and one of these is related to the physical memory which doesn't start to 0. This is actually not a big issue if code that makes physical address convertions uses the appropriate macros that do the

[BOOTMEM] bad physical address convertions.

2005-04-05 Thread Franck Bui-Huu
Hi, I'm porting linux on an embedded system based on MIPS proc. I've encountered several problems and one of these is related to the physical memory which doesn't start to 0. This is actually not a big issue if code that makes physical address convertions uses the appropriate macros that do the

Re: [TTY] 2 points seems strange to me.

2005-02-18 Thread Franck Bui-Huu
Second point, a lot of serial drivers call in their interrupt handler "tty_flip_buffer_push" function. This function must no be called in interrupt context. Why is it done anyway ? Calling tty_flip_buffer_push() is fine from interrupt as long as tty->low_latency is not set. It just queues work

Re: [TTY] 2 points seems strange to me.

2005-02-18 Thread Franck Bui-Huu
Ahaa! That's how the bug got introduced. It used to be an array and then it got changed to a pointer! linux-2.4.26 also shows a local array. Yes, just looked at the revision history in linux.bkbits.net and Linus just fixed this 67 hours ago... So we're too late :) ok, maybe next time :)

[TTY] 2 points seems strange to me.

2005-02-18 Thread Franck Bui-Huu
Hi, Looking at TTY code, I noticed a weird test done in "opost_bock" located in n_tty.c file. I don't understand why the following test is done at the start of the function: if (nr > sizeof(buf)) nr = sizeof(buf); Actually it limits the size of processing blocks to 4 bytes and I can't find

[TTY] 2 points seems strange to me.

2005-02-18 Thread Franck Bui-Huu
Hi, Looking at TTY code, I noticed a weird test done in opost_bock located in n_tty.c file. I don't understand why the following test is done at the start of the function: if (nr sizeof(buf)) nr = sizeof(buf); Actually it limits the size of processing blocks to 4 bytes and I can't find a

Re: [TTY] 2 points seems strange to me.

2005-02-18 Thread Franck Bui-Huu
Ahaa! That's how the bug got introduced. It used to be an array and then it got changed to a pointer! linux-2.4.26 also shows a local array. Yes, just looked at the revision history in linux.bkbits.net and Linus just fixed this 67 hours ago... So we're too late :) ok, maybe next time :)

Re: [TTY] 2 points seems strange to me.

2005-02-18 Thread Franck Bui-Huu
Second point, a lot of serial drivers call in their interrupt handler tty_flip_buffer_push function. This function must no be called in interrupt context. Why is it done anyway ? Calling tty_flip_buffer_push() is fine from interrupt as long as tty-low_latency is not set. It just queues work for