Re: [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable

2019-03-03 Thread Gabriele Mazzotta
Hi, I applied these patches on top of 4.20. The max frequency of all the cores now reflects the actual value and it's updated whenever I change the power source. Regards, Gabriele On Fri, 1 Mar 2019 at 13:51, Rafael J. Wysocki wrote: > > Hi All, > > This is how I would fix the issue reported in

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-07 Thread Gabriele Mazzotta
On 07/08/2018 23:22, Srinivas Pandruvada wrote: > On Tue, 2018-08-07 at 22:12 +0200, Gabriele Mazzotta wrote: >> On 07/08/2018 00:11, Srinivas Pandruvada wrote: >>> On Mon, 2018-08-06 at 23:50 +0200, Gabriele Mazzotta wrote: >>>> On 06/08/2018 18:49, Srinivas Pandru

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-07 Thread Gabriele Mazzotta
On 07/08/2018 00:11, Srinivas Pandruvada wrote: > On Mon, 2018-08-06 at 23:50 +0200, Gabriele Mazzotta wrote: >> On 06/08/2018 18:49, Srinivas Pandruvada wrote: >>> On Mon, 2018-08-06 at 10:30 +0200, Rafael J. Wysocki wrote: >>>> On Sat, Aug 4, 2018 at 7:31 PM,

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-06 Thread Gabriele Mazzotta
On 06/08/2018 18:49, Srinivas Pandruvada wrote: > On Mon, 2018-08-06 at 10:30 +0200, Rafael J. Wysocki wrote: >> On Sat, Aug 4, 2018 at 7:31 PM, Gabriele Mazzotta >> wrote: >>> On 04/08/2018 17:29, Gabriele Mazzotta wrote: >>>> This change does not take

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-04 Thread Gabriele Mazzotta
On 04/08/2018 17:29, Gabriele Mazzotta wrote: > This change does not take into account that some BIOSes change > MSR_IA32_MISC_ENABLE_TURBO_DISABLE depending on the power source. > If the turbo is disabled when the system boots, policy.max_freq > is set to pstate.max_pstate. However,

[PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-04 Thread Gabriele Mazzotta
turbo is enabled. This reverts commit 983e600e88835f0321d1a0ea06f52d48b7b5a544. Signed-off-by: Gabriele Mazzotta --- drivers/cpufreq/intel_pstate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index

Re: [RFC] iio: light: acpi-als: Enable the light sensor on the Zenbook UX430UQ

2017-11-19 Thread Gabriele Mazzotta
2017-11-19 18:03 GMT+01:00 Jonathan Cameron : > On Wed, 15 Nov 2017 20:27:54 -0700 > Kiernan Hager wrote: > >> This makes acpi-als properly enable the light sensor on the Zenbook UX430UQ. >> I don't know if the checking that I do to make sure that the ACPI method >> exists is sufficient or if it

Re: keyboard backlight max_brightness bug on Dell Latitude E6410

2017-09-14 Thread Gabriele Mazzotta
2017-09-14 15:54 GMT+02:00 Pali Rohár : > Adding Gabriele to thread, IIRC you have machine which uses > "supported keyboard light brightness levels" > Can you look at this bug, if your machine is affected by it too? My keyboard has two brightness levels + off. The value of max_brightness is 2, as

Re: Crash caused by hid-rmi and no longer working touchscreen

2017-04-10 Thread Gabriele Mazzotta
Here the full log showing the errors up to the crash: Gabriele [0.00] Linux version 4.11.0-rc6 (gabriele@xps13) (gcc version 6.3.0 20170406 (Debian 6.3.0-12) ) #3 SMP Mon Apr 10 14:54:58 CEST 2017 [0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-4.11.0-rc6 root=/dev/sda6 ro quiet r

Crash caused by hid-rmi and no longer working touchscreen

2017-04-10 Thread Gabriele Mazzotta
Hi, I'm having troubles with hid-rmi using 4.11-rc6. I'm getting some "rmi_hid_read_block: timeout elapsed" errors and ultimately the crash you can see at the end of this mail. I will reply to this mail with a full log that shows all the errors. The problem seems to be caused by commit 279967a65b

Re: [PATCH] leds: Allow drivers to update the core, and generate events on changes

2016-12-27 Thread Gabriele Mazzotta
On 27/12/2016 21:07, Pavel Machek wrote: > Hi! > >> Similarily to commit 325253a6b2de ("backlight: Allow drivers to update >> the core, and generate events on changes"), inform userspace about >> brightness changes and allow drivers to request updates of the >> brightness value. > > First... we h

[PATCH] leds: Allow drivers to update the core, and generate events on changes

2016-12-27 Thread Gabriele Mazzotta
Similarily to commit 325253a6b2de ("backlight: Allow drivers to update the core, and generate events on changes"), inform userspace about brightness changes and allow drivers to request updates of the brightness value. Signed-off-by: Gabriele Mazzotta --- This is exactly like 325253a

[PATCH 2/2] ALSA: hda - Fix click noises on Samsung Ativ Book 8

2016-12-24 Thread Gabriele Mazzotta
jack by automuting via amp instead of pinctl. Signed-off-by: Gabriele Mazzotta --- sound/pci/hda/patch_realtek.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d30cc49512e4..00df12b6695a 100644 --- a/sound/pci/hda

[PATCH 1/2] ALSA: hda - Apply ALC269_FIXUP_NO_SHUTUP on HDA_FIXUP_ACT_PROBE

2016-12-24 Thread Gabriele Mazzotta
Setting shutup when the action is HDA_FIXUP_ACT_PRE_PROBE might not have the desired effect since it could be overridden by another more generic shutup function. Prevent this by setting the more specific shutup function on HDA_FIXUP_ACT_PROBE. Signed-off-by: Gabriele Mazzotta --- sound/pci/hda

[PATCH v3] rtc-cmos: Reject unsupported alarm values

2016-10-03 Thread Gabriele Mazzotta
, alarms are potentially programmed to go off in the wrong moment. Fix this by rejecting any unsupported value. Signed-off-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c | 72 ++ 1 file changed, 72 insertions(+) diff --git a/drivers/rtc/rtc-cmos.c b

Re: [PATCH v2] rtc-cmos: Reject unsupported alarm values

2016-09-22 Thread Gabriele Mazzotta
2016-09-22 1:29 GMT+02:00 Alexandre Belloni : > On 02/09/2016 at 21:55:16 +0200, Gabriele Mazzotta wrote : >> Some platforms allows to specify the month and day of the month in >> which an alarm should go off, some others the day of the month and >> some others just the time

[PATCH v4 2/2] rtc-cmos: Restore alarm after resume

2016-09-19 Thread Gabriele Mazzotta
nd (5), resulting in it running in a confined space and potentially overheating. This seems reasonably important. The Rapid Start support code got added in 3.11, but it can be configured in the firmware regardless of kernel support. Signed-off-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c

[PATCH v4 1/2] rtc-cmos: Clear ACPI-driven alarms upon resume

2016-09-19 Thread Gabriele Mazzotta
-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 1dec52f..fd7ec0a 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -900,6

[PATCH v3 1/2] rtc-cmos: Clear ACPI-driven alarms upon resume

2016-09-14 Thread Gabriele Mazzotta
-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 1dec52f..6042257 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -939,6 +939,22

[PATCH v3 2/2] rtc-cmos: Restore alarm after resume

2016-09-14 Thread Gabriele Mazzotta
nd (5), resulting in it running in a confined space and potentially overheating. This seems reasonably important. The Rapid Start support code got added in 3.11, but it can be configured in the firmware regardless of kernel support. Signed-off-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c

Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

2016-09-06 Thread Gabriele Mazzotta
2016-09-06 0:26 GMT+02:00 Alexandre Belloni : > Hi > > On 01/09/2016 at 00:58:59 +0200, Gabriele Mazzotta wrote : >> static int cmos_resume(struct device *dev) >> { >> struct cmos_rtc *cmos = dev_get_drvdata(dev); >> unsigned char tmp; >> +

[PATCH v2] rtc-cmos: Reject unsupported alarm values

2016-09-02 Thread Gabriele Mazzotta
, alarms are potentially programmed to go off in the wrong moment. Fix this by rejecting any value not supported by the hardware. Signed-off-by: Gabriele Mazzotta --- I revisited the naive implementation of v1. I tested the new algorithm using some dates that and verified that it behaved as expected

Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

2016-09-02 Thread Gabriele Mazzotta
On 01/09/2016 00:58, Gabriele Mazzotta wrote: > Some BIOSes, such as the one of the Dell XPS13 9333, wake the system > when an alarm goes off without informing the OS. If any of the A clarification on this first sentence. I was looking at the ACPI specification [1] and it seems that there a

Re: [PATCH] rtc-cmos: Reject unsupported alarm values

2016-08-31 Thread Gabriele Mazzotta
On 01/09/2016 00:59, Gabriele Mazzotta wrote: > Return an error if the user tries to set an alarm that isn't > supported by the hardware. > > Signed-off-by: Gabriele Mazzotta > --- > drivers/rtc/rtc-cmos.c | 20 > 1 file changed, 20 insertions(+)

[PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

2016-08-31 Thread Gabriele Mazzotta
alarm writing 0 to wakealarm before being able to set a new alarm. Ensure this never happens. Signed-off-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index

[PATCH v2 2/2] rtc-cmos: Restore alarm after resume

2016-08-31 Thread Gabriele Mazzotta
nd (5), resulting in it running in a confined space and potentially overheating. This seems reasonably important. The Rapid Start support code got added in 3.11, but it can be configured in the firmware regardless of kernel support. Signed-off-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c

[PATCH] rtc-cmos: Reject unsupported alarm values

2016-08-31 Thread Gabriele Mazzotta
Return an error if the user tries to set an alarm that isn't supported by the hardware. Signed-off-by: Gabriele Mazzotta --- drivers/rtc/rtc-cmos.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 4cdb335..b3

Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

2016-08-31 Thread Gabriele Mazzotta
On 31/08/2016 01:28, Alexandre Belloni wrote: > Hi, > > On 25/08/2016 at 16:54:18 +0200, Gabriele Mazzotta wrote : >> Hi, >> >> were you able to verify that no other driver is affect? >> > > I had a closer look at the issue. I think what is happening is t

Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

2016-08-25 Thread Gabriele Mazzotta
On 04/06/2016 19:48, Alexandre Belloni wrote: > On 04/06/2016 at 18:58:59 +0200, Gabriele Mazzotta wrote : >> 2016-06-04 16:46 GMT+02:00 Alexandre Belloni >> : >>> On 01/06/2016 at 17:40:14 +0200, Gabriele Mazzotta wrote : >>>> If the system wakes up because

Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes

2016-06-22 Thread Gabriele Mazzotta
On 22/06/2016 16:21, mario_limoncie...@dell.com wrote: >> -Original Message- >> From: Pali Rohár [mailto:pali.ro...@gmail.com] >> Sent: Wednesday, June 22, 2016 9:13 AM >> To: Limonciello, Mario >> Cc: gabriele@gmail.com; mj...@srcf.ucam.org; dvh...@infradead.org; >> ker...@kempniu.pl;

Re: [PATCH v3 0/4] dell-wmi: Changes in WMI event code handling

2016-06-16 Thread Gabriele Mazzotta
go into linux-next? > > Series should be OK, but I would like to see if someone else test this > series... Gabriele, Alex or Andy? Do you have time? I tested this series and everything seems to be working fine here. Tested-by: Gabriele Mazzotta

Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes

2016-06-08 Thread Gabriele Mazzotta
On 08/06/2016 08:02, mario_limoncie...@dell.com wrote: >> -Original Message- >> From: Pali Rohár [mailto:pali.ro...@gmail.com] >> Sent: Tuesday, June 7, 2016 6:00 PM >> To: Gabriele Mazzotta ; Limonciello, Mario >> >> Cc: Matthew Garrett ; Darren Hart

Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

2016-06-04 Thread Gabriele Mazzotta
2016-06-04 16:46 GMT+02:00 Alexandre Belloni : > Hi, > > On 01/06/2016 at 17:40:14 +0200, Gabriele Mazzotta wrote : >> If the system wakes up because of a wake alarm, the internal state >> of the alarm is not updated. As consequence, the state no longer >> reflects the a

Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

2016-06-01 Thread Gabriele Mazzotta
On 01/06/2016 17:40, Gabriele Mazzotta wrote: > If the system wakes up because of a wake alarm, the internal state > of the alarm is not updated. As consequence, the state no longer > reflects the actual state of the hardware and setting a new alarm > is not possible until the expi

[PATCH 1/2] rtc-cmos: Clear expired alarm after resume

2016-06-01 Thread Gabriele Mazzotta
If the system wakes up because of a wake alarm, the internal state of the alarm is not updated. As consequence, the state no longer reflects the actual state of the hardware and setting a new alarm is not possible until the expired alarm is cleared. Signed-off-by: Gabriele Mazzotta --- drivers

[PATCH 2/2] rtc-cmos: Restore alarm after resume

2016-06-01 Thread Gabriele Mazzotta
nd (5), resulting in it running in a confined space and potentially overheating. This seems reasonably important. The Rapid Start support code got added in 3.11, but it can be configured in the firmware regardless of kernel support. Signed-off-by: Gabriele Mazzotta --- This a rework of

Re: [Experimental PATCH] dell-smm-hwmon: Add support for disabling automatic BIOS fan control

2016-05-30 Thread Gabriele Mazzotta
On 30/05/2016 11:32, Pali Rohár wrote: > On Friday 27 May 2016 14:11:11 Gabriele Mazzotta wrote: >> On 22/05/2016 13:50, Pali Rohár wrote: >>> This patch exports standard hwmon pwmX_enable sysfs attribute for enabling >>> or disabling automatic fan control by BIOS

Re: [Experimental PATCH] dell-smm-hwmon: Add support for disabling automatic BIOS fan control

2016-05-27 Thread Gabriele Mazzotta
On 22/05/2016 13:50, Pali Rohár wrote: > This patch exports standard hwmon pwmX_enable sysfs attribute for enabling > or disabling automatic fan control by BIOS. Standard value "1" is for > disabling automatic BIOS fan control and value "2" for enabling. > > Currently there is no way to check if B

Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes

2016-05-26 Thread Gabriele Mazzotta
knowing what's the meaning of this 0xe00e. This event is sent multiple times when I suspend/resume my laptop and it's definitely not a keypress. Anyway, I've been using this patch set and didn't notice any issue, so Tested-by: Gabriele Mazzotta > /* Wifi Catcher */ >

Re: [PATCH v4] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-25 Thread Gabriele Mazzotta
On 25/05/2016 22:36, Pali Rohár wrote: > On Wednesday 25 May 2016 22:28:47 Darren Hart wrote: >> On Tue, May 24, 2016 at 10:53:08PM +0200, Gabriele Mazzotta wrote: >>> Some BIOSes unconditionally send an ACPI notification to RBTN when >>> the system is resuming from su

[PATCH v4] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-24 Thread Gabriele Mazzotta
://bugzilla.kernel.org/show_bug.cgi?id=106031 Signed-off-by: Gabriele Mazzotta --- drivers/platform/x86/dell-rbtn.c | 56 1 file changed, 56 insertions(+) diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c index 331d63c..dd22fb9

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Gabriele Mazzotta
On 24/05/2016 00:22, Pali Rohár wrote: > On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: >> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote: >>> On Monday 23 May 2016 23:26:55 Darren Hart wrote: I've queued this. Thanks for your patience. >>> >>> Ok, In that case I would update c

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-04-25 Thread Gabriele Mazzotta
2016-04-18 14:35 GMT+02:00 Pali Rohár : > On Tuesday 29 March 2016 15:11:35 Rafael J. Wysocki wrote: >> On Monday, March 28, 2016 10:33:09 AM Darren Hart wrote: >> > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: >> > > 2016-03-24 10:39 GMT+01:00 P

Oops in 4.6-rc2: NULL pointer dereference in cdc-acm

2016-04-06 Thread Gabriele Mazzotta
Hi, I'm getting a kernel oops when I plug some smartphone via USB to my laptop, which is currently running the v4.6-rc2. The problem seems to be caused by a81cf9799ad7 ("cdc-acm: implement put_char() and flush_chars()"). A simple NULL pointer check prevents the crash, but since I have no use of

[PATCH v4 1/4] input: synaptics - fix pressure values calculation on image sensors

2016-04-01 Thread Gabriele Mazzotta
The pressure values retrieved from secondary packets was incorrectly shifted, making them lower than what they actually were. Since this only happened with secondary packets, the values reported when only one finger was present on the touchpad were correct. Signed-off-by: Gabriele Mazzotta

[PATCH v4 2/4] input: synaptics - fix width values calculation on image sensors

2016-04-01 Thread Gabriele Mazzotta
When multiple fingers are on the touchpad, W reports the finger count rather than the width. Retrieve the correct value that is encoded in X, Y and Z of AGM and SGM packets. The minimum width reported is 8 rather than 4 in this case, while the maximum remains 15. Signed-off-by: Gabriele Mazzotta

[PATCH v4 4/4] input: synaptics - make image sensors and cr48 sensors report widths

2016-04-01 Thread Gabriele Mazzotta
-off-by: Gabriele Mazzotta --- drivers/input/mouse/synaptics.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 27a091b..bed268b 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -943,6

[PATCH v4 0/4] input: synaptics - report correct width and pressure values

2016-04-01 Thread Gabriele Mazzotta
The problem of the previous set, v3, was the use of ABS_MT_TOUCH_MAJOR to report finger widths without them being expressed in surface units. In this set only the width of the first touch is reported, this time using ABS_TOOL_WIDTH. Gabriele Mazzotta (4): input: synaptics - fix pressure values

[PATCH v4 3/4] input: synaptics - change default width value of cr48 sensors

2016-04-01 Thread Gabriele Mazzotta
The minimum value these sensors can report is 4, so this should be the value used when W is not reporting the width. Signed-off-by: Gabriele Mazzotta --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers

[PATCH] HID: multitouch: Synchronize MT frame on reset_resume

2016-03-29 Thread Gabriele Mazzotta
input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called at each frame. Do it when releasing the touches, or else we won't get a proper slot number after mt_reset_resume(). Signed-off-by: Gabriele Mazzotta --- drivers/hid/hid-multitouch.c | 1 + 1 file changed, 1 inse

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-29 Thread Gabriele Mazzotta
2016-03-29 7:24 GMT+02:00 Darren Hart : > > On Mon, Mar 28, 2016 at 09:41:09PM +0200, Gabriele Mazzotta wrote: > > 2016-03-28 20:56 GMT+02:00 Darren Hart : > > > On Mon, Mar 28, 2016 at 07:58:09PM +0200, Gabriele Mazzotta wrote: > > >> 2016-03-28 19:33 GMT+02:00 D

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-28 Thread Gabriele Mazzotta
2016-03-28 20:56 GMT+02:00 Darren Hart : > On Mon, Mar 28, 2016 at 07:58:09PM +0200, Gabriele Mazzotta wrote: >> 2016-03-28 19:33 GMT+02:00 Darren Hart : >> > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: >> >> 2016-03-24 10:39 GMT+01:00 Pali Rohá

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-28 Thread Gabriele Mazzotta
2016-03-28 19:33 GMT+02:00 Darren Hart : > On Thu, Mar 24, 2016 at 12:24:56PM +0100, Gabriele Mazzotta wrote: >> 2016-03-24 10:39 GMT+01:00 Pali Rohár : >> > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: >> >> 2016-03-21 13:17 GMT+01:00 Pali Rohár : >

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-24 Thread Gabriele Mazzotta
2016-03-24 10:39 GMT+01:00 Pali Rohár : > On Monday 21 March 2016 16:13:34 Gabriele Mazzotta wrote: >> 2016-03-21 13:17 GMT+01:00 Pali Rohár : >> > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote: >> >> +#ifdef CONFIG_PM_SLEEP >> >> +static void A

Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-21 Thread Gabriele Mazzotta
2016-03-21 13:17 GMT+01:00 Pali Rohár : > On Friday 18 March 2016 23:44:23 Gabriele Mazzotta wrote: >> +#ifdef CONFIG_PM_SLEEP >> +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context) >> +{ >> + struct rbtn_data *rbtn_data = context; >> + >

[PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-18 Thread Gabriele Mazzotta
://bugzilla.kernel.org/show_bug.cgi?id=106031 Signed-off-by: Gabriele Mazzotta --- Same as v2 with some comments drivers/platform/x86/dell-rbtn.c | 50 1 file changed, 50 insertions(+) diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell

Re: [PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-14 Thread Gabriele Mazzotta
2016-03-12 0:49 GMT+01:00 Gabriele Mazzotta : > Some BIOSes unconditionally send an ACPI notification to RBTN when the > system is resuming from suspend. This makes dell-rbtn send an input > event to userspace as if a function key was pressed. Prevent this by > ignoring all the n

[PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-11 Thread Gabriele Mazzotta
://bugzilla.kernel.org/show_bug.cgi?id=106031 Signed-off-by: Gabriele Mazzotta --- drivers/platform/x86/dell-rbtn.c | 41 1 file changed, 41 insertions(+) diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c index cd410e3..56b0da7

Re: [PATCH 0/2] Fixes for dell-wmi

2015-12-27 Thread Gabriele Mazzotta
On 27/12/2015 14:07, Pali Rohár wrote: > On Sunday 27 December 2015 13:59:57 Gabriele Mazzotta wrote: >> On 24/12/2015 22:18, Pali Rohár wrote: >>> This patch series adds check if Dell WMI descriptor structure is >>> valid and fixes processing WMI events on devices with

Re: [PATCH 0/2] Fixes for dell-wmi

2015-12-27 Thread Gabriele Mazzotta
On 24/12/2015 22:18, Pali Rohár wrote: > This patch series adds check if Dell WMI descriptor structure is valid and > fixes processing WMI events on devices with WMI interface version 0. > > After testing, second patch is good candidate for backporting into stable > kernels, but problem is that it

[PATCH] dell-rbtn: Ignore ACPI notifications if device is suspended

2015-11-21 Thread Gabriele Mazzotta
://bugzilla.kernel.org/show_bug.cgi?id=106031 Signed-off-by: Gabriele Mazzotta --- drivers/platform/x86/dell-rbtn.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c index cd410e3..1d64b72 100644 --- a

Re: [PATCH] HID: rmi: Write updated F11 control registers after reset

2015-07-10 Thread Gabriele Mazzotta
On Thursday 09 July 2015 17:41:28 Andrew Duggan wrote: > On 07/09/2015 03:40 PM, Gabriele Mazzotta wrote: > > On Thursday 09 July 2015 15:14:17 Andrew Duggan wrote: > >> When a device is reset the values of control registers will be reset to > >> the defaults. This

Re: [PATCH] HID: rmi: Write updated F11 control registers after reset

2015-07-09 Thread Gabriele Mazzotta
couple of comments here below, but other than that Tested-by: Gabriele Mazzotta > Signed-off-by: Andrew Duggan > --- > drivers/hid/hid-rmi.c | 41 ++--- > 1 file changed, 34 insertions(+), 7 deletions(-) > > diff --git a/drivers/hid/hid-rm

Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-08 Thread Gabriele Mazzotta
On Tuesday 07 July 2015 22:49:30 Jiri Kosina wrote: > On Tue, 7 Jul 2015, Gabriele Mazzotta wrote: > > > The irq is most likely required by the suspend callback, so disable it > > only after the callback had been executed. > > It would be nice to have a more verbose chang

[PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-07 Thread Gabriele Mazzotta
The irq is most likely required by the suspend callback, so disable it only after the callback had been executed. Signed-off-by: Gabriele Mazzotta --- drivers/hid/i2c-hid/i2c-hid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers

[PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute

2015-06-27 Thread Gabriele Mazzotta
As per Documentation/hwmon/sysfs-interface, hwmon name attributes must not include '-', so replace 'dell-smm' with 'dell_smm'. Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k") Signed-off-by: Gabriele Mazzotta ---

Re: [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-06-27 Thread Gabriele Mazzotta
On Saturday 27 June 2015 15:01:34 Pali Rohár wrote: > On Saturday 27 June 2015 14:55:40 Gabriele Mazzotta wrote: > > On Saturday 27 June 2015 14:47:16 Pali Rohár wrote: > > > On Saturday 27 June 2015 13:34:30 Gabriele Mazzotta wrote: > > > > Hi Pali, > > >

Re: [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-06-27 Thread Gabriele Mazzotta
On Saturday 27 June 2015 14:47:16 Pali Rohár wrote: > On Saturday 27 June 2015 13:34:30 Gabriele Mazzotta wrote: > > Hi Pali, > > > > I've just noticed an issue with this patch. See the comment here > > below. > > > > Gabriele > > > &

Re: [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-06-27 Thread Gabriele Mazzotta
Hi Pali, I've just noticed an issue with this patch. See the comment here below. Gabriele On Wednesday 29 April 2015 13:41:26 Pali Rohár wrote: > This patch splits CONFIG_I8K compile option to SENSORS_DELL_SMM and > CONFIG_I8K. > Option SENSORS_DELL_SMM is now used to enable compilation of dell

Re: [PATCH v3 4/5] input: synaptics - make image sensors and cr48 sensors report widths

2015-06-12 Thread Gabriele Mazzotta
On Thursday 11 June 2015 17:40:14 Dmitry Torokhov wrote: > HI Gabriele, > > On Sun, Mar 22, 2015 at 03:43:55PM +0100, Gabriele Mazzotta wrote: > > The driver was not reporting widths for image sensors and cr48 sensors > > despite it was calculating them. > > > >

Re: [PATCH v3 0/5] input: synaptics - report correct width and pressure values

2015-06-09 Thread Gabriele Mazzotta
On Sunday 22 March 2015 15:43:51 Gabriele Mazzotta wrote: > Hi, > > I updated the series fixing the error reported by Shunsuke Shimizu that > I made when I rebased v1. I've also included a change to make input > devices correctly report their capabilities and included a

Re: Regression: turbostat stops working after suspend/resume cycle\

2015-05-18 Thread Gabriele Mazzotta
On Monday 18 May 2015 08:48:04 Peter Zijlstra wrote: > On Sun, May 17, 2015 at 05:48:44PM +0200, Gabriele Mazzotta wrote: > > Hi, > > > > I've recently noticed that if I suspend and resume my laptop, I can no > > longer execute turbostat. This is what I get when I

Re: Regression: turbostat stops working after suspend/resume cycle

2015-05-18 Thread Gabriele Mazzotta
On Monday 18 May 2015 08:45:52 Ingo Molnar wrote: > > * Gabriele Mazzotta wrote: > > > Hi, > > > > I've recently noticed that if I suspend and resume my laptop, I can no > > longer execute turbostat. This is what I get when I try to start it: > >

Regression: turbostat stops working after suspend/resume cycle

2015-05-17 Thread Gabriele Mazzotta
Hi, I've recently noticed that if I suspend and resume my laptop, I can no longer execute turbostat. This is what I get when I try to start it: # turbostat Could not migrate to CPU 1 turbostat: re-initialized with num_cpus 4 Could not migrate to CPU 1 Since everything works as expected with v4.0,

[PATCH] iio: acpi-als: Fix Kconfig and remove unneeded pointer casting

2015-05-09 Thread Gabriele Mazzotta
Signed-off-by: Gabriele Mazzotta --- This patch fixes the issues of: [PATCH v9] iio: acpi: Add support for ACPI0008 Ambient Light Sensor Link: http://lkml.kernel.org/g/1430569857-31386-1-git-send-email-gabriele@gmail.com drivers/iio/light/Kconfig| 1 + drivers/iio/light/acpi-als.c | 3

Re: [PATCH v9] iio: acpi: Add support for ACPI0008 Ambient Light Sensor

2015-05-09 Thread Gabriele Mazzotta
On Saturday 02 May 2015 14:30:57 Gabriele Mazzotta wrote: > This driver adds the initial support for the ACPI Ambient Light Sensor > as defined in Section 9.2 of the ACPI specification (Revision 5.0) [1]. > > Sensors complying with the standard are exposed as ACPI devices with &

Re: [PATCH v9] iio: acpi: Add support for ACPI0008 Ambient Light Sensor

2015-05-08 Thread Gabriele Mazzotta
On Friday 08 May 2015 10:58:29 Jonathan Cameron wrote: > On 02/05/15 08:30, Gabriele Mazzotta wrote: > > This driver adds the initial support for the ACPI Ambient Light Sensor > > as defined in Section 9.2 of the ACPI specification (Revision 5.0) [1]. > > > > Sensors

Re: [PATCH v2 0/3] Dell Airplane Mode Switch driver

2015-05-05 Thread Gabriele Mazzotta
he patches. It's > always good practice to include it - but especially after this much time has > passed - it really helps page back in all the relevant issues. > > After the discussion on this list, I'm not sure where we are with how this > patch > series impacts the ma

Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2015-05-05 Thread Gabriele Mazzotta
On Thursday 30 April 2015 09:44:29 Pali Rohár wrote: > On Thursday 30 April 2015 14:06:27 Alex Hung wrote: > > Method ABRT is to be used by driver to disable BIOS handling of radio > > button. So the changes in behaviours observed by Gabriele is expected. > > I have seen other systems behave the sa

Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2015-05-02 Thread Gabriele Mazzotta
On Thursday 30 April 2015 09:44:29 Pali Rohár wrote: > On Thursday 30 April 2015 14:06:27 Alex Hung wrote: > > Method ABRT is to be used by driver to disable BIOS handling of radio > > button. So the changes in behaviours observed by Gabriele is expected. > > I have seen other systems behave the sa

[PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated

2015-05-02 Thread Gabriele Mazzotta
Check whether the allocation of a new kfifo buffer failed or not before setting the update_needed flag to false. This will make iio_request_update_kfifo() try to allocate a new buffer the next time a buffer update is requested. Signed-off-by: Gabriele Mazzotta --- drivers/iio/kfifo_buf.c | 3

[PATCH v9] iio: acpi: Add support for ACPI0008 Ambient Light Sensor

2015-05-02 Thread Gabriele Mazzotta
/ACPIspec50.pdf Signed-off-by: Martin Liska Signed-off-by: Marek Vasut Signed-off-by: Gabriele Mazzotta Cc: Zhang Rui --- Changes since v8: - Set realbits to 32 - Fix license mismatch (using GPL v2 or later) - Drop iio_device_unregister() in favor of devm_iio_device_register() drivers/iio

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-05-01 Thread Gabriele Mazzotta
Hi, probably this is not completely related to this driver, but I noticed something while testing it. When I load acpi-als, /sys/bus/iio/devices/iio:device0/buffer/enable is 0. If I try to set it to 1, I get the following error: "Buffer not started: buffer parameter update failed (-22)" After I

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Gabriele Mazzotta
On Thursday 30 April 2015 15:24:07 Daniel Baluta wrote: > Hi Gabriele, > > Please keep the version numbering from previous patches, > I think this should be v8 :). OK, I'll use v9 for the next submission. > On Wed, Apr 29, 2015 at 2:27 PM, Gabriele Mazzotta >

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-30 Thread Gabriele Mazzotta
On Thursday 30 April 2015 11:44:36 Marek Vasut wrote: > On Wednesday, April 29, 2015 at 05:36:32 PM, Gabriele Mazzotta wrote: > [...] > > > > I'm sorry, I've just noticed that I haven't changed the value of > > > > realbits in acpi_als_cha

Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 20:16:06 Pali Rohár wrote: > On Wednesday 29 April 2015 20:11:38 Gabriele Mazzotta wrote: > > On Wednesday 29 April 2015 20:00:18 Pali Rohár wrote: > > > On Wednesday 29 April 2015 19:54:43 Gabriele Mazzotta wrote: > > > > On Wednesday 29

Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 20:00:18 Pali Rohár wrote: > On Wednesday 29 April 2015 19:54:43 Gabriele Mazzotta wrote: > > On Wednesday 29 April 2015 18:28:40 Pali Rohár wrote: > > > On Wednesday 29 April 2015 15:57:58 Gabriele Mazzotta wrote: > > > > On Wednesday 29

Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 18:28:40 Pali Rohár wrote: > On Wednesday 29 April 2015 15:57:58 Gabriele Mazzotta wrote: > > On Wednesday 29 April 2015 15:08:40 Pali Rohár wrote: > > > On Wednesday 29 April 2015 12:30:32 Gabriele Mazzotta wrote: > > > > On Wednesday 29

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 16:33:18 Marek Vasut wrote: > On Wednesday, April 29, 2015 at 01:51:21 PM, Gabriele Mazzotta wrote: > > On Wednesday 29 April 2015 13:27:25 Gabriele Mazzotta wrote: > > > Add basic implementation of the ACPI0008 Ambient Light Sensor driver. > >

Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 15:08:40 Pali Rohár wrote: > On Wednesday 29 April 2015 12:30:32 Gabriele Mazzotta wrote: > > On Wednesday 29 April 2015 11:51:04 Pali Rohár wrote: > > > This is an ACPI driver for Dell laptops which receive HW switch events. > > > It expo

Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-29 Thread Gabriele Mazzotta
On Wednesday 29 April 2015 13:27:25 Gabriele Mazzotta wrote: > Add basic implementation of the ACPI0008 Ambient Light Sensor driver. > This driver currently supports only the ALI property, yet is ready to > be easily extended to handle ALC, ALT, ALP ones as well. > > Signed-off-b

[PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor

2015-04-29 Thread Gabriele Mazzotta
Add basic implementation of the ACPI0008 Ambient Light Sensor driver. This driver currently supports only the ALI property, yet is ready to be easily extended to handle ALC, ALT, ALP ones as well. Signed-off-by: Martin Liska Signed-off-by: Marek Vasut Signed-off-by: Gabriele Mazzotta Cc: Zhang

Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2015-04-29 Thread Gabriele Mazzotta
es. This comes in handy when the function key controls multiple radio devices. Here below the simple patch. Maybe I could improve it and allow a dynamic switch between RBTN_TOGGLE and RBTN_SLIDER. >From 35d39a4ad079489147b4ce22651c5e4e18856cf0 Mon Sep 17 00:00:00 2001 From: Gabriele Mazzott

Re: [PATCH v3 0/5] input: synaptics - report correct width and pressure values

2015-04-27 Thread Gabriele Mazzotta
On Sunday 22 March 2015 15:43:51 Gabriele Mazzotta wrote: > Hi, > > I updated the series fixing the error reported by Shunsuke Shimizu that > I made when I rebased v1. I've also included a change to make input > devices correctly report their capabilities and included a

[PATCH] Bluetooth: Skip the shutdown routine if the interface is not up

2015-04-26 Thread Gabriele Mazzotta
Most likely, the shutdown routine requires the interface to be up. This is the case for BTUSB_INTEL: the routine tries to send a command to the interface, but since this one is down, it fails and exits once HCI_INIT_TIMEOUT has expired. Signed-off-by: Gabriele Mazzotta --- net/bluetooth

[PATCH v2 2/2] libata: Ignore spurious PHY event on LPM policy change

2015-04-25 Thread Gabriele Mazzotta
roughly 6s after the policy change. Link: http://lkml.kernel.org/g/3352987.ugV1Ipy7Z5@xps13 Signed-off-by: Gabriele Mazzotta --- drivers/ata/libata-core.c | 15 ++- drivers/ata/libata-eh.c | 3 +++ include/linux/libata.h| 9 + 3 files changed, 26 insertions(+), 1 deletion

[PATCH v2 0/2] libata: Ignore spurious PHY event on LPM policy change

2015-04-25 Thread Gabriele Mazzotta
Changes since v1: - Added generic helper to keep the logic in one place Gabriele Mazzotta (2): libata: Add helper to determine when PHY events should be ignored libata: Ignore spurious PHY event on LPM policy change drivers/ata/libahci.c | 3 +-- drivers/ata/libata-core.c | 32

[PATCH v2 1/2] libata: Add helper to determine when PHY events should be ignored

2015-04-25 Thread Gabriele Mazzotta
This is a preparation commit that will allow to add other criteria according to which PHY events should be dropped. Signed-off-by: Gabriele Mazzotta --- drivers/ata/libahci.c | 3 +-- drivers/ata/libata-core.c | 19 +++ include/linux/libata.h| 1 + 3 files changed, 21

Re: [PATCH] libata: Ignore spurious PHY events on LPM policy change

2015-04-25 Thread Gabriele Mazzotta
On Saturday 25 April 2015 11:37:51 Tejun Heo wrote: > I thought more about it and it's weird to have ATA_LFLAG_CHANGED and > last_lpm_change timestamp in libata core side and then open-code the > actual logic in ahci. How about implementing a generic helper, say, > bool sata_lpm_ignore_phy_events(

[PATCH] libata: Ignore spurious PHY events on LPM policy change

2015-04-25 Thread Gabriele Mazzotta
to roughly 6s after the policy change. Signed-off-by: Gabriele Mazzotta --- drivers/ata/libahci.c | 13 - drivers/ata/libata-eh.c | 3 +++ include/linux/libata.h | 9 + 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libahci.c b/drivers/ata

  1   2   >