Re: [Intel-gfx] xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-29 Thread Gaston Gonzalez
On Fri, Oct 28, 2016 at 07:23:24PM +0300, Ville Syrjälä wrote: > On Fri, Oct 28, 2016 at 11:53:40AM -0400, Greg KH wrote: > > On Fri, Oct 07, 2016 at 10:38:17AM -0300, Gaston Gonzalez wrote: > > > On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > > > > On T

Re: [Intel-gfx] xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-29 Thread Gaston Gonzalez
On Fri, Oct 28, 2016 at 07:23:24PM +0300, Ville Syrjälä wrote: > On Fri, Oct 28, 2016 at 11:53:40AM -0400, Greg KH wrote: > > On Fri, Oct 07, 2016 at 10:38:17AM -0300, Gaston Gonzalez wrote: > > > On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > > > > On T

Re: xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-07 Thread Gaston Gonzalez
On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > On Tue, Oct 04, 2016 at 08:43:03PM -0300, Gaston Gonzalez wrote: > > Hi, > > > > After hibernation I get the following error when I tried to connect to > > monitor > > through hdmi: > > > > $

Re: xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-07 Thread Gaston Gonzalez
On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > On Tue, Oct 04, 2016 at 08:43:03PM -0300, Gaston Gonzalez wrote: > > Hi, > > > > After hibernation I get the following error when I tried to connect to > > monitor > > through hdmi: > > > > $

Re: xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-05 Thread Gaston Gonzalez
On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > On Tue, Oct 04, 2016 at 08:43:03PM -0300, Gaston Gonzalez wrote: > > Hi, > > > > After hibernation I get the following error when I tried to connect to > > monitor > > through hdmi: > > > > $

Re: xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-05 Thread Gaston Gonzalez
On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > On Tue, Oct 04, 2016 at 08:43:03PM -0300, Gaston Gonzalez wrote: > > Hi, > > > > After hibernation I get the following error when I tried to connect to > > monitor > > through hdmi: > > > > $

xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-04 Thread Gaston Gonzalez
Hi, After hibernation I get the following error when I tried to connect to monitor through hdmi: $ xrandr --output LVDS1 --off --output HDMI1 --auto xrandr: Configure crtc 1 failed This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0 I don't see anything

xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

2016-10-04 Thread Gaston Gonzalez
Hi, After hibernation I get the following error when I tried to connect to monitor through hdmi: $ xrandr --output LVDS1 --off --output HDMI1 --auto xrandr: Configure crtc 1 failed This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0 I don't see anything

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-09-23 Thread Gaston Gonzalez
On Fri, Jun 26, 2015 at 01:36:14PM -0300, Gaston Gonzalez wrote: > On Thu, Jun 25, 2015 at 02:06:44PM +0200, Arnd Bergmann wrote: > > On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote: > > > On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: > > > >

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-09-23 Thread Gaston Gonzalez
On Fri, Jun 26, 2015 at 01:36:14PM -0300, Gaston Gonzalez wrote: > On Thu, Jun 25, 2015 at 02:06:44PM +0200, Arnd Bergmann wrote: > > On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote: > > > On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: > > > >

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-06-26 Thread Gaston Gonzalez
On Thu, Jun 25, 2015 at 02:06:44PM +0200, Arnd Bergmann wrote: > On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote: > > On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: > > > On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: > > > >

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-06-26 Thread Gaston Gonzalez
On Thu, Jun 25, 2015 at 02:06:44PM +0200, Arnd Bergmann wrote: On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote: On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: /* WMM spec P.11: The minimum

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-06-24 Thread Gaston Gonzalez
On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: > On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: > > /* WMM spec P.11: The minimum value for AIFSN shall be 2 */ > > qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? &

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-06-24 Thread Gaston Gonzalez
On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: /* WMM spec P.11: The minimum value for AIFSN shall be 2 */ qos_param-aifs[aci] = (qos_param-aifs[aci] 2) ? 2:qos_param-aifs[aci

[PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-06-21 Thread Gaston Gonzalez
restricted __le16 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:1501:45:got unsigned short [unsigned] [usertype] Signed-off-by: Gaston Gonzalez --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

2015-06-21 Thread Gaston Gonzalez
:1501:45:expected restricted __le16 noident drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:1501:45:got unsigned short [unsigned] [usertype] noident Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 12 +++- 1 file changed, 7

[PATCH] staging: rtl8192u: ieee80211: Fix incorrect type in assignment

2015-06-14 Thread Gaston Gonzalez
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30:right side has type restricted __le16 Signed-off-by: Gaston Gonzalez --- I wonder if this is the best approach, making payload_size u16 in ieee80211.h would fix this plus other three sparse warnings. Could we make payload_size u16

[PATCH] staging: rtl8192u: ieee80211: Fix incorrect type in assignment

2015-06-14 Thread Gaston Gonzalez
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30:right side has type restricted __le16 Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- I wonder if this is the best approach, making payload_size u16 in ieee80211.h would fix this plus other three sparse warnings. Could we make

[PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings ieee80211_softmac.c

2015-06-10 Thread Gaston Gonzalez
/ieee80211_softmac.c:3130:24:expected restricted __le16 [usertype] reason drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:3130:24:got unsigned char [unsigned] [usertype] asRsn Signed-off-by: Gaston Gonzalez --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 10 +- 1

[PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings ieee80211_softmac.c

2015-06-10 Thread Gaston Gonzalez
/ieee80211_softmac.c:3130:24:expected restricted __le16 [usertype] reason drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:3130:24:got unsigned char [unsigned] [usertype] asRsn Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH v3] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-02 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez --- Changes since V2: fix line over 80 chararcters. drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

Re: [PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-02 Thread Gaston Gonzalez
On Tue, Jun 02, 2015 at 11:09:41AM +0530, Sudip Mukherjee wrote: > On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote: > > Fix the following sparse warnings: > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 -- > > 1 file changed, 4

[PATCH v3] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-02 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- Changes since V2: fix line over 80 chararcters. drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging

Re: [PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-02 Thread Gaston Gonzalez
On Tue, Jun 02, 2015 at 11:09:41AM +0530, Sudip Mukherjee wrote: On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote: Fix the following sparse warnings: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez --- Changes since V1: rearrange the code to set auth->header.frame_ctl only once. drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/driv

Re: [PATCH RESEND 2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 02:43:28PM -0700, Joe Perches wrote: > On Mon, 2015-06-01 at 18:30 -0300, Gaston Gonzalez wrote: > > Fix the following sparse warnings: > [] > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > > b/drivers/staging/rtl8192u/ieee8

[PATCH RESEND 2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 01:03:16PM +0900, Greg KH wrote: > On Sun, May 31, 2015 at 11:24:42PM -0300, Gaston Gonzalez wrote: > > On Mon, Jun 01, 2015 at 10:53:20AM +0900, Greg KH wrote: > > > On Sun, May 31, 2015 at 10:41:52PM -0300, Gaston Gonzalez wrote: > > > > On M

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 01:03:16PM +0900, Greg KH wrote: On Sun, May 31, 2015 at 11:24:42PM -0300, Gaston Gonzalez wrote: On Mon, Jun 01, 2015 at 10:53:20AM +0900, Greg KH wrote: On Sun, May 31, 2015 at 10:41:52PM -0300, Gaston Gonzalez wrote: On Mon, Jun 01, 2015 at 08:24:17AM +0900

[PATCH RESEND 2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging

Re: [PATCH RESEND 2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 02:43:28PM -0700, Joe Perches wrote: On Mon, 2015-06-01 at 18:30 -0300, Gaston Gonzalez wrote: Fix the following sparse warnings: [] diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-06-01 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- Changes since V1: rearrange the code to set auth-header.frame_ctl only once. drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 10:53:20AM +0900, Greg KH wrote: > On Sun, May 31, 2015 at 10:41:52PM -0300, Gaston Gonzalez wrote: > > On Mon, Jun 01, 2015 at 08:24:17AM +0900, Greg KH wrote: > > > On Sun, May 31, 2015 at 08:07:21PM -0300, Gaston Gonzalez wrote: > > > > On M

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 08:24:17AM +0900, Greg KH wrote: > On Sun, May 31, 2015 at 08:07:21PM -0300, Gaston Gonzalez wrote: > > On Mon, Jun 01, 2015 at 07:17:39AM +0900, Greg KH wrote: > > > On Sun, May 31, 2015 at 12:17:48PM -0300, Gaston Gonzalez wrote: > > > > Fix

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 07:17:39AM +0900, Greg KH wrote: > On Sun, May 31, 2015 at 12:17:48PM -0300, Gaston Gonzalez wrote: > > Fix the following sparse warnings: > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: > > incorrect type in

Re: [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Sun, May 31, 2015 at 10:45:27AM +0900, Greg KH wrote: > On Tue, May 26, 2015 at 06:47:14PM -0300, Gaston Gonzalez wrote: > > Fix the following sparse warnings: > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: > > incorrect type in

[PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u

Re: [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Sun, May 31, 2015 at 10:45:27AM +0900, Greg KH wrote: On Tue, May 26, 2015 at 06:47:14PM -0300, Gaston Gonzalez wrote: Fix the following sparse warnings: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types

[PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 08:24:17AM +0900, Greg KH wrote: On Sun, May 31, 2015 at 08:07:21PM -0300, Gaston Gonzalez wrote: On Mon, Jun 01, 2015 at 07:17:39AM +0900, Greg KH wrote: On Sun, May 31, 2015 at 12:17:48PM -0300, Gaston Gonzalez wrote: Fix the following sparse warnings

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 07:17:39AM +0900, Greg KH wrote: On Sun, May 31, 2015 at 12:17:48PM -0300, Gaston Gonzalez wrote: Fix the following sparse warnings: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types

Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-31 Thread Gaston Gonzalez
On Mon, Jun 01, 2015 at 10:53:20AM +0900, Greg KH wrote: On Sun, May 31, 2015 at 10:41:52PM -0300, Gaston Gonzalez wrote: On Mon, Jun 01, 2015 at 08:24:17AM +0900, Greg KH wrote: On Sun, May 31, 2015 at 08:07:21PM -0300, Gaston Gonzalez wrote: On Mon, Jun 01, 2015 at 07:17:39AM +0900

[PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-26 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u

[PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-26 Thread Gaston Gonzalez
/ieee80211_softmac.c:664:50:right side has type int Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning

2015-05-25 Thread Gaston Gonzalez
On 25/05/15 13:35, Dan Carpenter wrote: > This is also wrong then. > > regards, > dan carpenter Hi Dan, Yes, you are right. It is the next sparse warning in line for that file. Including the fix for that, the patch would be as showed below. There are similar endianness warnings for other

[PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning

2015-05-25 Thread Gaston Gonzalez
/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:got int Signed-off-by: Gaston Gonzalez --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u

[PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning

2015-05-25 Thread Gaston Gonzalez
/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:got int Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning

2015-05-25 Thread Gaston Gonzalez
On 25/05/15 13:35, Dan Carpenter wrote: This is also wrong then. regards, dan carpenter Hi Dan, Yes, you are right. It is the next sparse warning in line for that file. Including the fix for that, the patch would be as showed below. There are similar endianness warnings for other variables

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-05-06 Thread Gaston Gonzalez
On 27/04/15 07:12, Dan Carpenter wrote: > Can't we just export the tkip.c function? > > regards, > dan carpenter > Hi Dan, (sorry for the delayed response) The inputs of the two implementations of tkip_mixing_phase2() differ in one parameter: - ieee80211_crypt_tkip.c expects 'const u16 *TTAK'

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-05-06 Thread Gaston Gonzalez
On 27/04/15 07:12, Dan Carpenter wrote: Can't we just export the tkip.c function? regards, dan carpenter Hi Dan, (sorry for the delayed response) The inputs of the two implementations of tkip_mixing_phase2() differ in one parameter: - ieee80211_crypt_tkip.c expects 'const u16 *TTAK' -

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-25 Thread Gaston Gonzalez
On 20/04/15 05:24, Dan Carpenter wrote: > Mk16_le() is a bad function name and as we can see from tkip.c it just > duplicates get_unaligned_le16(). Better to make TK void pointer instead > of a u8 pointer (because it doesn't point to u8s so we have to cast it > every time we use it). This is

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-25 Thread Gaston Gonzalez
On 20/04/15 05:24, Dan Carpenter wrote: Mk16_le() is a bad function name and as we can see from tkip.c it just duplicates get_unaligned_le16(). Better to make TK void pointer instead of a u8 pointer (because it doesn't point to u8s so we have to cast it every time we use it). This is another

[PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-19 Thread Gaston Gonzalez
Silence the following sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning: cast to restricted __le16 Signed-off-by: Gaston Gonzalez --- .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22 +++--- 1 file changed, 11 insertions(+), 11

[PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-19 Thread Gaston Gonzalez
Silence the following sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning: cast to restricted __le16 Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22 +++--- 1 file changed, 11

[PATCH] drivers: staging: imx-drm Fix checkpatch warning

2014-10-15 Thread Gaston Gonzalez
Fix line over 80 characters in imx-tve.c Signed-off-by: Gaston Gonzalez --- drivers/staging/imx-drm/imx-tve.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c index 3e8b0a1..a46905f 100644

[PATCH] drivers: staging: imx-drm Fix checkpatch warning

2014-10-15 Thread Gaston Gonzalez
Fix line over 80 characters in imx-tve.c Signed-off-by: Gaston Gonzalez gasc...@gmail.com --- drivers/staging/imx-drm/imx-tve.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c index 3e8b0a1..a46905f