this module?
Thanks!
--George Hilliard
On Tue, Apr 2, 2019 at 3:45 PM Christian Lütke-Stetzkamp
wrote:
> There are two other larger differences that I found during my
> work. One is that drivers/mmc/host/mtk-sd.c has much more features,
> like voltage and clock handling and some support for high speed
> modes. I don't know if these
is also unnecessary because the module never uses
complete_all(). Fix this by only ever initializing the completion a
single time, and log if the completions are not consumed as intended
(this is not a fatal problem, but should not go unnoticed).
Signed-off-by: George Hilliard
---
v2: rewrite of v1
v3
These values are not referred to anywhere else in the kernel. Card
detect is controlled by the device tree property "mediatek,cd-poll",
and there is no driver support for eMMC whatsoever.
Signed-off-by: George Hilliard
---
v2: Rewrite of v1
v3: [Not present]
v4: Resubmit of v2
v5: No c
Now formatted according to checkpatch.pl, not my own semi-coherent sense
of what the kernel style should be. No functionality changes.
George
On Tue, Mar 26, 2019 at 6:46 PM Greg Kroah-Hartman
wrote:
>
> On Tue, Mar 26, 2019 at 09:21:39AM -0600, George Hilliard wrote:
> > - init_completion(>cmd_done);
> > + // The completion should have been consumed by the previous command
> > + // respon
These values are not referred to anywhere else in the kernel. Card
detect is controlled by the device tree property "mediatek,cd-poll",
and there is no driver support for eMMC whatsoever.
Signed-off-by: George Hilliard
---
v2: Rewrite of v1
v3: [Not present]
v4: Resubmit of v2
drive
is also unnecessary because the module never uses
complete_all(). Fix this by only ever initializing the completion a
single time, and log if the completions are not consumed as intended
(this is not a fatal problem, but should not go unnoticed).
Signed-off-by: George Hilliard
---
v2: rewrite of v1
v3
Coding style fixup and rebase of v3, and resubmit of the Kconfig patch
that got dropped from v2. No other changes.
Thanks for your continued attention and reviews!
George
On Thu, Mar 21, 2019 at 5:40 PM Paul Burton wrote:
> On Thu, Mar 21, 2019 at 05:10:38PM -0600, George Hilliard wrote:
> > My version of U-Boot complains if I compile out LZMA support:
> > ---
> > => tftpboot 0x8100 uImage; tftpboot 0x8400 hawkeye.dtb; bootm
>
age ... Unimplemented compression type 3
exit not allowed from main input shell.
=>
---
Thanks,
George
On Thu, Mar 21, 2019 at 4:56 PM Aaro Koskinen wrote:
>
> Hi,
>
> On Thu, Mar 21, 2019 at 11:03:34AM -0600, George Hilliard wrote:
> > Architecturally, there's nothing preventin
not be compressed.
Tested on an MT7688 with U-Boot doing LZMA decompression of uImage.
Signed-off-by: George Hilliard
---
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 4a5f5b0ee9a9..b286fbbd9699 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips
Re-submitting this patch to the correct linux-mips mailing list; I just
learned the linux-mips.org one is not used. Sorry for duplicates.
Do I need to do a `make olddefconfig` or similar for existing
defconfigs? I am unsure of what the procedure is here, and I couldn't
find anything in the
Actually, I just thought about this: do I need to do a `make
olddefconfig` for all the ralink-based defconfigs to let them choose a
default compression method? (I'm somewhat new to kernel
contributions, sorry if this is obvious.)
Thanks,
George
On Thu, Mar 21, 2019 at 8:08 AM George Hilliard
not be compressed.
Tested on an MT7688 with U-Boot doing LZMA decompression of uImage.
Signed-off-by: George Hilliard
---
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 4a5f5b0ee9a9..b286fbbd9699 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips
is also unnecessary because the module never uses
complete_all(). Fix this by only ever initializing the completion a
single time, and log if the completions are not consumed as intended
(this is not a fatal problem, but should not go unnoticed).
Signed-off-by: George Hilliard
---
v2: Rebased v1
v3
this by removing the proc entry when the module is
unloaded.
Signed-off-by: George Hilliard
---
v1: Initial attempt
v2: Rebased from v1
v3: Use #ifdef in header file, not implementation
drivers/staging/mt7621-mmc/dbg.c | 15 ---
drivers/staging/mt7621-mmc/dbg.h | 9 +++--
drivers/staging
with that constraint during init.
Signed-off-by: George Hilliard
---
v2: Rebased v1
v3: Remove existing and added BUG_ON() in v2, and handle dma_map_sg
failure gracefully.
drivers/staging/mt7621-mmc/sd.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621
This series improves up the patches that needed more work from v2 I sent
a couple days ago. BUG_ON()s have been removed.
Let me know if you don't want the 'Remove obsolete Kconfig flags' patch I sent
in the previous series; I didn't see any mail about it.
Thanks!
George
This struct does not exist, and when it is looked up in the
compatibility tree, it returns null. Remove these nonfunctional lines.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-spi/spi-mt7621.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/mt7621-spi/spi
this by removing the proc entry when the module is
unloaded.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/dbg.c | 15 ---
drivers/staging/mt7621-mmc/dbg.h | 3 ++-
drivers/staging/mt7621-mmc/sd.c | 4
3 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers
When waiting on completions, use the _io variant so the caller is
charged as using I/O.
This should have no effect on the module's functionality, only improve
CPU accounting.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 4 ++--
1 file changed, 2 insertions(+), 2
Obvious typo. It is specified as BURST in the datasheet.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/mt6575_sd.h | 10 +-
drivers/staging/mt7621-mmc/sd.c| 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/mt7621-mmc
These comments don't contain useful code or alternate implementation
ideas. Remove them.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/mt6575_sd.h | 3 ---
drivers/staging/mt7621-mmc/sd.c| 2 --
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/mt7621-mmc
A failure while processing the start command could cause dma_unmap_sg()
to be called without first calling dma_map_sg().
Since calling dma_unmap_sg() is only needed when data != NULL, move the
unmap call into the corresponding if {} block.
Signed-off-by: George Hilliard
---
drivers/staging
This is set once during initialization and never changed. Don't bother
setting it again in the interrupt handler.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc
is also unnecessary because the module never uses
complete_all(). Fix this by only ever initializing the completion a
single time.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/mt7621
There is no need to delay notifying the mmc layer. Schedule the delayed
work to run immediately.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc
The buffer descriptor setup loop is correct only if it is setting up at
least one bd struct. Besides, there is an error somewhere if
dma_map_sg() returns 0. So add a paranoid check for this condition.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 7 ++-
1 file
iar with the IP core will
have to do that. Mediatek documentation (that I can find) is very
sparse.
This is ready to merge if there is no other feedback!
>From George Hilliard # This line is ignored.
From: George Hilliard
Reply-To:
Subject: [PATCH v2 00/11] mt7621-mmc: Various correctness fixes
In-Reply-To:
: unused variable ‘mode’
[-Wunused-variable]
int mode, size;
^~~~
Remove these declarations.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/dbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c
index
pinctrl-0 = <_pins>;
// ...
};
This change could break SD controller functionality on existing devices
whose device trees do not specify a pin controller and state for the SD
node.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 6 --
1 file changed,
When waiting on completions, use the _io variant so the caller is
charged as using I/O.
This should have no effect on the module's functionality, only improve
CPU accounting.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 4 ++--
1 file changed, 2 insertions(+), 2
These comments don't contain useful code or alternate implementation
ideas. Remove them.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
index 4b26ec896a96
This struct does not exist, and when it is looked up in the
compatibility tree, it returns null. Remove these nonfunctional lines.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-spi/spi-mt7621.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/mt7621-spi/spi
There is no need to delay notifying the mmc layer. Schedule the delayed
work to run immediately.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc
The buffer descriptor setup loop is correct only if it is setting up at
least one bd struct. Besides, there is an error somewhere if
dma_map_sg() returns 0. So add a paranoid check for this condition.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 7 ++-
1 file
This is a series of patches to provide a little TLC for the mt7621-mmc driver.
My original goal was to get it working on the MT7688, and I have succeeded. I
suspect it will now work on any of the MT762x line. The main change was
getting the driver to use the pinctrl subsystem instead of
is also unnecessary because the module never uses
complete_all(). Fix this by only ever initializing the completion a
single time.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/mt7621
This is set once during initialization and never changed. Don't bother
setting it again in the interrupt handler.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc
. The hardcoded
bit index was incorrect on that device.
This change could break SD controller functionality on existing devices
whose device trees do not specify a pin controller and state for the SD
node.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/sd.c | 28
this by removing the proc entry when the module is
unloaded.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/dbg.c | 15 ---
drivers/staging/mt7621-mmc/dbg.h | 3 ++-
drivers/staging/mt7621-mmc/sd.c | 4
3 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers
: unused variable ‘mode’
[-Wunused-variable]
int mode, size;
^~~~
Remove these declarations.
Signed-off-by: George Hilliard
---
drivers/staging/mt7621-mmc/dbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c
index
...@gmail.com
Signed-off-by: George Hilliard
---
Changelog:
v2:
- Also make the change for skipped/forgotten drivers such as mt7621-eth
v3..v4:
- Rebase against staging-testing
- Also make the change for new PCIe PHY driver
- Slightly change commit wording
v5:
- Fix dependency issue
On Tue, Jan 15, 2019 at 10:20 AM Greg Kroah-Hartman
wrote:
> What changed from v2 and v1? That always goes below the --- line.
>
> Please fix that up and resend v4.
>
Sent. Didn't know to do that - first time contributor here. Sorry
about the churn and thanks for your patience!
Cheers,
George
...@gmail.com
Signed-off-by: George Hilliard
---
Changes in v2..v4:
- Also use individual flags for mt7621-pci and the new mt7621-pci-phy
- Slightly revise commit message
drivers/staging/Makefile| 14 +++---
drivers/staging/mt7621-pci-phy/Makefile | 2 +-
drivers/staging/mt7621
...@gmail.com
Signed-off-by: George Hilliard
---
drivers/staging/Makefile| 14 +++---
drivers/staging/mt7621-pci-phy/Makefile | 2 +-
drivers/staging/mt7621-pci/Makefile | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/Makefile b/drivers
On Thu, Jan 10, 2019, 6:21 PM NeilBrown
> On Thu, Jan 10 2019, thirtythreefo...@gmail.com wrote:
>
> > From: George Hilliard
> >
> > This is in preparation to allow it and the mt7621-dma drivers to be
> > built separately. They are completely independent pieces of
48 matches
Mail list logo
