Re: [PATCH] power: supply: lp8788: prevent out of bounds array access

Ping. On Tue, Mar 28, 2017 at 2:23 AM, Kim, Milo <milo@ti.com> wrote: > On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote: >> >> val might become 7 in which case stime[7] (array of length 7) would be >> accessed during the scnprintf call later and that will cause i

Re: [PATCH] power: supply: lp8788: prevent out of bounds array access

Ping. On Tue, Mar 28, 2017 at 2:23 AM, Kim, Milo wrote: > On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote: >> >> val might become 7 in which case stime[7] (array of length 7) would be >> accessed during the scnprintf call later and that will cause issues. >> Obvi

[PATCH] power: supply: lp8788: prevent out of bounds array access

val might become 7 in which case stime[7] (array of length 7) would be accessed during the scnprintf call later and that will cause issues. Obviously, string concatenation is not intended here so just a comma needs to be added to fix the issue. Signed-off-by: Giedrius Statkevičius

[PATCH] power: supply: lp8788: prevent out of bounds array access

val might become 7 in which case stime[7] (array of length 7) would be accessed during the scnprintf call later and that will cause issues. Obviously, string concatenation is not intended here so just a comma needs to be added to fix the issue. Signed-off-by: Giedrius Statkevičius --- drivers

Re: [PATCH 00/87] Fix some style warnings in hfa384x.h

On Wed, Sep 28, 2016 at 7:27 PM, Sergio Paracuellos wrote: > This patch series fix some warnings reported by checkpatch.pl script in > hfa384x.h: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a separate line >

Re: [PATCH 00/87] Fix some style warnings in hfa384x.h

On Wed, Sep 28, 2016 at 7:27 PM, Sergio Paracuellos wrote: > This patch series fix some warnings reported by checkpatch.pl script in > hfa384x.h: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a separate line > WARNING: do not add new typedefs

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- [...] Why are you sending so many copies

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- [...] Why are you sending so many copies of the same patch?

Re: [PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

Some more users complaining about this: https://bbs.archlinux.org/viewtopic.php?id=215978 On Thu, Sep 01, 2016 at 08:47:02PM +0300, Giedrius Statkevičius wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status

Re: [PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

Some more users complaining about this: https://bbs.archlinux.org/viewtopic.php?id=215978 On Thu, Sep 01, 2016 at 08:47:02PM +0300, Giedrius Statkevičius wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Wed, Aug 17, 2016 at 11:23:15AM -0700, Darren Hart wrote: > On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: >

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Wed, Aug 17, 2016 at 11:23:15AM -0700, Darren Hart wrote: > On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: >

[PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

er.kernel.org> Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- This patch should be applied to all 4.7 and later kernels Another user complaining about probably the same problem: https://bugzilla.kernel.org/show_bug.cgi?id=151711 drivers/net/wireless/ath/ath9k/main.

[PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

depending on the status and is always red Even though for my case it only needs to be set to OUT in ath9k_start but for consistency bring back the IN direction setting as well. Cc: Miaoqing Pan Cc: Kalle Valo Cc: Signed-off-by: Giedrius Statkevičius --- This patch should be applied to all 4.7

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote:

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote:

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > > function instead. There is no funcionality change except that

Re: [PATCH] asus-laptop: get rid of parse_arg()

On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > > function instead. There is no funcionality change except that

[PATCH] asus-laptop: get rid of parse_arg()

-23 parse_arg.part39 - -39 Total: Before=19160, After=19012, chg -0.77% Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 77 ++ 1 file changed, 36 inse

[PATCH] asus-laptop: get rid of parse_arg()

-23 parse_arg.part39 - -39 Total: Before=19160, After=19012, chg -0.77% Signed-off-by: Giedrius Statkevičius --- drivers/platform/x86/asus-laptop.c | 77 ++ 1 file changed, 36 insertions(+), 41 deletions(-) diff --git

Re: [PATCH 1651/1651] staging: i4l: pcbit: Remove explicit NULL comparison

Hello shyam saini, On Tue, Aug 2, 2016 at 2:33 PM, shyam saini wrote: > Remove the explicit NULL comparison and rewrite in a compact form using > Coccinelle > > Signed-off-by: shyam saini Where are the other 1650 patches? Also, a patch series

Re: [PATCH 1651/1651] staging: i4l: pcbit: Remove explicit NULL comparison

Hello shyam saini, On Tue, Aug 2, 2016 at 2:33 PM, shyam saini wrote: > Remove the explicit NULL comparison and rewrite in a compact form using > Coccinelle > > Signed-off-by: shyam saini Where are the other 1650 patches? Also, a patch series that consists of 1651 patches???

Re: [PATCH] Staging: android: ion: ion.c: Compression of lines for

On Sun, Jul 31, 2016 at 6:44 PM, Nadim almas wrote: > This patch compresses two lines in to a single line in file > ion.c > if immediate return statement is found.It also removes variable > ret as it is no longer needed. > > ne using script Coccinelle. And coccinelle uses

Re: [PATCH] Staging: android: ion: ion.c: Compression of lines for

On Sun, Jul 31, 2016 at 6:44 PM, Nadim almas wrote: > This patch compresses two lines in to a single line in file > ion.c > if immediate return statement is found.It also removes variable > ret as it is no longer needed. > > ne using script Coccinelle. And coccinelle uses following semantic >

Re: [PATCH v2] rtl8712: Fixed alignment to match open parenthesis

On Mon, Apr 25, 2016 at 4:00 AM, Parth Sane wrote: > Added missing signed off by line and fixed alignment to match > open parenthesis. Put "Added missing signed off by line" below the ---. This is not what we want to have in change logs.

Re: [PATCH v2] rtl8712: Fixed alignment to match open parenthesis

On Mon, Apr 25, 2016 at 4:00 AM, Parth Sane wrote: > Added missing signed off by line and fixed alignment to match > open parenthesis. Put "Added missing signed off by line" below the ---. This is not what we want to have in change logs.

Re: [PATCH] asus-laptop: correct error handling in asus_read_brightness()

On Fri, Apr 22, 2016 at 02:09:22AM +0300, Andy Shevchenko wrote: > On Sat, Apr 16, 2016 at 3:27 AM, Giedrius Statkevičius > <giedrius.statkevic...@gmail.com> wrote: > > It is possible that acpi_evaluate_integer might fail and value would not be > > set to any valu

Re: [PATCH] asus-laptop: correct error handling in asus_read_brightness()

On Fri, Apr 22, 2016 at 02:09:22AM +0300, Andy Shevchenko wrote: > On Sat, Apr 16, 2016 at 3:27 AM, Giedrius Statkevičius > wrote: > > It is possible that acpi_evaluate_integer might fail and value would not be > > set to any value so correct this defect by returning 0 in ca

Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set

On Wed, Apr 20, 2016 at 01:19:55PM -0700, Darren Hart wrote: > On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote: > > Properly return rv back to the caller in the case of an error in > > parse_arg. In the process remove a unused variable 'out'. > > The

Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set

On Wed, Apr 20, 2016 at 01:19:55PM -0700, Darren Hart wrote: > On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote: > > Properly return rv back to the caller in the case of an error in > > parse_arg. In the process remove a unused variable 'out'. > > The

[PATCH] asus-laptop: correct error handling in asus_read_brightness()

-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 9a69734..15f1311 100644 --- a/drivers/platform/x8

[PATCH] asus-laptop: correct error handling in asus_read_brightness()

-by: Giedrius Statkevičius --- drivers/platform/x86/asus-laptop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 9a69734..15f1311 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86

[PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set

Properly return rv back to the caller in the case of an error in parse_arg. In the process remove a unused variable 'out'. Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 del

[PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set

Properly return rv back to the caller in the case of an error in parse_arg. In the process remove a unused variable 'out'. Signed-off-by: Giedrius Statkevičius --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86

[PATCH v2 1/2] asus-laptop: remove redundant initializers

Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH v2 1/2] asus-laptop: remove redundant initializers

Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevičius --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86

Re: [PATCH 2/2] asus-laptop: remove unused variable

On Sat, Apr 09, 2016 at 08:21:21PM -0700, Darren Hart wrote: > On Thu, Apr 07, 2016 at 11:20:01PM +0300, Giedrius Statkevičius wrote: > > `out' was assigned value but it was never used so remove it > > > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.c

Re: [PATCH 2/2] asus-laptop: remove unused variable

On Sat, Apr 09, 2016 at 08:21:21PM -0700, Darren Hart wrote: > On Thu, Apr 07, 2016 at 11:20:01PM +0300, Giedrius Statkevičius wrote: > > `out' was assigned value but it was never used so remove it > > > > Signed-off-by: Giedrius Statkevičius > > --- > > drive

[PATCH 1/2] asus-laptop: remove redundant initializers

Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH 2/2] asus-laptop: remove unused variable

`out' was assigned value but it was never used so remove it Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> --- drivers/platform/x86/asus-laptop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-la

[PATCH 2/2] asus-laptop: remove unused variable

`out' was assigned value but it was never used so remove it Signed-off-by: Giedrius Statkevičius --- drivers/platform/x86/asus-laptop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index d86d42e..39ddcee 100644

[PATCH 1/2] asus-laptop: remove redundant initializers

Initializing rv to AE_OK is pointless because later function results are assigned to them and only then the variable is used Signed-off-by: Giedrius Statkevičius --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86

Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD

On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote: > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module > is loaded with wapf=4 option. Add quirk for this. > --- You forgot Signed-off-by here. Always run your patch through scripts/checkpatch.pl. Also, I think the

Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD

On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote: > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module > is loaded with wapf=4 option. Add quirk for this. > --- You forgot Signed-off-by here. Always run your patch through scripts/checkpatch.pl. Also, I think the

Re: 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

On Thu, 8 Oct 2015, Geliang Tang wrote: > On Wed, Oct 07, 2015 at 10:27:27PM +0300, Giedrius Statkevičius wrote: > > Hello, > > I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" > > in > > /dev/sda2. After booting on linux-nex

Re: 30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

On Thu, 8 Oct 2015, Geliang Tang wrote: > On Wed, Oct 07, 2015 at 10:27:27PM +0300, Giedrius Statkevičius wrote: > > Hello, > > I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" > > in > > /dev/sda2. After booting on linux-nex

30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

Hello, I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" in /dev/sda2. After booting on linux-next and just after entering my password cryptsetup segfaults and a stack trace is printed from the kernel. Since writing down all those numbers is hard I've made a picture where

30c2a1faaeb3db94fc92f79553cc72634aa3b218 broke cryptsetup on my machine

Hello, I have a LUKS on LVM setup: /boot is unencrypted and everything is "hidden" in /dev/sda2. After booting on linux-next and just after entering my password cryptsetup segfaults and a stack trace is printed from the kernel. Since writing down all those numbers is hard I've made a picture where

Re: [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis

On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote: > Signed-off-by: Peng Sun Please always add a changelog message. Also, you need to fix the subject. The convention is to use something like: "a: b: ..." So in this case it should be something like: "staging: android: ..." You can look at

Re: [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis

On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote: Signed-off-by: Peng Sun sironhide0n...@gmail.com Please always add a changelog message. Also, you need to fix the subject. The convention is to use something like: a: b: ... So in this case it should be something like: staging: android:

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Better. Also, submit it again with proper commit message and put "PATCH v2" in the subject. > > Signed-off-by: Aparna Karuthodi > --- >

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Resubmit it properly with "PATCH v2" in the title and a good commit message. > > Signed-off-by: Aparna Karuthodi > --- >

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Resubmit it properly with PATCH v2 in the title and a good commit message. Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com ---

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Better. Also, submit it again with proper commit message and put PATCH v2 in the subject. Signed-off-by: Aparna Karuthodi

Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: > Made the comment into a new lineto remove a coding style error detected > by checkpatch. > The warning is given below: > drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters > > Signed-off-by: Aparna Karuthodi

Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: Made the comment into a new lineto remove a coding style error detected by checkpatch. The warning is given below: drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters Signed-off-by: Aparna Karuthodi

[PATCH v2] staging: ft1000: convert pack pragma to __packed

Convert a Microsoft compiler specific directive "#pragma pack(1)" to a GCC equivalent __packed. Also, by doing this we save ourselves from trouble if any other struct definitions are added after the #pragma because it will be applied to all of the definitions following it. Signed-off-by

[PATCH v2] staging: ft1000: convert pack pragma to __packed

Convert a Microsoft compiler specific directive #pragma pack(1) to a GCC equivalent __packed. Also, by doing this we save ourselves from trouble if any other struct definitions are added after the #pragma because it will be applied to all of the definitions following it. Signed-off-by: Giedrius

[PATCH] staging: ft1000: convert pack pragma to __packed__ attribute

following it. Signed-off-by: Giedrius Statkevičius --- drivers/staging/ft1000/ft1000-usb/ft1000_download.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c index 5def347..345c

[PATCH] staging: ft1000: convert pack pragma to __packed__ attribute

it. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/ft1000/ft1000-usb/ft1000_download.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c

Re: [PATCH] mfd: rtsx: add support for rts522A

On Thu, 16 Apr 2015, micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227. > Add it to file mfd/rts5227.c to support this chip. > > Signed-off-by: Micky Ching > --- Maybe update the Kconfig as well? So that the

Re: [PATCH] mfd: rtsx: add support for rts522A

On Thu, 16 Apr 2015, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227. Add it to file mfd/rts5227.c to support this chip. Signed-off-by: Micky Ching micky_ch...@realsil.com.cn --- Maybe

Re: [PATCH v2 1/2 RESEND] staging: dgnc: remove dead code in dgnc_tty_write()

On Sat, 11 Apr 2015, Sudip Mukherjee wrote: > On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote: > > Remove the dead code protected by in_user in dgnc_tty_write() because it is > > set > > to 0 and never changed to 1 thus the code in ifs never gets execu

Re: [PATCH v2 1/2 RESEND] staging: dgnc: remove dead code in dgnc_tty_write()

On Sat, 11 Apr 2015, Sudip Mukherjee wrote: On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote: Remove the dead code protected by in_user in dgnc_tty_write() because it is set to 0 and never changed to 1 thus the code in ifs never gets executed. dgnc_tty_write

[PATCH] staging: dgnc: remove some dead code from dgnc_tty.c

Remove some dead code that will never be executed or which serves no purpose Signed-off-by: Giedrius Statkevičius --- drivers/staging/dgnc/dgnc_tty.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index

[PATCH] staging: dgnc: remove some dead code from dgnc_tty.c

Remove some dead code that will never be executed or which serves no purpose Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers

[PATCH v4 1/3] staging: dgnc: clean up allocation of ->channels[i]

ent and check in the same loop because ->channels[i] isn't allocated anywhere else. Finally, remove a unnecessary check if ->channels[i] is NULL in the next loop because it can't be. Signed-off-by: Giedrius Statkevičius --- v4: Make this patch only for dgnc_tty.c and only for this thing. Spl

[PATCH v4 2/3] staging: dgnc: don't forget to check if ->channels[i] is NULL in dgnc_tty_uninit()

Add a check if ->channels[i] is NULL because a NULL pointer may be dereferenced in case one of the allocations failed Reported-by: Dan Carpenter Signed-off-by: Giedrius Statkevičius --- v4: new patch that fixes a bug reported by Dan Carpenter drivers/staging/dgnc/dgnc_tty.c | 8 ++--

[PATCH v4 3/3] staging: dgnc: remove redundant !ch checks

Remove checks that are redundant since we don't have boards with partially initialized ->channels[i]. Signed-off-by: Giedrius Statkevičius --- v4: splitted this from the one patch. drivers/staging/dgnc/dgnc_cls.c | 4 ++-- drivers/staging/dgnc/dgnc_neo.c | 2 +- 2 files changed, 3 inserti

Re: [PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Dan Carpenter wrote: > You will need to update the subject to reflect the new patch. > > The original code did check for kzalloc() failure but it had lots of > checks scattered around instead nicely at the point where the memory > was allocated. > There are a lot missing

Re: [PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 05:11:15PM +0300, Giedrius Statkevičius wrote: > > If one of the allocations of memory for storing a channel information struct > > fails then free all the successful allocations and return -ENOMEM that gets

[PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

obe failing if we can't allocate enough memory means that this scenario isn't possible. Signed-off-by: Giedrius Statkevičius --- v3: Remove the wrong comment at dgnc_tty_init() that says the allocation could happen somewhere else before this and remove the check if (!brd->channels[i]). Also, remo

Re: [PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Dan Carpenter wrote: > On Tue, Apr 07, 2015 at 03:40:17PM +0300, Giedrius Statkevičius wrote: > > If one of the allocations of memory for storing a channel information struct > > fails then free all the successful allocations and return -ENOMEM that gets

[PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

won't execute that if any of the allocations failed. Signed-off-by: Giedrius Statkevičius --- v2: Only returning -ENOMEM if an allocation failed isn't enough as it was spotted by Sudip so create a new label that frees all successfully allocated stuff and only then returns -ENOMEM. Also, remove

Re: [PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote: > > kzalloc() could fail so add a check and return -ENOMEM if it does that gets > > propogated to the pci layer > > > > Signed-off-by: Giedrius Statkev

[PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

kzalloc() could fail so add a check and return -ENOMEM if it does that gets propogated to the pci layer Signed-off-by: Giedrius Statkevičius --- drivers/staging/dgnc/dgnc_tty.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc

[PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

kzalloc() could fail so add a check and return -ENOMEM if it does that gets propogated to the pci layer Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_tty.c b

Re: [PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Sudip Mukherjee wrote: On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote: kzalloc() could fail so add a check and return -ENOMEM if it does that gets propogated to the pci layer Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com

[PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

won't execute that if any of the allocations failed. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Only returning -ENOMEM if an allocation failed isn't enough as it was spotted by Sudip so create a new label that frees all successfully allocated stuff and only

[PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

if we can't allocate enough memory means that this scenario isn't possible. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v3: Remove the wrong comment at dgnc_tty_init() that says the allocation could happen somewhere else before this and remove the check if (!brd

Re: [PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Sudip Mukherjee wrote: On Tue, Apr 07, 2015 at 05:11:15PM +0300, Giedrius Statkevičius wrote: If one of the allocations of memory for storing a channel information struct fails then free all the successful allocations and return -ENOMEM that gets propogated to the pci

Re: [PATCH v2] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Dan Carpenter wrote: On Tue, Apr 07, 2015 at 03:40:17PM +0300, Giedrius Statkevičius wrote: If one of the allocations of memory for storing a channel information struct fails then free all the successful allocations and return -ENOMEM that gets propogated to the pci

Re: [PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init()

On Tue, 7 Apr 2015, Dan Carpenter wrote: You will need to update the subject to reflect the new patch. The original code did check for kzalloc() failure but it had lots of checks scattered around instead nicely at the point where the memory was allocated. There are a lot missing too. For

[PATCH v4 2/3] staging: dgnc: don't forget to check if -channels[i] is NULL in dgnc_tty_uninit()

Add a check if -channels[i] is NULL because a NULL pointer may be dereferenced in case one of the allocations failed Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v4: new patch that fixes a bug reported by Dan

[PATCH v4 1/3] staging: dgnc: clean up allocation of -channels[i]

and check in the same loop because -channels[i] isn't allocated anywhere else. Finally, remove a unnecessary check if -channels[i] is NULL in the next loop because it can't be. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v4: Make this patch only for dgnc_tty.c and only

[PATCH v4 3/3] staging: dgnc: remove redundant !ch checks

Remove checks that are redundant since we don't have boards with partially initialized -channels[i]. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v4: splitted this from the one patch. drivers/staging/dgnc/dgnc_cls.c | 4 ++-- drivers/staging/dgnc/dgnc_neo.c | 2 +- 2

Re: [PATCH 1/2] staging: dgnc: remove dead code in dgnc_tty_write()

> to 0 and never changed to 1 thus the code in ifs never gets executed. > > Signed-off-by: Giedrius Statkevičius > --- > v2: Just remove the dead code protected by in_user and join the first and > third > patches. > > drivers/staging/dgnc/dgnc_tty.c | 45 > +

Re: [PATCH 1/2] staging: dgnc: remove dead code in dgnc_tty_write()

to 1 thus the code in ifs never gets executed. Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Just remove the dead code protected by in_user and join the first and third patches. drivers/staging/dgnc/dgnc_tty.c | 45

Re: [PATCH] staging: sm7xxfb: Fix sparse warning

On Sat, 4 Apr 2015, Nickolaus Woodruff wrote: > This patch fixes the following sparse warning in sm7xx.h: > > drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' > was not declared. Should it be static? > > Signed-off-by: Nickolaus Woodruff > --- >

Re: [PATCH] staging: sm7xxfb: Fix sparse warning

On Sat, 4 Apr 2015, Nickolaus Woodruff wrote: This patch fixes the following sparse warning in sm7xx.h: drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' was not declared. Should it be static? Signed-off-by: Nickolaus Woodruff nickolauswoodr...@gmail.com ---

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

On Sat, 4 Apr 2015, Andreas Theodosiou wrote: > This is a patch to the fb_ili9163.c file that inserts a line break in > line #92 to make the line fit into the 80 character limit. > > Signed-off-by: Andreas Theodosiou > --- > drivers/staging/fbtft/fb_ili9163.c | 3 ++- > 1 file changed, 2

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

On Sat, 4 Apr 2015, Andreas Theodosiou wrote: This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit. Signed-off-by: Andreas Theodosiou andreas...@gmail.com --- drivers/staging/fbtft/fb_ili9163.c | 3 ++- 1 file

Re: [PATCH] sm750fb: Fix Comment and if else braces

Hi Amitoj Kaur Chawla, On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: > The edits have been made to add a space before the comment and the errors in > braces in the if-else statements. > Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed > the C99 comments and errors in

Re: [PATCH] sm750fb: Fix C99 Comments and if else braces

Hi Amitoj Kaur Chawla, On 2015.03.19 19:39, Amitoj Kaur Chawla wrote: > The edits have been made to remove C99 Comments and properly indent > the if-else statements in the file while taking care of the braces according > to > Linux coding style. > > Signed-off-by: Amitoj Kaur Chawla > --- >

Re: [PATCH] sm750fb: Fix C99 Comments and if else braces

Hi Amitoj Kaur Chawla, On 2015.03.19 19:39, Amitoj Kaur Chawla wrote: The edits have been made to remove C99 Comments and properly indent the if-else statements in the file while taking care of the braces according to Linux coding style. Signed-off-by: Amitoj Kaur Chawla

Re: [PATCH] sm750fb: Fix Comment and if else braces

Hi Amitoj Kaur Chawla, On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: The edits have been made to add a space before the comment and the errors in braces in the if-else statements. Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed the C99 comments and errors in if-else

Re: [PATCH v2 1/7] dgnc: remove unused dgnc_ioctl_name() command

Greg, you probably missed these :) Could you look at these when you have some time? On 2015.03.13 15:56, Giedrius Statkevičius wrote: > dgnc_ioctl_name() is never used anywhere so remove it > > Signed-off-by: Giedrius Statkevičius > --- > v2: Forgot to include this patch in th

Re: [PATCH v2 1/7] dgnc: remove unused dgnc_ioctl_name() command

Greg, you probably missed these :) Could you look at these when you have some time? On 2015.03.13 15:56, Giedrius Statkevičius wrote: dgnc_ioctl_name() is never used anywhere so remove it Signed-off-by: Giedrius Statkevičius giedrius.statkevic...@gmail.com --- v2: Forgot to include

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

Hi Greg, On 2015.03.12 12:08, Greg KH wrote: > On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: >> Remove BOARD_FAILED and don't save dgnc_boards which failed to >> initialize. >> >> Assign the result of kzalloc() to brd in dgnc

Re: [PATCH 10/10] mach-osiris-dvs.c : use "&&" (not "&") with bool operands

On 2015.03.13 16:31, Ameen Ali wrote: > itwise AND ("&") was used > in logical expressions with operands having "bool" type. Replaced > bitwise AND operators with logical AND. > > Signed-off-by : Always use checkpatch to check the .patch for these kinds of issues. Also the Subject: is not

  1   2   >