On Tue, Apr 20, 2021 at 11:02 AM Sakari Ailus
wrote:
>
> Hi Bingbu,
>
> Thanks for the patch.
>
> On Tue, Apr 20, 2021 at 10:48:33AM +0800, Bingbu Cao wrote:
> > Intel IPU(Image Processing Unit) has its own (IO)MMU hardware,
> > The IPU driver allocates its own page table that is not mapped
> > vi
[Key part of Andew's reply: "Yes, this discussion should not prevent
this patchset from being merged."]
On Tue, Apr 6, 2021 at 1:00 PM Andrew Lunn wrote:
>
> > > Speed: 2500Mb/s and Duplex: Half is very unlikely. You really only
> > > ever see 10 Half and occasionally 100 Half. Anything above tha
On Tue, Apr 6, 2021 at 12:09 AM Andrew Lunn wrote:
>
> On Mon, Apr 05, 2021 at 04:13:40PM -0700, Grant Grundler wrote:
> > This series introduces support for USB network devices that report
> > speed as a part of their protocol, not emulating an MII to be accessed
> &g
On Tue, Mar 30, 2021 at 2:17 AM Grant Grundler wrote:
>
> This series introduces support for USB network devices that report
> speed as a part of their protocol, not emulating an MII to be accessed
> over MDIO.
>
> v2: rebased on recent upstream changes
> v3: incorporate
replaces the one
recently submitted in de658a195ee23ca6aaffe197d1d2ea040beea0a2 :
"net: usb: cdc_ncm: don't spew notifications"
v2: rebased on upstream
v3: changed variable names
v4: rewrote commit message
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Signed-off-by:
framework to use the new functions to get link speed/state.
User space can now get the most recent link speed/state using ethtool.
v4: added to series since cdc_ether uses same notifications
as cdc_ncm driver.
Signed-off-by: Grant Grundler
Reviewed-by: Andrew Lunn
---
drivers/net/usb
ed on upstream
v3: changed names and made clear which units are used
v4: moved hunks to correct patch; rewrote commmit messages
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by: Grant Grundler
Reviewed-by: Andrew Lunn
---
drivers/net/usb/usbnet.c
rename
the existing functions with _mii suffix.
v2: rebased on changed upstream
v3: changed names to clearly say that this does NOT use phylib
v4: moved hunks to correct patch; reworded commmit messages
Signed-off-by : Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by
This series introduces support for USB network devices that report
speed as a part of their protocol, not emulating an MII to be accessed
over MDIO.
v2: rebased on recent upstream changes
v3: incorporated hints on naming and comments
v4: fix misplaced hunks; reword some commit messages;
add sa
replaces the one
recently submitted in de658a195ee23ca6aaffe197d1d2ea040beea0a2 :
"net: usb: cdc_ncm: don't spew notifications"
v2: rebased on upstream
v3: changed variable names
v4: rewrote commit message
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Signed-off-by:
From: Grant Grundler
Until very recently, the usbnet framework only had support functions
for devices which reported the link speed by explicitly querying the
PHY over a MDIO interface. However, the cdc_ether devices send
notifications when the link state or link speeds change and do not
expose
ed on upstream
v3: changed names and made clear which units are used
v4: moved hunks to correct patch; rewrote commmit messages
Signed-off-by: Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by: Grant Grundler
---
drivers/net/usb/usbnet.c
rename
the existing functions with _mii suffix.
v2: rebased on changed upstream
v3: changed names to clearly say that this does NOT use phylib
v4: moved hunks to correct patch; reworded commmit messages
Signed-off-by : Oliver Neukum
Tested-by: Roland Dreier
Reviewed-by: Grant Grundler
Tested-by
This series introduces support for USB network devices that report
speed as a part of their protocol, not emulating an MII to be accessed
over MDIO.
v2: rebased on recent upstream changes
v3: incorporated hints on naming and comments
v4: fix misplaced hunks; reword some commit messages;
add sa
Errors in protocol should be logged when the driver aborts operations.
If the driver can carry on and "humor" the device, then emitting
the message as debug output level is fine.
Signed-off-by: Grant Grundler
---
drivers/net/usb/usbnet.c | 2 +-
1 file changed, 1 insertion(+),
Several error paths in bind/probe code will only emit
output using dev_dbg. But if we are going to fail the
bind/probe, emit related output with "err" priority.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 10 +-
1 file changed, 5 insertions(+), 5
On Wed, Jan 20, 2021 at 5:04 PM Jakub Kicinski wrote:
>
> On Wed, 20 Jan 2021 03:38:32 + Hayes Wang wrote:
> > Grant Grundler
> > > Sent: Wednesday, January 20, 2021 9:12 AM
> > > Subject: [PATCH net] net: usb: cdc_ncm: don't spew notifications
> >
On Wed, Jan 20, 2021 at 1:05 AM Jakub Kicinski wrote:
>
> On Wed, 20 Jan 2021 00:59:17 + Grant Grundler wrote:
> > > > Thanks for the patch, this looks like an improvement over:
> > > >
> > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected"
mbit/s uplink
...
Chrome OS cannot support RTL8156 until this is fixed.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 12 +++-
include/linux/usb/usbnet.h | 2 ++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cd
On Wed, Jan 20, 2021 at 12:55 AM Grant Grundler wrote:
>
> On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote:
> >
> > On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote:
> > > RTL8156 sends notifications about every 32ms.
> > > Only display/log
On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote:
>
> On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote:
> > RTL8156 sends notifications about every 32ms.
> > Only display/log notifications when something changes.
> >
> > This issue has been repor
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote:
>
> RTL8156 sends notifications about every 32ms.
> Only display/log notifications when something changes.
>
> This issue has been reported by others:
> https://
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote:
>
> Errors in protocol should be logged when the driver aborts operations.
> If the driver can carry on and "humor" the device, then emitting
> the message as debu
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:26 AM Grant Grundler wrote:
>
> Several error paths in bind/probe code will only emit
> output using dev_dbg. But if we are going to fail the
> bind/probe, emit related output with "err" prior
Several error paths in bind/probe code will only emit
output using dev_dbg. But if we are going to fail the
bind/probe, emit related output with "err" priority.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletion
mbit/s uplink
...
Chrome OS cannot support RTL8156 until this is fixed.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 12 +++-
include/linux/usb/usbnet.h | 2 ++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cd
Errors in protocol should be logged when the driver aborts operations.
If the driver can carry on and "humor" the device, then emitting
the message as debug output level is fine.
Signed-off-by: Grant Grundler
---
drivers/net/usb/usbnet.c | 2 +-
1 file changed, 1 insertion(+),
Adding linux-...@vger.kernel.org since Andy's email in MAINTAINERs bounced.
Using Matthew's personal email since his codeaurora email bounced.
On Mon, Sep 7, 2020 at 11:35 PM Grant Grundler wrote:
>
> Alban, Andy,
> Can you please apply this patch series from 2018 or please e
nding-documen.patch
...
In 2018, Rob Herring reviewed (and approved):
[V2,1/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document
I've just reviewed 2/3 and 3/3. You can add to those:
Reviewed-by: Grant Grundler
I compared 3/3 with the DTS entries that were submitted (and I
approved) t
On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee wrote:
>
> >-Original Message-
> >From: Mark Brown
> >Sent: Wednesday, November 28, 2018 1:50 AM
> >To: Ryan Lee
> >Cc: Liam Girdwood ; Jaroslav Kysela
> >; Takashi Iwai ; Grant Grundler
> >; Kun
I just realized I had one more question...
On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler wrote:
>
> Hi Ryan!
>
> Just some questions inline - in general I like the reset function.
>
> On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee
> wrote:
> >
> > Signed-off-b
Hi Ryan!
Just some questions inline - in general I like the reset function.
On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee wrote:
>
> Signed-off-by: Ryan Lee
> ---
> Changes : Created max98373_reset function to minimize code duplication.
>Changed regmap_write to regmap_update_bits. Othe
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote:
>
> On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote:
> > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote:
>
> > > Note that this isn't causing a warning upstream, presumably due to an
> > > im
[resending as plain/text - sorry]
On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote:
>
>
>
> On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote:
>>
>> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
>> > Commit ca917f9fe1a0fab added use o
ion of function 'usleep_range'
[-Werror,-Wimplicit-function-declaration]
usleep_range(1, 11000);
^
Including delay.h "fixes" this.
Signed-off-by: Grant Grundler
---
sound/soc/codecs/max98373.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/c
On Thu, Apr 26, 2018 at 12:56 AM, Krzysztof Kozlowski wrote:
> On Thu, Apr 26, 2018 at 2:40 AM, Grant Grundler wrote:
>> On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski
>> wrote:
>>>
>>> commit 90841047a01b452cc8c3f9b990698b264143334a upstream
>>>
t;
> Signed-off-by: Grant Grundler
> Reviewed-by: Douglas Anderson
> Signed-off-by: David S. Miller
> [krzk: Rebase on v4.4]
> Signed-off-by: Krzysztof Kozlowski
thanks krzk!
FTR, to support RTL8153B (HW ID 0x6010), the follow patch series to
bring r8152 v1.09.9 driver from 4.14 ke
On Sun, Oct 1, 2017 at 10:39 PM, David Miller wrote:
> From: Grant Grundler
> Date: Thu, 28 Sep 2017 11:35:00 -0700
>
>> This linksys dongle by default comes up in cdc_ether mode.
>> This patch allows r8152 to claim the device:
>>Bus 002 Device 002: ID 13b1:0041
This linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ether.c | 10 ++
drivers/net/usb/r8152.c | 2 ++
2 files changed, 12 insertions
Hi Doug!
On Wed, Sep 27, 2017 at 4:47 PM, Doug Anderson wrote:
> Hi,
>
> On Wed, Sep 27, 2017 at 10:28 AM, Grant Grundler
> wrote:
>> This linksys dongle by default comes up in cdc_ether mode.
>> This patch allows r8152 to claim the device:
>>Bus 002 De
This linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ether.c | 10 ++
drivers/net/usb/r8152.c | 2 ++
2 files changed, 12 insertions
On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote:
> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson:
>>
>> I know that for at least some of the adapters in the CDC Ethernet
>> blacklist it was claimed that the CDC Ethernet support in the adapter
>> was kinda broken anyway so th
On Mon, Sep 25, 2017 at 1:17 PM, Grant Grundler wrote:
...
> I didn't realize cdc_ether has a blacklist to make sure
> RTL8152|RTL8153 devices are not picked up by cdc_ether. Would you
> prefer I add this device to the blacklist in the same patch?
I've sent a V2 which also up
This linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ether.c | 8
drivers/net/usb/r8152.c | 2 ++
2 files changed, 10 insertions
[grrhmail...sorry! resending as plain text]
Hallo Oliver!
On Mon, Sep 25, 2017 at 7:51 AM, Oliver Neukum wrote:
> Am Freitag, den 22.09.2017, 12:06 -0700 schrieb Grant Grundler:
> > This Linksys dongle by default comes up in cdc_ether mode.
> > This patch allows r8152 to c
This Linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/r8152.c | 2 ++
1 file changed, 2 insertions(+)
This was tested on chromeos-3.14, chromeos-3.18
On Fri, Jul 14, 2017 at 2:35 PM, Daniel Vetter wrote:
> On Fri, Jul 14, 2017 at 7:32 PM, Grant Grundler wrote:
>> On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula
>> wrote:
>>> On Thu, 13 Jul 2017, Stéphane Marchesin
>>> wrote:
>>>> So, if you think
On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula
wrote:
> On Thu, 13 Jul 2017, Stéphane Marchesin wrote:
>> So, if you think this is wrong, can you fix this warning in a way that
>> you'd like?
>
> As I replied previously [1], with more background, fixing the warnings
> properly, in a way that actual
On Fri, May 5, 2017 at 1:08 PM, Ville Syrjälä
wrote:
...
>> > I'm not convinced the patch is making things any better really. To
>> > fix this really properly, I think we'd need to introduce a new enum
>> > pch_transcoder and thus avoid the confusion of which type of
>> > transcoder we're talking
On Fri, May 5, 2017 at 10:40 AM, Ville Syrjälä
wrote:
> On Fri, May 05, 2017 at 10:26:36AM -0700, Matthias Kaehlcke wrote:
>> El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit:
>>
>> > In several instances the driver passes an 'enum pipe' value to a
>> > function expecting an 'enum
On Thu, Mar 23, 2017 at 11:54 PM, Greg Kroah-Hartman
wrote:
> On Thu, Mar 23, 2017 at 02:47:39PM -0700, Grant Grundler wrote:
>> On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote:
>> > Matthias Kaehlcke wrote:
>> >> The value passed by the two callers of t
On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote:
> Matthias Kaehlcke wrote:
>> The value passed by the two callers of the function is unsigned anyway.
>
> Indeed; and those are just simple wrappers.
>
>> Making the parameter unsigned fixes the following warning when building
>> with clang:
Ping? Any feedback on this patch?
Is this in someone's queue for review?
thanks,
grant
On Tue, Mar 14, 2017 at 12:40 PM, Matthias Kaehlcke wrote:
> jiffies_64 is defined in kernel/time/timer.c with
> cacheline_aligned_in_smp,
> however this macro is not part of the declaration of jiffies an
On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore wrote:
> On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote:
>> Ping? Any feedback on this patch?
>
> It's on my list of patches to review, patience please.
No problem! Thank you!
just wanted confirmation it wasn't o
[resending as plain text only - sorry]
Ping? Any feedback on this patch?
LGTM.
cheers,
grant
On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote:
> 'perms' will never be NULL since it isn't a plain pointer but an array
> of u32 values.
>
> This fixes the following warning when building wi
Local "#define DRIVER_LICENSE" obfuscates which license is used
in MODULE_LICENSE(). "fgrep -R MODULE_LICENSE" is more informative
when the string is hard coded in MODULE_LICENSE.
Signed-off-by: Grant Grundler
---
Most of the kernel already uses hard coded strings.
The few p
On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote:
> On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote:
>
>> I'm not quite sure how the first From line was added, it
>> should not have been.
>> Grant Grundler is most definitely the author.
>>
>> Woul
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote:
...
> Thanks for the feedback (for this patch and the other ones)!
> I'm preparing a v2 and will submit it withing a day or two.
Excellent! very welcome and thanks again for picking this up.
...
>> FTR, current drivers/net/usb/ax88179_178a.c u
-review.googlesource.com/#/q/Fix+AX88772x+resume+failures
And has substantial meta data regarding author and reviewers:
(summarized from https://chromium-review.googlesource.com/#/c/314520/)
Signed-off-by: Allan Chou
Signed-off-by: WK Tsai
Tested-by: Grant Grundler
Reviewed-by: Wang-Kai Tsai
On Mon, Jul 25, 2016 at 10:40 AM, wrote:
> From: Vincent Palatin
>
> Check the answers from the USB stack and avoid re-sending multiple times
> the request if the device has disappeared.
>
> Signed-off-by: Vincent Palatin
The original chromium.org code review:
https://chromium-review.googl
[as plain text this time...]
Robert,
On Mon, Jul 25, 2016 at 10:40 AM, wrote:
> From: Grant Grundler
For the record, I believe I am not the author of these patches.
I believe the original author is
Signed-off-by: Freddy Xin
as recorded in the following code reviews (and testing) t
On Fri, Jul 15, 2016 at 2:25 PM, David Miller wrote:
> From: Grant Grundler
> Date: Thu, 14 Jul 2016 11:27:16 -0700
>
>> ethtool -i provides a driver version that is hard coded.
>> Export the same value via "modinfo".
>>
>> Signed-off-by: Grant Gr
ethtool -i provides a driver version that is hard coded.
Export the same value via "modinfo".
Signed-off-by: Grant Grundler
---
drivers/net/usb/r8152.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0da72d3..1c01ed5 10
On Thu, Jun 2, 2016 at 5:27 PM, Gwendal Grignou wrote:
> If available, eMMC stack uses HC_ERASE_GRP_SIZE as preferred erase size.
> However, that size is the minimal size we must use, not the optimal size.
> Calculate the optimal size based on whole device size and fall back to
> HC_ERASE_GRP_SIZE
Hayes Wang realtek.com> writes:
> Replace using VID/PID with using tp->version to initialize the ops.
Hayes,
This patch breaks new HW with existing drivers. more below.
>
> Signed-off-by: Hayes Wang realtek.com>
> ---
> drivers/net/usb/r8152.c | 79 ++--
On Wed, May 18, 2016 at 2:59 PM, Dmitry Torokhov
wrote:
> On Wed, May 18, 2016 at 11:44:04AM -0500, Rob Herring wrote:
>> On Mon, May 16, 2016 at 01:54:53PM -0700, Grant Grundler wrote:
>> > From: Daniel Hung-yu Wu
>> >
>> > Add binding for Atmel Capacitive T
On Wed, May 18, 2016 at 2:59 PM, Dmitry Torokhov
wrote:
> On Tue, May 17, 2016 at 12:29:32PM -0700, Grant Grundler wrote:
>> From: Daniel Hung-yu Wu
>>
>> Add I2C driver for Atmel Capacitive Touch Button device.
>>
>> Signed-off-by: Hung-yu Wu
>> Sig
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 13 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 13 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
From: Daniel Hung-yu Wu
Add binding for Atmel Capacitive Touch Button device.
Signed-off-by: Daniel Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../devicetree/bindings/input/atmel,captouch.txt | 36 ++
1 file changed, 34 insertions(+)
create mode 100644 Documentation
On Sat, May 14, 2016 at 7:52 AM, Rob Herring wrote:
> On Tue, May 10, 2016 at 07:07:48PM -0700, Grant Grundler wrote:
>> From: Daniel Hung-yu Wu
>>
>> Add binding for Atmel Capacitive Touch Button device.
>>
>> Signed-off-by: Daniel Hung-yu Wu
[plain text this time...]
On Sat, May 14, 2016 at 9:35 AM, Wim Van Sebroeck wrote:
>
> Hi Guenter,
>
> > The Qualcom watchdog timer block reports if the system was reset by the
> > watchdog. Pass the information to user space.
> >
> > Cc: Grant Grundler
Ping? Any additional feedback?
We've been holding off putting this code into ChromeOS since I'm happy
to integrate (just about) any addtional feedback on the code or DT
entries.
thanks!
grant
On Tue, May 10, 2016 at 7:07 PM, Grant Grundler wrote:
> From: Daniel Hung-yu Wu
>
From: Daniel Hung-yu Wu
Add binding for Atmel Capacitive Touch Button device.
Signed-off-by: Daniel Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../devicetree/bindings/input/atmel,captouch.txt | 34 ++
1 file changed, 34 insertions(+)
create mode 100644 Documentation
From: Daniel Hung-yu Wu
Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
drivers/input/misc/Kconfig | 11 ++
drivers/input/misc/Makefile | 1 +
drivers/input/misc/atmel_captouch.c | 287
On Mon, May 9, 2016 at 9:29 AM, Dmitry Torokhov
wrote:
> On Fri, May 06, 2016 at 11:14:12PM +0800, Daniel Hung-yu Wu wrote:
>> The register set is different, and this chip does not support calibration.
>> The I2C protocol is not the same as well; there is an additional byte
>> indicating data leng
On Fri, May 6, 2016 at 2:19 AM, Nicolas Ferre wrote:
...
> Is it different from the Atmel QT1070 or QT2160 which have drivers
> already available in Linux: drivers/input/keyboard/qt1070.c
Yes. What Daniel said. I would describe it as "probe code and
interrupt handling protocol are different" f
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote:
...
>> +Required properties:
>> +
>> + compatible: Must be "atmel,atmegaxx_captouch".
>
> No wildcards in the compatible strings. Use the specific devices.
>
> Also, use hyphen rather than underscore. However, if the device is only
> a tou
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote:
> On Tue, May 03, 2016 at 10:13:31AM -0700, Grant Grundler wrote:
>> Add I2C driver for AtmegaXX capacitive touch device.
>>
>> Signed-off-by: Hung-yu Wu
>> Signed-off-by: Grant Grundler
>> ---
>> .../bin
On Tue, May 3, 2016 at 7:01 PM, Guenter Roeck wrote:
> On 05/03/2016 06:36 PM, Grant Grundler wrote:
>>
>> Ping? Did this change get accepted?
>>
>
> Hi Grant,
>
> Should be. It is in my watchdog-next branch. I plan to send
> a pull request to Wim early next w
Ping? Did this change get accepted?
cheers,
grant
On Tue, Apr 5, 2016 at 12:07 PM, Grant Grundler wrote:
> On Mon, Apr 4, 2016 at 5:37 PM, Guenter Roeck wrote:
>> The Qualcom watchdog timer block reports if the system was reset by the
>> watchdog. Pass the information to user
Add I2C driver for AtmegaXX capacitive touch device.
Signed-off-by: Hung-yu Wu
Signed-off-by: Grant Grundler
---
.../bindings/input/atmel,atmegaxx_captouch.txt | 34 +++
drivers/input/misc/Kconfig | 11 +
drivers/input/misc/Makefile| 1
On Mon, Apr 4, 2016 at 5:37 PM, Guenter Roeck wrote:
> The Qualcom watchdog timer block reports if the system was reset by the
> watchdog. Pass the information to user space.
>
> Cc: Grant Grundler
> Signed-off-by: Guenter Roeck
Reviewed-by: Grant Grundler
Tested-by: Grant Gr
On Tue, Dec 1, 2015 at 12:44 PM, Helge Deller wrote:
> On 01.12.2015 17:41, Bjorn Helgaas wrote:
>> There are no callers of pcibios_init_bus(), so remove it.
>
> True, pcibios_init_bus() isn't called anywhere, so it should be removed.
>
> But I wonder if we might need to initialize latency and par
On Thu, Nov 19, 2015 at 6:29 PM, Florian Fainelli wrote:
> On 19/11/15 17:56, Grant Grundler wrote:
>> From: Grant Grundler
>>
>> I haven't had any PCI tulip HW for the past ~5 years. I have
>> been reviewing tulip patches and can continue doing that.
>
From: Grant Grundler
I haven't had any PCI tulip HW for the past ~5 years. I have
been reviewing tulip patches and can continue doing that.
Signed-off-by: Grant Grundler
---
I'm also proposing to add linux-parisc to the list since AFAIK, all
parisc systems but the C8000 workstatio
On Fri, Nov 6, 2015 at 4:22 AM, Vishnu Pratap Singh
wrote:
> This patch handles blk_register_region() return value.
> Earlier blk_register_region() function doesn't handle error
> cases, now it is added, so the callers of this function
> should also handle it.
>
> Verfied on X86 based ubuntu machi
On Tue, Oct 20, 2015 at 11:57 AM, Jeff Moyer wrote:
> Hi Grant,
>
> Grant Grundler writes:
>
>> Ping? Does no one care how long BLK_SECDISCARD takes?
>>
>> ChromeOS has landed this change as a compromise between "fast" (<10
>> seconds) and &quo
On Wed, Oct 21, 2015 at 2:00 AM, Ulf Hansson wrote:
To put a few more numbers on the "chunk size vs perf":
1EG (512KB) -> 44K commands -> ~20 minutes
32EG (16MB) -> 1375 commands -> ~1 minute
128EG (64MB) -> 344 commands -> ~30 seconds
8191EG (~4GB) -> 6 commands ->
roblem if we care about data privacy since
consumers won't expect a "secure erase" operation to take 1/2h or more
and think the device is hung.
cheers,
grant
On Mon, Sep 28, 2015 at 2:45 PM, Grant Grundler wrote:
> [resending...I forgot to switch gmail back to text-only mode.
Awesome! Thanks Ulf! :)
cheers
grant
On Mon, Oct 5, 2015 at 3:55 AM, Ulf Hansson wrote:
> On 24 September 2015 at 03:30, Grant Grundler wrote:
>> MMC_IOC_CMD and MMC_IOC_MULTI_CMD ioctl() code currently bails on
>> any eMMC errors. However, in case there is any resp[] dat
[resending...I forgot to switch gmail back to text-only mode. grrrh..]
-- Forwarded message --
From: Grant Grundler
Date: Mon, Sep 28, 2015 at 2:42 PM
Subject: Re: RFC: 32-bit __data_len and REQ_DISCARD+REQ_SECURE
To: Grant Grundler
Cc: Jens Axboe , Ulf Hansson
, LKML ,
"
t sure I need to do anything about references
to bio_iter.bi_size.
cheers,
grant
On Tue, Sep 22, 2015 at 6:54 PM, Grant Grundler wrote:
> Jens, Ulf,
>
> I've run into a basic issue: BLK_SECDISCARD takes 15-35 minutes
> perform a secure erase of ~23GB (mostly empty) partitio
in both cases.
Gwendal Grignou provided the idea and it was previously implemented
and tested on v3.18 ChromeOS kernel:
https://chromium-review.googlesource.com/#/c/299956
Signed-off-by: Grant Grundler
Reviewed-by: Hyung Taek Ryoo
Reviewed-by: Gwendal Grignou
Tested-by: David Riley
---
I
On Wed, Sep 23, 2015 at 3:26 PM, Ulf Hansson wrote:
...
>> Ulf,
>> is the git repo visible publicly?
>
> git://git.linaro.org/people/ulf.hansson/mmc.git
Sorry - my bad : I had looked at mmc.git and saw "2014-10-15" as the
last commit.
Scrolling down to the bottom of the page shows the "next" bra
On Wed, Sep 23, 2015 at 2:42 PM, Ulf Hansson wrote:
> On 22 September 2015 at 11:27, Jon Hunter wrote:
>> Certain eMMC devices allow vendor specific device information to be read
>> via a sequence of vendor commands. These vendor commands must be issued
>> in sequence and an atomic fashion. One w
On Wed, Sep 23, 2015 at 2:42 PM, Ulf Hansson wrote:
> On 22 September 2015 at 11:27, Jon Hunter wrote:
>> Certain eMMC devices allow vendor specific device information to be read
>> via a sequence of vendor commands. These vendor commands must be issued
>> in sequence and an atomic fashion. One w
Jens, Ulf,
I've run into a basic issue: BLK_SECDISCARD takes 15-35 minutes
perform a secure erase of ~23GB (mostly empty) partition on a 32GB
eMMC part (happens with two vendors). One of the vendors says it
should take less than 60 seconds. I've confirmed erasing 2GB takes
only ~6 seconds - so the
Jon, Ulf,
Can we first get the current implementation upstream and _then_ add
more patches to it?
On Mon, Sep 21, 2015 at 4:19 AM, Jon Hunter wrote:
...
+ for (i = 0; i < num_of_cmds; i++) {
+ err = __mmc_blk_ioctl_cmd(card, md, idata[i]);
+ if (er
>
> Signed-off-by: Seshagiri Holi
> Cc: Arnd Bergmann
> Cc: Grant Grundler
> Cc: Olof Johansson
> [ jonath...@nvidia.com: Rebased on linux-next from v3.18. Changed
> userspace pointer type for multi command to be a u64. Renamed
> from combo commands to multi com
1 - 100 of 328 matches
Mail list logo
