Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:47:17PM +, Nava kishore Manne wrote: > Hi Greg, > > Please find my response inline. > > > -Original Message----- > > From: Greg KH > > Sent: Tuesday, April 20, 2021 2:21 PM > > To: Nava kishore Manne > > Cc

Re: [PATCH 2/5] misc: zynq: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:36:51PM +, Nava kishore Manne wrote: > Hi Greg, > > Please find my response inline. > > > -Original Message----- > > From: Greg KH > > Sent: Tuesday, April 20, 2021 2:17 PM > > To: Nava kishore Manne > > Cc

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:41:53PM +0530, Nava kishore Manne wrote: > This patch adds zynqmp afi config driver.This is useful for > the configuration of the PS-PL interface on Zynq US+ MPSoC > platform. > > Signed-off-by: Nava kishore Manne > --- > drivers/misc/Kconfig | 11 ++ >

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:41:53PM +0530, Nava kishore Manne wrote: > This patch adds zynqmp afi config driver.This is useful for > the configuration of the PS-PL interface on Zynq US+ MPSoC > platform. Again, please spell out what those terms mean, as I have no idea :( > > Signed-off-by: Nava

Re: [PATCH 2/5] misc: zynq: Add afi config driver

2021-04-20 Thread Greg KH
On Tue, Apr 20, 2021 at 01:41:50PM +0530, Nava kishore Manne wrote: > This patch adds zynq afi config driver. This is useful for > the configuration of the PS-PL interface on zynq platform. What is "PS-PL"? Can you describe it better please? > > Signed-off-by: Nava kishore Manne > --- >

Re: [PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order

2021-04-20 Thread Greg KH
On Tue, Apr 06, 2021 at 06:35:17PM -0500, Aditya Pakki wrote: > The resource release in sm501fb_remove() is not in the inverse order of > sm501fb_probe(), for the buffers. Release the info object after > deallocating the buffers. > > Signed-off-by: Aditya Pakki > --- >

Re: [PATCH] scsi: be2iscsi: Reset the address passed in beiscsi_iface_create_default

2021-04-20 Thread Greg KH
On Tue, Apr 06, 2021 at 07:24:45PM -0500, Aditya Pakki wrote: > if_info is a local variable that is passed to beiscsi_if_get_info. In > case of failure, the variable is free'd but not reset to NULL. The patch > avoids security issue by passing NULL to if_info. That is just not true at all. Stop

Re: [PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-20 Thread Greg KH
On Tue, Apr 06, 2021 at 07:16:56PM -0500, Aditya Pakki wrote: > In gss_pipe_destroy_msg(), in case of error in msg, gss_release_msg > deletes gss_msg. The patch adds a check to avoid a potential double > free. > > Signed-off-by: Aditya Pakki > --- > net/sunrpc/auth_gss/auth_gss.c | 3 ++- > 1

Re: linux-next: manual merge of the rust tree with the char-misc tree

2021-04-16 Thread Greg KH
On Fri, Apr 16, 2021 at 05:58:06PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rust tree got a conflict in: > > include/uapi/linux/android/binder.h > > between commits: > > 432ff1e91694 ("binder: BINDER_FREEZE ioctl") > ae28c1be1e54 ("binder:

Re: [PATCH 0/1] coresight: Fix for v5.12-rc7

2021-04-16 Thread Greg KH
On Fri, Apr 16, 2021 at 08:54:00AM +0200, Greg KH wrote: > On Thu, Apr 15, 2021 at 02:24:03PM -0600, Mathieu Poirier wrote: > > Hi Greg, > > > > Please consider this patch as a fix for v5.12-rc7. Applies cleanly > > to your char-misc-linus branch (e49d033bddf5). >

Re: [PATCH 0/1] coresight: Fix for v5.12-rc7

2021-04-16 Thread Greg KH
On Thu, Apr 15, 2021 at 02:24:03PM -0600, Mathieu Poirier wrote: > Hi Greg, > > Please consider this patch as a fix for v5.12-rc7. Applies cleanly > to your char-misc-linus branch (e49d033bddf5). It's too late for 5.12-final, and really my tree should be closed for 5.13-rc1 now. I can sneak

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-15 Thread Greg KH
On Fri, Apr 16, 2021 at 10:43:34AM +0800, liulongfang wrote: > On 2021/4/15 20:34, Greg KH wrote: > > On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: > >> When the number of ports on the USB hub is 0, skip the registration > >> operation of the USB hub.

Re: [PATCH v2 4/5] staging: rtl8192e: rectified spelling mistake and replace memcmp with ether_oui_equal

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 07:12:47PM +0530, Mitali Borkar wrote: > On Wed, Apr 14, 2021 at 10:16:59AM +0200, Greg KH wrote: > > On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote: > > > Added a generic function of static inline bool in > > > include/linux/ethe

Re: backport patches to linux-5.4.y

2021-04-15 Thread Greg KH
On Tue, Apr 13, 2021 at 02:11:54PM +0200, Anders Roxell wrote: > Hi, > > Can these patches be backported to linux-5.4.y, I've tried to build > perf on arm and it failed without these patches. > fc8c0a992233 ("perf tools: Use %define api.pure full instead of %pure-parser") > 20befbb10803 ("perf

Re: [RFC PATCH] USB:XHCI:skip hub registration

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 08:22:38PM +0800, Longfang Liu wrote: > When the number of ports on the USB hub is 0, skip the registration > operation of the USB hub. That's crazy. Why not fix the hardware? How has this hub passed the USB certification process? > The current Kunpeng930's XHCI

Re: [PATCH v3] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 07:48:56PM +0800, chris.c...@canonical.com wrote: > From: Chris Chiu > > Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work > after the system resumes from suspend with remote wakeup enabled > device connected: > [ 1947.640907] hub 5-2.3:1.0:

Re: [GIT PULL] interconnect changes for 5.13

2021-04-15 Thread Greg KH
On Thu, Apr 15, 2021 at 11:09:48AM +0300, Georgi Djakov wrote: > Hello Greg, > > This is the pull request with the interconnect changes for the 5.13-rc1 > merge window. These include two new drivers. > > Patches have been in linux-next without any reported issues. Please pull > into

Re: [GIT PULL]: Generic phy updates for v5.13 -second round

2021-04-15 Thread Greg KH
On Wed, Apr 14, 2021 at 08:47:33PM +0530, Vinod Koul wrote: > Hi Greg, > > As promised, here are some minor fixes for earlier pull request. This > includes fixes which came in after the request was sent > > The following changes since commit cbc336c09b6d6dfb24d20c955599123308fa2fe2: > > phy:

Re: [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 10:49:41AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > UIO HV driver should not load in the isolation VM for security reason. > Return ENOTSUPP in the hv_uio_probe() in the isolation VM. > > Signed-off-by: Tianyu Lan > --- > drivers/uio/uio_hv_generic.c | 5 + >

Re: [RFC V2 PATCH 8/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 11:20:19PM +0800, Tianyu Lan wrote: > Hi Greg: > Thanks for your review. > > On 4/14/2021 12:00 AM, Greg KH wrote: > > On Tue, Apr 13, 2021 at 11:22:13AM -0400, Tianyu Lan wrote: > > > From: Tianyu Lan > > > > > > UIO

Re: [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 11:43:41AM +0200, Fabio Aiuto wrote: > On Wed, Apr 14, 2021 at 10:26:01AM +0200, Greg KH wrote: > > > - DBG_871X_SEL_NL(sel, "%10s %16s %8s %10s %11s %14s\n", > > > - "TH_L2H_ini", "TH_EDCCA_HL_diff&quo

Re: [PATCH v6 1/2] staging: rtl8192e: remove parentheses around boolean expression

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 12:51:55PM +0530, Mitali Borkar wrote: > Removed unnecessary parentheses around '!xyz' boolean expression as '!' > has higher precedance than '||' > > Signed-off-by: Mitali Borkar > --- This series does not apply to my tree :(

Re: [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()

2021-04-14 Thread Greg KH
On Tue, Apr 13, 2021 at 04:56:32PM +0200, Fabio Aiuto wrote: > replace DGB_871X_SEL_NL macro with netdev_dbg(). > > DBG_871X_SEL_NL macro expands to a raw prink call or a > seq_printf if selected stream _is not_ a local > debug symbol set to null. > This second scenario never occurs so replace >

Re: [PATCH 5/7] staging: rtl8723bs: put a new line after ';'

2021-04-14 Thread Greg KH
On Tue, Apr 13, 2021 at 04:56:33PM +0200, Fabio Aiuto wrote: > fix the following post commit hook checkpatch issue: > > ERROR: space required after that ';' (ctx:VxV) > 232: FILE: drivers/staging/rtl8723bs/core/rtw_odm.c:160: > +"AdapEn_RSSI", "IGI_LowerBound");netdev_dbg >

Re: Subject: [PATCH v2 0/5] staging: rtl8192e: CLeanup patchset for style issues in rtl819x_Y.c files

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 12:24:44PM +0530, Mitali Borkar wrote: > Changes from v1:- Dropped 6/6 from and made this as a patchset of 5 as > alignment of code is done in following patches. Why is "Subject:" listed in your subject line? Do not manually add it after git format-patch has created it...

Re: [PATCH v2 4/5] staging: rtl8192e: rectified spelling mistake and replace memcmp with ether_oui_equal

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 12:26:01PM +0530, Mitali Borkar wrote: > Added a generic function of static inline bool in > include/linux/etherdevice.h to replace memcmp with > ether_oui_equal throughout the execution. > Corrected the misspelled words in this file. > > Signed-off-by: Mitali Borkar >

Re: [PATCH 5.4 v3 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-14 Thread Greg KH
On Mon, Apr 12, 2021 at 01:27:35PM -0700, Saeed Mirzamohammadi wrote: > The IOMMU driver calculates the guest addressability for a DMA request > based on the value of the mgaw reported from the IOMMU. However, this > is a fused value and as mentioned in the spec, the guest width > should be

Re: [PATCH] usb: core: remove unused including

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 02:05:40PM +0800, Yang Li wrote: > Fix the following versioncheck warning: > ./drivers/usb/core/hcd.c: 14 linux/version.h not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/usb/core/hcd.c | 1 - > 1 file changed, 1 deletion(-) I am now

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to

Re: [PATCH 5.4 v3 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:05:34AM -0700, Saeed Mirzamohammadi wrote: > Hi Greg, > > I don’t have any commit ID since the fix is not in mainline or any Linus’ > tree yet. The driver has completely changed for newer stable versions (and > also mainline) and the fix only applies for 5.4, 4.19,

Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 09:55:08AM -0700, Maciej Żenczykowski wrote: > This patch (or at least the version of it that showed up in 5.10.24 > LTS when combined with Android Common Kernel and some arm phone > platform drivers) causes a roughly 60% regression (from ~5.3-6 gbps > down to ~2.2gbps) on

Re: [RFC V2 PATCH 8/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:22:13AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > UIO HV driver should not load in the isolation VM for security reason. Why? I need a lot more excuse than that. Why would the vm allow UIO devices to bind to it if it was not possible? Shouldn't the VM be

Re: [RFC V2 PATCH 8/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:22:13AM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > UIO HV driver should not load in the isolation VM for security reason. > Return ENOTSUPP in the hv_uio_probe() in the isolation VM. > > Signed-off-by: Tianyu Lan > --- > drivers/uio/uio_hv_generic.c | 5 + >

Re: [PATCH v5 0/3] staging: rtl8192e: Cleanup patchset for style issues in rtl819x_HTProc.c

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 04:15:03PM +0530, Mitali Borkar wrote: > On Tue, Apr 13, 2021 at 09:52:48AM +0200, Greg KH wrote: > > On Tue, Apr 13, 2021 at 08:55:03AM +0530, Mitali Borkar wrote: > > > Changes from v4:- > > > [PATCH v4 1/3]:- No changes. > > > [PATCH v

Re: cocci script hints request

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:24:56AM +0200, Fabio Aiuto wrote: > On Tue, Apr 13, 2021 at 11:11:38AM +0200, Greg KH wrote: > > On Tue, Apr 13, 2021 at 11:04:01AM +0200, Fabio Aiuto wrote: > > > Hi, > > > > > > I would like to improve the following coccinelle scri

Re: cocci script hints request

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:04:01AM +0200, Fabio Aiuto wrote: > Hi, > > I would like to improve the following coccinelle script: > > @@ > expression a, fmt; > expression list var_args; > @@ > > - DBG_871X_LEVEL(a, fmt, var_args); > + printk(fmt, var_args); > > I would replace the

Re: [PATCH v5 0/3] staging: rtl8192e: Cleanup patchset for style issues in rtl819x_HTProc.c

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 08:55:03AM +0530, Mitali Borkar wrote: > Changes from v4:- > [PATCH v4 1/3]:- No changes. > [PATCH v4 2/3]:- No changes. > [PATCH V4 3/3]:- Removed casts and parentheses. This series does not apply cleanly, please rebase and resend. thanks, greg k-h

Re: [PATCH v7 3/3] bio: add limit_bio_size sysfs

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:55:02AM +0900, Changheun Lee wrote: > Add limit_bio_size block sysfs node to limit bio size. > Queue flag QUEUE_FLAG_LIMIT_BIO_SIZE will be set if limit_bio_size is set. > And bio max size will be limited by queue max sectors via > QUEUE_FLAG_LIMIT_BIO_SIZE set. > >

Re: [PATCH 5.4 v3 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-13 Thread Greg KH
On Mon, Apr 12, 2021 at 01:27:35PM -0700, Saeed Mirzamohammadi wrote: > The IOMMU driver calculates the guest addressability for a DMA request > based on the value of the mgaw reported from the IOMMU. However, this > is a fused value and as mentioned in the spec, the guest width > should be

Re: Subject: [PATCH v2] staging: media: meson: vdec: declare u32 as static const appropriately

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:57:52AM +0530, Mitali Borkar wrote: > Declared 32 bit unsigned int as static constant inside a function > appropriately. > > Reported-by: kernel test robot > Signed-off-by: Mitali Borkar Why does your Subject: line have "Subject:" twice?

Re: linux-next: build failure after merge of the usb tree

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 09:36:55PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the usb tree, today's linux-next build (x86_64 almodconfig > modules_install) failed like this: > > depmod: ERROR: Cycle detected: usbcore -> typec -> usbcore > depmod: ERROR: Found 2 modules in

Re: [PATCH 12/12] USB: cdc-acm: add more Maxlinear/Exar models to ignore list

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 11:55:57AM +0200, Johan Hovold wrote: > From: Mauro Carvalho Chehab > > Now that the xr_serial got support for other models, add their USB IDs > as well. > > The Maxlinear/Exar USB UARTs can be used in either ACM mode using the > cdc-acm driver or in "custom driver" mode

Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 01:44:35PM +0300, Sakari Ailus wrote: > Hi Greg, > > On Mon, Apr 12, 2021 at 11:49:43AM +0200, Greg KH wrote: > > On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote: > > > Hi Mitali, > > > > > > On Mon, Apr 12, 202

Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove function

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 12:12:34PM +0200, Fabio M. De Francesco wrote: > On Monday, April 12, 2021 11:42:51 AM CEST Greg KH wrote: > > On Sun, Apr 11, 2021 at 08:48:13PM +0200, Fabio M. De Francesco wrote: > > > Remove cmpk_handle_query_config_rx() because it just initial

Re: [PATCH 0/4] USB: serial: closing-wait fixes and cleanups

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 11:38:11AM +0200, Johan Hovold wrote: > The port drain_delay parameter is used to add a time-based delay when > closing the port in order to allow the transmit FIFO to drain in cases > where we don't know how to tell if the FIFO is empty. > > This series removes a

Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote: > Hi Mitali, > > On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > > Added #include and replaced bit shifts by BIT() macro. > > This BIT() macro from linux/bitops.h is used to define > > IPU3_UAPI_GRID_Y_START_EN > >

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192u: Remove variable set but not used

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 08:36:34PM +0200, Fabio M. De Francesco wrote: > Remove variable "int ret", declared but not used. > > Signed-off-by: Fabio M. De Francesco > --- > > Changes from v1: Change the text of the subject and log. > > drivers/staging/rtl8192u/r8192U_core.c | 1 - > 1 file

Re: [PATCH v4 0/3] staging: rtl8192e: modified log message

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 05:04:46PM +0530, Mitali Borkar wrote: > This patch fixes style issues > Changes from v3:- > [PATCH v3 1/3]:- Modified log message. > [PATCH V3 2/3]:- No changes. > [PATCH v3 3/3]:- No changes Your subject line here is odd :( Please fix up. thanks, greg k-h

Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove function

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 08:48:13PM +0200, Fabio M. De Francesco wrote: > Remove cmpk_handle_query_config_rx() because it just initializes a local > variable and then returns "void". > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 40

Re: [PATCH 2/3] staging rtl8723bs: split long lines

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 02:57:36PM +0200, Fabio Aiuto wrote: > fix following post-commit hook checkpatch issues: > > WARNING: line length of 116 exceeds 100 columns > 30: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:883: > + HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, >

Re: [PATCH] staging: emxx_udc: remove useless variable

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 10:53:10AM +0800, Jiapeng Chong wrote: > Fix the following gcc warning: > > vers/staging/emxx_udc/emxx_udc.c:41:19: warning: ‘driver_desc’ defined > but not used [-Wunused-const-variable=]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- >

Re: [PATCH 1/3] staging: rtl8723bs: remove unused variable ret in hal/sdio_halinit.c

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 02:57:35PM +0200, Fabio Aiuto wrote: > fix following compiler warning issue: > >drivers/staging/rtl8723bs/hal/sdio_halinit.c: > In function 'CardDisableRTL8723BSdio': > >> drivers/staging/rtl8723bs/hal/sdio_halinit.c:881:5: > warning: variable 'ret' set but not used

Re: [Outreachy kernel] [PATCH v5 0/4] staging: rtl8723bs: Change several files of the driver

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 01:04:54PM +0200, Fabio M. De Francesco wrote: > Remove camelcase, correct misspelled words in comments, change > the type of a variable and its use, change comparisons with 'true' > in controlling expressions. > > Changes from v4: Write patch version number in 2/4. >

Re: [PATCH v3 0/3] Modify subject description and rectify spelling mistake.

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 03:25:05PM +0530, Mitali Borkar wrote: > This patch fixes style issues "this" is not a patch :( And the subject line here also needs fixed up. thanks, greg k-h

Re: [PATCH 2/3] staging: rtl8723bs: Use existing arc4 implementation

2021-04-12 Thread Greg KH
On Sat, Apr 10, 2021 at 03:35:52PM +0200, Christophe JAILLET wrote: > Use functions provided by instead of hand writing them. > > The implementations are slightly different, but are equivalent. It has > been checked with a test program which compares the output of the 2 sets of > functions. > >

Re: [PATCH 0/2] remove whitespace and rectify spelling error

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 01:15:52AM +0530, Mitali Borkar wrote: > This patch fixes whitespace and spelling mistake issue. "this" is not a patch, it is a 0/X email. Also your subject line does not match the prefix on the patches, please fix up. thanks, greg k-h

Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove variable set but not used

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 08:12:05PM +0200, Fabio M. De Francesco wrote: > On Sunday, April 11, 2021 7:43:57 PM CEST Julia Lawall wrote: > > On Sun, 11 Apr 2021, Fabio M. De Francesco wrote: > > > Remove variable "int ret" which is instantiated but not used. > > > > instantiated -> declared? I

Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove variable set but not used

2021-04-12 Thread Greg KH
On Sun, Apr 11, 2021 at 07:41:43PM +0200, Fabio M. De Francesco wrote: > Remove variable "int ret" which is instantiated but not used. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8192u/r8192U_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 02:50:20PM +0800, dillon min wrote: > Hi Greg, > > Thanks for the quick response, please ignore the last private mail. > > On Mon, Apr 12, 2021 at 1:52 PM Greg KH wrote: > > > > On Mon, Apr 12, 2021 at 12:34:21PM +0800, dillon.min...@gmail.co

Re: [PATCH] staging: rtl8188eu: replaced msleep() by usleep_range()

2021-04-12 Thread Greg KH
On Mon, Apr 12, 2021 at 11:40:53AM +0530, Mitali Borkar wrote: > Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing > msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long > max) > in usecs as msleep(1ms~20ms) can sleep for upto 20 ms. > >

Re: [PATCH] serial: stm32: optimize spin lock usage

2021-04-11 Thread Greg KH
On Mon, Apr 12, 2021 at 12:34:21PM +0800, dillon.min...@gmail.com wrote: > From: dillon min > > To avoid potential deadlock in spin_lock usage, change to use > spin_lock_irqsave(), spin_unlock_irqrestore() in process(thread_fn) context. > spin_lock(), spin_unlock() under handler context. > >

Re: [Outreachy kernel] [PATCH v3 3/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-11 Thread Greg KH
On Sun, Apr 11, 2021 at 10:29:07AM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling expression of an > 'if' statement. The

Re: [Outreachy kernel] [PATCH v2 0/5] staging: rtl8723bs: Change

2021-04-11 Thread Greg KH
On Sun, Apr 11, 2021 at 09:11:43AM +0200, Fabio M. De Francesco wrote: > On Sunday, April 11, 2021 8:39:18 AM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 05:00:03PM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase, correct misspelled words in comments, remo

Re: MHI changes for v5.13

2021-04-11 Thread Greg KH
On Sun, Apr 11, 2021 at 11:25:59AM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > Here is the MHI Pull request for the v5.13 cycle. I stayed with the PR as the > number patches got increased. > > Details are in the signed tag, please consider merging! A suggestion, please put [GIT PULL] in

Re: [git pull] habanalabs pull request for kernel 5.13

2021-04-11 Thread Greg KH
On Sat, Apr 10, 2021 at 11:01:42PM +0300, Oded Gabbay wrote: > Hi Greg, > > This is habanalabs pull request for the merge window of kernel 5.13. > It contains changes and new features, support for new firmware. > Details are in the tag. > > Thanks, > Oded > > The following changes since commit

Re: [PATCH] Staging: rtl8192u: ieee80211: remove odd backslash.

2021-04-11 Thread Greg KH
On Sat, Apr 10, 2021 at 10:29:12PM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > This backslash should be deleted - looks like leftover and not needed. > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Outreachy kernel] [PATCH v2 2/5] staging: rtl8723bs: include: Fix misspelled words in comments

2021-04-11 Thread Greg KH
On Sat, Apr 10, 2021 at 05:00:05PM +0200, Fabio M. De Francesco wrote: > Signed-off-by: Fabio M. De Francesco > --- I can not take patches without any changelog text at all, sorry.

Re: [PATCH v2 0/3] staging: rtl8192e: remove unnecessary parentheses

2021-04-11 Thread Greg KH
On Sun, Apr 11, 2021 at 10:03:40AM +0530, Mitali Borkar wrote: > This patch fixes style issues > Changes from v1:- > [Patch 1/3]:- Removed unnecessary parentheses around boolean expressions > [Patch 2/3]:- No changes > [Patch 3/3]:- No changes > > Mitali Borkar (3): > staging: rtl8192e: remove

Re: [Outreachy kernel] [PATCH v2 0/5] staging: rtl8723bs: Change

2021-04-11 Thread Greg KH
On Sat, Apr 10, 2021 at 05:00:03PM +0200, Fabio M. De Francesco wrote: > Remove camelcase, correct misspelled words in comments, remove an unused > variable, change the type of a variable and its use, change comparisons > with 'true' in controlling expressions. > > Changes from v1: Fix a typo in

Re: [Outreachy kernel] [PATCH v4] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-11 Thread Greg KH
On Sat, Apr 10, 2021 at 08:26:40PM +0530, Mitali Borkar wrote: > Fixed pointer error by adding '*' to the function. That really does not describe this at all. I'll go fix this up... greg k-h

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 03:53:38PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 3:24:43 PM CEST Julia Lawall wrote: > > On Sat, 10 Apr 2021, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 2:12:28 PM CEST Julia Lawall wrote: > > > > On Sat, 10 Apr 2021, Fabio M.

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 07:07:08PM +0530, Mitali Borkar wrote: > On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote: > > On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > >

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 03:23:35PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e. boolean expression. This makes code more readable > > alternative. > > Reported by

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote: > Fixed Comparison to NULL can be written as '!...' by replacing it with > simpler form i.e. boolean expression. This makes code more readable > alternative. > Reported by checkpatch. Checkpatch did not report this specific problem,

[GIT PULL] Driver core fix for 5.12-rc7

2021-04-10 Thread Greg KH
The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120: Linux 5.12-rc6 (2021-04-04 14:15:36 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-5.12-rc7 for you to fetch changes up to

[GIT PULL] USB/Thunderbolt driver fixes for 5.12-rc7

2021-04-10 Thread Greg KH
The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120: Linux 5.12-rc6 (2021-04-04 14:15:36 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.12-rc7 for you to fetch changes up to

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: replace comparison to NULL by bool

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 02:08:30PM +0200, Julia Lawall wrote: > > > On Sat, 10 Apr 2021, Mitali Borkar wrote: > > > Fixed Comparison to NULL can be written as '!...' by replacing it with > > simpler form i.e boolean expression. This makes code more readable > > alternative. > > Reported by

Re: [PATCH 3/3] staging: rtl8712: Use existing arc4 implementation

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 01:56:57PM +0200, Christophe JAILLET wrote: > Use functions provided by instead of hand writing them. > > The implementations are slightly different, but are equivalent. It has > been checked with a test program which compares the output of the 2 sets of > functions. > >

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 01:23:21PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 1:03:34 PM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 12:58:06PM +0200, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote: >

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 12:58:06PM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 12:31:27 PM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 11:56:48AM +0200, Fabio M. De Francesco wrote: > > > On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote: >

Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:45:18AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 11:32:00 AM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase in bFwCurrentInPSMode, a variable used by cod

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:56:48AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > > > Change the type of fw_current_in_ps_mode from u8 to bool, becaus

Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > Remove camelcase in bFwCurrentInPSMode, a variable used by code > of several subdirectories/files of the driver. Issue detected by > checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from > the beginning of

Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling > expression of an 'if' statement. > >

Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface

2021-04-10 Thread Greg KH
On Thu, Apr 08, 2021 at 01:48:48PM +, SeongJae Park wrote: > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) > +{ > + const char * const file_names[] = {"attrs", "target_ids"}; > + const struct file_operations *fops[] = {_fops, _ids_fops}; > + int i; > + >

Re: [PATCH] tty: n_gsm: check error while registering tty devices

2021-04-10 Thread Greg KH
On Wed, Apr 07, 2021 at 04:21:30PM +0800, Hillf Danton wrote: > On Wed, 7 Apr 2021 07:37:53 Jiri Slaby wrote: > > > >Yes, the fix makes sense. > > Thanks for taking a look. > > >But could you elaborate in the commit log when this happens? > >I only wonder how real this is. I assume you inject

Re: [PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 12:15:30AM -0300, Luiz Sampaio wrote: > Changed the permissions to preferred octal style. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/slaves/w1_ds2438.c

Re: [PATCH 0/6] staging: rtl8192e: cleanup patchset for style issues

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 07:04:23AM +0530, Mitali Borkar wrote: > This patches fix the cleanup style issues. > > Mitali Borkar (6): > staging: rtl8192e: add spaces around binary operators > staging: rtl8192e: remove unnecessary blank line before brace > staging: rtl8192e: remove unncessary

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote: > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > > > This patch series removes camelcases, changes the type and use o

Re: [Outreachy kernel] [Resend Patch 0/3] staging: rtl8723bs: Patchset for rtl8723bs

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:39:31PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcase, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files I've again, dropped all patches from you

Re: [Outreachy kernel] [Patch 0/3]

2021-04-10 Thread Greg KH
On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote: > This patch series removes camelcases, changes the type and use of a > variable, and correct misspelled words. > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files > >

Re: [PATCH v2] usb: dwc2: Enable RPi in ACPI mode

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 03:38:09PM -0500, Jeremy Linton wrote: > The dwc2 driver has everything we need to run > in ACPI mode except for the ACPI module device table > boilerplate. With that added and identified as "BCM2848", > an id in use by other OSs for this device, the dw2 > controller on the

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Change the type and use of a variable

2021-04-09 Thread Greg KH
On Thu, Apr 08, 2021 at 01:19:42PM +0200, Fabio M. De Francesco wrote: > Change the type of fw_current_in_ps_mode from u8 to bool, because > it is used everywhere as a bool and, accordingly, it should be > declared as a bool. Shorten the controlling > expression of an 'if' statement. > >

Re: [PATCH] USB: serial: do not use tty class device for debugging

2021-04-09 Thread Greg KH
On Thu, Apr 08, 2021 at 05:08:59PM +0200, Johan Hovold wrote: > Use the port struct device rather than tty class device for debugging. > > Note that while USB serial doesn't support serdev yet (due to serdev not > handling hotplugging), serdev ttys do not have a corresponding class > device and

Re: [PATCH v2 2/2] docs: reporting-issues: make people CC the regressions list

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:47:24PM +0200, Thorsten Leemhuis wrote: > Make people CC the recently created mailing list dedicated to Linux > kernel regressions when reporting one. Some paragraphs had to be > reshuffled and slightly rewritten during the process, as the text > otherwise would have

Re: [PATCH v2 1/2] MAINTAINERS: add regressions mailing list

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:47:23PM +0200, Thorsten Leemhuis wrote: > Add the newly created regression mailing list finally created after it > already had been agreed on during the maintainers summit 2017 (see > https://lwn.net/Articles/738216/ ). The topic was recently discussed > again, where an

Re: [PATCH] staging: rtl8712: fix wrong function output

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:41:59PM +0200, Sergei Krainov wrote: > On Fri, Apr 09, 2021 at 08:33:23AM +0200, Greg KH wrote: > > On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote: > > > Function r8712_find_network() were returning wlan_network even if it > >

Re: [PATCH v2 0/2] USB:ehci:fix the no SRBN register problem

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 10:42:35AM +0800, liulongfang wrote: > On 2021/4/8 22:53, Alan Stern wrote: > > On Thu, Apr 08, 2021 at 09:49:18PM +0800, Longfang Liu wrote: > >> (1) Add a whitelist for EHCI devices without SBRN registers. > >> (2) Add Kunpeng920's EHCI device to the whitelist. > >> > >>

Re: [PATCH v3 1/2] USB:ehci:Add a whitelist for EHCI controllers

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 11:00:14AM +0800, Longfang Liu wrote: > Some types of EHCI controllers do not have SBRN registers. > By comparing the white list, the operation of reading the SBRN > registers is skipped. > > Subsequent EHCI controller types without SBRN registers can be > directly added

  1   2   3   4   5   6   7   8   9   10   >