Re: [PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Greg KH
On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote:
> Parts of this work came from contributions of Alexandru Ardelean and
> Dragos Bogdan, I and Gabriel would like to thank for the insights
> provided by their previous patches. Maybe it would be the case to add
> them as co-authors of this patch set.

That's what the Co-developed-by: tag is for, please use it :)



Re: [PATCH] x86/retpoline: Fix forcing me to update my compiler

2018-12-08 Thread Greg KH
On Sat, Dec 08, 2018 at 02:14:47PM +0100, Kirill Marinushkin wrote:
> >> First problem: I cannot compile the kernel with my version of compiler
> 
> >> Second problem: when I disable the feature - it cannot take effect,
> >> because the parse-time error happens before `syncconfig`
> 
> On 12/08/18 13:42, Borislav Petkov wrote:
> > Does this help?
> > 
> > https://git.kernel.org/tip/25896d073d8a0403b07e6dec56f58e6c33678207
> > 
> 
> The patch which you mentioned fixes the second problem: now I can disable
> CONFIG_RETPOLINE.
> But, the first problem is still here: with defconfig and gcc v6.4.0, kernel
> doesn't build, with this message:
> 
> 
> $ make
> scripts/kconfig/conf  --syncconfig Kconfig
> You are building kernel with non-retpoline compiler.
> Please update your compiler.
> make: *** [arch/x86/Makefile:311: checkbin] Error 1
> 
> 
> I don't think that this is a proper behavior. I suggest to allow compilation

No, you asked for retpoline, and your compiler can not provide that, so
erroring out is the correct behavior.  It is worse for you to have an
option enabled and it not being enabled just because your compiler does
not support it.  That way you do not have the false sense of security.

thanks,

greg k-h


Linux 4.9.144

2018-12-08 Thread Greg KH
I'm announcing the release of the 4.9.144 kernel.

All users of the 4.9 kernel series must upgrade.

The updated 4.9.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.9.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile |5 
 arch/arc/Kconfig |2 
 arch/arc/Makefile|2 
 arch/arc/configs/axs101_defconfig|2 
 arch/arc/configs/axs103_defconfig|1 
 arch/arc/configs/axs103_smp_defconfig|1 
 arch/arc/configs/nps_defconfig   |2 
 arch/arc/configs/nsim_700_defconfig  |1 
 arch/arc/configs/nsimosci_defconfig  |2 
 arch/arc/configs/nsimosci_hs_defconfig   |1 
 arch/arc/configs/nsimosci_hs_smp_defconfig   |1 
 arch/arc/configs/tb10x_defconfig |1 
 arch/arc/configs/vdk_hs38_defconfig  |1 
 arch/arc/configs/vdk_hs38_smp_defconfig  |1 
 arch/mips/include/asm/syscall.h  |2 
 arch/mips/ralink/mt7620.c|2 
 arch/x86/include/asm/suspend_64.h|5 
 arch/x86/kvm/svm.c   |   19 
 arch/x86/power/hibernate_64.c|6 
 drivers/android/binder.c |   41 +
 drivers/gpu/drm/ast/ast_main.c   |3 
 drivers/gpu/drm/drm_auth.c   |2 
 drivers/gpu/drm/gma500/mdfld_intel_display.c |2 
 drivers/gpu/drm/mediatek/mtk_hdmi.c  |5 
 drivers/infiniband/hw/mlx5/main.c|   29 -
 drivers/infiniband/ulp/iser/iser_verbs.c |7 
 drivers/input/joystick/xpad.c|   16 
 drivers/input/keyboard/matrix_keypad.c   |   23 
 drivers/input/mouse/elan_i2c_core.c  |3 
 drivers/net/ethernet/qlogic/qed/qed_debug.c  |8 
 drivers/net/wireless/ath/wil6210/wmi.c   |8 
 drivers/reset/core.c |   79 ++-
 drivers/scsi/bfa/bfa_fcbuild.c   |8 
 drivers/scsi/bfa/bfa_fcs.c   |   78 +--
 drivers/scsi/bfa/bfa_fcs_lport.c |   62 --
 drivers/scsi/bfa/bfa_ioc.c   |2 
 drivers/scsi/bfa/bfa_svc.c   |4 
 drivers/scsi/bfa/bfad.c  |   20 
 drivers/scsi/bfa/bfad_attr.c |2 
 drivers/scsi/bfa/bfad_bsg.c  |6 
 drivers/scsi/csiostor/csio_lnode.c   |   43 +
 drivers/scsi/scsi_devinfo.c  |   22 
 drivers/staging/rts5208/sd.c |6 
 drivers/tty/serial/kgdboc.c  |   43 -
 drivers/usb/gadget/udc/dummy_hcd.c   |9 
 fs/btrfs/Makefile|2 
 fs/btrfs/ctree.h |  128 ++---
 fs/btrfs/disk-io.c   |  162 --
 fs/btrfs/extent-tree.c   |   86 +++
 fs/btrfs/extent_io.c |   24 
 fs/btrfs/extent_io.h |   19 
 fs/btrfs/free-space-cache.c  |2 
 fs/btrfs/struct-funcs.c  |9 
 fs/btrfs/tree-checker.c  |  649 +++
 fs/btrfs/tree-checker.h  |   38 +
 fs/btrfs/volumes.c   |   30 +
 fs/btrfs/volumes.h   |2 
 fs/ceph/mds_client.c |   15 
 fs/f2fs/checkpoint.c |   46 +
 fs/f2fs/data.c   |   33 +
 fs/f2fs/f2fs.h   |   41 +
 fs/f2fs/file.c   |   21 
 fs/f2fs/inode.c  |   68 ++
 fs/f2fs/node.c   |   73 ++-
 fs/f2fs/recovery.c   |6 
 fs/f2fs/segment.c|   34 +
 fs/f2fs/segment.h|   48 +
 fs/f2fs/super.c  |  107 
 fs/hugetlbfs/inode.c |   30 +
 fs/kernfs/symlink.c  |2 
 fs/udf/super.c   |   16 
 fs/udf/unicode.c |   14 
 fs/xfs/libxfs/xfs_attr.c |9 
 include/linux/bpf_verifier.h |1 
 include/linux/ceph/auth.h|   13 
 include/linux/ceph/ceph_features.h   |4 
 include/linux/ceph/messenger.h   |8 
 include/linux/ceph/msgr.h|2 
 include/linux/reset.h|   92 +--
 include/uapi/linux/btrfs_tree.h  |1 
 kernel/bpf/verifier.c|   90 ++-
 kernel/debug/kdb/kdb_support.c   |4 
 kernel/events/uprobes.c  |   12 
 lib/kobject.c   

Re: Linux 4.19.8

2018-12-08 Thread Greg KH
diff --git a/Makefile b/Makefile
index d2b4efcfb388..34bc4c752c49 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 VERSION = 4
 PATCHLEVEL = 19
-SUBLEVEL = 7
+SUBLEVEL = 8
 EXTRAVERSION =
 NAME = "People's Front"
 
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index a045f3086047..a90c4f126050 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -111,7 +111,7 @@ endmenu
 
 choice
prompt "ARC Instruction Set"
-   default ISA_ARCOMPACT
+   default ISA_ARCV2
 
 config ISA_ARCOMPACT
bool "ARCompact ISA"
diff --git a/arch/arc/Makefile b/arch/arc/Makefile
index 644815c0516e..16e6cc22e25c 100644
--- a/arch/arc/Makefile
+++ b/arch/arc/Makefile
@@ -6,7 +6,7 @@
 # published by the Free Software Foundation.
 #
 
-KBUILD_DEFCONFIG := nsim_700_defconfig
+KBUILD_DEFCONFIG := nsim_hs_defconfig
 
 cflags-y   += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
 cflags-$(CONFIG_ISA_ARCOMPACT) += -mA7
diff --git a/arch/arc/configs/axs101_defconfig 
b/arch/arc/configs/axs101_defconfig
index 41bc08be6a3b..020d4493edfd 100644
--- a/arch/arc/configs/axs101_defconfig
+++ b/arch/arc/configs/axs101_defconfig
@@ -14,6 +14,7 @@ CONFIG_PERF_EVENTS=y
 # CONFIG_VM_EVENT_COUNTERS is not set
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_MODULES=y
 CONFIG_MODULE_FORCE_LOAD=y
 CONFIG_MODULE_UNLOAD=y
@@ -95,6 +96,7 @@ CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/axs103_defconfig 
b/arch/arc/configs/axs103_defconfig
index 1e1c4a8011b5..666314fffc60 100644
--- a/arch/arc/configs/axs103_defconfig
+++ b/arch/arc/configs/axs103_defconfig
@@ -94,6 +94,7 @@ CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/axs103_smp_defconfig 
b/arch/arc/configs/axs103_smp_defconfig
index 6b0c0cfd5c30..429832b8560b 100644
--- a/arch/arc/configs/axs103_smp_defconfig
+++ b/arch/arc/configs/axs103_smp_defconfig
@@ -97,6 +97,7 @@ CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
index 1dec2b4bc5e6..2a1d2cbfee1a 100644
--- a/arch/arc/configs/hsdk_defconfig
+++ b/arch/arc/configs/hsdk_defconfig
@@ -65,6 +65,7 @@ CONFIG_EXT3_FS=y
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/nps_defconfig b/arch/arc/configs/nps_defconfig
index 31ba224bbfb4..6e84060e7c90 100644
--- a/arch/arc/configs/nps_defconfig
+++ b/arch/arc/configs/nps_defconfig
@@ -15,6 +15,7 @@ CONFIG_SYSCTL_SYSCALL=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 CONFIG_MODULE_FORCE_LOAD=y
@@ -73,6 +74,7 @@ CONFIG_PROC_KCORE=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_ROOT_NFS=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/nsim_700_defconfig 
b/arch/arc/configs/nsim_700_defconfig
index 8e0b8b134cd9..219c2a65294b 100644
--- a/arch/arc/configs/nsim_700_defconfig
+++ b/arch/arc/configs/nsim_700_defconfig
@@ -15,6 +15,7 @@ CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 # CONFIG_LBDAF is not set
diff --git a/arch/arc/configs/nsimosci_defconfig 
b/arch/arc/configs/nsimosci_defconfig
index f14eeff7d308..35dfc6491a09 100644
--- a/arch/arc/configs/nsimosci_defconfig
+++ b/arch/arc/configs/nsimosci_defconfig
@@ -15,6 +15,7 @@ CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 # CONFIG_LBDAF is not set
@@ -66,5 +67,6 @@ CONFIG_EXT2_FS_XATTR=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
diff --git a/arch/arc/configs/nsimosci_hs_defconfig 
b/arch/arc/configs/nsimosci_hs_defconfig
index 025298a48305..1638e5bc9672 100644
--- a/arch/arc/configs/nsimosci_hs_defconfig
+++ b/arch/arc/configs/nsimosci_hs_defconfig
@@ -65,5 +65,6 @@ CONFIG_EXT2_FS_XATTR=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
diff --git 

Re: Linux 4.14.87

2018-12-08 Thread Greg KH
diff --git a/Makefile b/Makefile
index 572bd98d2344..322484348f3e 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 VERSION = 4
 PATCHLEVEL = 14
-SUBLEVEL = 86
+SUBLEVEL = 87
 EXTRAVERSION =
 NAME = Petit Gorille
 
@@ -803,6 +803,9 @@ KBUILD_CFLAGS += $(call 
cc-option,-Wdeclaration-after-statement,)
 # disable pointer signed / unsigned warnings in gcc 4.0
 KBUILD_CFLAGS += $(call cc-disable-warning, pointer-sign)
 
+# disable stringop warnings in gcc 8+
+KBUILD_CFLAGS += $(call cc-disable-warning, stringop-truncation)
+
 # disable invalid "can't wrap" optimizations for signed / pointers
 KBUILD_CFLAGS  += $(call cc-option,-fno-strict-overflow)
 
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index 8ff066090680..9d06c9478a0d 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -109,7 +109,7 @@ endmenu
 
 choice
prompt "ARC Instruction Set"
-   default ISA_ARCOMPACT
+   default ISA_ARCV2
 
 config ISA_ARCOMPACT
bool "ARCompact ISA"
diff --git a/arch/arc/Makefile b/arch/arc/Makefile
index 7c6c97782022..2917f56f0ea4 100644
--- a/arch/arc/Makefile
+++ b/arch/arc/Makefile
@@ -6,7 +6,7 @@
 # published by the Free Software Foundation.
 #
 
-KBUILD_DEFCONFIG := nsim_700_defconfig
+KBUILD_DEFCONFIG := nsim_hs_defconfig
 
 cflags-y   += -fno-common -pipe -fno-builtin -mmedium-calls -D__linux__
 cflags-$(CONFIG_ISA_ARCOMPACT) += -mA7
diff --git a/arch/arc/configs/axs101_defconfig 
b/arch/arc/configs/axs101_defconfig
index ece78630d711..5d5ba2104ba7 100644
--- a/arch/arc/configs/axs101_defconfig
+++ b/arch/arc/configs/axs101_defconfig
@@ -15,6 +15,7 @@ CONFIG_PERF_EVENTS=y
 # CONFIG_VM_EVENT_COUNTERS is not set
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_MODULES=y
 CONFIG_MODULE_FORCE_LOAD=y
 CONFIG_MODULE_UNLOAD=y
@@ -98,6 +99,7 @@ CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/axs103_defconfig 
b/arch/arc/configs/axs103_defconfig
index 240c9251a7d4..0874db2d48a8 100644
--- a/arch/arc/configs/axs103_defconfig
+++ b/arch/arc/configs/axs103_defconfig
@@ -97,6 +97,7 @@ CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/axs103_smp_defconfig 
b/arch/arc/configs/axs103_smp_defconfig
index af54b96abee0..cf5df0e1cb08 100644
--- a/arch/arc/configs/axs103_smp_defconfig
+++ b/arch/arc/configs/axs103_smp_defconfig
@@ -100,6 +100,7 @@ CONFIG_VFAT_FS=y
 CONFIG_NTFS_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
index 762b1fcd93dc..083560e9e571 100644
--- a/arch/arc/configs/hsdk_defconfig
+++ b/arch/arc/configs/hsdk_defconfig
@@ -66,6 +66,7 @@ CONFIG_EXT3_FS=y
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS=y
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ISO8859_1=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/nps_defconfig b/arch/arc/configs/nps_defconfig
index 7c9c706ae7f6..9121c6ba15d0 100644
--- a/arch/arc/configs/nps_defconfig
+++ b/arch/arc/configs/nps_defconfig
@@ -15,6 +15,7 @@ CONFIG_SYSCTL_SYSCALL=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 CONFIG_MODULE_FORCE_LOAD=y
@@ -74,6 +75,7 @@ CONFIG_PROC_KCORE=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 CONFIG_ROOT_NFS=y
 CONFIG_DEBUG_INFO=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
diff --git a/arch/arc/configs/nsim_700_defconfig 
b/arch/arc/configs/nsim_700_defconfig
index b1a78222699c..cdb06417d3d9 100644
--- a/arch/arc/configs/nsim_700_defconfig
+++ b/arch/arc/configs/nsim_700_defconfig
@@ -16,6 +16,7 @@ CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 # CONFIG_LBDAF is not set
diff --git a/arch/arc/configs/nsimosci_defconfig 
b/arch/arc/configs/nsimosci_defconfig
index 14377b8234f7..c4577bd9196c 100644
--- a/arch/arc/configs/nsimosci_defconfig
+++ b/arch/arc/configs/nsimosci_defconfig
@@ -16,6 +16,7 @@ CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 # CONFIG_SLUB_DEBUG is not set
 # CONFIG_COMPAT_BRK is not set
+CONFIG_ISA_ARCOMPACT=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 # CONFIG_LBDAF is not set
@@ -69,5 +70,6 @@ CONFIG_EXT2_FS_XATTR=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_NFS_FS=y
+CONFIG_NFS_V3_ACL=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
diff --git 

Linux 4.14.87

2018-12-08 Thread Greg KH
I'm announcing the release of the 4.14.87 kernel.

All users of the 4.14 kernel series must upgrade.

The updated 4.14.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.14.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile |5 
 arch/arc/Kconfig |2 
 arch/arc/Makefile|2 
 arch/arc/configs/axs101_defconfig|2 
 arch/arc/configs/axs103_defconfig|1 
 arch/arc/configs/axs103_smp_defconfig|1 
 arch/arc/configs/hsdk_defconfig  |1 
 arch/arc/configs/nps_defconfig   |2 
 arch/arc/configs/nsim_700_defconfig  |1 
 arch/arc/configs/nsimosci_defconfig  |2 
 arch/arc/configs/nsimosci_hs_defconfig   |1 
 arch/arc/configs/nsimosci_hs_smp_defconfig   |1 
 arch/arc/configs/tb10x_defconfig |1 
 arch/arc/configs/vdk_hs38_defconfig  |1 
 arch/arc/configs/vdk_hs38_smp_defconfig  |1 
 arch/mips/include/asm/syscall.h  |2 
 arch/mips/ralink/mt7620.c|2 
 arch/x86/kvm/svm.c   |   19 -
 drivers/gpu/drm/ast/ast_main.c   |3 
 drivers/gpu/drm/drm_auth.c   |2 
 drivers/gpu/drm/gma500/mdfld_intel_display.c |2 
 drivers/gpu/drm/meson/meson_dw_hdmi.c|1 
 drivers/gpu/drm/meson/meson_viu.c|   12 -
 drivers/gpu/drm/msm/adreno/adreno_device.c   |5 
 drivers/infiniband/hw/mlx5/main.c|   29 --
 drivers/infiniband/ulp/iser/iser_verbs.c |7 
 drivers/input/joystick/xpad.c|   16 -
 drivers/input/keyboard/cros_ec_keyb.c|3 
 drivers/input/keyboard/matrix_keypad.c   |   23 +
 drivers/input/mouse/elan_i2c_core.c  |3 
 drivers/input/mouse/synaptics.c  |1 
 drivers/net/ethernet/qlogic/qed/qed_debug.c  |6 
 drivers/reset/core.c |9 
 drivers/scsi/bfa/bfa_fcbuild.c   |8 
 drivers/scsi/bfa/bfa_fcs.c   |   78 +++---
 drivers/scsi/bfa/bfa_fcs_lport.c |   62 ++---
 drivers/scsi/bfa/bfa_ioc.c   |2 
 drivers/scsi/bfa/bfa_svc.c   |4 
 drivers/scsi/bfa/bfad.c  |   20 -
 drivers/scsi/bfa/bfad_attr.c |2 
 drivers/scsi/bfa/bfad_bsg.c  |6 
 drivers/scsi/scsi_devinfo.c  |   22 -
 drivers/staging/rts5208/sd.c |6 
 drivers/thermal/hisi_thermal.c   |  318 ++-
 drivers/tty/serial/kgdboc.c  |   43 +--
 fs/btrfs/disk-io.c   |   10 
 fs/btrfs/tree-checker.c  |8 
 fs/kernfs/symlink.c  |2 
 fs/udf/super.c   |   16 -
 fs/udf/unicode.c |   14 -
 fs/userfaultfd.c |   15 +
 include/linux/reset.h|   34 +-
 kernel/debug/kdb/kdb_support.c   |4 
 kernel/events/uprobes.c  |   12 -
 lib/kobject.c|2 
 lib/test_hexdump.c   |2 
 mm/hugetlb.c |2 
 mm/shmem.c   |   31 ++
 mm/truncate.c|8 
 mm/userfaultfd.c |   62 +++--
 mm/vmstat.c  |4 
 net/ipv4/ip_tunnel.c |4 
 net/tipc/subscr.c|2 
 scripts/Makefile.extrawarn   |3 
 scripts/unifdef.c|4 
 sound/pci/trident/trident.c  |2 
 sound/x86/intel_hdmi_audio.c |2 
 67 files changed, 537 insertions(+), 446 deletions(-)

Adam Wong (1):
  Input: elan_i2c - add support for ELAN0621 touchpad

Alexey Brodkin (1):
  arc: [devboards] Add support of NFSv3 ACL

Andrea Arcangeli (5):
  userfaultfd: use ENOENT instead of EFAULT if the atomic copy user fails
  userfaultfd: shmem: allocate anonymous memory for MAP_PRIVATE shmem
  userfaultfd: shmem: add i_size checks
  userfaultfd: shmem: UFFDIO_COPY: set the page dirty if VM_WRITE is not set
  userfaultfd: shmem/hugetlbfs: only allow to register VM_MAYWRITE vmas

Andrea Parri (1):
  uprobes: Fix handle_swbp() vs. unregister() + register() race once more

Arnd Bergmann (5):
  drm: gma500: fix logic error
  scsi: bfa: convert to strlcpy/strlcat
  staging: rts5208: fix gcc-8 logic error warning
  kdb: use memmove instead of overlapping memcpy
  net: qed: use 

Linux 4.19.8

2018-12-08 Thread Greg KH
I'm announcing the release of the 4.19.8 kernel.

All users of the 4.19 kernel series must upgrade.

The updated 4.19.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.19.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile|2 
 arch/arc/Kconfig|2 
 arch/arc/Makefile   |2 
 arch/arc/configs/axs101_defconfig   |2 
 arch/arc/configs/axs103_defconfig   |1 
 arch/arc/configs/axs103_smp_defconfig   |1 
 arch/arc/configs/hsdk_defconfig |1 
 arch/arc/configs/nps_defconfig  |2 
 arch/arc/configs/nsim_700_defconfig |1 
 arch/arc/configs/nsimosci_defconfig |2 
 arch/arc/configs/nsimosci_hs_defconfig  |1 
 arch/arc/configs/nsimosci_hs_smp_defconfig  |1 
 arch/arc/configs/tb10x_defconfig|1 
 arch/arc/configs/vdk_hs38_defconfig |1 
 arch/arc/configs/vdk_hs38_smp_defconfig |1 
 arch/arm64/include/asm/ftrace.h |   13 ++
 arch/mips/include/asm/syscall.h |2 
 arch/mips/ralink/mt7620.c   |2 
 arch/x86/kvm/svm.c  |   19 ++--
 block/blk-mq.c  |7 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c |2 
 drivers/gpu/drm/ast/ast_main.c  |3 
 drivers/gpu/drm/drm_auth.c  |2 
 drivers/gpu/drm/meson/meson_crtc.c  |   27 +
 drivers/gpu/drm/meson/meson_dw_hdmi.c   |1 
 drivers/gpu/drm/meson/meson_venc.c  |3 
 drivers/gpu/drm/meson/meson_viu.c   |   12 +-
 drivers/infiniband/hw/mlx5/main.c   |   29 ++
 drivers/infiniband/ulp/iser/iser_verbs.c|7 -
 drivers/input/joystick/xpad.c   |   16 +--
 drivers/input/keyboard/cros_ec_keyb.c   |3 
 drivers/input/keyboard/matrix_keypad.c  |   23 ++--
 drivers/input/mouse/elan_i2c_core.c |3 
 drivers/input/mouse/synaptics.c |1 
 drivers/mtd/nand/bbt.c  |3 
 drivers/net/ethernet/intel/i40e/i40e_main.c |2 
 drivers/scsi/lpfc/lpfc_init.c   |6 +
 drivers/scsi/lpfc/lpfc_sli.c|1 
 drivers/tty/serial/kgdboc.c |   43 -
 fs/btrfs/tree-checker.c |8 -
 include/linux/tracepoint.h  |6 -
 include/trace/events/sched.h|   12 ++
 kernel/events/uprobes.c |   12 ++
 kernel/trace/trace.h|   57 +++-
 kernel/trace/trace_functions_graph.c|4 
 kernel/trace/trace_irqsoff.c|2 
 kernel/trace/trace_sched_wakeup.c   |2 
 lib/test_hexdump.c  |2 
 mm/hugetlb.c|2 
 mm/shmem.c  |   31 +-
 mm/userfaultfd.c|   47 -
 net/tipc/topsrv.c   |2 
 scripts/unifdef.c   |4 
 security/selinux/nlmsgtab.c |   13 ++
 54 files changed, 332 insertions(+), 123 deletions(-)

Adam Wong (1):
  Input: elan_i2c - add support for ELAN0621 touchpad

Alexey Brodkin (1):
  arc: [devboards] Add support of NFSv3 ACL

Andrea Arcangeli (4):
  userfaultfd: use ENOENT instead of EFAULT if the atomic copy user fails
  userfaultfd: shmem: allocate anonymous memory for MAP_PRIVATE shmem
  userfaultfd: shmem: add i_size checks
  userfaultfd: shmem: UFFDIO_COPY: set the page dirty if VM_WRITE is not set

Andrea Parri (1):
  uprobes: Fix handle_swbp() vs. unregister() + register() race once more

Brian Norris (1):
  Input: cros_ec_keyb - fix button/switch capability reports

Cameron Gutman (1):
  Input: xpad - quirk all PDP Xbox One gamepads

Christian Hoff (1):
  

Re: Process for severe early stable bugs?

2018-12-08 Thread Greg KH
On Fri, Dec 07, 2018 at 04:33:10PM -0800, Laura Abbott wrote:
> The latest file system corruption issue (Nominally fixed by
> ffe81d45322c ("blk-mq: fix corruption with direct issue") later
> fixed by c616cbee97ae ("blk-mq: punt failed direct issue to dispatch
> list")) brought a lot of rightfully concerned users asking about
> release schedules. 4.18 went EOL on Nov 21 and Fedora rebased to
> 4.19.3 on Nov 23. When the issue started getting visibility,
> users were left with the option of running known EOL 4.18.x
> kernels or running a 4.19 series that could corrupt their
> data. Admittedly, the risk of running the EOL kernel was pretty
> low given how recent it was, but it's still not a great look
> to tell people to run something marked EOL.
> 
> I'm wondering if there's anything we can do to make things easier
> on kernel consumers. Bugs will certainly happen but it really
> makes it hard to push the "always run the latest stable" narrative
> if there isn't a good fallback when things go seriously wrong. I
> don't actually have a great proposal for a solution here other than
> retroactively bringing back 4.18 (which I don't think Greg would
> like) but I figured I should at least bring it up.

A nice step forward would have been if someone could have at least
_told_ the stable maintainer (i.e. me) that there was such a serious bug
out there.  That didn't happen here and I only found out about it
accidentally by happening to talk to a developer who was on the bugzilla
thread at a totally random meeting last Wednesday.

There was also not an email thread that I could find once I found out
about the issue.  By that time the bug was fixed and all I could do was
wait for it to hit Linus's tree (and even then, I had to wait for the
fix to the fix...)  If I had known about it earlier, I would have
reverted the change that caused this.

I would start by looking at how we at least notify people of major
issues like this.  Yes it was complex and originally blamed on both
btrfs and ext4 changes, and it was dependant on using a brand-new
.config file which no kernel developers use (and it seems no distro uses
either, which protected Fedora and others at the least!)

There will always be bugs and exceptions and personally I think that the
rarity of this one was such that it is a rare event and adding the
requirement that I have to maintain more than one set of stable trees
for longer isn't going to happen (yeah, I know you said you didn't
expect that, but I know others mentioned it to me...)

So I don't know what to say here other than please tell me about major
issues like this and don't rely on me getting lucky and hearing about it
on my own.

thanks,

greg k-h


Re: [PATCH v3 2/2] kobject: drop newline from msg string

2018-12-07 Thread Greg KH
On Fri, Dec 07, 2018 at 05:21:49AM -0500, Bo YU wrote:
> There is currently a missing terminating newline in non-switch case
> match, when msg == NULL.
> 
> Signed-off-by: Bo YU 
> ---
> Changes in v3:
> Improve the commit log,requested by rafael.
> 
> Changes in v2:
> According to Joe's suggestion,drop newline from msg
> 
>  lib/kobject_uevent.c | 11 ++-
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index b7c088c902a2..1837765ebf01 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -195,12 +195,12 @@ int kobject_synth_uevent(struct kobject *kobj, const 
> char *buf, size_t count)
>   enum kobject_action action;
>   const char *action_args;
>   struct kobj_uevent_env *env;
> - const char *msg = NULL, *devpath;
> + const char *msg = NULL;

Why did you move the devpath variable from here to lower down?  That
really doesn't do anything :(

thanks,

greg k-h


Re: [PATCH v2] kobject: add kernel/uevent_features sysfs file

2018-12-07 Thread Greg KH
On Fri, Dec 07, 2018 at 12:46:07PM +0100, Peter Rajnoha wrote:
> We can use extended format when writing /sys/.../uevent files to
> generate synthetic uevents, introduced with commit f36776fafbaa
> ("kobject: support passing in variables for synthetic uevents").
> 
> Before using this extended format, we need to know if it's supported
> and kernel version check may not be appropriate in all cases - there
> are possible differences from upstream kernel in distributions with
> backports.
> 
> This patch adds /sys/kernel/uevent_features file which currently lists
> 'synthargs' string to denote that the kernel is able to recognize the
> extended synthetic uevent arguments. Userspace can easily check for
> the feature then.

So this is just to try to have userspace detect what type of feature the
kernel has?  Why can't you just go off of the other sysfs file itself?
You shouldn't need a "this is a feature list" for the kernel, otherwise
we would be on a huge slippery slope trying to document everything.

Who is going to use this thing?  And what else would go into it?

Isn't there some other way you can detect this from userspace (like
writing to the file and it fails?)

thanks,

greg k-h


Re: [PATCH 2/2] kobject: add kernel/uevent_features sysfs file

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 12:27:45PM +0100, Peter Rajnoha wrote:
> We can use extended format when writing /sys/.../uevent files to
> generate synthetic uevents, introduced with commit f36776fafbaa
> ("kobject: support passing in variables for synthetic uevents").
> 
> Before using this extended format, we need to know if it's supported
> and kernel version check may not be appropriate in all cases - there
> are possible differences from upstream kernel in distributions with
> backports.
> 
> This patch adds /sys/kernel/uevent_features file which currently lists
> 'synthargs' string to denote that the kernel is able to recognize the
> extended synthetic uevent arguments. Userspace can easily check for
> the feature then.

No Documentation/ABI/ update for your new sysfs file?  Not good, I can't
take this patch without that :(

greg k-h


Re: [PATCH v10 0/8] Introduce on-chip interconnect API

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 12:41:35PM -0800, Evan Green wrote:
> On Tue, Nov 27, 2018 at 10:03 AM Georgi Djakov  
> wrote:
> >
> > Modern SoCs have multiple processors and various dedicated cores (video, 
> > gpu,
> > graphics, modem). These cores are talking to each other and can generate a
> > lot of data flowing through the on-chip interconnects. These interconnect
> > buses could form different topologies such as crossbar, point to point 
> > buses,
> > hierarchical buses or use the network-on-chip concept.
> >
> > These buses have been sized usually to handle use cases with high data
> > throughput but it is not necessary all the time and consume a lot of power.
> > Furthermore, the priority between masters can vary depending on the running
> > use case like video playback or CPU intensive tasks.
> >
> > Having an API to control the requirement of the system in terms of bandwidth
> > and QoS, so we can adapt the interconnect configuration to match those by
> > scaling the frequencies, setting link priority and tuning QoS parameters.
> > This configuration can be a static, one-time operation done at boot for some
> > platforms or a dynamic set of operations that happen at run-time.
> >
> > This patchset introduce a new API to get the requirement and configure the
> > interconnect buses across the entire chipset to fit with the current demand.
> > The API is NOT for changing the performance of the endpoint devices, but 
> > only
> > the interconnect path in between them.
> 
> For what it's worth, we are ready to land this in Chrome OS. I think
> this series has been very well discussed and reviewed, hasn't changed
> much in the last few spins, and is in good enough shape to use as a
> base for future patches. Georgi's also done a great job reaching out
> to other SoC vendors, and there appears to be enough consensus that
> this framework will be usable by more than just Qualcomm. There are
> also several drivers out on the list trying to add patches to use this
> framework, with more to come, so it made sense (to us) to get this
> base framework nailed down. In my experiments this is an important
> piece of the overall power management story, especially on systems
> that are mostly idle.
> 
> I'll continue to track changes to this series and we will ultimately
> reconcile with whatever happens upstream, but I thought it was worth
> sending this note to express our "thumbs up" towards this framework.

Looks like a v11 will be forthcoming, so I'll wait for that one to apply
it to the tree if all looks good.

thanks,

greg k-h


Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote:
> Add __acquire()/__release() annnotations to fix warnings
> in sparse context checking
> 
> There is one case where the warning was due to a lack of
> a "default:" case in a switch statement where a lock was
> being released in each of the cases, so the default
> case was added.
> 
> Signed-off-by: Todd Kjos 
> ---
> v2: no change, just resubmitted as #1 of 3 patches instead of by itself

I've already applied this one, right?

thanks,

greg k-h


Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 05:32:19PM -0500, Sven Van Asbroeck wrote:
> Thanks :)
> 
> On Wed, Dec 5, 2018 at 2:17 PM Greg KH  wrote:
> >
> > Great, then call it a 'fieldbus' class, not "fieldbus_dev' class.
> 
> Small nit:
> 
> Hardware connected to a fieldbus comes in two distinct flavours:
> - clients (e.g. thermometer, robotic arm) called "fieldbus devices"
> - servers (e.g. a PLC) called "fieldbus controllers"
> 
> Their userspace APIs will probably differ quite a lot.

But servers are going to be much more rare, and odds are userspace is
not going to need to control anything with them, right?

> The userspace API created by the patch is only for clients a.k.a.
> "fieldbus devices". That's why I'm writing 'fieldbus_dev' all over the place.
> 
> For simplicity, we could change that to just 'fieldbus'. But would this get
> us in trouble when, at some point, we want to add a userspace API for
> servers a.k.a. "fieldbus controllers" ?

Ick, yeah, I guess so, but planning for future events is not something
we do well at all.  Are you sure you will need fieldbus controllers as a
class?

And as these are really devices, why not make them a "device" and a bus?
What type of topology do you have on these busses?  Are everything
"flat" and connected directly to a PCI/USB/platform device?  Or are
there multiple devices attached to a single controller?

It really feels like you want to use 'struct device' and a bus_type and
not a class here to me...

thanks,

greg k-h


Re: [PATCH] binder: implement binderfs

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 10:42:06PM +0100, Christian Brauner wrote:
> On Wed, Dec 05, 2018 at 09:01:45PM +0100, Greg KH wrote:
> > > /* binder-control */
> > > Each new binderfs instance comes with a binder-control device. No other
> > > devices will be present at first. The binder-control device can be used to
> > > dynamically allocate binder devices. All requests operate on the binderfs
> > > mount the binder-control device resides in:
> > > - BINDER_CTL_ADD
> > >   Allocate a new binder device.
> > > Assuming a new instance of binderfs has been mounted at /dev/binderfs via
> > > mount -t binderfs binderfs /dev/binderfs. Then a request to create a new
> > > binder device can be made via:
> > > 
> > > struct binderfs_device device = {0};
> > > int fd = open("/dev/binderfs/binder-control", O_RDWR);
> > > ioctl(fd, BINDER_CTL_ADD, );
> > > 
> > > The struct binderfs_device will be used to return the major and minor
> > > number, as well as the index used as the new name for the device.
> > > Binderfs devices can simply be removed via unlink().
> > 
> > I think you should provide a name in the BINDER_CTL_ADD command.  That
> > way you can easily emulate the existing binder queues, and it saves you
> > a create/rename sequence that you will be forced to do otherwise.  Why
> > not do it just in a single command?
> 
> Sounds reasonable. How do you feel about capping the name length at 255
> bytes aka the standard Linux file name length (e.g. xfs, ext4 etc.)?
> 
> #define BINDERFS_NAME_MAX 255
> 
> struct binderfs_device {
> char name[BINDERFS_NAME_MAX + 1];

__u8 is the proper type to cross the user/kernel boundry :)

>   __u32 major;
>   __u32 minor;
> }

Yes, limiting it to 255 is fine with me.

> > That way also you don't need to care about the major/minor number at
> > all.  Userspace should never need to worry about that, use a name,
> > that's the best thing.  Also, it allows you to drop the use of the idr,
> > making the kernel code simpler overall.
> > 
> > > /* Implementation details */
> > > - When binderfs is registered as a new filesystem it will dynamically
> > >   allocate a new major number. The allocated major number will be returned
> > >   in struct binderfs_device when a new binder device is allocated.
> > 
> > Why does userspace care about major/minor numbers at all?  You should
> 
> Userspace cares for the sake of the devices cgroup which operates on
> device numnbers to restrict access to devices. Since binderfs doesn't
> have a static major number returning that information is helpful.

Ugh, ok, that makes sense.  If we really want to make the kernel
interface simpler, drop the major/minor and then have userspace do the
stat(2) to see what the major/minor number they care about is.

But yeah, keeping it here makes everyone's life simpler, the kernel
already knows this, and it's trivial to pass it back to userspace this
way.

Care to make this change and resend?

thanks,

greg k-h


Re: [PATCH] mm: hide incomplete nr_indirectly_reclaimable in /proc/zoneinfo

2018-12-06 Thread Greg KH
On Thu, Nov 29, 2018 at 03:54:10PM +0100, Vlastimil Babka wrote:
> On 11/29/18 1:52 PM, Greg KH wrote:
> > On Tue, Oct 30, 2018 at 05:48:25PM +, Roman Gushchin wrote:
> >> BTW, in 4.19+ the counter has been renamed and exported by
> >> the commit b29940c1abd7 ("mm: rename and change semantics of
> >> nr_indirectly_reclaimable_bytes"), so there is no such a problem
> >> anymore.
> >>
> >> Cc:  # 4.14.x-4.18.x
> >> Fixes: 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable in 
> >> /proc/vmstat")
> 
> ...
> 
> > I do not see this patch in Linus's tree, do you?
> > 
> > If not, what am I supposed to do with this?
> 
> Yeah it wasn't probably clear enough, but this is stable-only patch, as
> upstream avoided the (then-unknown) problem in 4.19 as part of a far
> more intrusive series. As I've said in my previous reply to this thread,
> I don't think we can backport that series to stable (e.g. it introduces
> a set of new kmalloc caches that will suddenly appear in /proc/slabinfo)
> so I think this is a case for exception from the stable rules.

Ok, now queued up, thanks.

greg k-h


Re: [PATCH] ubi: fastmap: Check each mapping only once

2018-12-06 Thread Greg KH
On Sun, Dec 02, 2018 at 09:51:34AM +0100, Richard Weinberger wrote:
> Greg,
> 
> Am Donnerstag, 29. November 2018, 09:09:23 CET schrieb Greg KH:
> > On Mon, Nov 26, 2018 at 11:38:42AM +0100, Martin Kepplinger wrote:
> > > From: Richard Weinberger 
> > > 
> > > [ Upstream commit 34653fd8c46e771585fce5975e4243f8fd401914 ]
> > > 
> > > This commit got merged along with commit 781932375ffc
> > > ("ubi: fastmap: Correctly handle interrupted erasures in EBA") upstream 
> > > but
> > > only the latter has been applied to stable v4.14.54 as commit 
> > > a23cf10d9abb.
> > > This resulted in a performance regression. Startup on i.MX platforms is
> > > delayed for up to a few seconds depending on the platform.
> > > This fixes ubi fastmap to be of the same performance as it has been before
> > > said fastmap changes.
> > > 
> > > Fixes: a23cf10d9abb ("ubi: fastmap: Correctly handle interrupted erasures 
> > > in EBA")
> > > Signed-off-by: Richard Weinberger 
> > > Signed-off-by: Martin Kepplinger 
> > > ---
> > > 
> > > Richard, although this fixes a major slowdown regression in -stable, do 
> > > you
> > > consider this "stable" too?
> > > 
> > > This applies and is tested only for the 4.14 stable tree. It seems to be
> > > equally relevant for 4.9 and 4.4 though.
> > 
> > Now queued up for 4.14.y, thanks.
> 
> can you *please* slow a little down?
> 
> There are times (e.g. when I travel, visit customers on-site, being sick, 
> etc...)
> where I don't have the resources to monitor the mailinglists
> in detail. Adding patches to stable on shout asks for trouble.
> 
> As Sudip points out, this patch needs a further fix patch:
> 25677478474a ("ubi: Initialize Fastmap checkmapping correctly")

This is now in 4.14.86 so all should be fine now.

As for "speed", most of the time people are complaining that I move too
slow in getting fixes backported and to their patches.  Rarely am I told
I am moving too fast, that's a nice change :)

As for doing releases on a "regular" schedule, I've tried it, and it
didn't work any better/worse than what I'm doing now as everyone who
consumes these kernels have their own cadence / acceptance process and I
can never get in sync with _everyone_ let alone almost _anyone_.

And due to travel and other things (like security issues coming up),
trying to nail down a specific day-of-the-week doesn't work out at all
either.

thanks,

greg k-h


Re: v4.14 fix for Hikey 960 unbalanced IRQ enablement

2018-12-06 Thread Greg KH
On Mon, Dec 03, 2018 at 04:24:48PM -0200, Rafael David Tinoco wrote:
> >> Greg,
> >>
> >> Patch 5 in this series seems to explain the best what is happening here:
> >>
> >>> With the following changes, we fix all in one:
> >>>
> >>> - Do the setup, one time, at probe time
> >>>
> >>> - Add the IRQF_ONESHOT, ack the interrupt in the threaded handler
> >>>
> >>> - Remove the interrupt handler
> >>>
> >>> - Set the correct value for the LAG register
> >>>
> >>> - Remove all the irq_enabled stuff in the code as the interruption
> >>>   handling is fixed
> >>>
> >>> - Remove the 3ms delay
> >>>
> >>> - Reorder the initialization routine to be in the right order
> >>
> >> We can't revert anything because the breakage was there since the driver
> >> was introduced.
> > 
> > So the driver was broken in 4.14, why not just use 4.19 instead?  This
> > isn't a 4.14 regression, it's something that obviously no one has
> > noticed for a year now, so why backport these big patches to 4.14 now?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> This was caught during our functional tests. No direct complains, but,
> since it included a trace, and there was a fix for it, I thought it
> could be accepted for upstream v4.14 (it is included in other v4.14
> kernels, like Android's).

Ok, all now queued up, thanks.

greg k-h


Re: linux-next: manual merge of the char-misc tree with the mmc tree

2018-12-05 Thread Greg KH
On Thu, Dec 06, 2018 at 03:48:00PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the char-misc tree got a conflict in:
> 
>   drivers/misc/Makefile
> 
> between commit:
> 
>   4eb78924bf0e ("misc: cardreader: add new Alcor Micro Cardreader PCI driver")
> 
> from the mmc tree and commit:
> 
>   fcb418cd567f ("pvpanic: move pvpanic to misc as common driver")
> 
> from the char-misc tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 
> diff --cc drivers/misc/Makefile
> index fe3134cf3008,b76d611c87de..
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@@ -57,4 -57,5 +57,5 @@@ obj-$(CONFIG_ASPEED_LPC_CTRL)   += aspeed
>   obj-$(CONFIG_ASPEED_LPC_SNOOP)  += aspeed-lpc-snoop.o
>   obj-$(CONFIG_PCI_ENDPOINT_TEST) += pci_endpoint_test.o
>   obj-$(CONFIG_OCXL)  += ocxl/
>  -obj-$(CONFIG_MISC_RTSX) += cardreader/
>  +obj-y   += cardreader/
> + obj-$(CONFIG_PVPANIC)   += pvpanic.o

Looks good to me, thanks!

greg k-h


Re: [PATCH] binder: implement binderfs

2018-12-05 Thread Greg KH
On Tue, Dec 04, 2018 at 02:12:39PM +0100, Christian Brauner wrote:
> As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the
> implementation of binderfs. If you want to skip reading and just see how it
> works, please go to [2].

First off, thanks for doing this so quickly.  I think the overall idea
and implementation is great, I just have some minor issues with the user
api:

> /* binder-control */
> Each new binderfs instance comes with a binder-control device. No other
> devices will be present at first. The binder-control device can be used to
> dynamically allocate binder devices. All requests operate on the binderfs
> mount the binder-control device resides in:
> - BINDER_CTL_ADD
>   Allocate a new binder device.
> Assuming a new instance of binderfs has been mounted at /dev/binderfs via
> mount -t binderfs binderfs /dev/binderfs. Then a request to create a new
> binder device can be made via:
> 
> struct binderfs_device device = {0};
> int fd = open("/dev/binderfs/binder-control", O_RDWR);
> ioctl(fd, BINDER_CTL_ADD, );
> 
> The struct binderfs_device will be used to return the major and minor
> number, as well as the index used as the new name for the device.
> Binderfs devices can simply be removed via unlink().

I think you should provide a name in the BINDER_CTL_ADD command.  That
way you can easily emulate the existing binder queues, and it saves you
a create/rename sequence that you will be forced to do otherwise.  Why
not do it just in a single command?

That way also you don't need to care about the major/minor number at
all.  Userspace should never need to worry about that, use a name,
that's the best thing.  Also, it allows you to drop the use of the idr,
making the kernel code simpler overall.

> /* Implementation details */
> - When binderfs is registered as a new filesystem it will dynamically
>   allocate a new major number. The allocated major number will be returned
>   in struct binderfs_device when a new binder device is allocated.

Why does userspace care about major/minor numbers at all?  You should
just be able to deal with the binder "names", that's all that userspace
uses normally as you are not calling mknod() yourself.

>   Minor numbers that have been given out are tracked in a global idr struct
>   that is capped at BINDERFS_MAX_MINOR. The minor number tracker is
>   protected by a global mutex. This is the only point of contention between
>   binderfs mounts.

I doubt this will be any real contention given that setting up / tearing
down binder mounts is going to be rare, right?  Well, hopefully, who
knows with some container systems...

> - The naming scheme for binder devices is binder%d. Each binderfs mount
>   starts numbering of new binder devices at 0 up to n. The indeces used in
>   constructing the name are tracked in a struct idr that is per-binderfs
>   super block.

Again, let userspace pick the name, as you will have to rename it anyway
to get userspace to work properly with it.

I'll stop repeating myself now :)

thanks,

greg k-h


Linux 4.9.143

2018-12-05 Thread Greg KH
I'm announcing the release of the 4.9.143 kernel.

All users of the 4.9 kernel series must upgrade.

The updated 4.9.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.9.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile   |   67 ++--
 arch/arm/Makefile  |2 
 arch/arm/boot/compressed/Makefile  |2 
 arch/arm/firmware/trusted_foundations.c|   14 +-
 arch/x86/events/core.c |   20 ---
 arch/x86/events/intel/core.c   |   52 +++---
 arch/x86/events/perf_event.h   |   13 +-
 arch/x86/kvm/mmu.c |   27 +
 arch/x86/kvm/svm.c |   20 ++-
 arch/x86/kvm/x86.c |3 
 arch/xtensa/kernel/asm-offsets.c   |   16 +--
 arch/xtensa/kernel/process.c   |5 
 drivers/bus/arm-cci.c  |2 
 drivers/dma/at_hdmac.c |   10 +
 drivers/firmware/efi/libstub/Makefile  |3 
 drivers/firmware/efi/libstub/efi-stub-helper.c |   11 +-
 drivers/hv/channel.c   |8 +
 drivers/iio/magnetometer/st_magn_buffer.c  |   12 --
 drivers/media/usb/em28xx/em28xx-dvb.c  |3 
 drivers/misc/mic/scif/scif_rma.c   |2 
 drivers/net/rionet.c   |2 
 drivers/net/usb/ipheth.c   |   10 -
 drivers/net/wireless/ti/wlcore/cmd.c   |6 -
 drivers/s390/net/qeth_core_main.c  |   27 ++---
 drivers/usb/core/quirks.c  |3 
 drivers/usb/dwc3/gadget.c  |5 
 drivers/usb/storage/unusual_realtek.h  |   10 +
 fs/btrfs/super.c   |1 
 fs/btrfs/transaction.c |6 -
 fs/direct-io.c |4 
 fs/ext2/xattr.c|2 
 include/linux/workqueue.h  |4 
 mm/huge_memory.c   |   79 +++
 mm/khugepaged.c|  129 ++---
 mm/shmem.c |   97 ++
 net/core/skbuff.c  |4 
 sound/core/control.c   |   80 ---
 sound/isa/wss/wss_lib.c|2 
 sound/pci/ac97/ac97_codec.c|2 
 sound/sparc/cs4231.c   |8 -
 40 files changed, 423 insertions(+), 350 deletions(-)

Alistair Strachan (1):
  efi/libstub: arm: support building with clang

Ard Biesheuvel (1):
  efi/libstub: Make file I/O chunking x86-specific

Arnd Bergmann (1):
  workqueue: avoid clang warning

Bernd Eckstein (1):
  usbnet: ipheth: fix potential recvmsg bug and recvmsg bug 2

Chris Fries (1):
  kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

Dexuan Cui (1):
  Drivers: hv: vmbus: check the creation_status in vmbus_establish_gpadl()

Felipe Balbi (1):
  Revert "usb: dwc3: gadget: skip Set/Clear Halt when invalid"

Filipe Manana (1):
  Btrfs: ensure path name is null terminated at btrfs_control_ioctl

Greg Kroah-Hartman (1):
  Linux 4.9.143

Hugh Dickins (9):
  mm/huge_memory: rename freeze_page() to unmap_page()
  mm/huge_memory: splitting set mapping+index before unfreeze
  mm/huge_memory: fix lockdep complaint on 32-bit i_size_read()
  mm/khugepaged: collapse_shmem() stop if punched or truncated
  mm/khugepaged: fix crashes due to misaccounted holes
  mm/khugepaged: collapse_shmem() remember to clear holes
  mm/khugepaged: minor reorderings in collapse_shmem()
  mm/khugepaged: collapse_shmem() without freezing new_page
  mm/khugepaged: collapse_shmem() do not crash on Compound

Jim Mattson (1):
  kvm: svm: Ensure an IBPB on all affected CPUs when freeing a vmcb

Jiri Olsa (2):
  perf/x86/intel: Move branch tracing setup to the Intel-specific source 
file
  perf/x86/intel: Add generic branch tracing check to intel_pmu_has_bts()

Josef Bacik (1):
  btrfs: release metadata before running delayed refs

Julian Wiedmann (1):
  s390/qeth: fix length check in SNMP processing

Junaid Shahid (1):
  kvm: mmu: Fix race in emulated page table writes

Kai-Heng Feng (1):
  USB: usb-storage: Add new IDs to ums-realtek

Konstantin Khlebnikov (1):
  mm/huge_memory.c: reorder operations in __split_huge_page_tail()

Martin Kelly (1):
  iio:st_magn: Fix enable device after trigger

Matthias Schwarzott (1):
  media: em28xx: Fix use-after-free when disconnecting

Max Filippov (2):
  xtensa: enable coprocessors that are 

Re: Linux 4.9.143

2018-12-05 Thread Greg KH
diff --git a/Makefile b/Makefile
index 72ed8ff90329..8ec52cd19526 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 VERSION = 4
 PATCHLEVEL = 9
-SUBLEVEL = 142
+SUBLEVEL = 143
 EXTRAVERSION =
 NAME = Roaring Lionus
 
@@ -509,6 +509,39 @@ ifneq ($(filter install,$(MAKECMDGOALS)),)
 endif
 endif
 
+ifeq ($(cc-name),clang)
+ifneq ($(CROSS_COMPILE),)
+CLANG_TARGET   := -target $(notdir $(CROSS_COMPILE:%-=%))
+GCC_TOOLCHAIN  := $(realpath $(dir $(shell which $(LD)))/..)
+endif
+ifneq ($(GCC_TOOLCHAIN),)
+CLANG_GCC_TC   := -gcc-toolchain $(GCC_TOOLCHAIN)
+endif
+KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
+KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
+KBUILD_CPPFLAGS += $(call cc-option,-Qunused-arguments,)
+KBUILD_CFLAGS += $(call cc-disable-warning, unused-variable)
+KBUILD_CFLAGS += $(call cc-disable-warning, format-invalid-specifier)
+KBUILD_CFLAGS += $(call cc-disable-warning, gnu)
+KBUILD_CFLAGS += $(call cc-disable-warning, address-of-packed-member)
+# Quiet clang warning: comparison of unsigned expression < 0 is always false
+KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare)
+# CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
+# source of a reference will be _MergedGlobals and not on of the whitelisted 
names.
+# See modpost pattern 2
+KBUILD_CFLAGS += $(call cc-option, -mno-global-merge,)
+KBUILD_CFLAGS += $(call cc-option, -fcatch-undefined-behavior)
+KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
+KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
+else
+
+# These warnings generated too much noise in a regular build.
+# Use make W=1 to enable them (see scripts/Makefile.build)
+KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
+KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
+endif
+
+
 ifeq ($(mixed-targets),1)
 # ===
 # We're called with mixed targets (*config and build targets).
@@ -704,38 +737,6 @@ ifdef CONFIG_CC_STACKPROTECTOR
 endif
 KBUILD_CFLAGS += $(stackp-flag)
 
-ifeq ($(cc-name),clang)
-ifneq ($(CROSS_COMPILE),)
-CLANG_TARGET   := -target $(notdir $(CROSS_COMPILE:%-=%))
-GCC_TOOLCHAIN  := $(realpath $(dir $(shell which $(LD)))/..)
-endif
-ifneq ($(GCC_TOOLCHAIN),)
-CLANG_GCC_TC   := -gcc-toolchain $(GCC_TOOLCHAIN)
-endif
-KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
-KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
-KBUILD_CPPFLAGS += $(call cc-option,-Qunused-arguments,)
-KBUILD_CFLAGS += $(call cc-disable-warning, unused-variable)
-KBUILD_CFLAGS += $(call cc-disable-warning, format-invalid-specifier)
-KBUILD_CFLAGS += $(call cc-disable-warning, gnu)
-KBUILD_CFLAGS += $(call cc-disable-warning, address-of-packed-member)
-# Quiet clang warning: comparison of unsigned expression < 0 is always false
-KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare)
-# CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
-# source of a reference will be _MergedGlobals and not on of the whitelisted 
names.
-# See modpost pattern 2
-KBUILD_CFLAGS += $(call cc-option, -mno-global-merge,)
-KBUILD_CFLAGS += $(call cc-option, -fcatch-undefined-behavior)
-KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
-KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
-else
-
-# These warnings generated too much noise in a regular build.
-# Use make W=1 to enable them (see scripts/Makefile.build)
-KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
-KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
-endif
-
 ifdef CONFIG_FRAME_POINTER
 KBUILD_CFLAGS  += -fno-omit-frame-pointer -fno-optimize-sibling-calls
 else
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 6be9ee148b78..e14ddca59d02 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -104,7 +104,7 @@ tune-$(CONFIG_CPU_V6K)  =$(call 
cc-option,-mtune=arm1136j-s,-mtune=strongarm)
 tune-y := $(tune-y)
 
 ifeq ($(CONFIG_AEABI),y)
-CFLAGS_ABI :=-mabi=aapcs-linux -mno-thumb-interwork -mfpu=vfp
+CFLAGS_ABI :=-mabi=aapcs-linux -mfpu=vfp
 else
 CFLAGS_ABI :=$(call cc-option,-mapcs-32,-mabi=apcs-gnu) $(call 
cc-option,-mno-thumb-interwork,)
 endif
diff --git a/arch/arm/boot/compressed/Makefile 
b/arch/arm/boot/compressed/Makefile
index d50430c40045..552c7d7f84ce 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -112,7 +112,7 @@ CFLAGS_fdt_ro.o := $(nossp_flags)
 CFLAGS_fdt_rw.o := $(nossp_flags)
 CFLAGS_fdt_wip.o := $(nossp_flags)
 
-ccflags-y := -fpic -mno-single-pic-base -fno-builtin -I$(obj)
+ccflags-y := -fpic $(call cc-option,-mno-single-pic-base,) -fno-builtin 
-I$(obj)
 asflags-y := -DZIMAGE
 
 # Supply kernel BSS size to the decompressor via a linker symbol.
diff --git a/arch/arm/firmware/trusted_foundations.c 
b/arch/arm/firmware/trusted_foundations.c
index 3fb1b5a1dce9..689e6565abfc 100644
--- 

Linux 4.14.86

2018-12-05 Thread Greg KH
I'm announcing the release of the 4.14.86 kernel.

All users of the 4.14 kernel series must upgrade.

The updated 4.14.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.14.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/admin-guide/kernel-parameters.txt   |   56 
 Documentation/userspace-api/spec_ctrl.rst |9 
 Makefile  |2 
 arch/arm/boot/dts/rk3288-veyron.dtsi  |6 
 arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts   |2 
 arch/x86/Kconfig  |   12 
 arch/x86/Makefile |5 
 arch/x86/events/core.c|   20 
 arch/x86/events/intel/core.c  |   52 
 arch/x86/events/perf_event.h  |   13 
 arch/x86/include/asm/cpufeatures.h|2 
 arch/x86/include/asm/msr-index.h  |5 
 arch/x86/include/asm/nospec-branch.h  |   44 
 arch/x86/include/asm/spec-ctrl.h  |   20 
 arch/x86/include/asm/switch_to.h  |3 
 arch/x86/include/asm/thread_info.h|   20 
 arch/x86/include/asm/tlbflush.h   |8 
 arch/x86/kernel/cpu/amd.c |4 
 arch/x86/kernel/cpu/bugs.c|  510 ++-
 arch/x86/kernel/cpu/common.c  |9 
 arch/x86/kernel/cpu/mcheck/mce_amd.c  |   19 
 arch/x86/kernel/fpu/signal.c  |4 
 arch/x86/kernel/process.c |  101 +
 arch/x86/kernel/process.h |   39 
 arch/x86/kernel/process_32.c  |   10 
 arch/x86/kernel/process_64.c  |   10 
 arch/x86/kvm/cpuid.c  |   10 
 arch/x86/kvm/mmu.c|   27 
 arch/x86/kvm/svm.c|   28 
 arch/x86/kvm/x86.c|4 
 arch/x86/mm/tlb.c |  115 +
 arch/xtensa/kernel/asm-offsets.c  |   16 
 arch/xtensa/kernel/process.c  |5 
 arch/xtensa/kernel/ptrace.c   |   42 
 drivers/android/binder.c  |   21 
 drivers/android/binder_alloc.c|   14 
 drivers/android/binder_alloc.h|3 
 drivers/dma/at_hdmac.c|   10 
 drivers/hv/channel.c  |8 
 drivers/iio/magnetometer/st_magn_buffer.c |   12 
 drivers/media/usb/em28xx/em28xx-dvb.c |3 
 drivers/misc/mic/scif/scif_rma.c  |2 
 drivers/mtd/ubi/vtbl.c|   20 
 drivers/net/ethernet/cavium/thunder/nicvf_main.c  |9 
 drivers/net/ethernet/cavium/thunder/nicvf_queues.c|4 
 drivers/net/rionet.c  |2 
 drivers/net/usb/ipheth.c  |   10 
 drivers/net/virtio_net.c  |   13 
 drivers/net/wireless/ath/wil6210/wmi.c|8 
 drivers/net/wireless/ti/wlcore/cmd.c  |6 
 drivers/pci/dwc/pci-layerscape.c  |2 
 drivers/s390/net/qeth_core_main.c |   27 
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c |2 
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c |7 
 drivers/usb/core/quirks.c |3 
 drivers/usb/dwc3/gadget.c |5 
 drivers/usb/storage/unusual_realtek.h |   10 
 fs/btrfs/Makefile |2 
 fs/btrfs/disk-io.c|  153 --
 fs/btrfs/extent-tree.c|   86 +
 fs/btrfs/relocation.c |1 
 fs/btrfs/super.c  |1 
 fs/btrfs/transaction.c|6 
 fs/btrfs/tree-checker.c   |  649 ++
 

Linux 4.19.7

2018-12-05 Thread Greg KH
I'm announcing the release of the 4.19.7 kernel.

All users of the 4.19 kernel series must upgrade.

The updated 4.19.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.19.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/admin-guide/kernel-parameters.txt   |   56 +
 Documentation/userspace-api/spec_ctrl.rst |9 
 Makefile  |2 
 arch/arm/boot/dts/rk3288-veyron.dtsi  |6 
 arch/arm/kernel/ftrace.c  |   17 
 arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts   |2 
 arch/arm64/kernel/ftrace.c|   15 
 arch/microblaze/kernel/ftrace.c   |   15 
 arch/mips/kernel/ftrace.c |   14 
 arch/nds32/kernel/ftrace.c|   18 
 arch/parisc/kernel/ftrace.c   |   17 
 arch/powerpc/kernel/trace/ftrace.c|   15 
 arch/riscv/kernel/ftrace.c|   14 
 arch/s390/kernel/ftrace.c |   13 
 arch/sh/kernel/ftrace.c   |   16 
 arch/sparc/kernel/ftrace.c|   11 
 arch/x86/Kconfig  |   12 
 arch/x86/Makefile |5 
 arch/x86/events/core.c|   20 
 arch/x86/events/intel/core.c  |   56 -
 arch/x86/events/perf_event.h  |   13 
 arch/x86/include/asm/kvm_host.h   |3 
 arch/x86/include/asm/msr-index.h  |5 
 arch/x86/include/asm/nospec-branch.h  |   43 
 arch/x86/include/asm/spec-ctrl.h  |   20 
 arch/x86/include/asm/switch_to.h  |3 
 arch/x86/include/asm/thread_info.h|   20 
 arch/x86/include/asm/tlbflush.h   |8 
 arch/x86/kernel/cpu/bugs.c|  493 --
 arch/x86/kernel/cpu/mcheck/mce_amd.c  |   19 
 arch/x86/kernel/fpu/signal.c  |4 
 arch/x86/kernel/ftrace.c  |   15 
 arch/x86/kernel/process.c |  101 +-
 arch/x86/kernel/process.h |   39 
 arch/x86/kernel/process_32.c  |   10 
 arch/x86/kernel/process_64.c  |   10 
 arch/x86/kvm/lapic.c  |5 
 arch/x86/kvm/mmu.c|   27 
 arch/x86/kvm/svm.c|   25 
 arch/x86/kvm/vmx.c|   22 
 arch/x86/kvm/x86.c|   10 
 arch/x86/mm/tlb.c |  115 +-
 arch/xtensa/kernel/asm-offsets.c  |   16 
 arch/xtensa/kernel/process.c  |5 
 arch/xtensa/kernel/ptrace.c   |   42 
 drivers/android/binder.c  |   21 
 drivers/android/binder_alloc.c|   16 
 drivers/android/binder_alloc.h|3 
 drivers/dma/at_hdmac.c|   10 
 drivers/hid/hid-sensor-custom.c   |2 
 drivers/hid/hid-sensor-hub.c  |   13 
 drivers/hv/channel.c  |8 
 drivers/iio/accel/hid-sensor-accel-3d.c   |5 
 drivers/iio/gyro/hid-sensor-gyro-3d.c |5 
 drivers/iio/humidity/hid-sensor-humidity.c|3 
 drivers/iio/light/hid-sensor-als.c|8 
 drivers/iio/light/hid-sensor-prox.c   |8 
 drivers/iio/magnetometer/hid-sensor-magn-3d.c |8 
 drivers/iio/magnetometer/st_magn_buffer.c |   12 
 drivers/iio/orientation/hid-sensor-incl-3d.c  |8 
 drivers/iio/pressure/hid-sensor-press.c   |8 
 drivers/iio/temperature/hid-sensor-temperature.c  |3 
 drivers/misc/mic/scif/scif_rma.c  |2 
 drivers/net/ethernet/cavium/thunder/nicvf_main.c  |9 
 

Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Wed, Dec 05, 2018 at 10:39:56AM -0500, Sven Van Asbroeck wrote:
> Hello Greg, thanks for the feedback!
> 
> On Wed, Dec 5, 2018 at 5:17 AM Greg KH  wrote:
> > And why is this a class and not just a "normal" device and bus?  Devices
> > live on busses, not generally as a class.  Can your devices live on
> > different types of busses (USB, PCI, etc.)?
> 
> This patchset can be a bit confusing, because it doesn't just add support for 
> a
> single fieldbus device - it proposes a general fieldbus subsystem.

Great, then call it a 'fieldbus' class, not "fieldbus_dev' class.

Devices can belong to a bus, or a class, so you are fine here.

> Fieldbus devices from different vendors can sit on the usb, i2c, pci, etc.
> buse, but they all register as a fieldbus device, via fieldbus_dev_register(),
> and show up as a fieldbus class member.

ok, I'm just complaining about your name in sysfs, not your code :)

I think what you did here is correct from a logic point of view.

> Userspace can then enumerate all fieldbus devices connected to the system by
> looking at the class. Without having to know which bus they happen to be
> connected to.

Sounds reasonable.

nice work,

greg k-h


Re: [PATCH 0/2] Fix return code and improve feature check for synthetic uevents

2018-12-05 Thread Greg KH
On Wed, Dec 05, 2018 at 12:27:43PM +0100, Peter Rajnoha wrote:
> Two small patches to aid handling of synthetic uevents back in userspace:
> 
>   - Return error code back to userspace on /sys/.../uevent file write
> failure so userspace knows and it can act accordingly.
> 
>   - Add new 'kernel/uevent_features' sysfs file to make it possible for
> userspace to check that the extended synthetic uevent arguments are
> supported without relying on kernel version check only.
> 
> Peter Rajnoha (2):
>   kobject: return error code if writing /sys/.../uevent fails
>   kobject: add kernel/uevent_features sysfs file

Did you send this series twice?  Which one should I pay attention to?

confused,

greg k-h


Re: [PATCH] Fonts: New Terminus large console font

2018-12-05 Thread Greg KH
On Mon, Nov 26, 2018 at 04:21:15AM -0500, Amanoel Dawod wrote:
> This patch adds an option to compile-in a high resolution and large
> Terminus (ter16x32) bitmap console font for use with HiDPI and Retina screens.
> 
> The font was convereted from standard Terminus ter-i32b.psf (size 16x32)
> with the help of psftools and minor hand editing deleting useless characters.
> 
> This patch is non-intrusive, no options are enabled by default so most
> users won't notice a thing.
> 
> I am placing my changes under the GPL 2.0 just as source Terminus font.

Can you please run scripts/checkpatch.pl and fix up the issues that it
finds in this patch.  It's a lot:
total: 1792 errors, 2058 warnings, 2127 lines checked

thanks,

greg k-h


Re: [PATCH] binder: fix use-after-free due to fdget() optimization

2018-12-05 Thread Greg KH
On Mon, Dec 03, 2018 at 12:24:57PM -0800, Todd Kjos wrote:
> 44d8047f1d87a ("binder: use standard functions to allocate fds")
> exposed a pre-existing issue in the binder driver.
> 
> fdget() is used in ksys_ioctl() as a performance optimization.
> One of the rules associated with fdget() is that ksys_close() must
> not be called between the fdget() and the fdput(). There is a case
> where this requirement is not met in the binder driver (and possibly
> other drivers) which results in the reference count dropping to 0
> when the device is still in use. This can result in use-after-free
> or other issues.
> 
> This was observed with the following sequence of events:
> 
> Task A and task B are connected via binder; task A has /dev/binder open at
> file descriptor number X. Both tasks are single-threaded.
> 
> 1. task B sends a binder message with a file descriptor array
>(BINDER_TYPE_FDA) containing one file descriptor to task A
> 2. task A reads the binder message with the translated file
>descriptor number Y
> 3. task A uses dup2(X, Y) to overwrite file descriptor Y with
>the /dev/binder file
> 4. task A unmaps the userspace binder memory mapping; the reference
>count on task A's /dev/binder is now 2
> 5. task A closes file descriptor X; the reference count on task
>A's /dev/binder is now 1
> 6. task A forks off a child, task C, duplicating the file descriptor
>table; the reference count on task A's /dev/binder is now 2
> 7. task A invokes the BC_FREE_BUFFER command on file descriptor X
>to release the incoming binder message
> 8. fdget() in ksys_ioctl() suppresses the reference count increment,
>since the file descriptor table is not shared
> 9. the BC_FREE_BUFFER handler removes the file descriptor table
>entry for X and decrements the reference count of task A's
>/dev/binder file to 1
> 10.task C calls close(X), which drops the reference count of
>task A's /dev/binder to 0 and frees it
> 11.task A continues processing of the ioctl and accesses some
>property of e.g. the binder_proc => KASAN-detectable UAF
> 
> Fixed by using get_file() / fput() in binder_ioctl().
> 
> Suggested-by: Jann Horn 
> Signed-off-by: Todd Kjos 
> Acked-by: Martijn Coenen 

Shouldn't this go to 4.20-final?  And have a stable@ tag?
And a "Fixes:" tag?

thanks,

greg k-h


Re: [PATCH] binder: fix kerneldoc header for struct binder_buffer

2018-12-05 Thread Greg KH
On Mon, Dec 03, 2018 at 12:24:55PM -0800, Todd Kjos wrote:
> Fix the incomplete kerneldoc header for struct binder_buffer.
> 
> Change-Id: If3ca10cf6d90f605a0c078e4cdce28f02a475877

No need for this here :)



Re: [PATCH] binder: fix sparse warnings on locking context

2018-12-05 Thread Greg KH
On Mon, Dec 03, 2018 at 12:24:54PM -0800, Todd Kjos wrote:
> Add __acquire()/__release() annnotations to fix warnings
> in sparse context checking
> 
> There is one case where the warning was due to a lack of
> a "default:" case in a switch statement where a lock was
> being released in each of the cases, so the default
> case was added.
> 
> Signed-off-by: Todd Kjos 

You sent out 4 patches here, as a series, but with no numbering so I
don't know what order to put them in :(

Can you resend them properly numbered so I have a chance to get it
right?

thanks,

greg k-h


Re: [PATCH v5 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2018-12-05 Thread Greg KH
On Tue, Dec 04, 2018 at 05:02:19PM -0500, Sven Van Asbroeck wrote:
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-fieldbus-dev
> @@ -0,0 +1,63 @@
> +What:/sys/class/fieldbus_dev/fieldbus_devX/card_name

Here's a good example of your naming being a bit too "verbose" :)

There is no need to name your devices with the same prefix as your
class.  Just make it:
/sys/class/fieldbus/XXX/card_name

And why is this a class and not just a "normal" device and bus?  Devices
live on busses, not generally as a class.  Can your devices live on
different types of busses (USB, PCI, etc.)?

But, if you really just want to leave this as a "class", then just call
it "fieldbus" and make it simple.  You are only exposing the
"fieldbus-specific" type of attributes here, so that's probably good
enough for now.

> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -187,4 +187,5 @@ obj-$(CONFIG_TEE) += tee/
>  obj-$(CONFIG_MULTIPLEXER)+= mux/
>  obj-$(CONFIG_UNISYS_VISORBUS)+= visorbus/
>  obj-$(CONFIG_SIOX)   += siox/
> +obj-$(CONFIG_FIELDBUS_DEV)   += fieldbus/
>  obj-$(CONFIG_GNSS)   += gnss/

Why not after gnss?

> --- /dev/null
> +++ b/drivers/fieldbus/Makefile
> @@ -0,0 +1,9 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Makefile for fieldbus_dev drivers.
> +#
> +
> +obj-$(CONFIG_FIELDBUS_DEV)   += fieldbus_dev_core.o

Why not just "fieldbus.o"?

> +static ssize_t online_show(struct device *dev, struct device_attribute *attr,
> + char *buf)
> +{
> + struct fieldbus_dev *fb = dev_get_drvdata(dev);
> +
> + return snprintf(buf, PAGE_SIZE, "%s\n",

Nit, sysfs attributes are always so small that you don't need to care
about the size of the buffer because you "always" know that you will not
overflow it.

So this can just be a simple:
return sprintf(buf, "%s\n", ...);

> + fb->online ? "online" : "offline");
> +}
> +static DEVICE_ATTR_RO(online);
> +
> +static ssize_t enabled_show(struct device *dev, struct device_attribute 
> *attr,
> + char *buf)
> +{
> + struct fieldbus_dev *fb = dev_get_drvdata(dev);
> +
> + if (!fb->enable_get)
> + return -EINVAL;
> + return snprintf(buf, PAGE_SIZE, "%s\n",
> + fb->enable_get(fb) ? ctrl_enabled : ctrl_disabled);
> +}

New line?

> +static ssize_t enabled_store(struct device *dev, struct device_attribute 
> *attr,
> +  const char *buf, size_t n)
> +{
> + struct fieldbus_dev *fb = dev_get_drvdata(dev);
> + int err;
> +
> + if (!fb->simple_enable_set) {
> + n = -ENOTSUPP;
> + } else if (sysfs_streq(buf, ctrl_enabled)) {

Why not just have the normal "0/1" type of parsing?  We have a function
for it already, kstrtobool().

thanks,

greg k-h


Re: [PATCH 4.14 018/146] libceph: implement CEPHX_V2 calculation mode

2018-12-04 Thread Greg KH
On Tue, Dec 04, 2018 at 01:06:40PM +0100, Ilya Dryomov wrote:
> On Tue, Dec 4, 2018 at 12:01 PM Greg Kroah-Hartman
>  wrote:
> >
> > 4.14-stable review patch.  If anyone has any objections, please let me know.
> >
> > --
> >
> > commit cc255c76c70f7a87d97939621eae04b600d9f4a1 upstream.
> >
> > Derive the signature from the entire buffer (both AES cipher blocks)
> > instead of using just the first half of the first block, leaving out
> > data_crc entirely.
> >
> > This addresses CVE-2018-1129.
> >
> > Link: http://tracker.ceph.com/issues/24837
> > Signed-off-by: Ilya Dryomov 
> > Reviewed-by: Sage Weil 
> > Signed-off-by: Ben Hutchings 
> > Signed-off-by: Sasha Levin 
> > ---
> >  include/linux/ceph/ceph_features.h |  7 +--
> >  net/ceph/auth_x.c  | 73 +++---
> >  2 files changed, 60 insertions(+), 20 deletions(-)
> >
> > diff --git a/include/linux/ceph/ceph_features.h 
> > b/include/linux/ceph/ceph_features.h
> > index 59042d5ac520..70f42eef813b 100644
> > --- a/include/linux/ceph/ceph_features.h
> > +++ b/include/linux/ceph/ceph_features.h
> > @@ -165,9 +165,9 @@ DEFINE_CEPH_FEATURE(58, 1, FS_FILE_LAYOUT_V2) // overlap
> >  DEFINE_CEPH_FEATURE(59, 1, FS_BTIME)
> >  DEFINE_CEPH_FEATURE(59, 1, FS_CHANGE_ATTR) // overlap
> >  DEFINE_CEPH_FEATURE(59, 1, MSG_ADDR2) // overlap
> > -DEFINE_CEPH_FEATURE(60, 1, BLKIN_TRACING)  // *do not share this bit*
> > +DEFINE_CEPH_FEATURE(60, 1, OSD_RECOVERY_DELETES) // *do not share this bit*
> > +DEFINE_CEPH_FEATURE(61, 1, CEPHX_V2) // *do not share this bit*
> >
> > -DEFINE_CEPH_FEATURE(61, 1, RESERVED2)  // unused, but slow down!
> >  DEFINE_CEPH_FEATURE(62, 1, RESERVED)   // do not use; used as a 
> > sentinal
> >  DEFINE_CEPH_FEATURE_DEPRECATED(63, 1, RESERVED_BROKEN, LUMINOUS) // 
> > client-facing
> >
> > @@ -209,7 +209,8 @@ DEFINE_CEPH_FEATURE_DEPRECATED(63, 1, RESERVED_BROKEN, 
> > LUMINOUS) // client-facin
> >  CEPH_FEATURE_SERVER_JEWEL |\
> >  CEPH_FEATURE_MON_STATEFUL_SUB |\
> >  CEPH_FEATURE_CRUSH_TUNABLES5 | \
> > -CEPH_FEATURE_NEW_OSDOPREPLY_ENCODING)
> > +CEPH_FEATURE_NEW_OSDOPREPLY_ENCODING | \
> > +CEPH_FEATURE_CEPHX_V2)
> >
> >  #define CEPH_FEATURES_REQUIRED_DEFAULT   \
> > (CEPH_FEATURE_NOSRCADDR |\
> > diff --git a/net/ceph/auth_x.c b/net/ceph/auth_x.c
> > index ce28bb07d8fd..10eb759bbcb4 100644
> > --- a/net/ceph/auth_x.c
> > +++ b/net/ceph/auth_x.c
> > @@ -9,6 +9,7 @@
> >
> >  #include 
> >  #include 
> > +#include 
> >  #include 
> >  #include 
> >
> > @@ -803,26 +804,64 @@ static int calc_signature(struct ceph_x_authorizer 
> > *au, struct ceph_msg *msg,
> >   __le64 *psig)
> >  {
> > void *enc_buf = au->enc_buf;
> > -   struct {
> > -   __le32 len;
> > -   __le32 header_crc;
> > -   __le32 front_crc;
> > -   __le32 middle_crc;
> > -   __le32 data_crc;
> > -   } __packed *sigblock = enc_buf + ceph_x_encrypt_offset();
> > int ret;
> >
> > -   sigblock->len = cpu_to_le32(4*sizeof(u32));
> > -   sigblock->header_crc = msg->hdr.crc;
> > -   sigblock->front_crc = msg->footer.front_crc;
> > -   sigblock->middle_crc = msg->footer.middle_crc;
> > -   sigblock->data_crc =  msg->footer.data_crc;
> > -   ret = ceph_x_encrypt(>session_key, enc_buf, 
> > CEPHX_AU_ENC_BUF_LEN,
> > -sizeof(*sigblock));
> > -   if (ret < 0)
> > -   return ret;
> > +   if (!CEPH_HAVE_FEATURE(msg->con->peer_features, CEPHX_V2)) {
> > +   struct {
> > +   __le32 len;
> > +   __le32 header_crc;
> > +   __le32 front_crc;
> > +   __le32 middle_crc;
> > +   __le32 data_crc;
> > +   } __packed *sigblock = enc_buf + ceph_x_encrypt_offset();
> > +
> > +   sigblock->len = cpu_to_le32(4*sizeof(u32));
> > +   sigblock->header_crc = msg->hdr.crc;
> > +   sigblock->front_crc = msg->footer.front_crc;
> > +   sigblock->middle_crc = msg->footer.middle_crc;
> > +   sigblock->data_crc =  msg->footer.data_crc;
> > +
> > +   ret = ceph_x_encrypt(>session_key, enc_buf,
> > +CEPHX_AU_ENC_BUF_LEN, 
> > sizeof(*sigblock));
> > +   if (ret < 0)
> > +   return ret;
> > +
> > +   *psig = *(__le64 *)(enc_buf + sizeof(u32));
> > +   } else {
> > +   struct {
> > +   __le32 header_crc;
> > +   __le32 front_crc;
> > +   __le32 front_len;
> > +   __le32 middle_crc;
> > +   __le32 middle_len;
> > +   __le32 data_crc;
> > +   __le32 data_len;

Re: linux-next: manual merge of the char-misc tree with the char-misc.current tree

2018-12-03 Thread Greg KH
On Tue, Dec 04, 2018 at 03:35:13PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the char-misc tree got a conflict in:
> 
>   drivers/hv/channel_mgmt.c
> 
> between commit:
> 
>   37c2578c0c40 ("Drivers: hv: vmbus: Offload the handling of channels to two 
> workqueues")
> 
> from the char-misc.current tree and commit:
> 
>   4d3c5c69191f ("Drivers: hv: vmbus: Remove the useless API 
> vmbus_get_outgoing_channel()")
> 
> from the char-misc tree.
> 
> I fixed it up (I used the former version where they conflicted) and can
> carry the fix as necessary. This is now fixed as far as linux-next is
> concerned, but any non trivial conflicts should be mentioned to your
> upstream maintainer when your tree is submitted for merging.  You may
> also want to consider cooperating with the maintainer of the conflicting
> tree to minimise any particularly complex conflicts.

Yeah, this is a mess, I'll wait for the hyper-v developers to send me a
fixup patch for handling this merge issue, as they know it is happening
:(

thanks,

greg k-h


Re: [PATCH AUTOSEL 4.14 25/35] iomap: sub-block dio needs to zeroout beyond EOF

2018-12-03 Thread Greg KH
On Mon, Dec 03, 2018 at 11:22:46PM +0159, Thomas Backlund wrote:
> Den 2018-12-03 kl. 11:22, skrev Sasha Levin:
> 
> > 
> > This is a case where theory collides with the real world. Yes, our QA is
> > lacking, but we don't have the option of not doing the current process.
> > If we stop backporting until a future data where our QA problem is
> > solved we'll end up with what we had before: users stuck on ancient
> > kernels without a way to upgrade.
> > 
> 
> Sorry, but you seem to be living in a different "real world"...
> 
> People stay on "ancient kernels" that "just works" instead of updating
> to a newer one that "hopefully/maybe/... works"

That's not good as those "ancient kernels" really just are "kernels with
lots of known security bugs".

It's your systems, I can't tell you what to do, but I will tell you that
running older, unfixed kernels, is a known liability.

Good luck!

greg k-h


Re: v4.14 fix for Hikey 960 unbalanced IRQ enablement

2018-12-03 Thread Greg KH
On Mon, Dec 03, 2018 at 10:19:46AM -0500, Sasha Levin wrote:
> On Mon, Dec 03, 2018 at 03:42:41PM +0100, Daniel Lezcano wrote:
> > On 03/12/2018 15:14, Greg KH wrote:
> > > On Mon, Dec 03, 2018 at 11:31:02AM -0200, Rafael David Tinoco wrote:
> > > > Sasha, could you consider including this cherry-picked patchset in 
> > > > v4.14.
> > > > 
> > > > Kernel v4.14 might suffer from the following unbalanced enablement for 
> > > > the board Hikey 960:
> > > > 
> > > > Nov  5 12:02:54 hikey kernel: [   22.148194] Unbalanced enable for IRQ 
> > > > 44
> > > > Nov  5 12:02:54 hikey kernel: [   22.152193] [ cut here 
> > > > ]
> > > > Nov  5 12:02:54 hikey kernel: [   22.156872] WARNING: CPU: 2 PID: 509 
> > > > at 
> > > > /home/inaddy/work/sources/linux/stable/stable-linux-4.14.y/kernel/irq/manage.c:525
> > > >  __enable_irq+0x78/0x80
> > > > Nov  5 12:02:54 hikey kernel: [   22.249606] CPU: 2 PID: 509 Comm: 
> > > > kworker/2:2 Not tainted 4.14.79 #1
> > > > Nov  5 12:02:54 hikey kernel: [   22.255975] Hardware name: HiKey 
> > > > Development Board (DT)
> > > > Nov  5 12:02:54 hikey kernel: [   22.261248] Workqueue: 
> > > > events_freezable thermal_zone_device_check
> > > > Nov  5 12:02:54 hikey kernel: [   22.267368] task: 8000616e0e00 
> > > > task.stack: 0b5f
> > > > Nov  5 12:02:54 hikey kernel: [   22.273312] PC is at 
> > > > __enable_irq+0x78/0x80
> > > > Nov  5 12:02:54 hikey kernel: [   22.277516] LR is at 
> > > > __enable_irq+0x78/0x80
> > > > Nov  5 12:02:54 hikey kernel: [   22.281718] pc : [] 
> > > > lr : [] pstate: 01c5
> > > > Nov  5 12:02:54 hikey kernel: [   22.289129] sp : 0b5f3c80
> > > > Nov  5 12:02:54 hikey kernel: [   22.292457] x29: 0b5f3c80 x28: 
> > > > 
> > > > Nov  5 12:02:54 hikey kernel: [   22.297804] x27: 80005c139e38 x26: 
> > > > 08a71870
> > > > Nov  5 12:02:54 hikey kernel: [   22.303148] x25:  x24: 
> > > > 0002
> > > > Nov  5 12:02:54 hikey kernel: [   22.308492] x23: 0b5f3d9c x22: 
> > > > 80005d565e88
> > > > Nov  5 12:02:54 hikey kernel: [   22.313836] x21: f980 x20: 
> > > > 002c
> > > > Nov  5 12:02:54 hikey kernel: [   22.319181] x19: 800061726000 x18: 
> > > > 0010
> > > > Nov  5 12:02:54 hikey kernel: [   22.324524] x17:  x16: 
> > > > 
> > > > Nov  5 12:02:54 hikey kernel: [   22.329868] x15:  x14: 
> > > > 09269c08
> > > > Nov  5 12:02:54 hikey kernel: [   22.335213] x13: 8940678f x12: 
> > > > 09406797
> > > > Nov  5 12:02:54 hikey kernel: [   22.340558] x11: 0929 x10: 
> > > > 0b5f3980
> > > > Nov  5 12:02:54 hikey kernel: [   22.345902] x9 : ffd0 x8 : 
> > > > 0862c298
> > > > Nov  5 12:02:54 hikey kernel: [   22.351246] x7 : 6c62616e65206465 x6 : 
> > > > 01b2
> > > > Nov  5 12:02:54 hikey kernel: [   22.356589] x5 :  x4 : 
> > > > 
> > > > Nov  5 12:02:54 hikey kernel: [   22.361931] x3 :  x2 : 
> > > > 800063e824c8
> > > > Nov  5 12:02:54 hikey kernel: [   22.367275] x1 : 80005af95000 x0 : 
> > > > 001c
> > > > Nov  5 12:02:54 hikey kernel: [   22.372618] Call trace:
> > > > Nov  5 12:02:54 hikey kernel: [   22.375088] Exception 
> > > > stack(0x0b5f3b40 to 0x0b5f3c80)
> > > > Nov  5 12:02:54 hikey kernel: [   22.381560] 3b40: 001c 
> > > > 80005af95000 800063e824c8 
> > > > Nov  5 12:02:54 hikey kernel: [   22.389417] 3b60:  
> > > >  01b2 6c62616e65206465
> > > > Nov  5 12:02:54 hikey kernel: [   22.397276] 3b80: 0862c298 
> > > > ffd0 0b5f3980 0929
> > > > Nov  5 12:02:54 hikey kernel: [   22.405136] 3ba0: 09406797 
> > > > 8940678f 09269c08 
> > > > Nov  5 12:02:54 hikey kernel: [   22.412994] 3bc0:  
> > > >  0010 

Re: [PATCH v3] code-of-conduct: Remove explicit list of discrimination factors

2018-12-03 Thread Greg KH
On Mon, Dec 03, 2018 at 12:53:00PM +0100, Geert Uytterhoeven wrote:
> Hi Greg,
> 
> On Mon, Dec 3, 2018 at 12:05 PM Greg Kroah-Hartman
>  wrote:
> > On Sun, Dec 02, 2018 at 10:32:57AM +0100, Geert Uytterhoeven wrote:
> > > Providing an explicit list of discrimination factors may give the false
> > > impression that discrimination based on other unlisted factors would be
> > > allowed.
> > >
> > > Furthermore, this list is already overly long, polarizing,
> > > politically-laden, and reinstating the concept of human races.
> > > None of these is related to the goals of the Linux kernel project.
> > >
> > > Avoid any ambiguity or political undertone by removing the list, to
> > > ensure "a harassment-free experience for everyone", period.
> >
> > I understand the reason you and others are proposing this change,
> > however for now, let us stick with the text that we have.  As Linus and
> > I said just over a month ago, let's sit with the text we have until
> > something comes up that requires a change to happen.
> >
> > Also, I recommend you work with the upstream developers of this text to
> > see if they agree with your changes here.  If they do, and update their
> > version, I will be glad to revisit this text at that time.
> 
> I did, cfr. 
> https://github.com/ContributorCovenant/contributor_covenant/issues/610
> 
> The official response was:
> 
>"I'm not going to make this change to the Contributor Covenant itself,
> since I believe that explicitly listing examples of protected classes is
> important. However, any adopting project is free to modify the document
> according to the license."

I figured.  As I said, some people feel that the list is good to have,
if not essential.  So let's stick with it for now.

thanks,

greg k-h


Re: v4.14 fix for Hikey 960 unbalanced IRQ enablement

2018-12-03 Thread Greg KH
On Mon, Dec 03, 2018 at 11:31:02AM -0200, Rafael David Tinoco wrote:
> Sasha, could you consider including this cherry-picked patchset in v4.14.
> 
> Kernel v4.14 might suffer from the following unbalanced enablement for the 
> board Hikey 960:
> 
> Nov  5 12:02:54 hikey kernel: [   22.148194] Unbalanced enable for IRQ 44
> Nov  5 12:02:54 hikey kernel: [   22.152193] [ cut here 
> ]
> Nov  5 12:02:54 hikey kernel: [   22.156872] WARNING: CPU: 2 PID: 509 at 
> /home/inaddy/work/sources/linux/stable/stable-linux-4.14.y/kernel/irq/manage.c:525
>  __enable_irq+0x78/0x80
> Nov  5 12:02:54 hikey kernel: [   22.249606] CPU: 2 PID: 509 Comm: 
> kworker/2:2 Not tainted 4.14.79 #1
> Nov  5 12:02:54 hikey kernel: [   22.255975] Hardware name: HiKey Development 
> Board (DT)
> Nov  5 12:02:54 hikey kernel: [   22.261248] Workqueue: events_freezable 
> thermal_zone_device_check
> Nov  5 12:02:54 hikey kernel: [   22.267368] task: 8000616e0e00 
> task.stack: 0b5f
> Nov  5 12:02:54 hikey kernel: [   22.273312] PC is at __enable_irq+0x78/0x80
> Nov  5 12:02:54 hikey kernel: [   22.277516] LR is at __enable_irq+0x78/0x80
> Nov  5 12:02:54 hikey kernel: [   22.281718] pc : [] lr : 
> [] pstate: 01c5
> Nov  5 12:02:54 hikey kernel: [   22.289129] sp : 0b5f3c80
> Nov  5 12:02:54 hikey kernel: [   22.292457] x29: 0b5f3c80 x28: 
>  
> Nov  5 12:02:54 hikey kernel: [   22.297804] x27: 80005c139e38 x26: 
> 08a71870 
> Nov  5 12:02:54 hikey kernel: [   22.303148] x25:  x24: 
> 0002 
> Nov  5 12:02:54 hikey kernel: [   22.308492] x23: 0b5f3d9c x22: 
> 80005d565e88 
> Nov  5 12:02:54 hikey kernel: [   22.313836] x21: f980 x20: 
> 002c 
> Nov  5 12:02:54 hikey kernel: [   22.319181] x19: 800061726000 x18: 
> 0010 
> Nov  5 12:02:54 hikey kernel: [   22.324524] x17:  x16: 
>  
> Nov  5 12:02:54 hikey kernel: [   22.329868] x15:  x14: 
> 09269c08 
> Nov  5 12:02:54 hikey kernel: [   22.335213] x13: 8940678f x12: 
> 09406797 
> Nov  5 12:02:54 hikey kernel: [   22.340558] x11: 0929 x10: 
> 0b5f3980 
> Nov  5 12:02:54 hikey kernel: [   22.345902] x9 : ffd0 x8 : 
> 0862c298 
> Nov  5 12:02:54 hikey kernel: [   22.351246] x7 : 6c62616e65206465 x6 : 
> 01b2 
> Nov  5 12:02:54 hikey kernel: [   22.356589] x5 :  x4 : 
>  
> Nov  5 12:02:54 hikey kernel: [   22.361931] x3 :  x2 : 
> 800063e824c8 
> Nov  5 12:02:54 hikey kernel: [   22.367275] x1 : 80005af95000 x0 : 
> 001c 
> Nov  5 12:02:54 hikey kernel: [   22.372618] Call trace:
> Nov  5 12:02:54 hikey kernel: [   22.375088] Exception 
> stack(0x0b5f3b40 to 0x0b5f3c80)
> Nov  5 12:02:54 hikey kernel: [   22.381560] 3b40: 001c 
> 80005af95000 800063e824c8 
> Nov  5 12:02:54 hikey kernel: [   22.389417] 3b60:  
>  01b2 6c62616e65206465
> Nov  5 12:02:54 hikey kernel: [   22.397276] 3b80: 0862c298 
> ffd0 0b5f3980 0929
> Nov  5 12:02:54 hikey kernel: [   22.405136] 3ba0: 09406797 
> 8940678f 09269c08 
> Nov  5 12:02:54 hikey kernel: [   22.412994] 3bc0:  
>  0010 800061726000
> Nov  5 12:02:54 hikey kernel: [   22.420852] 3be0: 002c 
> f980 80005d565e88 0b5f3d9c
> Nov  5 12:02:54 hikey kernel: [   22.428710] 3c00: 0002 
>  08a71870 80005c139e38
> Nov  5 12:02:54 hikey kernel: [   22.436569] 3c20:  
> 0b5f3c80 0813e010 0b5f3c80
> Nov  5 12:02:54 hikey kernel: [   22.26] 3c40: 0813e010 
> 01c5  
> Nov  5 12:02:54 hikey kernel: [   22.452286] 3c60:  
> 800061800618 0b5f3c80 0813e010
> Nov  5 12:02:54 hikey kernel: [   22.460144] [] 
> __enable_irq+0x78/0x80
> Nov  5 12:02:54 hikey kernel: [   22.465394] [] 
> enable_irq+0x40/0x78
> Nov  5 12:02:54 hikey kernel: [   22.470493] [] 
> hisi_thermal_get_temp+0x1b0/0x1d8 [hisi_thermal]
> Nov  5 12:02:54 hikey kernel: [   22.478008] [] 
> of_thermal_get_temp+0x38/0x50
> Nov  5 12:02:54 hikey kernel: [   22.483869] [] 
> thermal_zone_get_temp+0x58/0x80
> Nov  5 12:02:54 hikey kernel: [   22.489903] [] 
> thermal_zone_device_update.part.4+0x2c/0x1a8
> Nov  5 12:02:54 hikey kernel: [   22.497066] [] 
> thermal_zone_device_check+0x40/0x50
> Nov  5 12:02:54 hikey kernel: [   22.503457] [] 
> process_one_work+0x19c/0x3d0
> Nov  5 12:02:54 hikey kernel: [   22.509236] [] 
> worker_thread+0x4c/0x428
> Nov  5 12:02:54 hikey kernel: [   22.514664] [] 
> kthread+0x134/0x138
> Nov  5 

Re: [patch set 4.19.6] BFS updates

2018-12-03 Thread Greg KH
On Mon, Dec 03, 2018 at 09:55:23AM +, Tigran Aivazian wrote:
> Re-sending the patches with the "Cc: sta...@vger.kernel.org" included
> in the sign-off area, as per Option 1 of the rules Greg referred me
> to. I hope that now I have done everything by the rules.

As you want to replace an existing patch in linux-next that is in
Andrew's trees, you need to cc: him :)

Also, you need to send each patch as an individual email, like
Documentation/SubmittingPatches says to do.

This shouldn't be any different from submitting any other patch.

thanks,

greg k-h


Re: [PATCH 4.19.6] BFS: static inode bitmap and extra sanity checking

2018-12-02 Thread Greg KH
On Sun, Dec 02, 2018 at 08:21:30PM +, Tigran Aivazian wrote:
> On Sun, 2 Dec 2018 at 20:13, Greg KH  wrote:
> > What is the git commit id of this patch in Linus's tree?
> 
> In linux-next the commit id is
> d2e6681167c634cfc3558991b59a6f614a31d226 , but it is not in Linus'
> tree (i.e. at github.com/torvalds/linux) yet. It went into Andrew
> Morton's "-mm" tree and then into "linux-next" tree.

Please take a look at:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to get a patch into the stable tree.  The patch needs to be in
Linus's tree first, linux-next does not count, sorry.

thanks,

greg k-h


Re: [PATCH 4.19.6] BFS: static inode bitmap and extra sanity checking

2018-12-02 Thread Greg KH
On Sun, Dec 02, 2018 at 06:57:10PM +, Tigran Aivazian wrote:
> Hello,
> 
> Please find a patch attached which contains the following changes:
> 
> 1. Simplifies inode bitmap allocation by making it static.
> 2. Supersedes the changes to BFS that went into 4.19.6 with stronger checking.
> 3. Other changes are trivial (like whitespace cleanup, warning messages etc).
> 
> Fully tested under 4.19.6 kernel.
> 
> Kind regards,
> Tigran

> From: Tigran Aivazian 
> Subject: [PATCH 4.19.6] BFS: static inode bitmap and extra sanity checking
> 
> Strengthen validation of BFS superblock against corruption.
> Make in-core inode bitmap static part of superblock info structure.
> Print a warning when mounting a BFS filesystem created with "-N 512"
> option as only 510 files can be created in the root directory.
> Make the kernel messages more uniform. Update the 'prefix' passed to
> bfs_dump_imap() to match the current naming of operations.
> White space and comments cleanup.
> 
> Signed-off-by: Tigran Aivazian 
> Cc: Tetsuo Handa 
> Cc: Andrew Morton 
> Cc: Matthew Wilcox 
> Cc: Linus Torvalds 
> Cc: Greg Kroah-Hartman 
> ---
> 
>  fs/bfs/bfs.h|   11 ++-
>  fs/bfs/dir.c|4 +-
>  fs/bfs/file.c   |2 -
>  fs/bfs/inode.c  |   65 
> ++--
>  include/uapi/linux/bfs_fs.h |2 -
>  5 files changed, 41 insertions(+), 43 deletions(-)

What is the git commit id of this patch in Linus's tree?

thanks,

greg k-h


Re: [PATCH AUTOSEL 4.14 25/35] iomap: sub-block dio needs to zeroout beyond EOF

2018-12-02 Thread Greg KH
On Sat, Dec 01, 2018 at 08:45:48AM +1100, Dave Chinner wrote:
> > > Right now the XFS developers don't have the time or resources
> > > available to validate stable backports are correct and regression
> > > fre because we are focussed on ensuring the upstream fixes we've
> > > already made (and are still writing) are solid and reliable.
> > 
> > Ok, that's fine, so users of XFS should wait until the 4.20 release
> > before relying on it?  :)
> 
> Ok, Greg, that's *out of line*.

Sorry, I did not mean it that way at all, I apologize.

I do appreciate all the work you do on your subsystem, I was not
criticizing that at all.  I was just trying to make a bad joke that it
felt like no xfs patches should ever be accepted into stable kernels
because more are always being fixed, so the treadmill wouldn't stop.

It's like asking a processor developer "what chip to buy" and they
always say "the next one is going to be great!" because that is what
they are working on at the moment, yet you need to buy something today
to get your work done.  That's all, no harm ment at all, sorry if it
came across the wrong way.

greg k-h


Re: XFS patches for stable

2018-12-02 Thread Greg KH
On Sun, Dec 02, 2018 at 08:10:16AM -0800, Christoph Hellwig wrote:
> As someone who has done xfs stable backports for a while I really don't
> think the autoselection is helpful at all.

autoselection for xfs patches has been turned off for a while, what
triggered this email thread was a core vfs patch that was backported
that was not obvious it was created by the xfs developers due to a
problem they had found.

> Someone who is vaguely familiar with the code needs to manually select
> the commits and QA them, which takes a fair amount of time, but just
> needs some manual help if it should work ok.
> 
> I think we are about ready to have a new xfs stable maintainer lined up
> if everything works well fortunately.

That would be wonderful news.

thanks,

greg k-h


Linux 4.19.6

2018-12-01 Thread Greg KH
I'm announcing the release of the 4.19.6 kernel.

All users of the 4.19 kernel series must upgrade.

The updated 4.19.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.19.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/admin-guide/security-bugs.rst |   48 +-
 Documentation/devicetree/bindings/net/can/holt_hi311x.txt   |2 
 MAINTAINERS |1 
 Makefile|2 
 arch/powerpc/include/asm/io.h   |   20 
 arch/powerpc/kvm/trace.h|8 
 arch/powerpc/kvm/trace_booke.h  |9 
 arch/powerpc/kvm/trace_hv.h |9 
 arch/powerpc/kvm/trace_pr.h |9 
 arch/powerpc/mm/numa.c  |2 
 arch/riscv/Makefile |4 
 arch/riscv/kernel/module.c  |   12 
 arch/x86/events/intel/uncore_snb.c  |  115 +
 block/bio.c |1 
 block/bounce.c  |1 
 crypto/simd.c   |5 
 drivers/acpi/acpica/dsopcode.c  |4 
 drivers/block/floppy.c  |3 
 drivers/cpufreq/imx6q-cpufreq.c |7 
 drivers/firmware/efi/arm-init.c |4 
 drivers/firmware/efi/arm-runtime.c  |2 
 drivers/firmware/efi/libstub/Makefile   |3 
 drivers/firmware/efi/memmap.c   |3 
 drivers/gpio/gpiolib.c  |5 
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c  |7 
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c   |1 
 drivers/gpu/drm/amd/amdgpu/vega10_ih.c  |2 
 drivers/gpu/drm/ast/ast_drv.c   |   21 
 drivers/gpu/drm/ast/ast_mode.c  |3 
 drivers/gpu/drm/drm_fb_helper.c |3 
 drivers/gpu/drm/i915/intel_pm.c |   41 +
 drivers/gpu/drm/vc4/vc4_kms.c   |6 
 drivers/hid/hid-steam.c |  154 ---
 drivers/infiniband/hw/hfi1/user_sdma.c  |   87 +--
 drivers/infiniband/hw/hfi1/user_sdma.h  |3 
 drivers/input/mouse/synaptics.c |4 
 drivers/media/i2c/ov5640.c  |  263 +++-
 drivers/mmc/host/sdhci-pci-core.c   |   86 +++
 drivers/net/can/dev.c   |   48 +-
 drivers/net/can/flexcan.c   |  108 ++--
 drivers/net/can/rx-offload.c|   51 ++
 drivers/net/can/spi/hi311x.c|2 
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c |3 
 drivers/net/wireless/intel/iwlwifi/fw/acpi.h|4 
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c |   38 +
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c   |   12 
 drivers/net/wireless/intel/iwlwifi/mvm/nvm.c|5 
 drivers/opp/ti-opp-supply.c |5 
 drivers/pinctrl/meson/pinctrl-meson-gxbb.c  |2 
 drivers/pinctrl/meson/pinctrl-meson-gxl.c   |2 
 drivers/pinctrl/meson/pinctrl-meson.c   |2 
 drivers/pinctrl/meson/pinctrl-meson8.c  |2 
 drivers/pinctrl/meson/pinctrl-meson8b.c |2 
 drivers/rtc/rtc-cmos.c  |   16 
 drivers/rtc/rtc-pcf2127.c   |3 
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c  |2 
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c  |2 
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c  |2 
 drivers/scsi/lpfc/lpfc_debugfs.c|2 
 drivers/tty/n_tty.c |   20 
 drivers/tty/tty_buffer.c|6 
 drivers/usb/core/hub.c  |4 
 drivers/usb/dwc3/core.c |1 
 drivers/usb/dwc3/dwc3-pci.c |4 
 drivers/usb/dwc3/gadget.c   |8 
 drivers/usb/host/xhci-histb.c

Re: Linux 4.14.85

2018-12-01 Thread Greg KH
diff --git a/Documentation/devicetree/bindings/net/can/holt_hi311x.txt 
b/Documentation/devicetree/bindings/net/can/holt_hi311x.txt
index 23aa94eab207..4e0ec14f7abf 100644
--- a/Documentation/devicetree/bindings/net/can/holt_hi311x.txt
+++ b/Documentation/devicetree/bindings/net/can/holt_hi311x.txt
@@ -18,7 +18,7 @@ Example:
reg = <1>;
clocks = <>;
interrupt-parent = <>;
-   interrupts = <13 IRQ_TYPE_EDGE_RISING>;
+   interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
vdd-supply = <>;
xceiver-supply = <>;
};
diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
index 35e17f748ca7..af5859b2d0f9 100644
--- a/Documentation/sysctl/fs.txt
+++ b/Documentation/sysctl/fs.txt
@@ -34,7 +34,9 @@ Currently, these files are in /proc/sys/fs:
 - overflowgid
 - pipe-user-pages-hard
 - pipe-user-pages-soft
+- protected_fifos
 - protected_hardlinks
+- protected_regular
 - protected_symlinks
 - suid_dumpable
 - super-max
@@ -182,6 +184,24 @@ applied.
 
 ==
 
+protected_fifos:
+
+The intent of this protection is to avoid unintentional writes to
+an attacker-controlled FIFO, where a program expected to create a regular
+file.
+
+When set to "0", writing to FIFOs is unrestricted.
+
+When set to "1" don't allow O_CREAT open on FIFOs that we don't own
+in world writable sticky directories, unless they are owned by the
+owner of the directory.
+
+When set to "2" it also applies to group writable sticky directories.
+
+This protection is based on the restrictions in Openwall.
+
+==
+
 protected_hardlinks:
 
 A long-standing class of security issues is the hardlink-based
@@ -202,6 +222,22 @@ This protection is based on the restrictions in Openwall 
and grsecurity.
 
 ==
 
+protected_regular:
+
+This protection is similar to protected_fifos, but it
+avoids writes to an attacker-controlled regular file, where a program
+expected to create one.
+
+When set to "0", writing to regular files is unrestricted.
+
+When set to "1" don't allow O_CREAT open on regular files that we
+don't own in world writable sticky directories, unless they are
+owned by the owner of the directory.
+
+When set to "2" it also applies to group writable sticky directories.
+
+==
+
 protected_symlinks:
 
 A long-standing class of security issues is the symlink-based
diff --git a/MAINTAINERS b/MAINTAINERS
index 546beb6b0176..6cb70b853323 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12662,6 +12662,7 @@ F:  arch/alpha/kernel/srm_env.c
 
 STABLE BRANCH
 M: Greg Kroah-Hartman 
+M: Sasha Levin 
 L: sta...@vger.kernel.org
 S: Supported
 F: Documentation/process/stable-kernel-rules.rst
diff --git a/Makefile b/Makefile
index 874d72a3e6a7..58a248264090 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 VERSION = 4
 PATCHLEVEL = 14
-SUBLEVEL = 84
+SUBLEVEL = 85
 EXTRAVERSION =
 NAME = Petit Gorille
 
@@ -480,13 +480,15 @@ endif
 ifeq ($(cc-name),clang)
 ifneq ($(CROSS_COMPILE),)
 CLANG_TARGET   := --target=$(notdir $(CROSS_COMPILE:%-=%))
-GCC_TOOLCHAIN  := $(realpath $(dir $(shell which $(LD)))/..)
+GCC_TOOLCHAIN_DIR := $(dir $(shell which $(LD)))
+CLANG_PREFIX   := --prefix=$(GCC_TOOLCHAIN_DIR)
+GCC_TOOLCHAIN  := $(realpath $(GCC_TOOLCHAIN_DIR)/..)
 endif
 ifneq ($(GCC_TOOLCHAIN),)
 CLANG_GCC_TC   := --gcc-toolchain=$(GCC_TOOLCHAIN)
 endif
-KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
-KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
+KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
+KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
 KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
 KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
 endif
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 36ae4454554c..17e80f483281 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -106,7 +106,7 @@ tune-$(CONFIG_CPU_V6K)  =$(call 
cc-option,-mtune=arm1136j-s,-mtune=strongarm)
 tune-y := $(tune-y)
 
 ifeq ($(CONFIG_AEABI),y)
-CFLAGS_ABI :=-mabi=aapcs-linux -mno-thumb-interwork -mfpu=vfp
+CFLAGS_ABI :=-mabi=aapcs-linux -mfpu=vfp
 else
 CFLAGS_ABI :=$(call cc-option,-mapcs-32,-mabi=apcs-gnu) $(call 
cc-option,-mno-thumb-interwork,)
 endif
diff --git a/arch/arm/boot/compressed/Makefile 
b/arch/arm/boot/compressed/Makefile
index a5889238fc9f..746c8c575f98 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -113,7 +113,7 @@ CFLAGS_fdt_ro.o := $(nossp_flags)
 CFLAGS_fdt_rw.o := $(nossp_flags)
 CFLAGS_fdt_wip.o := $(nossp_flags)
 
-ccflags-y := -fpic -mno-single-pic-base -fno-builtin -I$(obj)
+ccflags-y := -fpic $(call cc-option,-mno-single-pic-base,) -fno-builtin 

Re: Linux 4.9.142

2018-12-01 Thread Greg KH
diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
index 35e17f748ca7..af5859b2d0f9 100644
--- a/Documentation/sysctl/fs.txt
+++ b/Documentation/sysctl/fs.txt
@@ -34,7 +34,9 @@ Currently, these files are in /proc/sys/fs:
 - overflowgid
 - pipe-user-pages-hard
 - pipe-user-pages-soft
+- protected_fifos
 - protected_hardlinks
+- protected_regular
 - protected_symlinks
 - suid_dumpable
 - super-max
@@ -182,6 +184,24 @@ applied.
 
 ==
 
+protected_fifos:
+
+The intent of this protection is to avoid unintentional writes to
+an attacker-controlled FIFO, where a program expected to create a regular
+file.
+
+When set to "0", writing to FIFOs is unrestricted.
+
+When set to "1" don't allow O_CREAT open on FIFOs that we don't own
+in world writable sticky directories, unless they are owned by the
+owner of the directory.
+
+When set to "2" it also applies to group writable sticky directories.
+
+This protection is based on the restrictions in Openwall.
+
+==
+
 protected_hardlinks:
 
 A long-standing class of security issues is the hardlink-based
@@ -202,6 +222,22 @@ This protection is based on the restrictions in Openwall 
and grsecurity.
 
 ==
 
+protected_regular:
+
+This protection is similar to protected_fifos, but it
+avoids writes to an attacker-controlled regular file, where a program
+expected to create one.
+
+When set to "0", writing to regular files is unrestricted.
+
+When set to "1" don't allow O_CREAT open on regular files that we
+don't own in world writable sticky directories, unless they are
+owned by the owner of the directory.
+
+When set to "2" it also applies to group writable sticky directories.
+
+==
+
 protected_symlinks:
 
 A long-standing class of security issues is the symlink-based
diff --git a/MAINTAINERS b/MAINTAINERS
index 63cefa62324c..4f559f5b3a89 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11469,6 +11469,7 @@ F:  arch/alpha/kernel/srm_env.c
 
 STABLE BRANCH
 M: Greg Kroah-Hartman 
+M: Sasha Levin 
 L: sta...@vger.kernel.org
 S: Supported
 F: Documentation/stable_kernel_rules.txt
diff --git a/Makefile b/Makefile
index 8eba73521a7f..72ed8ff90329 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 VERSION = 4
 PATCHLEVEL = 9
-SUBLEVEL = 141
+SUBLEVEL = 142
 EXTRAVERSION =
 NAME = Roaring Lionus
 
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 92110c2c6c59..ee94597773fa 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -10,7 +10,7 @@
 #
 # Copyright (C) 1995-2001 by Russell King
 
-LDFLAGS_vmlinux:=-p --no-undefined -X
+LDFLAGS_vmlinux:=--no-undefined -X
 CPPFLAGS_vmlinux.lds = -DTEXT_OFFSET=$(TEXT_OFFSET)
 GZFLAGS:=-9
 
diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
index f6fda8482f60..3b10f532c28e 100644
--- a/arch/powerpc/include/asm/io.h
+++ b/arch/powerpc/include/asm/io.h
@@ -333,19 +333,13 @@ extern void _memcpy_toio(volatile void __iomem *dest, 
const void *src,
  * their hooks, a bitfield is reserved for use by the platform near the
  * top of MMIO addresses (not PIO, those have to cope the hard way).
  *
- * This bit field is 12 bits and is at the top of the IO virtual
- * addresses PCI_IO_INDIRECT_TOKEN_MASK.
+ * The highest address in the kernel virtual space are:
  *
- * The kernel virtual space is thus:
+ *  d0003fff   # with Hash MMU
+ *  c00f   # with Radix MMU
  *
- *  0xD000 : vmalloc
- *  0xD800 : PCI PHB IO space
- *  0xD8008000 : ioremap
- *  0xDfff : end of ioremap region
- *
- * Since the top 4 bits are reserved as the region ID, we use thus
- * the next 12 bits and keep 4 bits available for the future if the
- * virtual address space is ever to be extended.
+ * The top 4 bits are reserved as the region ID on hash, leaving us 8 bits
+ * that can be used for the field.
  *
  * The direct IO mapping operations will then mask off those bits
  * before doing the actual access, though that only happen when
@@ -357,8 +351,8 @@ extern void _memcpy_toio(volatile void __iomem *dest, const 
void *src,
  */
 
 #ifdef CONFIG_PPC_INDIRECT_MMIO
-#define PCI_IO_IND_TOKEN_MASK  0x0ffful
-#define PCI_IO_IND_TOKEN_SHIFT 48
+#define PCI_IO_IND_TOKEN_SHIFT 52
+#define PCI_IO_IND_TOKEN_MASK  (0xfful << PCI_IO_IND_TOKEN_SHIFT)
 #define PCI_FIX_ADDR(addr) \
((PCI_IO_ADDR)(((unsigned long)(addr)) & ~PCI_IO_IND_TOKEN_MASK))
 #define PCI_GET_ADDR_TOKEN(addr)   \
diff --git a/arch/powerpc/kvm/trace.h b/arch/powerpc/kvm/trace.h
index 2e0e67ef3544..e8cedf32345a 100644
--- a/arch/powerpc/kvm/trace.h
+++ b/arch/powerpc/kvm/trace.h

Linux 4.14.85

2018-12-01 Thread Greg KH
I'm announcing the release of the 4.14.85 kernel.

All users of the 4.14 kernel series must upgrade.

The updated 4.14.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.14.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/devicetree/bindings/net/can/holt_hi311x.txt   |2 
 Documentation/sysctl/fs.txt |   36 +++
 MAINTAINERS |1 
 Makefile|   10 -
 arch/arm/Makefile   |2 
 arch/arm/boot/compressed/Makefile   |2 
 arch/arm/boot/dts/exynos5420-peach-pit.dts  |4 
 arch/arm/boot/dts/exynos5800-peach-pi.dts   |4 
 arch/arm/firmware/trusted_foundations.c |   14 -
 arch/arm64/Makefile |2 
 arch/powerpc/include/asm/io.h   |   20 --
 arch/powerpc/kvm/trace.h|8 
 arch/powerpc/kvm/trace_booke.h  |9 
 arch/powerpc/kvm/trace_hv.h |9 
 arch/powerpc/kvm/trace_pr.h |9 
 arch/powerpc/mm/numa.c  |2 
 arch/s390/mm/gmap.c |2 
 arch/x86/events/intel/uncore_snb.c  |  115 +++-
 crypto/simd.c   |5 
 drivers/base/core.c |2 
 drivers/block/floppy.c  |3 
 drivers/bus/arm-cci.c   |2 
 drivers/clk/samsung/clk-exynos5250.c|6 
 drivers/cpufreq/imx6q-cpufreq.c |7 
 drivers/firmware/efi/arm-init.c |4 
 drivers/firmware/efi/arm-runtime.c  |2 
 drivers/firmware/efi/libstub/Makefile   |3 
 drivers/firmware/efi/memmap.c   |3 
 drivers/gpio/gpiolib.c  |5 
 drivers/gpu/drm/ast/ast_drv.c   |   21 ++
 drivers/gpu/drm/ast/ast_mode.c  |3 
 drivers/gpu/drm/mediatek/mtk_hdmi.c |5 
 drivers/infiniband/core/verbs.c |5 
 drivers/infiniband/hw/hfi1/user_sdma.c  |   87 -
 drivers/infiniband/hw/hfi1/user_sdma.h  |3 
 drivers/infiniband/hw/i40iw/i40iw_verbs.c   |2 
 drivers/input/joystick/xpad.c   |   45 ++--
 drivers/input/mouse/synaptics.c |4 
 drivers/mmc/host/sdhci-pci-core.c   |7 
 drivers/mtd/nand/atmel/nand-controller.c|   11 -
 drivers/mtd/ubi/build.c |1 
 drivers/mtd/ubi/eba.c   |4 
 drivers/mtd/ubi/fastmap.c   |   20 ++
 drivers/mtd/ubi/ubi.h   |   11 +
 drivers/mtd/ubi/vmt.c   |1 
 drivers/mtd/ubi/vtbl.c  |   16 +
 drivers/net/can/dev.c   |   48 +++--
 drivers/net/can/flexcan.c   |4 
 drivers/net/can/rx-offload.c|   51 +
 drivers/net/can/spi/hi311x.c|2 
 drivers/net/ethernet/broadcom/genet/bcmmii.c|2 
 drivers/net/ethernet/mellanox/mlx4/resource_tracker.c   |1 
 drivers/net/usb/lan78xx.c   |   42 ++--
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c |3 
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c |   40 +++-
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c   |   12 -
 drivers/net/wireless/intel/iwlwifi/mvm/nvm.c|5 
 drivers/nfc/nfcmrvl/uart.c  |5 
 drivers/of/base.c   |   25 ++
 drivers/pci/endpoint/pci-ep-cfs.c   |   14 -
 drivers/pinctrl/meson/pinctrl-meson.c   |2 
 drivers/power/supply/twl4030_charger.c  |5 
 drivers/rtc/rtc-omap.c  |3 
 drivers/rtc/rtc-pcf2127.c   |3 
 drivers/tty/n_tty.c |   20 +-
 drivers/tty/tty_buffer.c   

Re: Linux 4.4.166

2018-12-01 Thread Greg KH
diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt
index 35e17f748ca7..af5859b2d0f9 100644
--- a/Documentation/sysctl/fs.txt
+++ b/Documentation/sysctl/fs.txt
@@ -34,7 +34,9 @@ Currently, these files are in /proc/sys/fs:
 - overflowgid
 - pipe-user-pages-hard
 - pipe-user-pages-soft
+- protected_fifos
 - protected_hardlinks
+- protected_regular
 - protected_symlinks
 - suid_dumpable
 - super-max
@@ -182,6 +184,24 @@ applied.
 
 ==
 
+protected_fifos:
+
+The intent of this protection is to avoid unintentional writes to
+an attacker-controlled FIFO, where a program expected to create a regular
+file.
+
+When set to "0", writing to FIFOs is unrestricted.
+
+When set to "1" don't allow O_CREAT open on FIFOs that we don't own
+in world writable sticky directories, unless they are owned by the
+owner of the directory.
+
+When set to "2" it also applies to group writable sticky directories.
+
+This protection is based on the restrictions in Openwall.
+
+==
+
 protected_hardlinks:
 
 A long-standing class of security issues is the hardlink-based
@@ -202,6 +222,22 @@ This protection is based on the restrictions in Openwall 
and grsecurity.
 
 ==
 
+protected_regular:
+
+This protection is similar to protected_fifos, but it
+avoids writes to an attacker-controlled regular file, where a program
+expected to create one.
+
+When set to "0", writing to regular files is unrestricted.
+
+When set to "1" don't allow O_CREAT open on regular files that we
+don't own in world writable sticky directories, unless they are
+owned by the owner of the directory.
+
+When set to "2" it also applies to group writable sticky directories.
+
+==
+
 protected_symlinks:
 
 A long-standing class of security issues is the symlink-based
diff --git a/MAINTAINERS b/MAINTAINERS
index ab65bbecb159..f4d4a5544dc1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10135,6 +10135,7 @@ F:  arch/alpha/kernel/srm_env.c
 
 STABLE BRANCH
 M: Greg Kroah-Hartman 
+M: Sasha Levin 
 L: sta...@vger.kernel.org
 S: Supported
 F: Documentation/stable_kernel_rules.txt
diff --git a/Makefile b/Makefile
index 441a760dc5a4..64521458d35e 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 VERSION = 4
 PATCHLEVEL = 4
-SUBLEVEL = 165
+SUBLEVEL = 166
 EXTRAVERSION =
 NAME = Blurry Fish Butt
 
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index c10bb98144b0..fb4ac87fc398 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -10,7 +10,7 @@
 #
 # Copyright (C) 1995-2001 by Russell King
 
-LDFLAGS_vmlinux:=-p --no-undefined -X
+LDFLAGS_vmlinux:=--no-undefined -X
 CPPFLAGS_vmlinux.lds = -DTEXT_OFFSET=$(TEXT_OFFSET)
 OBJCOPYFLAGS   :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
 GZFLAGS:=-9
diff --git a/arch/powerpc/kvm/trace.h b/arch/powerpc/kvm/trace.h
index 2e0e67ef3544..e8cedf32345a 100644
--- a/arch/powerpc/kvm/trace.h
+++ b/arch/powerpc/kvm/trace.h
@@ -5,8 +5,6 @@
 
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM kvm
-#define TRACE_INCLUDE_PATH .
-#define TRACE_INCLUDE_FILE trace
 
 /*
  * Tracepoint for guest mode entry.
@@ -119,4 +117,10 @@ TRACE_EVENT(kvm_check_requests,
 #endif /* _TRACE_KVM_H */
 
 /* This part must be outside protection */
+#undef TRACE_INCLUDE_PATH
+#undef TRACE_INCLUDE_FILE
+
+#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_FILE trace
+
 #include 
diff --git a/arch/powerpc/kvm/trace_booke.h b/arch/powerpc/kvm/trace_booke.h
index 7ec534d1db9f..7eadbf449a1f 100644
--- a/arch/powerpc/kvm/trace_booke.h
+++ b/arch/powerpc/kvm/trace_booke.h
@@ -5,8 +5,6 @@
 
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM kvm_booke
-#define TRACE_INCLUDE_PATH .
-#define TRACE_INCLUDE_FILE trace_booke
 
 #define kvm_trace_symbol_exit \
{0, "CRITICAL"}, \
@@ -217,4 +215,11 @@ TRACE_EVENT(kvm_booke_queue_irqprio,
 #endif
 
 /* This part must be outside protection */
+
+#undef TRACE_INCLUDE_PATH
+#undef TRACE_INCLUDE_FILE
+
+#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_FILE trace_booke
+
 #include 
diff --git a/arch/powerpc/kvm/trace_hv.h b/arch/powerpc/kvm/trace_hv.h
index 33d9daff5783..d1bfe017d751 100644
--- a/arch/powerpc/kvm/trace_hv.h
+++ b/arch/powerpc/kvm/trace_hv.h
@@ -8,8 +8,6 @@
 
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM kvm_hv
-#define TRACE_INCLUDE_PATH .
-#define TRACE_INCLUDE_FILE trace_hv
 
 #define kvm_trace_symbol_hcall \
{H_REMOVE,  "H_REMOVE"}, \
@@ -474,4 +472,11 @@ TRACE_EVENT(kvmppc_run_vcpu_exit,
 #endif /* _TRACE_KVM_HV_H */
 
 /* This part must be outside protection */
+
+#undef TRACE_INCLUDE_PATH
+#undef TRACE_INCLUDE_FILE
+
+#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_FILE trace_hv
+
 #include 
diff --git a/arch/powerpc/kvm/trace_pr.h 

Linux 4.9.142

2018-12-01 Thread Greg KH
I'm announcing the release of the 4.9.142 kernel.

All users of the 4.9 kernel series must upgrade.

The updated 4.9.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.9.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/sysctl/fs.txt |   36 
 MAINTAINERS |1 
 Makefile|2 
 arch/arm64/Makefile |2 
 arch/powerpc/include/asm/io.h   |   20 
 arch/powerpc/kvm/trace.h|8 
 arch/powerpc/kvm/trace_booke.h  |9 
 arch/powerpc/kvm/trace_hv.h |9 
 arch/powerpc/kvm/trace_pr.h |9 
 arch/powerpc/mm/numa.c  |2 
 arch/s390/mm/gmap.c |2 
 arch/x86/events/intel/uncore_snb.c  |  115 ++
 drivers/block/floppy.c  |3 
 drivers/cpufreq/imx6q-cpufreq.c |7 
 drivers/firmware/efi/arm-init.c |4 
 drivers/firmware/efi/arm-runtime.c  |2 
 drivers/firmware/efi/memmap.c   |3 
 drivers/gpio/gpiolib.c  |5 
 drivers/gpu/drm/ast/ast_drv.c   |   21 
 drivers/gpu/drm/ast/ast_mode.c  |3 
 drivers/infiniband/core/verbs.c |4 
 drivers/infiniband/hw/hfi1/user_sdma.c  |  106 +-
 drivers/input/joystick/xpad.c   |  471 +---
 drivers/net/can/dev.c   |   48 -
 drivers/net/ethernet/broadcom/genet/bcmmii.c|2 
 drivers/net/usb/lan78xx.c   |   42 -
 drivers/net/wireless/ath/ath10k/mac.c   |6 
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c |3 
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c   |   12 
 drivers/net/wireless/intel/iwlwifi/mvm/nvm.c|5 
 drivers/net/wireless/marvell/mwifiex/cfg80211.c |   10 
 drivers/net/wireless/marvell/mwifiex/pcie.c |   19 
 drivers/net/wireless/marvell/mwifiex/wmm.c  |   12 
 drivers/net/wireless/st/cw1200/wsm.c|   16 
 drivers/nfc/nfcmrvl/uart.c  |5 
 drivers/of/base.c   |   25 
 drivers/pinctrl/meson/pinctrl-meson.c   |2 
 drivers/rtc/rtc-pcf2127.c   |3 
 drivers/scsi/ufs/ufs.h  |3 
 drivers/scsi/ufs/ufshcd-pci.c   |2 
 drivers/scsi/ufs/ufshcd-pltfrm.c|5 
 drivers/scsi/ufs/ufshcd.c   |   75 +
 drivers/tty/n_tty.c |   20 
 drivers/tty/tty_buffer.c|2 
 drivers/usb/core/hub.c  |4 
 drivers/usb/dwc3/core.c |1 
 drivers/usb/host/xhci-hub.c |   66 +
 drivers/usb/host/xhci-ring.c|2 
 drivers/usb/host/xhci.h |2 
 fs/9p/vfs_dir.c |   11 
 fs/bfs/inode.c  |9 
 fs/gfs2/ops_fstype.c|2 
 fs/namei.c  |   53 +
 include/linux/can/dev.h |1 
 include/linux/fs.h  |2 
 include/linux/integrity.h   |1 
 include/linux/of.h  |8 
 include/linux/pfn_t.h   |2 
 kernel/debug/kdb/kdb_io.c   |   15 
 kernel/debug/kdb/kdb_private.h  |2 
 kernel/debug/kdb/kdb_support.c  |   10 
 kernel/sched/core.c |4 
 kernel/sysctl.c |   18 
 mm/shmem.c  |4 
 mm/slab.c   |4 
 mm/slab_common.c|   12 
 

Linux 4.4.166

2018-12-01 Thread Greg KH
I'm announcing the release of the 4.4.166 kernel.

All users of the 4.4 kernel series must upgrade.

The updated 4.4.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.4.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/sysctl/fs.txt  |   36 +
 MAINTAINERS  |1 
 Makefile |2 
 arch/arm64/Makefile  |2 
 arch/powerpc/kvm/trace.h |8 
 arch/powerpc/kvm/trace_booke.h   |9 
 arch/powerpc/kvm/trace_hv.h  |9 
 arch/powerpc/kvm/trace_pr.h  |9 
 arch/powerpc/mm/numa.c   |2 
 arch/s390/mm/pgtable.c   |2 
 arch/x86/entry/entry_64.S|   20 
 drivers/cpufreq/imx6q-cpufreq.c  |7 
 drivers/gpu/drm/ast/ast_drv.c|   21 
 drivers/gpu/drm/ast/ast_mode.c   |3 
 drivers/input/joystick/xpad.c|  810 +--
 drivers/net/can/dev.c|   48 +
 drivers/net/ethernet/broadcom/genet/bcmmii.c |2 
 drivers/net/wireless/ath/ath10k/mac.c|6 
 drivers/net/wireless/cw1200/wsm.c|   16 
 drivers/net/wireless/iwlwifi/mvm/mac80211.c  |   12 
 drivers/net/wireless/iwlwifi/mvm/nvm.c   |5 
 drivers/net/wireless/mwifiex/cfg80211.c  |   10 
 drivers/net/wireless/mwifiex/wmm.c   |   12 
 drivers/nfc/nfcmrvl/uart.c   |5 
 drivers/of/base.c|   25 
 drivers/scsi/qla2xxx/qla_os.c|5 
 drivers/scsi/ufs/ufs.h   |3 
 drivers/scsi/ufs/ufshcd-pci.c|2 
 drivers/scsi/ufs/ufshcd-pltfrm.c |5 
 drivers/scsi/ufs/ufshcd.c|   75 ++
 drivers/tty/n_tty.c  |   19 
 drivers/tty/tty_buffer.c |2 
 drivers/usb/core/hub.c   |4 
 drivers/usb/host/xhci-hub.c  |   66 +-
 drivers/usb/host/xhci-ring.c |2 
 drivers/usb/host/xhci.h  |2 
 fs/9p/vfs_dir.c  |   11 
 fs/bfs/inode.c   |9 
 fs/btrfs/extent-tree.c   |   10 
 fs/btrfs/ioctl.c |   11 
 fs/gfs2/ops_fstype.c |2 
 fs/namei.c   |   53 +
 include/linux/can/dev.h  |1 
 include/linux/fs.h   |2 
 include/linux/of.h   |8 
 kernel/debug/kdb/kdb_io.c|   15 
 kernel/debug/kdb/kdb_private.h   |2 
 kernel/debug/kdb/kdb_support.c   |   10 
 kernel/sched/core.c  |4 
 kernel/sysctl.c  |   18 
 mm/shmem.c   |4 
 net/llc/af_llc.c |   11 
 net/netfilter/nf_tables_api.c|1 
 net/sctp/associola.c |   10 
 net/sunrpc/auth_generic.c|8 
 55 files changed, 1118 insertions(+), 339 deletions(-)

Aaron Ma (2):
  usb: xhci: fix timeout for transition from RExit to U0
  usb: xhci: fix uninitialized completion when USB3 port got wrong status

Amitkumar Karwar (1):
  mwifiex: Fix NULL pointer dereference in skb_dequeue()

Andrew Price (1):
  gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd

Andy Lutomirski (1):
  x86/entry/64: Remove %ebx handling from error_entry/exit

Anson Huang (1):
  cpufreq: imx6q: add return value check for voltage scale

Arnd Bergmann (1):
  Input: xpad - remove unused function

Arvind Yadav (1):
  Input: xpad - constify usb_device_id

Benjamin Valentin (5):
  Input: xpad - sort supported devices by USB ID
  Input: xpad - sync supported devices with xboxdrv
  Input: xpad - add USB IDs for Mad Catz Brawlstick and Razer Sabertooth
  Input: xpad - sync supported devices with 360Controller
  Input: xpad - sync supported devices with XBCD

Cameron Gutman (11):
  Input: xpad - prevent spurious input from wired Xbox 360 controllers
  Input: xpad - fix rumble on Xbox One controllers with 2015 firmware
  Input: xpad - power off wireless 360 controllers on suspend
  Input: xpad - add product ID for Xbox One S pad
  Input: xpad - fix Xbox One rumble stopping after 2.5 secs
  Input: xpad - don't depend on endpoint order
  Input: xpad - fix stuck mode button on Xbox One S pad
  Input: xpad - restore LED state after device resume
  Input: xpad - support some quirky Xbox One pads
 

Re: Linux 3.18.128

2018-12-01 Thread Greg KH
diff --git a/Makefile b/Makefile
index 7c78eb797de8..9060189af162 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 VERSION = 3
 PATCHLEVEL = 18
-SUBLEVEL = 127
+SUBLEVEL = 128
 EXTRAVERSION =
 NAME = Diseased Newt
 
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 37c4fd6aeb7a..42065599d014 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -10,7 +10,7 @@
 #
 # Copyright (C) 1995-2001 by Russell King
 
-LDFLAGS_vmlinux:=-p --no-undefined -X
+LDFLAGS_vmlinux:=--no-undefined -X
 CPPFLAGS_vmlinux.lds = -DTEXT_OFFSET=$(TEXT_OFFSET)
 OBJCOPYFLAGS   :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
 GZFLAGS:=-9
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index b9d1dfdbe5bb..ae9d3bf79612 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -1479,7 +1479,7 @@ static long vphn_get_associativity(unsigned long cpu,
 
switch (rc) {
case H_FUNCTION:
-   printk(KERN_INFO
+   printk_once(KERN_INFO
"VPHN is not supported. Disabling polling...\n");
stop_topology_update();
break;
diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
index c2d30765bf3d..a4ede00483d1 100644
--- a/drivers/cpufreq/imx6q-cpufreq.c
+++ b/drivers/cpufreq/imx6q-cpufreq.c
@@ -105,8 +105,13 @@ static int imx6q_set_target(struct cpufreq_policy *policy, 
unsigned int index)
/* Ensure the arm clock divider is what we expect */
ret = clk_set_rate(arm_clk, new_freq * 1000);
if (ret) {
+   int ret1;
+
dev_err(cpu_dev, "failed to set clock rate: %d\n", ret);
-   regulator_set_voltage_tol(arm_reg, volt_old, 0);
+   ret1 = regulator_set_voltage_tol(arm_reg, volt_old, 0);
+   if (ret1)
+   dev_warn(cpu_dev,
+"failed to restore vddarm voltage: %d\n", 
ret1);
return ret;
}
 
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index 9a32d9dfdd26..011700262824 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -60,8 +60,29 @@ static const struct pci_device_id pciidlist[] = {
 
 MODULE_DEVICE_TABLE(pci, pciidlist);
 
+static void ast_kick_out_firmware_fb(struct pci_dev *pdev)
+{
+   struct apertures_struct *ap;
+   bool primary = false;
+
+   ap = alloc_apertures(1);
+   if (!ap)
+   return;
+
+   ap->ranges[0].base = pci_resource_start(pdev, 0);
+   ap->ranges[0].size = pci_resource_len(pdev, 0);
+
+#ifdef CONFIG_X86
+   primary = pdev->resource[PCI_ROM_RESOURCE].flags & 
IORESOURCE_ROM_SHADOW;
+#endif
+   remove_conflicting_framebuffers(ap, "astdrmfb", primary);
+   kfree(ap);
+}
+
 static int ast_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 {
+   ast_kick_out_firmware_fb(pdev);
+
return drm_get_pci_dev(pdev, ent, );
 }
 
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 9dc0fd5c1ea4..a43d81b6d5d1 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -549,6 +549,7 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc,
}
ast_bo_unreserve(bo);
 
+   ast_set_offset_reg(crtc);
ast_set_start_address_crt1(crtc, (u32)gpu_addr);
 
return 0;
@@ -1246,7 +1247,7 @@ static int ast_cursor_move(struct drm_crtc *crtc,
ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xc7, ((y >> 8) & 0x07));
 
/* dummy write to fire HWC */
-   ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xCB, 0xFF, 0x00);
+   ast_show_cursor(crtc);
 
return 0;
 }
diff --git a/drivers/input/gameport/gameport.c 
b/drivers/input/gameport/gameport.c
index e29c04e2aff4..e853a2134680 100644
--- a/drivers/input/gameport/gameport.c
+++ b/drivers/input/gameport/gameport.c
@@ -527,14 +527,14 @@ EXPORT_SYMBOL(gameport_set_phys);
  */
 static void gameport_init_port(struct gameport *gameport)
 {
-   static atomic_t gameport_no = ATOMIC_INIT(0);
+   static atomic_t gameport_no = ATOMIC_INIT(-1);
 
__module_get(THIS_MODULE);
 
mutex_init(>drv_mutex);
device_initialize(>dev);
dev_set_name(>dev, "gameport%lu",
-   (unsigned long)atomic_inc_return(_no) - 1);
+   (unsigned long)atomic_inc_return(_no));
gameport->dev.bus = _bus;
gameport->dev.release = gameport_release_port;
if (gameport->parent)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 1a728f310b27..2e52015634f9 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -31,12 +31,14 @@
  *  - the iForce driverdrivers/char/joystick/iforce.c
  *  - the skeleton-driver  drivers/usb/usb-skeleton.c
  *  - Xbox 360 information http://www.free60.org/wiki/Gamepad
+ *  - Xbox One 

Linux 3.18.128

2018-12-01 Thread Greg KH
I'm announcing the release of the 3.18.128 kernel.

All users of the 3.18 kernel series must upgrade.

The updated 3.18.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-3.18.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile  |2 
 arch/arm64/Makefile   |2 
 arch/powerpc/mm/numa.c|2 
 drivers/cpufreq/imx6q-cpufreq.c   |7 
 drivers/gpu/drm/ast/ast_drv.c |   21 
 drivers/gpu/drm/ast/ast_mode.c|3 
 drivers/input/gameport/gameport.c |4 
 drivers/input/joystick/xpad.c | 1422 --
 drivers/input/misc/ims-pcu.c  |4 
 drivers/input/serio/serio.c   |4 
 drivers/input/serio/serio_raw.c   |4 
 drivers/net/can/dev.c |   48 -
 drivers/net/wireless/cw1200/wsm.c |   16 
 drivers/scsi/qla2xxx/qla_os.c |5 
 drivers/scsi/ufs/ufs.h|3 
 drivers/scsi/ufs/ufshcd.c |   72 +
 drivers/tty/n_tty.c   |   19 
 drivers/tty/tty_buffer.c  |2 
 drivers/usb/core/hub.c|4 
 fs/9p/vfs_dir.c   |   11 
 fs/bfs/inode.c|9 
 fs/gfs2/ops_fstype.c  |2 
 include/linux/can/dev.h   |1 
 kernel/debug/kdb/kdb_io.c |   15 
 kernel/debug/kdb/kdb_private.h|2 
 kernel/debug/kdb/kdb_support.c|   10 
 mm/shmem.c|4 
 net/llc/af_llc.c  |   11 
 net/sctp/associola.c  |   10 
 net/sunrpc/auth_generic.c |8 
 net/unix/af_unix.c|   27 
 31 files changed, 1289 insertions(+), 465 deletions(-)

Andrew Price (1):
  gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd

Aniroop Mathur (1):
  Input: initialize device counter variables with -1

Anson Huang (1):
  cpufreq: imx6q: add return value check for voltage scale

Arnd Bergmann (1):
  Input: xpad - remove unused function

Arvind Yadav (1):
  Input: xpad - constify usb_device_id

Benjamin Valentin (5):
  Input: xpad - sort supported devices by USB ID
  Input: xpad - sync supported devices with xboxdrv
  Input: xpad - add USB IDs for Mad Catz Brawlstick and Razer Sabertooth
  Input: xpad - sync supported devices with 360Controller
  Input: xpad - sync supported devices with XBCD

Cameron Gutman (12):
  Input: xpad - prevent spurious input from wired Xbox 360 controllers
  Input: xpad - fix rumble on Xbox One controllers with 2015 firmware
  Input: xpad - fix oops when attaching an unknown Xbox One gamepad
  Input: xpad - power off wireless 360 controllers on suspend
  Input: xpad - add product ID for Xbox One S pad
  Input: xpad - fix Xbox One rumble stopping after 2.5 secs
  Input: xpad - don't depend on endpoint order
  Input: xpad - fix stuck mode button on Xbox One S pad
  Input: xpad - restore LED state after device resume
  Input: xpad - support some quirky Xbox One pads
  Input: xpad - fix PowerA init quirk for some gamepad models
  Input: xpad - validate USB endpoint type during probe

Clement Calmels (1):
  Input: xpad - remove spurious events of wireless xpad 360 controller

Daniel Tobias (2):
  Input: xpad - correctly sort vendor id's
  Input: xpad - move reporting xbox one home button to common function

Dario Scarpa (1):
  Input: xpad - fix Razer Atrox Arcade Stick button mapping

Dennis Wassenberg (1):
  usb: core: Fix hub port connection events lost

Dmitry Torokhov (1):
  Input: xpad - use LED API when identifying wireless controllers

Dominique Martinet (1):
  v9fs_dir_readdir: fix double-free on p9stat_read error

Enno Boland (1):
  Input: xpad - fix GPD Win 2 controller name

Eric Dumazet (1):
  llc: do not use sk_eat_skb()

Erik Lundgren (1):
  Input: xpad - add Covert Forces edition of the Xbox One controller

Ethan Lee (1):
  Input: xpad - add GPD Win 2 Controller USB IDs

Francis Therien (1):
  Input: xpad - add PDP device id 0x02a4

Greg Hackmann (1):
  arm64: remove no-op -p linker flag

Greg Kroah-Hartman (2):
  tty: wipe buffer if not echoing data
  Linux 3.18.128

Johannes Thumshirn (1):
  cw1200: Don't leak memory if krealloc failes

Leo Sperling (1):
  Input: xpad - fix some coding style issues

Linus Torvalds (1):
  tty: wipe buffer.

Marc Kleine-Budde (4):
  can: dev: can_get_echo_skb(): factor out non sending code to 
__can_get_echo_skb()
  can: dev: __can_get_echo_skb(): replace struct can_frame by canfd_frame 
to access frame length
  can: dev: __can_get_echo_skb(): Don't crash the kernel if 
can_priv::echo_skb is accessed out of bounds
  can: dev: __can_get_echo_skb(): print error message, if trying to echo 
non 

Re: [RFC PATCH 2/6] char: fastrpc: Add Qualcomm fastrpc basic driver model

2018-11-30 Thread Greg KH
On Fri, Nov 30, 2018 at 10:46:53AM +, Srinivas Kandagatla wrote:
> This patch adds basic driver model for qualcomm fastrpc.
> Each DSP rpmsg channel is represented as fastrpc channel context and
> is exposed as a character driver for userspace interface.
> Each compute context bank is represented as fastrpc-session-context,
> which are dynamically managed by the channel context char device.
> 
> Signed-off-by: Srinivas Kandagatla 
> ---
>  drivers/char/Kconfig   |  10 ++
>  drivers/char/Makefile  |   1 +
>  drivers/char/fastrpc.c | 337 +
>  3 files changed, 348 insertions(+)
>  create mode 100644 drivers/char/fastrpc.c
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 9d03b2ff5df6..75fd274c67df 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -552,6 +552,16 @@ config ADI
> and SSM (Silicon Secured Memory).  Intended consumers of this
> driver include crash and makedumpfile.
>  
> +config QCOM_FASTRPC
> + tristate "Qualcomm FastRPC"
> + depends on ARCH_QCOM || COMPILE_TEST
> + depends on RPMSG
> + help
> +   Provides a communication mechanism that allows for clients to
> +   make remote method invocations across processor boundary to
> +   applications DSP processor. Say M if you want to enable this
> +   module.
> +
>  endmenu
>  
>  config RANDOM_TRUST_CPU
> diff --git a/drivers/char/Makefile b/drivers/char/Makefile
> index b8d42b4e979b..30ec9187350e 100644
> --- a/drivers/char/Makefile
> +++ b/drivers/char/Makefile
> @@ -58,3 +58,4 @@ js-rtc-y = rtc.o
>  obj-$(CONFIG_XILLYBUS)   += xillybus/
>  obj-$(CONFIG_POWERNV_OP_PANEL)   += powernv-op-panel.o
>  obj-$(CONFIG_ADI)+= adi.o
> +obj-$(CONFIG_QCOM_FASTRPC)   += fastrpc.o
> diff --git a/drivers/char/fastrpc.c b/drivers/char/fastrpc.c
> new file mode 100644
> index ..97d8062eb3e1
> --- /dev/null
> +++ b/drivers/char/fastrpc.c
> @@ -0,0 +1,337 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2011-2018, The Linux Foundation. All rights reserved.
> +// Copyright (c) 2018, Linaro Limited
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#define ADSP_DOMAIN_ID (0)
> +#define MDSP_DOMAIN_ID (1)
> +#define SDSP_DOMAIN_ID (2)
> +#define CDSP_DOMAIN_ID (3)
> +#define FASTRPC_DEV_MAX  4 /* adsp, mdsp, slpi, cdsp*/
> +#define FASTRPC_MAX_SESSIONS 9 /*8 compute, 1 cpz*/
> +#define FASTRPC_CTX_MAX (256)
> +#define FASTRPC_CTXID_MASK (0xFF0)
> +#define FASTRPC_DEVICE_NAME  "fastrpc"
> +
> +#define cdev_to_cctx(d) container_of(d, struct fastrpc_channel_ctx, cdev)
> +
> +static const char *domains[FASTRPC_DEV_MAX] = { "adsp", "mdsp",
> + "sdsp", "cdsp"};
> +static dev_t fastrpc_major;

Why do you need a whole major number for this?  Why not just use the
misc interface instead?



[GIT PULL] Driver core fix for 4.20-rc5

2018-11-30 Thread Greg KH
The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:

  Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
tags/driver-core-4.20-rc5

for you to fetch changes up to a66d972465d15b1d89281258805eb8b47d66bd36:

  devres: Align data[] to ARCH_KMALLOC_MINALIGN (2018-11-11 11:40:04 -0800)


Driver core fix for 4.20-rc5

Here is a single driver core fix for 4.20-rc5

It resolves an issue with the data alignment in 'struct devres' for the
ARC platform.  The full details are in the commit changelog, but the
short summary is the change is a single line:
-   unsigned long long  data[]; /* guarantee ull alignment */
+   u8 __aligned(ARCH_KMALLOC_MINALIGN) data[];

This has been in linux-next for a while with no reported issues.

Signed-off-by: Greg Kroah-Hartman 


Alexey Brodkin (1):
  devres: Align data[] to ARCH_KMALLOC_MINALIGN

 drivers/base/devres.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)


[GIT PULL] Char/Misc driver fixes for 4.20-rc5

2018-11-30 Thread Greg KH
The following changes since commit 2e6e902d185027f8e3cb8b7305238f7e35d6a436:

  Linux 4.20-rc4 (2018-11-25 14:19:31 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 
tags/char-misc-4.20-rc5

for you to fetch changes up to 6484a677294aa5d08c0210f2f387ebb9be646115:

  misc: mic/scif: fix copy-paste error in scif_create_remote_lookup (2018-11-27 
09:00:38 +0100)


Char/Misc fixes for 4.20-rc5

Here are a few small char/misc driver fixes for 4.20-rc5 that resolve a
number of reported issues.

The "largest" here is the thunderbolt patch, which resolves an issue
with NVM upgrade, the smallest being some fsi driver fixes.  There's
also a hyperv bugfix, and the usual binder bugfixes.

All of these have been in linux-next with no reported issues.

Signed-off-by: Greg Kroah-Hartman 


Arnd Bergmann (1):
  fsi: master-ast-cf: select GENERIC_ALLOCATOR

Brajeswar Ghosh (1):
  fsi: fsi-scom.c: Remove duplicate header

Dexuan Cui (1):
  Drivers: hv: vmbus: check the creation_status in vmbus_establish_gpadl()

Greg Kroah-Hartman (1):
  Merge tag 'fsi-updates-2018-11-26' of 
git://git.kernel.org/.../benh/linux-fsi char-misc-linus

Mika Westerberg (1):
  thunderbolt: Prevent root port runtime suspend during NVM upgrade

Todd Kjos (1):
  binder: fix race that allows malicious free of live buffer

YueHaibing (1):
  misc: mic/scif: fix copy-paste error in scif_create_remote_lookup

 drivers/android/binder.c | 21 -
 drivers/android/binder_alloc.c   | 16 ++--
 drivers/android/binder_alloc.h   |  3 +--
 drivers/fsi/Kconfig  |  1 +
 drivers/fsi/fsi-scom.c   |  1 -
 drivers/hv/channel.c |  8 
 drivers/misc/mic/scif/scif_rma.c |  2 +-
 drivers/thunderbolt/switch.c | 40 ++--
 8 files changed, 67 insertions(+), 25 deletions(-)


[GIT PULL] Staging/IIO driver fixes for 4.20-rc5

2018-11-30 Thread Greg KH
The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:

  Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 
tags/staging-4.20-rc5

for you to fetch changes up to c648284f6c9606f1854816086593eeae5556845a:

  Merge tag 'iio-fixes-for-4.20a' of 
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus 
(2018-11-22 09:37:36 +0100)


Staging and IIO driver fixes for 4.20-rc5

Here are some small IIO and Staging driver fixes for 4.20-rc5.

Nothing major, the IIO fix ended up touching the HID drivers at the same
time, but the HID maintainer acked it.  The staging fixes are all minor
patches for reported issues and regressions, full details are in the
shortlog.

All of these have been in linux-next for a while with no reported
issues.

Signed-off-by: Greg Kroah-Hartman 


Ben Wolsieffer (1):
  staging: vchiq_arm: fix compat VCHIQ_IOC_AWAIT_COMPLETION

Christophe JAILLET (1):
  staging: rtl8723bs: Fix the return value in case of error in 
'rtw_wx_read32()'

Colin Ian King (3):
  drivers: staging: cedrus: find ctx before dereferencing it ctx
  staging: most: use format specifier "%s" in snprintf
  staging: mt7621-pinctrl: fix uninitialized variable ngroups

Greg Kroah-Hartman (1):
  Merge tag 'iio-fixes-for-4.20a' of git://git.kernel.org/.../jic23/iio 
into staging-linus

Hans de Goede (1):
  iio/hid-sensors: Fix IIO_CHAN_INFO_RAW returning wrong values for signed 
numbers

Larry Finger (2):
  staging: rtl8723bs: Fix incorrect sense of ether_addr_equal
  staging: rtl8723bs: Add missing return for cfg80211_rtw_get_station

Martin Kelly (1):
  iio:st_magn: Fix enable device after trigger

Sergio Paracuellos (1):
  staging: mt7621-dma: fix potentially dereferencing uninitialized 'tx_desc'

Spencer E. Olson (2):
  staging: comedi: ni_mio_common: scale ao 
INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS
  staging: comedi: clarify/unify macros for NI macro-defined terminals

 drivers/hid/hid-sensor-custom.c|  2 +-
 drivers/hid/hid-sensor-hub.c   | 13 ++--
 drivers/iio/accel/hid-sensor-accel-3d.c|  5 ++-
 drivers/iio/gyro/hid-sensor-gyro-3d.c  |  5 ++-
 drivers/iio/humidity/hid-sensor-humidity.c |  3 +-
 drivers/iio/light/hid-sensor-als.c |  8 +++--
 drivers/iio/light/hid-sensor-prox.c|  8 +++--
 drivers/iio/magnetometer/hid-sensor-magn-3d.c  |  8 +++--
 drivers/iio/magnetometer/st_magn_buffer.c  | 12 ++-
 drivers/iio/orientation/hid-sensor-incl-3d.c   |  8 +++--
 drivers/iio/pressure/hid-sensor-press.c|  8 +++--
 drivers/iio/temperature/hid-sensor-temperature.c   |  3 +-
 drivers/rtc/rtc-hid-sensor-time.c  |  2 +-
 drivers/staging/comedi/comedi.h| 39 --
 drivers/staging/comedi/drivers/ni_mio_common.c |  3 +-
 drivers/staging/media/sunxi/cedrus/cedrus.c| 22 ++--
 drivers/staging/most/core.c|  2 +-
 drivers/staging/mt7621-dma/mtk-hsdma.c |  3 +-
 drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c|  2 +-
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c |  4 +--
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c  |  2 +-
 drivers/staging/rtl8723bs/os_dep/ioctl_linux.c |  2 +-
 .../vc04_services/interface/vchiq_arm/vchiq_arm.c  |  7 +++-
 include/linux/hid-sensor-hub.h |  4 ++-
 24 files changed, 103 insertions(+), 72 deletions(-)


Re: [PATCH AUTOSEL 4.14 25/35] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-30 Thread Greg KH
On Fri, Nov 30, 2018 at 09:40:19AM +1100, Dave Chinner wrote:
> On Thu, Nov 29, 2018 at 01:47:56PM +0100, Greg KH wrote:
> > On Thu, Nov 29, 2018 at 11:14:59PM +1100, Dave Chinner wrote:
> > > 
> > > Cherry picking only one of the 50-odd patches we've committed into
> > > late 4.19 and 4.20 kernels to fix the problems we've found really
> > > seems like asking for trouble. If you're going to back port random
> > > data corruption fixes, then you need to spend a *lot* of time
> > > validating that it doesn't make things worse than they already
> > > are...
> > 
> > Any reason why we can't take the 50-odd patches in their entirety?  It
> > sounds like 4.19 isn't fully fixed, but 4.20-rc1 is?  If so, what do you
> > recommend we do to make 4.19 working properly?
> 
> You coul dpull all the fixes, but then you have a QA problem.
> Basically, we have multiple badly broken syscalls (FICLONERANGE,
> FIDEDUPERANGE and copy_file_range), and even 4.20-rc4 isn't fully
> fixed.
> 
> There were ~5 critical dedupe/clone data corruption fixes for XFS
> went into 4.19-rc8.

Have any of those been tagged for stable?

> There were ~30 patches that went into 4.20-rc1 that fixed the
> FICLONERANGE/FIDEDUPERANGE ioctls. That completely reworks the
> entire VFS infrastructure for those calls, and touches several
> filesystems as well. It fixes problems with setuid files, swap
> files, modifying immutable files, failure to enforce rlimit and
> max file size constraints, behaviour that didn't match man page
> descriptions, etc.
> 
> There were another ~10 patches that went into 4.20-rc4 that fixed
> yet more data corruption and API problems that we found when we
> enhanced fsx to use the above syscalls.
> 
> And I have another ~10 patches that I'm working on right now to fix
> the copy_file_range() implementation - it has all the same problems
> I listed above for FICLONERANGE/FIDEDUPERANGE and some other unique
> ones. I'm currently writing error condition tests for fstests so
> that we at least have some coverage of the conditions
> copy_file_range() is supposed to catch and fail. This might all make
> a late 4.20-rcX, but it's looking more like 4.21 at this point.
> 
> As to testing this stuff, I've spend several weeks now on this and
> so has Darrick. Between us we've done a huge amount of QA needed to
> verify that the problems are fixed and it is still ongoing. From
> #xfs a couple of days ago:
> 
> [28/11/18 16:59] * djwong hits 6 billion fsxops...
> [28/11/18 17:07]  djwong: I've got about 3.75 billion ops running 
> on a machine here
> [28/11/18 17:20]  note that's 1 billion fsxops x 6 machines
> [28/11/18 17:21]  [xfsv4, xfsv5, xfsv5 w/ 1k blocks] * [directio fsx, 
> buffered fsx]
> [28/11/18 17:21]  Oh, I've got 3.75B x 4 instances on one 
> filesystem :P
> [28/11/18 17:22]  [direct io, buffered] x [small op lengths, large 
> op lengths]
> 
> And this morning:
> 
> [30/11/18 08:53]  7 billion fsxops...
> 
> I stopped my tests at 5 billion ops yesterday (i.e. 20 billion ops
> aggregate) to focus on testing the copy_file_range() changes, but
> Darrick's tests are still ongoing and have passed 40 billion ops in
> aggregate over the past few days.
> 
> The reason we are running these so long is that we've seen fsx data
> corruption failures after 12+ hours of runtime and hundreds of
> millions of ops. Hence the testing for backported fixes will need to
> replicate these test runs across multiple configurations for
> multiple days before we have any confidence that we've actually
> fixed the data corruptions and not introduced any new ones.
> 
> If you pull only a small subset of the fixes, the fsx will still
> fail and we have no real way of actually verifying that there have
> been no regression introduced by the backport.  IOWs, there's a
> /massive/ amount of QA needed for ensuring that these backports work
> correctly.
> 
> Right now the XFS developers don't have the time or resources
> available to validate stable backports are correct and regression
> fre because we are focussed on ensuring the upstream fixes we've
> already made (and are still writing) are solid and reliable.

Ok, that's fine, so users of XFS should wait until the 4.20 release
before relying on it?  :)

I understand your reluctance to want to backport anything, but it really
feels like you are not even allowing for fixes that are "obviously
right" to be backported either, even after they pass testing.  Which
isn't ok for your users.

thanks,

greg k-h


Re: [PATCH v4 4/6] coresight: Use PMU driver configuration for sink selection

2018-11-29 Thread Greg KH
On Thu, Nov 29, 2018 at 04:09:15PM -0700, Mathieu Poirier wrote:
> Hi Greg,
> 
> On Thu, Nov 29, 2018 at 08:49:36AM +0100, Greg KH wrote:
> > On Wed, Nov 28, 2018 at 03:01:16PM -0700, Mathieu Poirier wrote:
> > > This patch uses the PMU driver configuration held in event::hw::drv_config
> > > to select a sink for each event that is created (the old sysFS way of
> > > working is kept around for backward compatibility).
> > 
> > It is "sysfs", no InterCaps please, I've never called it that in the
> > past.
> > 
> > And just use sysfs, if that does not work properly, then fix that, don't
> > create yet-another-way-to-configure-this-thing to just confuse people.
> 
> Thanks for the review, you've provided usefull comments.
> 
> Regarding the "char *" argument for the ioctl, I followed an example that
> currently exist but I can proceed differently.  

What driver currently uses a char * on an ioctl to parse arbritrary
userspace information to set its configuration?  That should be fixed...

> My goal with this patchset was specifically to fix what is wrong with sysfs 
> and
> completely take it out of the equation.  The only reason to keep the kernel 
> interface alive was to prevent braking older user space perf tools currently
> using it.  

That's fine, just don't create a new syscall that takes arbritrary data
and parses it in the kernel, that's not ok.

> I chose to use an ioctl() because it is flexible and well suited for the 
> dynamic
> nature of perf events.  It is also currently used to set various event 
> specific 
> configuration so doing the same adds to the established pattern and avoids
> creating a new way of doing things, something the perf crew would have been
> quick to point out.
> 
> Was my approach wrong?

I don't know how the perf interface works, so perhaps work with those
developers to sync up and match what they use today?

But step back, what exactly are you trying to do here?  You have an
implementation of a solution but I don't see the problem stated anywhere
here.

thanks,

greg k-h


Re: [PATCH] Input: mouse: elan_i2c_core: Added support for ELAN0621 touchpad.

2018-11-29 Thread Greg KH
On Thu, Nov 29, 2018 at 11:30:19AM -0500, a...@adamwong.me wrote:
> From: TheWongGuy 
> 
> Added the ability to detect the ELAN0621 touchpad found in some Lenovo
> laptops.
> 
> Signed-off-by: TheWongGuy 

I doubt that is the name on your passport :(

Please use your "real" name, like you did for the signed-off-by last
time, just fix up the From: line.

thanks,

greg k-h


Re: [PATCH 4.19 033/110] bfs: add sanity check at bfs_fill_super()

2018-11-29 Thread Greg KH
On Thu, Nov 29, 2018 at 04:55:20PM +, Tigran Aivazian wrote:
> On Thu, 29 Nov 2018 at 16:07, Greg KH  wrote:
> > On Thu, Nov 29, 2018 at 03:23:00PM +, Tigran Aivazian wrote:
> > > Yes, of course I object to it.
> > I can not apply a patch to the stable trees that are not in Linus's tree
> > first.  So there's nothing I can do here with this.
> 
> Ok, we can wait until my patch propagates into Linus' tree, but I
> would have thought it would be a waste of your time to apply a patch
> which is waiting to be inevitably superseded by a different one.

Your patch has to apply on top of the existing one, so there's not an
issue here.

And might as well fix it now, as I can never count on a "future" patch
getting merged.

> I can
> see there are 238 PRs at Linus' tree on github and I am very glad that
> I looked into one of them --- it contained a long comment explaining
> that I should NOT do what I was just about to do, i.e. make a PR
> against Linus' tree! :)

We do not do kernel development on github :)

thanks,

greg k-h


Re: [PATCH 4.19 033/110] bfs: add sanity check at bfs_fill_super()

2018-11-29 Thread Greg KH
On Thu, Nov 29, 2018 at 03:23:00PM +, Tigran Aivazian wrote:
> Hello,
> 
> Yes, of course I object to it. I ignored this version of the patch
> being applied to the older Linux versions, but for the latest versions
> surely the version that I have authored should be applied instead. I
> have sent to Andrew Morton both the 4.20-rc1 and 4.19.2 versions of
> the patch. The 4.20 was applied (as "linux-next", I don't know why it
> is not in 4.20-rc4 yet), but 4.19.2 version was not applied yet, so
> here it is attached again (with the proper changelog etc). It applies
> to 4.19.5 cleanly as well, so please use this version (attached).

I can not apply a patch to the stable trees that are not in Linus's tree
first.  So there's nothing I can do here with this.

Until then, I'll take the patch that is already in Linus's tree, which
is what I did here, thanks.

greg k-h


Re: [PATCH] [stable, netdev 4.4+] lan78xx: make sure RX_ADDRL & RX_ADDRH regs are always up to date

2018-11-29 Thread Greg KH
On Thu, Nov 08, 2018 at 10:49:04AM -0500, Sasha Levin wrote:
> On Thu, Nov 08, 2018 at 12:01:27PM +0100, Paolo Pisati wrote:
> > On Wed, Nov 07, 2018 at 07:17:51PM -0500, Sasha Levin wrote:
> > > So why not just take 760db29bdc completely? It looks safer than taking a
> > > partial backport, and will make applying future patches easier.
> > > 
> > > I tried to do it and it doesn't look like there are any dependencies
> > > that would cause an issue.
> > 
> > Somehow i was convinced it didn't build on 4.4.x... can you pick it up?
> > 
> > commit 760db29bdc97b73ff60b091315ad787b1deb5cf5
> > Author: Phil Elwell 
> > Date:   Thu Apr 19 17:59:38 2018 +0100
> > 
> >lan78xx: Read MAC address from DT if present
> > 
> >There is a standard mechanism for locating and using a MAC address from
> >the Device Tree. Use this facility in the lan78xx driver to support
> >applications without programmed EEPROM or OTP. At the same time,
> >regularise the handling of the different address sources.
> > 
> >Signed-off-by: Phil Elwell 
> >Signed-off-by: David S. Miller 
> 
> Can you confirm it actually works on 4.4?

It does not build on 4.4, so I'm dropping it :(

greg k-h


Re: [PATCH] mm: hide incomplete nr_indirectly_reclaimable in /proc/zoneinfo

2018-11-29 Thread Greg KH
On Tue, Oct 30, 2018 at 05:48:25PM +, Roman Gushchin wrote:
> Yongqin reported that /proc/zoneinfo format is broken in 4.14
> due to commit 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable
> in /proc/vmstat")
> 
> Node 0, zone  DMA
>   per-node stats
>   nr_inactive_anon 403
>   nr_active_anon 89123
>   nr_inactive_file 128887
>   nr_active_file 47377
>   nr_unevictable 2053
>   nr_slab_reclaimable 7510
>   nr_slab_unreclaimable 10775
>   nr_isolated_anon 0
>   nr_isolated_file 0
>   <...>
>   nr_vmscan_write 0
>   nr_vmscan_immediate_reclaim 0
>   nr_dirtied   6022
>   nr_written   5985
>74240
>   ^^
>   pages free 131656
> 
> The problem is caused by the nr_indirectly_reclaimable counter,
> which is hidden from the /proc/vmstat, but not from the
> /proc/zoneinfo. Let's fix this inconsistency and hide the
> counter from /proc/zoneinfo exactly as from /proc/vmstat.
> 
> BTW, in 4.19+ the counter has been renamed and exported by
> the commit b29940c1abd7 ("mm: rename and change semantics of
> nr_indirectly_reclaimable_bytes"), so there is no such a problem
> anymore.
> 
> Cc:  # 4.14.x-4.18.x
> Fixes: 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable in 
> /proc/vmstat")
> Reported-by: Yongqin Liu 
> Signed-off-by: Roman Gushchin 
> Cc: Vlastimil Babka 
> Cc: Andrew Morton 
> ---
>  mm/vmstat.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 527ae727d547..6389e876c7a7 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -1500,6 +1500,10 @@ static void zoneinfo_show_print(struct seq_file *m, 
> pg_data_t *pgdat,
>   if (is_zone_first_populated(pgdat, zone)) {
>   seq_printf(m, "\n  per-node stats");
>   for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) {
> + /* Skip hidden vmstat items. */
> + if (*vmstat_text[i + NR_VM_ZONE_STAT_ITEMS +
> +  NR_VM_NUMA_STAT_ITEMS] == '\0')
> + continue;
>   seq_printf(m, "\n  %-12s %lu",
>   vmstat_text[i + NR_VM_ZONE_STAT_ITEMS +
>   NR_VM_NUMA_STAT_ITEMS],
> -- 
> 2.17.2
> 

I do not see this patch in Linus's tree, do you?

If not, what am I supposed to do with this?

confused,

greg k-h


Re: [PATCH AUTOSEL 4.14 25/35] iomap: sub-block dio needs to zeroout beyond EOF

2018-11-29 Thread Greg KH
On Thu, Nov 29, 2018 at 11:14:59PM +1100, Dave Chinner wrote:
> 
> Cherry picking only one of the 50-odd patches we've committed into
> late 4.19 and 4.20 kernels to fix the problems we've found really
> seems like asking for trouble. If you're going to back port random
> data corruption fixes, then you need to spend a *lot* of time
> validating that it doesn't make things worse than they already
> are...

Any reason why we can't take the 50-odd patches in their entirety?  It
sounds like 4.19 isn't fully fixed, but 4.20-rc1 is?  If so, what do you
recommend we do to make 4.19 working properly?

thanks,

greg k-h


Re: [PATCH RCU -stable] Make need_resched() respond to urgent RCU-QS needs

2018-11-29 Thread Greg KH
On Sun, Nov 04, 2018 at 06:34:34PM -0800, Paul E. McKenney wrote:
> commit 92aa39e9dc77 upstream.
> 
> The per-CPU rcu_dynticks.rcu_urgent_qs variable communicates an urgent
> need for an RCU quiescent state from the force-quiescent-state processing
> within the grace-period kthread to context switches and to cond_resched().
> Unfortunately, such urgent needs are not communicated to need_resched(),
> which is sometimes used to decide when to invoke cond_resched(), for
> but one example, within the KVM vcpu_run() function.  As of v4.15, this
> can result in synchronize_sched() being delayed by up to ten seconds,
> which can be problematic, to say nothing of annoying.
> 
> This commit therefore checks rcu_dynticks.rcu_urgent_qs from within
> rcu_check_callbacks(), which is invoked from the scheduling-clock
> interrupt handler.  If the current task is not an idle task and is
> not executing in usermode, a context switch is forced, and either way,
> the rcu_dynticks.rcu_urgent_qs variable is set to false.  If the current
> task is an idle task, then RCU's dyntick-idle code will detect the
> quiescent state, so no further action is required.  Similarly, if the
> task is executing in usermode, other code in rcu_check_callbacks() and
> its called functions will report the corresponding quiescent state.
> 
> Reported-by: Marius Hillenbrand 
> Reported-by: David Woodhouse 
> Suggested-by: Peter Zijlstra 
> Signed-off-by: Paul E. McKenney 
> [ paulmck: Backported to make patch apply cleanly on older versions. ]
> Tested-by: Marius Hillenbrand 
> Cc:  # 4.12.x - 4.19.x
> 

Now queued up, thanks.

greg k-h


Re: [PATCH] sched: Do not bug in __sched_setscheduler() when pi is not used

2018-11-29 Thread Greg KH
On Mon, Nov 19, 2018 at 02:27:56PM -0500, Steven Rostedt wrote:
> On Mon, 19 Nov 2018 11:09:50 -0800
> Florian Fainelli  wrote:
> 
> 
> > > I did the change against v4.2.8 below.  
> > 
> > Thanks Steven! Here is the local 4.9 backport:
> 
> Yours even updates the comment.
> 
> Reviewed-by: Steven Rostedt (VMware) 

Now applied, thanks.

greg k-h


Re: [PATCH] ubi: fastmap: Check each mapping only once

2018-11-29 Thread Greg KH
On Mon, Nov 26, 2018 at 11:38:42AM +0100, Martin Kepplinger wrote:
> From: Richard Weinberger 
> 
> [ Upstream commit 34653fd8c46e771585fce5975e4243f8fd401914 ]
> 
> This commit got merged along with commit 781932375ffc
> ("ubi: fastmap: Correctly handle interrupted erasures in EBA") upstream but
> only the latter has been applied to stable v4.14.54 as commit a23cf10d9abb.
> This resulted in a performance regression. Startup on i.MX platforms is
> delayed for up to a few seconds depending on the platform.
> This fixes ubi fastmap to be of the same performance as it has been before
> said fastmap changes.
> 
> Fixes: a23cf10d9abb ("ubi: fastmap: Correctly handle interrupted erasures in 
> EBA")
> Signed-off-by: Richard Weinberger 
> Signed-off-by: Martin Kepplinger 
> ---
> 
> Richard, although this fixes a major slowdown regression in -stable, do you
> consider this "stable" too?
> 
> This applies and is tested only for the 4.14 stable tree. It seems to be
> equally relevant for 4.9 and 4.4 though.

Now queued up for 4.14.y, thanks.

greg k-h


Re: [PATCH] Input: mouse: elan_i2c_core: Added support for ELAN0621 touchpad.

2018-11-28 Thread Greg KH
On Wed, Nov 28, 2018 at 04:20:01PM -0500, a...@adamwong.me wrote:
> From: TheWongGuy 

This name, does not match:

> Signed-off-by: Adam Wong 

That name :(

Please fix.

thanks,

greg k-h


Re: [PATCH v4 4/6] coresight: Use PMU driver configuration for sink selection

2018-11-28 Thread Greg KH
On Wed, Nov 28, 2018 at 03:01:16PM -0700, Mathieu Poirier wrote:
> This patch uses the PMU driver configuration held in event::hw::drv_config
> to select a sink for each event that is created (the old sysFS way of
> working is kept around for backward compatibility).

It is "sysfs", no InterCaps please, I've never called it that in the
past.

And just use sysfs, if that does not work properly, then fix that, don't
create yet-another-way-to-configure-this-thing to just confuse people.

thanks,

greg k-h


Re: [PATCH v4 2/6] perf/core: Use ioctl to communicate driver configuration to kernel

2018-11-28 Thread Greg KH
On Wed, Nov 28, 2018 at 03:01:14PM -0700, Mathieu Poirier wrote:
> This patch adds the mechanic needed for user space to send PMU specific
> configuration to the kernel driver using an ioctl() command.  That way
> events can keep track of options that don't fit in the perf_event_attr
> structure like the selection of a CoreSight sink to use for the session.

This is what configfs is for, please use that instead of a generic "send
a string to the kernel for it to parse" type of thing.  No other driver
does this (or if they do, they should not), so this driver should not do
it as well, sorry.

greg k-h


Re: [PATCH v4 1/6] perf: Introduce ioctl to communicate driver configuration to kernel

2018-11-28 Thread Greg KH
On Wed, Nov 28, 2018 at 03:01:13PM -0700, Mathieu Poirier wrote:
> Adding a new IOCTL command to communicate PMU specific configuration to
> PMU kernel drivers.  This can be anything a PMU might need for
> configuration that doesn't fit in the perf_event_attr structure, such
> as the CoreSight sink to use for a session.
> 
> Signed-off-by: Mathieu Poirier 
> ---
>  include/uapi/linux/perf_event.h   | 1 +
>  tools/include/uapi/linux/perf_event.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index 9de8780ac8d9..bb558caeb33b 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -462,6 +462,7 @@ struct perf_event_query_bpf {
>  #define PERF_EVENT_IOC_PAUSE_OUTPUT  _IOW('$', 9, __u32)
>  #define PERF_EVENT_IOC_QUERY_BPF _IOWR('$', 10, struct 
> perf_event_query_bpf *)
>  #define PERF_EVENT_IOC_MODIFY_ATTRIBUTES _IOW('$', 11, struct 
> perf_event_attr *)
> +#define PERF_EVENT_IOC_SET_DRV_CONFIG_IOW('$', 12, char *)


A generic "char *" that the kernel is then going to parse?  Can you make
any more flexible of a new syscall to the kernel that allows anyone to
do anything with this?  :)

Please make this a lot more specific, this is way to generic, sorry.

greg k-h


Re: [PATCH anybus v4 1/7] fieldbus_dev: add Fieldbus Device subsystem.

2018-11-28 Thread Greg KH
On Wed, Nov 28, 2018 at 01:19:05PM -0500, Sven Van Asbroeck wrote:
> On Wed, Nov 28, 2018 at 12:42 PM Greg KH  wrote:
> 
> > It depends on what you want to do with this device node.  You can use a
> > static one in your structure if you use it to "cast back" to your real
> > structure in the open() call, do you do that?
> 
> I do...
> 
> static int fieldbus_open(struct inode *inode, struct file *filp)
> {
> struct fieldbus_dev *fbdev = container_of(inode->i_cdev,
> struct fieldbus_dev,
> cdev);

Ok, good, that's a nice way to use this, nevermind my objection.

> > Or use a misc device?  How many of these do you need?
> 
> Just one per fieldbus device.
> But my main concern is naming in sysfs. A misc device will always show up as
> /sys/class/misc/..., right? Given that this is a userspace fieldbus API,
> we'd prefer /sys/class/fieldbus_dev/..., and cdev is the only way?

Ah, the common misunderstanding.

A cdev has NOTHING to do with the /sys/class/ entries.  It is only there
to register a char device with the kernel core and to handle the file
operations that are caused by it.  It does not do much, and not even the
/dev/NODE stuff either.  That is up to your class device code.

So you still need a char device, and you will have have a load of them,
just use the misc device api.  It's simple, clean, and is hard to get
wrong.  The cdev api is hard, complex, and trivial to get wrong in any
number of different ways that it can be used :)

That being said, it looks like you used it correctly, so all should be
fine here.

And your /sys/class/fieldbus_dev/ is "interesting", why name it that?

> > For an online/offline attribute, no need to poll on it, just do a
> > 'kobject change' event for online/offline and all should be fine.  This
> > is not a high-frequency event, right?
> 
> Grepping... you mean kobject_uevent(KOBJ_CHANGE) ?
> THAT mechanism seems to fit much better, thanks !!

Yes, use that please.

> > Hey, if no one wants to use it, either no need to write any code at all,
> > or you get to decide everything.  Either way, you're in charge!  :)
> 
> I did get the impression that people are reluctant to take my patch partly
> because of an unproven userspace API. Maybe they are (rightly) worried that,
> once in, we will have to support this userspace API for evermore.
> 
> I'd love to get others involved in Fieldbus on Linux, but I'm not sure
> how.

Adding a new driver subsystem is messy, it takes a lot of work and
finding the right reviewers is hard.  It's not just you, it happens all
the time (look at how long the i3c code took to get merged as one
example...)

So keep submitting, I'll try to review it the next time around, and all
should be fine.  But keep your user api as simple as possible for now,
only doing what you need it to do, worry about future stuff then.


> > But you do need to document the thing, in Documentation/ABI/ to get it
> > correct and able to be reviewed.
> 
> The documentation is already included in this patch? Should I indicate this
> in some standardized fashion?
> 
>  create mode 100644 Documentation/ABI/testing/fieldbus-dev-cdev
>  create mode 100644 Documentation/ABI/testing/sysfs-class-fieldbus-dev

Ah, sorry, I didn't read it, my fault :(

Why not just /sys/class/fieldbus/ ?  No need for "dev", right?

greg k-h


Re: [PATCH anybus v4 1/7] fieldbus_dev: add Fieldbus Device subsystem.

2018-11-28 Thread Greg KH
On Wed, Nov 28, 2018 at 10:39:41AM -0500, Sven Van Asbroeck wrote:
> Wow Greg, thanks for the review, this is awesome !!
> 
> On Tue, Nov 27, 2018 at 2:54 AM Greg KH  wrote:
> 
> >> + cdev_init(>cdev, _fops);
> >> + err = cdev_add(>cdev, devno, 1);
> >> + if (err) {
> >> + pr_err("fieldbus_dev%d unable to add device %d:%d\n",
> >> + fb->id, MAJOR(fieldbus_devt), fb->id);
> >> + goto err_cdev;
> >> + }
> >
> > Why do you have a static cdev?
> 
> The proposed fieldbus API needs a single /dev/fieldbus_devX node for every
> device. I just looked around the drivers/ tree to see how others accomplish
> this.
> 
> Is there a better way?

It depends on what you want to do with this device node.  You can use a
static one in your structure if you use it to "cast back" to your real
structure in the open() call, do you do that?  If not, just create one
dynamically.

Or use a misc device?  How many of these do you need?

> >> + fb->online_sd = sysfs_get_dirent(fb->dev->kobj.sd, "online");
> >
> > Ick, what?  Why?  Why are you messing around with a raw sysfs attribute?
> 
> The proposed fieldbus API has a sysfs attribute that can be poll/select'ed on.
> Is this behaviour still allowed / ok?

For an online/offline attribute, no need to poll on it, just do a
'kobject change' event for online/offline and all should be fine.  This
is not a high-frequency event, right?

> Now that I (hopefully) have a few seconds of your attention...
> I suppose the fieldbus API in this patch can't go anywhere, without buy-in 
> from
> multiple people who also want to use fieldbus. Right now, there are none.

Hey, if no one wants to use it, either no need to write any code at all,
or you get to decide everything.  Either way, you're in charge!  :)

But you do need to document the thing, in Documentation/ABI/ to get it
correct and able to be reviewed.

thanks,

greg k-h


Linux 4.4.165

2018-11-27 Thread Greg KH
I'm announcing the release of the 4.4.165 kernel.

All users of the 4.4 kernel series must upgrade.

The updated 4.4.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.4.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 .gitignore |1 
 Kbuild |   25 --
 Makefile   |   39 +++---
 arch/arm64/Makefile|4 ++
 arch/arm64/crypto/sha1-ce-core.S   |6 ++-
 arch/arm64/crypto/sha1-ce-glue.c   |   11 +-
 arch/arm64/crypto/sha2-ce-core.S   |6 ++-
 arch/arm64/crypto/sha2-ce-glue.c   |   13 ++-
 arch/arm64/include/asm/percpu.h|3 +
 arch/ia64/kernel/Makefile  |   26 +--
 arch/s390/kernel/vdso32/Makefile   |6 +--
 arch/s390/kernel/vdso64/Makefile   |6 +--
 arch/s390/numa/numa.c  |1 
 arch/um/os-Linux/skas/process.c|5 ++
 arch/x86/Makefile  |   39 --
 arch/x86/boot/compressed/aslr.c|3 +
 arch/x86/boot/string.c |9 +
 arch/x86/crypto/aes_ctrby8_avx-x86_64.S|7 +---
 arch/x86/include/asm/asm.h |1 
 drivers/acpi/acpi_platform.c   |1 
 drivers/block/zram/zram_drv.c  |   26 +++
 drivers/bluetooth/Kconfig  |1 
 drivers/clk/samsung/clk-exynos5420.c   |1 
 drivers/firmware/efi/libstub/Makefile  |2 -
 drivers/firmware/efi/libstub/arm64-stub.c  |   10 +
 drivers/hid/uhid.c |   13 +++
 drivers/hwmon/ibmpowernv.c |7 +---
 drivers/media/v4l2-core/v4l2-event.c   |   43 +
 drivers/media/v4l2-core/videobuf2-core.c   |9 +
 drivers/misc/atmel-ssc.c   |2 -
 drivers/misc/sgi-gru/grukdump.c|4 ++
 drivers/net/ethernet/broadcom/tg3.c|   18 +-
 drivers/platform/x86/acerhdf.c |1 
 drivers/uio/uio.c  |7 ++--
 drivers/usb/class/cdc-acm.c|3 +
 drivers/usb/core/quirks.c  |8 
 drivers/usb/host/xhci-hub.c|2 -
 drivers/usb/misc/appledisplay.c|1 
 fs/btrfs/disk-io.c |   19 ---
 fs/exofs/super.c   |5 ++
 fs/gfs2/rgrp.c |3 +
 fs/hfs/brec.c  |4 ++
 fs/hfsplus/brec.c  |4 ++
 fs/reiserfs/xattr.c|7 
 include/linux/kbuild.h |6 +--
 include/linux/module.h |4 +-
 include/linux/netfilter/ipset/ip_set_comment.h |4 +-
 include/linux/uaccess.h|3 +
 lib/raid6/test/Makefile|4 +-
 net/core/dev.c |4 ++
 net/core/flow_dissector.c  |4 +-
 net/ipv4/ip_tunnel_core.c  |2 -
 net/ipv6/route.c   |8 +++-
 net/netfilter/ipset/ip_set_hash_netportnet.c   |8 ++--
 net/netfilter/xt_IDLETIMER.c   |   20 +++
 net/sunrpc/xdr.c   |2 -
 scripts/Kbuild.include |   18 ++
 scripts/Makefile.build |8 
 scripts/Makefile.extrawarn |1 
 scripts/Makefile.lib   |   31 ++
 scripts/mod/Makefile   |   28 +---
 61 files changed, 348 insertions(+), 219 deletions(-)

Al Viro (1):
  new helper: uaccess_kernel()

Andreas Gruenbacher (1):
  gfs2: Put bitmap buffers in put_super

Ard Biesheuvel (3):
  crypto: arm64/sha - avoid non-standard inline asm tricks
  efi/libstub/arm64: Force 'hidden' visibility for section markers
  efi/libstub/arm64: Set -fpie when building the EFI stub

Arnd Bergmann (1):
  modules: mark __inittest/__exittest as __maybe_unused

Behan Webster (2):
  kbuild: Add better clang cross build support
  kbuild: use -Oz instead of -Os when using clang

Chengguang Xu (1):
  fs/exofs: fix potential memory leak in mount option parsing

Chris Fries (1):
  kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

Dan Carpenter (1):
  uio: Fix an Oops on load

David Ahern (1):
  ipv6: Fix PMTU updates for 

Linux 3.18.127

2018-11-27 Thread Greg KH
I'm announcing the release of the 3.18.127 kernel.

All users of the 3.18 kernel series must upgrade.

The updated 3.18.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-3.18.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile |2 -
 arch/s390/kernel/vdso32/Makefile |6 ++--
 arch/s390/kernel/vdso64/Makefile |6 ++--
 arch/um/os-Linux/skas/process.c  |5 
 drivers/acpi/acpi_platform.c |1 
 drivers/block/zram/zram_drv.c|   18 --
 drivers/bluetooth/Kconfig|1 
 drivers/clk/samsung/clk-exynos5420.c |1 
 drivers/gpu/drm/i915/i915_gem.c  |2 -
 drivers/hid/uhid.c   |   13 ++
 drivers/media/v4l2-core/v4l2-event.c |   43 +++
 drivers/misc/atmel-ssc.c |2 -
 drivers/uio/uio.c|7 -
 drivers/usb/class/cdc-acm.c  |3 ++
 drivers/usb/core/quirks.c|8 ++
 drivers/usb/misc/appledisplay.c  |1 
 fs/exofs/super.c |5 +++-
 fs/hfs/brec.c|4 +++
 fs/hfsplus/brec.c|4 +++
 fs/reiserfs/xattr.c  |7 +
 include/linux/uaccess.h  |3 ++
 lib/raid6/test/Makefile  |4 +--
 net/core/dev.c   |4 +++
 net/sunrpc/xdr.c |2 -
 24 files changed, 105 insertions(+), 47 deletions(-)

Al Viro (1):
  new helper: uaccess_kernel()

Chengguang Xu (1):
  fs/exofs: fix potential memory leak in mount option parsing

Dan Carpenter (1):
  uio: Fix an Oops on load

Emmanuel Pescosta (1):
  usb: quirks: Add delay-init quirk for Corsair K70 LUX RGB

Eric Biggers (1):
  HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

Eric Dumazet (1):
  net-gro: reset skb->pkt_type in napi_reuse_skb()

Ernesto A. Fernández (2):
  hfs: prevent btree data loss on root split
  hfsplus: prevent btree data loss on root split

Greg Kroah-Hartman (2):
  Revert "Bluetooth: h5: Fix missing dependency on BT_HCIUART_SERDEV"
  Linux 3.18.127

Hans de Goede (1):
  ACPI / platform: Add SMB0001 HID to forbidden_id_list

Jann Horn (1):
  reiserfs: propagate errors from fill_with_dentries() properly

Jeremy Linton (1):
  lib/raid6: Fix arm64 test build

Kai-Heng Feng (1):
  USB: quirks: Add no-lpm quirk for Raydium touchscreens

Maarten Jacobs (1):
  usb: cdc-acm: add entry for Hiro (Conexant) modem

Marek Szyprowski (1):
  clk: samsung: exynos5420: Enable PERIS clocks for suspend

Mattias Jacobsson (1):
  USB: misc: appledisplay: add 20" Apple Cinema Display

Minchan Kim (1):
  zram: close udev startup race condition as default groups

Nathan Chancellor (1):
  misc: atmel-ssc: Fix section annotation on atmel_ssc_get_driver_data

Richard Weinberger (1):
  um: Give start_idle_thread() a return code

Sakari Ailus (1):
  media: v4l: event: Add subscription to list before calling "add" operation

Sasha Levin (1):
  Revert "Revert "drm/i915: Fix mutex->owner inspection race under 
DEBUG_MUTEXES""

Vasily Gorbik (1):
  s390/vdso: add missing FORCE to build targets

YueHaibing (1):
  SUNRPC: drop pointless static qualifier in xdr_get_next_encode_buffer()



signature.asc
Description: PGP signature


Re: Linux 4.4.165

2018-11-27 Thread Greg KH
diff --git a/.gitignore b/.gitignore
index fd3a35592543..34fe1346aa87 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,6 +33,7 @@
 *.lzo
 *.patch
 *.gcno
+*.ll
 modules.builtin
 Module.symvers
 *.dwo
diff --git a/Kbuild b/Kbuild
index f55cefd9bf29..f56ed561a284 100644
--- a/Kbuild
+++ b/Kbuild
@@ -6,31 +6,6 @@
 # 3) Generate asm-offsets.h (may need bounds.h and timeconst.h)
 # 4) Check for missing system calls
 
-# Default sed regexp - multiline due to syntax constraints
-define sed-y
-   "/^->/{s:->#\(.*\):/* \1 */:; \
-   s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \
-   s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \
-   s:->::; p;}"
-endef
-
-# Use filechk to avoid rebuilds when a header changes, but the resulting file
-# does not
-define filechk_offsets
-   (set -e; \
-echo "#ifndef $2"; \
-echo "#define $2"; \
-echo "/*"; \
-echo " * DO NOT MODIFY."; \
-echo " *"; \
-echo " * This file was generated by Kbuild"; \
-echo " */"; \
-echo ""; \
-sed -ne $(sed-y); \
-echo ""; \
-echo "#endif" )
-endef
-
 #
 # 1) Generate bounds.h
 
diff --git a/Makefile b/Makefile
index 9382e7e4e750..441a760dc5a4 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 VERSION = 4
 PATCHLEVEL = 4
-SUBLEVEL = 164
+SUBLEVEL = 165
 EXTRAVERSION =
 NAME = Blurry Fish Butt
 
@@ -303,14 +303,9 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo 
$$BASH; \
 
 HOSTCC   = gcc
 HOSTCXX  = g++
-HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 
-fomit-frame-pointer -std=gnu89
+HOSTCFLAGS   := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 
-fomit-frame-pointer -std=gnu89
 HOSTCXXFLAGS = -O2
 
-ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
-HOSTCFLAGS  += -Wno-unused-value -Wno-unused-parameter \
-   -Wno-missing-field-initializers -fno-delete-null-pointer-checks
-endif
-
 # Decide whether to build built-in, modular, or both.
 # Normally, just do built-in.
 
@@ -612,6 +607,22 @@ endif # $(dot-config)
 # Defaults to vmlinux, but the arch makefile usually adds further targets
 all: vmlinux
 
+ifeq ($(cc-name),clang)
+ifneq ($(CROSS_COMPILE),)
+CLANG_TARGET   := --target=$(notdir $(CROSS_COMPILE:%-=%))
+GCC_TOOLCHAIN_DIR := $(dir $(shell which $(LD)))
+CLANG_PREFIX   := --prefix=$(GCC_TOOLCHAIN_DIR)
+GCC_TOOLCHAIN  := $(realpath $(GCC_TOOLCHAIN_DIR)/..)
+endif
+ifneq ($(GCC_TOOLCHAIN),)
+CLANG_GCC_TC   := --gcc-toolchain=$(GCC_TOOLCHAIN)
+endif
+KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
+KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX)
+KBUILD_CFLAGS += $(call cc-option, -no-integrated-as)
+KBUILD_AFLAGS += $(call cc-option, -no-integrated-as)
+endif
+
 # The arch Makefile can set ARCH_{CPP,A,C}FLAGS to override the default
 # values of the respective KBUILD_* variables
 ARCH_CPPFLAGS :=
@@ -628,7 +639,7 @@ KBUILD_CFLAGS   += $(call cc-disable-warning, 
int-in-bool-context)
 KBUILD_CFLAGS  += $(call cc-disable-warning, attribute-alias)
 
 ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
-KBUILD_CFLAGS  += -Os
+KBUILD_CFLAGS  += $(call cc-option,-Oz,-Os)
 else
 ifdef CONFIG_PROFILE_ALL_BRANCHES
 KBUILD_CFLAGS  += -O2
@@ -699,10 +710,9 @@ KBUILD_CFLAGS += $(stackp-flag)
 
 ifeq ($(cc-name),clang)
 KBUILD_CPPFLAGS += $(call cc-option,-Qunused-arguments,)
-KBUILD_CPPFLAGS += $(call cc-option,-Wno-unknown-warning-option,)
-KBUILD_CFLAGS += $(call cc-disable-warning, unused-variable)
 KBUILD_CFLAGS += $(call cc-disable-warning, format-invalid-specifier)
 KBUILD_CFLAGS += $(call cc-disable-warning, gnu)
+KBUILD_CFLAGS += $(call cc-disable-warning, address-of-packed-member)
 # Quiet clang warning: comparison of unsigned expression < 0 is always false
 KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare)
 # CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
@@ -713,11 +723,11 @@ KBUILD_CFLAGS += $(call cc-option, 
-fcatch-undefined-behavior)
 else
 
 # These warnings generated too much noise in a regular build.
-# Use make W=1 to enable them (see scripts/Makefile.build)
+# Use make W=1 to enable them (see scripts/Makefile.extrawarn)
 KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
-KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
 endif
 
+KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
 ifdef CONFIG_FRAME_POINTER
 KBUILD_CFLAGS  += -fno-omit-frame-pointer -fno-optimize-sibling-calls
 else
@@ -1297,6 +1307,8 @@ help:
@echo  '(default: 
$$(INSTALL_MOD_PATH)/lib/firmware)'
@echo  '  dir/- Build all files in dir and below'
@echo  '  dir/file.[ois]  - Build specified target only'
+   @echo  '  dir/file.ll - Build the LLVM assembly file'
+   @echo  '(requires compiler support for LLVM 
assembly generation)'
@echo  '  

Re: Linux 3.18.127

2018-11-27 Thread Greg KH
diff --git a/Makefile b/Makefile
index 14472990c4bd..7c78eb797de8 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 VERSION = 3
 PATCHLEVEL = 18
-SUBLEVEL = 126
+SUBLEVEL = 127
 EXTRAVERSION =
 NAME = Diseased Newt
 
diff --git a/arch/s390/kernel/vdso32/Makefile b/arch/s390/kernel/vdso32/Makefile
index 8ad2b34ad151..6661bfc2b3b4 100644
--- a/arch/s390/kernel/vdso32/Makefile
+++ b/arch/s390/kernel/vdso32/Makefile
@@ -29,7 +29,7 @@ GCOV_PROFILE := n
 $(obj)/vdso32_wrapper.o : $(obj)/vdso32.so
 
 # link rule for the .so file, .lds has to be first
-$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32)
+$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) FORCE
$(call if_changed,vdso32ld)
 
 # strip rule for the .so file
@@ -38,12 +38,12 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE
$(call if_changed,objcopy)
 
 # assembly rules for the .S files
-$(obj-vdso32): %.o: %.S
+$(obj-vdso32): %.o: %.S FORCE
$(call if_changed_dep,vdso32as)
 
 # actual build commands
 quiet_cmd_vdso32ld = VDSO32L $@
-  cmd_vdso32ld = $(CC) $(c_flags) -Wl,-T $^ -o $@
+  cmd_vdso32ld = $(CC) $(c_flags) -Wl,-T $(filter %.lds %.o,$^) -o $@
 quiet_cmd_vdso32as = VDSO32A $@
   cmd_vdso32as = $(CC) $(a_flags) -c -o $@ $<
 
diff --git a/arch/s390/kernel/vdso64/Makefile b/arch/s390/kernel/vdso64/Makefile
index 2a8ddfd12a5b..5b7712f8eb4f 100644
--- a/arch/s390/kernel/vdso64/Makefile
+++ b/arch/s390/kernel/vdso64/Makefile
@@ -29,7 +29,7 @@ GCOV_PROFILE := n
 $(obj)/vdso64_wrapper.o : $(obj)/vdso64.so
 
 # link rule for the .so file, .lds has to be first
-$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64)
+$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) FORCE
$(call if_changed,vdso64ld)
 
 # strip rule for the .so file
@@ -38,12 +38,12 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE
$(call if_changed,objcopy)
 
 # assembly rules for the .S files
-$(obj-vdso64): %.o: %.S
+$(obj-vdso64): %.o: %.S FORCE
$(call if_changed_dep,vdso64as)
 
 # actual build commands
 quiet_cmd_vdso64ld = VDSO64L $@
-  cmd_vdso64ld = $(CC) $(c_flags) -Wl,-T $^ -o $@
+  cmd_vdso64ld = $(CC) $(c_flags) -Wl,-T $(filter %.lds %.o,$^) -o $@
 quiet_cmd_vdso64as = VDSO64A $@
   cmd_vdso64as = $(CC) $(a_flags) -c -o $@ $<
 
diff --git a/arch/um/os-Linux/skas/process.c b/arch/um/os-Linux/skas/process.c
index 908579f2b0ab..258e741f61a8 100644
--- a/arch/um/os-Linux/skas/process.c
+++ b/arch/um/os-Linux/skas/process.c
@@ -694,6 +694,11 @@ int start_idle_thread(void *stack, jmp_buf *switch_buf)
fatal_sigsegv();
}
longjmp(*switch_buf, 1);
+
+   /* unreachable */
+   printk(UM_KERN_ERR "impossible long jump!");
+   fatal_sigsegv();
+   return 0;
 }
 
 void initial_thread_cb_skas(void (*proc)(void *), void *arg)
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
index ce115ed71a2a..ec60c5a89239 100644
--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c
@@ -29,6 +29,7 @@ static const struct acpi_device_id forbidden_id_list[] = {
{"PNP0200",  0},/* AT DMA Controller */
{"ACPI0009", 0},/* IOxAPIC */
{"ACPI000A", 0},/* IOAPIC */
+   {"SMB0001",  0},/* ACPI SMBUS virtual device */
{"", 0},
 };
 
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 7e94459a489a..5f4e6a3c2dde 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -999,6 +999,11 @@ static struct attribute_group zram_disk_attr_group = {
.attrs = zram_disk_attrs,
 };
 
+static const struct attribute_group *zram_disk_attr_groups[] = {
+   _disk_attr_group,
+   NULL,
+};
+
 static int create_device(struct zram *zram, int device_id)
 {
int ret = -ENOMEM;
@@ -1060,22 +1065,14 @@ static int create_device(struct zram *zram, int 
device_id)
zram->disk->queue->limits.discard_zeroes_data = 0;
queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, zram->disk->queue);
 
+   disk_to_dev(zram->disk)->groups = zram_disk_attr_groups;
add_disk(zram->disk);
 
-   ret = sysfs_create_group(_to_dev(zram->disk)->kobj,
-   _disk_attr_group);
-   if (ret < 0) {
-   pr_warn("Error creating sysfs group");
-   goto out_free_disk;
-   }
strlcpy(zram->compressor, default_compressor, sizeof(zram->compressor));
zram->meta = NULL;
zram->max_comp_streams = 1;
return 0;
 
-out_free_disk:
-   del_gendisk(zram->disk);
-   put_disk(zram->disk);
 out_free_queue:
blk_cleanup_queue(zram->queue);
 out:
@@ -1084,9 +1081,6 @@ out:
 
 static void destroy_device(struct zram *zram)
 {
-   sysfs_remove_group(_to_dev(zram->disk)->kobj,
-   _disk_attr_group);
-
del_gendisk(zram->disk);
put_disk(zram->disk);
 
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index d59123d39e87..4547dc238fc7 

Re: Linux 4.9.141

2018-11-27 Thread Greg KH
diff --git a/Makefile b/Makefile
index a9aed2326233..8eba73521a7f 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 VERSION = 4
 PATCHLEVEL = 9
-SUBLEVEL = 140
+SUBLEVEL = 141
 EXTRAVERSION =
 NAME = Roaring Lionus
 
diff --git a/arch/arm64/include/asm/percpu.h b/arch/arm64/include/asm/percpu.h
index 0d551576eb57..4724b8f0b625 100644
--- a/arch/arm64/include/asm/percpu.h
+++ b/arch/arm64/include/asm/percpu.h
@@ -92,6 +92,7 @@ static inline unsigned long __percpu_##op(void *ptr,  
\
: [val] "Ir" (val));\
break;  \
default:\
+   ret = 0;\
BUILD_BUG();\
}   \
\
@@ -121,6 +122,7 @@ static inline unsigned long __percpu_read(void *ptr, int 
size)
ret = ACCESS_ONCE(*(u64 *)ptr);
break;
default:
+   ret = 0;
BUILD_BUG();
}
 
@@ -190,6 +192,7 @@ static inline unsigned long __percpu_xchg(void *ptr, 
unsigned long val,
: [val] "r" (val));
break;
default:
+   ret = 0;
BUILD_BUG();
}
 
diff --git a/arch/s390/kernel/vdso32/Makefile b/arch/s390/kernel/vdso32/Makefile
index 6cc947896c77..ca7c3c34f94b 100644
--- a/arch/s390/kernel/vdso32/Makefile
+++ b/arch/s390/kernel/vdso32/Makefile
@@ -32,7 +32,7 @@ UBSAN_SANITIZE := n
 $(obj)/vdso32_wrapper.o : $(obj)/vdso32.so
 
 # link rule for the .so file, .lds has to be first
-$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32)
+$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) FORCE
$(call if_changed,vdso32ld)
 
 # strip rule for the .so file
@@ -41,12 +41,12 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE
$(call if_changed,objcopy)
 
 # assembly rules for the .S files
-$(obj-vdso32): %.o: %.S
+$(obj-vdso32): %.o: %.S FORCE
$(call if_changed_dep,vdso32as)
 
 # actual build commands
 quiet_cmd_vdso32ld = VDSO32L $@
-  cmd_vdso32ld = $(CC) $(c_flags) -Wl,-T $^ -o $@
+  cmd_vdso32ld = $(CC) $(c_flags) -Wl,-T $(filter %.lds %.o,$^) -o $@
 quiet_cmd_vdso32as = VDSO32A $@
   cmd_vdso32as = $(CC) $(a_flags) -c -o $@ $<
 
diff --git a/arch/s390/kernel/vdso64/Makefile b/arch/s390/kernel/vdso64/Makefile
index 2d54c18089eb..84af2b6b64c4 100644
--- a/arch/s390/kernel/vdso64/Makefile
+++ b/arch/s390/kernel/vdso64/Makefile
@@ -32,7 +32,7 @@ UBSAN_SANITIZE := n
 $(obj)/vdso64_wrapper.o : $(obj)/vdso64.so
 
 # link rule for the .so file, .lds has to be first
-$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64)
+$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) FORCE
$(call if_changed,vdso64ld)
 
 # strip rule for the .so file
@@ -41,12 +41,12 @@ $(obj)/%.so: $(obj)/%.so.dbg FORCE
$(call if_changed,objcopy)
 
 # assembly rules for the .S files
-$(obj-vdso64): %.o: %.S
+$(obj-vdso64): %.o: %.S FORCE
$(call if_changed_dep,vdso64as)
 
 # actual build commands
 quiet_cmd_vdso64ld = VDSO64L $@
-  cmd_vdso64ld = $(CC) $(c_flags) -Wl,-T $^ -o $@
+  cmd_vdso64ld = $(CC) $(c_flags) -Wl,-T $(filter %.lds %.o,$^) -o $@
 quiet_cmd_vdso64as = VDSO64A $@
   cmd_vdso64as = $(CC) $(a_flags) -c -o $@ $<
 
diff --git a/arch/s390/numa/numa.c b/arch/s390/numa/numa.c
index 0dac2640c3a7..e73a1165d261 100644
--- a/arch/s390/numa/numa.c
+++ b/arch/s390/numa/numa.c
@@ -53,6 +53,7 @@ int __node_distance(int a, int b)
 {
return mode->distance ? mode->distance(a, b) : 0;
 }
+EXPORT_SYMBOL(__node_distance);
 
 int numa_debug_enabled;
 
diff --git a/arch/um/os-Linux/skas/process.c b/arch/um/os-Linux/skas/process.c
index 23025d645160..0a99d4515065 100644
--- a/arch/um/os-Linux/skas/process.c
+++ b/arch/um/os-Linux/skas/process.c
@@ -578,6 +578,11 @@ int start_idle_thread(void *stack, jmp_buf *switch_buf)
fatal_sigsegv();
}
longjmp(*switch_buf, 1);
+
+   /* unreachable */
+   printk(UM_KERN_ERR "impossible long jump!");
+   fatal_sigsegv();
+   return 0;
 }
 
 void initial_thread_cb_skas(void (*proc)(void *), void *arg)
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
index 03250e1f1103..d92eacaef231 100644
--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c
@@ -30,6 +30,7 @@ static const struct acpi_device_id forbidden_id_list[] = {
{"PNP0200",  0},/* AT DMA Controller */
{"ACPI0009", 0},/* IOxAPIC */
{"ACPI000A", 0},/* IOAPIC */
+   {"SMB0001",  0},/* ACPI SMBUS virtual device */
{"", 0},
 };
 
diff --git a/drivers/acpi/acpi_watchdog.c b/drivers/acpi/acpi_watchdog.c
index 

Linux 4.9.141

2018-11-27 Thread Greg KH
I'm announcing the release of the 4.9.141 kernel.

All users of the 4.9 kernel series must upgrade.

The updated 4.9.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.9.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile  |2 
 arch/arm64/include/asm/percpu.h   |3 
 arch/s390/kernel/vdso32/Makefile  |6 -
 arch/s390/kernel/vdso64/Makefile  |6 -
 arch/s390/numa/numa.c |1 
 arch/um/os-Linux/skas/process.c   |5 +
 drivers/acpi/acpi_platform.c  |1 
 drivers/acpi/acpi_watchdog.c  |   77 +++---
 drivers/block/zram/zram_drv.c |   26 +--
 drivers/bluetooth/Kconfig |1 
 drivers/clk/clk-fixed-factor.c|1 
 drivers/clk/clk-fixed-rate.c  |1 
 drivers/clk/samsung/clk-exynos5420.c  |1 
 drivers/gpu/drm/drm_edid.c|3 
 drivers/hid/uhid.c|   13 +++
 drivers/hwmon/ibmpowernv.c|7 --
 drivers/media/v4l2-core/v4l2-event.c  |   43 ++--
 drivers/media/v4l2-core/videobuf2-core.c  |9 --
 drivers/misc/atmel-ssc.c  |2 
 drivers/misc/sgi-gru/grukdump.c   |4 +
 drivers/net/ethernet/qlogic/qed/qed_sp.h  |3 
 drivers/net/ethernet/qlogic/qed/qed_sp_commands.c |   16 
 drivers/net/ethernet/qlogic/qed/qed_spq.c |   57 
 drivers/platform/x86/acerhdf.c|1 
 drivers/platform/x86/intel_telemetry_debugfs.c|8 +-
 drivers/s390/net/qeth_l3_main.c   |8 +-
 drivers/uio/uio.c |7 +-
 drivers/usb/class/cdc-acm.c   |3 
 drivers/usb/core/quirks.c |8 ++
 drivers/usb/misc/appledisplay.c   |1 
 fs/btrfs/disk-io.c|   19 -
 fs/btrfs/extent-tree.c|   63 +++---
 fs/btrfs/ioctl.c  |   11 ++-
 fs/cifs/cifsfs.c  |7 +-
 fs/exofs/super.c  |5 +
 fs/gfs2/rgrp.c|3 
 fs/hfs/brec.c |4 +
 fs/hfsplus/brec.c |4 +
 fs/reiserfs/xattr.c   |7 ++
 include/linux/netfilter/ipset/ip_set_comment.h|4 -
 include/linux/uaccess.h   |3 
 lib/raid6/test/Makefile   |4 -
 net/ceph/messenger.c  |   12 ++-
 net/netfilter/ipset/ip_set_hash_netportnet.c  |8 +-
 net/netfilter/xt_IDLETIMER.c  |   20 +
 net/sunrpc/xdr.c  |2 
 46 files changed, 350 insertions(+), 150 deletions(-)

Al Viro (1):
  new helper: uaccess_kernel()

Alan Tull (1):
  clk: fixed-rate: fix of_node_get-put imbalance

Andreas Gruenbacher (1):
  gfs2: Put bitmap buffers in put_super

Chengguang Xu (1):
  fs/exofs: fix potential memory leak in mount option parsing

Colin Ian King (1):
  cifs: don't dereference smb_file_target before null check

Dan Carpenter (1):
  uio: Fix an Oops on load

Denis Bolotin (2):
  qed: Fix memory/entry leak in qed_init_sp_request()
  qed: Fix blocking/unlimited SPQ entries leak

Emmanuel Pescosta (1):
  usb: quirks: Add delay-init quirk for Corsair K70 LUX RGB

Eric Biggers (1):
  HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

Eric Westbrook (1):
  netfilter: ipset: actually allow allowable CIDR 0 in hash:net,port,net

Ernesto A. Fernández (2):
  hfs: prevent btree data loss on root split
  hfsplus: prevent btree data loss on root split

Geert Uytterhoeven (1):
  hwmon: (ibmpowernv) Remove bogus __init annotations

Greg Kroah-Hartman (2):
  Revert "Bluetooth: h5: Fix missing dependency on BT_HCIUART_SERDEV"
  Linux 4.9.141

Gustavo A. R. Silva (1):
  drivers/misc/sgi-gru: fix Spectre v1 vulnerability

Hans Verkuil (1):
  Revert "media: videobuf2-core: don't call memop 'finish' when queueing"

Hans de Goede (1):
  ACPI / platform: Add SMB0001 HID to forbidden_id_list

Ilya Dryomov (1):
  libceph: fall back to sendmsg for slab pages

Jann Horn (1):
  reiserfs: propagate errors from fill_with_dentries() properly

Jeremy Linton (1):
  lib/raid6: Fix arm64 test build

Jozsef Kadlecsik (1):
  netfilter: ipset: Correct 

Linux 4.19.5

2018-11-27 Thread Greg KH
I'm announcing the release of the 4.19.5 kernel.

All users of the 4.19 kernel series must upgrade.

The updated 4.19.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.19.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/admin-guide/kernel-parameters.txt |8 
 Documentation/x86/x86_64/mm.txt |   10 
 Makefile|2 
 arch/arm/boot/dts/imx53-ppd.dts |2 
 arch/arm/boot/dts/imx6sll.dtsi  |2 
 arch/arm/boot/dts/vf610m4-colibri.dts   |4 
 arch/arm64/boot/dts/renesas/r8a7795.dtsi|2 
 arch/arm64/boot/dts/renesas/r8a77980-condor.dts |   47 +--
 arch/arm64/include/asm/percpu.h |3 
 arch/arm64/kernel/probes/kprobes.c  |   27 +-
 arch/mips/configs/cavium_octeon_defconfig   |1 
 arch/riscv/include/asm/uaccess.h|4 
 arch/s390/boot/compressed/Makefile  |   14 -
 arch/s390/include/asm/mmu_context.h |5 
 arch/s390/include/asm/pgalloc.h |6 
 arch/s390/include/asm/pgtable.h |   18 +
 arch/s390/include/asm/tlb.h |6 
 arch/s390/kernel/perf_cpum_cf.c |2 
 arch/s390/kernel/vdso32/Makefile|6 
 arch/s390/kernel/vdso64/Makefile|6 
 arch/s390/mm/pgalloc.c  |1 
 arch/s390/numa/numa.c   |1 
 arch/um/os-Linux/skas/process.c |5 
 arch/x86/include/asm/page_64_types.h|   12 
 arch/x86/include/asm/pgtable_64_types.h |4 
 arch/x86/kernel/early_printk.c  |   29 +-
 arch/x86/kernel/ldt.c   |   59 ++--
 arch/x86/xen/mmu_pv.c   |6 
 block/bio.c |1 
 drivers/acpi/acpi_platform.c|1 
 drivers/block/brd.c |   16 -
 drivers/clk/clk-fixed-factor.c  |1 
 drivers/clk/clk-fixed-rate.c|1 
 drivers/clk/meson/axg.c |7 
 drivers/clk/meson/gxbb.c|   12 
 drivers/clk/meson/meson8b.c |3 
 drivers/clk/renesas/r9a06g032-clocks.c  |3 
 drivers/clk/samsung/clk-exynos5420.c|1 
 drivers/clk/ti/clk.c|   13 -
 drivers/gnss/serial.c   |3 
 drivers/gnss/sirf.c |3 
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c   |2 
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h   |2 
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c |   45 ---
 drivers/gpu/drm/drm_edid.c  |3 
 drivers/gpu/drm/exynos/exynos5433_drm_decon.c   |9 
 drivers/gpu/drm/exynos/exynos_drm_crtc.c|   11 
 drivers/gpu/drm/exynos/exynos_drm_drv.h |1 
 drivers/gpu/drm/i915/i915_drv.h |2 
 drivers/gpu/drm/i915/i915_gem_gtt.c |   18 -
 drivers/hid/hid-alps.c  |   18 +
 drivers/hid/hid-ids.h   |6 
 drivers/hid/hid-quirks.c|4 
 drivers/hid/i2c-hid/i2c-hid.c   |   19 +
 drivers/hid/uhid.c  |   12 
 drivers/hwmon/ibmpowernv.c  |7 
 drivers/i2c/busses/Kconfig  |2 
 drivers/i2c/busses/i2c-qcom-geni.c  |   15 -
 drivers/media/v4l2-core/v4l2-event.c|   43 +--
 

Re: Linux 4.19.5

2018-11-27 Thread Greg KH
diff --git a/Documentation/admin-guide/kernel-parameters.txt 
b/Documentation/admin-guide/kernel-parameters.txt
index 92eb1f42240d..fa4eec22816d 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -1063,7 +1063,7 @@
earlyprintk=serial[,0x...[,baudrate]]
earlyprintk=ttySn[,baudrate]
earlyprintk=dbgp[debugController#]
-   earlyprintk=pciserial,bus:device.function[,baudrate]
+   
earlyprintk=pciserial[,force],bus:device.function[,baudrate]
earlyprintk=xdbc[xhciController#]
 
earlyprintk is useful when the kernel crashes before
@@ -1095,6 +1095,10 @@
 
The sclp output can only be used on s390.
 
+   The optional "force" to "pciserial" enables use of a
+   PCI device even when its classcode is not of the
+   UART class.
+
edac_report=[HW,EDAC] Control how to report EDAC event
Format: {"on" | "off" | "force"}
on: enable EDAC to report H/W event. May be overridden
@@ -4683,6 +4687,8 @@
prevent spurious wakeup);
n = USB_QUIRK_DELAY_CTRL_MSG (Device needs a
pause after every control message);
+   o = USB_QUIRK_HUB_SLOW_RESET (Hub needs extra
+   delay after resetting its port);
Example: quirks=0781:5580:bk,0a5c:5834:gij
 
usbhid.mousepoll=
diff --git a/Documentation/x86/x86_64/mm.txt b/Documentation/x86/x86_64/mm.txt
index 5432a96d31ff..05ef53d83a41 100644
--- a/Documentation/x86/x86_64/mm.txt
+++ b/Documentation/x86/x86_64/mm.txt
@@ -4,8 +4,9 @@ Virtual memory map with 4 level page tables:
  - 7fff (=47 bits) user space, different per mm
 hole caused by [47:63] sign extension
 8000 - 87ff (=43 bits) guard hole, reserved for 
hypervisor
-8800 - c7ff (=64 TB) direct mapping of all phys. memory
-c800 - c8ff (=40 bits) hole
+8800 - 887f (=39 bits) LDT remap for PTI
+8880 - c87f (=64 TB) direct mapping of all phys. memory
+c880 - c8ff (=39 bits) hole
 c900 - e8ff (=45 bits) vmalloc/ioremap space
 e900 - e9ff (=40 bits) hole
 ea00 - eaff (=40 bits) virtual memory map (1TB)
@@ -30,8 +31,9 @@ Virtual memory map with 5 level page tables:
  - 00ff (=56 bits) user space, different per mm
 hole caused by [56:63] sign extension
 ff00 - ff0f (=52 bits) guard hole, reserved for 
hypervisor
-ff10 - ff8f (=55 bits) direct mapping of all phys. 
memory
-ff90 - ff9f (=52 bits) LDT remap for PTI
+ff10 - ff10 (=48 bits) LDT remap for PTI
+ff11 - ff90 (=55 bits) direct mapping of all phys. 
memory
+ff91 - ff9f (=3840 TB) hole
 ffa0 - ffd1 (=54 bits) vmalloc/ioremap space (12800 TB)
 ffd2 - ffd3 (=49 bits) hole
 ffd4 - ffd5 (=49 bits) virtual memory map (512TB)
diff --git a/Makefile b/Makefile
index 1f3c7adeea63..a07830185bdf 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 VERSION = 4
 PATCHLEVEL = 19
-SUBLEVEL = 4
+SUBLEVEL = 5
 EXTRAVERSION =
 NAME = "People's Front"
 
diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
index cdb90bee7b4a..f202396e3f2a 100644
--- a/arch/arm/boot/dts/imx53-ppd.dts
+++ b/arch/arm/boot/dts/imx53-ppd.dts
@@ -55,7 +55,7 @@
};
 
chosen {
-   stdout-path = ":115200n8";
+   stdout-path = "serial0:115200n8";
};
 
memory@7000 {
diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
index 000e6136a9d6..3e6ffaf5f104 100644
--- a/arch/arm/boot/dts/imx6sll.dtsi
+++ b/arch/arm/boot/dts/imx6sll.dtsi
@@ -709,7 +709,7 @@
i2c1: i2c@21a {
#address-cells = <1>;
#size-cells = <0>;
-   compatible = "fs,imx6sll-i2c", "fsl,imx21-i2c";
+   compatible = "fsl,imx6sll-i2c", "fsl,imx21-i2c";
reg = <0x021a 0x4000>;
interrupts = ;
clocks = < IMX6SLL_CLK_I2C1>;
diff --git a/arch/arm/boot/dts/vf610m4-colibri.dts 
b/arch/arm/boot/dts/vf610m4-colibri.dts
index 41ec66a96990..ca6249558760 100644
--- 

Re: Linux 4.14.84

2018-11-27 Thread Greg KH
diff --git a/Documentation/admin-guide/kernel-parameters.txt 
b/Documentation/admin-guide/kernel-parameters.txt
index 9841bad6f271..99a08722124d 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -1011,7 +1011,7 @@
earlyprintk=serial[,0x...[,baudrate]]
earlyprintk=ttySn[,baudrate]
earlyprintk=dbgp[debugController#]
-   earlyprintk=pciserial,bus:device.function[,baudrate]
+   
earlyprintk=pciserial[,force],bus:device.function[,baudrate]
earlyprintk=xdbc[xhciController#]
 
earlyprintk is useful when the kernel crashes before
@@ -1043,6 +1043,10 @@
 
The sclp output can only be used on s390.
 
+   The optional "force" to "pciserial" enables use of a
+   PCI device even when its classcode is not of the
+   UART class.
+
edac_report=[HW,EDAC] Control how to report EDAC event
Format: {"on" | "off" | "force"}
on: enable EDAC to report H/W event. May be overridden
diff --git a/Documentation/x86/x86_64/mm.txt b/Documentation/x86/x86_64/mm.txt
index ea91cb61a602..43f066cde67d 100644
--- a/Documentation/x86/x86_64/mm.txt
+++ b/Documentation/x86/x86_64/mm.txt
@@ -4,8 +4,9 @@ Virtual memory map with 4 level page tables:
  - 7fff (=47 bits) user space, different per mm
 hole caused by [47:63] sign extension
 8000 - 87ff (=43 bits) guard hole, reserved for 
hypervisor
-8800 - c7ff (=64 TB) direct mapping of all phys. memory
-c800 - c8ff (=40 bits) hole
+8800 - 887f (=39 bits) LDT remap for PTI
+8880 - c87f (=64 TB) direct mapping of all phys. memory
+c880 - c8ff (=39 bits) hole
 c900 - e8ff (=45 bits) vmalloc/ioremap space
 e900 - e9ff (=40 bits) hole
 ea00 - eaff (=40 bits) virtual memory map (1TB)
@@ -30,8 +31,9 @@ Virtual memory map with 5 level page tables:
  - 00ff (=56 bits) user space, different per mm
 hole caused by [56:63] sign extension
 ff00 - ff0f (=52 bits) guard hole, reserved for 
hypervisor
-ff10 - ff8f (=55 bits) direct mapping of all phys. 
memory
-ff90 - ff9f (=52 bits) LDT remap for PTI
+ff10 - ff10 (=48 bits) LDT remap for PTI
+ff11 - ff90 (=55 bits) direct mapping of all phys. 
memory
+ff91 - ff9f (=3840 TB) hole
 ffa0 - ffd1 (=54 bits) vmalloc/ioremap space (12800 TB)
 ffd2 - ffd3 (=49 bits) hole
 ffd4 - ffd5 (=49 bits) virtual memory map (512TB)
diff --git a/Makefile b/Makefile
index 0f42814095a4..874d72a3e6a7 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 VERSION = 4
 PATCHLEVEL = 14
-SUBLEVEL = 83
+SUBLEVEL = 84
 EXTRAVERSION =
 NAME = Petit Gorille
 
diff --git a/arch/arm64/include/asm/percpu.h b/arch/arm64/include/asm/percpu.h
index 43393208229e..d79eaa816f29 100644
--- a/arch/arm64/include/asm/percpu.h
+++ b/arch/arm64/include/asm/percpu.h
@@ -93,6 +93,7 @@ static inline unsigned long __percpu_##op(void *ptr,  
\
: [val] "Ir" (val));\
break;  \
default:\
+   ret = 0;\
BUILD_BUG();\
}   \
\
@@ -122,6 +123,7 @@ static inline unsigned long __percpu_read(void *ptr, int 
size)
ret = READ_ONCE(*(u64 *)ptr);
break;
default:
+   ret = 0;
BUILD_BUG();
}
 
@@ -191,6 +193,7 @@ static inline unsigned long __percpu_xchg(void *ptr, 
unsigned long val,
: [val] "r" (val));
break;
default:
+   ret = 0;
BUILD_BUG();
}
 
diff --git a/arch/arm64/kernel/probes/kprobes.c 
b/arch/arm64/kernel/probes/kprobes.c
index 22a5921562c7..0417c929d21a 100644
--- a/arch/arm64/kernel/probes/kprobes.c
+++ b/arch/arm64/kernel/probes/kprobes.c
@@ -23,7 +23,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -42,10 +44,21 @@ DEFINE_PER_CPU(struct kprobe_ctlblk, kprobe_ctlblk);
 static void 

Linux 4.14.84

2018-11-27 Thread Greg KH
I'm announcing the release of the 4.14.84 kernel.

All users of the 4.14 kernel series must upgrade.

The updated 4.14.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.14.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Documentation/admin-guide/kernel-parameters.txt   |6 -
 Documentation/x86/x86_64/mm.txt   |   10 +
 Makefile  |2 
 arch/arm64/include/asm/percpu.h   |3 
 arch/arm64/kernel/probes/kprobes.c|   27 +++--
 arch/mips/configs/cavium_octeon_defconfig |1 
 arch/s390/kernel/perf_cpum_cf.c   |2 
 arch/s390/kernel/vdso32/Makefile  |6 -
 arch/s390/kernel/vdso64/Makefile  |6 -
 arch/s390/numa/numa.c |1 
 arch/um/os-Linux/skas/process.c   |5 
 arch/x86/include/asm/page_64_types.h  |   12 +-
 arch/x86/include/asm/pgtable_64_types.h   |7 -
 arch/x86/kernel/early_printk.c|   29 +++--
 arch/x86/kernel/ldt.c |   49 ++---
 arch/x86/xen/mmu_pv.c |6 -
 drivers/acpi/acpi_platform.c  |1 
 drivers/acpi/acpi_watchdog.c  |   72 -
 drivers/block/zram/zram_drv.c |   26 +---
 drivers/clk/clk-fixed-factor.c|1 
 drivers/clk/clk-fixed-rate.c  |1 
 drivers/clk/samsung/clk-exynos5420.c  |1 
 drivers/gpu/drm/drm_edid.c|3 
 drivers/gpu/drm/exynos/exynos5433_drm_decon.c |9 -
 drivers/gpu/drm/exynos/exynos_drm_crtc.c  |   11 --
 drivers/gpu/drm/exynos/exynos_drm_drv.h   |1 
 drivers/hid/uhid.c|   12 ++
 drivers/hwmon/ibmpowernv.c|7 -
 drivers/media/v4l2-core/v4l2-event.c  |   43 
 drivers/misc/atmel-ssc.c  |2 
 drivers/misc/sgi-gru/grukdump.c   |4 
 drivers/net/ethernet/intel/i40e/i40e_main.c   |2 
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c|4 
 drivers/net/ethernet/qlogic/qed/qed_sp.h  |3 
 drivers/net/ethernet/qlogic/qed/qed_sp_commands.c |   16 ++-
 drivers/net/ethernet/qlogic/qed/qed_spq.c |   69 ++--
 drivers/net/ethernet/stmicro/stmmac/common.h  |3 
 drivers/net/ethernet/stmicro/stmmac/descs_com.h   |2 
 drivers/net/ethernet/stmicro/stmmac/enh_desc.c|2 
 drivers/net/ethernet/stmicro/stmmac/ring_mode.c   |2 
 drivers/platform/x86/acerhdf.c|1 
 drivers/platform/x86/intel_telemetry_debugfs.c|8 +
 drivers/s390/net/qeth_l3_main.c   |8 -
 drivers/uio/uio.c |7 -
 drivers/usb/class/cdc-acm.c   |3 
 drivers/usb/core/quirks.c |8 +
 drivers/usb/misc/appledisplay.c   |1 
 fs/cifs/cifsfs.c  |7 -
 fs/cifs/smb2ops.c |   11 +-
 fs/exofs/super.c  |5 
 fs/hfs/brec.c |4 
 fs/hfsplus/brec.c |4 
 fs/reiserfs/xattr.c   |7 +
 include/linux/netfilter/ipset/ip_set.h|2 
 include/linux/netfilter/ipset/ip_set_comment.h|4 
 kernel/sched/core.c   |5 
 lib/raid6/test/Makefile   |4 
 net/ceph/messenger.c  |   12 +-
 net/netfilter/ipset/ip_set_core.c |   23 ++--
 net/netfilter/ipset/ip_set_hash_netportnet.c  |8 -
 net/netfilter/ipset/ip_set_list_set.c |   17 ++-
 net/netfilter/xt_IDLETIMER.c  |   20 +++
 net/sunrpc/xdr.c  |2 
 security/apparmor/lib.c   |6 -
 tools/perf/jvmti/jvmti_agent.c|   49 +++--
 tools/perf/tests/code-reading.c   |1 
 tools/perf/util/env.c |   32 ++
 tools/perf/util/env.h |4 
 tools/perf/util/machine.c |  117 +-
 tools/perf/util/machine.h |6 +
 tools/perf/util/symbol-elf.c  |   12 ++
 tools/perf/util/symbol.c  |   12 +-
 72 files changed, 624 insertions(+), 255 deletions(-)

Aaro Koskinen (1):
  MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver

Adrian Hunter (5):
  perf machine: Add 

Re: [PATCH RESEND] tty/sysrq: Do not call sync directly from sysrq_do_reset()

2018-11-27 Thread Greg KH
On Tue, Nov 27, 2018 at 09:57:23AM +1300, Mark Tomlinson wrote:
> sysrq_do_reset() is called in softirq context, so it cannot call
> sync() directly. Instead, call orderly_reboot(), which creates a work
> item to run /sbin/reboot, or do emergency_sync and restart if the
> command fails.
> 
> Signed-off-by: Mark Tomlinson 
> ---
>  drivers/tty/sysrq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index ad1ee5d01b53..f2ca32c1ad7c 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -660,8 +660,7 @@ static void sysrq_do_reset(struct timer_list *t)
>  
>   state->reset_requested = true;
>  
> - ksys_sync();
> - kernel_restart(NULL);
> + orderly_reboot();

Is this something new?  Why haven't we had reports of this failing in
the past?  Or has something changed recently to cause this to now be
needed?

thanks,

greg k-h


Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-27 Thread Greg KH
On Mon, Nov 26, 2018 at 08:36:33PM +0100, Stefan Wahren wrote:
> > Nicolas Saenz Julienne  hat am 20. November 2018 um 
> > 15:53 geschrieben:
> > 
> > 
> > Hi All,
> > 
> > This series was written in parallel with reading and understanding the
> > vchiq code. So excuse me for the lack of logic in the sequence of
> > patches.
> > 
> > The main focus was to delete as much code as possible, I've counted
> > around 550 lines, which is not bad. Apart from that there are some
> > patches enforcing proper kernel APIs usage.
> > 
> > The only patch that really changes code is the
> > vchiq_ioc_copy_element_data() rewrite.
> > 
> > The last commit updates the TODO list with some of my observations, I
> > realise some of the might be a little opinionated. If anything it's
> > going to force a discussion on the topic, which is nice.
> > 
> > It was developed on top of the latest linux-next, and was tested on a
> > RPIv3B+ with audio, video and running vchiq_test.
> > 
> > Regards,
> > Nicolas
> > 
> > RFC -> PATCH, as per Stefan's comments:
> >   - Remove semaphore initialization from remove_event_create()
> > (commit 9)
> >   - Join all three semaphore to completion patches (commit 11)
> >   - Update probe/init commit message (commit 14)
> >   - Update TODO commit message and clean up (commit 16)
> >   - Fix spelling on some of the patches
> > 
> 
> The whole series is
> 
> Acked-by: Stefan Wahren 
> 
> Unfortunately patch 05 might not apply.

I fixed it up.

thanks,

greg k-h


Re: [PATCH] misc/pvpanic: resolve compile errors for arch=um

2018-11-26 Thread Greg KH
On Tue, Nov 27, 2018 at 03:47:28PM +0800, peng.h...@zte.com.cn wrote:
> >> >On Fri, Nov 16, 2018 at 07:13:26PM +0800, Peng Hao wrote:
> >> >> Resolve compile error for arch=um
> >> >> pvpanic.c:(.text+0xb6): undefined reference to `devm_ioremap_resource'
> >> >>
> >> >> Signed-off-by: Peng Hao 
> >> >> ---
> >> >>  drivers/misc/Kconfig | 2 +-
> >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> >What commit is this fixing?  What broke and when did it break?
> >> kbuildtestrobot reports this compile  error for arch=um.
> >> here is content:
> >> " head:   24438e46268c721e14c5c888386af85c9e1c5db1
> >> commit: 77703e0b0326a1fb06b5cb5b468a633472c5a8e9 [10/26] misc/pvpanic : 
> >> break dependency on ACPI
> >
> >Ah, it is breaking because of your patch, not a patch in the kernel
> >today.  So please integrate this patch into your latest patch series
> >when you redo your patches.
> >
> The series of patches has merged into "char-misc-next"
> (https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/log/?h=char-misc-next),
> Do I need to re-send the entire series of patches ? 

Ah, I didn't realize that.  Ok, let me go dig this back up and add it
to my tree, sorry for the noise...

greg k-h


Re: [PATCH anybus v4 1/7] fieldbus_dev: add Fieldbus Device subsystem.

2018-11-26 Thread Greg KH
On Wed, Nov 21, 2018 at 10:07:03AM -0500, thesve...@gmail.com wrote:
> +static struct attribute *fieldbus_attrs[] = {
> + _attr_enabled.attr,
> + _attr_card_name.attr,
> + _attr_fieldbus_id.attr,
> + _attr_read_area_size.attr,
> + _attr_write_area_size.attr,
> + _attr_online.attr,
> + _attr_fieldbus_type.attr,
> + NULL,
> +};
> +
> +static umode_t fieldbus_is_visible(struct kobject *kobj, struct attribute 
> *attr,
> + int n)
> +{
> + struct device *dev = container_of(kobj, struct device, kobj);
> + struct fieldbus_dev *fb = dev_get_drvdata(dev);
> + umode_t mode = attr->mode;
> +
> + if (attr == _attr_enabled.attr) {
> + mode = 0;
> + if (fb->enable_get)
> + mode |= 0444;
> + if (fb->simple_enable_set)
> + mode |= 0200;
> + }
> +
> + return mode;
> +}
> +
> +static const struct attribute_group fieldbus_group = {
> + .attrs = fieldbus_attrs,
> + .is_visible = fieldbus_is_visible,
> +};
> +__ATTRIBUTE_GROUPS(fieldbus);

Why not just use ATTRIBUTE_GROUPS()?

> +static int __fieldbus_dev_register(struct fieldbus_dev *fb)
> +{
> + dev_t devno;
> + int err;
> +
> + if (!fb)
> + return -EINVAL;
> + if (!fb->read_area || !fb->write_area || !fb->fieldbus_id_get)
> + return -EINVAL;
> + fb->id = ida_simple_get(_ida, 0, MAX_FIELDBUSES, GFP_KERNEL);
> + if (fb->id < 0)
> + return fb->id;
> + devno = MKDEV(MAJOR(fieldbus_devt), fb->id);
> + init_waitqueue_head(>dc_wq);
> + cdev_init(>cdev, _fops);
> + err = cdev_add(>cdev, devno, 1);
> + if (err) {
> + pr_err("fieldbus_dev%d unable to add device %d:%d\n",
> + fb->id, MAJOR(fieldbus_devt), fb->id);
> + goto err_cdev;
> + }

Why do you have a static cdev?

> + fb->dev = device_create(_class, fb->parent, devno, fb,
> + "fieldbus_dev%d", fb->id);
> + if (IS_ERR(fb->dev)) {
> + err = PTR_ERR(fb->dev);
> + goto err_dev_create;
> + }
> + fb->online_sd = sysfs_get_dirent(fb->dev->kobj.sd, "online");

Ick, what?  Why?  Why are you messing around with a raw sysfs attribute?

Also, you are creating sysfs files and you are not documenting any of
them in Documentation/ABI/ which is not allowed.  Please add that to
this patch for the next round.

thanks,

greg k-h


Re: [PATCH anybus v4 1/7] fieldbus_dev: add Fieldbus Device subsystem.

2018-11-26 Thread Greg KH
On Wed, Nov 21, 2018 at 10:07:03AM -0500, thesve...@gmail.com wrote:
> Fieldbus device (client) adapters allow data exchange with a PLC aka.
> "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.)
> 
> They are typically used when a Linux device wants to expose itself
> as an actuator, motor, console light, switch, etc. over the fieldbus.
> 
> This framework is designed to provide a generic interface to Fieldbus
> Devices from both the Linux Kernel and the userspace.
> 
> Signed-off-by: Sven Van Asbroeck 

Your "From:" line does not match this address or name at all, which
means no one can apply this :(

Please fix for your next round of patches.

thanks,

greg k-h


Re: [PATCH anybus v4 1/7] fieldbus_dev: add Fieldbus Device subsystem.

2018-11-26 Thread Greg KH
On Wed, Nov 21, 2018 at 10:07:03AM -0500, thesve...@gmail.com wrote:
> Fieldbus device (client) adapters allow data exchange with a PLC aka.
> "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.)
> 
> They are typically used when a Linux device wants to expose itself
> as an actuator, motor, console light, switch, etc. over the fieldbus.
> 
> This framework is designed to provide a generic interface to Fieldbus
> Devices from both the Linux Kernel and the userspace.
> 
> Signed-off-by: Sven Van Asbroeck 

License nit:

> --- /dev/null
> +++ b/drivers/fieldbus/dev_core.c
> @@ -0,0 +1,355 @@
> +// SPDX-License-Identifier: GPL-2.0

That's great, but then you write:

> +MODULE_LICENSE("GPL");

Which means "GPLv2+".  So this MODULE_LICENSE() should be "GPL v2",
right?

thanks,

greg k-h


Re: [PATCH] misc/pvpanic: resolve compile errors for arch=um

2018-11-26 Thread Greg KH
On Tue, Nov 27, 2018 at 08:27:03AM +0800, peng.h...@zte.com.cn wrote:
> >On Fri, Nov 16, 2018 at 07:13:26PM +0800, Peng Hao wrote:
> >> Resolve compile error for arch=um
> >> pvpanic.c:(.text+0xb6): undefined reference to `devm_ioremap_resource'
> >>
> >> Signed-off-by: Peng Hao 
> >> ---
> >>  drivers/misc/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> >What commit is this fixing?  What broke and when did it break?
> kbuildtestrobot reports this compile  error for arch=um.
> here is content:
> " head:   24438e46268c721e14c5c888386af85c9e1c5db1
> commit: 77703e0b0326a1fb06b5cb5b468a633472c5a8e9 [10/26] misc/pvpanic : break 
> dependency on ACPI

Ah, it is breaking because of your patch, not a patch in the kernel
today.  So please integrate this patch into your latest patch series
when you redo your patches.

thanks,

greg k-h


Re: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 08:56:50PM +, Michael Kelley wrote:
> From: Greg KH   Monday, November 26, 2018 11:57 AM
> 
> > > > You created "null" hooks that do nothing, for no one in this patch
> > > > series, why?
> > > >
> > >
> > > hv_enable_vmbus_irq() and hv_disable_vmbus_irq() have non-null
> > > implementations in the ARM64 code in patch 2 of this series.  The
> > > implementations are in the new file arch/arm64/hyperv/mshyperv.c.
> > > Or am I misunderstanding your point?
> > 
> > So you use a hook in an earlier patch and then add it in a later one?
> > 
> > Shouldn't you do it the other way around?  As it is, the earlier patch
> > should not work properly, right?
> 
> The earlier patch implements the hook on the ARM64 side but it is
> unused -- it's not called.  The later patch then calls it.  Wouldn't the
> other way around be backwards?

Ah, it wasn't obvious that the previous patch added it at all, why not
just make that addition part of this patch?

> The general approach is for patches 1 and 2 of the series to provide
> all the new code under arch/arm64 to enable Hyper-V.  But the code
> won't get called (or even built) with just these two patches because
> CONFIG_HYPERV can't be selected.  Patch 3 is separate because it
> applies to architecture independent code and arch/x86 code -- I thought
> there might be value in keeping the ARM64 and x86 patches distinct. 
> Patch 4 applies to architecture independent code, and enables the
> ARM64 code in patches 1 and 2 to be compiled and run when
> CONFIG_HYPERV is selected.
> 
> If combining some of the patches in the series is a better approach, I'm
> good with that.

Ok, that makes more sense, if it is easier to get the ARM people to
review this, that's fine.  Doesn't seem like anyone did that yet :(

sorry for the noise,

greg k-h


Re: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 07:47:41PM +, Michael Kelley wrote:
> From: Greg KH   Monday, November 26, 2018 11:21 AM
> 
> > > diff --git a/arch/x86/include/asm/mshyperv.h 
> > > b/arch/x86/include/asm/mshyperv.h
> > > index 0d6271cce198..8d97bd3a13a6 100644
> > > --- a/arch/x86/include/asm/mshyperv.h
> > > +++ b/arch/x86/include/asm/mshyperv.h
> > > @@ -109,6 +109,10 @@ void hyperv_vector_handler(struct pt_regs *regs);
> > >  void hv_setup_vmbus_irq(void (*handler)(void));
> > >  void hv_remove_vmbus_irq(void);
> > >
> > > +/* On x86/x64, there isn't a real IRQ to be enabled/disable */
> > > +static inline void hv_enable_vmbus_irq(void) {}
> > > +static inline void hv_disable_vmbus_irq(void) {}
> > > +
> > >  void hv_setup_kexec_handler(void (*handler)(void));
> > >  void hv_remove_kexec_handler(void);
> > >  void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));
> > > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> > > index 166c2501de17..d0bb09a4bd73 100644
> > > --- a/drivers/hv/hv.c
> > > +++ b/drivers/hv/hv.c
> > > @@ -307,6 +307,7 @@ int hv_synic_init(unsigned int cpu)
> > >   hv_set_siefp(siefp.as_uint64);
> > >
> > >   /* Setup the shared SINT. */
> > > + hv_enable_vmbus_irq();
> > >   hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
> > >
> > >   shared_sint.vector = HYPERVISOR_CALLBACK_VECTOR;
> > > @@ -434,6 +435,7 @@ int hv_synic_cleanup(unsigned int cpu)
> > >   /* Disable the global synic bit */
> > >   sctrl.enable = 0;
> > >   hv_set_synic_state(sctrl.as_uint64);
> > > + hv_disable_vmbus_irq();
> > >
> > >   return 0;
> > >  }
> > > --
> > > 2.19.1
> > 
> > You created "null" hooks that do nothing, for no one in this patch
> > series, why?
> > 
> 
> hv_enable_vmbus_irq() and hv_disable_vmbus_irq() have non-null
> implementations in the ARM64 code in patch 2 of this series.  The
> implementations are in the new file arch/arm64/hyperv/mshyperv.c.
> Or am I misunderstanding your point?

So you use a hook in an earlier patch and then add it in a later one?

Shouldn't you do it the other way around?  As it is, the earlier patch
should not work properly, right?

thanks,

greg k-h


Re: [PATCH] misc/pvpanic: resolve compile errors for arch=um

2018-11-26 Thread Greg KH
On Fri, Nov 16, 2018 at 07:13:26PM +0800, Peng Hao wrote:
> Resolve compile error for arch=um
> pvpanic.c:(.text+0xb6): undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Peng Hao 
> ---
>  drivers/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What commit is this fixing?  What broke and when did it break?

thanks,

greg k-h


Re: [PATCH 2/2] Drivers: hv: vmbus: offload the handling of channels to two workqueues

2018-11-26 Thread Greg KH
On Mon, Nov 26, 2018 at 02:29:57AM +, k...@linuxonhyperv.com wrote:
> From: Dexuan Cui 
> 
> vmbus_process_offer() mustn't call channel->sc_creation_callback()
> directly for sub-channels, because sc_creation_callback() ->
> vmbus_open() may never get the host's response to the
> OPEN_CHANNEL message (the host may rescind a channel at any time,
> e.g. in the case of hot removing a NIC), and vmbus_onoffer_rescind()
> may not wake up the vmbus_open() as it's blocked due to a non-zero
> vmbus_connection.offer_in_progress, and finally we have a deadlock.
> 
> The above is also true for primary channels, if the related device
> drivers use sync probing mode by default.
> 
> And, usually the handling of primary channels and sub-channels can
> depend on each other, so we should offload them to different
> workqueues to avoid possible deadlock, e.g. in sync-probing mode,
> NIC1's netvsc_subchan_work() can race with NIC2's netvsc_probe() ->
> rtnl_lock(), and causes deadlock: the former gets the rtnl_lock
> and waits for all the sub-channels to appear, but the latter
> can't get the rtnl_lock and this blocks the handling of sub-channels.
> 
> The patch can fix the multiple-NIC deadlock described above for
> v3.x kernels (e.g. RHEL 7.x) which don't support async-probing
> of devices, and v4.4, v4.9, v4.14 and v4.18 which support async-probing
> but don't enable async-probing for Hyper-V drivers (yet).
> 
> The patch can also fix the hang issue in sub-channel's handling described
> above for all versions of kernels, including v4.19 and v4.20-rc3.
> 
> So the patch should be applied to all the existing kernels.
> 
> Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Cc: sta...@vger.kernel.org
> Cc: Stephen Hemminger 
> Cc: K. Y. Srinivasan 
> Cc: Haiyang Zhang 
> Signed-off-by: Dexuan Cui 
> Signed-off-by: K. Y. Srinivasan 
> ---
>  drivers/hv/channel_mgmt.c | 188 +-
>  drivers/hv/connection.c   |  24 -
>  drivers/hv/hyperv_vmbus.h |   7 ++
>  include/linux/hyperv.h|   7 ++
>  4 files changed, 161 insertions(+), 65 deletions(-)

As Sasha pointed out, this patch does not even apply :(




Re: [PATCH 3/4] Drivers: hv: vmbus: Add hooks for per-CPU IRQ

2018-11-26 Thread Greg KH
On Thu, Nov 22, 2018 at 03:10:58AM +, k...@linuxonhyperv.com wrote:
> From: Michael Kelley 
> 
> Add hooks to enable/disable a per-CPU IRQ for VMbus. These hooks
> are in the architecture independent setup and shutdown paths for
> Hyper-V, and are needed by Linux guests on Hyper-V on ARM64.  The
> x86/x64 implementation is null because VMbus interrupts on x86/x64
> don't use an IRQ.
> 
> Signed-off-by: Michael Kelley 
> Signed-off-by: K. Y. Srinivasan 
> ---
>  arch/x86/include/asm/mshyperv.h | 4 
>  drivers/hv/hv.c | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> index 0d6271cce198..8d97bd3a13a6 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -109,6 +109,10 @@ void hyperv_vector_handler(struct pt_regs *regs);
>  void hv_setup_vmbus_irq(void (*handler)(void));
>  void hv_remove_vmbus_irq(void);
>  
> +/* On x86/x64, there isn't a real IRQ to be enabled/disable */
> +static inline void hv_enable_vmbus_irq(void) {}
> +static inline void hv_disable_vmbus_irq(void) {}
> +
>  void hv_setup_kexec_handler(void (*handler)(void));
>  void hv_remove_kexec_handler(void);
>  void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index 166c2501de17..d0bb09a4bd73 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -307,6 +307,7 @@ int hv_synic_init(unsigned int cpu)
>   hv_set_siefp(siefp.as_uint64);
>  
>   /* Setup the shared SINT. */
> + hv_enable_vmbus_irq();
>   hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
>  
>   shared_sint.vector = HYPERVISOR_CALLBACK_VECTOR;
> @@ -434,6 +435,7 @@ int hv_synic_cleanup(unsigned int cpu)
>   /* Disable the global synic bit */
>   sctrl.enable = 0;
>   hv_set_synic_state(sctrl.as_uint64);
> + hv_disable_vmbus_irq();
>  
>   return 0;
>  }
> -- 
> 2.19.1

You created "null" hooks that do nothing, for no one in this patch
series, why?

Add them when they are needed not now.  If I saw this code in the tree,
I would just go delete it as it is because it is not used at all.

thanks,

greg k-h


Re: [PATCH 2/4] arm64: hyperv: Add support for Hyper-V as a hypervisor

2018-11-26 Thread Greg KH
On Thu, Nov 22, 2018 at 03:10:57AM +, k...@linuxonhyperv.com wrote:
> --- /dev/null
> +++ b/arch/arm64/hyperv/hv_hvc.S
> @@ -0,0 +1,54 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Using SPDX is good, but:

> +
> +/*
> + * Microsoft Hyper-V hypervisor invocation routines
> + *
> + * Copyright (C) 2018, Microsoft, Inc.
> + *
> + * Author : Michael Kelley 
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published
> + * by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
> + * NON INFRINGEMENT.  See the GNU General Public License for more
> + * details.

No need for these two paragraphs at all.  If you add them now, someone
will just come along later and rip them out.  Please don't include them
in the first place.

Not to mention the first paragraph doesn't make sense, think about
"which" version 2 the FSF published (hint, there was 5 or 7 or so...)
That's why we have one in the kernel tree for everyone to rely on.

thanks,

greg k-h


Re: [PATCH 1/4] arm64: hyperv: Add core Hyper-V include files

2018-11-26 Thread Greg KH
On Thu, Nov 22, 2018 at 03:10:56AM +, k...@linuxonhyperv.com wrote:
> --- /dev/null
> +++ b/arch/arm64/include/asm/hyperv-tlfs.h
> @@ -0,0 +1,338 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +/*
> + * This file contains definitions from the Hyper-V Hypervisor Top-Level
> + * Functional Specification (TLFS):
> + * 
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fvirtualization%2Fhyper-v-on-windows%2Freference%2Ftlfsdata=02%7C01%7Ckys%40microsoft.com%7Cc831a45fd63e4a4b083908d641216aa8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636768009113747528sdata=jRSrs9ZWXdmeS7LQUEpoSyUfBS7a5KLYy%2FolFdE2tI0%3Dreserved=0

"interesting" url :(

Care to use a real one?

thanks,

greg k-h


Re: [PATCH] Fonts: New Terminus large console font

2018-11-26 Thread Greg KH


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Mon, Nov 26, 2018 at 03:09:31AM -0500, Amanoel Dawod wrote:
> Changing the name did not break anything. Pretty much I dumped the original
> .psf file to .inc
> format with new naming using psftools extracting the bitmap data. Then
> manually editing it
> removing useless header, leaving bitmaps data alone.

I did not refer to any name, just the #define that you changed.

> Do you mean adding it at end of lists with other fonts? if that's what you
> mean,
> no real reason, but just wanted it to be after sun12x22 always as in
> Kconfig.

You can put it wherever you want in the Kconfig file (but you should put
it at the end, as it is a new font.)  I mean the #defines, you need to
just add it at the end please, do not change any existing #defines.


> Please let me know if that must be changed.
> Now regarding "From:" line, please accept my apology as it my first time
> dealing
> with submissions and git send-mail. Should I re-submit the patch with
> modified subject line?

Not subject line, From: line from your email client.  And you need to
change the patch anyway before it could be added, so you have to resend
it :)

thanks,

greg k-h


Re: [PATCH] Fonts: New Terminus large console font

2018-11-25 Thread Greg KH
On Sun, Nov 25, 2018 at 10:47:34PM -0500, nimrud wrote:
> This patch adds an option to compile-in a high resolution and large
> Terminus (ter16x32) bitmap console font for use with HiDPI and Retina screens.
> 
> The font was convereted from standard Terminus ter-i32b.psf (size 16x32)
> with the help of psftools and minor hand editing deleting useless characters.
> 
> This patch is non-intrusive, no options are enabled by default so most
> users won't notice a thing.
> 
> I am placing my changes under the GPL 2.0 just as source Terminus font.
> 
> Signed-off-by: Amanoel Dawod 

Also, your "From:" line on your email does not match this name, so that
needs to be fixed before we could take the patch :(

thanks,

greg k-h


Re: [PATCH] Fonts: New Terminus large console font

2018-11-25 Thread Greg KH
On Sun, Nov 25, 2018 at 10:47:34PM -0500, nimrud wrote:
> This patch adds an option to compile-in a high resolution and large
> Terminus (ter16x32) bitmap console font for use with HiDPI and Retina screens.
> 
> The font was convereted from standard Terminus ter-i32b.psf (size 16x32)
> with the help of psftools and minor hand editing deleting useless characters.
> 
> This patch is non-intrusive, no options are enabled by default so most
> users won't notice a thing.
> 
> I am placing my changes under the GPL 2.0 just as source Terminus font.
> 
> Signed-off-by: Amanoel Dawod 
> ---
>  include/linux/font.h  |8 +-
>  lib/fonts/Kconfig |   10 +
>  lib/fonts/Makefile|1 +
>  lib/fonts/font_ter16x32.c | 2072 +
>  lib/fonts/fonts.c |4 +
>  5 files changed, 2092 insertions(+), 3 deletions(-)
>  create mode 100644 lib/fonts/font_ter16x32.c
> 
> diff --git a/include/linux/font.h b/include/linux/font.h
> index d6821769dd1e..8ab5192e8a13 100644
> --- a/include/linux/font.h
> +++ b/include/linux/font.h
> @@ -29,9 +29,10 @@ struct font_desc {
>  #define  FONT10x18_IDX   5
>  #define SUN8x16_IDX  6
>  #define SUN12x22_IDX 7
> -#define ACORN8x8_IDX 8
> -#define  MINI4x6_IDX 9
> -#define FONT6x10_IDX 10
> +#define TER16x32_IDX 8
> +#define ACORN8x8_IDX 9
> +#define  MINI4x6_IDX 10
> +#define FONT6x10_IDX 11

By changing the font names, did you just break anything?  Why not just
add your new one at the end of the list?

thanks,

greg k-h


Linux 4.9.140

2018-11-23 Thread Greg KH
Sorry for the quick follow-on release, but this resolves two reported
issues that should have gotten into the previous release.

I'm announcing the release of the 4.9.140 kernel.

All users of the 4.9 kernel series must upgrade.

The updated 4.9.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git 
linux-4.9.y
and can be browsed at the normal kernel.org git web browser:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h



 Makefile   |2 -
 arch/x86/kernel/cpu/bugs.c |   57 -
 kernel/cpu.c   |   11 
 net/ipv6/route.c   |   11 ++--
 4 files changed, 16 insertions(+), 65 deletions(-)

Greg Kroah-Hartman (3):
  Revert "x86/speculation: Enable cross-hyperthread spectre v2 STIBP 
mitigation"
  Revert "ipv6: set rt6i_protocol properly in the route when it is 
installed"
  Linux 4.9.140



signature.asc
Description: PGP signature


  1   2   3   4   5   6   7   8   9   10   >