Re: [PATCH 4.9 000/101] 4.9.144-stable review

2018-12-07 Thread Guenter Roeck
On Thu, Dec 06, 2018 at 03:37:59PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.144 release. > There are 101 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 00/41] 4.19.8-stable review

2018-12-07 Thread Guenter Roeck
On Thu, Dec 06, 2018 at 03:38:40PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.8 release. > There are 41 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/55] 4.14.87-stable review

2018-12-07 Thread Guenter Roeck
On Thu, Dec 06, 2018 at 03:38:34PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.87 release. > There are 55 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH v2 3/3] watchdog/hpwdt: Update driver version.

2018-12-06 Thread Guenter Roeck
On Wed, Dec 05, 2018 at 05:42:23PM -0700, Jerry Hoemann wrote: > Bump version number to reflect recent minor changes. > > Signed-off-by: Jerry Hoemann Reviewed-by: Guenter Roeck > --- > drivers/watchdog/hpwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > &

Re: [PATCH v2 2/3] watchdog/hpwdt: Do not claim unsupported hardware

2018-12-06 Thread Guenter Roeck
On Wed, Dec 05, 2018 at 05:42:22PM -0700, Jerry Hoemann wrote: > Do not claim when SSID 0x0289 as the watchdog features > are not enabled/validated by the firmware. > > Signed-off-by: Jerry Hoemann Reviewed-by: Guenter Roeck > --- > drivers/watchdog/hpwdt.c | 1 + &g

Re: [PATCH v2 1/3] watchdog/hpwdt: Exclude via blacklist

2018-12-06 Thread Guenter Roeck
On Wed, Dec 05, 2018 at 05:42:21PM -0700, Jerry Hoemann wrote: > Instead of having explicit if statments excluding devices, > use a pci_device_id table of devices to blacklist. > > Signed-off-by: Jerry Hoemann Reviewed-by: Guenter Roeck > --- > drivers/watchdog/hpwdt.c | 12

Re: [PATCH 1/1] watchdog/hpwdt: Do not claim unsupported hardware

2018-12-04 Thread Guenter Roeck
On 12/4/18 6:22 PM, Jerry Hoemann wrote: Do not claim when SSID 0x0289 as the watchdog features are not enabled/validated by the firmware. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/watchdog/hpwdt.c

Re: [PATCH 4.19 000/139] 4.19.7-stable review

2018-12-04 Thread Guenter Roeck
On 12/4/18 2:48 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.7 release. There are 139 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 4.14 000/146] 4.14.86-stable review

2018-12-04 Thread Guenter Roeck
On 12/4/18 2:48 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.86 release. There are 146 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.9 00/50] 4.9.143-stable review

2018-12-04 Thread Guenter Roeck
On 12/4/18 2:49 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.143 release. There are 50 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 2/2] watchdog: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Guenter Roeck
On 12/1/18 6:51 AM, Yangtao Li wrote: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li Reviewed-by: Guenter Roeck --- drivers/watchdog/ie6xx_wdt.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/watchdog

Re: [PATCH 1/2] watchdog: bcm281xx: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-04 Thread Guenter Roeck
On 12/1/18 6:51 AM, Yangtao Li wrote: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li Reviewed-by: Guenter Roeck --- drivers/watchdog/bcm_kona_wdt.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/watchdog

Re: [PATCH v3 2/8] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-12-04 Thread Guenter Roeck
On Tue, Dec 4, 2018 at 3:52 AM Enric Balletbo i Serra wrote: > > Hi Lee, > > On 4/12/18 10:21, Lee Jones wrote: > > On Mon, 03 Dec 2018, Enric Balletbo i Serra wrote: > >> On 3/12/18 11:36, Lee Jones wrote: > >>> On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote: > >>> > The entire way how

Re: [PATCH] Revert "mfd: cros_ec: Use devm_kzalloc for private data"

2018-12-04 Thread Guenter Roeck
t; __arm64_sys_delete_module+0x16c/0x1f8 > el0_svc_common+0x84/0xd8 > el0_svc_handler+0x2c/0x80 > el0_svc+0x8/0xc > ---[ end trace a57c4625f3c60ae8 ]--- > > Cc: sta...@vger.kernel.org > Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data"

Re: [PATCH] watchdog: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-01 Thread Guenter Roeck
On 12/1/18 2:14 AM, Yangtao Li wrote: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li One patch per file, please. Guenter --- drivers/watchdog/bcm_kona_wdt.c | 16 +++- drivers/watchdog/ie6xx_wdt.c| 16 +++- 2 files changed,

Re: [PATCH 4.19 000/110] 4.19.6-stable review

2018-11-30 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 03:11:31PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.6 release. > There are 110 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 000/100] 4.14.85-stable review

2018-11-30 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 03:11:30PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.85 release. > There are 100 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/92] 4.9.142-stable review

2018-11-30 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 03:11:29PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.142 release. > There are 92 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 00/86] 4.4.166-stable review

2018-11-30 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 03:11:25PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.166 release. > There are 86 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 3.18 00/83] 3.18.128-stable review

2018-11-30 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 03:11:18PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.128 release. > There are 83 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH v3 2/5] bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD.

2018-11-30 Thread Guenter Roeck
ed-off-by: Eric Anholt For watchdog: Reviewed-by: Guenter Roeck > --- > > v3: don't reset bcm2835_power_off_wdt on remove, drop pm driver's > empty remove, sort includes, add a "static". > > arch/arm/mach-bcm/Kconfig | 1 + > drivers/mfd/Makefil

Re: [PATCH 4.14 000/100] 4.14.85-stable review

2018-11-30 Thread Guenter Roeck
On 11/29/18 6:11 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.85 release. There are 100 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH] watchdog: asm9260_wdt: make array mode_name static, shrinks object size

2018-11-29 Thread Guenter Roeck
; > Signed-off-by: Colin Ian King Reviewed-by: Guenter Roeck > --- > drivers/watchdog/asm9260_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/asm9260_wdt.c b/drivers/watchdog/asm9260_wdt.c > index 2cf56b459d84..9768e44ffeb8 1006

Re: [PATCH v3 3/8] mfd / platform: cros_ec: move vbc attributes to its own driver.

2018-11-29 Thread Guenter Roeck
vbc attributes are attached to the cros_class. > > The patch also adds the sysfs documentation. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck > --- > > Changes in v3: > - Fixed build error as reported by the kbuild test robot. > > Change

Re: [PATCH v3 2/8] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-11-29 Thread Guenter Roeck
n > the path, the lightbar attributes are attached to the cros_class. > > The patch also adds the sysfs documentation. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck > --- > > Changes in v3: > - Removed unneded check for ec_dev. > > Changes in v2: >

Re: [PATCH v3 1/8] mfd / platform: cros_ec: use devm_mfd_add_devices.

2018-11-29 Thread Guenter Roeck
i Serra Reviewed-by: Guenter Roeck > --- > > Changes in v3: > - Removed cros_ec_remove from include file. > > Changes in v2: > - Use devm only for the cros-ec core. > > drivers/mfd/cros_ec.c | 14 +++--- > drivers/mfd/cros_ec_dev.c | 1

Re: [PATCH v3 8/8] mfd: cros_ec: add a dev_release empty method.

2018-11-29 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 2:11 PM Enric Balletbo i Serra wrote: > > Hi, > > On 29/11/18 8:55, Greg Kroah-Hartman wrote: > > On Wed, Nov 28, 2018 at 05:17:22PM -0800, Guenter Roeck wrote: > >> Hi Greg, > >> > >> On Tue, Nov 27, 2018 at 9:52 AM Greg Kroah

Re: [PATCH v3 8/8] mfd: cros_ec: add a dev_release empty method.

2018-11-28 Thread Guenter Roeck
Hi Greg, On Tue, Nov 27, 2018 at 9:52 AM Greg Kroah-Hartman wrote: > > On Tue, Nov 27, 2018 at 09:29:38AM -0800, Guenter Roeck wrote: > > Hi Enric, > > > > On Tue, Nov 27, 2018 at 4:19 AM Enric Balletbo i Serra > > wrote: > > > > > > Devices are

Re: ext4 file system corruption with v4.19.3 / v4.19.4

2018-11-27 Thread Guenter Roeck
On Tue, Nov 27, 2018 at 07:55:01PM +0100, Rainer Fiebig wrote: > Am Dienstag, 27. November 2018, 15:48:19 schrieb Marek Habersack: > > On 27/11/2018 15:32, Guenter Roeck wrote: > > Hi, > > > > You might try to see if you have CONFIG_SCSI_MQ_DEFAULT=yes in your

Re: ext4 file system corruption with v4.19.3 / v4.19.4

2018-11-27 Thread Guenter Roeck
On Tue, Nov 27, 2018 at 03:48:19PM +0100, Marek Habersack wrote: > On 27/11/2018 15:32, Guenter Roeck wrote: > Hi, > > You might try to see if you have CONFIG_SCSI_MQ_DEFAULT=yes in your kernel > config. Starting with 4.19.1 it somehow Yes, it is enabled in my configuration

Re: [PATCH v3 8/8] mfd: cros_ec: add a dev_release empty method.

2018-11-27 Thread Guenter Roeck
Hi Enric, On Tue, Nov 27, 2018 at 4:19 AM Enric Balletbo i Serra wrote: > > Devices are required to provide a release method. This patch fixes the > following WARN(): > > [ 47.218707] [ cut here ] > [ 47.223901] Device 'cros_ec' does not have a release() function, it

ext4 file system corruption with v4.19.3 / v4.19.4

2018-11-27 Thread Guenter Roeck
[trying again, this time with correct kernel.org address] Hi, I have seen the following and similar problems several times, with both v4.19.3 and v4.19.4: Nov 23 04:32:25 mars kernel: [112668.673671] EXT4-fs error (device sdb1): ext4_iget:4831: inode #12602889: comm git: bad extra_isize 33661

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Guenter Roeck
On 11/26/18 11:34 PM, Heiko Carstens wrote: On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: Thanks for testing. Unfortunately Heiko reported

Re: [PATCH 4.14 00/62] 4.14.84-stable review

2018-11-26 Thread Guenter Roeck
On 11/26/18 2:50 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.84 release. There are 62 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.4 00/70] 4.4.165-stable review

2018-11-26 Thread Guenter Roeck
On 11/26/18 2:50 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.165 release. There are 70 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.19 000/118] 4.19.5-stable review

2018-11-26 Thread Guenter Roeck
On Mon, Nov 26, 2018 at 11:49:54AM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.5 release. > There are 118 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/46] 4.9.141-stable review

2018-11-26 Thread Guenter Roeck
On Mon, Nov 26, 2018 at 11:50:49AM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.141 release. > There are 46 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 3.18 00/24] 3.18.127-stable review

2018-11-26 Thread Guenter Roeck
On Mon, Nov 26, 2018 at 11:50:54AM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.127 release. > There are 24 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH v2 1/8] mfd / platform: cros_ec: use devm_mfd_add_devices.

2018-11-26 Thread Guenter Roeck
Hi Enric, On Mon, Nov 26, 2018 at 9:52 AM Enric Balletbo i Serra wrote: > > Use devm_mfd_add_devices() for adding cros-ec core MFD child devices. This > reduces the need of remove callback from platform/chrome for removing the > MFD child devices. > > Signed-off-by: Enric Balletbo i Serra > ---

Re: [PATCH] exec: separate MM_ANONPAGES and RLIMIT_STACK accounting

2018-11-26 Thread Guenter Roeck
Hi Oleg, On Mon, Nov 26, 2018 at 01:23:07PM +0100, Oleg Nesterov wrote: > Hi Guenter, > > On 11/23, Guenter Roeck wrote: > > > > On Mon, Nov 12, 2018 at 05:09:10PM +0100, Oleg Nesterov wrote: > > > get_arg_page() checks bprm->rlim_stack.rlim_cur and re-calculate

Re: [PATCH] x86/TSC: Use RDTSCP

2018-11-23 Thread Guenter Roeck
On 11/23/18 12:44 PM, Borislav Petkov wrote: On Fri, Nov 23, 2018 at 12:03:07PM -0800, Guenter Roeck wrote: [0.762832] EIP: read_tsc+0x4/0x10 [0.762832] Code: 00 01 00 eb 89 90 55 89 e5 5d c3 90 90 90 90 90 90 90 90 90 90 90 55 a1 44 5a 8b c5 89 e5 5d c3 8d b6 00 00 00 00 55 89 e5 57

Re: [PATCH] x86/TSC: Use RDTSCP

2018-11-23 Thread Guenter Roeck
Hi, On Mon, Nov 19, 2018 at 07:45:56PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Currently, the kernel uses > > [LM]FENCE; RDTSC > > in the timekeeping code, to guarantee monotonicity of time where the > *FENCE is selected based on vendor. > > Replace that sequence with

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-23 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 12:50:50PM -0800, Guenter Roeck wrote: > On Mon, Nov 19, 2018 at 10:44:30AM -0800, Florian Fainelli wrote: > > On 11/15/18 5:16 PM, Guenter Roeck wrote: > > > On Thu, Nov 15, 2018 at 11:48:20AM -0800, Florian Fainelli wrote: > > >> >

Re: [PATCH] exec: separate MM_ANONPAGES and RLIMIT_STACK accounting

2018-11-23 Thread Guenter Roeck
Hi, On Mon, Nov 12, 2018 at 05:09:10PM +0100, Oleg Nesterov wrote: > get_arg_page() checks bprm->rlim_stack.rlim_cur and re-calculates the > "extra" size for argv/envp pointers every time, this is a bit ugly and > even not strictly correct: acct_arg_size() must not account this size. > > Remove

Re: [PATCH 4.19 00/42] 4.19.4-stable review

2018-11-23 Thread Guenter Roeck
On 11/22/18 11:45 PM, Greg Kroah-Hartman wrote: On Thu, Nov 22, 2018 at 02:30:58PM -0800, Guenter Roeck wrote: On 11/22/18 2:01 PM, Thomas Voegtle wrote: On Thu, 22 Nov 2018, Thomas Voegtle wrote: Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):   CALL    scripts/checksyscalls.sh

Re: [PATCH 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-11-23 Thread Guenter Roeck
On 11/23/18 3:52 AM, Enric Balletbo i Serra wrote: Hi Guenter, On 22/11/18 18:41, Guenter Roeck wrote: Hi Enric, On Thu, Nov 22, 2018 at 12:33:51PM +0100, Enric Balletbo i Serra wrote: The entire way how cros sysfs attibutes are created is broken. cros_ec_lightbar should be its own driver

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-23 Thread Guenter Roeck
On 11/23/18 3:10 AM, Enric Balletbo i Serra wrote: Hi Guenter, On 22/11/18 20:25, Guenter Roeck wrote: On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: Due to the way attribute groups visibility work, the function cros_ec_lightbar_attrs_are_visible is called multiple

Re: [PATCH 4.19 00/42] 4.19.4-stable review

2018-11-22 Thread Guenter Roeck
On 11/22/18 2:01 PM, Thomas Voegtle wrote: On Thu, 22 Nov 2018, Thomas Voegtle wrote: Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):   CALL    scripts/checksyscalls.sh   DESCEND  objtool   CHK include/generated/compile.h   CC [M]  drivers/gpu/drm/i915/i915_gem_gtt.o

Re: [PATCH v2 2/5] bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD.

2018-11-22 Thread Guenter Roeck
On 11/20/18 1:36 PM, Eric Anholt wrote: The PM block that the wdt driver was binding to actually has multiple features we want to expose (power domains, reset, watchdog). Move the DT attachment to a MFD driver and make WDT probe against MFD. Signed-off-by: Eric Anholt ---

Re: [PATCH 4.9 00/59] 4.9.139-stable review

2018-11-22 Thread Guenter Roeck
On 11/22/18 10:07 AM, Murilo Fossa Vicentini wrote: On 22/11/18 14:33, Guenter Roeck wrote: drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_xmit': drivers/net/ethernet/ibm/ibmvnic.c:789:40: error: implicit declaration of function 'skb_vlan_tag_present' Caused by 5f51bb855fa1

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-22 Thread Guenter Roeck
On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: > Due to the way attribute groups visibility work, the function > cros_ec_lightbar_attrs_are_visible is called multiple times, once per > attribute, and each of these calls makes an EC transaction. For what is > worth the EC

Re: [PATCH 6/7] mfd / platform: cros_ec: instantiate only if th EC has a VBC NVRAM.

2018-11-22 Thread Guenter Roeck
On Thu, Nov 22, 2018 at 12:33:55PM +0100, Enric Balletbo i Serra wrote: > The cros-ec-vbc driver is DT-only and there is a DT property that > indicates if the EC has the VCB NVRAM, in such case instantiate the > driver but don't instantiate on the other cases. > > To do this move the check code

Re: [PATCH 5/7] mfd / platform: cros_ec: move device sysfs attributes to its own driver.

2018-11-22 Thread Guenter Roeck
On Thu, Nov 22, 2018 at 12:33:54PM +0100, Enric Balletbo i Serra wrote: > The entire way how cros debugfs attibutes are created is broken. > cros_ec_sysfs should be its own driver and its attributes should be > associated with the sysfs driver not the mfd driver. > > The patch also adds the sysfs

Re: [PATCH 4/7] mfd / platform: cros_ec: move debugfs attributes to its own driver.

2018-11-22 Thread Guenter Roeck
On Thu, Nov 22, 2018 at 12:33:53PM +0100, Enric Balletbo i Serra wrote: > The entire way how cros debugfs attibutes are created is broken. > cros_ec_debugfs should be its own driver and its attributes should be > associated with a debugfs driver not the mfd driver. > > Signed-off-by: Enric

Re: [PATCH 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver.

2018-11-22 Thread Guenter Roeck
Hi Enric, On Thu, Nov 22, 2018 at 12:33:51PM +0100, Enric Balletbo i Serra wrote: > The entire way how cros sysfs attibutes are created is broken. > cros_ec_lightbar should be its own driver and its attributes should be > associated with a lightbar driver not the mfd driver. In order to retain >

Re: [PATCH 4.19 00/42] 4.19.4-stable review

2018-11-22 Thread Guenter Roeck
On 11/21/18 11:05 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.4 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.14 00/21] 4.14.83-stable review

2018-11-22 Thread Guenter Roeck
On 11/21/18 11:06 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.83 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.9 00/59] 4.9.139-stable review

2018-11-22 Thread Guenter Roeck
On 11/21/18 11:06 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.139 release. There are 59 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH v2 2/2] power: supply: cros: allow to set input voltage and current limit.

2018-11-22 Thread Guenter Roeck
any negative value will remove that limit. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck > --- > > Changes in v2: > - Fix the upper limit that can be set. > - Remove unnecessary else. > > drivers/power/supply/cros_usbpd-charger.c | 116 +++

Re: [PATCH 3.18 00/90] 3.18.126-stable review

2018-11-21 Thread Guenter Roeck
On Wed, Nov 21, 2018 at 11:37:33AM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 20, 2018 at 12:38:29PM -0800, Guenter Roeck wrote: > > On Mon, Nov 19, 2018 at 05:28:42PM +0100, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for th

Re: [PATCH 2/2] power: supply: cros: allow to set input voltage and current limit.

2018-11-21 Thread Guenter Roeck
Trying again, this time (hopefully if gmail lets me) in plaintext mode. Sorry for the noise. On Wed, Nov 21, 2018 at 7:34 AM Enric Balletbo i Serra wrote: > > This patch allows reading and writing the input voltage and current > limit through the POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT and >

Re: [PATCH 1/2] power: supply: add input voltage limit property.

2018-11-21 Thread Guenter Roeck
-level knowledge or user input. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck > > --- > > Documentation/power/power_supply_class.txt | 2 ++ > drivers/power/supply/power_supply_sysfs.c | 1 + > include/linux/power_supply.h |

Re: [PATCH 4.19 000/205] 4.19.3-stable review

2018-11-20 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 05:25:07PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.3 release. > There are 205 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.18 000/171] 4.18.20-stable review

2018-11-20 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 05:26:36PM +0100, Greg Kroah-Hartman wrote: > -- > NOTE, this is going to be the last 4.18.y release. After this one it is > end-of-life, please move to 4.19.y at this point in time. > -- > > This is the start of the stable review cycle for

Re: [PATCH 4.9 00/83] 4.9.138-stable review

2018-11-20 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 05:28:26PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.138 release. > There are 83 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 000/124] 4.14.82-stable review

2018-11-20 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 05:27:34PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.82 release. > There are 124 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 000/160] 4.4.164-stable review

2018-11-20 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 05:27:19PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.164 release. > There are 160 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 3.18 00/90] 3.18.126-stable review

2018-11-20 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 05:28:42PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.126 release. > There are 90 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 1/8] watchdog: bcm2835: Move the driver to the soc/ directory.

2018-11-20 Thread Guenter Roeck
On Tue, Nov 20, 2018 at 09:19:53AM -0800, Eric Anholt wrote: > The binding for the bcm2835 "wdt" actually covers a large range of the > PM block's register space. The WDT is not a separate HW block from > the rest of power domain management, so move the driver to the soc/ > directory in

Re: [PATCH 3.18 00/90] 3.18.126-stable review

2018-11-20 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 05:28:42PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.126 release. > There are 90 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH v2] watchdog: cpwd: add of_node_put()

2018-11-20 Thread Guenter Roeck
On 11/20/18 6:54 AM, Yangtao Li wrote: use of_node_put() to release the refcount. Signed-off-by: Yangtao Li Reviewed-by: Guenter Roeck --- Changes in v2: -do that right after its last use to also cover error handling. --- drivers/watchdog/cpwd.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCH] watchdog: cpwd: add of_node_put()

2018-11-20 Thread Guenter Roeck
On 11/20/18 5:23 AM, Yangtao Li wrote: use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- drivers/watchdog/cpwd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c index aee0b25cf10d..d3a81642ada5 100644 ---

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-19 Thread Guenter Roeck
On Mon, Nov 19, 2018 at 10:44:30AM -0800, Florian Fainelli wrote: > On 11/15/18 5:16 PM, Guenter Roeck wrote: > > On Thu, Nov 15, 2018 at 11:48:20AM -0800, Florian Fainelli wrote: > >> > >> OK, would you mind testing this below? It seems to me that 8250_of.c is > >

Re: [PATCH 2/2] hwmon: (ntc_thermistor): add support for B57891S0103 from Epcos

2018-11-19 Thread Guenter Roeck
On Sat, Nov 17, 2018 at 12:13:00PM +, Peter Rosin wrote: > More of the same... > > Signed-off-by: Peter Rosin > --- > drivers/hwmon/Kconfig| 3 +- > drivers/hwmon/ntc_thermistor.c | 57 > +++- >

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 11:48:20AM -0800, Florian Fainelli wrote: > > OK, would you mind testing this below? It seems to me that 8250_of.c is > incompatible with arch/powerpc/kernel/legacy_serial.c and that is what > is causing the issue here. > > diff --git a/drivers/tty/serial/8250/Kconfig >

Re: [PATCH] watchdog: core: suppress "watchdog did not stop" message

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 11:44:26PM +, Tao Ren wrote: > Currently "watchdog did not stop!" message is printed when the watchdog > timer is not stopped at close. For example, people may see the message > when rebooting the system, or the message will be logged to console > periodically if

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 03:12:48PM -0700, Jens Axboe wrote: > On 11/15/18 3:06 PM, Guenter Roeck wrote: > > On Thu, Nov 15, 2018 at 12:43:40PM -0700, Jens Axboe wrote: > >> On 11/15/18 12:40 PM, Jens Axboe wrote: > >>> On 11/15/18 12:38 PM, Guenter Roeck wrote: > &

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 12:43:40PM -0700, Jens Axboe wrote: > On 11/15/18 12:40 PM, Jens Axboe wrote: > > On 11/15/18 12:38 PM, Guenter Roeck wrote: > >> On Thu, Nov 15, 2018 at 12:29:04PM -0700, Jens Axboe wrote: > >>> On 11/15/18 12:11 PM, Guenter Roeck wrote: >

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 12:29:04PM -0700, Jens Axboe wrote: > On 11/15/18 12:11 PM, Guenter Roeck wrote: > > On Wed, Nov 14, 2018 at 10:12:44AM -0700, Jens Axboe wrote: > >> > >> I think the below patch should fix it. > >> > > > > I spoke too early

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 11:11:26AM -0800, Guenter Roeck wrote: > On Wed, Nov 14, 2018 at 10:12:44AM -0700, Jens Axboe wrote: > > > > I think the below patch should fix it. > > > > I spoke too early. sparc64, next-20181115: > > [ 14.204370] nvme

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-15 Thread Guenter Roeck
On Wed, Nov 14, 2018 at 10:12:44AM -0700, Jens Axboe wrote: > > I think the below patch should fix it. > I spoke too early. sparc64, next-20181115: [ 14.204370] nvme nvme0: pci function :02:00.0 [ 14.249956] nvme nvme0: Removing after probe failure status: -5 [ 14.263496]

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-15 Thread Guenter Roeck
Hi Jens, On Wed, Nov 14, 2018 at 10:12:44AM -0700, Jens Axboe wrote: > On 11/13/18 9:52 PM, Guenter Roeck wrote: > > On Tue, Nov 13, 2018 at 05:51:08PM -0700, Jens Axboe wrote: > >> On 11/13/18 5:41 PM, Guenter Roeck wrote: > >>> Hi, > >>> > >&

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 09:19:14AM -0800, Florian Fainelli wrote: > > > On 11/14/2018 9:38 PM, Guenter Roeck wrote: > > On Wed, Nov 14, 2018 at 07:56:47PM -0800, Florian Fainelli wrote: > >> > >> > >> On November 14, 2018 5:11:25 PM PST, Guenter Roec

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-14 Thread Guenter Roeck
On Wed, Nov 14, 2018 at 07:56:47PM -0800, Florian Fainelli wrote: > > > On November 14, 2018 5:11:25 PM PST, Guenter Roeck wrote: > >On Thu, Nov 01, 2018 at 11:26:06AM -0700, Florian Fainelli wrote: > >> It is way too easy to miss enabling SERIAL_OF_PLATFORM

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-14 Thread Guenter Roeck
On Wed, Nov 14, 2018 at 07:56:47PM -0800, Florian Fainelli wrote: > > > On November 14, 2018 5:11:25 PM PST, Guenter Roeck wrote: > >On Thu, Nov 01, 2018 at 11:26:06AM -0700, Florian Fainelli wrote: > >> It is way too easy to miss enabling SERIAL_OF_PLATFORM

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-14 Thread Guenter Roeck
On Thu, Nov 01, 2018 at 11:26:06AM -0700, Florian Fainelli wrote: > It is way too easy to miss enabling SERIAL_OF_PLATFORM which would > result in the inability for the kernel to have a valid console device, > which can be seen with: > > Warning: unable to open an initial console. > > and then:

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-13 Thread Guenter Roeck
On Tue, Nov 13, 2018 at 05:51:08PM -0700, Jens Axboe wrote: > On 11/13/18 5:41 PM, Guenter Roeck wrote: > > Hi, > > > > On Wed, Oct 31, 2018 at 08:36:31AM -0600, Jens Axboe wrote: > >> NVMe does round-robin between queues by default, which means that > >

Re: [PATCH] nvme: utilize two queue maps, one for reads and one for writes

2018-11-13 Thread Guenter Roeck
Hi, On Wed, Oct 31, 2018 at 08:36:31AM -0600, Jens Axboe wrote: > NVMe does round-robin between queues by default, which means that > sharing a queue map for both reads and writes can be problematic > in terms of read servicing. It's much easier to flood the queue > with writes and reduce the

Re: [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells

2018-11-13 Thread Guenter Roeck
On Mon, Nov 12, 2018 at 05:37:46PM -0600, Rob Herring wrote: > On Wed, 7 Nov 2018 16:47:08 +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > The tmp108 does have an alert output that can be used as interrupt source > > and can of course also be used as part of a thermal sensor setup

Re: [PATCH 3.16 000/366] 3.16.61-rc1 review

2018-11-12 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 07:49:04PM +, Ben Hutchings wrote: > This is the start of the stable review cycle for the 3.16.61 release. > There are 366 patches in this series, which will be posted as responses > to this one. If anyone has any issues with these being applied, please > let me know.

Re: [PATCH 4.19 000/361] 4.19.2-stable review

2018-11-12 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 02:15:47PM -0800, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.2 release. > There are 361 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.18 000/350] 4.18.19-stable review

2018-11-12 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 02:17:44PM -0800, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.19 release. > There are 350 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 000/222] 4.14.81-stable review

2018-11-12 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 02:21:37PM -0800, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.81 release. > There are 222 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 000/141] 4.9.137-stable review

2018-11-12 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 02:24:19PM -0800, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.137 release. > There are 141 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 3.16 000/410] 3.16.57-rc1 review

2018-11-12 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 07:20:37PM +, Ben Hutchings wrote: > On Sun, 2018-11-11 at 17:48 +, Ben Hutchings wrote: > > On Sun, Nov 11, 2018 at 08:23:43AM -0800, Guenter Roeck wrote: > [...] > > > I re-enabled it, but now it fails. Let me know if you want to try to f

Re: [PATCH 3.16 000/410] 3.16.57-rc1 review

2018-11-11 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 12:09:03AM +, Ben Hutchings wrote: > On Sat, 2018-06-16 at 22:18 +0100, Ben Hutchings wrote: > > On Fri, 2018-06-08 at 07:14 -0700, Guenter Roeck wrote: > > > On Thu, Jun 07, 2018 at 03:05:20PM +0100, Ben Hutchings wrote: > > > > This is

Re: [PATCH 3.16 000/410] 3.16.57-rc1 review

2018-11-10 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 12:09:03AM +, Ben Hutchings wrote: > On Sat, 2018-06-16 at 22:18 +0100, Ben Hutchings wrote: > > On Fri, 2018-06-08 at 07:14 -0700, Guenter Roeck wrote: > > > On Thu, Jun 07, 2018 at 03:05:20PM +0100, Ben Hutchings wrote: > > > > This is

Re: [PATCH 4.4 000/114] 4.4.163-stable review

2018-11-09 Thread Guenter Roeck
On Thu, Nov 08, 2018 at 01:50:15PM -0800, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.163 release. > There are 114 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-09 Thread Guenter Roeck
ume this is an older version of git > and just use the old git-diff-index method. > > Cc: Genki Sky > Cc: Christian Kujau > Cc: Guenter Roeck > Signed-off-by: Brian Norris Working for me with git v2.7.4. Tested-by: Guenter Roeck > --- > On Fri, Nov 09, 2018 at 11:55

Re: [PATCH 4.18 00/34] 4.18.18-stable review

2018-11-09 Thread Guenter Roeck
On Thu, Nov 08, 2018 at 01:52:29PM -0800, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.18 release. > There are 34 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

  1   2   3   4   5   6   7   8   9   10   >