Re: [PATCH v2 7/7] kunit, slub: add test_kfree_rcu() and test_leak_destroy()

Hi, On Wed, Aug 07, 2024 at 12:31:20PM +0200, Vlastimil Babka wrote: > Add a test that will create cache, allocate one object, kfree_rcu() it > and attempt to destroy it. As long as the usage of kvfree_rcu_barrier() > in kmem_cache_destroy() works correctly, there should be no warnings in > dmesg

Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN

bad magic bug. > > Fix the issue by excluding MT_FLAGS_LOCK_EXTERN from the maple tree > initialization flags. Note that we don't use empty flags to make it > further similar to the usage of mm maple tree, and to be prepared for > possible future changes, as suggested by Lia

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

On 9/4/24 12:26, Liam R. Howlett wrote: * Guenter Roeck [240904 00:27]: On 9/3/24 20:36, Liam R. Howlett wrote: * Guenter Roeck [240903 22:38]: On 9/3/24 19:31, Liam R. Howlett wrote: * SeongJae Park [240903 21:18]: On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: On Tue, 3 Sep

Re: [PATCH v2] mm/damon/tests/vaddr-kunit: init maple tree without MT_FLAGS_LOCK_EXTERN

from the maple tree initialization flags. Note that we don't use empty flags to make it further similar to the usage of mm maple tree, and to be prepared for possible future changes, as suggested by Liam. Reported-by: Guenter Roeck Closes: https://lore.kernel.org/1453b2b2-6119-4082

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

On 9/3/24 20:36, Liam R. Howlett wrote: * Guenter Roeck [240903 22:38]: On 9/3/24 19:31, Liam R. Howlett wrote: * SeongJae Park [240903 21:18]: On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: On Tue, 3 Sep 2024 20:48:53 -0400 "Liam R. Howlett" wrote: * SeongJae Par

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

On 9/3/24 20:36, Liam R. Howlett wrote: * Guenter Roeck [240903 22:38]: On 9/3/24 19:31, Liam R. Howlett wrote: * SeongJae Park [240903 21:18]: On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: On Tue, 3 Sep 2024 20:48:53 -0400 "Liam R. Howlett" wrote: * SeongJae Par

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

cumentation/core-api/maple_tree.rst) I was thinking the fact that the test code is executed in single thread is same to use of external lock. I will be happy to learn if I missed something. Thanks, SJ Thanks, SJ Reported-by: Guenter Roeck Closes: https://lore.kernel.org/145

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

On 9/3/24 18:18, SeongJae Park wrote: On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: On Tue, 3 Sep 2024 20:48:53 -0400 "Liam R. Howlett" wrote: * SeongJae Park [240903 20:45]: damon_test_three_regions_in_vmas() initializes a maple tree with MM_MT_FLAGS. The flags contains MT_FL

Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree

have a suggestion of better flags? Correct. I don't see those messages with your patch. From my perspective, this is Tested-by: Guenter Roeck Thanks, Guenter

Re: [PATCH v4 01/13] ring-buffer: Allow mapped field to be set without mapping

On 6/11/24 15:53, Steven Rostedt wrote: On Tue, 11 Jun 2024 15:43:59 -0700 Guenter Roeck wrote: On 6/11/24 12:28, Steven Rostedt wrote: From: "Steven Rostedt (Google)" In preparation for having the ring buffer mapped to a dedicated location, which will have the same restrictio

Re: [PATCH v4 01/13] ring-buffer: Allow mapped field to be set without mapping

On 6/11/24 12:28, Steven Rostedt wrote: From: "Steven Rostedt (Google)" In preparation for having the ring buffer mapped to a dedicated location, which will have the same restrictions as user space memory mapped buffers, allow it to use the "mapped" field of the ring_buffer_per_cpu structure wi

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

On Fri, Mar 22, 2024 at 9:47 AM Wolfram Sang wrote: > > > > Acked-by: Nicolas Ferre # for at91 > > Probably file names themselves will need some care, in a second time. > > Totally true. I am aware of that. But one step after the other... > Kind of odd though to change function names but not par

Re: [PATCH v1] lib,kprobes: using try_cmpxchg_local in objpool_push

On Mon, Oct 23, 2023 at 07:24:52PM +0800, wuqiang.matt wrote: > The objpool_push can only happen on local cpu node, so only the local > cpu can touch slot->tail and slot->last, which ensures the correctness > of using cmpxchg without lock prefix (using try_cmpxchg_local instead > of try_cmpxchg_acq

Re: [PATCH 1/3] dt-bindings: watchdog: qcom-wdt: Add MSM8226 and MSM8974 compatibles

On Wed, Oct 11, 2023 at 06:33:13PM +0200, Luca Weiss wrote: > From: Matti Lehtimäki > > Add compatibles for the MSM8226 and MSM8974 platforms to the Qualcomm > watchdog binding. > > Signed-off-by: Matti Lehtimäki > Signed-off-by: Luca Weiss Reviewed-by: Guenter Roeck &

Re: [PATCH] MIPS: pci-legacy: revert "use generic pci_enable_resources"

52: > + for (idx=0; idx < PCI_NUM_RESOURCES; idx++) { > ^ > > ERROR: do not use assignment in if condition > #67: FILE: arch/mips/pci/pci-legacy.c:284: > + if ((err = pcibios_enable_resources(dev, mask)) < 0) > > Reported-by: Guenter Roeck > Signed-off-by: Ilya Lipnitskiy Tested-by: Guenter Roeck Guenter

Re: Enabling pmbus power control

On 4/20/21 12:06 AM, Zev Weiss wrote: > On Tue, Apr 20, 2021 at 01:00:25AM CDT, Guenter Roeck wrote: >> On 4/19/21 10:50 PM, Zev Weiss wrote: >> [ ... ] >> >>> I had a glance at the enclosure driver; it looks pretty geared toward >>> SES-like things (driver

Re: Enabling pmbus power control

On 4/19/21 10:50 PM, Zev Weiss wrote: [ ... ] > I had a glance at the enclosure driver; it looks pretty geared toward > SES-like things (drivers/scsi/ses.c being its only usage I can see in the > kernel at the moment) and while it could perhaps be pressed into working for > this it seems like i

Re: [PATCH v2 8/8] MIPS: pci-legacy: use generic pci_enable_resources

On Tue, Apr 13, 2021 at 08:12:40PM -0700, Ilya Lipnitskiy wrote: > Follow the reasoning from commit 842de40d93e0 ("PCI: add generic > pci_enable_resources()"): > > The only functional difference from the MIPS version is that the > generic one uses "!r->parent" to check for resource collisions

Re: Enabling pmbus power control

On Mon, Apr 19, 2021 at 08:29:53PM -0500, Zev Weiss wrote: > On Tue, Mar 30, 2021 at 02:38:10PM CDT, Guenter Roeck wrote: > > On Tue, Mar 30, 2021 at 07:02:00PM +0100, Mark Brown wrote: > > > On Tue, Mar 30, 2021 at 12:56:56PM -0500, Zev Weiss wrote: > > > > >

Re: [PATCH 5.11 000/122] 5.11.16-rc1 review

> let me know. > > Responses should be made by Wed, 21 Apr 2021 13:05:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 461 pass: 461 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/73] 5.4.114-rc1 review

> let me know. > > Responses should be made by Wed, 21 Apr 2021 13:05:09 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 433 pass: 433 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH] hwmon: (pmbus/max15301) Add pmbus driver for MAX15301

diff --git a/MAINTAINERS b/MAINTAINERS > index aa84121c5611..de2ad7223055 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10790,6 +10790,13 @@ S: Orphan > F: drivers/video/fbdev/matrox/matroxfb_* > F: include/uapi/linux/matroxfb.h > > +MAX15301 DRIVER > +M:

Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

On 4/18/21 9:27 PM, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- [ ... ] > drivers/watchdog/renesas_wdt.c| 2 +- > 48 files chan

Re: Linux 5.12-rc8

On Sun, Apr 18, 2021 at 03:02:49PM -0700, Linus Torvalds wrote: > Ok, so it's been _fairly_ calm this past week, but it hasn't been the > kind of dead calm I would have taken to mean "no rc8 necessary". > > So here we are, with an extra rc to make sure things are all settled > down. It's not _that

Re: [PATCH] watchdog: aspeed: fix hardware timeout calculation

Aspeed watchdog driver") > Reported-by: Amithash Prasad > Signed-off-by: Tao Ren Reviewed-by: Guenter Roeck > --- > drivers/watchdog/aspeed_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspee

Re: [PATCH v4 1/3] riscv: Move kernel mapping outside of linear mapping

On Fri, Apr 09, 2021 at 02:14:58AM -0400, Alexandre Ghiti wrote: > This is a preparatory patch for relocatable kernel and sv48 support. > > The kernel used to be linked at PAGE_OFFSET address therefore we could use > the linear mapping for the kernel mapping. But the relocated kernel base > addres

Re: [PATCH v2] hwmon: pmbus: pxe1610: don't bail out when not all pages are active

On Fri, Apr 16, 2021 at 01:29:04PM +0300, Paul Fertser wrote: > Certain VRs might be configured to use only the first output channel and > so the mode for the second will be 0. Handle this gracefully. > > Fixes: b9fa0a3acfd8 ("hwmon: (pmbus/core) Add support for vid mode detection > per page base

Re: [PATCH v2] watchdog: aspeed: fix integer overflow in set_timeout handler

On 4/15/21 7:13 PM, rentao.b...@gmail.com wrote: > From: Tao Ren > > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout > handler to avoid potential integer overflow when the supplied timeout is > greater than aspeed's maximum allowed timeout (4294 seconds). > I think this

Re: [PATCH] watchdog: aspeed: fix integer overflow in set_timeout handler

On Thu, Apr 15, 2021 at 06:04:45PM -0700, Tao Ren wrote: > On Thu, Apr 15, 2021 at 05:50:32PM -0700, Guenter Roeck wrote: > > On 4/15/21 5:12 PM, rentao.b...@gmail.com wrote: > > > From: Tao Ren > > > > > > Fix the time comparison (timeout vs. max_hw_heartbeat

Re: [PATCH] watchdog: aspeed: fix integer overflow in set_timeout handler

On 4/15/21 5:12 PM, rentao.b...@gmail.com wrote: > From: Tao Ren > > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout > handler to avoid potential integer overflow when the supplied timeout is > greater than aspeed's maximum allowed timeout (4294 seconds). > > Fixes: efa8

Re: [PATCH] hwmon: pmbus: pxe1610: don't bail out when not all pages are active

On 4/15/21 6:34 AM, Paul Fertser wrote: > Certain VRs might be configured to use only the first output channel and > so the mode for the second will be 0. Handle this gracefully. > > Fixes: b9fa0a3acfd8 ("hwmon: (pmbus/core) Add support for vid mode detection > per page bases") > Signed-off-by: P

Re: [PATCH V3] watchdog: mtk: support pre-timeout when the bark irq is available

On 4/15/21 2:40 AM, 王擎 wrote: > > Yes, as mentioned before, the behavior of WDT_MODE_IRQ_EN is use irq instead > of > reset, so we must use WDT_MODE_IRQ_EN | WDT_MODE_DUAL_EN if like you said > "the first time generating an interrupt and the second time resetting the > system" . > > The Dual

Re: [PATCH v1] usb: typec: tcpm: Fix error while calculating PPS out values

> for pps supply") > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c >

Re: [PATCH v3 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

On Fri, Apr 09, 2021 at 10:13:31AM +0700, Quan Nguyen wrote: > This commit adds support for Ampere SMpro hwmon driver. This driver > supports accessing various CPU sensors provided by the SMpro co-processor > including temperature, power, voltages, and current. > > Signed-off-by: Quan Nguyen > --

Re: [PATCH v3 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

On Fri, Apr 09, 2021 at 10:13:30AM +0700, Quan Nguyen wrote: > Adds an MFD driver for SMpro found on the Mt.Jade hardware reference > platform with Ampere's Altra processor family. > > Signed-off-by: Quan Nguyen > Reported-by: kernel test robot > --- > drivers/mfd/Kconfig | 10

Re: [PATCH V3] watchdog: mtk: support pre-timeout when the bark irq is available

On 4/14/21 4:48 AM, Wang Qing wrote: > Use the bark interrupt as the pretimeout notifier if available. > > By default, the pretimeout notification shall occur one second earlier > than the timeout. > > V2: > - panic() by default if WATCHDOG_PRETIMEOUT_GOV is not enabled. > > V3: > - Modify the p

Re: [PATCH V2] watchdog: mtk: support pre-timeout when the bark irq is available

On 4/14/21 12:28 AM, Wang Qing wrote: > Use the bark interrupt as the pretimeout notifier if available. > > By default, the pretimeout notification shall occur one second earlier > than the timeout. > > V2: > - panic() by default if WATCHDOG_PRETIMEOUT_GOV is not enabled > > Signed-off-by: Wang

Re: [PATCH v2 2/2] hwmon: intel-m10-bmc-hwmon: add sensor support of Intel D5005 card

On Tue, Apr 13, 2021 at 03:58:35PM -0700, matthew.gerl...@linux.intel.com wrote: > From: Matthew Gerlach > > Like the Intel N3000 card, the Intel D5005 has a MAX10 based > BMC. This commit adds support for the D5005 sensors that are > monitored by the MAX10 BMC. > > Signed-off-by: Matthew Gerla

Re: [PATCH] hwmon: (nct6683) remove useless function

On Tue, Apr 13, 2021 at 02:02:50PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/hwmon/nct6683.c:491:19: warning: unused function 'in_to_reg' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks, Guenter > --- > driv

Re: [PATCH] watchdog: it87_wdt: remove useless function

On 4/13/21 2:34 AM, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/watchdog/it87_wdt.c:155:20: warning: unused function > 'superio_outw' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Reviewed-by: Guenter Ro

Re: [PATCH v4] hwmon: Add driver for fsp-3y PSUs and PDUs

On 4/13/21 3:42 AM, Václav Kubernát wrote: > This patch adds support for these devices: > - YH-5151E - the PDU > - YM-2151E - the PSU > > The device datasheet says that the devices support PMBus 1.2, but in my > testing, a lot of the commands aren't supported and if they are, they > sometimes beha

Re: [PATCH 5.11 000/210] 5.11.14-rc1 review

and fixed. Until then, I guess we'll have to live with it. Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/188] 5.10.30-rc1 review

> let me know. > > Responses should be made by Wed, 14 Apr 2021 08:39:44 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 454 pass: 454 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 000/111] 5.4.112-rc1 review

> let me know. > > Responses should be made by Wed, 14 Apr 2021 08:39:44 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 432 pass: 432 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/66] 4.19.187-rc1 review

> let me know. > > Responses should be made by Wed, 14 Apr 2021 08:39:44 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 422 pass: 422 fail: 0 Tested-by: Guenter Roeck Guenter

Re: Linux 5.12-rc7

On 4/12/21 10:38 AM, Eric Dumazet wrote: [ ... ] > Yes, I think this is the real issue here. This smells like some memory > corruption. > > In my traces, packet is correctly received in AF_PACKET queue. > > I have checked the skb is well formed. > > But the user space seems to never call poll()

Re: Linux 5.12-rc7

On 4/12/21 9:31 AM, Eric Dumazet wrote: > On Mon, Apr 12, 2021 at 6:28 PM Linus Torvalds > wrote: >> >> On Sun, Apr 11, 2021 at 10:14 PM Guenter Roeck wrote: >>> >>> Qemu test results: >>> total: 460 pass: 459 fail: 1 >>> Failed

Re: [PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

On 4/12/21 8:35 AM, Henning Schild wrote: > Am Thu, 1 Apr 2021 18:15:41 +0200 > schrieb "Enrico Weigelt, metux IT consult" : > >> On 29.03.21 19:49, Henning Schild wrote: >> >> Hi, >> >>> This driver adds initial support for several devices from Siemens. >>> It is based on a platform driver introd

Re: [PATCH] ASoC: fsl_sai: Don't use devm_regmap_init_mmio_clk

On 4/12/21 3:37 AM, Shengjiu Wang wrote: [ ... ] > The SAI module is not supported in QEMU, so the access of the register > failed. > > you can add bypass the access in QEMU, for example: > > diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c > index e0128d7316..62f7bd92a4 100644 > --- a/hw/a

Re: [PATCH v1] watchdog: add new parameter to start the watchdog on module insertion

On 4/12/21 1:29 AM, Flavio Suligoi wrote: > Hi Guenter, > > ... > >> On 4/9/21 2:34 AM, Flavio Suligoi wrote: >>> The new parameter "start_enabled" starts the watchdog at the same time >>> of the module insertion. >>> This feature is very useful in embedded systems, to avoid cases where >>> the s

Re: Linux 5.12-rc7

On Sun, Apr 11, 2021 at 03:41:18PM -0700, Linus Torvalds wrote: > Oh well. rc5 was big. rc6 was small. And now rc7 is big again. In > fact, it's the biggest rc7 (at least in number of commits) we've had > in the 5.x series. > > It's mostly due to networking fixes (of which rc6 had none), and none

Re: [PATCH] ASoC: fsl_sai: Don't use devm_regmap_init_mmio_clk

On Fri, Mar 19, 2021 at 04:06:43PM +0800, Shengjiu Wang wrote: > When there is power domain bind with bus clock, > > The call flow: > devm_regmap_init_mmio_clk >- clk_prepare() > - clk_pm_runtime_get() > > cause the power domain of clock always be enabled after > regmap_init(). which im

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

Michal, On 4/7/21 11:08 PM, Michal Simek wrote: ... > It looks like that you directly created the patch. Isn't it better to > send it yourself? Or do you want Manish to create it based on guidance > above? > -next is substantially broken all over the place. I already spend way too much time bisec

Re: [PATCH v2] hwmon: (dell-smm) Add Dell Latitude E7440 to fan control whitelist

On Sun, Apr 11, 2021 at 11:57:41AM +0200, Sebastian Oechsle wrote: > Allow manual PWM control on Dell Latitude E7440. > > Signed-off-by: Sebastian Oechsle > > Changes in v2: > - Fix spelling > - Fix format > --- Applied, but next time changelog goes here, please (after ---). Thanks, Guenter >

Re: [PATCH v4] platform/x86: add Gigabyte WMI temperature driver

ely not all sensor registers are handled by the firmware and even > less are exposed via WMI. > > Signed-off-by: Thomas Weißschuh Good enough, though you may want to improve your description. Reviewed-by: Guenter Roeck FWIW, on B450 AORUS M: gigabyte-wmi DEADBEEF-2001--00A0-C9062

Re: [PATCH 08/10] powerpc/signal32: Convert restore_[tm]_user_regs() to user access block

On Fri, Mar 19, 2021 at 11:06:57AM +, Christophe Leroy wrote: > Convert restore_user_regs() and restore_tm_user_regs() > to use user_access_read_begin/end blocks. > > Signed-off-by: Christophe Leroy > --- ... > static long restore_user_regs(struct pt_regs *regs, >

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

On 4/10/21 2:21 AM, Naresh Kamboju wrote: > On Sat, 10 Apr 2021 at 01:43, Guenter Roeck wrote: >> >> On Fri, Apr 09, 2021 at 11:53:25AM +0200, Greg Kroah-Hartman wrote: >>> This is the start of the stable review cycle for the 4.14.230 release. >>> There are 14 pa

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

On 4/10/21 7:57 AM, Hans de Goede wrote: > Hi, > > On 4/10/21 4:40 PM, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> * Fix errno/ACPI error confu

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

On 4/10/21 7:40 AM, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup > * Document reason for

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

Hi Greg, On 4/10/21 6:15 AM, Greg Kroah-Hartman wrote: > On Fri, Apr 09, 2021 at 01:13:06PM -0700, Guenter Roeck wrote: >> On Fri, Apr 09, 2021 at 11:53:25AM +0200, Greg Kroah-Hartman wrote: >>> This is the start of the stable review cycle for the 4.14.230 release. >>&

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

On 4/8/21 11:02 PM, Thomas Weißschuh wrote: > On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: >> On 4/8/21 2:36 AM, Hans de Goede wrote: >>> On 4/7/21 9:43 PM, Thomas Weißschuh wrote: >>>> On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >>> Jean, Guente

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

On 4/8/21 9:07 AM, Hans de Goede wrote: > Hi Guenter, > > On 4/8/21 5:08 PM, Guenter Roeck wrote: >> On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: >>> Changes since v1: >>> * Incorporate feedback from Barnabás Pőcze >>> * Use

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

On Fri, Apr 09, 2021 at 01:13:06PM -0700, Guenter Roeck wrote: > On Fri, Apr 09, 2021 at 11:53:25AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.230 release. > > There are 14 patches in this series, all will be posted as a response

Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

On 4/9/21 8:11 PM, 王擎 wrote: > >> On 4/9/21 7:42 PM, 王擎 wrote: >>> On 4/9/21 2:55 AM, Wang Qing wrote: > Use the bark interrupt as the pretimeout notifier if available. > > By default, the pretimeout notification shall occur one second earlier > than the timeout. > > S

Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

On 4/9/21 7:42 PM, 王擎 wrote: > >> On 4/9/21 2:55 AM, Wang Qing wrote: >>> Use the bark interrupt as the pretimeout notifier if available. >>> >>> By default, the pretimeout notification shall occur one second earlier >>> than the timeout. >>> >>> Signed-off-by: Wang Qing >>> --- >>> drivers/watc

Re: [PATCH v2 4/6] usb: typec: tcpm: Honour pSnkStdby requirement during negotiation

ms [rev2 POWER_NEGOTIATION] > [ 169.260222] PD RX, header: 0x566 [1] > [ 169.260227] Setting voltage/current limit 9000 mV 2000 mA > [ 169.261315] set_auto_vbus_discharge_threshold mode:3 pps_active:n > vbus:9000 ret:0 > [ 169.261321] state change SNK_TRANSITION_SINK -> SNK_RE

Re: [PATCH v2 3/6] usb: typec: tcpm: update power supply once partner accepts

_supply_changed is already > called right after usb_type is changed. > > Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through > power_supply") > Signed-off-by: Badhri Jagan Sridharan > Reviewed-by: Adam Thomson Reviewed-by: Guenter Roeck > --- >

Re: [PATCH v2 2/6] usb: typec: tcpm: Address incorrect values of tcpm psy for pps supply

ltage gets updated > once local port's tcpm enters SNK_TRANSITION_SINK when the accepted > current_limit and supply_voltage is enforced. > > Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through > power_supply") > Signed-off-by: Badhri Jagan Sridharan

Re: [PATCH] hwmon: (dell-smm) Add Dell Latitude 7440 to fan control whitelist

On Tue, Mar 30, 2021 at 07:02:55PM +0200, Sebastian Oechsle wrote: > Allow manual PWM control on Dell Latitude 7440. > > Signed-off-by: Sebastian Oechsle > This patch is corrupt, to the point where it doesn't show up in hwmon patchwork. I just happened to find it, b

Re: [PATCH] hwmon: (dme1737): Add missing null check on return from platform_get_resource

On Tue, Apr 06, 2021 at 07:54:58PM +0100, Colin King wrote: > From: Colin Ian King > > The call to platform_get_resource can potentially return a NULL pointer > on failure, so add this check and return -EINVAL if it fails. > > Addresses-Coverity: ("Dereference null return") > Fixes: e95c237d78c0

Re: [PATCH 5.11 00/45] 5.11.13-rc1 review

> let me know. > > Responses should be made by Sun, 11 Apr 2021 09:52:52 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 460 pass: 460 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 00/41] 5.10.29-rc1 review

> let me know. > > Responses should be made by Sun, 11 Apr 2021 09:52:52 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 454 pass: 454 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/23] 5.4.111-rc1 review

> let me know. > > Responses should be made by Sun, 11 Apr 2021 09:52:52 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 433 pass: 433 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 00/18] 4.19.186-rc1 review

> let me know. > > Responses should be made by Sun, 11 Apr 2021 09:52:52 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 423 pass: 423 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.14 00/14] 4.14.230-rc1 review

> let me know. > > Responses should be made by Sun, 11 Apr 2021 09:52:52 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 408 pass: 408 fail: 0 Tested-by: Guenter Roeck Havin

Re: [PATCH 4.9 00/13] 4.9.266-rc1 review

> let me know. > > Responses should be made by Sun, 11 Apr 2021 09:52:52 +. > Anything received after that time might be too late. > Build results: total: 163 pass: 163 fail: 0 Qemu test results: total: 383 pass: 383 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.4 00/20] 4.4.266-rc1 review

> let me know. > > Responses should be made by Sun, 11 Apr 2021 09:52:52 +. > Anything received after that time might be too late. > Build results: total: 160 pass: 160 fail: 0 Qemu test results: total: 328 pass: 328 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH v1] watchdog: add new parameter to start the watchdog on module insertion

On 4/9/21 2:34 AM, Flavio Suligoi wrote: > The new parameter "start_enabled" starts the watchdog at the same time > of the module insertion. > This feature is very useful in embedded systems, to avoid cases where > the system hangs before reaching userspace. > > This function can be also enabled i

Re: [PATCH] watchdog: mtk: support pre-timeout when the bark irq is available

On 4/9/21 2:55 AM, Wang Qing wrote: > Use the bark interrupt as the pretimeout notifier if available. > > By default, the pretimeout notification shall occur one second earlier > than the timeout. > > Signed-off-by: Wang Qing > --- > drivers/watchdog/mtk_wdt.c | 47 > ++

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/8/21 3:53 PM, Frank Rowand wrote: > On 4/8/21 4:54 PM, Guenter Roeck wrote: >> On 4/8/21 2:28 PM, Rob Herring wrote: >>> >>> Applying now so this gets into linux-next this week. >>> >> The patch doesn't apply on top of today's -next; it conf

Re: [PATCH v3] hwmon: Add driver for fsp-3y PSUs and PDUs

On 4/8/21 6:27 PM, Václav Kubernát wrote: > This patch adds support for these devices: > - YH-5151E - the PDU > - YM-2151E - the PSU > > The device datasheet says that the devices support PMBus 1.2, but in my > testing, a lot of the commands aren't supported and if they are, they > sometimes behav

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

stcase-data/address-tests/bus@8000/device@1000 Tested-by: Guenter Roeck Guenter

Re: [PATCH v3 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/8/21 1:06 PM, Frank Rowand wrote: >>> +#define FDT_ALIGN_SIZE 8 >>> + >> >> Use existing define ? Or was that local in libfdt ? > > I don't see a define in libfdt. If anyone finds one, > I'll switch to it. > Turns out that was hardcoded in scripts/dtc/libfdt/fdt.c + /* The device t

Re: [PATCH] block: Disable -Walign-mismatch for blk-mq.c

ne translation unit. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1328 > Link: > https://lore.kernel.org/r/20210310182307.zzcbi5w5jrmveld4@archlinux-ax161/ > Link: https://lore.kernel.org/r/20210330230249.709221-1-jian...@google.com/ > Signed-off-by: Nathan Chancellor

Re: [PATCH v3 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

as reported in: > https://lore.kernel.org/lkml/20210327224116.69309-1-li...@roeck-us.net/ > > Reported-by: Guenter Roeck > Signed-off-by: Frank Rowand > --- > > changes since version 1: > - use pointer from kmalloc() for kfree() instead of using pointer that > has been modified f

Re: [PATCH v2 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

as reported in: > https://lore.kernel.org/lkml/20210327224116.69309-1-li...@roeck-us.net/ > > Reported-by: Guenter Roeck > Signed-off-by: Frank Rowand > > --- > > Please review carefully, I am not yet fully awake... > > changes since version 1: > - use pointer from kmal

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup >

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

On 4/8/21 2:36 AM, Hans de Goede wrote: > Hi, > > On 4/7/21 9:43 PM, Thomas Weißschuh wrote: >> Hi Hans, >> >> On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >>> Thank you for your new driver and thank you for the quick respin >>> addressing Barnabás' request to make it a WMI driver. >>> >>> T

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

coming which would make use of it, but my memory may defeat me. Either case, it is getting old. It it is ever needed, it can be reintroduced. Reviewed-by: Guenter Roeck Guenter > Acked-by: Heikki Krogerus > >> --- >> drivers/usb/typec/tcpm/tcpm.c | 60 >>

Re: [PATCH v2] hwmon: Add driver for fsp-3y PSUs and PDUs

On 4/7/21 7:34 PM, Václav Kubernát wrote: > This patch adds support for these devices: > - YH-5151E - the PDU > - YM-2151E - the PSU > > The device datasheet says that the devices support PMBus 1.2, but in my > testing, a lot of the commands aren't supported and if they are, they > sometimes behav

Re: [PATCH 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/7/21 1:59 PM, Frank Rowand wrote: > Hi Guenter, > > On 4/7/21 3:51 PM, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> The Devicetree standard specifies an 8 byte alignment of the FDT. >> Code in libfdt expects this alignment for an FDT image in memory. >> kmemdup() returns 4 byte

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

On Wed, Mar 17, 2021 at 12:22:29PM +0530, Manish Narani wrote: > Add a new driver for supporting Xilinx platforms. This driver is used > for some sequence of operations required for Xilinx USB controllers. > This driver is also used to choose between PIPE clock coming from SerDes > and the Suspend

Re: [PATCH] MIPS: select ARCH_KEEP_MEMBLOCK unconditionally

t; > Link: > https://lore.kernel.org/linux-kbuild/20210313194836.372585-11-masahi...@kernel.org/ > Fixes: commit a8c0f1c634507 ("MIPS: Select ARCH_KEEP_MEMBLOCK if s/commit // > DEBUG_KERNEL to enable sysfs memblock debug") > Cc: Masahiro Yamada > Reported-by: Guente

Re: [PATCH v2 1/1] serial: sh-sci: Respect deferred probe when getting IRQ

e distinguished from no IRQ case. With this, rewrite IRQ resource > handling in sh-sci driver to follow above and allow to respect deferred > probe. > > Fixes: ed7027fdf4ec ("driver core: platform: Make platform_get_irq_optional() > optional") > Reported-by: Guenter Roe

Re: [PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

On 4/7/21 1:53 AM, Andy Shevchenko wrote: > On Tue, Apr 6, 2021 at 5:56 PM Henning Schild > wrote: >> >> Am Thu, 1 Apr 2021 18:15:41 +0200 >> schrieb "Enrico Weigelt, metux IT consult" : >> >>> On 29.03.21 19:49, Henning Schild wrote: >>> >>> Hi, >>> This driver adds initial support for sever

Re: [PATCH v2 07/19] dt-bindings: fix references for iio-bindings.txt

in order to point to the right URL. > > Fixes: dba91f82d580 ("dt-bindings:iio:iio-binding.txt Drop file as content > now in dt-schema") > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt | 2 +- Acked-by: Guenter

Re: [PATCH v2 3/4] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver

On 4/7/21 12:41 AM, Quan Nguyen wrote: [ ... ] >> >> But then why don't you just use reg_ext to store SOC_VR_HOT_THRESHOLD_REG >> or MEM_HOT_THRESHOLD_REG ? It is already available, after all, and with it >> the code could be simplified to >> >>     ret = regmap_read(hwmon->regmap, temperature[

Re: [PATCH v2] hwmon: (sbtsi) Don't read sensor more than once if it doesn't respond

the mutex lock/unlock in the original > driver. > Why would that be necessary ? My understanding is that the returned value is read-only and won't change. FWIW, I don't even understand why it is read more than once to start with. On a side note, the above code would leave the mutex l

Re: [PATCH v2] h8300: rearrange headers inclusion order in asm/bitops

ported-by: kernel test robot > Reported-by: Guenter Roeck > Reviewed-by: Andy Shevchenko > Signed-off-by: Yury Norov Tested-by: Guenter Roeck Guenter > --- > arch/h8300/include/asm/bitops.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH v2] hwmon: (sbtsi) Don't read sensor more than once if it doesn't respond

oticed that the mutex check is absent in a > SBTSI_REG_CONFIG read call both in the original driver version and in > my patch, is this an error? > What do you mean with "mutex check" ? Thanks, Guenter > Best regards, > Konstantin Aladyshev > > > On Tue

  1   2   3   4   5   6   7   8   9   10   >