Re: [PATCH v4] lib: add size unit t/p/e to memparse
On Mon, 2014-06-16 at 18:29 -0700, David Rientjes wrote:
> On Tue, 17 Jun 2014, Gui Hecheng wrote:
>
> > > > diff --git a/lib/cmdline.c b/lib/cmdline.c
> > > > index d4932f7..76a712e 100644
> > > > --- a/lib/cmdline.c
> > > > +++ b/lib/cmdline.c
> > > > @@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
> > > > * @retptr: (output) Optional pointer to next char after parse
> > > > completes
> > > > *
> > > > * Parses a string into a number. The number stored at @ptr is
> > > > - * potentially suffixed with %K (for kilobytes, or 1024 bytes),
> > > > - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
> > > > - * 1073741824). If the number is suffixed with K, M, or G, then
> > > > - * the return value is the number multiplied by one kilobyte, one
> > > > - * megabyte, or one gigabyte, respectively.
> > > > + * potentially suffixed with K, M, G, T, P, E.
> > > > */
> > > >
> > > > unsigned long long memparse(const char *ptr, char **retptr)
> > > > @@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char
> > > > **retptr)
> > > > unsigned long long ret = simple_strtoull(ptr, , 0);
> > > >
> > > > switch (*endptr) {
> > > > + case 'E':
> > > > + case 'e':
> > > > + ret <<= 10;
> > > > + case 'P':
> > > > + case 'p':
> > > > + ret <<= 10;
> > > > + case 'T':
> > > > + case 't':
> > > > + ret <<= 10;
> > > > case 'G':
> > > > case 'g':
> > > > ret <<= 10;
> > >
> > > Seems fine since unsigned long long is always at least 64 bits, but
> > > perhaps also change simple_strtoull() to use kstrtoull() at the same time
> > > since the former is deprecated?
> >
> > Yes, that is a point. But the deprecated function is a separate problem
> > and may not be included in this patch.
> > Also, I find that simple_strtoull is used in many places in the kernel
> > code, it is better to replace it globally?
> >
>
> If you're going to have a go at replacing the simple_strto*() functions
> throughout the kernel, it's probably better to do it per subsystem (as
> defined by the separate sections of MAINTAINERS) and propose the patches
> individually to those maintainers. Once it has been removed entirely, you
> can submit a patch to remove the functions themselves.
>
> Be aware that there are many callers to the deprecated functions so it may
> take a significant amount of time.
H...It may really take a long time. But I am not sure whether this
is really a good idea to do this big replacement. Let's see whether
anyone would like to share his opinions.
-Gui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] lib: add size unit t/p/e to memparse
On Fri, 2014-06-13 at 14:58 -0700, David Rientjes wrote:
> On Fri, 13 Jun 2014, Gui Hecheng wrote:
>
> > diff --git a/lib/cmdline.c b/lib/cmdline.c
> > index d4932f7..76a712e 100644
> > --- a/lib/cmdline.c
> > +++ b/lib/cmdline.c
> > @@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
> > * @retptr: (output) Optional pointer to next char after parse completes
> > *
> > * Parses a string into a number. The number stored at @ptr is
> > - * potentially suffixed with %K (for kilobytes, or 1024 bytes),
> > - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
> > - * 1073741824). If the number is suffixed with K, M, or G, then
> > - * the return value is the number multiplied by one kilobyte, one
> > - * megabyte, or one gigabyte, respectively.
> > + * potentially suffixed with K, M, G, T, P, E.
> > */
> >
> > unsigned long long memparse(const char *ptr, char **retptr)
> > @@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char
> > **retptr)
> > unsigned long long ret = simple_strtoull(ptr, , 0);
> >
> > switch (*endptr) {
> > + case 'E':
> > + case 'e':
> > + ret <<= 10;
> > + case 'P':
> > + case 'p':
> > + ret <<= 10;
> > + case 'T':
> > + case 't':
> > + ret <<= 10;
> > case 'G':
> > case 'g':
> > ret <<= 10;
>
> Seems fine since unsigned long long is always at least 64 bits, but
> perhaps also change simple_strtoull() to use kstrtoull() at the same time
> since the former is deprecated?
Yes, that is a point. But the deprecated function is a separate problem
and may not be included in this patch.
Also, I find that simple_strtoull is used in many places in the kernel
code, it is better to replace it globally?
-Gui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] lib: add size unit t/p/e to memparse
On Fri, 2014-06-13 at 14:58 -0700, David Rientjes wrote:
On Fri, 13 Jun 2014, Gui Hecheng wrote:
diff --git a/lib/cmdline.c b/lib/cmdline.c
index d4932f7..76a712e 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with K, M, G, T, P, E.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char
**retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
Seems fine since unsigned long long is always at least 64 bits, but
perhaps also change simple_strtoull() to use kstrtoull() at the same time
since the former is deprecated?
Yes, that is a point. But the deprecated function is a separate problem
and may not be included in this patch.
Also, I find that simple_strtoull is used in many places in the kernel
code, it is better to replace it globally?
-Gui
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] lib: add size unit t/p/e to memparse
On Mon, 2014-06-16 at 18:29 -0700, David Rientjes wrote:
On Tue, 17 Jun 2014, Gui Hecheng wrote:
diff --git a/lib/cmdline.c b/lib/cmdline.c
index d4932f7..76a712e 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
* @retptr: (output) Optional pointer to next char after parse
completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with K, M, G, T, P, E.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char
**retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
Seems fine since unsigned long long is always at least 64 bits, but
perhaps also change simple_strtoull() to use kstrtoull() at the same time
since the former is deprecated?
Yes, that is a point. But the deprecated function is a separate problem
and may not be included in this patch.
Also, I find that simple_strtoull is used in many places in the kernel
code, it is better to replace it globally?
If you're going to have a go at replacing the simple_strto*() functions
throughout the kernel, it's probably better to do it per subsystem (as
defined by the separate sections of MAINTAINERS) and propose the patches
individually to those maintainers. Once it has been removed entirely, you
can submit a patch to remove the functions themselves.
Be aware that there are many callers to the deprecated functions so it may
take a significant amount of time.
H...It may really take a long time. But I am not sure whether this
is really a good idea to do this big replacement. Let's see whether
anyone would like to share his opinions.
-Gui
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] lib: add size unit t/p/e to memparse
On Fri, 2014-06-13 at 07:55 +0200, Brendan Hide wrote:
> On 13/06/14 03:42, Gui Hecheng wrote:
> > For modern filesystems such as btrfs, t/p/e size level operations
> > are common.
> > add size unit t/p/e parsing to memparse
> >
> > Signed-off-by: Gui Hecheng
> > ---
> > changelog
> > v1->v2: replace kilobyte with kibibyte, and others
> > v2->v3: add missing unit "bytes" in comment
> > v3->v4: remove idiotic name for K,M,G,P,T,E
> > ---
> > lib/cmdline.c | 15 ++-
> > 1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/cmdline.c b/lib/cmdline.c
> > index d4932f7..76a712e 100644
> > --- a/lib/cmdline.c
> > +++ b/lib/cmdline.c
> > @@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
> >*@retptr: (output) Optional pointer to next char after parse
> > completes
> >*
> >*Parses a string into a number. The number stored at @ptr is
> > - * potentially suffixed with %K (for kilobytes, or 1024 bytes),
> > - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
> > - * 1073741824). If the number is suffixed with K, M, or G, then
> > - * the return value is the number multiplied by one kilobyte, one
> > - * megabyte, or one gigabyte, respectively.
> > + * potentially suffixed with K, M, G, T, P, E.
> >*/
> >
> > unsigned long long memparse(const char *ptr, char **retptr)
> > @@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char
> > **retptr)
> > unsigned long long ret = simple_strtoull(ptr, , 0);
> >
> > switch (*endptr) {
> > + case 'E':
> > + case 'e':
> > + ret <<= 10;
> > + case 'P':
> > + case 'p':
> > + ret <<= 10;
> > + case 'T':
> > + case 't':
> > + ret <<= 10;
> > case 'G':
> > case 'g':
> > ret <<= 10;
> Ah, I see - you've removed all reference to their names. That's good too. :)
>
Thank you for your review!
I think maybe more people would like cleaner things in the kernel.
-Gui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4] lib: add size unit t/p/e to memparse
On Fri, 2014-06-13 at 07:55 +0200, Brendan Hide wrote:
On 13/06/14 03:42, Gui Hecheng wrote:
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog
v1-v2: replace kilobyte with kibibyte, and others
v2-v3: add missing unit bytes in comment
v3-v4: remove idiotic name for K,M,G,P,T,E
---
lib/cmdline.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index d4932f7..76a712e 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
*@retptr: (output) Optional pointer to next char after parse
completes
*
*Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with K, M, G, T, P, E.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char
**retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
Ah, I see - you've removed all reference to their names. That's good too. :)
Thank you for your review!
I think maybe more people would like cleaner things in the kernel.
-Gui
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng
---
changelog
v1->v2: replace kilobyte with kibibyte, and others
v2->v3: add missing unit "bytes" in comment
v3->v4: remove idiotic name for K,M,G,P,T,E
---
lib/cmdline.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index d4932f7..76a712e 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with K, M, G, T, P, E.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, , 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret <<= 10;
+ case 'P':
+ case 'p':
+ ret <<= 10;
+ case 'T':
+ case 't':
+ ret <<= 10;
case 'G':
case 'g':
ret <<= 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] lib: add size unit t/p/e to memparse
On Thu, 2014-06-12 at 14:15 -0700, Andrew Morton wrote:
> On Wed, 2 Apr 2014 16:54:37 +0800 Gui Hecheng
> wrote:
>
> > For modern filesystems such as btrfs, t/p/e size level operations
> > are common.
> > add size unit t/p/e parsing to memparse
> >
> > Signed-off-by: Gui Hecheng
> > ---
> > changelog
> > v1->v2: replace kilobyte with kibibyte, and others
> > v2->v3: add missing unit "bytes" in comment
> > ---
> > lib/cmdline.c | 25 -
> > 1 file changed, 20 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/cmdline.c b/lib/cmdline.c
> > index eb67911..511b9be 100644
> > --- a/lib/cmdline.c
> > +++ b/lib/cmdline.c
> > @@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int
> > *ints)
> > * @retptr: (output) Optional pointer to next char after parse completes
> > *
> > * Parses a string into a number. The number stored at @ptr is
> > - * potentially suffixed with %K (for kilobytes, or 1024 bytes),
> > - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
> > - * 1073741824). If the number is suffixed with K, M, or G, then
> > - * the return value is the number multiplied by one kilobyte, one
> > - * megabyte, or one gigabyte, respectively.
> > + * potentially suffixed with
> > + * %K (for kibibytes, or 1024 bytes),
> > + * %M (for mebibytes, or 1048576 bytes),
> > + * %G (for gibibytes, or 1073741824 bytes),
> > + * %T (for tebibytes, or 1099511627776 bytes),
> > + * %P (for pebibytes, or 1125899906842624 bytes),
> > + * %E (for exbibytes, or 1152921504606846976 bytes).
>
> I'm afraid I find these names quite idiotic - we all know what the
> traditional terms mean so why go and muck with it.
>
> Also, kibibytes sounds like cat food.
Yes, I will cleanup this part, Thanks very much.
-Gui
> > @@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char
> > **retptr)
> > unsigned long long ret = simple_strtoull(ptr, , 0);
> >
> > switch (*endptr) {
> > + case 'E':
> > + case 'e':
> > + ret <<= 10;
> > + case 'P':
> > + case 'p':
> > + ret <<= 10;
> > + case 'T':
> > + case 't':
> > + ret <<= 10;
> > case 'G':
> > case 'g':
> > ret <<= 10;
>
> That bit makes sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] lib: add size unit t/p/e to memparse
On Thu, 2014-06-12 at 14:15 -0700, Andrew Morton wrote:
On Wed, 2 Apr 2014 16:54:37 +0800 Gui Hecheng guihc.f...@cn.fujitsu.com
wrote:
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog
v1-v2: replace kilobyte with kibibyte, and others
v2-v3: add missing unit bytes in comment
---
lib/cmdline.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..511b9be 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int
*ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with
+ * %K (for kibibytes, or 1024 bytes),
+ * %M (for mebibytes, or 1048576 bytes),
+ * %G (for gibibytes, or 1073741824 bytes),
+ * %T (for tebibytes, or 1099511627776 bytes),
+ * %P (for pebibytes, or 1125899906842624 bytes),
+ * %E (for exbibytes, or 1152921504606846976 bytes).
I'm afraid I find these names quite idiotic - we all know what the
traditional terms mean so why go and muck with it.
Also, kibibytes sounds like cat food.
Yes, I will cleanup this part, Thanks very much.
-Gui
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char
**retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
That bit makes sense.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog
v1-v2: replace kilobyte with kibibyte, and others
v2-v3: add missing unit bytes in comment
v3-v4: remove idiotic name for K,M,G,P,T,E
---
lib/cmdline.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index d4932f7..76a712e 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -121,11 +121,7 @@ EXPORT_SYMBOL(get_options);
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with K, M, G, T, P, E.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -135,6 +131,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: ·[ping][PATCH v3] lib: add size unit t/p/e to memparse
On Wed, 2014-04-02 at 16:54 +0800, Gui Hecheng wrote:
> For modern filesystems such as btrfs, t/p/e size level operations
> are common.
> add size unit t/p/e parsing to memparse
>
> Signed-off-by: Gui Hecheng
> ---
> changelog
> v1->v2: replace kilobyte with kibibyte, and others
> v2->v3: add missing unit "bytes" in comment
> ---
> lib/cmdline.c | 25 -
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/lib/cmdline.c b/lib/cmdline.c
> index eb67911..511b9be 100644
> --- a/lib/cmdline.c
> +++ b/lib/cmdline.c
> @@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
> * @retptr: (output) Optional pointer to next char after parse completes
> *
> * Parses a string into a number. The number stored at @ptr is
> - * potentially suffixed with %K (for kilobytes, or 1024 bytes),
> - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
> - * 1073741824). If the number is suffixed with K, M, or G, then
> - * the return value is the number multiplied by one kilobyte, one
> - * megabyte, or one gigabyte, respectively.
> + * potentially suffixed with
> + * %K (for kibibytes, or 1024 bytes),
> + * %M (for mebibytes, or 1048576 bytes),
> + * %G (for gibibytes, or 1073741824 bytes),
> + * %T (for tebibytes, or 1099511627776 bytes),
> + * %P (for pebibytes, or 1125899906842624 bytes),
> + * %E (for exbibytes, or 1152921504606846976 bytes).
> + * If the number is suffixed with K, M, G, T, P, E, then
> + * the return value is the number multiplied by one kibibyte, one
> + * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
> + * respectively.
> */
>
> unsigned long long memparse(const char *ptr, char **retptr)
> @@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char
> **retptr)
> unsigned long long ret = simple_strtoull(ptr, , 0);
>
> switch (*endptr) {
> + case 'E':
> + case 'e':
> + ret <<= 10;
> + case 'P':
> + case 'p':
> + ret <<= 10;
> + case 'T':
> + case 't':
> + ret <<= 10;
> case 'G':
> case 'g':
> ret <<= 10;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: ·[ping][PATCH v3] lib: add size unit t/p/e to memparse
On Wed, 2014-04-02 at 16:54 +0800, Gui Hecheng wrote:
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog
v1-v2: replace kilobyte with kibibyte, and others
v2-v3: add missing unit bytes in comment
---
lib/cmdline.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..511b9be 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with
+ * %K (for kibibytes, or 1024 bytes),
+ * %M (for mebibytes, or 1048576 bytes),
+ * %G (for gibibytes, or 1073741824 bytes),
+ * %T (for tebibytes, or 1099511627776 bytes),
+ * %P (for pebibytes, or 1125899906842624 bytes),
+ * %E (for exbibytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
+ * the return value is the number multiplied by one kibibyte, one
+ * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char
**retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [ping][PATCH v3] lib: add size unit t/p/e to memparse
On Wed, 2014-04-02 at 16:54 +0800, Gui Hecheng wrote:
> For modern filesystems such as btrfs, t/p/e size level operations
> are common.
> add size unit t/p/e parsing to memparse
>
> Signed-off-by: Gui Hecheng
> ---
> changelog
> v1->v2: replace kilobyte with kibibyte, and others
> v2->v3: add missing unit "bytes" in comment
> ---
> lib/cmdline.c | 25 -
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/lib/cmdline.c b/lib/cmdline.c
> index eb67911..511b9be 100644
> --- a/lib/cmdline.c
> +++ b/lib/cmdline.c
> @@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
> * @retptr: (output) Optional pointer to next char after parse completes
> *
> * Parses a string into a number. The number stored at @ptr is
> - * potentially suffixed with %K (for kilobytes, or 1024 bytes),
> - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
> - * 1073741824). If the number is suffixed with K, M, or G, then
> - * the return value is the number multiplied by one kilobyte, one
> - * megabyte, or one gigabyte, respectively.
> + * potentially suffixed with
> + * %K (for kibibytes, or 1024 bytes),
> + * %M (for mebibytes, or 1048576 bytes),
> + * %G (for gibibytes, or 1073741824 bytes),
> + * %T (for tebibytes, or 1099511627776 bytes),
> + * %P (for pebibytes, or 1125899906842624 bytes),
> + * %E (for exbibytes, or 1152921504606846976 bytes).
> + * If the number is suffixed with K, M, G, T, P, E, then
> + * the return value is the number multiplied by one kibibyte, one
> + * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
> + * respectively.
> */
>
> unsigned long long memparse(const char *ptr, char **retptr)
> @@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char
> **retptr)
> unsigned long long ret = simple_strtoull(ptr, , 0);
>
> switch (*endptr) {
> + case 'E':
> + case 'e':
> + ret <<= 10;
> + case 'P':
> + case 'p':
> + ret <<= 10;
> + case 'T':
> + case 't':
> + ret <<= 10;
> case 'G':
> case 'g':
> ret <<= 10;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [ping][PATCH v3] lib: add size unit t/p/e to memparse
On Wed, 2014-04-02 at 16:54 +0800, Gui Hecheng wrote:
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog
v1-v2: replace kilobyte with kibibyte, and others
v2-v3: add missing unit bytes in comment
---
lib/cmdline.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..511b9be 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with
+ * %K (for kibibytes, or 1024 bytes),
+ * %M (for mebibytes, or 1048576 bytes),
+ * %G (for gibibytes, or 1073741824 bytes),
+ * %T (for tebibytes, or 1099511627776 bytes),
+ * %P (for pebibytes, or 1125899906842624 bytes),
+ * %E (for exbibytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
+ * the return value is the number multiplied by one kibibyte, one
+ * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char
**retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng
---
changelog
v1->v2: replace kilobyte with kibibyte, and others
v2->v3: add missing unit "bytes" in comment
---
lib/cmdline.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..511b9be 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with
+ * %K (for kibibytes, or 1024 bytes),
+ * %M (for mebibytes, or 1048576 bytes),
+ * %G (for gibibytes, or 1073741824 bytes),
+ * %T (for tebibytes, or 1099511627776 bytes),
+ * %P (for pebibytes, or 1125899906842624 bytes),
+ * %E (for exbibytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
+ * the return value is the number multiplied by one kibibyte, one
+ * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, , 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret <<= 10;
+ case 'P':
+ case 'p':
+ ret <<= 10;
+ case 'T':
+ case 't':
+ ret <<= 10;
case 'G':
case 'g':
ret <<= 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog
v1-v2: replace kilobyte with kibibyte, and others
v2-v3: add missing unit bytes in comment
---
lib/cmdline.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..511b9be 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with
+ * %K (for kibibytes, or 1024 bytes),
+ * %M (for mebibytes, or 1048576 bytes),
+ * %G (for gibibytes, or 1073741824 bytes),
+ * %T (for tebibytes, or 1099511627776 bytes),
+ * %P (for pebibytes, or 1125899906842624 bytes),
+ * %E (for exbibytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
+ * the return value is the number multiplied by one kibibyte, one
+ * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng
---
changelog
v1->v2: replace kilobyte with kibibyte, and others
---
lib/cmdline.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..7cf5cb8 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with
+ * %K (for kibibytes, or 1024 bytes),
+ * %M (for mebibytes, or 1048576 bytes),
+ * %G (for gibibytes, or 1073741824),
+ * %T (for tebibytes, or 1099511627776),
+ * %P (for pebibytes, or 1125899906842624 bytes),
+ * %E (for exbibytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
+ * the return value is the number multiplied by one kibibyte, one
+ * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, , 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret <<= 10;
+ case 'P':
+ case 'p':
+ ret <<= 10;
+ case 'T':
+ case 't':
+ ret <<= 10;
case 'G':
case 'g':
ret <<= 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
changelog
v1-v2: replace kilobyte with kibibyte, and others
---
lib/cmdline.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..7cf5cb8 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
- * the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * potentially suffixed with
+ * %K (for kibibytes, or 1024 bytes),
+ * %M (for mebibytes, or 1048576 bytes),
+ * %G (for gibibytes, or 1073741824),
+ * %T (for tebibytes, or 1099511627776),
+ * %P (for pebibytes, or 1125899906842624 bytes),
+ * %E (for exbibytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
+ * the return value is the number multiplied by one kibibyte, one
+ * mebibyte, one gibibyte, one tebibyte, one pebibyte, one exbibyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] lib: add size unit t/p/e to memparse
On Mon, 2014-03-31 at 13:17 +0200, Brendan Hide wrote: > On 31/03/14 12:03, Gui Hecheng wrote: > > - * potentially suffixed with %K (for kilobytes, or 1024 bytes), > > - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or > > - * 1073741824). If the number is suffixed with K, M, or G, then > > + * potentially suffixed with > > + * %K (for kilobytes, or 1024 bytes), > > + * %M (for megabytes, or 1048576 bytes), > > + * %G (for gigabytes, or 1073741824), > > + * %T (for terabytes, or 1099511627776), > > + * %P (for petabytes, or 1125899906842624 bytes), > > + * %E (for exabytes, or 1152921504606846976 bytes). > > My apologies, I should have noticed this in your earlier mail. This > could be updated to specifically refer to the "bi"nary prefixes rather > than the old SI-conflicting names: > kibibyte, mebibyte, gibibyte, tebibyte, pebibyte, and exbibyte Yes, indeed, I will send a V2. Thanks! -Gui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng
---
lib/cmdline.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..20a55b0 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
+ * potentially suffixed with
+ * %K (for kilobytes, or 1024 bytes),
+ * %M (for megabytes, or 1048576 bytes),
+ * %G (for gigabytes, or 1073741824),
+ * %T (for terabytes, or 1099511627776),
+ * %P (for petabytes, or 1125899906842624 bytes),
+ * %E (for exabytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
* the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * megabyte, one gigabyte, one terabyte, one petabyte, one exabyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, , 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret <<= 10;
+ case 'P':
+ case 'p':
+ ret <<= 10;
+ case 'T':
+ case 't':
+ ret <<= 10;
case 'G':
case 'g':
ret <<= 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] lib: add size unit t/p/e to memparse
For modern filesystems such as btrfs, t/p/e size level operations
are common.
add size unit t/p/e parsing to memparse
Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com
---
lib/cmdline.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/lib/cmdline.c b/lib/cmdline.c
index eb67911..20a55b0 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -119,11 +119,17 @@ char *get_options(const char *str, int nints, int *ints)
* @retptr: (output) Optional pointer to next char after parse completes
*
* Parses a string into a number. The number stored at @ptr is
- * potentially suffixed with %K (for kilobytes, or 1024 bytes),
- * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or
- * 1073741824). If the number is suffixed with K, M, or G, then
+ * potentially suffixed with
+ * %K (for kilobytes, or 1024 bytes),
+ * %M (for megabytes, or 1048576 bytes),
+ * %G (for gigabytes, or 1073741824),
+ * %T (for terabytes, or 1099511627776),
+ * %P (for petabytes, or 1125899906842624 bytes),
+ * %E (for exabytes, or 1152921504606846976 bytes).
+ * If the number is suffixed with K, M, G, T, P, E, then
* the return value is the number multiplied by one kilobyte, one
- * megabyte, or one gigabyte, respectively.
+ * megabyte, one gigabyte, one terabyte, one petabyte, one exabyte,
+ * respectively.
*/
unsigned long long memparse(const char *ptr, char **retptr)
@@ -133,6 +139,15 @@ unsigned long long memparse(const char *ptr, char **retptr)
unsigned long long ret = simple_strtoull(ptr, endptr, 0);
switch (*endptr) {
+ case 'E':
+ case 'e':
+ ret = 10;
+ case 'P':
+ case 'p':
+ ret = 10;
+ case 'T':
+ case 't':
+ ret = 10;
case 'G':
case 'g':
ret = 10;
--
1.8.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] lib: add size unit t/p/e to memparse
On Mon, 2014-03-31 at 13:17 +0200, Brendan Hide wrote: On 31/03/14 12:03, Gui Hecheng wrote: - * potentially suffixed with %K (for kilobytes, or 1024 bytes), - * %M (for megabytes, or 1048576 bytes), or %G (for gigabytes, or - * 1073741824). If the number is suffixed with K, M, or G, then + * potentially suffixed with + * %K (for kilobytes, or 1024 bytes), + * %M (for megabytes, or 1048576 bytes), + * %G (for gigabytes, or 1073741824), + * %T (for terabytes, or 1099511627776), + * %P (for petabytes, or 1125899906842624 bytes), + * %E (for exabytes, or 1152921504606846976 bytes). My apologies, I should have noticed this in your earlier mail. This could be updated to specifically refer to the binary prefixes rather than the old SI-conflicting names: kibibyte, mebibyte, gibibyte, tebibyte, pebibyte, and exbibyte Yes, indeed, I will send a V2. Thanks! -Gui -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
