Re: [PATCH 2/4] lightnvm: move metadata mapping to lower level driver

2019-08-01 Thread Hans Holmberg
On Wed, Jul 31, 2019 at 3:59 PM Javier González wrote: > > > On 31 Jul 2019, at 11.41, Hans Holmberg wrote: > > > > Now that blk_rq_map_kern can map both kmem and vmem, move > > internal metadata mapping down to the lower level driver. > > > > Signed-off

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-02-04 Thread Hans Holmberg
On Mon, Feb 4, 2019 at 9:14 AM Javier González wrote: > > > > On 31 Jan 2019, at 21.10, Hans Holmberg wrote: > > > > On Thu, Jan 31, 2019 at 5:33 PM Javier González wrote: > >>> On 31 Jan 2019, at 11.41, Hans Holmberg wrote: > >>> > >>&

Re: [PATCH V2] lightnvm: pblk: fix race condition on GC

2019-02-04 Thread Hans Holmberg
Thanks Heiner, it's awesome to get this fixed! Reviewed-by: Hans Holmberg On Mon, Feb 4, 2019 at 9:19 AM Javier González wrote: > > > On 1 Feb 2019, at 03.38, Heiner Litz wrote: > > > > This patch fixes a race condition where a write is mapped to the last > > s

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-01-31 Thread Hans Holmberg
On Thu, Jan 31, 2019 at 5:33 PM Javier González wrote: > > > > > On 31 Jan 2019, at 11.41, Hans Holmberg wrote: > > > > Hi Javier! > > > > How did you test this? I'm trying to add a test case to our testing > > framework. > > > > This i

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-01-31 Thread Hans Holmberg
Hi Javier! How did you test this? I'm trying to add a test case to our testing framework. This is what i ran in qemu, and I got a hang (with this version of the patch) nvme lnvm create -d nvme0n1 -t pblk -n pblk0 -f -b 0 -e 0 kernel log: [ 116.381799] pblk pblk0: luns:1, lines:280,

Re: [EXT] [PATCH] lightnvm: pblk: extend line wp balance check

2019-01-29 Thread Hans Holmberg
-Original Message- > From: h...@owltronix.com > Sent: Tuesday, January 29, 2019 12:48 AM > To: Matias Bjorling > Cc: jav...@javigon.com; Zhoujie Wu ; > linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org; Hans Holmberg > > Subject: [EXT] [PATCH] lightn

Re: [PATCH] lightnvm: pblk: extend line wp balance check

2019-01-29 Thread Hans Holmberg
On Tue, Jan 29, 2019 at 4:03 PM Javier González wrote: > > > On 29 Jan 2019, at 13.49, Hans Holmberg wrote: > > > > On Tue, Jan 29, 2019 at 12:19 PM Javier González wrote: > >>> On 29 Jan 2019, at 09.47, h...@owltronix.com wrote: > >>> > >>

Re: [PATCH] lightnvm: pblk: extend line wp balance check

2019-01-29 Thread Hans Holmberg
On Tue, Jan 29, 2019 at 12:19 PM Javier González wrote: > > > > On 29 Jan 2019, at 09.47, h...@owltronix.com wrote: > > > > From: Hans Holmberg > > > > pblk stripes writes of minimal write size across all non-offline chunks > > in a line, which means t

Re: [PATCH] lightnvm: pblk: prevent stall due to wb threshold

2019-01-29 Thread Hans Holmberg
On Fri, Jan 25, 2019 at 2:08 PM Matias Bjørling wrote: > > On 1/25/19 11:09 AM, Javier González wrote: > > In order to respect mw_cuinits, pblk's write buffer maintains a > > backpointer to protect data not yet persisted; when writing to the write > > buffer, this backpointer defines a threshold

Re: [PATCH] lightnvm: pblk: stop taking the free lock in in pblk_lines_free

2019-01-25 Thread Hans Holmberg
On Thu, Jan 24, 2019 at 2:19 PM Javier González wrote: > > > On 22 Jan 2019, at 11.15, h...@owltronix.com wrote: > > > > From: Hans Holmberg > > > > pblk_line_meta_free might sleep (it can end up calling vfree, depending > > on how we allocate lba lists),

Re: [PATCH] lightnvm: pblk: fix TRACE_INCLUDE_PATH

2019-01-25 Thread Hans Holmberg
s/lightnvm is working by coincidence because the top > Makefile adds -I$(srctree)/arch/$(SRCARCH)/include as a header > search path, but we should not rely on it. Nice catch, thanks! Reviewed-by: Hans Holmberg > > Signed-off-by: Masahiro Yamada > --- > > drivers/lightnvm/pblk-trace.h |

[PATCH 4/4] lightnvm: pblk: add tracing for chunk resets

2018-08-29 Thread Hans Holmberg
From: Hans Holmberg Trace state of chunk resets. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-core.c | 12 drivers/lightnvm/pblk-trace.h | 31 +++ drivers/lightnvm/pblk.h | 6 ++ 3 files changed, 49 insertions(+) diff --git

[PATCH 4/4] lightnvm: pblk: add tracing for chunk resets

2018-08-29 Thread Hans Holmberg
From: Hans Holmberg Trace state of chunk resets. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-core.c | 12 drivers/lightnvm/pblk-trace.h | 31 +++ drivers/lightnvm/pblk.h | 6 ++ 3 files changed, 49 insertions(+) diff --git

[PATCH v2 2/3] lightnvm: pblk: garbage collect lines with failed writes

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Write failures should not happen under normal circumstances, so in order to bring the chunk back into a known state as soon as possible, evacuate all the valid data out of the line and let the fw judge if the block can be written to in th

[PATCH v2 2/3] lightnvm: pblk: garbage collect lines with failed writes

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg Write failures should not happen under normal circumstances, so in order to bring the chunk back into a known state as soon as possible, evacuate all the valid data out of the line and let the fw judge if the block can be written to in the next reset cycle. Do

[PATCH v2 1/3] lightnvm: pblk: rework write error recovery path

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> The write error recovery path is incomplete, so rework the write error recovery handling to do resubmits directly from the write buffer. When a write error occurs, the remaining sectors in the chunk are mapped out and invalidated and the r

[PATCH v2 1/3] lightnvm: pblk: rework write error recovery path

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg The write error recovery path is incomplete, so rework the write error recovery handling to do resubmits directly from the write buffer. When a write error occurs, the remaining sectors in the chunk are mapped out and invalidated and the request inserted in a resubmit list

[PATCH v2 0/3] Rework write error handling in pblk

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> This patch series fixes the(currently incomplete) write error handling in pblk by: * queuing and re-submitting failed writes in the write buffer * evacuating valid data data in lines with write failures, so the chunk(s) with write fa

[PATCH v2 3/3] lightnvm: pblk: fix smeta write error path

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Smeta write errors were previously ignored. Skip these lines instead and throw them back on the free list, so the chunks will go through a reset cycle before we attempt to use the line again. Signed-off-by: Hans Holmberg <h

[PATCH v2 0/3] Rework write error handling in pblk

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg This patch series fixes the(currently incomplete) write error handling in pblk by: * queuing and re-submitting failed writes in the write buffer * evacuating valid data data in lines with write failures, so the chunk(s) with write failures can be reset to a known state

[PATCH v2 3/3] lightnvm: pblk: fix smeta write error path

2018-04-23 Thread Hans Holmberg
From: Hans Holmberg Smeta write errors were previously ignored. Skip these lines instead and throw them back on the free list, so the chunks will go through a reset cycle before we attempt to use the line again. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-core.c | 7 --- 1 file

Re: [PATCH 2/3] lightnvm: pblk: garbage collect lines with failed writes

2018-04-23 Thread Hans Holmberg
On Fri, Apr 20, 2018 at 9:49 PM, Javier Gonzalez <jav...@cnexlabs.com> wrote: >> On 19 Apr 2018, at 09.39, Hans Holmberg <hans.ml.holmb...@owltronix.com> >> wrote: >> >> From: Hans Holmberg <hans.holmb...@cnexlabs.com> >> >> Write failur

Re: [PATCH 2/3] lightnvm: pblk: garbage collect lines with failed writes

2018-04-23 Thread Hans Holmberg
On Fri, Apr 20, 2018 at 9:49 PM, Javier Gonzalez wrote: >> On 19 Apr 2018, at 09.39, Hans Holmberg >> wrote: >> >> From: Hans Holmberg >> >> Write failures should not happen under normal circumstances, >> so in order to bring the chunk back into a kn

Re: [PATCH 1/3] lightnvm: pblk: rework write error recovery path

2018-04-23 Thread Hans Holmberg
On Fri, Apr 20, 2018 at 9:38 PM, Javier Gonzalez <jav...@cnexlabs.com> wrote: >> On 19 Apr 2018, at 09.39, Hans Holmberg <hans.ml.holmb...@owltronix.com> >> wrote: >> >> From: Hans Holmberg <hans.holmb...@cnexlabs.com> >> >> The write err

Re: [PATCH 1/3] lightnvm: pblk: rework write error recovery path

2018-04-23 Thread Hans Holmberg
On Fri, Apr 20, 2018 at 9:38 PM, Javier Gonzalez wrote: >> On 19 Apr 2018, at 09.39, Hans Holmberg >> wrote: >> >> From: Hans Holmberg >> >> The write error recovery path is incomplete, so rework >> the write error recovery handling to do resubmits dir

[PATCH 0/3] Rework write error handling in pblk

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> This patch series fixes the(currently incomplete) write error handling in pblk by: * queuing and re-submitting failed writes in the write buffer * evacuating valid data data in lines with write failures, so the chunk(s) with write fa

[PATCH 0/3] Rework write error handling in pblk

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg This patch series fixes the(currently incomplete) write error handling in pblk by: * queuing and re-submitting failed writes in the write buffer * evacuating valid data data in lines with write failures, so the chunk(s) with write failures can be reset to a known state

[PATCH 3/3] lightnvm: pblk: fix smeta write error path

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Smeta write errors were previously ignored. Skip these lines instead and throw them back on the free list, so the chunks will go through a reset cycle before we attempt to use the line again. Signed-off-by: Hans Holmberg <h

[PATCH 3/3] lightnvm: pblk: fix smeta write error path

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg Smeta write errors were previously ignored. Skip these lines instead and throw them back on the free list, so the chunks will go through a reset cycle before we attempt to use the line again. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-core.c | 7 --- 1 file

[PATCH 2/3] lightnvm: pblk: garbage collect lines with failed writes

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Write failures should not happen under normal circumstances, so in order to bring the chunk back into a known state as soon as possible, evacuate all the valid data out of the line and let the fw judge if the block can be written to in th

[PATCH 2/3] lightnvm: pblk: garbage collect lines with failed writes

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg Write failures should not happen under normal circumstances, so in order to bring the chunk back into a known state as soon as possible, evacuate all the valid data out of the line and let the fw judge if the block can be written to in the next reset cycle. Do

[PATCH 1/3] lightnvm: pblk: rework write error recovery path

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> The write error recovery path is incomplete, so rework the write error recovery handling to do resubmits directly from the write buffer. When a write error occurs, the remaining sectors in the chunk are mapped out and invalidated and the r

[PATCH 1/3] lightnvm: pblk: rework write error recovery path

2018-04-19 Thread Hans Holmberg
From: Hans Holmberg The write error recovery path is incomplete, so rework the write error recovery handling to do resubmits directly from the write buffer. When a write error occurs, the remaining sectors in the chunk are mapped out and invalidated and the request inserted in a resubmit list

[PATCH 0/2] pblk bugfixes

2018-04-16 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> This is a couple of bugfixes, nothing very urgent. Hans Holmberg (2): lightnvm: pblk: only try to recover lines with written smeta lightnvm: pblk: kick writer on new flush points drivers/lightnvm/pblk-cache.c| 10 ++ d

[PATCH 0/2] pblk bugfixes

2018-04-16 Thread Hans Holmberg
From: Hans Holmberg This is a couple of bugfixes, nothing very urgent. Hans Holmberg (2): lightnvm: pblk: only try to recover lines with written smeta lightnvm: pblk: kick writer on new flush points drivers/lightnvm/pblk-cache.c| 10 ++ drivers/lightnvm/pblk-core.c | 2

[PATCH 1/2] lightnvm: pblk: only try to recover lines with written smeta

2018-04-16 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> When switching between different lun configurations, there is no guarantee that all lines that contain closed/open chunks have some valid data to recover. Check that the smeta chunk has been written to instead. Also skip bad lines (tha

[PATCH 2/2] lightnvm: pblk: kick writer on new flush points

2018-04-16 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Unless we kick the writer directly when setting a new flush point, the user risks having to wait for up to one second (the default timeout for the write thread to be kicked) for the IO to complete. Signed-off-by: Hans Holmberg <h

[PATCH 1/2] lightnvm: pblk: only try to recover lines with written smeta

2018-04-16 Thread Hans Holmberg
From: Hans Holmberg When switching between different lun configurations, there is no guarantee that all lines that contain closed/open chunks have some valid data to recover. Check that the smeta chunk has been written to instead. Also skip bad lines (that does not have enough good chunks

[PATCH 2/2] lightnvm: pblk: kick writer on new flush points

2018-04-16 Thread Hans Holmberg
From: Hans Holmberg Unless we kick the writer directly when setting a new flush point, the user risks having to wait for up to one second (the default timeout for the write thread to be kicked) for the IO to complete. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-cache.c | 10

Re: [PATCH 4/5] lightnvm: pblk: add padding distribution sysfs attribute

2018-02-06 Thread Hans Holmberg
On Tue, Feb 6, 2018 at 11:50 AM, Matias Bjørling <m...@lightnvm.io> wrote: > On 02/06/2018 10:27 AM, Hans Holmberg wrote: >> >> Hi Matias, >> >> On Wed, Jan 31, 2018 at 9:44 AM, Matias Bjørling <m...@lightnvm.io> wrote: >>> >>> On 01/31/

Re: [PATCH 4/5] lightnvm: pblk: add padding distribution sysfs attribute

2018-02-06 Thread Hans Holmberg
On Tue, Feb 6, 2018 at 11:50 AM, Matias Bjørling wrote: > On 02/06/2018 10:27 AM, Hans Holmberg wrote: >> >> Hi Matias, >> >> On Wed, Jan 31, 2018 at 9:44 AM, Matias Bjørling wrote: >>> >>> On 01/31/2018 03:06 AM, Javier González wrote: >>&g

Re: [PATCH 4/5] lightnvm: pblk: add padding distribution sysfs attribute

2018-02-06 Thread Hans Holmberg
Hi Matias, On Wed, Jan 31, 2018 at 9:44 AM, Matias Bjørling <m...@lightnvm.io> wrote: > On 01/31/2018 03:06 AM, Javier González wrote: >> >> From: Hans Holmberg <hans.holmb...@cnexlabs.com> >> >> When pblk receives a sync, all data up to that point

Re: [PATCH 4/5] lightnvm: pblk: add padding distribution sysfs attribute

2018-02-06 Thread Hans Holmberg
Hi Matias, On Wed, Jan 31, 2018 at 9:44 AM, Matias Bjørling wrote: > On 01/31/2018 03:06 AM, Javier González wrote: >> >> From: Hans Holmberg >> >> When pblk receives a sync, all data up to that point in the write buffer >> must be comitted to persistent s

[PATCH v2] lightnvm: pblk: clear flush point on completed writes

2017-12-28 Thread Hans Holmberg
Move completion of syncs and clearing of flush points to the write completion path - this ensures that the data has been comitted to the media before completing bios containing syncs. Signed-off-by: Hans Holmberg <hans.holmb...@cnexlabs.com> Signed-off-by: Javier González <jav...@cne

[PATCH v2] lightnvm: pblk: clear flush point on completed writes

2017-12-28 Thread Hans Holmberg
Move completion of syncs and clearing of flush points to the write completion path - this ensures that the data has been comitted to the media before completing bios containing syncs. Signed-off-by: Hans Holmberg Signed-off-by: Javier González --- Changes since v1: * Fixed an off-by one issue

[PATCH] lightnvm: pblk: remove spinlock when freeing line metadata

2017-10-05 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Lockdep complains about being in atomic context while freeing line metadata - and rightly so as we take a spinlock and end up calling vfree that might sleep(in pblk_mfree). There is no need for holding the line manager free_lock while freein

[PATCH] lightnvm: pblk: remove spinlock when freeing line metadata

2017-10-05 Thread Hans Holmberg
From: Hans Holmberg Lockdep complains about being in atomic context while freeing line metadata - and rightly so as we take a spinlock and end up calling vfree that might sleep(in pblk_mfree). There is no need for holding the line manager free_lock while freeing line metadata, so remove

Re: [PATCH] lightnvm: pblk: use vfree_atomic when freeing line metadata

2017-10-03 Thread Hans Holmberg
Thanks for the review Andrey, i'll send a new patch removing the lock.

Re: [PATCH] lightnvm: pblk: use vfree_atomic when freeing line metadata

2017-10-03 Thread Hans Holmberg
Thanks for the review Andrey, i'll send a new patch removing the lock.

Re: [PATCH 0/9] recovery robustness improvements

2017-10-03 Thread Hans Holmberg
Cheers! Thanks, Hans On Tue, Oct 3, 2017 at 12:51 PM, Javier González <j...@lightnvm.io> wrote: >> On 3 Oct 2017, at 12.05, Hans Holmberg <hans.ml.holmb...@owltronix.com> >> wrote: >> >> From: Hans Holmberg <hans.holmb...@cnexlabs.com> >> >

Re: [PATCH 0/9] recovery robustness improvements

2017-10-03 Thread Hans Holmberg
Cheers! Thanks, Hans On Tue, Oct 3, 2017 at 12:51 PM, Javier González wrote: >> On 3 Oct 2017, at 12.05, Hans Holmberg >> wrote: >> >> From: Hans Holmberg >> >> This patchset improves the robustness of recovery - fixing a bunch of >> issues that o

[PATCH] lightnvm: pblk: use vfree_atomic when freeing line metadata

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> The commit bf22e37a6413 ("mm: add vfree_atomic()") made vfree unsafe to call in atomic context (unless the call came from an interrupt) and introduced vfree_atomic that is safe to call in atomic context. So, since we're holding lo

[PATCH] lightnvm: pblk: use vfree_atomic when freeing line metadata

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg The commit bf22e37a6413 ("mm: add vfree_atomic()") made vfree unsafe to call in atomic context (unless the call came from an interrupt) and introduced vfree_atomic that is safe to call in atomic context. So, since we're holding locks when freeing line metadat

[PATCH 1/9] lightnvm: pblk: prevent gc kicks when gc is not operational

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> GC can be kicked after it has been shut down when closing the last line during exit, resulting in accesses to freed structures. Make sure that GC is not triggered while it is not operational. Also make sure that GC won't be re-activated

[PATCH 1/9] lightnvm: pblk: prevent gc kicks when gc is not operational

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg GC can be kicked after it has been shut down when closing the last line during exit, resulting in accesses to freed structures. Make sure that GC is not triggered while it is not operational. Also make sure that GC won't be re-activated during exit when running on another

[PATCH 2/9] lightnvm: pblk: recover partially written lines correctly

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> When recovering partially written lines, the valid sector count must be decreased by the number of padded sectors in the line. Update line recovery to take all ADDR_EMPTY(padded) sectors into account. Signed-off-by: Hans Holmberg <h

[PATCH 2/9] lightnvm: pblk: recover partially written lines correctly

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg When recovering partially written lines, the valid sector count must be decreased by the number of padded sectors in the line. Update line recovery to take all ADDR_EMPTY(padded) sectors into account. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-recovery.c | 8

[PATCH 5/9] lightnvm: pblk: consider bad sectors in emeta during recovery

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> When recovering lines we need to consider that bad blocks in a line affects the emeta area size. Previously it was assumed that the emeta area would grow by the number of sectors per page * number of bad blocks in the line. This ass

[PATCH 5/9] lightnvm: pblk: consider bad sectors in emeta during recovery

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg When recovering lines we need to consider that bad blocks in a line affects the emeta area size. Previously it was assumed that the emeta area would grow by the number of sectors per page * number of bad blocks in the line. This assumtion not correct - the number of "

[PATCH 6/9] lightnvm: pblk: shut down gc gracefully during exit

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Shut down the GC workqueues and tasks in the right order. Signed-off-by: Hans Holmberg <hans.holmb...@cnexlabs.com> --- drivers/lightnvm/pblk-gc.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --g

[PATCH 6/9] lightnvm: pblk: shut down gc gracefully during exit

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Shut down the GC workqueues and tasks in the right order. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-gc.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index

[PATCH 3/9] lightnvm: pblk: free full lines during recovery

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> When rebuilding the L2P table, any full lines(lines without any valid sectors) will be identified. If these lines are not freed, we risk not being able to allocate the first data line. This patch refactors the part of GC that frees empty

[PATCH 3/9] lightnvm: pblk: free full lines during recovery

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg When rebuilding the L2P table, any full lines(lines without any valid sectors) will be identified. If these lines are not freed, we risk not being able to allocate the first data line. This patch refactors the part of GC that frees empty lines into a separate function

[PATCH 7/9] lightnvm: pblk: add l2p crc debug printouts

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Print the CRC of the logical-to-physical mapping during exit and after recovering the L2P table to facilitate detection of meta data corruption/recovery issues. The CRC printed after recovery should match the CRC printed during the previou

[PATCH 7/9] lightnvm: pblk: add l2p crc debug printouts

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Print the CRC of the logical-to-physical mapping during exit and after recovering the L2P table to facilitate detection of meta data corruption/recovery issues. The CRC printed after recovery should match the CRC printed during the previous exit - if it doesn't

[PATCH 8/9] lightnvm: pblk: gc all lines in the pipeline before exit

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Finish garbage collect of the lines that are in the gc pipeline before exiting. Ensure that all lines already in in the pipeline goes through, from read to write. Do this by keeping track of how many lines are in the pipeline and w

[PATCH 8/9] lightnvm: pblk: gc all lines in the pipeline before exit

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Finish garbage collect of the lines that are in the gc pipeline before exiting. Ensure that all lines already in in the pipeline goes through, from read to write. Do this by keeping track of how many lines are in the pipeline and waiting for that number to reach zero before

[PATCH 9/9] lightnvm: pblk: correct valid lba count calculation

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> During garbage collect, lbas being written can end up being invalidated. Make sure that this is reflected in the valid lba count. Signed-off-by: Hans Holmberg <hans.holmb...@cnexlabs.com> --- drivers/lightnvm/pblk-map.c | 7 +++

[PATCH 4/9] lightnvm: pblk: start gc if needed during init

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> Start GC, if needed, directly after init, as we might need to garbage collect to make room for user writes. Signed-off-by: Hans Holmberg <hans.holmb...@cnexlabs.com> --- drivers/lightnvm/pblk-init.c | 4 1 file changed, 4 inserti

[PATCH 9/9] lightnvm: pblk: correct valid lba count calculation

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg During garbage collect, lbas being written can end up being invalidated. Make sure that this is reflected in the valid lba count. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-map.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 4/9] lightnvm: pblk: start gc if needed during init

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Start GC, if needed, directly after init, as we might need to garbage collect to make room for user writes. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-init.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm

[PATCH 0/9] recovery robustness improvements

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg <hans.holmb...@cnexlabs.com> This patchset improves the robustness of recovery - fixing a bunch of issues that occurs when removing and re-creating a pblk instance. It also adds a couple of debug-only prints to facilitate detection of L2P table corruptions. The patches

[PATCH 0/9] recovery robustness improvements

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg This patchset improves the robustness of recovery - fixing a bunch of issues that occurs when removing and re-creating a pblk instance. It also adds a couple of debug-only prints to facilitate detection of L2P table corruptions. The patches apply on top of: https

[PATCH v2] lib/Kconfig.debug: correct documentation paths

2017-03-16 Thread Hans Holmberg
A bunch of documentation files have moved, correct the paths. Signed-off-by: Hans Holmberg <h...@pixelmunchies.com> --- Changes in v2: - Rebased on top of 4.11-rc2 (one of the paths was fixed by another patch) lib/Kconfig.debug | 9 + 1 file changed, 5 insertions

[PATCH v2] lib/Kconfig.debug: correct documentation paths

2017-03-16 Thread Hans Holmberg
A bunch of documentation files have moved, correct the paths. Signed-off-by: Hans Holmberg --- Changes in v2: - Rebased on top of 4.11-rc2 (one of the paths was fixed by another patch) lib/Kconfig.debug | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib

Re: [PATCH] lib/Kconfig.debug: correct documentation paths

2017-03-16 Thread Hans Holmberg
On Fri, Feb 24, 2017 at 10:21:35AM -0700, Jonathan Corbet wrote: > On Fri, 24 Feb 2017 10:36:20 +0200 > Krzysztof Kozlowski wrote: > > > What happened with this patch? I am asking because on top of > > next-20170224 I found some more sysrq.txt obsolete paths... including > > the

Re: [PATCH] lib/Kconfig.debug: correct documentation paths

2017-03-16 Thread Hans Holmberg
On Fri, Feb 24, 2017 at 10:21:35AM -0700, Jonathan Corbet wrote: > On Fri, 24 Feb 2017 10:36:20 +0200 > Krzysztof Kozlowski wrote: > > > What happened with this patch? I am asking because on top of > > next-20170224 I found some more sysrq.txt obsolete paths... including > > the ones fixed here.

[RFC PATCH v3] Input: gpio_keys - add dt abs/rel button support

2017-02-09 Thread Hans Holmberg
keys when all buttons of the same type and axis are released. This is a must-have for supporting digital joysticks. Finally, report min/max values for abs axes to the input framework. Signed-off-by: Hans Holmberg <h...@pixelmunchies.com> --- Thanks for your comments, Rob, Dimitry. Changes si

[RFC PATCH v3] Input: gpio_keys - add dt abs/rel button support

2017-02-09 Thread Hans Holmberg
keys when all buttons of the same type and axis are released. This is a must-have for supporting digital joysticks. Finally, report min/max values for abs axes to the input framework. Signed-off-by: Hans Holmberg --- Thanks for your comments, Rob, Dimitry. Changes since v2: * 0 is now only

[PATCH] regulator: gpio-regulator: doc: correct default type

2017-02-03 Thread Hans Holmberg
The driver defaults to voltage, not current, type so correct this in the device tree binding documentation. Signed-off-by: Hans Holmberg <h...@pixelmunchies.com> --- See drivers/regulator/gpio-regulator.c:231 ..and the example in the binding doc is voltage regulator without regulato

[PATCH] regulator: gpio-regulator: doc: correct default type

2017-02-03 Thread Hans Holmberg
The driver defaults to voltage, not current, type so correct this in the device tree binding documentation. Signed-off-by: Hans Holmberg --- See drivers/regulator/gpio-regulator.c:231 ..and the example in the binding doc is voltage regulator without regulator-type specified. Documentation

Re: [RFC PATCH v2] Input: gpio_keys - add dt abs/rel button support

2017-02-02 Thread Hans Holmberg
On Wed, Feb 01, 2017 at 11:25:31AM -0600, Rob Herring wrote: > On Tue, Jan 31, 2017 at 08:55:19AM +0100, Hans Holmberg wrote: > > + > > + gpio-joystick: { > > Why do we need a whole new example? I found it motivated to describe a use case with the new property, since it i

Re: [RFC PATCH v2] Input: gpio_keys - add dt abs/rel button support

2017-02-02 Thread Hans Holmberg
On Wed, Feb 01, 2017 at 11:25:31AM -0600, Rob Herring wrote: > On Tue, Jan 31, 2017 at 08:55:19AM +0100, Hans Holmberg wrote: > > + > > + gpio-joystick: { > > Why do we need a whole new example? I found it motivated to describe a use case with the new property, since it i

[RFC PATCH v2] Input: gpio_keys - add dt abs/rel button support

2017-01-30 Thread Hans Holmberg
keys. This is a must-have for supporting digital joysticks, and aligns the driver whith gpio-keys-polled. Finally, report min/max values for abs axes to the input framework. Signed-off-by: Hans Holmberg <h...@pixelmunchies.com> --- RFC because it alters the behaviour of abs-buttons making t

[RFC PATCH v2] Input: gpio_keys - add dt abs/rel button support

2017-01-30 Thread Hans Holmberg
keys. This is a must-have for supporting digital joysticks, and aligns the driver whith gpio-keys-polled. Finally, report min/max values for abs axes to the input framework. Signed-off-by: Hans Holmberg --- RFC because it alters the behaviour of abs-buttons making them un-sticky, reporting 0

[PATCH] lib/Kconfig.debug: correct documentation paths

2016-12-13 Thread Hans Holmberg
A bunch of documentation files have moved, correct the paths. Signed-off-by: Hans Holmberg <h...@pixelmunchies.com> --- lib/Kconfig.debug | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index e6327d1..18ffa80

[PATCH] lib/Kconfig.debug: correct documentation paths

2016-12-13 Thread Hans Holmberg
A bunch of documentation files have moved, correct the paths. Signed-off-by: Hans Holmberg --- lib/Kconfig.debug | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index e6327d1..18ffa80 100644 --- a/lib/Kconfig.debug

[PATCH] Input: only send a syn event when needed in input_dev_release_keys

2015-08-26 Thread Hans Holmberg
A SYN event is reported in input_release_keys even if no keys are released. Stop doing this as the superfluous event can prevent autosleep if a user has opened a device with EPOLLWAKEUP enabled. Based on a patch developed by Ting Li . Signed-off-by: Hans Holmberg --- drivers/input/input.c | 12

[PATCH] Input: only send a syn event when needed in input_dev_release_keys

2015-08-26 Thread Hans Holmberg
A SYN event is reported in input_release_keys even if no keys are released. Stop doing this as the superfluous event can prevent autosleep if a user has opened a device with EPOLLWAKEUP enabled. Based on a patch developed by Ting Li ting...@intel.com. Signed-off-by: Hans Holmberg hans.holmb

[PATCH] gpiolib: of: allow of_gpiochip_find_and_xlate to find more than one chip per node

2015-02-10 Thread Hans Holmberg
to not stop looking for chips if a node-match is found and the translation fails. Signed-off-by: Hans Holmberg --- drivers/gpio/gpiolib-of.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 08261f2..26645a8 100644

[PATCH] gpiolib: of: allow of_gpiochip_find_and_xlate to find more than one chip per node

2015-02-10 Thread Hans Holmberg
to not stop looking for chips if a node-match is found and the translation fails. Signed-off-by: Hans Holmberg hans.holmb...@intel.com --- drivers/gpio/gpiolib-of.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index