Re: [PATCH 2/5] media: dt-bindings: Add binding for si470x radio

2018-12-07 Thread Hans Verkuil
Please combine 2/5 with 5/5. No need to have two patches for these bindings. Regards, Hans On 12/05/2018 04:47 PM, Paweł Chmiel wrote: > Add device tree bindings for si470x family radio receiver driver. > > Signed-off-by: Paweł Chmiel > --- > .../devicetree/bindings/media/si470x.txt

Re: [PATCH v4] media: vivid: Improve timestamping

2018-12-03 Thread Hans Verkuil
On 12/02/2018 09:43 PM, Arnd Bergmann wrote: > On Sun, Dec 2, 2018 at 2:47 PM Gabriel Francisco Mandaji > wrote: > >> @@ -667,10 +653,28 @@ static void vivid_overlay(struct vivid_dev *dev, >> struct vivid_buffer *buf) >> } >> } >> >> +static void vivid_cap_update_frame_period(struct

Re: [PATCH] media: videobuf2-core: fix use after free in vb2_mmap

2018-11-17 Thread Hans Verkuil
Same patch was already posted and is waiting to be merged: https://patchwork.linuxtv.org/patch/52944/ Regards, Hans On 11/17/2018 12:42 AM, Sudip Mukherjee wrote: > When we are using __find_plane_by_offset() to find the matching plane > number and the buffer, the queue is not locked.

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-11-15 Thread Hans Verkuil
On 10/22/2018 04:48 PM, Tomasz Figa wrote: > Due to complexity of the video decoding process, the V4L2 drivers of > stateful decoder hardware require specific sequences of V4L2 API calls > to be followed. These include capability enumeration, initialization, > decoding, seek, pause, dynamic

Re: [PATCH v4 2/2] media: platform: Add Aspeed Video Engine driver

2018-10-12 Thread Hans Verkuil
On 10/05/2018 09:57 PM, Eddie James wrote: > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting a service processor, the Video Engine can capture > the host processor graphics

Re: [PATCH v3 0/3] Add Amlogic video decoder driver

2018-10-01 Thread Hans Verkuil
On 09/28/2018 04:28 PM, Maxime Jourdan wrote: > Hi everyone, > > This patch series adds support for the Amlogic video decoder, > as well as the corresponding dt bindings for GXBB/GXL/GXM chips. > > It features decoding for the following formats: > - MPEG 1 > - MPEG 2 > > The following formats

Re: gpio regression in linux-next

2018-09-17 Thread Hans Verkuil
On 09/17/2018 02:49 PM, Heikki Krogerus wrote: > Hi, > > I hit a BUG while attempting to unload fusb302 driver module on my > Intel CHT board (GPDWin). I bisected it to commit: > > 461c1a7d4733 ("gpiolib: override irq_enable/disable") Does your linux-next have this patch:

Re: [PATCH v2 2/2] media: platform: Add Aspeed Video Engine driver

2018-09-14 Thread Hans Verkuil
On 09/14/2018 05:22 PM, Eddie James wrote: >>> +static int aspeed_video_allocate_cma(struct aspeed_video *video) >>> +{ >>> + video->srcs[0].virt = dma_alloc_coherent(video->dev, >>> +VE_SRC_BUFFER_SIZE, >>> +

Re: [RFC PATCH] media: docs-rst: Document m2m stateless video decoder interface

2018-09-10 Thread Hans Verkuil
Hi Alexandre, Thank you very much for working on this, much appreciated! On 08/31/2018 09:47 AM, Alexandre Courbot wrote: > This patch documents the protocol that user-space should follow when > communicating with stateless video decoders. It is based on the > following references: > > * The

Re: [PATCH 0/2] Document memory-to-memory video codec interfaces

2018-09-10 Thread Hans Verkuil
Hi Tomasz, On 07/24/2018 04:06 PM, Tomasz Figa wrote: > This series attempts to add the documentation of what was discussed > during Media Workshops at LinuxCon Europe 2012 in Barcelona and then > later Embedded Linux Conference Europe 2014 in Düsseldorf and then > eventually written down by

Re: v4.19-rc0: compile problem in ./include/media/cec.h:82:24:

2018-08-23 Thread Hans Verkuil
On 22/08/18 23:12, Pavel Machek wrote: > Hi! > >> I'm getting this in -rc0: >> >> CC drivers/gpu/drm/ttm/ttm_tt.o >> In file included from ./include/media/cec-notifier.h:13:0, >>from drivers/gpu/drm/i915/intel_drv.h:42, >> from >>

Re: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC

2018-08-03 Thread Hans Verkuil
On 08/03/2018 12:58 AM, Mauro Carvalho Chehab wrote: > Em Tue, 24 Jul 2018 11:35:59 +0200 > Arnd Bergmann escreveu: > >> Without the MFD driver, we run into a link error: > > Weird... I'm not seeing this driver at the media tree... was it merged via > some other tree? Yes, it's going via the

Re: [PATCH 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2018-07-25 Thread Hans Verkuil
On 24/07/18 16:06, Tomasz Figa wrote: > Due to complexity of the video encoding process, the V4L2 drivers of > stateful encoder hardware require specific sequences of V4L2 API calls > to be followed. These include capability enumeration, initialization, > encoding, encode parameters change, drain

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-07-25 Thread Hans Verkuil
URE`` queue. In particular, it also > + means that ``CAPTURE`` format may be reset and the client must not that -> that the > + rely on the previously set format being preserved. > + > +2. Enumerating formats on ``CAPTURE`` queue must only return formats > + supported for

Re: [PATCH v7 6/6] [media] cxusb: add analog mode support for Medion MD95700

2018-07-17 Thread Hans Verkuil
On 10/07/18 23:48, Maciej S. Szmigiero wrote: > Hi Hans, > > On 04.07.2018 11:33, Hans Verkuil wrote: >> Hi Maciej, >> >> On 02/07/18 23:23, Maciej S. Szmigiero wrote: > (..) >>> +static int cxusb_medion_v_queue_setup(struct vb2_queue *q, >>>

Re: [PATCH v7 0/6] Add ChromeOS EC CEC Support

2018-06-11 Thread Hans Verkuil
On 11/06/18 10:56, Neil Armstrong wrote: > Hi Lee, > > On 11/06/2018 08:03, Lee Jones wrote: >> On Fri, 08 Jun 2018, Hans Verkuil wrote: >>> On 08/06/18 10:17, Neil Armstrong wrote: >>>> On 08/06/2018 09:53, Hans Verkuil wrote: >>>>> On 06/01

Re: [PATCH v2 1/2] media: v4l2-ctrl: Add control for VP9 profile

2018-06-11 Thread Hans Verkuil
>> >> >> >> Le ven. 8 juin 2018 08:56, Stanimir Varbanov >> a écrit : >>> >>> Hi Hans, >>> >>> On 06/08/2018 12:29 PM, Hans Verkuil wrote: >>>> On 05/30/2018 09:16 AM, Keiichi Watanabe wrote: >>>>> Ad

Re: [PATCH v2] media: staging: tegra-vde: Reset memory client

2018-05-29 Thread Hans Verkuil
Hi Dmitry, On 05/26/2018 04:27 PM, Dmitry Osipenko wrote: > DMA requests must be blocked before resetting VDE HW, otherwise it is > possible to get a memory corruption or a machine hang. Use the reset > control provided by the Memory Controller to block DMA before resetting > the VDE HW. > >

Re: [PATCH] media: v4l2-ctrl: Add control for VP9 profile

2018-05-25 Thread Hans Verkuil
On 17/05/18 11:53, Keiichi Watanabe wrote: > Add a new control V4L2_CID_MPEG_VIDEO_VP9_PROFILE for selecting desired > profile for VP9 encoder and querying for supported profiles by VP9 encoder > or decoder. > > An existing control V4L2_CID_MPEG_VIDEO_VPX_PROFILE cannot be > used for querying

Re: [PATCH 2/3] gspca_zc3xx: Fix power line frequency settings for OV7648

2018-05-25 Thread Hans Verkuil
On 24/05/18 17:09, Ondrej Zary wrote: > Power line frequency settings for OV7648 sensor contain autogain > and exposure commands, affecting unrelated controls. Remove them. > > Signed-off-by: Ondrej Zary > --- > drivers/media/usb/gspca/zc3xx.c | 17 ++---

Re: [PATCH v6 5/6] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-24 Thread Hans Verkuil
abora.com> For whatever it is worth: Acked-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans > --- > drivers/mfd/cros_ec_dev.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c >

Re: [PATCH v6 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Hans Verkuil
On 24/05/18 11:57, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> > Tested-by: Enric Balletbo i Serra <enric.balle...@collabora

Re: [PATCH v5 4/6] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-24 Thread Hans Verkuil
On 24/05/18 10:54, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > > Signed-off-by: Neil Armstrong > Tested-by: Enric Balletbo i Serra > --- >

Re: [PATCH v5 6/6] media: platform: Add ChromeOS EC CEC driver

2018-05-24 Thread Hans Verkuil
or name. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> > Reviewed-by: Enric Balletbo i Serra <enric.balle...@collabora.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans > --- > drivers/media/platform/Kconfig

Re: [PATCH v5 1/6] media: cec-notifier: Get notifier by device and connector name

2018-05-24 Thread Hans Verkuil
gned-off-by: Neil Armstrong <narmstr...@baylibre.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans > --- > drivers/media/cec/cec-notifier.c | 11 --- > include/media/cec-notifier.h | 27 --- > 2 files changed

Re: [PATCH v10 08/16] v4l: mark unordered formats

2018-05-23 Thread Hans Verkuil
On 23/05/18 12:30, Ezequiel Garcia wrote: > On Tue, 2018-05-22 at 13:55 +0200, Hans Verkuil wrote: >> On 21/05/18 18:59, Ezequiel Garcia wrote: >>> From: Gustavo Padovan <gustavo.pado...@collabora.com> >>> >>> Now that we've introduced the V4L2_FMT_FLA

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Hans Verkuil
On 22/05/18 18:22, Ezequiel Garcia wrote: >>> @@ -1615,7 +1762,12 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) >>> return; >>> >>> vb->state = VB2_BUF_STATE_DEQUEUED; >>> - >>> + if (vb->in_fence) { >>> + if (dma_fence_remove_callback(vb->in_fence, >fence_cb))

Re: [PATCH v10 13/16] vb2: add out-fence support to QBUF

2018-05-22 Thread Hans Verkuil
it confusing. > > v11: - Return fence_fd to userpace only in the QBUF ioctl. > - Rework implementation to avoid storing the sync_file >as state, which is not really needed. > > v10: - use -EIO for fence error (Hans Verkuil) > - add comment around fence cont

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Hans Verkuil
- print noisy warning on unexpected enqueue conditioin > - schedule a vb2_start_streaming work from the fence callback > > v12: fixed dvb_vb2.c usage of vb2_core_qbuf. > > v11: - minor doc/comments fixes (Hans Verkuil) > - reviewed the in-fence path at __fill_v4l2_buffe

Re: [PATCH v10 11/16] vb2: add explicit fence user API

2018-05-22 Thread Hans Verkuil
t; Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used > when sending an in-fence to the kernel to be waited on, and > V4L2_BUF_FLAG_OUT_FENCE, to ask the kernel to give back an out-fence. > > v8: return -1 if new flags are set. > v7: minor fixes on the Documentation (Hans Verk

Re: [PATCH v10 09/16] cobalt: add .is_unordered() for cobalt

2018-05-22 Thread Hans Verkuil
On 21/05/18 18:59, Ezequiel Garcia wrote: > From: Gustavo Padovan > > The cobalt driver may reorder the capture buffers so we need to report > it as such. > > v3: set formats as unordered > v2: use vb2_ops_set_unordered() helper > > Signed-off-by: Gustavo Padovan

Re: [PATCH v10 08/16] v4l: mark unordered formats

2018-05-22 Thread Hans Verkuil
On 21/05/18 18:59, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, > mark the appropriate formats. > > v2: Set unordered flag before calling the driver callback. > > Signed-off-by: Gustavo Padovan

Re: [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > driver for such feature of the Embedded Controller. > > This driver is part of the cros-ec MFD and will be add as a sub-device when > the feature bit is exposed by the EC.

Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> For what it is worth (not an MFD expert): Acked-by: Hans

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly inside the mkbp event > instead of

Re: [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Hans Verkuil
HPD changes > to an eventual CEC adapter. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> Reviewed-by: Hans Verkuil <hans.verk...@cisco.com> Thanks! Hans > --- > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/i915/intel_drv.h | 2 ++

Re: [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Hans Verkuil
On 05/15/2018 04:42 PM, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function by using the device name > instead and will not create a

Re: [PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
Some small comments below: On 05/15/18 14:47, Neil Armstrong wrote: > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > driver for such feature of the Embedded Controller. > > This driver is part of the cros-ec MFD and will be add as a sub-device when > the feature bit

Re: [PATCH 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Hans Verkuil
On 05/15/18 14:46, Neil Armstrong wrote: > This patchs adds the cec_notifier feature to the intel_hdmi part > of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate > between each HDMI ports. > The changes will allow the i915 HDMI code to notify EDID and HPD changes > to an

Re: [PATCH 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Hans Verkuil
Hi Neil, Two small comments below: On 05/15/18 14:46, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function by using the device name >

Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
On 05/15/18 10:28, Neil Armstrong wrote: > + int ret; > + > + cros_ec_cec = devm_kzalloc(>dev, sizeof(*cros_ec_cec), > +GFP_KERNEL); > + if (!cros_ec_cec) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, cros_ec_cec); >

Re: [PATCH v2 00/29] Venus updates

2018-05-15 Thread Hans Verkuil
Hi Stanimir, On 05/15/18 09:58, Stanimir Varbanov wrote: > Hello, > > Here is v2 with following comments addressed: > > * reworked venus suspend 3xx and reuse it for 4xx. > * drop 10/28 patch from v1, i.e. call of session_continue when > buffer requirements are not sufficient. > * fixed

Re: [PATCH v2 27/29] venus: implementing multi-stream support

2018-05-15 Thread Hans Verkuil
Hi Stanimir, On 05/15/18 09:58, Stanimir Varbanov wrote: > This is implementing a multi-stream decoder support. The multi > stream gives an option to use the secondary decoder output > with different raw format (or the same in case of crop). You told me that multi-stream support is currently

Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
On 05/15/18 09:25, Neil Armstrong wrote: > Hi Hans, > > Thanks for the extensive review. > > On 15/05/2018 08:58, Hans Verkuil wrote: >> On 05/15/2018 12:40 AM, Neil Armstrong wrote: >>> The Chrome OS Embedded Controller can expose a CEC bus, this patch add t

Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-15 Thread Hans Verkuil
On 05/15/2018 12:40 AM, Neil Armstrong wrote: > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the > driver for such feature of the Embedded Controller. > > This driver is part of the cros-ec MFD and will be add as a sub-device when > the feature bit is exposed by the EC.

Re: [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Hans Verkuil
On 05/15/2018 12:40 AM, Neil Armstrong wrote: > This patchs adds the cec_notifier feature to the intel_hdmi part > of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate > between each HDMI ports. > The changes will allow the i915 HDMI code to notify EDID and HPD changes > to

Re: [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi

2018-05-15 Thread Hans Verkuil
On 05/15/2018 12:40 AM, Neil Armstrong wrote: > This patchs adds the cec_notifier feature to the intel_hdmi part > of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate > between each HDMI ports. > The changes will allow the i915 HDMI code to notify EDID and HPD changes > to

Re: [RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name

2018-05-15 Thread Hans Verkuil
Hi Neil, Thanks for this patch series! Some comments below: On 05/15/2018 12:40 AM, Neil Armstrong wrote: > In non device-tree world, we can need to get the notifier by the driver > name directly and eventually defer probe if not yet created. > > This patch adds a variant of the get function

Re: [PATCH 1/5] media: docs: selection: fix typos

2018-05-13 Thread Hans Verkuil
Hi Luca, My apologies for the long delay in reviewing this. It all looks very good and if you can post a v2 with these small issues fixed, then I'll merge it for 4.18. Regards, Hans On 05/13/2018 11:13 AM, Hans Verkuil wrote: > On 04/03/2018 11:15 PM, Luca Ceresoli wrote: > &g

Re: [PATCH 3/5] media: docs: selection: rename files to something meaningful

2018-05-13 Thread Hans Verkuil
On 04/03/2018 11:15 PM, Luca Ceresoli wrote: > These files have an automatically-generated numbering. Replaname them Replaname -> Replace > to something that suggests their meaning. to -> with Regards, Hans > > Reported-by: Hans Verkuil <hverk...@xs4all.nl> &

Re: [PATCH 1/5] media: docs: selection: fix typos

2018-05-13 Thread Hans Verkuil
On 04/03/2018 11:15 PM, Luca Ceresoli wrote: Please add a commit message here. Yes, it can be as simple as 'Fixed typos in the selection documentation.' Regards, Hans > Cc: Hans Verkuil <hverk...@xs4all.nl> > Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net> >

Re: [PATCH 2/5] media: docs: clarify relationship between crop and selection APIs

2018-05-13 Thread Hans Verkuil
p the two sections > - give a name to the two APIs in the section names > - add a note at the beginning of the CROP API section > > Also remove a note that is incorrect (correct wording is in > vidioc-cropcap.rst). > > Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net&

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
the buffers back >> to userspace in order. >> >> v12: fixed dvb_vb2.c usage of vb2_core_qbuf. >> >> v11: - minor doc/comments fixes (Hans Verkuil) >> - reviewed the in-fence path at __fill_v4l2_buffer() >> >> v10: - rename fence to in_fence in ma

Re: [PATCH v4] media: v4l2-ioctl: replace IOCTL_INFO_STD with stub functions

2018-05-09 Thread Hans Verkuil
On 05/08/2018 07:56 PM, Sami Tolvanen wrote: > This change removes IOCTL_INFO_STD and adds stub functions where > needed using the DEFINE_V4L_STUB_FUNC macro. This fixes indirect call > mismatches with Control-Flow Integrity, caused by calling standard > ioctls using a function pointer that

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
On 05/08/2018 09:16 PM, Ezequiel Garcia wrote: > On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: >> On 04/05/18 22:06, Ezequiel Garcia wrote: >>> @@ -1421,15 +1505,40 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int >>> index, void *pb) &

Re: [PATCH v3] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

2018-05-08 Thread Hans Verkuil
On 05/08/2018 07:35 PM, Sami Tolvanen wrote: > This change fixes indirect call mismatches with Control-Flow Integrity > checking, which are caused by calling standard ioctls using a function > pointer that doesn't match the type of the actual function. I really like the patch, but we've drifted

Re: [PATCH v2] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

2018-05-08 Thread Hans Verkuil
On 05/08/2018 07:17 PM, Sami Tolvanen wrote: > On Tue, May 08, 2018 at 10:18:24AM +0200, Hans Verkuil wrote: >> Just call this v4l_stub_g_fbuf, conform the naming of the other functions. >> >> So just replace vidioc_ by v4l_stub_ in all these DEFINE_IOCTL_FNC macros. >&g

Re: [PATCH v2] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

2018-05-08 Thread Hans Verkuil
Hi Sami, This looks much better. There is one thing that can be improved further though: On 05/07/2018 10:51 PM, Sami Tolvanen wrote: > This change fixes indirect call mismatches with Control-Flow Integrity > checking, which are caused by calling standard ioctls using a function > pointer that

Re: [PATCH v2] media: media-device: fix ioctl function types

2018-05-08 Thread Hans Verkuil
Hi Sami, This is unchanged from the previous version, right? I've already added that to a pull request. If this v2 has changes, then let me know asap. Regards, Hans On 05/07/2018 08:09 PM, Sami Tolvanen wrote: > This change fixes function types for media device ioctls to avoid >

Re: [PATCH v3 11/14] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-05-07 Thread Hans Verkuil
On 07/05/18 14:44, Paul Kocialkowski wrote: > This introduces the Sunxi-Cedrus VPU driver that supports the VPU found > in Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it only supports

Re: [PATCH v3 09/14] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-05-07 Thread Hans Verkuil
On 07/05/18 14:44, Paul Kocialkowski wrote: > This introduces support for Allwinner's MB32-tiled NV12 format, where > each plane is divided into macroblocks of 32x32 pixels. Hence, the size > of each plane has to be aligned to 32 bytes. The pixels inside each > macroblock are coded as they would

Re: [PATCH v3 08/14] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-07 Thread Hans Verkuil
On 07/05/18 14:44, Paul Kocialkowski wrote: > From: Florent Revest > > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel

Re: [PATCH v9 07/15] v4l: mark unordered formats

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, > mark the appropriate formats. > > Signed-off-by: Gustavo Padovan > --- >

Re: [PATCH v9 15/15] v4l: Document explicit synchronization behavior

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it > > v8: amend querybuf documentation. > > v7: minor issues and English improvements (Hans Verkuil) > >

Re: [PATCH v9 14/15] v4l: Add V4L2_CAP_FENCES to drivers

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Drivers that use videobuf2 are capable of using fences and > should report that to userspace. > > v9: Add in the core. > > Signed-off-by: Gustavo Padovan >

Re: [PATCH v9 12/15] vb2: add out-fence support to QBUF

2018-05-07 Thread Hans Verkuil
call. > > The fence is signaled on buffer_done(), when the job on the buffer is > finished. > > v11: - Return fence_fd to userpace only in the QBUF ioctl. > - Rework implementation to avoid storing the sync_file >as state, which is not really needed. > &g

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-07 Thread Hans Verkuil
eue it to the driver, > instead we mark it as error and wait until the previous buffer is done > to notify userspace of the error. We wait here to deliver the buffers back > to userspace in order. > > v12: fixed dvb_vb2.c usage of vb2_core_qbuf. > > v11: - minor doc/comme

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-07 Thread Hans Verkuil
t; Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used > when sending an in-fence to the kernel to be waited on, and > V4L2_BUF_FLAG_OUT_FENCE, to ask the kernel to give back an out-fence. > > v7: minor fixes on the Documentation (Hans Verkuil) > > v6: big improvement on doc (

Re: [PATCH v9 08/15] cobalt: set queue as unordered

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > The cobalt driver may reorder the capture buffers so we need to report > it as such. > > v3: set unordered as a property > v2: use vb2_ops_set_unordered() helper > > Signed-off-by: Gustavo

Re: [PATCH v9 05/15] vb2: add unordered vb2_queue property for drivers

2018-05-07 Thread Hans Verkuil
) data, then it has to call a callback. Regards, Hans > > v4: rename it to vb2_ops_is_unordered() (Hans Verkuil) > > v3: - make it bool (Hans) > - create vb2_ops_set_unordered() helper > > v2: improve comments for is_unordered flag (Hans Verkuil) > > Signed-

Re: [PATCH v9 09/15] vb2: mark codec drivers as unordered

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > In preparation to have full support to explicit fence we are > marking codec as non-ordered preventively. It is easier and safer from an > uAPI point of view to move from unordered to ordered

Re: [PATCH 00/28] Venus updates

2018-05-07 Thread Hans Verkuil
On 24/04/18 14:44, Stanimir Varbanov wrote: > Hello, > > This patch set aims to: > > * add initial support for Venus version 4xx (found on sdm845). > > * introduce a common capability parser to enumerate better > supported uncompressed formats, capabilities by codec, > supported codecs and

Re: [PATCH 28/28] venus: add HEVC codec support

2018-05-07 Thread Hans Verkuil
On 24/04/18 14:44, Stanimir Varbanov wrote: > This add HEVC codec support for venus versions 3xx and 4xx. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/helpers.c | 3 +++ > drivers/media/platform/qcom/venus/hfi.c | 2 ++ >

Re: [PATCH 15/28] venus: add a helper function to set dynamic buffer mode

2018-05-07 Thread Hans Verkuil
On 24/04/18 14:44, Stanimir Varbanov wrote: > Adds a new helper function to set dymaic buffer mode if it is dymaic -> dynamic Regards, Hans > supported by current HFI version. > > Signed-off-by: Stanimir Varbanov > --- >

Re: [PATCH] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

2018-05-07 Thread Hans Verkuil
Hi Sami, This patch can simplify things further, see my comments below: On 27/04/18 20:59, Sami Tolvanen wrote: > This change fixes indirect call mismatches with Control-Flow Integrity > checking, which are caused by calling standard ioctls using a function > pointer that doesn't match the type

Re: [PATCH] media: v4l2-dev.h: document VFL_TYPE_MAX

2018-05-07 Thread Hans Verkuil
On 07/05/18 11:22, Mauro Carvalho Chehab wrote: > Cleanup this Sphinx warning: >read./include/media/v4l2-dev.h:42: warning: Enum value 'VFL_TYPE_MAX' not > described in enum 'vfl_devnode_type' Posted patch for this already, part of an upcoming pull request from me:

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Hans Verkuil
e to see if they care. In a few cases people do, but >>> most often no one does. >> >> Let's start with this one (zoran) then, as Mauro is keen on having >> all media drivers compile-testable on x86-64 and arm. >> >> Trent Piepho and Hans Verkuil both worked on thi

Re: [PATCH v8 09/13] [media] vb2: add in-fence support to QBUF

2018-04-26 Thread Hans Verkuil
On 04/25/2018 10:11 PM, Ezequiel Garcia wrote: > On 14 March 2018 at 12:55, Hans Verkuil <hverk...@xs4all.nl> wrote: >> On 03/09/2018 09:49 AM, Gustavo Padovan wrote: >>> From: Gustavo Padovan <gustavo.pado...@collabora.com> >>> >>> Receive in-

Re: [patch 4/9] LICENSES/GPL2.0: Add GPL-2.0-only/or-later as valid identifiers

2018-04-23 Thread Hans Verkuil
s in the SPDX license identifier specification, but the >> identifiers are not mentioned as valid in the GPL-2.0 license file. >> >> Add them to make everything consistent again. >> >> Signed-off-by: Thomas Gleixner <t...@linutronix.de> >> Cc: Hans Verkuil &

Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-04-22 Thread Hans Verkuil
more. > > This patch simplifies the dma resource acquisition, using the more > generic function dma_request_slave_channel(). > > Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Regards, Hans &

Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-04-22 Thread Hans Verkuil
On 04/21/2018 09:27 PM, Robert Jarzmik wrote: > Robert Jarzmik writes: > >> From: Robert Jarzmik >> >> As the pxa architecture switched towards the dmaengine slave map, the >> old compatibility mechanism to acquire the dma requestor line

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:45, Paul Kocialkowski wrote: > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > with MPEG2 slice data, as well as a

Re: [PATCH v2 06/10] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:45, Paul Kocialkowski wrote: > This introduces support for Allwinner's MB32-tiled NV12 format, where > each plane is divided into macroblocks of 32x32 pixels. Hence, the size > of each plane has to be aligned to 32 bytes. The pixels inside each > macroblock are coded as they would

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:45, Paul Kocialkowski wrote: > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > with MPEG2 slice data, as well as a

Re: [PATCH v2 02/10] media-request: Add a request complete operation to allow m2m scheduling

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:41, Paul Kocialkowski wrote: > When using the request API in the context of a m2m driver, the > operations that come with a m2m run scheduling call in their > (m2m-specific) ioctl handler are delayed until the request is queued > (for instance, this includes queuing buffers and

Re: [PATCH v2 03/10] videobuf2-core: Add helper to get buffer private data from media request

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:41, Paul Kocialkowski wrote: > When calling media operation driver callbacks related to media requests, > only a pointer to the request itself is provided, which is insufficient > to retrieve the driver's context. Since the driver context is usually > set as vb2 queue private data

Re: [PATCH v2 01/10] media: v4l2-ctrls: Add missing v4l2 ctrl unlock

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:41, Paul Kocialkowski wrote: > This adds a missing v4l2_ctrl_unlock call that is required to avoid > deadlocks. > > Signed-off-by: Paul Kocialkowski > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [PATCH] media: cx231xx: Add support for AverMedia DVD EZMaker 7

2018-04-20 Thread Hans Verkuil
On 04/13/18 08:59, Kai Heng Feng wrote: > Hi, > >> On Mar 26, 2018, at 2:06 PM, Kai-Heng Feng >> wrote: >> >> User reports AverMedia DVD EZMaker 7 can be driven by VIDEO_GRABBER. >> Add the device to the id_table to make it work. > > *Gentle ping* > I am hoping

Re: uvcvideo stopped working in 4.16

2018-04-07 Thread Hans Verkuil
On 06/04/18 18:54, Damjan Georgievski wrote: > Since the 4.16 kernel my uvcvideo webcam on Thinkpad X1 Carbon (5th > gen) stopped working with gst-launch-1.0, kamoso (kde webcam app), > Firefox and Chromium on sites like appear.in, talky.io, Google > Hangouts and meet.jit.si. Do you see a

Re: [PATCH v9 2/2] media: V3s: Add support for Allwinner CSI.

2018-04-03 Thread Hans Verkuil
> > Currently, the driver only support the parallel interface. MIPI-CSI2, > ISP's support are not included in this patch. > > Reviewed-by: Maxime Ripard <maxime.rip...@bootlin.com> > Tested-by: Maxime Ripard <maxime.rip...@bootlin.com> > Signed-off-by: Yong Deng <

Re: [PATCH v2 1/4] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-15 Thread Hans Verkuil
On 03/15/2018 07:38 AM, jacopo mondi wrote: > Hi Sakari, >thanks for looking into this! > > On Thu, Mar 15, 2018 at 01:35:34PM +0200, Sakari Ailus wrote: >> Hi Jacopo, >> >> I wonder if it'd make sense to just make all the changes to the driver and >> then have it reviewed; I'm not sure the

Re: [PATCH v8 10/13] [media] vb2: add out-fence support to QBUF

2018-03-14 Thread Hans Verkuil
rn arg for the QBUF call. > > The fence is signaled on buffer_done(), when the job on the buffer is > finished. > > v9: - remove in-fences changes from this patch (Alex Courbot) > - improve fence context creation (Hans Verkuil) > - clean up out fences if

Re: [PATCH v8 12/13] [media] v4l: Add V4L2_CAP_FENCES to drivers

2018-03-14 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drivers that use videobuf2 are capable of using fences and > should report that to userspace. > > The coding style is following what each drivers was already > doing. I think this can be

Re: [PATCH v8 13/13] [media] v4l: Document explicit synchronization behavior

2018-03-14 Thread Hans Verkuil
On 03/13/2018 08:33 PM, Hans Verkuil wrote: > On 03/09/2018 09:49 AM, Gustavo Padovan wrote: >> From: Gustavo Padovan <gustavo.pado...@collabora.com> >> >> Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it >> >> v6: - Close some gaps in the

Re: [PATCH v8 09/13] [media] vb2: add in-fence support to QBUF

2018-03-14 Thread Hans Verkuil
. > > v9: - rename fence to in_fence in many places > - handle fences signalling with error better (Hans Verkuil) > > v8: - improve comments and docs (Hans Verkuil) > - fix unlocking of vb->fence_cb_lock on vb2_core_qbuf (Hans Verkuil) > - move in-fences code th

Re: [PATCH v8 13/13] [media] v4l: Document explicit synchronization behavior

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it > > v6: - Close some gaps in the docs (Hans) > > v5: > - Remove V4L2_CAP_ORDERED > - Add doc about

Re: [PATCH v8 11/13] [media] v4l: introduce the fences capability

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drivers capable of using fences (vb2 drivers) should report the > V4L2_CAP_FENCES to userspace, so add this flag to the uapi. > > Signed-off-by: Gustavo Padovan

Re: [PATCH v8 08/13] [media] vb2: add explicit fence user API

2018-03-13 Thread Hans Verkuil
t; Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used > when sending a fence to the kernel to be waited on, and > V4L2_BUF_FLAG_OUT_FENCE, to ask the kernel to give back an out-fence. > > v6: - big improvement on doc (Hans Verkuil) > > v5: > - keep using reser

Re: [PATCH v8 07/13] [media] vb2: mark codec drivers as unordered

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > In preparation to have full support to explicit fence we are > marking codec as non-ordered preventively. It is easier and safer from an > uAPI point of view to move from unordered to

Re: [PATCH v8 06/13] [media] cobalt: add .is_unordered() for cobalt

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > The cobalt driver may reorder the capture buffers so we need to report > it as such. > > v2: - use vb2_ops_set_unordered() helper > > Signed-off-by: Gustavo Padovan

  1   2   3   4   5   6   7   8   9   10   >