RE: [PATCH] ARM: ep93xx: don't use clang IAS for crunch

On Friday, February 26, 2021 12:23 PM, Alexander Sverdlin wrote: > On Fri, 2021-02-26 at 17:43 +0100, Arnd Bergmann wrote: >> Randconfig builds with ep93xx fail with the clang integrated assembler >> that does not understand the maverick crunch extensions: >> >>

RE: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

On Monday, April 15, 2019 12:47 PM, Arnd Bergmann wrote: > On Mon, Apr 15, 2019 at 9:39 PM Hartley Sweeten > wrote: >>> -#define EP93XX_KEYPAD_KDIV (1<<4) /* 1/4 clock or 1/16 clock */ >>> -#define EP93XX_KEYPAD_AUTOREPEAT (1<<5) /* e

RE: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

On Monday, April 15, 2019 12:25 PM, Arnd Bergmann wrote: > We can communicate the clock rate using platform data rather than setting a > flag to use a particular value in the driver, which is cleaner and avoids the > dependency. > > No platform in the kernel currently defines the ep93xx keypad

RE: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

S | 6 ++ > arch/arm/mach-ep93xx/Kconfig | 7 ++ > arch/arm/mach-ep93xx/ts72xx.c | 165 > +++--- > arch/arm/mach-ep93xx/ts72xx.h | 9 +++ > arch/arm/tools/mach-types | 1 + > 5 files changed, 176 insertion

RE: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

S | 6 ++ > arch/arm/mach-ep93xx/Kconfig | 7 ++ > arch/arm/mach-ep93xx/ts72xx.c | 165 > +++--- > arch/arm/mach-ep93xx/ts72xx.h | 9 +++ > arch/arm/tools/mach-types | 1 + > 5 files changed, 176 insertions(+), 12 deletions(-) Looks good. Thanks! Acked-by: H Hartley Sweeten

RE: [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

On Monday, December 11, 2017 2:40 PM, Lukasz Majewski wrote: > Hi Hartley, > >> On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote: >>> >>> The BK3 board is a derivative of the ts72xx reference design. >> >> Lukasz, >> >> I was just reviewing the other TS-72xx boards and noticed

RE: [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

On Monday, December 11, 2017 2:40 PM, Lukasz Majewski wrote: > Hi Hartley, > >> On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote: >>> >>> The BK3 board is a derivative of the ts72xx reference design. >> >> Lukasz, >> >> I was just reviewing the other TS-72xx boards and noticed

RE: [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote: > > The BK3 board is a derivative of the ts72xx reference design. Lukasz, I was just reviewing the other TS-72xx boards and noticed this: > +/* BK3 specific defines */ > +#define BK3_CPLDVER_PHYS_BASE0x2340 >

RE: [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote: > > The BK3 board is a derivative of the ts72xx reference design. Lukasz, I was just reviewing the other TS-72xx boards and noticed this: > +/* BK3 specific defines */ > +#define BK3_CPLDVER_PHYS_BASE0x2340 >

RE: [PATCH v4 0/5] ARM: ep93xx: ts72xx: Add support for BK3 board

h-types | 1 + > 5 files changed, 202 insertions(+), 19 deletions(-) Looks good. Acked-by: H Hartley Sweeten <hswee...@visionengravers.com> Linus, Would you mind picking this series up? Thanks, Hartley

RE: [PATCH v4 0/5] ARM: ep93xx: ts72xx: Add support for BK3 board

h-types | 1 + > 5 files changed, 202 insertions(+), 19 deletions(-) Looks good. Acked-by: H Hartley Sweeten Linus, Would you mind picking this series up? Thanks, Hartley

RE: [PATCH v3 5/6] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > This patch extends readability of ts72xx.c code. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - New patch > --- > arch/arm/mach-ep93xx/ts72xx.c | 12 > 1 file changed, 12 insertions(+)

RE: [PATCH v3 5/6] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > This patch extends readability of ts72xx.c code. > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - New patch > --- > arch/arm/mach-ep93xx/ts72xx.c | 12 > 1 file changed, 12 insertions(+) This patch does

RE: [PATCH v3 4/6] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > The map IO common code has been excluded to be reused by other ts72xx clones. > > Signed-off-by: Lukasz Majewski > Acked-by: Alexander Sverdlin > arch/arm/mach-ep93xx/ts72xx.c | 23

RE: [PATCH v3 4/6] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > The map IO common code has been excluded to be reused by other ts72xx clones. > > Signed-off-by: Lukasz Majewski > Acked-by: Alexander Sverdlin > arch/arm/mach-ep93xx/ts72xx.c | 23 --- > 1 file changed, 16

RE: [PATCH v3 3/6] ARM: ep93xx: ts72xx: Rewrite ts72xx_register_flash() to accept parameters

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > This commit extend the ts72xx_register_flash() to accept passed parameters, > which makes it more reusable. > > Now it is possible to accept ep93xx flash start address and partitions. @@ -223,7 +217,9 @@ static struct

RE: [PATCH v3 3/6] ARM: ep93xx: ts72xx: Rewrite ts72xx_register_flash() to accept parameters

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > This commit extend the ts72xx_register_flash() to accept passed parameters, > which makes it more reusable. > > Now it is possible to accept ep93xx flash start address and partitions. @@ -223,7 +217,9 @@ static struct

RE: [PATCH v3 1/6] ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > This commit cleans up the code by using dedicated macros instead of full > definitions. > > Signed-off-by: Lukasz Majewski > Acked-by: Alexander Sverdlin > @@ -187,16 +187,8 @@

RE: [PATCH v3 1/6] ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable

On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote: > This commit cleans up the code by using dedicated macros instead of full > definitions. > > Signed-off-by: Lukasz Majewski > Acked-by: Alexander Sverdlin > @@ -187,16 +187,8 @@ static struct platform_device ts72xx_rtc_device =

RE: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: >> +const struct comedi_lrange *lrange; > > NAK. The following lines of source code allocate memory pointed to by > 'lrange' and modify it, so 'const' is not appropriate here.

RE: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: >> +const struct comedi_lrange *lrange; > > NAK. The following lines of source code allocate memory pointed to by > 'lrange' and modify it, so 'const' is not appropriate here.

RE: [PATCH] MAINTAINERS: EP93XX: Update maintainership

On Monday, May 22, 2017 6:30 AM, Alexander Sverdlin wrote: > As agreed with Ryan, change the maintainership. > > Signed-off-by: Alexander Sverdlin <alexander.sverd...@gmail.com> Acked-by: H Hartley Sweeten <hswee...@visionengravers.com> Welcome aboard!

RE: [PATCH] MAINTAINERS: EP93XX: Update maintainership

On Monday, May 22, 2017 6:30 AM, Alexander Sverdlin wrote: > As agreed with Ryan, change the maintainership. > > Signed-off-by: Alexander Sverdlin Acked-by: H Hartley Sweeten Welcome aboard!

RE: [PATCH 02/35] ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn

CLK, open drain has no effect\n"); > + pr_warn("scl != EECLK, open drain has no effect\n"); > > __raw_writel((data->sda_is_open_drain << 1) | >(data->scl_is_open_drain << 0), For the ep93xx part: Acked-by: H Hartley Sweeten <hswee...@visionengravers.com>

RE: [PATCH 02/35] ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn

n"); > + pr_warn("scl != EECLK, open drain has no effect\n"); > > __raw_writel((data->sda_is_open_drain << 1) | >(data->scl_is_open_drain << 0), For the ep93xx part: Acked-by: H Hartley Sweeten

[tip:irq/core] genirq: Fix /proc/interrupts output alignment

Commit-ID: f435da416beaacc8934fc21820d9488269b39c98 Gitweb: http://git.kernel.org/tip/f435da416beaacc8934fc21820d9488269b39c98 Author: H Hartley Sweeten <hswee...@visionengravers.com> AuthorDate: Fri, 10 Feb 2017 09:54:16 -0700 Committer: Thomas Gleixner <t...@linutronix.de>

[tip:irq/core] genirq: Fix /proc/interrupts output alignment

Commit-ID: f435da416beaacc8934fc21820d9488269b39c98 Gitweb: http://git.kernel.org/tip/f435da416beaacc8934fc21820d9488269b39c98 Author: H Hartley Sweeten AuthorDate: Fri, 10 Feb 2017 09:54:16 -0700 Committer: Thomas Gleixner CommitDate: Fri, 10 Feb 2017 20:17:52 +0100 genirq: Fix /proc

[PATCH] getirq: fix /proc/interrupts output alignment

If the irq_desc being output does not have a domain the information following the 'name' is not aligned correctly. Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com> Cc: Thomas Gleixner <t...@linutronix.de> --- kernel/irq/proc.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH] getirq: fix /proc/interrupts output alignment

If the irq_desc being output does not have a domain the information following the 'name' is not aligned correctly. Signed-off-by: H Hartley Sweeten Cc: Thomas Gleixner --- kernel/irq/proc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index

RE: [PATCH RESEND] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

rious reboot. > > Do not pull ts72xx.h, but instead locally define what we need to disable > the watchdog. > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> > --- > Arnd, this is a recent, so you can queue this up, thanks! Reviewed-by: H Hartley Sweeten <hswee..

RE: [PATCH RESEND] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

rious reboot. > > Do not pull ts72xx.h, but instead locally define what we need to disable > the watchdog. > > Signed-off-by: Florian Fainelli > --- > Arnd, this is a recent, so you can queue this up, thanks! Reviewed-by: H Hartley Sweeten or Tested-by/Acked-by as appropriate... Hartley

RE: [PATCH 2/2] watchdog: ts72xx_wdt: convert driver to watchdog core

On Monday, January 30, 2017 12:02 PM, Guenter Roeck wrote: > On Mon, Jan 30, 2017 at 09:55:48AM -0700, H Hartley Sweeten wrote: >> Cleanup this driver and convert it to use the watchdog framework API. >> >> Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com

RE: [PATCH 2/2] watchdog: ts72xx_wdt: convert driver to watchdog core

On Monday, January 30, 2017 12:02 PM, Guenter Roeck wrote: > On Mon, Jan 30, 2017 at 09:55:48AM -0700, H Hartley Sweeten wrote: >> Cleanup this driver and convert it to use the watchdog framework API. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Mika Westerberg >

RE: [PATCH 1/2] watchdog: ep93xx_wdt: cleanup and let the core handle the heartbeat

On Monday, January 30, 2017 11:55 AM, Guenter Roeck wrote: > On Mon, Jan 30, 2017 at 09:55:47AM -0700, H Hartley Sweeten wrote: >> Cleanup this driver and remove the 200ms heartbeat timer. The core now >> has the ability to handle the heartbeat. >> >> Signed-off-b

RE: [PATCH 1/2] watchdog: ep93xx_wdt: cleanup and let the core handle the heartbeat

On Monday, January 30, 2017 11:55 AM, Guenter Roeck wrote: > On Mon, Jan 30, 2017 at 09:55:47AM -0700, H Hartley Sweeten wrote: >> Cleanup this driver and remove the 200ms heartbeat timer. The core now >> has the ability to handle the heartbeat. >> >> Signed-off-by: H

[PATCH 0/2] watchdog: cleanup ep93xx platform drivers

The ep93xx_wdt driver is used by EP93xx based platforms for the internal watchdog of the EP93xx processor. The TS-72xx platforms have an additional watchdog provided by the CPLD on those boards. Cleanup both drivers. H Hartley Sweeten (2): watchdog: ep93xx_wdt: cleanup and let the core handle

[PATCH 0/2] watchdog: cleanup ep93xx platform drivers

The ep93xx_wdt driver is used by EP93xx based platforms for the internal watchdog of the EP93xx processor. The TS-72xx platforms have an additional watchdog provided by the CPLD on those boards. Cleanup both drivers. H Hartley Sweeten (2): watchdog: ep93xx_wdt: cleanup and let the core handle

[PATCH 1/2] watchdog: ep93xx_wdt: cleanup and let the core handle the heartbeat

Cleanup this driver and remove the 200ms heartbeat timer. The core now has the ability to handle the heartbeat. Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com> Cc: Wim Van Sebroeck <w...@iguana.be> Cc: Guenter Roeck <li...@roeck-us.net> --- drivers/watchdog/

[PATCH 1/2] watchdog: ep93xx_wdt: cleanup and let the core handle the heartbeat

Cleanup this driver and remove the 200ms heartbeat timer. The core now has the ability to handle the heartbeat. Signed-off-by: H Hartley Sweeten Cc: Wim Van Sebroeck Cc: Guenter Roeck --- drivers/watchdog/ep93xx_wdt.c | 115 +- 1 file changed, 46

[PATCH 2/2] watchdog: ts72xx_wdt: convert driver to watchdog core

Cleanup this driver and convert it to use the watchdog framework API. Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com> Cc: Mika Westerberg <mika.westerb...@iki.fi> Cc: Wim Van Sebroeck <w...@iguana.be> Cc: Guenter Roeck <li...@roeck-us.net> --- drivers/wat

[PATCH 2/2] watchdog: ts72xx_wdt: convert driver to watchdog core

Cleanup this driver and convert it to use the watchdog framework API. Signed-off-by: H Hartley Sweeten Cc: Mika Westerberg Cc: Wim Van Sebroeck Cc: Guenter Roeck --- drivers/watchdog/ts72xx_wdt.c | 447 +- 1 file changed, 93 insertions(+), 354

RE: [PATCH v5 2/4] ARM: Define KERNEL_START and KERNEL_END

On Tuesday, January 03, 2017 6:14 PM, Florian Fainelli wrote: > > In preparation for adding CONFIG_DEBUG_VIRTUAL support, define a set of > common constants: KERNEL_START and KERNEL_END which abstract > CONFIG_XIP_KERNEL vs. !CONFIG_XIP_KERNEL. Update the code where > relevant. > > Acked-by:

RE: [PATCH v5 2/4] ARM: Define KERNEL_START and KERNEL_END

On Tuesday, January 03, 2017 6:14 PM, Florian Fainelli wrote: > > In preparation for adding CONFIG_DEBUG_VIRTUAL support, define a set of > common constants: KERNEL_START and KERNEL_END which abstract > CONFIG_XIP_KERNEL vs. !CONFIG_XIP_KERNEL. Update the code where > relevant. > > Acked-by:

RE: [PATCH] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

On Sunday, December 18, 2016 7:08 PM, Florian Fainelli wrote: > Le 12/11/16 à 11:16, Florian Fainelli a écrit : >> The TS-72xx/73xx boards have a CPLD watchdog which is configured to >> reset the board after 8 seconds, if the kernel is large enough that this >> takes about this time to decompress

RE: [PATCH] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

On Sunday, December 18, 2016 7:08 PM, Florian Fainelli wrote: > Le 12/11/16 à 11:16, Florian Fainelli a écrit : >> The TS-72xx/73xx boards have a CPLD watchdog which is configured to >> reset the board after 8 seconds, if the kernel is large enough that this >> takes about this time to decompress

RE: [PATCH] drivers: staging: comedi: fix function prototypes

; > Looks good, thanks! > > Reviewed-by: Ian Abbott <abbo...@mev.co.uk> Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>

RE: [PATCH] drivers: staging: comedi: fix function prototypes

> Reviewed-by: Ian Abbott Reviewed-by: H Hartley Sweeten

RE: [PATCH] drivers: staging: comedi: fix function prototypes

On Thursday, December 15, 2016 4:47 AM, Ian Abbott wrote: > On 14/12/16 16:14, Hartley Sweeten wrote: >> On December 14, 2016 6:42 AM, Piotr Gregor wrote: >>> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); >>> +struct pci_dev *comedi_to_pci_de

RE: [PATCH] drivers: staging: comedi: fix function prototypes

On Thursday, December 15, 2016 4:47 AM, Ian Abbott wrote: > On 14/12/16 16:14, Hartley Sweeten wrote: >> On December 14, 2016 6:42 AM, Piotr Gregor wrote: >>> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *); >>> +struct pci_dev *comedi_to_pci_de

RE: [PATCH v3 2/2] FPGA: Add TS-7300 FPGA manager

On Wednesday, December 14, 2016 11:55 AM, Florian Fainelli wrote: > My understanding is that, yes, this triggers the final write. You are > right that ts73xx_fpga_write() can be called multiple times. It sounds > like what my write_complete function does right now is just return that > we

RE: [PATCH v3 2/2] FPGA: Add TS-7300 FPGA manager

On Wednesday, December 14, 2016 11:55 AM, Florian Fainelli wrote: > My understanding is that, yes, this triggers the final write. You are > right that ts73xx_fpga_write() can be called multiple times. It sounds > like what my write_complete function does right now is just return that > we

RE: [PATCH 2/2] FPGA: Add TS-7300 FPGA manager

On Monday, December 12, 2016 9:02 AM, Alan Tull wrote: > On Sun, 11 Dec 2016, Florian Fainelli wrote: >> Add support for loading bitstreams on the Altera Cyclone II FPGA >> populated on the TS-7300 board. This is done through the configuration >> and data registers offered through a memory

RE: [PATCH 2/2] FPGA: Add TS-7300 FPGA manager

On Monday, December 12, 2016 9:02 AM, Alan Tull wrote: > On Sun, 11 Dec 2016, Florian Fainelli wrote: >> Add support for loading bitstreams on the Altera Cyclone II FPGA >> populated on the TS-7300 board. This is done through the configuration >> and data registers offered through a memory

RE: [PATCH] drivers: staging: comedi: fix function prototypes

On December 14, 2016 6:42 AM, Piotr Gregor wrote: > Add names of parameters to function prototypes in comedi PCI. > Checkpatch reports now no errors. > > Signed-off-by: Piotr Gregor > --- > drivers/staging/comedi/comedi_pci.h | 18 ++ > 1 file changed, 10

RE: [PATCH] drivers: staging: comedi: fix function prototypes

On December 14, 2016 6:42 AM, Piotr Gregor wrote: > Add names of parameters to function prototypes in comedi PCI. > Checkpatch reports now no errors. > > Signed-off-by: Piotr Gregor > --- > drivers/staging/comedi/comedi_pci.h | 18 ++ > 1 file changed, 10 insertions(+), 8

RE: [PATCH v3 1/2] ARM: ep93xx: Register ts73xx-fpga manager driver for TS-7300

m/mach-ep93xx/ts72xx.c | 26 ++ > 1 file changed, 26 insertions(+) For the ep93xx core change: Acked-by: H Hartley Sweeten <hswee...@visionengravers.com>

RE: [PATCH v3 1/2] ARM: ep93xx: Register ts73xx-fpga manager driver for TS-7300

-ep93xx/ts72xx.c | 26 ++ > 1 file changed, 26 insertions(+) For the ep93xx core change: Acked-by: H Hartley Sweeten

RE: [PATCH] staging: comedi: ni_mio_common: fix AO inttrig backwards compatibility

G_EXT); +* in that case, the internal trigger is being used as a pre-trigger +* before the external trigger. +*/ + if (cmd->start_src == TRIG_INT && trig_num != cmd->start_arg) return -EINVAL; But, either way: Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> Thanks!

RE: [PATCH] staging: comedi: ni_mio_common: fix AO inttrig backwards compatibility

s a bit clearer: + /* +* Require trig_num == cmd->start_arg when cmd->start_src == TRIG_INT. +* For backwards compatibility, any trig_num is valid when +* cmd->start_src != TRIG_INT (i.e. when cmd->start_src == TRIG_EXT); +* in that case, the internal tri

RE: [PATCH 4/5] rtc: m48t86: move m48t86.h to platform_data

On Sunday, June 26, 2016 3:03 PM, Alexandre Belloni wrote: > m48t86.h belongs to include/linux/platform_data/ > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> > --- > Cc: Hartley Sweeten <hswee...@visionengravers.com> > Cc: Ryan Mallon <r

RE: [PATCH 4/5] rtc: m48t86: move m48t86.h to platform_data

On Sunday, June 26, 2016 3:03 PM, Alexandre Belloni wrote: > m48t86.h belongs to include/linux/platform_data/ > > Signed-off-by: Alexandre Belloni > --- > Cc: Hartley Sweeten > Cc: Ryan Mallon > Cc: Alexander Clouter > Cc: Jason Cooper > Cc: Andrew Lunn > C

RE: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue

On Friday, June 17, 2016 9:02 PM, Greg KH wrote: >> The patch looks fine (although this odd-ball Comedi driver shouldn't really >> be sending signals to a user-space task!). > > Yeah, that's really odd, fixing that would be nice... This is the last addi-data driver that does this. It's on my list

RE: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue

On Friday, June 17, 2016 9:02 PM, Greg KH wrote: >> The patch looks fine (although this odd-ball Comedi driver shouldn't really >> be sending signals to a user-space task!). > > Yeah, that's really odd, fixing that would be nice... This is the last addi-data driver that does this. It's on my list

RE: [PATCH 5/5] Staging: comedi: Prefer using the BIT macro issue in dmm32at.c

On Tuesday, June 07, 2016 4:51 AM, Ravishankar Karkala Mallikarjunayya wrote: > Subject: [PATCH 5/5] Staging: comedi: Prefer using the BIT macro issue in > dmm32at.c Please don't add random patches to a series. You started this series with 1/4, 2/4, 3/4 and 4/4 then added a 5/5. Also, please

RE: [PATCH 5/5] Staging: comedi: Prefer using the BIT macro issue in dmm32at.c

On Tuesday, June 07, 2016 4:51 AM, Ravishankar Karkala Mallikarjunayya wrote: > Subject: [PATCH 5/5] Staging: comedi: Prefer using the BIT macro issue in > dmm32at.c Please don't add random patches to a series. You started this series with 1/4, 2/4, 3/4 and 4/4 then added a 5/5. Also, please

RE: [PATCH 04/20] staging: comedi: drivers: re-do macros for PLX PCI 9080 LASxRR values

On Friday, May 20, 2016 10:18 AM, Ian Abbott wrote: > On 20/05/16 17:37, Hartley Sweeten wrote: >> On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: >>> Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in >>> "plx9080.h", using the prefix

RE: [PATCH 04/20] staging: comedi: drivers: re-do macros for PLX PCI 9080 LASxRR values

On Friday, May 20, 2016 10:18 AM, Ian Abbott wrote: > On 20/05/16 17:37, Hartley Sweeten wrote: >> On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: >>> Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in >>> "plx9080.h", using the prefix

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> _REG_ format. Personally I prefer the format to b

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> _REG_ format. Personally I prefer the format to b

RE: [PATCH 04/20] staging: comedi: drivers: re-do macros for PLX PCI 9080 LASxRR values

On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in > "plx9080.h", using the prefix `PLX_LASRR_`. Make use of the `BIT(x)` > and `GENMASK(h,l)` macros to define the values. > > Define a macro `PLX_LASRR_PREFETCH` for the

RE: [PATCH 04/20] staging: comedi: drivers: re-do macros for PLX PCI 9080 LASxRR values

On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in > "plx9080.h", using the prefix `PLX_LASRR_`. Make use of the `BIT(x)` > and `GENMASK(h,l)` macros to define the values. > > Define a macro `PLX_LASRR_PREFETCH` for the

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros in "plx9080.h" that define the offsets of registers, > following the pattern `PLX_REG_`, where `` is the register > name from the PLX PCI 9080 Data Book. > > Add defines for the "Mailbox" registers, and add parameterized macros

RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets

On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros in "plx9080.h" that define the offsets of registers, > following the pattern `PLX_REG_`, where `` is the register > name from the PLX PCI 9080 Data Book. > > Add defines for the "Mailbox" registers, and add parameterized macros

RE: [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset macros

On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> > Reviewed-by: H Hartley Sweeten <hswee...@visionengr

RE: [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset macros

On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > Reviewed-by: H Hartley Sweeten > --- > Other CamelCase issues in thi

RE: [PATCH v2 12/14] staging: comedi: daqboard2000: rename reference DACs register macros

On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros that define values for the reference DACs register to > avoid CamelCase, and to make it clearer which register they are > associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value > `0x80` that triggers setting

RE: [PATCH v2 12/14] staging: comedi: daqboard2000: rename reference DACs register macros

On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros that define values for the reference DACs register to > avoid CamelCase, and to make it clearer which register they are > associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value > `0x80` that triggers setting

RE: [PATCH v2 06/14] staging: comedi: daqboard2000: rename register offset macros

On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott <abbo...@mev.co.uk> > Reviewed-by: H Hartley Sweeten <hswee...@visionengr

RE: [PATCH v2 06/14] staging: comedi: daqboard2000: rename register offset macros

On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > Reviewed-by: H Hartley Sweeten > --- > Other CamelCase issues in thi

RE: [PATCH 00/14] staging: comedi: daqboard2000: checkpatch clean-ups

ons(-) Ian, I had a couple comments on patches 1, 5, 6, and 14 but they are really just nitpicks. If you prefer to leave this series as-is: Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com> Thanks for going through this one, it's annoyed me... Hartley

RE: [PATCH 00/14] staging: comedi: daqboard2000: checkpatch clean-ups

ons(-) Ian, I had a couple comments on patches 1, 5, 6, and 14 but they are really just nitpicks. If you prefer to leave this series as-is: Reviewed-by: H Hartley Sweeten Thanks for going through this one, it's annoyed me... Hartley

RE: [PATCH 14/14] staging: comedi: daqboard2000: prefer usleep_range()

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > The checkpatch.pl warns about two `udelay(x)` calls, one of 100 > microseconds, and one of 10 microseconds. The 100 microseconds one is > used when waiting for FPGA to become ready to accept firmware, and is > not that critical, so replace it

RE: [PATCH 14/14] staging: comedi: daqboard2000: prefer usleep_range()

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > The checkpatch.pl warns about two `udelay(x)` calls, one of 100 > microseconds, and one of 10 microseconds. The 100 microseconds one is > used when waiting for FPGA to become ready to accept firmware, and is > not that critical, so replace it

RE: [PATCH 06/14] staging: comedi: daqboard2000: rename register offset macros

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > --- > Other CamelCase issues in this patch will be dealt with by later >

RE: [PATCH 06/14] staging: comedi: daqboard2000: rename register offset macros

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > --- > Other CamelCase issues in this patch will be dealt with by later > patches in the series.

RE: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Remove some commented out code. Some of it uses constructs that don't > exist in the driver, and probably come from the source code for the MS > Windows driver. > > Signed-off-by: Ian Abbott > --- >

RE: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Remove some commented out code. Some of it uses constructs that don't > exist in the driver, and probably come from the source code for the MS > Windows driver. > > Signed-off-by: Ian Abbott > --- >

RE: [PATCH 05/14] staging: comedi: daqboard2000: rename serial EEPROM register macros

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining values for the Serial EEPROM Control Register > to avoid CamelCase. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/drivers/daqboard2000.c | 26 +- > 1 file

RE: [PATCH 05/14] staging: comedi: daqboard2000: rename serial EEPROM register macros

On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining values for the Serial EEPROM Control Register > to avoid CamelCase. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/drivers/daqboard2000.c | 26 +- > 1 file changed, 13

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 3:41 AM, Ian Abbott wrote: > On 06/04/16 10:41, Ian Abbott wrote: >> On 06/04/16 02:21, Hartley Sweeten wrote: >>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>>> The variable unipolar was never used. >>&g

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 3:41 AM, Ian Abbott wrote: > On 06/04/16 10:41, Ian Abbott wrote: >> On 06/04/16 02:21, Hartley Sweeten wrote: >>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>>> The variable unipolar was never used. >>&g

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukher

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukherjee >>> -

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: > The variable unipolar was never used. > > Signed-off-by: Sudip Mukherjee > --- > > There may be a chance that reading from DAS1800_CONTROL_C is necessary > before reading from DAS1800_STATUS. If that is

RE: [PATCH] staging: comedi: das1800: remove unused variable

On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: > The variable unipolar was never used. > > Signed-off-by: Sudip Mukherjee > --- > > There may be a chance that reading from DAS1800_CONTROL_C is necessary > before reading from DAS1800_STATUS. If that is true then please discard > this

RE: [PATCH] staging: comedi: drivers: remove bogus ni_mio_c_common.c

s/staging/comedi/drivers/ni_mio_c_common.c > deleted file mode 100644 > index e69de29..000 Weird. Good catch. Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>

RE: [PATCH] staging: comedi: drivers: remove bogus ni_mio_c_common.c

io_c_common.c > deleted file mode 100644 > index e69de29..000 Weird. Good catch. Reviewed-by: H Hartley Sweeten

RE: [PATCH v2] staging/comedi/dt282x: avoid integer overflow warning

On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote: > On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote: >> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote: >> >> Is this a gcc-6 specific issue? Seems line this warning should be showing >> up in a

RE: [PATCH v2] staging/comedi/dt282x: avoid integer overflow warning

On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote: > On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote: >> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote: >> >> Is this a gcc-6 specific issue? Seems line this warning should be showing >> up in a

RE: [PATCH v2] staging/comedi/dt282x: avoid integer overflow warning

t; This disambiguates the operation by making the constant expressions > we pass here explicitly 'unsigned', which helps to avoid the warning. > > As pointed out by Hartley Sweeten, scripts/checkpatch.pl notices that > the shifts here are rather unreadable, though the suggested BIT() > m

  1   2   3   4   5   6   7   8   9   10   >