Re: [PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-13 Thread Hauke Mehrtens
On 4/13/21 12:24 AM, Martin Blumenstingl wrote: Hi Andrew, On Mon, Apr 12, 2021 at 1:16 AM Andrew Lunn wrote: On Sun, Apr 11, 2021 at 10:55:11PM +0200, Martin Blumenstingl wrote: Add support for .get_regs_len and .get_regs so it is easier to find out about the state of the ports on the

Re: [PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-11 Thread Hauke Mehrtens
the current port status (as well as the result of the auto polling mechanism). Other global and per-port registers which are also considered useful are included as well. Acked-by: Hauke Mehrtens Signed-off-by: Martin Blumenstingl --- drivers/net/dsa/lantiq_gswip.c | 83

Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits

2021-04-07 Thread Hauke Mehrtens
On 4/7/21 2:32 AM, Andrew Lunn wrote: case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID: miicfg |= GSWIP_MII_CFG_MODE_RGMII; + + if

Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits

2021-04-06 Thread Hauke Mehrtens
of the GSWIP_MII_CFG register. Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Cc: sta...@vger.kernel.org Suggested-by: Hauke Mehrtens Acked-by: Hauke Mehrtens Signed-off-by: Martin Blumenstingl --- drivers/net/dsa/lantiq_gswip.c | 22 +++--

Re: [PATCH v3 2/3] net: dsa: lantiq: verify compatible strings against hardware

2021-03-21 Thread Hauke Mehrtens
On 3/21/21 6:39 PM, Aleksander Jan Bajkowski wrote: Verify compatible string against hardware. Signed-off-by: Aleksander Jan Bajkowski Acked-by: Hauke Mehrtens

Re: [PATCH v3 1/3] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2021-03-21 Thread Hauke Mehrtens
-off-by: Aleksander Jan Bajkowski Acked-by: Hauke Mehrtens

Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency

2021-03-10 Thread Hauke Mehrtens
On 3/10/21 5:57 PM, Arnd Bergmann wrote: On Wed, Mar 10, 2021 at 8:30 AM Pavel Machek wrote: Hi! I'd like people from Intel to contact me. There's more to fix there, and AFAICT original author went away. The following message to was undeliverable. : Recipient +address rejected: User

Re: [PATCH] phy: lantiq: rcu-usb2: wait after clock enable

2021-01-07 Thread Hauke Mehrtens
he phy get up and running. There isn't any documentation how much time is required, the value was chosen based on tests. Cc: # v5.7+ Signed-off-by: Mathias Kresin Acked-by: Hauke Mehrtens I do not know how long you have to wait here, but this looks ok, when it works. Hauke --- drivers/

Re: [PATCH 2/2] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access

2021-01-02 Thread Hauke Mehrtens
because there's really only three (one for each of the following ports: 0, 1, 5). Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Cc: sta...@vger.kernel.org Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gs

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-02 Thread Hauke Mehrtens
antiq / Intel DSA driver for vrx200") Cc: sta...@vger.kernel.org Suggested-by: Hauke Mehrtens Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- drivers/net/dsa/lantiq_gswip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Hauke Mehrtens
On 12/21/20 7:04 PM, Andrew Lunn wrote: On Tue, Dec 22, 2020 at 12:59:08AM +0900, Masahiro Yamada wrote: On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: The declaration of request_irq() in is marked as __must_check.

Re: [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-04 Thread Hauke Mehrtens
On 12/4/20 2:49 AM, Andrew Lunn wrote: static const struct of_device_id gswip_of_match[] = { { .compatible = "lantiq,xrx200-gswip", .data = _xrx200 }, + { .compatible = "lantiq,xrx300-gswip", .data = _xrx300 }, + { .compatible = "lantiq,xrx330-gswip", .data = _xrx300 },

Re: [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-03 Thread Hauke Mehrtens
Hi, This looks good. I haven't checked all the differences between the SoCs, but found some minor problems in the code for the port configuration. On 12/3/20 11:03 PM, Aleksander Jan Bajkowski wrote: From: Aleksander Jan Bajkowski This patch allows you to use all phs on GRX300 and

Re: [PATCH v2] net: lantiq: Wait for the GPHY firmware to be ready

2020-11-15 Thread Hauke Mehrtens
by: Martin Blumenstingl Acked-by: Hauke Mehrtens --- Changes since v1: - move the msleep() closer to the actual loop over all GPHY instances as suggested by Andrew - added Andrew's Reviewed-by (thank you!) drivers/net/dsa/lantiq_gswip.c | 11 +++ 1 file changed, 11 insertions(+)

Re: [PATCH AUTOSEL 5.4 10/58] mips: vdso: fix 'jalr t9' crash in vdso code

2020-08-29 Thread Hauke Mehrtens
On 8/29/20 3:56 PM, Sasha Levin wrote: > On Sat, Aug 29, 2020 at 03:08:01PM +0200, Hauke Mehrtens wrote: >> On 3/5/20 6:13 PM, Sasha Levin wrote: >>> From: Victor Kamensky >>> >>> [ Upstream commit d3f703c4359ff06619b2322b91f69710453e6b6d ] >>> >

Re: [PATCH AUTOSEL 5.4 10/58] mips: vdso: fix 'jalr t9' crash in vdso code

2020-08-29 Thread Hauke Mehrtens
On 3/5/20 6:13 PM, Sasha Levin wrote: > From: Victor Kamensky > > [ Upstream commit d3f703c4359ff06619b2322b91f69710453e6b6d ] > > Observed that when kernel is built with Yocto mips64-poky-linux-gcc, > and mips64-poky-linux-gnun32-gcc toolchain, resulting vdso contains > 'jalr t9' instructions

Re: [PATCH] MIPS: lantiq: xway: sysctrl: fix the GPHY clock alias names

2020-06-07 Thread Hauke Mehrtens
eff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Cc: sta...@vger.kernel.org > Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens > --- > arch/mips/lantiq/xway/sysctrl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > di

Re: [PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error

2020-06-07 Thread Hauke Mehrtens
mprove > the cases where someone made a mistake. > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c | 3 ++- > 1 file changed, 2 i

Re: [PATCH 1/4] spi: lantiq: Synchronize interrupt handlers and transfers

2020-04-28 Thread Hauke Mehrtens
On 4/28/20 1:10 PM, Daniel Schwierzeck wrote: > > > Am 24.04.20 um 12:42 schrieb Dilip Kota: >> Synchronize tx, rx and error interrupts by registering to the >> same interrupt handler. Interrupt handler will recognize and process >> the appropriate interrupt on the basis of interrupt status

Re: [musl] [PATCH] arm64: uapi: Fix user space compile with musl libc

2019-10-19 Thread Hauke Mehrtens
On 10/19/19 10:29 PM, Rich Felker wrote: > On Sat, Oct 19, 2019 at 10:17:17PM +0200, Hauke Mehrtens wrote: >> musl libc also defines the structures in their arch/aarch64/bits/signal.h >> header file. Some applications like strace and gdb include both of them >> and then the

[PATCH] arm64: uapi: Fix user space compile with musl libc

2019-10-19 Thread Hauke Mehrtens
will also update musl libc to define these constants. Signed-off-by: Hauke Mehrtens Cc: sta...@vger.kernel.org --- arch/arm64/include/uapi/asm/sigcontext.h | 13 + include/uapi/linux/libc-compat.h | 20 2 files changed, 33 insertions(+) diff --git a/arch

Re: [PATCH AUTOSEL 5.2 17/42] MIPS: lantiq: update the clock alias' for the mainline PCIe PHY driver

2019-09-29 Thread Hauke Mehrtens
On 9/29/19 7:32 PM, Sasha Levin wrote: > From: Martin Blumenstingl > > [ Upstream commit ed90302be64a53d9031c8ce05428c358b16a5d96 ] > > The mainline PCIe PHY driver has it's own devicetree node. Update the > clock alias so the mainline driver finds the clocks. > > The first PCIe PHY is located

Re: [PATCH v2] ethernet: lantiq_xrx200: Use devm_platform_ioremap_resource() in xrx200_probe()

2019-09-20 Thread Hauke Mehrtens
tform_get_resource” and “devm_ioremap_resource” directly. > > * Thus reduce also a bit of exception handling code here. > * Delete the local variable “res”. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Hauke Mehrtens But this can al

Re: [PATCH 5/5] MIPS: dts: lantiq: danube: easy50712: route the PCI_INTA IRQ through EBU

2019-07-29 Thread Hauke Mehrtens
ctly (using IRQ_TYPE_LEVEL_LOW, this was previously hardcoded in >> the PCI driver) and ACKed properly. >> >> Signed-off-by: Martin Blumenstingl Acked-by: Hauke Mehrtens >> --- >> arch/mips/boot/dts/lantiq/easy50712.dts | 4 +++- >> 1 file changed, 3 inserti

Re: [PATCH 2/3] net: dsa: lantiq_gswip: fix OF child-node lookups

2019-01-16 Thread Hauke Mehrtens
ntiq / Intel DSA driver for vrx200") > Cc: stable# 4.20 > Cc: Hauke Mehrtens > Signed-off-by: Johan Hovold Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) >

Re: [PATCH 3/3] net: dsa: lantiq_gswip: drop bogus drvdata check

2019-01-16 Thread Hauke Mehrtens
On 1/16/19 11:23 AM, Johan Hovold wrote: > The platform-device driver data is set on successful probe and will > never be NULL on remove (or we have much bigger problems). > > Signed-off-by: Johan Hovold Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c

Re: [PATCH 1/3] net: dsa: lantiq_gswip: fix use-after-free on failed probe

2019-01-16 Thread Hauke Mehrtens
4fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") >> Cc: stable # 4.20 >> Cc: Hauke Mehrtens >> Signed-off-by: Johan Hovold >> --- >> drivers/net/dsa/lantiq_gswip.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >>

Re: [PATCH 1/3] net: dsa: lantiq_gswip: fix use-after-free on failed probe

2019-01-16 Thread Hauke Mehrtens
Cc: stable# 4.20 > Cc: Hauke Mehrtens > Signed-off-by: Johan Hovold Acked-by: Hauke Mehrtens > --- > drivers/net/dsa/lantiq_gswip.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gsw

Re: [PATCH mips-fixes] MIPS: BCM47XX: Setup struct device for the SoC

2019-01-02 Thread Hauke Mehrtens
dma noncoherent ops for simple noncoherent platforms") Cc: Christoph Hellwig Cc: sta...@vger.kernel.org # v4.19+ Signed-off-by: Rafał Miłecki Acked-by: Hauke Mehrtens I assume that the old ssb based devices also have such problems did you had a look into those? --- arch/mips/bcm47x

Re: [PATCH AUTOSEL 4.19 28/57] watchdog: lantiq: update register names to better match spec

2018-11-05 Thread Hauke Mehrtens
On 11/04/2018 02:51 PM, Sasha Levin wrote: > From: Hauke Mehrtens > > [ Upstream commit 1f59f8aff98f200af7a6882184add7b85f5da741 ] > > Some of the names of the bits were confusing to me. > Now the bits share the same prefix as the register they are set on. > > The LTQ_W

Re: [PATCH AUTOSEL 4.19 28/57] watchdog: lantiq: update register names to better match spec

2018-11-05 Thread Hauke Mehrtens
On 11/04/2018 02:51 PM, Sasha Levin wrote: > From: Hauke Mehrtens > > [ Upstream commit 1f59f8aff98f200af7a6882184add7b85f5da741 ] > > Some of the names of the bits were confusing to me. > Now the bits share the same prefix as the register they are set on. > > The LTQ_W

Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

2018-10-07 Thread Hauke Mehrtens
On 10/04/2018 11:08 PM, René Kjellerup wrote: > Hi Hauke, > > thank you for suggesting adding the dts patch to mainline kernel, > so here it is. > I feel Rafal technically still have the copyrights, this is pretty > much just a few string updates for the ea6500v2. However with this > dts in

Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

2018-10-07 Thread Hauke Mehrtens
On 10/04/2018 11:08 PM, René Kjellerup wrote: > Hi Hauke, > > thank you for suggesting adding the dts patch to mainline kernel, > so here it is. > I feel Rafal technically still have the copyrights, this is pretty > much just a few string updates for the ea6500v2. However with this > dts in

[PATCH] phy: lantiq: Fix compile warning

2018-09-25 Thread Hauke Mehrtens
This local variable is unused, remove it. Fixes: dea54fbad332 ("phy: Add an USB PHY driver for the Lantiq SoCs using the RCU module") Signed-off-by: Hauke Mehrtens --- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/lantiq/phy-

[PATCH] phy: lantiq: Fix compile warning

2018-09-25 Thread Hauke Mehrtens
This local variable is unused, remove it. Fixes: dea54fbad332 ("phy: Add an USB PHY driver for the Lantiq SoCs using the RCU module") Signed-off-by: Hauke Mehrtens --- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/lantiq/phy-

Re: [PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3

2018-08-25 Thread Hauke Mehrtens
s Tynkkynen I didn't runtime tested this and didn't checked the board, but this looks good. Acked-by: Hauke Mehrtens > --- > arch/mips/bcm47xx/workarounds.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/mips/bcm47xx/workarounds.c b/arch/mips

Re: [PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3

2018-08-25 Thread Hauke Mehrtens
s Tynkkynen I didn't runtime tested this and didn't checked the board, but this looks good. Acked-by: Hauke Mehrtens > --- > arch/mips/bcm47xx/workarounds.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/mips/bcm47xx/workarounds.c b/arch/mips

Re: [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open coded version

2018-08-25 Thread Hauke Mehrtens
On 08/16/2018 05:58 PM, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang Acked-by: Hauke Mehrtens > --- > drivers/phy/lantiq/phy-lantiq-rcu-us

Re: [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open coded version

2018-08-25 Thread Hauke Mehrtens
On 08/16/2018 05:58 PM, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang Acked-by: Hauke Mehrtens > --- > drivers/phy/lantiq/phy-lantiq-rcu-us

Re: [PATCH v2 04/18] MIPS: dts: Add initial support for Intel MIPS SoCs

2018-08-04 Thread Hauke Mehrtens
On 08/03/2018 05:02 AM, Songjun Wu wrote: > From: Hua Ma > > Add dts files to support Intel MIPS SoCs: > - xrx500.dtsi is the chip dts > - easy350_anywan.dts is the board dts > > Signed-off-by: Hua Ma > Signed-off-by: Songjun Wu > --- > > Changes in v2: > - New patch split from previous

Re: [PATCH v2 04/18] MIPS: dts: Add initial support for Intel MIPS SoCs

2018-08-04 Thread Hauke Mehrtens
On 08/03/2018 05:02 AM, Songjun Wu wrote: > From: Hua Ma > > Add dts files to support Intel MIPS SoCs: > - xrx500.dtsi is the chip dts > - easy350_anywan.dts is the board dts > > Signed-off-by: Hua Ma > Signed-off-by: Songjun Wu > --- > > Changes in v2: > - New patch split from previous

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-04 Thread Hauke Mehrtens
On 08/03/2018 12:30 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 03, 2018 at 03:33:38PM +0800, Wu, Songjun wrote: >> >> >> On 8/3/2018 1:56 PM, Greg Kroah-Hartman wrote: >>> On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote: Previous implementation uses platform-dependent API to get

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-04 Thread Hauke Mehrtens
On 08/03/2018 12:30 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 03, 2018 at 03:33:38PM +0800, Wu, Songjun wrote: >> >> >> On 8/3/2018 1:56 PM, Greg Kroah-Hartman wrote: >>> On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote: Previous implementation uses platform-dependent API to get

[PATCH] freevxfs: Do not inline vxfs_put_page()

2018-06-16 Thread Hauke Mehrtens
vxfs_put_page() is not implemented in a header file, but in a normal c file and used in multiple functions in different c files. Remove the inline attribute as it does not make sense here and causes a link error when LTO is activated. Signed-off-by: Hauke Mehrtens --- fs/freevxfs/vxfs_subr.c

[PATCH] freevxfs: Do not inline vxfs_put_page()

2018-06-16 Thread Hauke Mehrtens
vxfs_put_page() is not implemented in a header file, but in a normal c file and used in multiple functions in different c files. Remove the inline attribute as it does not make sense here and causes a link error when LTO is activated. Signed-off-by: Hauke Mehrtens --- fs/freevxfs/vxfs_subr.c

Re: [PATCH] ARM: dts: BCM5301X: Relicense most DTS files to the GPL 2.0+ / MIT

2018-05-02 Thread Hauke Mehrtens
empt to relicense remaining files will be made separately and will > require approve from more/other developers. > > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> Acked-by: Hauke Mehrtens <ha...@hauke-m.de> > --- > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts| 13 +

Re: [PATCH] ARM: dts: BCM5301X: Relicense most DTS files to the GPL 2.0+ / MIT

2018-05-02 Thread Hauke Mehrtens
be made separately and will > require approve from more/other developers. > > Signed-off-by: Rafał Miłecki Acked-by: Hauke Mehrtens > --- > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts| 13 + > arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts| 13 +--

Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts

2018-04-22 Thread Hauke Mehrtens
off-by: Mathias Kresin <d...@kresin.me> Acked-by: Hauke Mehrtens <ha...@hauke-m.de> > --- > drivers/soc/lantiq/gphy.c | 34 -- > 1 file changed, 34 deletions(-) > > diff --git a/drivers/soc/lantiq/gphy.c b/drivers/soc/lantiq/gphy.c > ind

Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts

2018-04-22 Thread Hauke Mehrtens
und for a wrong syscon-reboot mask. With a > mask set which includes the GPHY resets, these resets aren't required > any more. > > Fixes: 126534141b45 ("MIPS: lantiq: Add a GPHY driver which uses the RCU > syscon-mfd") > Cc: sta...@vger.kernel.org # 4.14+ > Signed-off

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-20 Thread Hauke Mehrtens
On 01/18/2018 09:49 AM, Jonas Bonn wrote: > On 01/17/2018 11:34 PM, Daniel Wagner wrote: >> >> On 01/17/2018 11:20 PM, Hauke Mehrtens wrote: >>> >>> Do we want to do any changes to the kernel header files? I do not know >>> of any clean workarou

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-20 Thread Hauke Mehrtens
On 01/18/2018 09:49 AM, Jonas Bonn wrote: > On 01/17/2018 11:34 PM, Daniel Wagner wrote: >> >> On 01/17/2018 11:20 PM, Hauke Mehrtens wrote: >>> >>> Do we want to do any changes to the kernel header files? I do not know >>> of any clean workarou

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-17 Thread Hauke Mehrtens
On 01/17/2018 08:31 PM, Neil MacLeod wrote: > All > > Further to my previous reply (reproduced below having been bounced by > linux-kernel) I have successfully built LibreELEC when using the > ConnMan patch from Jonas - there were no other failures. > > I have also built a number of network

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-17 Thread Hauke Mehrtens
On 01/17/2018 08:31 PM, Neil MacLeod wrote: > All > > Further to my previous reply (reproduced below having been bounced by > linux-kernel) I have successfully built LibreELEC when using the > ConnMan patch from Jonas - there were no other failures. > > I have also built a number of network

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-17 Thread Hauke Mehrtens
On 01/17/2018 08:59 AM, Daniel Wagner wrote: > Hi Neil, > > On 01/16/2018 07:51 PM, Neil MacLeod wrote: >> Since this commit in 4.15-rc8: >> >> https://github.com/torvalds/linux/commit/6926e041a8920c8ec27e4e155efa760aa01551fd >> >> >> building connman 1.35 with glibc 2.26 now fails as follows:

Re: ipv6 redefinition build issue with 4.15-rc8

2018-01-17 Thread Hauke Mehrtens
On 01/17/2018 08:59 AM, Daniel Wagner wrote: > Hi Neil, > > On 01/16/2018 07:51 PM, Neil MacLeod wrote: >> Since this commit in 4.15-rc8: >> >> https://github.com/torvalds/linux/commit/6926e041a8920c8ec27e4e155efa760aa01551fd >> >> >> building connman 1.35 with glibc 2.26 now fails as follows:

[PATCH v4] uapi libc compat: add fallback for unsupported libcs

2018-01-01 Thread Hauke Mehrtens
glibc are still correct, but this file is not only used for glibc any more. Signed-off-by: Felix Janda <felix.ja...@posteo.de> Reviewed-by: Hauke Mehrtens <ha...@hauke-m.de> --- v4: Extend patch description with comment about glibc comments v3: Fix typos, add a comment to the file and use #if

[PATCH v4] uapi libc compat: add fallback for unsupported libcs

2018-01-01 Thread Hauke Mehrtens
, but this file is not only used for glibc any more. Signed-off-by: Felix Janda Reviewed-by: Hauke Mehrtens --- v4: Extend patch description with comment about glibc comments v3: Fix typos, add a comment to the file and use #ifndef. v2: The only change to the previous version is the commit title

Re: [PATCHv3 resend] uapi libc compat: add fallback for unsupported libcs

2018-01-01 Thread Hauke Mehrtens
ample the following compiler errors when is >> included after musl's : >> >> ./linux/in6.h:32:8: error: redefinition of 'struct in6_addr' >> ./linux/in6.h:49:8: error: redefinition of 'struct sockaddr_in6' >> ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mre

Re: [PATCHv3 resend] uapi libc compat: add fallback for unsupported libcs

2018-01-01 Thread Hauke Mehrtens
ample the following compiler errors when is >> included after musl's : >> >> ./linux/in6.h:32:8: error: redefinition of 'struct in6_addr' >> ./linux/in6.h:49:8: error: redefinition of 'struct sockaddr_in6' >> ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mre

Re: [PATCH] ARM: dts: sun8i: add support for Orange Pi R1

2017-12-28 Thread Hauke Mehrtens
Hi, I tried this device tree file with my Orange Pi R1 and then the Ethernet chip connected to the USB controller is not working. When I set PAD 20 to high the device is found on the USB bus. On 11/12/2017 01:41 PM, Icenowy Zheng wrote: > Orange Pi R1 is a board design based on Orange Pi Zero,

Re: [PATCH] ARM: dts: sun8i: add support for Orange Pi R1

2017-12-28 Thread Hauke Mehrtens
Hi, I tried this device tree file with my Orange Pi R1 and then the Ethernet chip connected to the USB controller is not working. When I set PAD 20 to high the device is found on the USB bus. On 11/12/2017 01:41 PM, Icenowy Zheng wrote: > Orange Pi R1 is a board design based on Orange Pi Zero,

Re: [PATCHv3 resend] uapi libc compat: add fallback for unsupported libcs

2017-12-03 Thread Hauke Mehrtens
ror: redefinition of 'struct sockaddr_in6' > ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq' > > Signed-off-by: Felix Janda <felix.ja...@posteo.de> > Reviewed-by: Hauke Mehrtens <ha...@hauke-m.de> > --- > v3: Fix typos, add a comment to the file and use #

Re: [PATCHv3 resend] uapi libc compat: add fallback for unsupported libcs

2017-12-03 Thread Hauke Mehrtens
ror: redefinition of 'struct sockaddr_in6' > ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq' > > Signed-off-by: Felix Janda > Reviewed-by: Hauke Mehrtens > --- > v3: Fix typos, add a comment to the file and use #ifndef. > v2: The only change to t

Re: [PATCHv3] uapi libc compat: add fallback for unsupported libcs

2017-10-01 Thread Hauke Mehrtens
On 07/29/2017 04:02 PM, Felix Janda wrote: > libc-compat.h aims to prevent symbol collisions between uapi and libc > headers for each supported libc. This requires continuous coordination > between them. > > The goal of this commit is to improve the situation for libcs (such as > musl) which are

Re: [PATCHv3] uapi libc compat: add fallback for unsupported libcs

2017-10-01 Thread Hauke Mehrtens
On 07/29/2017 04:02 PM, Felix Janda wrote: > libc-compat.h aims to prevent symbol collisions between uapi and libc > headers for each supported libc. This requires continuous coordination > between them. > > The goal of this commit is to improve the situation for libcs (such as > musl) which are

Re: linux-next: Signed-off-by missing for commits in the mips tree

2017-09-04 Thread Hauke Mehrtens
Hi Ralf and Martin, On 09/03/2017 11:14 PM, Martin Blumenstingl wrote: > Hi Hauke, Hi Ralf, > > On Sun, Sep 3, 2017 at 6:13 PM, Stephen Rothwell > wrote: >> Hi all, >> >> Commits >> >> bb19a5e5205b MIPS: lantiq: Remove the arch/mips/lantiq/xway/reset.c >> implementation

Re: linux-next: Signed-off-by missing for commits in the mips tree

2017-09-04 Thread Hauke Mehrtens
Hi Ralf and Martin, On 09/03/2017 11:14 PM, Martin Blumenstingl wrote: > Hi Hauke, Hi Ralf, > > On Sun, Sep 3, 2017 at 6:13 PM, Stephen Rothwell > wrote: >> Hi all, >> >> Commits >> >> bb19a5e5205b MIPS: lantiq: Remove the arch/mips/lantiq/xway/reset.c >> implementation >> f6a4de1654c9 MIPS:

Re: [PATCHv3] uapi libc compat: add fallback for unsupported libcs

2017-08-26 Thread Hauke Mehrtens
ror: redefinition of 'struct sockaddr_in6' > ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq' > > Signed-off-by: Felix Janda <felix.ja...@posteo.de> Reviewed-by: Hauke Mehrtens <ha...@hauke-m.de> With this patch + a patch which protects "struct ethhdr"

Re: [PATCHv3] uapi libc compat: add fallback for unsupported libcs

2017-08-26 Thread Hauke Mehrtens
ror: redefinition of 'struct sockaddr_in6' > ./linux/in6.h:59:8: error: redefinition of 'struct ipv6_mreq' > > Signed-off-by: Felix Janda Reviewed-by: Hauke Mehrtens With this patch + a patch which protects "struct ethhdr" I was able to build LEDE with musl libc using thes

Re: [musl] [PATCHv2] uapi libc compat: add fallback for unsupported libcs

2017-07-08 Thread Hauke Mehrtens
On 07/08/2017 10:27 PM, Felix Janda wrote: > libc-compat.h aims to prevent symbol collisions between uapi and libc > headers for each supported libc. This requires continuous coordination > between them. > > The goal of this commit is to improve the situation for libcs (such as > musl) which

Re: [musl] [PATCHv2] uapi libc compat: add fallback for unsupported libcs

2017-07-08 Thread Hauke Mehrtens
On 07/08/2017 10:27 PM, Felix Janda wrote: > libc-compat.h aims to prevent symbol collisions between uapi and libc > headers for each supported libc. This requires continuous coordination > between them. > > The goal of this commit is to improve the situation for libcs (such as > musl) which

Re: [PATCH] MIPS: Lantiq: Fix ASC0/ASC1 clocks

2017-06-03 Thread Hauke Mehrtens
m...@dev.tdt.de> Acked-by: Hauke Mehrtens <ha...@hauke-m.de> > --- > arch/mips/lantiq/xway/sysctrl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c > index 95bec46..cd6dbea 1006

Re: [PATCH] MIPS: Lantiq: Fix ASC0/ASC1 clocks

2017-06-03 Thread Hauke Mehrtens
On 05/30/2017 06:34 AM, Martin Schiller wrote: > ASC1 is available on every Lantiq SoC (also AmazonSE) and should be > enabled like the other generic xway clocks instead of ASC0, which is > only available for AR9 and Danube. This is correct. > Signed-off-by: Martin Schiller Ack

Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

2017-04-25 Thread Hauke Mehrtens
On 03/08/2017 05:39 PM, Carlos O'Donell wrote: > Any header needing compat with a libc includes libc-compat.h (per the > documented way the model works). With this patch any included linux kernel > header that also includes libc-compat.h would immediately define all > the __UAPI_DEF_* constants

Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

2017-04-25 Thread Hauke Mehrtens
On 03/08/2017 05:39 PM, Carlos O'Donell wrote: > Any header needing compat with a libc includes libc-compat.h (per the > documented way the model works). With this patch any included linux kernel > header that also includes libc-compat.h would immediately define all > the __UAPI_DEF_* constants

Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

2017-04-25 Thread Hauke Mehrtens
On 03/08/2017 01:46 PM, David Woodhouse wrote: > On Fri, 2016-11-11 at 07:08 -0500, Felix Janda wrote: >> Currently, libc-compat.h detects inclusion of specific glibc headers, >> and defines corresponding _UAPI_DEF_* macros, which in turn are used in >> uapi headers to prevent definition of

Re: [musl] Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

2017-04-25 Thread Hauke Mehrtens
On 03/08/2017 01:46 PM, David Woodhouse wrote: > On Fri, 2016-11-11 at 07:08 -0500, Felix Janda wrote: >> Currently, libc-compat.h detects inclusion of specific glibc headers, >> and defines corresponding _UAPI_DEF_* macros, which in turn are used in >> uapi headers to prevent definition of

Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-21 Thread Hauke Mehrtens
On 04/20/2017 10:36 PM, David Miller wrote: > From: David Woodhouse > Date: Thu, 20 Apr 2017 21:14:37 +0100 > >> I agree, except I don't think you're going far enough. Those "standard >> names" you mention... some of this stuff actually depends on __GLIBC__, >> and *that*

Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-21 Thread Hauke Mehrtens
On 04/20/2017 10:36 PM, David Miller wrote: > From: David Woodhouse > Date: Thu, 20 Apr 2017 21:14:37 +0100 > >> I agree, except I don't think you're going far enough. Those "standard >> names" you mention... some of this stuff actually depends on __GLIBC__, >> and *that* isn't right either. >

[PATCH v2 1/3] uapi glibc compat: add libc compat code when not build for kernel

2017-04-18 Thread Hauke Mehrtens
. This is based on an older patch from David Heidelberger <david.heidelber...@ixit.cz> Acked-by: Mikko Rapeli <mikko.rap...@iki.fi> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> --- include/uapi/linux/libc-compat.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

[PATCH v2 1/3] uapi glibc compat: add libc compat code when not build for kernel

2017-04-18 Thread Hauke Mehrtens
. This is based on an older patch from David Heidelberger Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index

[PATCH v2 3/3] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-04-18 Thread Hauke Mehrtens
<maillist-li...@barfooze.de> Tested-by: David Heidelberger <david.heidelber...@ixit.cz> Signed-off-by: Jonas Gorski <j...@openwrt.org> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> --- include/uapi/linux/if_ether.h| 3 +++ include/uapi/linux/libc-compat.h | 11 +++ 2 f

[PATCH v2 3/3] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-04-18 Thread Hauke Mehrtens
-by: Hauke Mehrtens --- include/uapi/linux/if_ether.h| 3 +++ include/uapi/linux/libc-compat.h | 11 +++ 2 files changed, 14 insertions(+) diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h index 5bc9bfd816b7..fb5ab8c1e753 100644 --- a/include/uapi/linux

[PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-18 Thread Hauke Mehrtens
. This was compile tested with the user space from LEDE (OpenWrt) with musl 1.1.16, glibc 2.25 and uClibc-ng 1.0.22. Changes since v1: - fix typo in commit message - combine two changes David Heidelberger (1): uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens (2): uapi

[PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-18 Thread Hauke Mehrtens
. This was compile tested with the user space from LEDE (OpenWrt) with musl 1.1.16, glibc 2.25 and uClibc-ng 1.0.22. Changes since v1: - fix typo in commit message - combine two changes David Heidelberger (1): uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens (2): uapi

[PATCH v2 2/3] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-04-18 Thread Hauke Mehrtens
these defines. Acked-by: Mikko Rapeli <mikko.rap...@iki.fi> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 43a81136ea6e..

[PATCH v2 2/3] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-04-18 Thread Hauke Mehrtens
these defines. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 43a81136ea6e..ce2fa8a4ced6 100644 --- a/include/uapi/linux/libc

[PATCH resend 1/4] uapi glibc compat: add libc compat code when not build for kernel

2017-04-12 Thread Hauke Mehrtens
Instead of checking if this header file is used in the glibc, check if iti is not used in kernel context, this way it will also work with other libc implementations like musl. Acked-by: Mikko Rapeli <mikko.rap...@iki.fi> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> --- includ

[PATCH resend 1/4] uapi glibc compat: add libc compat code when not build for kernel

2017-04-12 Thread Hauke Mehrtens
Instead of checking if this header file is used in the glibc, check if iti is not used in kernel context, this way it will also work with other libc implementations like musl. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 8 1 file changed

[PATCH resend 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-04-12 Thread Hauke Mehrtens
__USE_MISC is glibc specific and not available in musl libc. Only do this check when glibc is used. This fixes a problem with musl libc. Acked-by: Mikko Rapeli <mikko.rap...@iki.fi> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> --- include/uapi/linux/libc-compat.h | 4 ++-- 1 fil

[PATCH resend 4/4] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-04-12 Thread Hauke Mehrtens
<maillist-li...@barfooze.de> Tested-by: David Heidelberger <david.heidelber...@ixit.cz> Signed-off-by: Jonas Gorski <j...@openwrt.org> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> --- include/uapi/linux/if_ether.h| 3 +++ include/uapi/linux/libc-compat.h | 11 +++ 2 f

[PATCH resend 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-04-12 Thread Hauke Mehrtens
__USE_MISC is glibc specific and not available in musl libc. Only do this check when glibc is used. This fixes a problem with musl libc. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH resend 4/4] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-04-12 Thread Hauke Mehrtens
-by: Hauke Mehrtens --- include/uapi/linux/if_ether.h| 3 +++ include/uapi/linux/libc-compat.h | 11 +++ 2 files changed, 14 insertions(+) diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h index 5bc9bfd816b7..fb5ab8c1e753 100644 --- a/include/uapi/linux

[PATCH resend 2/4] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-04-12 Thread Hauke Mehrtens
these defines. Acked-by: Mikko Rapeli <mikko.rap...@iki.fi> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de> --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 7c1fead03c50..

[PATCH resend 0/4] uapi glibc compat: fix musl libc compatibility

2017-04-12 Thread Hauke Mehrtens
. This was compile tested with the user space from LEDE (OpenWrt) with musl 1.1.16, glibc 2.25 and uClibc-ng 1.0.22. David Heidelberger (1): uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens (3): uapi glibc compat: add libc compat code when not build for kernel uapi

[PATCH resend 2/4] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-04-12 Thread Hauke Mehrtens
these defines. Acked-by: Mikko Rapeli Signed-off-by: Hauke Mehrtens --- include/uapi/linux/libc-compat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/libc-compat.h b/include/uapi/linux/libc-compat.h index 7c1fead03c50..49a8cc3138ae 100644 --- a/include/uapi/linux/libc

[PATCH resend 0/4] uapi glibc compat: fix musl libc compatibility

2017-04-12 Thread Hauke Mehrtens
. This was compile tested with the user space from LEDE (OpenWrt) with musl 1.1.16, glibc 2.25 and uClibc-ng 1.0.22. David Heidelberger (1): uapi/if_ether.h: prevent redefinition of struct ethhdr Hauke Mehrtens (3): uapi glibc compat: add libc compat code when not build for kernel uapi

Re: [PATCH 0/4] uapi glibc compat: fix musl libc compatibility

2017-03-28 Thread Hauke Mehrtens
On 2017-03-12 23:00, Hauke Mehrtens wrote: The code from libc-compat.h depends on some glibc specific defines and causes compile problems with the musl libc. These patches remove some of the glibc dependencies. With these patches the LEDE (OpenWrt) base user space applications can be build

Re: [PATCH 0/4] uapi glibc compat: fix musl libc compatibility

2017-03-28 Thread Hauke Mehrtens
On 2017-03-12 23:00, Hauke Mehrtens wrote: The code from libc-compat.h depends on some glibc specific defines and causes compile problems with the musl libc. These patches remove some of the glibc dependencies. With these patches the LEDE (OpenWrt) base user space applications can be build

Re: [PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-03-17 Thread Hauke Mehrtens
On 03/16/2017 09:26 AM, Mikko Rapeli wrote: > On Thu, Mar 16, 2017 at 07:59:12AM +, David Woodhouse wrote: >> On Sun, 2017-03-12 at 23:00 +0100, Hauke Mehrtens wrote: >>> __USE_MISC is glibc specific and not available in musl libc. Only do >>> this check whe

  1   2   3   >