Re: [RFC PATCH net] net: phy: fix the issue that netif always links up after resuming

2018-11-29 Thread Heiner Kallweit
On 29.11.2018 09:12, Kunihiko Hayashi wrote: > Even though the link is down before entering hibernation, > there is an issue that the network interface always links up after resuming > from hibernation. > > The phydev->state is PHY_READY before enabling the network interface, so > the link is

Re: Issue with RTL8111 NIC after upgrade to kernel 4.19

2018-11-22 Thread Heiner Kallweit
On 22.11.2018 20:29, Marc Dionne wrote: > On Thu, Nov 22, 2018 at 2:17 PM Heiner Kallweit wrote: >> Thanks a lot for testing. Could you please test also the following >> as an alternative to the delay? >> >> diff --git a/drivers/net/phy/phy_device.c b/drivers/ne

[PATCH net-next v2 2/2] net: phy: remove flag PHY_HAS_INTERRUPT from driver configs

2018-11-08 Thread Heiner Kallweit
Now that flag PHY_HAS_INTERRUPT has been replaced with a check for callbacks config_intr and ack_interrupt, we can remove setting this flag from all driver configs. Last but not least remove flag PHY_HAS_INTERRUPT completely. Signed-off-by: Heiner Kallweit --- v2: - remove flag from all driver

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-10-15 Thread Heiner Kallweit
On 28.09.2018 15:18, Frederic Weisbecker wrote: > On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: >> On Tue, 28 Aug 2018, Frederic Weisbecker wrote: >>> On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: >>>> I tested it and Frederic

Re: [PATCH] r8169: set RX_MULTI_EN bit in RxConfig for 8168F-family chips

2018-10-11 Thread Heiner Kallweit
break; > case RTL_GIGA_MAC_VER_40 ... RTL_GIGA_MAC_VER_51: > Patch should have been flagged as "net". Apart from that: Reviewed-by: Heiner Kallweit

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Heiner Kallweit
On 09.10.2018 16:40, Chris Clayton wrote: > Thanks to Maciej and Heiner for their replies. > > On 09/10/2018 13:32, Maciej S. Szmigiero wrote: >> On 07.10.2018 21:36, Chris Clayton wrote: >>> Hi again, >>> >>> I didn't think there was anything in 4.19-rc7 to fix this regression, but >>> tried it

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Heiner Kallweit
On 09.10.2018 16:40, Chris Clayton wrote: > Thanks to Maciej and Heiner for their replies. > > On 09/10/2018 13:32, Maciej S. Szmigiero wrote: >> On 07.10.2018 21:36, Chris Clayton wrote: >>> Hi again, >>> >>> I didn't think there was anything in 4.19-rc7 to fix this regression, but >>> tried it

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-09-28 Thread Heiner Kallweit
On 29.09.2018 00:00, Chris Clayton wrote: > Thanks Maciej. > > On 28/09/2018 16:54, Maciej S. Szmigiero wrote: >> Hi, >> >>> Hi, >>> >>> I upgraded my kernel to 4.18.10 recently and have since been experiencing >>> network problems after resuming from a >>> suspend to RAM or disk. I previously

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-09-28 Thread Heiner Kallweit
On 28.09.2018 15:18, Frederic Weisbecker wrote: > On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: >> On Tue, 28 Aug 2018, Frederic Weisbecker wrote: >>> On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: >>>> I tested it and Frederic

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-24 Thread Heiner Kallweit
On 24.08.2018 16:30, Frederic Weisbecker wrote: > On Fri, Aug 24, 2018 at 10:01:35AM +0200, Thomas Gleixner wrote: >> On Fri, 24 Aug 2018, Heiner Kallweit wrote: >>> On 24.08.2018 06:12, Frederic Weisbecker wrote: >>>> On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-24 Thread Heiner Kallweit
On 24.08.2018 06:12, Frederic Weisbecker wrote: > On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner Kallweit wrote: >> Recently I started to get warning "NOHZ: local_softirq_pending 202" and >> I think it's related to mentioned commit (didn't bisect it yet). >> See lo

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-18 Thread Heiner Kallweit
On 18.08.2018 13:26, Thomas Gleixner wrote: > On Thu, 16 Aug 2018, Heiner Kallweit wrote: > >> Recently I started to get warning "NOHZ: local_softirq_pending 202" and >> I think it's related to mentioned commit (didn't bisect it yet). >> See log from suspendin

Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-16 Thread Heiner Kallweit
Recently I started to get warning "NOHZ: local_softirq_pending 202" and I think it's related to mentioned commit (didn't bisect it yet). See log from suspending. I have no reason to think the fix is wrong, it may just have revealed another issue which existed before and was hidden by the bug.

Re: [PATCH 2/3] mei: Migrate to pci_alloc_irq_vectors API

2018-08-05 Thread Heiner Kallweit
MSI-X. >> >> Signed-off-by: Heiner Kallweit > > Sorry, we are losing the ONE_SHOT flag here, In spite that pci_enable_msi is > marked as deprecated, ONE_SHOT flag isn't needed here. See commit f7368a550275 ("PCI: Use IRQF_ONESHOT if pci_request_irq() called with no ha

[PATCH 2/3] mei: Migrate to pci_alloc_irq_vectors API

2018-08-03 Thread Heiner Kallweit
Update the driver to the pci_alloc_irq_vectors API, this allows to get rid of legacy calls like pci_enable_msi(). Another benefit is that no driver change would be needed in case the hardware starts supporting MSI-X. Signed-off-by: Heiner Kallweit --- drivers/misc/mei/pci-me.c | 25

[PATCH 3/3] mei: Improve usage of mei_start

2018-08-03 Thread Heiner Kallweit
mei_start() prints an error message and returns -ENODEV on failure, so we don't have to duplicate this in the caller. Signed-off-by: Heiner Kallweit --- drivers/misc/mei/pci-me.c | 6 ++ drivers/misc/mei/pci-txe.c | 6 ++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH 1/3] mei: Don't free irq when suspending

2018-08-03 Thread Heiner Kallweit
Usually it's not needed to free and re-request the interrupt in a suspend / resume cycle, so remove this. Signed-off-by: Heiner Kallweit --- drivers/misc/mei/pci-me.c | 20 drivers/misc/mei/pci-txe.c | 27 +-- 2 files changed, 1 insertion(+), 46

[PATCH 0/3] mei: migrate to pci_alloc_irq_vectors and smaller improvements

2018-08-03 Thread Heiner Kallweit
This series migrates the driver to the pci_alloc_irq_vectors API and includes also smaller improvements. MEI_ME was tested on a Zotac CI321. MEI_TXE is compile-tested only. Heiner Kallweit (3): mei: Don't free irq when suspending mei: Migrate to pci_alloc_irq_vectors API mei: Improve usage

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

2018-08-03 Thread Heiner Kallweit
On 03.08.2018 21:40, Thomas Gleixner wrote: > On Fri, 3 Aug 2018, Heiner Kallweit wrote: >> On 03.08.2018 16:09, Thomas Gleixner wrote: >>> On Wed, 1 Aug 2018, Heiner Kallweit wrote: >>>> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c >>>> index 4ca2f

Re: [PATCH] genirq: Consider domain hierarchy when checking for IRQCHIP_ONESHOT_SAFE

2018-08-03 Thread Heiner Kallweit
On 03.08.2018 22:00, Thomas Gleixner wrote: > On Fri, 3 Aug 2018, Heiner Kallweit wrote: > >> In case of a domain hierarchy we may miss the IRQCHIP_ONESHOT_SAFE >> flag because we look at top of the stack only. See also discussion >> here: https://marc.info/?l=linux-

[PATCH] genirq: Consider domain hierarchy when checking for IRQCHIP_ONESHOT_SAFE

2018-08-03 Thread Heiner Kallweit
In case of a domain hierarchy we may miss the IRQCHIP_ONESHOT_SAFE flag because we look at top of the stack only. See also discussion here: https://marc.info/?l=linux-kernel=153301773524685=2 Signed-off-by: Heiner Kallweit --- Uups, PATCH tag was missing. --- kernel/irq/manage.c | 12

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

2018-08-03 Thread Heiner Kallweit
On 03.08.2018 16:09, Thomas Gleixner wrote: > On Wed, 1 Aug 2018, Heiner Kallweit wrote: >> On 31.07.2018 08:15, Marc Zyngier wrote: >>> On Mon, 30 Jul 2018 23:36:57 +0100, >>> Thomas Gleixner wrote: >>>> >>>> Yes, request for pure t

genirq: Consider domain hierarchy when checking for IRQCHIP_ONESHOT_SAFE

2018-08-03 Thread Heiner Kallweit
In case of a domain hierarchy we may miss the IRQCHIP_ONESHOT_SAFE flag because we look at top of the stack only. See also discussion here: https://marc.info/?l=linux-kernel=153301773524685=2 Signed-off-by: Heiner Kallweit --- kernel/irq/manage.c | 12 +++- 1 file changed, 11 insertions

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

2018-08-01 Thread Heiner Kallweit
On 31.07.2018 08:15, Marc Zyngier wrote: > On Mon, 30 Jul 2018 23:36:57 +0100, > Thomas Gleixner wrote: >> >> On Mon, 30 Jul 2018, Bjorn Helgaas wrote: >> >>> [+cc Thomas, Christoph, LKML] >> >> + Marc >> >>> On Mon, Jul 30, 2018

Re: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts

2018-07-30 Thread Heiner Kallweit
On 30.07.2018 23:30, Bjorn Helgaas wrote: > [+cc Thomas, Christoph, LKML] > > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: >> If we have a threaded interrupt with the handler being NULL, then >> request_threaded_irq() -> __setup_irq() wi

Re: Potential problem with 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")

2018-04-12 Thread Heiner Kallweit
Am 12.04.2018 um 15:30 schrieb Vincent Guittot: > Heiner, Niklas, > > Le Thursday 12 Apr 2018 à 13:15:19 (+0200), Niklas Söderlund a écrit : >> Hi Vincent, >> >> Thanks for your feedback. >> >> On 2018-04-12 12:33:27 +0200, Vincent Guittot wrote: >>> Hi Niklas, >>> >>> On 12 April 2018 at 11:18,

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-04-11 Thread Heiner Kallweit
Am 11.04.2018 um 19:00 schrieb Vincent Guittot: > Hi Heiner, > > On 9 April 2018 at 19:33, Heiner Kallweit <hkallwe...@gmail.com> wrote: >> Am 06.04.2018 um 18:03 schrieb Vincent Guittot: >>> Hi Heiner, >>> >>> On 30 March 2018 at 10:37, Heine

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-04-09 Thread Heiner Kallweit
Am 06.04.2018 um 18:03 schrieb Vincent Guittot: > Hi Heiner, > > On 30 March 2018 at 10:37, Heiner Kallweit <hkallwe...@gmail.com> wrote: >> Am 30.03.2018 um 08:50 schrieb Vincent Guittot: >>> On 29 March 2018 at 19:40, Heiner Kallweit <hkallwe...@gmail.com>

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-04-06 Thread Heiner Kallweit
Am 06.04.2018 um 18:03 schrieb Vincent Guittot: > Hi Heiner, > > On 30 March 2018 at 10:37, Heiner Kallweit <hkallwe...@gmail.com> wrote: >> Am 30.03.2018 um 08:50 schrieb Vincent Guittot: >>> On 29 March 2018 at 19:40, Heiner Kallweit <hkallwe...@gmail.com>

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-03-30 Thread Heiner Kallweit
Am 30.03.2018 um 08:50 schrieb Vincent Guittot: > On 29 March 2018 at 19:40, Heiner Kallweit <hkallwe...@gmail.com> wrote: >> Am 29.03.2018 um 09:41 schrieb Vincent Guittot: > >>> >>> I'm finally not so sure that i have the right set up to reproduce th

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-03-29 Thread Heiner Kallweit
Am 29.03.2018 um 09:41 schrieb Vincent Guittot: > On 28 March 2018 at 16:01, Vincent Guittot <vincent.guit...@linaro.org> wrote: >> Hi, >> >> On 28 March 2018 at 12:37, Dietmar Eggemann <dietmar.eggem...@arm.com> wrote: >>> Hi, >>> >>>

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-03-24 Thread Heiner Kallweit
Am 24.03.2018 um 07:46 schrieb Vincent Guittot: > Hi Heiner, > > Le Friday 23 Mar 2018 à 22:28:09 (+0100), Heiner Kallweit a écrit : >> Recently I started to get the following problems with linux-next: >> >> - When working via Putty/SSH on the system the console freq

Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-03-23 Thread Heiner Kallweit
Recently I started to get the following problems with linux-next: - When working via Putty/SSH on the system the console frequently freezes for few seconds. Sometimes only opening a second console makes the first one react again. - I get "INFO: rcu_sched detected stalls on CPUs/tasks:"

Recent kernel change causing "rcu_sched detected stalls on CPUs/tasks"

2018-03-22 Thread Heiner Kallweit
Recently I started to get the following sporadic errors. Maybe related: When working with putty on the console then console frequently hangs for few seconds. linux-next from March 2nd still works fine. Platform is x86_64, Zotac CI-321 with Intel 2961Y. [ 9755.298719] INFO: rcu_sched detected

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

2018-03-05 Thread Heiner Kallweit
Am 05.03.2018 um 09:19 schrieb Kirill A. Shutemov: > On Sat, Mar 03, 2018 at 12:46:28PM +0100, Heiner Kallweit wrote: >> Am 03.03.2018 um 11:02 schrieb Ingo Molnar: >>> >>> * Heiner Kallweit <hkallwe...@gmail.com> wrote: >>> >>>> Am 03.03.2018

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

2018-03-03 Thread Heiner Kallweit
Am 03.03.2018 um 11:02 schrieb Ingo Molnar: > > * Heiner Kallweit <hkallwe...@gmail.com> wrote: > >> Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui: >>> On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallwe...@gmail.com >>> <mailto:hkallwe...@gm

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

2018-03-02 Thread Heiner Kallweit
Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui: > On Fri, Mar 2, 2018 at 12:57 PM, Heiner Kallweit <hkallwe...@gmail.com > <mailto:hkallwe...@gmail.com>> wrote: > > Recently my Mini PC Zotac CI-321 started to reboot immediately before > anything

"x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

2018-03-02 Thread Heiner Kallweit
Recently my Mini PC Zotac CI-321 started to reboot immediately before anything was written to the console. Bisecting lead to b91993a87aff "x86/boot/compressed/64: Prepare trampoline memory" being the change breaking boot. If you need any more information, please let me know. Rgds, Heiner

Re: [PATCH] eeprom: at24: check the return value of nvmem_unregister()

2017-12-28 Thread Heiner Kallweit
Am 28.12.2017 um 22:42 schrieb Bartosz Golaszewski: > 2017-12-28 12:28 GMT+01:00 Johan Hovold : >> On Wed, Dec 27, 2017 at 03:10:38PM +0100, Bartosz Golaszewski wrote: >>> This function can fail with -EBUSY, but we don't check its return >>> value in at24_remove(). Bail-out of

[PATCH v6 3/3] eeprom: at24: switch to device-managed version of i2c_new_dummy

2017-12-19 Thread Heiner Kallweit
Make use of recently introduced device-managed version of i2c_new_dummy to simplify the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - small improvements regarding code readability v3: - no changes v4: - no changes v5: - no changes v6: - rebased --- drivers/misc/

[PATCH v6 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy

2017-12-19 Thread Heiner Kallweit
with detailed error codes within the i2c core or for API extensions. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Reviewed-by: Bartosz Golaszewski <b...@bgdev.pl> --- v3: - prefix i2c_new_device and i2c_new_dummy with two underscores instead one v4: - add missing kernel doc -

[PATCH v6 2/3] i2c: core: add device-managed version of i2c_new_dummy

2017-12-19 Thread Heiner Kallweit
case return value type: i2c_new_dummy returns NULL whilst devm_new_i2c_dummy returns an ERR_PTR. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - use new function _i2c_new_dummy with detailed error codes v3: - no changes v4: - reflect renaming to __i2c_new_dummy v5: - i

[PATCH v6 0/3] i2c: introduce devm_i2c_new_dummy and use it in at24 driver

2017-12-19 Thread Heiner Kallweit
doc comments - add Reviewed-by Changes in v5: - fix a copy & paste error in patch 1 - improve readability in patch 2 Changes in v5: - cosmetic change in patch 1 - patch 3 rebased on top of latest at24/for-next Heiner Kallweit (3): i2c: core: improve return value handling of i2c_new_de

[PATCH v5 3/3] eeprom: at24: switch to device-managed version of i2c_new_dummy

2017-12-15 Thread Heiner Kallweit
Make use of recently introduced device-managed version of i2c_new_dummy to simplify the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - small improvements regarding code readability v3: - no changes v4: - no changes v5: - no changes --- drivers/misc/eeprom/at24.

[PATCH v5 2/3] i2c: core: add device-managed version of i2c_new_dummy

2017-12-15 Thread Heiner Kallweit
case return value type: i2c_new_dummy returns NULL whilst devm_new_i2c_dummy returns an ERR_PTR. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - use new function _i2c_new_dummy with detailed error codes v3: - no changes v4: - reflect renaming to __i2c_new_dummy v5: - i

[PATCH v5 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy

2017-12-15 Thread Heiner Kallweit
with detailed error codes within the i2c core or for API extensions. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Reviewed-by: Bartosz Golaszewski <b...@bgdev.pl> --- v3: - prefix i2c_new_device and i2c_new_dummy with two underscores instead one v4: - add missing kernel doc -

[PATCH v5 0/3] i2c: introduce devm_i2c_new_dummy and use it in at24 driver

2017-12-15 Thread Heiner Kallweit
doc comments - add Reviewed-by Changes in v5: - fix a copy & paste error in patch 1 - improve readability in patch 2 Heiner Kallweit (3): i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy i2c: core: add device-managed version of i2c_new_dummy eeprom: at24: sw

Re: [PATCH v4 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy

2017-12-15 Thread Heiner Kallweit
Am 15.12.2017 um 23:02 schrieb Bartosz Golaszewski: > 2017-12-15 18:43 GMT+01:00 Heiner Kallweit <hkallwe...@gmail.com>: >> Currently i2c_new_device and i2c_new_dummy return just NULL in error >> case although they have more error details internally. Therefore move >>

[PATCH v4 2/3] i2c: core: add device-managed version of i2c_new_dummy

2017-12-15 Thread Heiner Kallweit
case return value type: i2c_new_dummy returns NULL whilst devm_new_i2c_dummy returns an ERR_PTR. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Reviewed-by: Bartosz Golaszewski <b...@bgdev.pl> --- v2: - use new function _i2c_new_dummy with detailed error codes v3: - no changes v

[PATCH v4 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy

2017-12-15 Thread Heiner Kallweit
with detailed error codes within the i2c core or for API extensions. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Reviewed-by: Bartosz Golaszewski <b...@bgdev.pl> --- v3: - prefix i2c_new_device and i2c_new_dummy with two underscores instead one v4: - add missing kernel doc -

[PATCH v4 3/3] eeprom: at24: switch to device-managed version of i2c_new_dummy

2017-12-15 Thread Heiner Kallweit
Make use of recently introduced device-managed version of i2c_new_dummy to simplify the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Reviewed-by: Bartosz Golaszewski <b...@bgdev.pl> --- v2: - small improvements regarding code readability v3: - no changes v4:

[PATCH v4 0/3] i2c: introduce devm_i2c_new_dummy and use it in at24 driver

2017-12-15 Thread Heiner Kallweit
doc comments - add Reviewed-by Heiner Kallweit (3): i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy i2c: core: add device-managed version of i2c_new_dummy eeprom: at24: switch to device-managed version of i2c_new_dummy Documentation/driver-model/devres.txt | 3

[PATCH v3 2/3] i2c: core: add device-managed version of i2c_new_dummy

2017-12-13 Thread Heiner Kallweit
case return value type: i2c_new_dummy returns NULL whilst devm_new_i2c_dummy returns an ERR_PTR. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - use new function _i2c_new_dummy with detailed error codes v3: - no changes --- Documentation/driver-model/devres.txt | 3 +++ d

[PATCH v3 3/3] eeprom: at24: switch to device-managed version of i2c_new_dummy

2017-12-13 Thread Heiner Kallweit
Make use of recently introduced device-managed version of i2c_new_dummy to simplify the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - small improvements regarding code readability v3: - no changes --- drivers/misc/eeprom/at24.c | 31 +++

[PATCH v3 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy

2017-12-13 Thread Heiner Kallweit
with detailed error codes within the i2c core or for API extensions. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v3: - prefix i2c_new_device and i2c_new_dummy with two underscores instead one --- drivers/i2c/i2c-core-base.c | 46 -

[PATCH v3 0/3] i2c: introduce devm_i2c_new_dummy and use it in at24 driver

2017-12-13 Thread Heiner Kallweit
the first user of the new function. Changes in v2: - add change to i2c core to make a version of i2c_new_device available which returns an ERR_PTR instead of NULL in error case - few minor improvements Changes in v3: - rename _i2c_new_device to __i2c_new_device Heiner Kallweit (3): i2c: core

[PATCH v2 3/3] eeprom: at24: switch to device-managed version of i2c_new_dummy

2017-12-06 Thread Heiner Kallweit
Make use of recently introduced device-managed version of i2c_new_dummy to simplify the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - small improvements regarding code readability --- drivers/misc/eeprom/at24.c | 31 +++ 1 file chang

[PATCH v2 2/3] i2c: core: add device-managed version of i2c_new_dummy

2017-12-06 Thread Heiner Kallweit
case return value type: i2c_new_dummy returns NULL whilst devm_new_i2c_dummy returns an ERR_PTR. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - use new function _i2c_new_dummy with detailed error codes --- Documentation/driver-model/devres.txt | 3 +++ drivers/i2c/i2

[PATCH v2 1/3] i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy

2017-12-06 Thread Heiner Kallweit
with detailed error codes within the i2c core or for API extensions. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- drivers/i2c/i2c-core-base.c | 46 - 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/i2c-core-ba

[PATCH v2 0/3] i2c: introduce devm_i2c_new_dummy and use it in at24 driver

2017-12-06 Thread Heiner Kallweit
the first user of the new function. Changes in v2: - add change to i2c core to make a version of i2c_new_device available which returns an ERR_PTR instead of NULL in error case - few minor improvements Heiner Kallweit (3): i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy

Re: [PATCH resubmit 1/2] i2c: core: add device-managed version of i2c_new_dummy

2017-12-06 Thread Heiner Kallweit
Am 06.12.2017 um 11:36 schrieb Bartosz Golaszewski: > 2017-12-05 20:44 GMT+01:00 Heiner Kallweit <hkallwe...@gmail.com>: >> i2c_new_dummy is typically called from the probe function of the >> driver for the primary i2c client. It requires calls to >> i2c_unregist

[PATCH resubmit 2/2] eeprom: at24: switch to device-managed version of i2c_new_dummy

2017-12-05 Thread Heiner Kallweit
Make use of recently introduced device-managed version of i2c_new_dummy to simplify the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- drivers/misc/eeprom/at24.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/misc/eeprom/at

[PATCH resubmit 1/2] i2c: core: add device-managed version of i2c_new_dummy

2017-12-05 Thread Heiner Kallweit
case return value type: i2c_new_dummy returns NULL whilst devm_new_i2c_dummy returns an ERR_PTR. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> Reviewed-by: Peter Rosin <p...@axentia.se> --- Documentation/driver-model/devres.txt | 3 +++ drivers/i2c/i2c-core-base.c

[PATCH 0/2] i2c: introduce devm_i2c_new_dummy and use it in at24 driver

2017-12-05 Thread Heiner Kallweit
the first user of the new function. Patch 1 has been submitted and reviewed some time ago, however it was waiting for a first user until now. Heiner Kallweit (2): i2c: core: add device-managed version of i2c_new_dummy eeprom: at24: switch to device-managed version of i2c_new_dummy Documentation

Re: linux-next: build warning after merge of the net-next tree

2017-12-03 Thread Heiner Kallweit
Am 04.12.2017 um 01:02 schrieb Stephen Rothwell: > Hi all, > > After merging the net-next tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but > not used [-Wunused-function] > static

Re: [GIT PULL] revert ARM SCPI changes for v4.15-rc1

2017-12-03 Thread Heiner Kallweit
Am 03.12.2017 um 02:04 schrieb Olof Johansson: > On Fri, Dec 01, 2017 at 11:53:05AM -0800, Kevin Hilman wrote: >> Arnd, Olof, >> >> These ARM SCPI changes caused SCPI regressions resulting in CPUfreq >> failures on most Amlogic SoCs (found by kernelci.org.) >> >> Unfortunately, this was not caught

Re: [PATCH] eeprom: at24: correctly set the size for at24mac402

2017-11-28 Thread Heiner Kallweit
Am 28.11.2017 um 13:09 schrieb Andy Shevchenko: > On Mon, Nov 27, 2017 at 11:06 PM, Bartosz Golaszewski wrote: >> There's an ilog2() expansion in AT24_DEVICE_MAGIC() which rounds down >> the actual size of EUI-48 byte array in at24mac402 eeproms to 4 from 6, >> making it impossible

Re: [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig

2017-11-28 Thread Heiner Kallweit
Am 28.11.2017 um 18:09 schrieb Randy Dunlap: > On 11/27/2017 11:12 PM, Heiner Kallweit wrote: >> I have a little bit of a hard time to find the right addressee for >> this patch because there is no maintainer entry for drivers/firmware. >> Can you apply the following through

[PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig

2017-11-27 Thread Heiner Kallweit
I have a little bit of a hard time to find the right addressee for this patch because there is no maintainer entry for drivers/firmware. Can you apply the following through your tree? Add missing entry for firmware subdirectory in drivers/Kconfig. Signed-off-by: Heiner Kallweit <hkal

Re: [PATCH] eeprom: at24: fix the magic value for at24mac402

2017-11-27 Thread Heiner Kallweit
Am 27.11.2017 um 13:28 schrieb Bartosz Golaszewski: > There's an ilog2() expansion in AT24_DEVICE_MAGIC() which rounds down > the actual size of EUI-48 byte array in at24mac402 eeproms to 4 from 6, > making it impossible to read it all. > > Fix it by creating the magic value manually with the

[PATCH] nvmem: core: let stride and word_size default to 1

2017-11-25 Thread Heiner Kallweit
If the caller doesn't set stride and/or word_size in struct nvmem_config then nvmem_register accepts this but we may face strange effects later due to both values being 0. Therefore use 1 as default for both values. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- drivers/nvmem/

[PATCH] nvmem: core: switch to device_property_present for reading property "read-only"

2017-11-25 Thread Heiner Kallweit
Switch to more generic device_property_present to consider also non-DT properties. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- drivers/nvmem/core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 5a5

[PATCH] nvmem: core: change of_property_read_bool to device_property_present in nvmem_register

2017-08-20 Thread Heiner Kallweit
When checking for property "read-only" it's better to use the more generic device_property_present as in addition to device tree nodes it also covers other node types like ACPI nodes. In addition switch to a logical or. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --

Re: linux-next: build warning after merge of the rtc tree

2017-07-05 Thread Heiner Kallweit
Am 06.07.2017 um 06:24 schrieb Stephen Rothwell: > Hi Alexandre, > > After merging the rtc tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > drivers/rtc/rtc-ds1307.c: In function 'ds1307_get_time': > drivers/rtc/rtc-ds1307.c:342:26: warning: unused variable

[tip:irq/urgent] genirq: Release resources in __setup_irq() error path

2017-06-12 Thread tip-bot for Heiner Kallweit
Commit-ID: fa07ab72cbb0d843429e61bf179308aed6cbe0dd Gitweb: http://git.kernel.org/tip/fa07ab72cbb0d843429e61bf179308aed6cbe0dd Author: Heiner Kallweit <hkallwe...@gmail.com> AuthorDate: Sun, 11 Jun 2017 00:38:36 +0200 Committer: Thomas Gleixner <t...@linutronix.de> CommitD

[PATCH] genirq: fix error path in __setup_irq

2017-06-10 Thread Heiner Kallweit
If __irq_set_trigger() fails irq_request_resources() was successfully called before. Therefore we should release all potentially claimed resources in the error path. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- kernel/irq/manage.c | 4 +++- 1 file changed, 3 insertions

Re: [PATCH] nvmem: core: add managed version of nvmem_register

2017-06-08 Thread Heiner Kallweit
Am 08.06.2017 um 08:26 schrieb Srinivas Kandagatla: > > > On 07/06/17 22:55, Heiner Kallweit wrote: >> Am 07.06.2017 um 18:19 schrieb Srinivas Kandagatla: >>> >>> On 04/06/17 12:06, Heiner Kallweit wrote: >>>> Add a device-managed version of nv

Re: [PATCH 1/3] nvmem: core: remove member users from struct nvmem_device

2017-06-07 Thread Heiner Kallweit
Am 07.06.2017 um 17:30 schrieb Srinivas Kandagatla: > > > On 04/06/17 12:01, Heiner Kallweit wrote: >> Member users is used only to check whether we're allowed to remove >> the module. So in case of built-in it's not used at all and in case > > nvmem providers doe

Re: [PATCH] nvmem: core: add managed version of nvmem_register

2017-06-07 Thread Heiner Kallweit
Am 07.06.2017 um 18:19 schrieb Srinivas Kandagatla: > > On 04/06/17 12:06, Heiner Kallweit wrote: >> Add a device-managed version of nvmem_register. >> >> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> >> --- >> Documentation/nvmem/nvmem.txt | 1

[PATCH] nvmem: core: add managed version of nvmem_register

2017-06-04 Thread Heiner Kallweit
Add a device-managed version of nvmem_register. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- Documentation/nvmem/nvmem.txt | 1 + drivers/nvmem/core.c | 35 +++ include/linux/nvmem-provider.h | 7 +++ 3 files changed, 43 inse

[PATCH 1/3] nvmem: core: remove member users from struct nvmem_device

2017-06-04 Thread Heiner Kallweit
users isn't needed. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- drivers/nvmem/core.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 8c830a80..4e07f3f8 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/

[PATCH 3/3] nvmem: core: remove nvmem_mutex

2017-06-04 Thread Heiner Kallweit
Mutex nvmem_mutex is used in __nvmem_device_get only and isn't needed due to: - of_nvmem_find just calls bus_find_device which doesn't need locking - nvmem_find_cell is protected by nvmem_cells_mutex Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- drivers/nvmem/core.

[PATCH 2/3] nvmem: core: add locking to nvmem_find_cell

2017-06-04 Thread Heiner Kallweit
Adding entries to nvmem_cells and deleting entries from it is protected by nvmem_cells_mutex. Therefore this mutex should also protect iterating over the list. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- drivers/nvmem/core.c | 8 +++- 1 file changed, 7 insertions(+), 1 de

[PATCH 0/3] nvmem: core: series with smaller refactorings

2017-06-04 Thread Heiner Kallweit
Series with smaller refactorings of the nvmem core. Heiner Kallweit (3): nvmem: core: remove member users from struct nvmem_device nvmem: core: add locking to nvmem_find_cell nvmem: core: remove nvmem_mutex drivers/nvmem/core.c | 37 + 1 file changed, 9

Re: linux-next: build failure after merge of the rtc tree

2017-05-30 Thread Heiner Kallweit
Am 31.05.2017 um 06:33 schrieb Stephen Rothwell: > Hi Alexandre, > > After merging the rtc tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe': > drivers/rtc/rtc-ds1307.c:1410:29: error: 'struct ds1307' has no

Why does callback irq_startup in struct irq_chip return _unsigned_ int ?

2017-05-25 Thread Heiner Kallweit
Hi Thomas, just by chance I noticed that callback irq_startup in struct irq_chip returns an unsigned int. This doesn't seem to make sense as the result is a normal retval which is casted to a signed int in function irq_startup() anyway. Is there any specific reason for this or is it simply a

Re: [PATCH] mmc:dw_mmc-k3: add sd support for hi3660

2017-05-16 Thread Heiner Kallweit
Am 16.05.2017 um 14:26 schrieb liwei: > Add sd card support for hi3660 soc > > Signed-off-by: Li Wei > Signed-off-by: Chen Jun > --- > drivers/mmc/host/dw_mmc-k3.c | 311 > +++ > 1 file changed, 311

[tip:irq/core] genirq/devres: Use dev_name(dev) as default for devname

2017-02-12 Thread tip-bot for Heiner Kallweit
Commit-ID: 899b5fbf9d3fcb721690b4d58cf58cc018517003 Gitweb: http://git.kernel.org/tip/899b5fbf9d3fcb721690b4d58cf58cc018517003 Author: Heiner Kallweit <hkallwe...@gmail.com> AuthorDate: Sun, 12 Feb 2017 16:31:44 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitD

[PATCH] genirq: devres: use dev_name(dev) as default for devname

2017-02-12 Thread Heiner Kallweit
Allow the devname parameter to be NULL and use dev_name(dev) in this case. This should be an appropriate default for most use cases. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- kernel/irq/devres.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/

Re: Optional regulators in bulk operations - reverted patch

2017-01-31 Thread Heiner Kallweit
Am 31.01.2017 um 22:43 schrieb Heiner Kallweit: > Hi Bjorn, > > I just came across a use case where I wanted to deal with optional > regulators in bulk operations. I was about to submit a related > patch when I saw that you submitted basically the same in > 3ff3f518a135 "r

Optional regulators in bulk operations - reverted patch

2017-01-31 Thread Heiner Kallweit
Hi Bjorn, I just came across a use case where I wanted to deal with optional regulators in bulk operations. I was about to submit a related patch when I saw that you submitted basically the same in 3ff3f518a135 "regulator: Make bulk API support optional supplies" and reverted it later stating

Re: [PATCH v3 0/6] Add support for IR transmitters

2016-11-02 Thread Heiner Kallweit
Am 02.11.2016 um 11:40 schrieb Andi Shyti: > Hi, > > The main goal is to add support in the rc framework for IR > transmitters, which currently is only supported by lirc but that > is not the preferred way. > > The last patch adds support for an IR transmitter driven by > the MOSI line of an SPI

Merge problem: Re: Applied "spi: fsl-espi: avoid processing uninitalized data on error" to the spi tree

2016-10-26 Thread Heiner Kallweit
Am 26.10.2016 um 12:15 schrieb Mark Brown: > The patch > >spi: fsl-espi: avoid processing uninitalized data on error > > has been applied to the spi tree at > >git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git > > All being well this means that it will be integrated into

Re: [PATCH 17/28] spi: fsl-espi: avoid processing uninitalized data on error

2016-10-24 Thread Heiner Kallweit
Am 24.10.2016 um 19:27 schrieb Mark Brown: > On Tue, Oct 18, 2016 at 12:13:38AM +0200, Arnd Bergmann wrote: >> When we get a spurious interrupt in fsl_espi_irq, we end up >> processing four uninitalized bytes of data, as shown in this >> warning message: > > This doesn't apply against current

Re: [PATCH] hid-led.c: remove unneccessary underscores

2016-10-07 Thread Heiner Kallweit
Am 07.10.2016 um 18:25 schrieb Benjamin Tissoires: > On Oct 03 2016 or thereabouts, Pavel Machek wrote: >> On Mon 2016-10-03 10:16:26, Pavel Machek wrote: >>> >>> u8 (and friends) can be used directly in kernel sources (not kernel >>> headers). >>> >>> Signed-off-by: Pavel Machek >>

[PATCH v2 6/7] leds: gpio: switch to managed version of led_classdev_register

2016-09-14 Thread Heiner Kallweit
Using the managed version of led_classdev_register allows to significantly simplify the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - rebased due to removal of patch 2 of the original series --- drivers/leds/leds-gpio.c | 23 ++- 1 file chan

[PATCH v2 4/7] leds: gpio: simplify gpio_leds_create

2016-09-14 Thread Heiner Kallweit
Definition of np can be moved into the loop as well to simplify the code a little. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - rebased due to removal of patch 2 of the original series --- drivers/leds/leds-gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH v2 5/7] leds: gpio: fix and simplify reading property "label"

2016-09-14 Thread Heiner Kallweit
Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - rebased due to removal of patch 2 of the original series --- drivers/leds/leds-gpio.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index

[PATCH v2 1/7] leds: gpio: introduce gpio_blink_set_t

2016-09-14 Thread Heiner Kallweit
Introduce a typedef gpio_blink_set_t to improve readability of the code. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - no change --- drivers/leds/leds-gpio.c | 6 ++ include/linux/leds.h | 9 ++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff

[PATCH v2 2/7] leds: gpio: fix an unhandled error case in create_gpio_led

2016-09-14 Thread Heiner Kallweit
gpiod_get_value_cansleep returns 0, 1, or an error code. So far errors are not handled and treated the same as 1. Change this to bail out if an error code is returned and remove the double negation. Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> --- v2: - rebased due to removal of p

  1   2   >