[tip:sched/core] sched/debug: Initialize sd_sysctl_cpus if !CONFIG_CPUMASK_OFFSTACK

2019-02-04 Thread tip-bot for Hidetoshi Seto
Commit-ID: 1ca4fa3ab604734e38e2a3000c9abf788512ffa7 Gitweb: https://git.kernel.org/tip/1ca4fa3ab604734e38e2a3000c9abf788512ffa7 Author: Hidetoshi Seto AuthorDate: Tue, 29 Jan 2019 10:12:45 -0500 Committer: Ingo Molnar CommitDate: Mon, 4 Feb 2019 09:13:21 +0100 sched/debug: Initialize

[PATCH 8/8] cputime: iowait aware idle tick accounting

2014-06-26 Thread Hidetoshi Seto
By changes in vtime* codes by previous patches, now account_idle_time() become a function to be called only from tick-accounting codes. Introduce __account_idle_ticks() to do iowait accounting in ticks properly. For this purpose record jiffies at end of iowait. Not-Tested-by: Hidetoshi Seto

[PATCH 7/8] cputime: generic iowait accounting for VIRT_CPU_ACCOUNTING

2014-06-26 Thread Hidetoshi Seto
Get iowait's timestamp for accounting w/ VIRT_CPU_ACCOUNTING_GEN. (currently arm is only user of this?) At last of this series of changes, introduce common function vtime_iowait_exit to replace all arch_record_iowait_exit. Not-tested-by: Hidetoshi Seto --- arch/ia64/include/asm/cputime.h

[PATCH 6/8] cputime, ppc: update iowait accounting

2014-06-26 Thread Hidetoshi Seto
Like s390 and ia64, ppc also has VIRT_CPU_ACCOUNTING. Check "timestamp at end of iowait" for idle/iowait accounting. Not-Tested-by: Hidetoshi Seto --- arch/powerpc/include/asm/cputime.h |3 +++ arch/powerpc/kernel/time.c | 21 + 2 files changed, 20

[PATCH 5/8] cputime, ia64: update iowait accounting

2014-06-26 Thread Hidetoshi Seto
Using VIRT_CPU_ACCOUNTING, ia64 utilize "timestamp at end of iowait" like s390. Not-Tested-by: Hidetoshi Seto --- arch/ia64/include/asm/cputime.h |2 + arch/ia64/kernel/time.c | 43 ++- 2 files changed, 44 insertions(+), 1 deletion

[PATCH 4/8] cputime, s390: introduce s390_get_idle_and_iowait

2014-06-26 Thread Hidetoshi Seto
s390_get_idle_time give us the duration from idle entry to now. But it does not tell us how to divide it to idle and iowait. Modify this function to return 2 values. To realize this, s390's cputime accounting also requires timestamp at end of iowait. Not-Tested-by: Hidetoshi Seto --- arch/s390

[PATCH 3/8] cputime: introduce account_idle_and_iowait

2014-06-26 Thread Hidetoshi Seto
The current account_idle_time() cannot process mixed cputime which contain both of idle cputime and iowait cputime. So introduce new account_idle_and_iowait() to do paranoid work. Following patches will add users of this new function. Not-Tested-by: Hidetoshi Seto --- kernel/sched/cputime.c

[PATCH 2/8] cputime, nohz: handle last_iowait for nohz

2014-06-26 Thread Hidetoshi Seto
Now observer cpu can refer both of idle entry time and iowait exit time of observed sleeping cpu, so observer can get idle/iowait time of sleeping cpu by calculating cputimes not accounted yet. Not-Tested-by: Hidetoshi Seto --- include/linux/sched.h|1 + kernel/sched/core.c | 27

[PATCH 1/8] cputime, sched: record last_iowait

2014-06-26 Thread Hidetoshi Seto
Suggested-by: Peter Zijlstra Not-Tested-by: Hidetoshi Seto --- kernel/sched/core.c| 40 kernel/sched/cputime.c |2 +- kernel/sched/sched.h |4 +++- 3 files changed, 32 insertions(+), 14 deletions(-) diff --git a/kernel/sched/core.c b/kerne

[RFC PATCH 0/8] rework iowait accounting

2014-06-26 Thread Hidetoshi Seto
/pub/linux/kernel/people/wli/vm/iowait/iowait-2.5.45-6 Thanks, H.Seto --- Hidetoshi Seto (8): cputime, sched: record last_iowait cputime, nohz: handle last_iowait for nohz cputime: introduce account_idle_and_iowait cputime, s390: introduce s390_get_idle_and_iowait cpu

[PATCH] nohz: make updating sleep stats local, add seqcount

2014-06-26 Thread Hidetoshi Seto
. update patch description, separate from following changes. (patch body does not changed from 1/2 of v4) v1-4: https://lkml.org/lkml/2014/4/17/120 Signed-off-by: Hidetoshi Seto Reported-by: Fernando Luis Vazquez Cao Reported-by: Tetsuo Handa Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc

[PATCH] nohz: make updating sleep stats local, add seqcount

2014-06-26 Thread Hidetoshi Seto
. update patch description, separate from following changes. (patch body does not changed from 1/2 of v4) v1-4: https://lkml.org/lkml/2014/4/17/120 Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reported-by: Fernando Luis Vazquez Cao fernando...@lab.ntt.co.jp Reported-by: Tetsuo

[RFC PATCH 0/8] rework iowait accounting

2014-06-26 Thread Hidetoshi Seto
/kernel/people/wli/vm/iowait/iowait-2.5.45-6 Thanks, H.Seto --- Hidetoshi Seto (8): cputime, sched: record last_iowait cputime, nohz: handle last_iowait for nohz cputime: introduce account_idle_and_iowait cputime, s390: introduce s390_get_idle_and_iowait cputime, ia64

[PATCH 1/8] cputime, sched: record last_iowait

2014-06-26 Thread Hidetoshi Seto
Zijlstra pet...@infradead.org Not-Tested-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- kernel/sched/core.c| 40 kernel/sched/cputime.c |2 +- kernel/sched/sched.h |4 +++- 3 files changed, 32 insertions(+), 14 deletions(-) diff --git

[PATCH 2/8] cputime, nohz: handle last_iowait for nohz

2014-06-26 Thread Hidetoshi Seto
Now observer cpu can refer both of idle entry time and iowait exit time of observed sleeping cpu, so observer can get idle/iowait time of sleeping cpu by calculating cputimes not accounted yet. Not-Tested-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- include/linux/sched.h|1

[PATCH 3/8] cputime: introduce account_idle_and_iowait

2014-06-26 Thread Hidetoshi Seto
The current account_idle_time() cannot process mixed cputime which contain both of idle cputime and iowait cputime. So introduce new account_idle_and_iowait() to do paranoid work. Following patches will add users of this new function. Not-Tested-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com

[PATCH 4/8] cputime, s390: introduce s390_get_idle_and_iowait

2014-06-26 Thread Hidetoshi Seto
s390_get_idle_time give us the duration from idle entry to now. But it does not tell us how to divide it to idle and iowait. Modify this function to return 2 values. To realize this, s390's cputime accounting also requires timestamp at end of iowait. Not-Tested-by: Hidetoshi Seto seto.hideto

[PATCH 5/8] cputime, ia64: update iowait accounting

2014-06-26 Thread Hidetoshi Seto
Using VIRT_CPU_ACCOUNTING, ia64 utilize timestamp at end of iowait like s390. Not-Tested-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- arch/ia64/include/asm/cputime.h |2 + arch/ia64/kernel/time.c | 43 ++- 2 files changed, 44 insertions

[PATCH 6/8] cputime, ppc: update iowait accounting

2014-06-26 Thread Hidetoshi Seto
Like s390 and ia64, ppc also has VIRT_CPU_ACCOUNTING. Check timestamp at end of iowait for idle/iowait accounting. Not-Tested-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- arch/powerpc/include/asm/cputime.h |3 +++ arch/powerpc/kernel/time.c | 21 + 2

[PATCH 7/8] cputime: generic iowait accounting for VIRT_CPU_ACCOUNTING

2014-06-26 Thread Hidetoshi Seto
Get iowait's timestamp for accounting w/ VIRT_CPU_ACCOUNTING_GEN. (currently arm is only user of this?) At last of this series of changes, introduce common function vtime_iowait_exit to replace all arch_record_iowait_exit. Not-tested-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- arch

[PATCH 8/8] cputime: iowait aware idle tick accounting

2014-06-26 Thread Hidetoshi Seto
By changes in vtime* codes by previous patches, now account_idle_time() become a function to be called only from tick-accounting codes. Introduce __account_idle_ticks() to do iowait accounting in ticks properly. For this purpose record jiffies at end of iowait. Not-Tested-by: Hidetoshi Seto

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/21 12:19), Chen Yucong wrote: > On Wed, 2014-05-21 at 11:43 +0900, Hidetoshi Seto wrote: >> (2014/05/21 11:03), Chen Yucong wrote: >>> On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: >>>> (2014/05/20 11:11), Chen Yucong wrote: >>>>>

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/21 11:03), Chen Yucong wrote: > On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: >> (2014/05/20 11:11), Chen Yucong wrote: >>> mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as >>> possible. So the >>> clear operati

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/20 11:11), Chen Yucong wrote: > mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as > possible. So the > clear operation of mces_seen should also be lcoal to Per-CPU rather than > monarch CPU. I don't think it should be local. Originally what we want to have

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/20 11:11), Chen Yucong wrote: mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as possible. So the clear operation of mces_seen should also be lcoal to Per-CPU rather than monarch CPU. I don't think it should be local. Originally what we want to have here is

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/21 11:03), Chen Yucong wrote: On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: (2014/05/20 11:11), Chen Yucong wrote: mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as possible. So the clear operation of mces_seen should also be lcoal to Per-CPU

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/21 12:19), Chen Yucong wrote: On Wed, 2014-05-21 at 11:43 +0900, Hidetoshi Seto wrote: (2014/05/21 11:03), Chen Yucong wrote: On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: (2014/05/20 11:11), Chen Yucong wrote: mces_seen is a Per-CPU variable which should only be accessed

Re: [PATCH 3/3] nohz: Fix iowait overcounting if iowait task migrates

2014-04-24 Thread Hidetoshi Seto
(iowait_exittime - idle_entrytime) > gets accounted as iowait, and the remaining (now - iowait_exittime) > as "true" idle. > > Run-tested: /proc/stats no longer go backwards. > > Signed-off-by: Denys Vlasenko > Cc: Frederic Weisbecker > Cc: Hidetoshi Seto > Cc

Re: [PATCH 3/3] nohz: Fix iowait overcounting if iowait task migrates

2014-04-24 Thread Hidetoshi Seto
accounted as iowait, and the remaining (now - iowait_exittime) as true idle. Run-tested: /proc/stats no longer go backwards. Signed-off-by: Denys Vlasenko dvlas...@redhat.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Cc: Fernando Luis Vazquez Cao

Re: [PATCH 2/2] nohz: delayed iowait accounting for nohz idle time stats

2014-04-23 Thread Hidetoshi Seto
(2014/04/23 18:41), Peter Zijlstra wrote: > On Wed, Apr 23, 2014 at 04:40:18PM +0900, Hidetoshi Seto wrote: >> (2014/04/23 4:45), Peter Zijlstra wrote: >>> On Thu, Apr 17, 2014 at 06:41:41PM +0900, Hidetoshi Seto wrote: >>>> [TARGET OF THIS PATCH]: >>>> &g

Re: [PATCH 2/2] nohz: delayed iowait accounting for nohz idle time stats

2014-04-23 Thread Hidetoshi Seto
(2014/04/23 4:45), Peter Zijlstra wrote: > On Thu, Apr 17, 2014 at 06:41:41PM +0900, Hidetoshi Seto wrote: >> [TARGET OF THIS PATCH]: >> >> Complete rework for iowait accounting implies that some user >> interfaces might be replaced completely. It will intro

Re: [PATCH 2/2] nohz: delayed iowait accounting for nohz idle time stats

2014-04-23 Thread Hidetoshi Seto
(2014/04/23 18:41), Peter Zijlstra wrote: On Wed, Apr 23, 2014 at 04:40:18PM +0900, Hidetoshi Seto wrote: (2014/04/23 4:45), Peter Zijlstra wrote: On Thu, Apr 17, 2014 at 06:41:41PM +0900, Hidetoshi Seto wrote: [TARGET OF THIS PATCH]: Complete rework for iowait accounting implies that some

Re: [PATCH 2/2] nohz: delayed iowait accounting for nohz idle time stats

2014-04-23 Thread Hidetoshi Seto
(2014/04/23 4:45), Peter Zijlstra wrote: On Thu, Apr 17, 2014 at 06:41:41PM +0900, Hidetoshi Seto wrote: [TARGET OF THIS PATCH]: Complete rework for iowait accounting implies that some user interfaces might be replaced completely. It will introduce new counter or so, and kill per-cpu

Re: [PATCH v4 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-22 Thread Hidetoshi Seto
Ping? (I'll have a week holidays from next week. So thank you if you could give me your comments soon!) Thanks, H.Seto (2014/04/17 18:35), Hidetoshi Seto wrote: > Hi all, > > This patch set (rebased on v3.15-rc1) is my 4th try to fix an issue > that idle/iowait of /proc/stat can

Re: [PATCH v4 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-22 Thread Hidetoshi Seto
Ping? (I'll have a week holidays from next week. So thank you if you could give me your comments soon!) Thanks, H.Seto (2014/04/17 18:35), Hidetoshi Seto wrote: Hi all, This patch set (rebased on v3.15-rc1) is my 4th try to fix an issue that idle/iowait of /proc/stat can go backward

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-17 Thread Hidetoshi Seto
(2014/04/17 19:05), Peter Zijlstra wrote: > Anyway, if you want to preserve the same broken ass crap we had pre > NOHZ, something like the below should do that. > > I'm not really thrilled with iowait_{start,stop}() but I think they > should have the same general cost as the atomic ops we already

[PATCH 2/2] nohz: delayed iowait accounting for nohz idle time stats

2014-04-17 Thread Hidetoshi Seto
qcount instead of seqlock (achieved by inserting cleanup as former patch) plus introduce delayed iowait accounting v2: update comments and description about problem 2. include fix for minor typo Signed-off-by: Hidetoshi Seto Reported-by: Fernando Luis Vazquez Cao Reported-by: Tetsuo Handa Cc

[PATCH 1/2] nohz: make updating sleep stats local

2014-04-17 Thread Hidetoshi Seto
update_ts_time_stats(), fold this static routine into tick_nohz_stop_idle(). (Still there is problem 2. Continue to following patch 2/2.) Signed-off-by: Hidetoshi Seto Reported-by: Fernando Luis Vazquez Cao Reported-by: Tetsuo Handa Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Ingo Molnar Cc

[PATCH v4 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-17 Thread Hidetoshi Seto
so). Of course still reviews are welcome. Thanks, H.Seto Hidetoshi Seto (2): nohz: make updating sleep stats local nohz: delayed iowait accounting for nohz idle time stats include/linux/tick.h |6 +- kernel/time/tick-sched.c | 179

[PATCH v4 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-17 Thread Hidetoshi Seto
so). Of course still reviews are welcome. Thanks, H.Seto Hidetoshi Seto (2): nohz: make updating sleep stats local nohz: delayed iowait accounting for nohz idle time stats include/linux/tick.h |6 +- kernel/time/tick-sched.c | 179

[PATCH 1/2] nohz: make updating sleep stats local

2014-04-17 Thread Hidetoshi Seto
update_ts_time_stats(), fold this static routine into tick_nohz_stop_idle(). (Still there is problem 2. Continue to following patch 2/2.) Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reported-by: Fernando Luis Vazquez Cao fernando...@lab.ntt.co.jp Reported-by: Tetsuo Handa penguin-ker

[PATCH 2/2] nohz: delayed iowait accounting for nohz idle time stats

2014-04-17 Thread Hidetoshi Seto
by inserting cleanup as former patch) plus introduce delayed iowait accounting v2: update comments and description about problem 2. include fix for minor typo Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reported-by: Fernando Luis Vazquez Cao fernando...@lab.ntt.co.jp Reported

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-17 Thread Hidetoshi Seto
(2014/04/17 19:05), Peter Zijlstra wrote: Anyway, if you want to preserve the same broken ass crap we had pre NOHZ, something like the below should do that. I'm not really thrilled with iowait_{start,stop}() but I think they should have the same general cost as the atomic ops we already had.

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-16 Thread Hidetoshi Seto
(2014/04/16 18:36), Peter Zijlstra wrote: > On Wed, Apr 16, 2014 at 03:33:06PM +0900, Hidetoshi Seto wrote: >> So we need 2 operations: >> a) remove regression > > What regression; there's never been talk about a regression, just a bug > found. AFAICT this 'regr

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-16 Thread Hidetoshi Seto
(2014/04/15 19:19), Peter Zijlstra wrote: > On Thu, Apr 10, 2014 at 06:13:54PM +0900, Hidetoshi Seto wrote: >> [WHAT THIS PATCH PROPOSED]: >> >> To fix problem 1, this patch adds seqcount for NO_HZ idle >> accounting to avoid possible races between reader/writer. >&

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-16 Thread Hidetoshi Seto
(2014/04/15 19:04), Peter Zijlstra wrote: > On Thu, Apr 10, 2014 at 06:13:54PM +0900, Hidetoshi Seto wrote: >> This patch is v3 of patch set to fix an issue that idle/iowait >> of /proc/stat can go backward. Originally reported by Tetsuo and >> Fernando at last year, Mar 201

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-16 Thread Hidetoshi Seto
(2014/04/15 19:04), Peter Zijlstra wrote: On Thu, Apr 10, 2014 at 06:13:54PM +0900, Hidetoshi Seto wrote: This patch is v3 of patch set to fix an issue that idle/iowait of /proc/stat can go backward. Originally reported by Tetsuo and Fernando at last year, Mar 2013. [BACKGROUNDS]: idle

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-16 Thread Hidetoshi Seto
(2014/04/15 19:19), Peter Zijlstra wrote: On Thu, Apr 10, 2014 at 06:13:54PM +0900, Hidetoshi Seto wrote: [WHAT THIS PATCH PROPOSED]: To fix problem 1, this patch adds seqcount for NO_HZ idle accounting to avoid possible races between reader/writer. And to cope with problem 2, I introduced

Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-16 Thread Hidetoshi Seto
(2014/04/16 18:36), Peter Zijlstra wrote: On Wed, Apr 16, 2014 at 03:33:06PM +0900, Hidetoshi Seto wrote: So we need 2 operations: a) remove regression What regression; there's never been talk about a regression, just a bug found. AFAICT this 'regression' is ever since we introduced NOHZ

Re: [PATCH v3 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-14 Thread Hidetoshi Seto
Ping? (2014/04/10 18:07), Hidetoshi Seto wrote: > Hi all, > > This patch set (rebased on v3.14) is my 3rd try to fix an issue > that idle/iowait of /proc/stat can go backward. Originally reported > by Tetsuo and Fernando at last year, Mar 2013. > > This v3 takes new approa

Re: [PATCH v3 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-14 Thread Hidetoshi Seto
Ping? (2014/04/10 18:07), Hidetoshi Seto wrote: Hi all, This patch set (rebased on v3.14) is my 3rd try to fix an issue that idle/iowait of /proc/stat can go backward. Originally reported by Tetsuo and Fernando at last year, Mar 2013. This v3 takes new approach to fix the problem

[PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-10 Thread Hidetoshi Seto
scription about problem 2. include fix for minor typo Signed-off-by: Hidetoshi Seto Reported-by: Fernando Luis Vazquez Cao Reported-by: Tetsuo Handa Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Andrew Morton Cc: Arjan van de Ven Cc: Oleg Nesterov

[PATCH 1/2] nohz: stop updating sleep stats from get_cpu_{idle,iowait}_time_us()

2014-04-10 Thread Hidetoshi Seto
-off-by: Hidetoshi Seto Cc: Fernando Luis Vazquez Cao Cc: Tetsuo Handa Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Andrew Morton Cc: Arjan van de Ven Cc: Oleg Nesterov Cc: Preeti U Murthy Cc: Denys Vlasenko Cc: --- include/linux/tick.h |4

[PATCH v3 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-10 Thread Hidetoshi Seto
still reviews are welcome! Thanks, H.Seto Hidetoshi Seto (2): nohz: stop updating sleep stats from get_cpu_{idle,iowait}_time_us() nohz: use delayed iowait accounting to avoid race on idle time stats include/linux/tick.h |6 ++- kernel/time/tick-sched.c | 116

[PATCH v3 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-04-10 Thread Hidetoshi Seto
still reviews are welcome! Thanks, H.Seto Hidetoshi Seto (2): nohz: stop updating sleep stats from get_cpu_{idle,iowait}_time_us() nohz: use delayed iowait accounting to avoid race on idle time stats include/linux/tick.h |6 ++- kernel/time/tick-sched.c | 116

[PATCH 1/2] nohz: stop updating sleep stats from get_cpu_{idle,iowait}_time_us()

2014-04-10 Thread Hidetoshi Seto
-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Cc: Fernando Luis Vazquez Cao fernando...@lab.ntt.co.jp Cc: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp Cc: Frederic Weisbecker fweis...@gmail.com Cc: Thomas Gleixner t...@linutronix.de Cc: Ingo Molnar mi...@kernel.org Cc: Peter Zijlstra pet

[PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

2014-04-10 Thread Hidetoshi Seto
. include fix for minor typo Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reported-by: Fernando Luis Vazquez Cao fernando...@lab.ntt.co.jp Reported-by: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp Cc: Frederic Weisbecker fweis...@gmail.com Cc: Thomas Gleixner t...@linutronix.de Cc: Ingo

Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2

2014-04-03 Thread Hidetoshi Seto
(2014/04/03 18:51), Denys Vlasenko wrote: > On Thu, Apr 3, 2014 at 9:02 AM, Hidetoshi Seto > wrote: >>>> [PROBLEM 2]: broken iowait accounting. >>>> >>>> As historical nature, cpu's idle time was accounted as either >>>> idle or iowait

Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2

2014-04-03 Thread Hidetoshi Seto
(2014/04/03 4:35), Denys Vlasenko wrote: > On Mon, Mar 31, 2014 at 4:08 AM, Hidetoshi Seto > wrote: >> There are 2 problems: >> >> [PROBLEM 1]: there is no exclusive control. >> >> It is easy to understand that there are 2 different cpu - an >> observing

Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2

2014-04-03 Thread Hidetoshi Seto
(2014/04/03 18:51), Denys Vlasenko wrote: On Thu, Apr 3, 2014 at 9:02 AM, Hidetoshi Seto seto.hideto...@jp.fujitsu.com wrote: [PROBLEM 2]: broken iowait accounting. As historical nature, cpu's idle time was accounted as either idle or iowait depending on the presence of tasks blocked by I/O

Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2

2014-04-03 Thread Hidetoshi Seto
(2014/04/03 4:35), Denys Vlasenko wrote: On Mon, Mar 31, 2014 at 4:08 AM, Hidetoshi Seto seto.hideto...@jp.fujitsu.com wrote: There are 2 problems: [PROBLEM 1]: there is no exclusive control. It is easy to understand that there are 2 different cpu - an observing cpu where running a program

[PATCH 2/2] nohz, procfs: introduce get_cpu_idle/iowait_time_coarse

2014-03-30 Thread Hidetoshi Seto
reproducer and stressor for a day. The rate of reproduce is different for different system, but in my case, running "git gc" on kernel source repository aside of checker works fine. Signed-off-by: Hidetoshi Seto Reviewed-by: Preeti U Murthy Reported-by: Fernando Luis Vazquez Cao Reported-

[PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2

2014-03-30 Thread Hidetoshi Seto
9/86 v2: update comments and description about problem 2. include fix for minor typo Signed-off-by: Hidetoshi Seto Reviewed-by: Preeti U Murthy Reported-by: Fernando Luis Vazquez Cao Reported-by: Tetsuo Handa Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Cc: And

[PATCH 0/2 v2] nohz: fix idle accounting in NO_HZ kernels

2014-03-30 Thread Hidetoshi Seto
Hi all, This patch set (rebased on v3.14-rc8) will fix an issue that idle/iowait of /proc/stat can go backward. Originally reported by Tetsuo and Fernando at last year, Mar 2013. v2 have Preeti's Reviewed-by (Thanks!). Of course still reviews are welcome. Thanks, H.Seto Hidetoshi Seto (2

[PATCH 0/2 v2] nohz: fix idle accounting in NO_HZ kernels

2014-03-30 Thread Hidetoshi Seto
Hi all, This patch set (rebased on v3.14-rc8) will fix an issue that idle/iowait of /proc/stat can go backward. Originally reported by Tetsuo and Fernando at last year, Mar 2013. v2 have Preeti's Reviewed-by (Thanks!). Of course still reviews are welcome. Thanks, H.Seto Hidetoshi Seto (2

[PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2

2014-03-30 Thread Hidetoshi Seto
about problem 2. include fix for minor typo Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com Reported-by: Fernando Luis Vazquez Cao fernando...@lab.ntt.co.jp Reported-by: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp Cc

[PATCH 2/2] nohz, procfs: introduce get_cpu_idle/iowait_time_coarse

2014-03-30 Thread Hidetoshi Seto
for a day. The rate of reproduce is different for different system, but in my case, running git gc on kernel source repository aside of checker works fine. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com Reported-by: Fernando Luis

Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats

2014-03-24 Thread Hidetoshi Seto
(2014/03/24 16:45), Preeti Murthy wrote: > Hi Hidetoshi, > > The patch looks good to me except the comments around the monotonicity > of the return value of the idle stats observer. I am unable to relate them > to the dependency on nr_iowait_cpu. > > I see that when the reader queries for the

Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats

2014-03-24 Thread Hidetoshi Seto
(2014/03/24 16:45), Preeti Murthy wrote: Hi Hidetoshi, The patch looks good to me except the comments around the monotonicity of the return value of the idle stats observer. I am unable to relate them to the dependency on nr_iowait_cpu. I see that when the reader queries for the idle

[PATCH 1/2] nohz: use seqlock to avoid race on idle time stats

2014-03-23 Thread Hidetoshi Seto
l/2013/8/8/638 [PATCH RESEND 0/4] nohz: Fix racy sleeptime stats https://lkml.org/lkml/2013/8/16/274 2nd patchset from Frederic: [RFC PATCH 0/5] nohz: Fix racy sleeptime stats v2 https://lkml.org/lkml/2013/10/19/86 Signed-off-by: Hidetoshi Seto Reported-by: Fernando Luis Vazquez

[PATCH 2/2] nohz, procfs: introduce get_cpu_idle/iowait_time_coarse

2014-03-23 Thread Hidetoshi Seto
reproducer and stressor for a day. The rate of reproduce is different for different system, but in my case, running "git gc" on kernel source repository aside of checker works fine. Thanks, H.Seto Signed-off-by: Hidetoshi Seto Reported-by: Fernando Luis Vazquez Cao Reported-by: Tetsuo Handa Cc:

[PATCH 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-03-23 Thread Hidetoshi Seto
Hi all, This patch set (based on v3.14-rc7) will fix an issue that idle/iowait of /proc/stat can go backward. Originally reported by Tetsuo and Fernando at last year, Mar 2013. Reviews are welcome. Thanks, H.Seto Hidetoshi Seto (2): nohz: use seqlock to avoid race on idle time stats

[PATCH 0/2] nohz: fix idle accounting in NO_HZ kernels

2014-03-23 Thread Hidetoshi Seto
Hi all, This patch set (based on v3.14-rc7) will fix an issue that idle/iowait of /proc/stat can go backward. Originally reported by Tetsuo and Fernando at last year, Mar 2013. Reviews are welcome. Thanks, H.Seto Hidetoshi Seto (2): nohz: use seqlock to avoid race on idle time stats

[PATCH 1/2] nohz: use seqlock to avoid race on idle time stats

2014-03-23 Thread Hidetoshi Seto
0/4] nohz: Fix racy sleeptime stats https://lkml.org/lkml/2013/8/16/274 2nd patchset from Frederic: [RFC PATCH 0/5] nohz: Fix racy sleeptime stats v2 https://lkml.org/lkml/2013/10/19/86 Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reported-by: Fernando Luis Vazquez Cao

[PATCH 2/2] nohz, procfs: introduce get_cpu_idle/iowait_time_coarse

2014-03-23 Thread Hidetoshi Seto
and stressor for a day. The rate of reproduce is different for different system, but in my case, running git gc on kernel source repository aside of checker works fine. Thanks, H.Seto Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Reported-by: Fernando Luis Vazquez Cao fernando...@lab.ntt.co.jp

[PATCH] rcu: Copyright string update

2014-02-24 Thread Hidetoshi Seto
Fix corporate name for copyright. Signed-off-by: Hidetoshi Seto --- include/linux/srcu.h |2 +- kernel/rcu/srcu.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/srcu.h b/include/linux/srcu.h index 9b058ee..04f5abb 100644 --- a/include/linux/srcu.h

[PATCH] btrfs: Copyright string update

2014-02-24 Thread Hidetoshi Seto
Fix corporate name for copyright. Signed-off-by: Hidetoshi Seto --- fs/btrfs/delayed-inode.c |2 +- fs/btrfs/delayed-inode.h |2 +- fs/btrfs/math.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c

[PATCH] rcu: Copyright string update

2014-02-24 Thread Hidetoshi Seto
Fix corporate name for copyright. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- include/linux/srcu.h |2 +- kernel/rcu/srcu.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/srcu.h b/include/linux/srcu.h index 9b058ee..04f5abb

[PATCH] btrfs: Copyright string update

2014-02-24 Thread Hidetoshi Seto
Fix corporate name for copyright. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- fs/btrfs/delayed-inode.c |2 +- fs/btrfs/delayed-inode.h |2 +- fs/btrfs/math.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/delayed-inode.c b

Re: [PATCH] ia64: Scalability improvement of gettimeofday with jitter compensation

2007-06-13 Thread Hidetoshi Seto
Bob Picco wrote: I will be pushing Peter Keilty's clocksource ia64 patches within the next week or so. At that time I'll ask for inclusion into -mm. Please see: http://marc.info/?t=11788158551=1=2 You'll notice that the time interpolator is removed. I see. Your patch will replace the time

Re: [PATCH] ia64: Scalability improvement of gettimeofday with jitter compensation

2007-06-13 Thread Hidetoshi Seto
Bob Picco wrote: I will be pushing Peter Keilty's clocksource ia64 patches within the next week or so. At that time I'll ask for inclusion into -mm. Please see: http://marc.info/?t=11788158551r=1w=2 You'll notice that the time interpolator is removed. I see. Your patch will replace the

[PATCH] ia64: Scalability improvement of gettimeofday with jitter compensation

2007-06-11 Thread Hidetoshi Seto
atch - x3 process: 1.59us / 1 gettimeofday() call 1.11us / 1 gettimeofday() call with patch - x4 process: 2.34us / 1 gettimeofday() call 1.29us / 1 gettimeofday() call with patch I know that this patch could not help quite huge system since such system like having 1024CPUs shoul

[PATCH] ia64: Scalability improvement of gettimeofday with jitter compensation

2007-06-11 Thread Hidetoshi Seto
such system like having 1024CPUs should have better clocksource instead of doing cmpxchg. Even though this patch will work good on middle-sized box (4~8way, possibly 16~64way?). Thanks, H.Seto Signed-off-by: Hidetoshi Seto [EMAIL PROTECTED] - arch/ia64/kernel/fsys.S | 10 +++--- kernel

Re: [PATCH] CPEI gets warning at kernel/irq/migration.c:27/move_masked_irq()

2006-12-06 Thread Hidetoshi Seto
Arjan van de Ven wrote: >> It'd be nice if we could just teach the userspace balancer to not try to >> move perpcu IRQs? >> >> otoh, the patch is super-cheap. Arjan? > > I can fix irqbalance no problem, however I like the kernel approach as > well, since it's not just irqbalance that moves

Re: [PATCH] CPEI gets warning at kernel/irq/migration.c:27/move_masked_irq()

2006-12-06 Thread Hidetoshi Seto
Arjan van de Ven wrote: It'd be nice if we could just teach the userspace balancer to not try to move perpcu IRQs? otoh, the patch is super-cheap. Arjan? I can fix irqbalance no problem, however I like the kernel approach as well, since it's not just irqbalance that moves irqs, sysadmins

[PATCH] CPEI gets warning at kernel/irq/migration.c:27/move_masked_irq()

2006-12-04 Thread Hidetoshi Seto
t stuff of CPEI need to be fixed, but I think that returning error to attempting move PER_CPU irq is useful for all applications since it will never work. Following small patch takes b) style. It works, the warning disappeared and irqbalance still runs well. Thanks, H.Seto Signed-off-by: Hidetoshi Seto <

[PATCH] CPEI gets warning at kernel/irq/migration.c:27/move_masked_irq()

2006-12-04 Thread Hidetoshi Seto
well. Thanks, H.Seto Signed-off-by: Hidetoshi Seto [EMAIL PROTECTED] --- kernel/irq/proc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6.19/kernel/irq/proc.c === --- linux-2.6.19.orig/kernel/irq/proc.c

Re: [PATCH 2.6.13] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-03 Thread Hidetoshi Seto
Matthew Wilcox wrote: On Thu, Sep 01, 2005 at 05:45:54PM -0500, Brent Casavant wrote: I am extremely concerned about the performance implications of this implementation. These changes have several deleterious effects on I/O performance. I agree. I think the iochk patches should be

Re: [PATCH 2.6.13 1/2] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-03 Thread Hidetoshi Seto
Oh my, Hidetoshi Seto wrote: I'd like to merge this part into 2.6.13-rc1 even if the latter half isn't This is typo, should be 2.6.14-rc1. :-p Thanks, H.Seto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

Re: [PATCH 2.6.13 1/2] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-03 Thread Hidetoshi Seto
Oh my, Hidetoshi Seto wrote: I'd like to merge this part into 2.6.13-rc1 even if the latter half isn't This is typo, should be 2.6.14-rc1. :-p Thanks, H.Seto - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 2.6.13] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-03 Thread Hidetoshi Seto
Matthew Wilcox wrote: On Thu, Sep 01, 2005 at 05:45:54PM -0500, Brent Casavant wrote: I am extremely concerned about the performance implications of this implementation. These changes have several deleterious effects on I/O performance. I agree. I think the iochk patches should be

Re: [PATCH 2.6.13 1/2] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-02 Thread Hidetoshi Seto
to merge this part into 2.6.13-rc1 even if the latter half isn't accepted. This former half functions without the latter, and helps realize of effective recovery from MCA. Tony, could you apply this part to your tree? Thanks, H.Seto Signed-off-by: Hidetoshi Seto <[EMAIL PROTECTED]> --- arc

Re: [PATCH 2.6.13 2/2] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-02 Thread Hidetoshi Seto
on the situation. Comments, to this paranoia part, are welcomed. Thanks, H.Seto Signed-off-by: Hidetoshi Seto <[EMAIL PROTECTED]> --- arch/ia64/kernel/mca.c | 21 + arch/ia64/lib/iomap_check.c | 28 +++- include/asm-ia64/io.h

Re: [PATCH 2.6.13] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-02 Thread Hidetoshi Seto
Thank you for your comment, Brent. Brent Casavant wrote: On Thu, 1 Sep 2005, Hidetoshi Seto wrote: static inline unsigned int ___ia64_inb (unsigned long port) { volatile unsigned char *addr = __ia64_mk_io_addr(port); unsigned char ret; + unsigned long flags

Re: [PATCH 2.6.13] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-02 Thread Hidetoshi Seto
Thank you for your comment, Brent. Brent Casavant wrote: On Thu, 1 Sep 2005, Hidetoshi Seto wrote: static inline unsigned int ___ia64_inb (unsigned long port) { volatile unsigned char *addr = __ia64_mk_io_addr(port); unsigned char ret; + unsigned long flags

Re: [PATCH 2.6.13 1/2] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-02 Thread Hidetoshi Seto
to merge this part into 2.6.13-rc1 even if the latter half isn't accepted. This former half functions without the latter, and helps realize of effective recovery from MCA. Tony, could you apply this part to your tree? Thanks, H.Seto Signed-off-by: Hidetoshi Seto [EMAIL PROTECTED] --- arch/ia64

[PATCH 2.6.13] IOCHK interface for I/O error handling/detecting

2005-08-31 Thread Hidetoshi Seto
This patch implements IOCHK interfaces that enable PCI drivers to detect error and make their error handling easier. Please refer archives if you need, e.g. http://lwn.net/Articles/139240/ Thanks, H.Seto Signed-off-by: Hidetoshi Seto <[EMAIL PROTECTED]> --- drivers/pci

[PATCH 2.6.13] IOCHK interface for I/O error handling/detecting (for ia64)

2005-08-31 Thread Hidetoshi Seto
This patch implements ia64-specific IOCHK interfaces that enable PCI drivers to detect error and make their error handling easier. Please refer archives if you need, e.g. http://lwn.net/Articles/139240/ Thanks, H.Seto Signed-off-by: Hidetoshi Seto <[EMAIL PROTECTED]> --- arch/ia64/K

[PATCH 2.6.13] IOCHK interface for I/O error handling/detecting

2005-08-31 Thread Hidetoshi Seto
This patch implements IOCHK interfaces that enable PCI drivers to detect error and make their error handling easier. Please refer archives if you need, e.g. http://lwn.net/Articles/139240/ Thanks, H.Seto Signed-off-by: Hidetoshi Seto [EMAIL PROTECTED] --- drivers/pci/pci.c |2

[PATCH 2.6.13] IOCHK interface for I/O error handling/detecting (for ia64)

2005-08-31 Thread Hidetoshi Seto
This patch implements ia64-specific IOCHK interfaces that enable PCI drivers to detect error and make their error handling easier. Please refer archives if you need, e.g. http://lwn.net/Articles/139240/ Thanks, H.Seto Signed-off-by: Hidetoshi Seto [EMAIL PROTECTED] --- arch/ia64/Kconfig

  1   2   >