Re: [PATCH 0/1] PCI/MSI: add NULL check before use of msi_desc

2018-01-16 Thread Hiraku Toyooka
Hello Lorenzo, Thank you for telling me. I missed the patch. Best regards, Hiraku Toyooka 2018-01-16 18:30 GMT+09:00 Lorenzo Pieralisi <lorenzo.pieral...@arm.com>: > On Tue, Jan 16, 2018 at 06:15:46PM +0900, Hiraku Toyooka wrote: >> Hello, >> >> I found a NULL poi

Re: [PATCH 0/1] PCI/MSI: add NULL check before use of msi_desc

2018-01-16 Thread Hiraku Toyooka
Hello Lorenzo, Thank you for telling me. I missed the patch. Best regards, Hiraku Toyooka 2018-01-16 18:30 GMT+09:00 Lorenzo Pieralisi : > On Tue, Jan 16, 2018 at 06:15:46PM +0900, Hiraku Toyooka wrote: >> Hello, >> >> I found a NULL pointer dereference in PCI/MSI when

[PATCH 0/1] PCI/MSI: add NULL check before use of msi_desc

2018-01-16 Thread Hiraku Toyooka
60609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4)) #14 SMP Tue Jan 16 06:33:27 UTC 2018 Hiraku Toyooka (1): PCI/MSI: add NULL check before use of msi_desc drivers/pci/msi.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4

[PATCH 0/1] PCI/MSI: add NULL check before use of msi_desc

2018-01-16 Thread Hiraku Toyooka
60609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4)) #14 SMP Tue Jan 16 06:33:27 UTC 2018 Hiraku Toyooka (1): PCI/MSI: add NULL check before use of msi_desc drivers/pci/msi.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4

[PATCH 1/1] PCI/MSI: add NULL check before use of msi_desc

2018-01-16 Thread Hiraku Toyooka
ror by avoiding NULL msi_desc use. Signed-off-by: Hiraku Toyooka <hiraku.toyo...@cybertrust.co.jp> Cc: Bjorn Helgaas <bhelg...@google.com> Cc: Richard Zhu <hongxing@nxp.com> Cc: Lucas Stach <l.st...@pengutronix.de> Cc: Jingoo Han <jingooh...@gmail.com> Cc: Joao P

[PATCH 1/1] PCI/MSI: add NULL check before use of msi_desc

2018-01-16 Thread Hiraku Toyooka
ror by avoiding NULL msi_desc use. Signed-off-by: Hiraku Toyooka Cc: Bjorn Helgaas Cc: Richard Zhu Cc: Lucas Stach Cc: Jingoo Han Cc: Joao Pinto Cc: Lorenzo Pieralisi Cc: Russell King Cc: Will Deacon --- drivers/pci/msi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/msi.

[PATCH 1/5] ramoops: use persistent_ram_free() instead of kfree() for freeing prz

2015-11-04 Thread Hiraku Toyooka
persistent_ram_zone(=prz) structures are allocated by persistent_ram_new(), which includes vmap() or ioremap(). But they are currently freed by kfree(). We should use persistent_ram_free() to correct this asymmetry usage. Signed-off-by: Hiraku Toyooka Cc: Anton Vorontsov Cc: Colin Cross Cc

[PATCH 3/5] pstore: support multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
]. Signed-off-by: Hiraku Toyooka Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees Cook Cc: Mark Salyzyn Cc: Seiji Aguchi Cc: Tony Luck Cc: linux-kernel@vger.kernel.org --- fs/pstore/pmsg.c | 20 ++-- include/linux/pstore.h |1 + 2 files changed, 19 insertions(+), 2

[PATCH 2/5] ramoops: introduce generic init/free functions for prz

2015-11-04 Thread Hiraku Toyooka
przs'. * rename ramoops_init_prz() to ramoops_init_dprzs(). * change parameter of ramoops_free_przs() from struct ramoops_context * into struct persistent_ram_zone * in order to make it available for all prz array. Signed-off-by: Hiraku Toyooka Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees

[PATCH 5/5] selftests/pstore: add testcases for multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
ore_tests - Write unique string to the last /dev/pmsgN - pstore_post_reboot_tests - Check the last pmsg area is detected Signed-off-by: Hiraku Toyooka Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees Cook Cc: Mark Salyzyn Cc: Seiji Aguchi Cc: Shuah Khan Cc: Tony Luck Cc: linux-...@vger.k

[PATCH 0/5] pstore: ramoops: support multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
|8 + tools/testing/selftests/pstore/common_tests| 21 ++ .../selftests/pstore/pstore_post_reboot_tests | 27 +-- tools/testing/selftests/pstore/pstore_tests| 16 +- 8 files changed, 257 insertions(+), 71 deletions(-) -- Hiraku Toyooka

[PATCH 4/5] ramoops: support multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
]. Signed-off-by: Hiraku Toyooka Cc: Jonathan Corbet Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees Cook Cc: Mark Salyzyn Cc: Seiji Aguchi Cc: Tony Luck Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- Documentation/ramoops.txt | 22 +++ fs/pstore/ram.c| 146

[PATCH 2/5] ramoops: introduce generic init/free functions for prz

2015-11-04 Thread Hiraku Toyooka
przs'. * rename ramoops_init_prz() to ramoops_init_dprzs(). * change parameter of ramoops_free_przs() from struct ramoops_context * into struct persistent_ram_zone * in order to make it available for all prz array. Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc:

[PATCH 0/5] pstore: ramoops: support multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
|8 + tools/testing/selftests/pstore/common_tests| 21 ++ .../selftests/pstore/pstore_post_reboot_tests | 27 +-- tools/testing/selftests/pstore/pstore_tests| 16 +- 8 files changed, 257 insertions(+), 71 deletions(-) -- Hiraku Toyooka

[PATCH 1/5] ramoops: use persistent_ram_free() instead of kfree() for freeing prz

2015-11-04 Thread Hiraku Toyooka
persistent_ram_zone(=prz) structures are allocated by persistent_ram_new(), which includes vmap() or ioremap(). But they are currently freed by kfree(). We should use persistent_ram_free() to correct this asymmetry usage. Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc:

[PATCH 3/5] pstore: support multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
]. Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc: Anton Vorontsov <an...@enomsg.org> Cc: Colin Cross <ccr...@android.com> Cc: Kees Cook <keesc...@chromium.org> Cc: Mark Salyzyn <saly...@android.com> Cc: Seiji Aguchi <seiji.aguchi...@hitachi.com> Cc

[PATCH 4/5] ramoops: support multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
]. Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc: Jonathan Corbet <cor...@lwn.net> Cc: Anton Vorontsov <an...@enomsg.org> Cc: Colin Cross <ccr...@android.com> Cc: Kees Cook <keesc...@chromium.org> Cc: Mark Salyzyn <saly...@android.com> Cc: Seiji Agu

[PATCH 5/5] selftests/pstore: add testcases for multiple pmsg instances

2015-11-04 Thread Hiraku Toyooka
ore_tests - Write unique string to the last /dev/pmsgN - pstore_post_reboot_tests - Check the last pmsg area is detected Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc: Anton Vorontsov <an...@enomsg.org> Cc: Colin Cross <ccr...@android.com> Cc: Kees Cook

Re: [RFD] pstore: pmsg: ramoops: add multiple pmsg instances

2015-10-18 Thread Hiraku Toyooka
pstore configuration Would you mean pstore backend's configuration (e.g.'mem_address' in ramoops)? Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [RFD] pstore: pmsg: ramoops: add multiple pmsg instances

2015-10-18 Thread Hiraku Toyooka
pstore configuration Would you mean pstore backend's configuration (e.g.'mem_address' in ramoops)? Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

[RFD] pstore: pmsg: ramoops: add multiple pmsg instances

2015-10-08 Thread Hiraku Toyooka
. (Although there is no ramoops's backend which uses pmsg currently) * Give an ID for each pmsg buffer, and modify some functions related to buffer allocation. What do you think about this idea? Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-k

[RFD] pstore: pmsg: ramoops: add multiple pmsg instances

2015-10-08 Thread Hiraku Toyooka
. (Although there is no ramoops's backend which uses pmsg currently) * Give an ID for each pmsg buffer, and modify some functions related to buffer allocation. What do you think about this idea? Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH v2 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-10-02 Thread Hiraku Toyooka
-ramoops-0 ... ok dmesg-ramoops-0 ... ok dmesg-ramoops-1 ... ok pmsg-ramoops-0 ... ok selftests: pstore_post_reboot_tests [PASS] Signed-off-by: Hiraku Toyooka Cc: Shuah Khan Cc: Tony Luck Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees Cook Cc: Mark Salyzyn Cc: Seiji

[PATCH v2 0/2] selftests/pstore: add pstore test script

2015-10-02 Thread Hiraku Toyooka
written to pmsg matches across crash. * Don't touch panic_on_oops because it is not necessary for reboot on crash (v1: http://www.kernelhub.org/?msg=831044=2) I also confirmed that these scripts work fine with kdump reboot with kernel boot parameter 'crash_kexec_post_notifiers'. --- Hiraku Toyooka

[PATCH v2 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-10-02 Thread Hiraku Toyooka
=/dev/mmcblk0p2 rw rootwait mem=768M ramoops.mem_address=0x3000 ramoops.mem_size=0x1 Checking pstore console is registered ... ok Checking /dev/pmsg0 exists ... ok Writing unique string to /dev/pmsg0 ... ok Signed-off-by: Hiraku Toyooka Cc: Shuah Khan Cc: Tony Luck Cc: Anton

[PATCH v2 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-10-02 Thread Hiraku Toyooka
=/dev/mmcblk0p2 rw rootwait mem=768M ramoops.mem_address=0x3000 ramoops.mem_size=0x1 Checking pstore console is registered ... ok Checking /dev/pmsg0 exists ... ok Writing unique string to /dev/pmsg0 ... ok Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc: Shua

[PATCH v2 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-10-02 Thread Hiraku Toyooka
-ramoops-0 ... ok dmesg-ramoops-0 ... ok dmesg-ramoops-1 ... ok pmsg-ramoops-0 ... ok selftests: pstore_post_reboot_tests [PASS] Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc: Shuah Khan <shua...@osg.samsung.com> Cc: Tony Luck <tony.l..

[PATCH v2 0/2] selftests/pstore: add pstore test script

2015-10-02 Thread Hiraku Toyooka
written to pmsg matches across crash. * Don't touch panic_on_oops because it is not necessary for reboot on crash (v1: http://www.kernelhub.org/?msg=831044=2) I also confirmed that these scripts work fine with kdump reboot with kernel boot parameter 'crash_kexec_post_notifiers'. --- Hiraku Toyooka

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-29 Thread Hiraku Toyooka
if [ $? -eq 0 ]; then prlog "ok" else prlog "FAIL" else prlog "FAIL" fi Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-29 Thread Hiraku Toyooka
if [ $? -eq 0 ]; then prlog "ok" else prlog "FAIL" else prlog "FAIL" fi Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-09-16 Thread Hiraku Toyooka
re the sysrq? Yes, I should check /sys/kernel/kexec_crash_loaded. If the value is 1, this script should try to unload kexec kernel. > Or, does it cover oops and kdump case? No, not yet. I think we should support oops case at first. Best regards, Hiraku Toyooka 阿口誠司 / AGUCHI,SEIJI wrote: +

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-16 Thread Hiraku Toyooka
Hello, > It may be good if you can log "/sys/module/pstore/parameters/backend/" > or /proc/cmdline in failure case. > > It makes debug easy. OK, I'll have the script log the information in v2. Best regards, Hiraku Toyooka 阿口誠司 / AGUCHI,SEIJI wrote: Hi, +prlog -n &q

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-16 Thread Hiraku Toyooka
Hello, > It may be good if you can log "/sys/module/pstore/parameters/backend/" > or /proc/cmdline in failure case. > > It makes debug easy. OK, I'll have the script log the information in v2. Best regards, Hiraku Toyooka 阿口誠司 / AGUCHI,SEIJI wrote: Hi, +prlog -n &q

Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-09-16 Thread Hiraku Toyooka
re the sysrq? Yes, I should check /sys/kernel/kexec_crash_loaded. If the value is 1, this script should try to unload kexec kernel. > Or, does it cover oops and kdump case? No, not yet. I think we should support oops case at first. Best regards, Hiraku Toyooka 阿口誠司 / AGUCHI,SEIJI wrote: +

Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-09-14 Thread Hiraku Toyooka
ern is repeated a lot. Maybe better to create a helper > function instead? It could make the tests much more readable. Yes, I should make a helper function in v2. Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-14 Thread Hiraku Toyooka
tead? OK, I'll update in that way. Best regards, Hiraku Toyooka Kees Cook wrote: On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka wrote: The pstore_tests script includes test cases which check pstore's behavior before crash (and reboot). The test cases are currently following. - Check pstore

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-14 Thread Hiraku Toyooka
t to a regular file before reboot as well as reboot_flag.) Is it OK? Best regards, Hiraku Toyooka -- Hiraku Toyooka Systems Productivity Research Dept. / Linux Technology Center Center for Technology Innovation - Systems Engineering, Hitachi Ltd. -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-14 Thread Hiraku Toyooka
tead? OK, I'll update in that way. Best regards, Hiraku Toyooka Kees Cook wrote: On Tue, Sep 8, 2015 at 4:06 AM, Hiraku Toyooka <hiraku.toyooka...@hitachi.com> wrote: The pstore_tests script includes test cases which check pstore's behavior before crash (and reboot). The test cases are c

Re: [PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-09-14 Thread Hiraku Toyooka
ern is repeated a lot. Maybe better to create a helper > function instead? It could make the tests much more readable. Yes, I should make a helper function in v2. Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-14 Thread Hiraku Toyooka
t to a regular file before reboot as well as reboot_flag.) Is it OK? Best regards, Hiraku Toyooka -- Hiraku Toyooka Systems Productivity Research Dept. / Linux Technology Center Center for Technology Innovation - Systems Engineering, Hitachi Ltd. -- To unsubscribe from this list: send the line "unsu

[PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-08 Thread Hiraku Toyooka
-off-by: Hiraku Toyooka Cc: Shuah Khan Cc: Tony Luck Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees Cook Cc: Mark Salyzyn Cc: Seiji Aguchi Cc: linux-kernel@vger.kernel.org Cc: linux-...@vger.kernel.org --- tools/testing/selftests/Makefile|1 + tools/testing/selftests/pstore

[PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-09-08 Thread Hiraku Toyooka
[PASS] make: Leaving directory '/home/root/selftests/pstore' Signed-off-by: Hiraku Toyooka Cc: Shuah Khan Cc: Tony Luck Cc: Anton Vorontsov Cc: Colin Cross Cc: Kees Cook Cc: Mark Salyzyn Cc: Seiji Aguchi Cc: linux-kernel@vger.kernel.org Cc: linux-...@vger.kernel.org --- tools/testing

[PATCH 0/2] selftests/pstore: add pstore test script

2015-09-08 Thread Hiraku Toyooka
oot/selftests/pstore' We can also see test logs later. # cat pstore/logs/20150903-58/pstore_tests.log ... --- Hiraku Toyooka (2): selftests/pstore: add pstore test script for pre-reboot selftests/pstore: add pstore test scripts going with reboot tools/testing/selftests/Mak

[PATCH 1/2] selftests/pstore: add pstore test script for pre-reboot

2015-09-08 Thread Hiraku Toyooka
-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc: Shuah Khan <shua...@osg.samsung.com> Cc: Tony Luck <tony.l...@intel.com> Cc: Anton Vorontsov <an...@enomsg.org> Cc: Colin Cross <ccr...@android.com> Cc: Kees Cook <keesc...@chromium.org> Cc: Mark Salyzyn &l

[PATCH 2/2] selftests/pstore: add pstore test scripts going with reboot

2015-09-08 Thread Hiraku Toyooka
[PASS] make: Leaving directory '/home/root/selftests/pstore' Signed-off-by: Hiraku Toyooka <hiraku.toyooka...@hitachi.com> Cc: Shuah Khan <shua...@osg.samsung.com> Cc: Tony Luck <tony.l...@intel.com> Cc: Anton Vorontsov <an...@enomsg.org> Cc: Colin Cross <ccr...@androi

[PATCH 0/2] selftests/pstore: add pstore test script

2015-09-08 Thread Hiraku Toyooka
oot/selftests/pstore' We can also see test logs later. # cat pstore/logs/20150903-58/pstore_tests.log ... --- Hiraku Toyooka (2): selftests/pstore: add pstore test script for pre-reboot selftests/pstore: add pstore test scripts going with reboot tools/testing/selftests/Mak

[PATCH v2] ARM: socfpga: add smp_ops.cpu_kill to make kexec/kdump available

2015-06-10 Thread Hiraku Toyooka
Kexec_load syscall in ARM requires that machine-specific code has the smp_ops.cpu_kill() before loading kernel image. This patch adds the cpu_kill(), as a result, kexec reboot and kernel crash dump become available in mach-socfpga. Signed-off-by: Hiraku Toyooka Cc: Dinh Nguyen Cc: Russell King

[PATCH v2] ARM: socfpga: add smp_ops.cpu_kill to make kexec/kdump available

2015-06-10 Thread Hiraku Toyooka
Kexec_load syscall in ARM requires that machine-specific code has the smp_ops.cpu_kill() before loading kernel image. This patch adds the cpu_kill(), as a result, kexec reboot and kernel crash dump become available in mach-socfpga. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc

Re: [PATCH] ARM: socfpga: add smp_ops.cpu_kill to make kexec/kdump available

2015-06-02 Thread Hiraku Toyooka
is is discussed before between Alan Tull and you. (https://lkml.org/lkml/2014/9/25/37) Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] ARM: socfpga: add smp_ops.cpu_kill to make kexec/kdump available

2015-06-02 Thread Hiraku Toyooka
Alan Tull and you. (https://lkml.org/lkml/2014/9/25/37) Best regards, Hiraku Toyooka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH] ARM: socfpga: add smp_ops.cpu_kill to make kexec/kdump available

2015-05-29 Thread Hiraku Toyooka
Kexec_load syscall in ARM checks that machine-specific code has the smp_ops.cpu_kill() before loading kernel image. This patch adds the cpu_kill(), as a result, kexec reboot and kernel crash dump become available in mach-socfpga. Signed-off-by: Hiraku Toyooka Cc: Dinh Nguyen Cc: Russell King

[PATCH] ARM: socfpga: add smp_ops.cpu_kill to make kexec/kdump available

2015-05-29 Thread Hiraku Toyooka
Kexec_load syscall in ARM checks that machine-specific code has the smp_ops.cpu_kill() before loading kernel image. This patch adds the cpu_kill(), as a result, kexec reboot and kernel crash dump become available in mach-socfpga. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc

[tip:perf/urgent] tracing: update documentation of snapshot utility

2013-03-08 Thread tip-bot for Hiraku Toyooka
Commit-ID: 1abccd7419de9829bcdf9ab1f81d5f6cf74d55d3 Gitweb: http://git.kernel.org/tip/1abccd7419de9829bcdf9ab1f81d5f6cf74d55d3 Author: Hiraku Toyooka AuthorDate: Fri, 8 Mar 2013 16:32:25 +0900 Committer: Steven Rostedt CommitDate: Fri, 8 Mar 2013 06:27:11 -0500 tracing: update

[tip:perf/urgent] tracing: update documentation of snapshot utility

2013-03-08 Thread tip-bot for Hiraku Toyooka
Commit-ID: 1abccd7419de9829bcdf9ab1f81d5f6cf74d55d3 Gitweb: http://git.kernel.org/tip/1abccd7419de9829bcdf9ab1f81d5f6cf74d55d3 Author: Hiraku Toyooka hiraku.toyooka...@hitachi.com AuthorDate: Fri, 8 Mar 2013 16:32:25 +0900 Committer: Steven Rostedt rost...@goodmis.org CommitDate: Fri, 8

Re: [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-07 Thread Hiraku Toyooka
to update the documentation. Could you include this patch? Thanks, Hiraku Toyooka From: Hiraku Toyooka Subject: [PATCH] tracing: update documentation of snapshot utility Now, "snapshot" file returns success on a reset of snapshot buffer even if the buffer wasn't allocated, instead of return

Re: [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API

2013-03-07 Thread Hiraku Toyooka
to update the documentation. Could you include this patch? Thanks, Hiraku Toyooka From: Hiraku Toyooka hiraku.toyooka...@hitachi.com Subject: [PATCH] tracing: update documentation of snapshot utility Now, snapshot file returns success on a reset of snapshot buffer even if the buffer wasn't allocated

Re: [RFC][PATCH 2/2] tracing: Do not return EINVAL in snapshot when not allocated

2013-03-06 Thread Hiraku Toyooka
or '1' is written > into the snapshot file. But if the file is not allocated it returns > -EINVAL error code. This is rather pointless. It is better just to > do nothing and return success. > > Cc: Hiraku Toyooka > Signed-off-by: Steven Rostedt > --- Acked-by: Hiraku Toyooka &g

Re: [RFC][PATCH 1/2] tracing: Add help of snapshot feature when snapshot is empty

2013-03-06 Thread Hiraku Toyooka
t already allocated. > # Takes a snapshot of the main buffer. > # echo 2 > snapshot : Clears snapshot buffer (but does not allocate) > # (Doesn't have to be '2' works with any number that > # is not a '0' or '1') > > Cc: H

Re: snapshot error on non allocated buffer?

2013-03-06 Thread Hiraku Toyooka
not return -EINVAL. Does it need to be based on 3.9-rc1 or tip tree? Thanks, Hiraku Toyooka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: snapshot error on non allocated buffer?

2013-03-06 Thread Hiraku Toyooka
to be based on 3.9-rc1 or tip tree? Thanks, Hiraku Toyooka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC][PATCH 1/2] tracing: Add help of snapshot feature when snapshot is empty

2013-03-06 Thread Hiraku Toyooka
' works with any number that # is not a '0' or '1') Cc: Hiraku Toyookahiraku.toyooka...@hitachi.com Signed-off-by: Steven Rostedtrost...@goodmis.org --- Acked-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com kernel/trace/trace.c | 25 - 1

Re: [RFC][PATCH 2/2] tracing: Do not return EINVAL in snapshot when not allocated

2013-03-06 Thread Hiraku Toyooka
. But if the file is not allocated it returns -EINVAL error code. This is rather pointless. It is better just to do nothing and return success. Cc: Hiraku Toyookahiraku.toyooka...@hitachi.com Signed-off-by: Steven Rostedtrost...@goodmis.org --- Acked-by: Hiraku Toyooka hiraku.toyooka

[tip:perf/core] tracing: Add documentation of snapshot utility

2013-02-03 Thread tip-bot for Hiraku Toyooka
Commit-ID: c1043fcda1b9e8e5144cfdaee7be262c50dbdead Gitweb: http://git.kernel.org/tip/c1043fcda1b9e8e5144cfdaee7be262c50dbdead Author: Hiraku Toyooka AuthorDate: Wed, 26 Dec 2012 11:53:09 +0900 Committer: Steven Rostedt CommitDate: Wed, 30 Jan 2013 11:02:07 -0500 tracing: Add

[tip:perf/core] tracing: Make a snapshot feature available from userspace

2013-02-03 Thread tip-bot for Hiraku Toyooka
Commit-ID: debdd57f5145f3c6a4b3f8d0126abd1a2def7fc6 Gitweb: http://git.kernel.org/tip/debdd57f5145f3c6a4b3f8d0126abd1a2def7fc6 Author: Hiraku Toyooka AuthorDate: Wed, 26 Dec 2012 11:53:00 +0900 Committer: Steven Rostedt CommitDate: Wed, 30 Jan 2013 11:02:06 -0500 tracing: Make

[tip:perf/core] tracing: Replace static old_tracer check of tracer name

2013-02-03 Thread tip-bot for Hiraku Toyooka
Commit-ID: 2fd196ec1eab2623096e7fc7e6f3976160392bce Gitweb: http://git.kernel.org/tip/2fd196ec1eab2623096e7fc7e6f3976160392bce Author: Hiraku Toyooka AuthorDate: Wed, 26 Dec 2012 11:52:52 +0900 Committer: Steven Rostedt CommitDate: Wed, 30 Jan 2013 11:02:05 -0500 tracing: Replace

[tip:perf/core] tracing: Replace static old_tracer check of tracer name

2013-02-03 Thread tip-bot for Hiraku Toyooka
Commit-ID: 2fd196ec1eab2623096e7fc7e6f3976160392bce Gitweb: http://git.kernel.org/tip/2fd196ec1eab2623096e7fc7e6f3976160392bce Author: Hiraku Toyooka hiraku.toyooka...@hitachi.com AuthorDate: Wed, 26 Dec 2012 11:52:52 +0900 Committer: Steven Rostedt rost...@goodmis.org CommitDate: Wed

[tip:perf/core] tracing: Make a snapshot feature available from userspace

2013-02-03 Thread tip-bot for Hiraku Toyooka
Commit-ID: debdd57f5145f3c6a4b3f8d0126abd1a2def7fc6 Gitweb: http://git.kernel.org/tip/debdd57f5145f3c6a4b3f8d0126abd1a2def7fc6 Author: Hiraku Toyooka hiraku.toyooka...@hitachi.com AuthorDate: Wed, 26 Dec 2012 11:53:00 +0900 Committer: Steven Rostedt rost...@goodmis.org CommitDate: Wed

[tip:perf/core] tracing: Add documentation of snapshot utility

2013-02-03 Thread tip-bot for Hiraku Toyooka
Commit-ID: c1043fcda1b9e8e5144cfdaee7be262c50dbdead Gitweb: http://git.kernel.org/tip/c1043fcda1b9e8e5144cfdaee7be262c50dbdead Author: Hiraku Toyooka hiraku.toyooka...@hitachi.com AuthorDate: Wed, 26 Dec 2012 11:53:09 +0900 Committer: Steven Rostedt rost...@goodmis.org CommitDate: Wed

[tip:perf/core] tracing: Add checks if tr-> buffer is NULL in tracing_reset{_online_cpus}

2013-01-24 Thread tip-bot for Hiraku Toyooka
Commit-ID: a54164114b96b4693b42cdb553260eec41ea4393 Gitweb: http://git.kernel.org/tip/a54164114b96b4693b42cdb553260eec41ea4393 Author: Hiraku Toyooka AuthorDate: Wed, 19 Dec 2012 16:02:34 +0900 Committer: Steven Rostedt CommitDate: Mon, 21 Jan 2013 13:22:32 -0500 tracing: Add checks

[tip:perf/core] tracing: Add checks if tr- buffer is NULL in tracing_reset{_online_cpus}

2013-01-24 Thread tip-bot for Hiraku Toyooka
Commit-ID: a54164114b96b4693b42cdb553260eec41ea4393 Gitweb: http://git.kernel.org/tip/a54164114b96b4693b42cdb553260eec41ea4393 Author: Hiraku Toyooka hiraku.toyooka...@hitachi.com AuthorDate: Wed, 19 Dec 2012 16:02:34 +0900 Committer: Steven Rostedt rost...@goodmis.org CommitDate: Mon

[PATCH v4 -tip 3/3] tracing: add description of snapshot to Documentation/trace/ftrace.txt

2012-12-25 Thread Hiraku Toyooka
This patch adds snapshot description in ftrace documentation. This description includes what the snapshot is and how to use it. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Rob Landley Cc: linux-...@vger.kernel.org Cc: linux-kernel

[PATCH v4 -tip 2/3] tracing: make a snapshot feature available from userspace

2012-12-25 Thread Hiraku Toyooka
napshot if it is allocated. Any other positive values will clear the snapshot contents if the snapshot is allocated, or return EINVAL if it is not allocated. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Jiri Olsa Cc: David Sharp Cc: li

[PATCH v4 -tip 1/3] tracing: replace static old_tracer with trace iterator's pointer to the original tracer's name

2012-12-25 Thread Hiraku Toyooka
ed between different reads of the trace file. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org --- kernel/trace/trace.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/ke

[PATCH v4 -tip 0/3] tracing: make a snapshot feature available from userspace

2012-12-25 Thread Hiraku Toyooka
/12/19/35) --- Hiraku Toyooka (3): tracing: replace static old_tracer with trace iterator's pointer to the original tracer's name tracing: make a snapshot feature available from userspace tracing: add description of snapshot to Documentation/trace/ftrace.txt Documentation/tr

[PATCH v4 -tip 0/3] tracing: make a snapshot feature available from userspace

2012-12-25 Thread Hiraku Toyooka
/19/35) --- Hiraku Toyooka (3): tracing: replace static old_tracer with trace iterator's pointer to the original tracer's name tracing: make a snapshot feature available from userspace tracing: add description of snapshot to Documentation/trace/ftrace.txt Documentation/trace

[PATCH v4 -tip 1/3] tracing: replace static old_tracer with trace iterator's pointer to the original tracer's name

2012-12-25 Thread Hiraku Toyooka
reads of the trace file. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@redhat.com Cc: linux-kernel@vger.kernel.org --- kernel/trace/trace.c | 22 +- 1 file

[PATCH v4 -tip 2/3] tracing: make a snapshot feature available from userspace

2012-12-25 Thread Hiraku Toyooka
. Any other positive values will clear the snapshot contents if the snapshot is allocated, or return EINVAL if it is not allocated. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

[PATCH v4 -tip 3/3] tracing: add description of snapshot to Documentation/trace/ftrace.txt

2012-12-25 Thread Hiraku Toyooka
This patch adds snapshot description in ftrace documentation. This description includes what the snapshot is and how to use it. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

Re: [PATCH v3 -tip 2/4] tracing: replace static old_tracer with strcmp

2012-12-21 Thread Hiraku Toyooka
Hi, (12/21/2012 12:04 PM), Steven Rostedt wrote: On Wed, 2012-12-19 at 16:02 +0900, Hiraku Toyooka wrote: Currently, read functions for trace buffer use static "old_tracer" for detecting changes of current tracer. This is because we can assume that these functions are used from onl

Re: [PATCH v3 -tip 2/4] tracing: replace static old_tracer with strcmp

2012-12-21 Thread Hiraku Toyooka
Hi, (12/21/2012 12:04 PM), Steven Rostedt wrote: On Wed, 2012-12-19 at 16:02 +0900, Hiraku Toyooka wrote: Currently, read functions for trace buffer use static old_tracer for detecting changes of current tracer. This is because we can assume that these functions are used from only one file

[PATCH v3 -tip 4/4] tracing: add description of snapshot to Documentation/trace/ftrace.txt

2012-12-18 Thread Hiraku Toyooka
This patch adds snapshot description in ftrace documentation. This description includes what the snapshot is and how to use it. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Rob Landley Cc: linux-...@vger.kernel.org Cc: linux-kernel

[PATCH v3 -tip 2/4] tracing: replace static old_tracer with strcmp

2012-12-18 Thread Hiraku Toyooka
d from two files. So we remove all static "old_tracer", and replace those with string comparison between current and previous tracers. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org --- kernel/trace/trace.c |

[PATCH v3 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-18 Thread Hiraku Toyooka
napshot if it is allocated. Any other positive values will clear the snapshot contents if the snapshot is allocated, or return EINVAL if it is not allocated. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Jiri Olsa Cc: David Sharp Cc: li

[PATCH v3 -tip 1/4] tracing: add checks if tr->buffer is NULL in tracing_reset{_online_cpus}

2012-12-18 Thread Hiraku Toyooka
max_tr->buffer could be NULL in the tracing_reset{_online_cpus}. In this case, a NULL pointer dereference happens, so we should return immediately from these functions. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.

[PATCH v3 -tip 0/4] tracing: make a snapshot feature available from userspace

2012-12-18 Thread Hiraku Toyooka
of the snapshot ToDo: - adding "trace_snapshot" kernel parameter to allocate spare buffer on boot. (v1: https://lkml.org/lkml/2012/10/2/67) (v2: https://lkml.org/lkml/2012/10/16/585) --- Hiraku Toyooka (4): tracing: add checks if tr->buffer is NULL in tracing_reset{_online

[PATCH v3 -tip 0/4] tracing: make a snapshot feature available from userspace

2012-12-18 Thread Hiraku Toyooka
ToDo: - adding trace_snapshot kernel parameter to allocate spare buffer on boot. (v1: https://lkml.org/lkml/2012/10/2/67) (v2: https://lkml.org/lkml/2012/10/16/585) --- Hiraku Toyooka (4): tracing: add checks if tr-buffer is NULL in tracing_reset{_online_cpus} tracing: replace static

[PATCH v3 -tip 1/4] tracing: add checks if tr-buffer is NULL in tracing_reset{_online_cpus}

2012-12-18 Thread Hiraku Toyooka
max_tr-buffer could be NULL in the tracing_reset{_online_cpus}. In this case, a NULL pointer dereference happens, so we should return immediately from these functions. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis

[PATCH v3 -tip 2/4] tracing: replace static old_tracer with strcmp

2012-12-18 Thread Hiraku Toyooka
remove all static old_tracer, and replace those with string comparison between current and previous tracers. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@redhat.com Cc: linux-kernel

[PATCH v3 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-18 Thread Hiraku Toyooka
. Any other positive values will clear the snapshot contents if the snapshot is allocated, or return EINVAL if it is not allocated. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

[PATCH v3 -tip 4/4] tracing: add description of snapshot to Documentation/trace/ftrace.txt

2012-12-18 Thread Hiraku Toyooka
This patch adds snapshot description in ftrace documentation. This description includes what the snapshot is and how to use it. Signed-off-by: Hiraku Toyooka hiraku.toyooka...@hitachi.com Cc: Steven Rostedt rost...@goodmis.org Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-17 Thread Hiraku Toyooka
(12/15/2012 02:08 AM), Steven Rostedt wrote: On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] > > Actually, I would have: > > status\input | 0 | 1

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-17 Thread Hiraku Toyooka
(12/15/2012 02:08 AM), Steven Rostedt wrote: On Fri, 2012-12-07 at 11:07 +0900, Hiraku Toyooka wrote: Hi, Steven, (2012/11/30 23:17), Steven Rostedt wrote: [snip] Actually, I would have: status\input | 0 | 1 |else

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-06 Thread Hiraku Toyooka
} >> mutex_unlock(_types_lock); >> >> +if (iter->snapshot && iter->trace->use_max_tr) >> +return ERR_PTR(-EBUSY); >> + >> ... >> } >> >> static void s_stop(struct seq_file *m, void *p) >> { >> struct tra

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-12-06 Thread Hiraku Toyooka
); if (!p || IS_ERR(p)) break; ... } m-op-stop(m, p); So, I think we need the check in s_stop(), don't we? Thanks, Hiraku Toyooka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-29 Thread Hiraku Toyooka
es - "trace" and "snapshot", so we should change static "old_tracer" to per open-file.) static void *s_start(struct seq_file *m, loff_t *pos) { struct trace_iterator *iter = m->private; -static struct tracer *old_tracer; ... /* copy the tracer to avoid

Re: [PATCH v2 -tip 3/4] tracing: make a snapshot feature available from userspace

2012-11-29 Thread Hiraku Toyooka
see. Thanks, Hiraku Toyooka +if (ret 0) +return ret; + +ret = seq_read(filp, ubuf, cnt, ppos); + +return ret; +} + +static ssize_t +tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt, + loff_t *ppos) +{ +unsigned long

[tip:perf/core] tracing: Change tracer's integer flags to bool

2012-11-13 Thread tip-bot for Hiraku Toyooka
Commit-ID: f43c738bfa8608424610e4fc1aef4d4644e2ce11 Gitweb: http://git.kernel.org/tip/f43c738bfa8608424610e4fc1aef4d4644e2ce11 Author: Hiraku Toyooka AuthorDate: Tue, 2 Oct 2012 17:27:10 +0900 Committer: Steven Rostedt CommitDate: Wed, 31 Oct 2012 16:45:25 -0400 tracing: Change

[tip:perf/core] tracing: Change tracer's integer flags to bool

2012-11-13 Thread tip-bot for Hiraku Toyooka
Commit-ID: f43c738bfa8608424610e4fc1aef4d4644e2ce11 Gitweb: http://git.kernel.org/tip/f43c738bfa8608424610e4fc1aef4d4644e2ce11 Author: Hiraku Toyooka hiraku.toyooka...@hitachi.com AuthorDate: Tue, 2 Oct 2012 17:27:10 +0900 Committer: Steven Rostedt rost...@goodmis.org CommitDate: Wed, 31

[PATCH v2 -tip 2/4] tracing: add a resize function for making one buffer equivalent to the other buffer

2012-10-16 Thread Hiraku Toyooka
-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org --- kernel/trace/trace.c | 58 +++--- 1 files changed, 31 insertions(+), 27 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace

[PATCH v2 -tip 4/4] tracing: add description of snapshot to Documentation/trace/ftrace.txt

2012-10-16 Thread Hiraku Toyooka
This patch adds snapshot description in ftrace documentation. This description includes what the snapshot is and how to use it. Signed-off-by: Hiraku Toyooka Cc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Rob Landley Cc: linux-...@vger.kernel.org Cc: linux-kernel

  1   2   >