[PATCH 2.6.25] lib/vsprintf.c: Fix bug omitting minus sign of numbers (module_param)

2008-02-21 Thread Hoang-Nam Nguyen
lib/vsprintf.c: Fix bug omitting minus sign of numbers (module_param) This exists in 2.6.25 only. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- lib/vsprintf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index f

[PATCH 2.6.25] lib/vsprintf.c: Fix bug omitting minus sign of numbers (module_param)

2008-02-21 Thread Hoang-Nam Nguyen
lib/vsprintf.c: Fix bug omitting minus sign of numbers (module_param) This exists in 2.6.25 only. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- lib/vsprintf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index fd987b1..6021757

[PATCH] IB/ipoib: Fix undefined symbol (priv->cm) if ipoib_cm disabled

2008-01-16 Thread Hoang-Nam Nguyen
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/ulp/ipoib/ipoib_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index e499626..0a58ac4

[PATCH] IB/ipoib: Fix undefined symbol (priv-cm) if ipoib_cm disabled

2008-01-16 Thread Hoang-Nam Nguyen
Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers/infiniband/ulp/ipoib/ipoib_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index e499626..0a58ac4 100644

Re: [PATCH] IB/ehca: Forward event client-reregister-required to registered clients

2008-01-03 Thread Hoang-Nam Nguyen
Hi Roland, Just want to make sure you've seen this patch and if it looks ok for you. Thanks Nam On Thursday 20 December 2007 15:06, Hoang-Nam Nguyen wrote: > This patch allows ehca to forward event client-reregister-required to > registered clients. Such one event is generated by the swi

Re: [PATCH] IB/ehca: Forward event client-reregister-required to registered clients

2008-01-03 Thread Hoang-Nam Nguyen
Hi Roland, Just want to make sure you've seen this patch and if it looks ok for you. Thanks Nam On Thursday 20 December 2007 15:06, Hoang-Nam Nguyen wrote: This patch allows ehca to forward event client-reregister-required to registered clients. Such one event is generated by the switch eg

[PATCH] IB/ehca: Forward event client-reregister-required to registered clients

2007-12-20 Thread Hoang-Nam Nguyen
This patch allows ehca to forward event client-reregister-required to registered clients. Such one event is generated by the switch eg. after its reboot. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c | 12 1 files chang

[PATCH] IB/ehca: Forward event client-reregister-required to registered clients

2007-12-20 Thread Hoang-Nam Nguyen
This patch allows ehca to forward event client-reregister-required to registered clients. Such one event is generated by the switch eg. after its reboot. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_irq.c | 12 1 files changed, 12

Re: [PATCH] hugetlb: follow_hugetlb_page for write access

2007-11-19 Thread Hoang-Nam Nguyen
On Wednesday 07 November 2007 20:51, Adam Litke wrote: > > When calling get_user_pages(), a write flag is passed in by the caller to > indicate if write access is required on the faulted-in pages. Currently, > follow_hugetlb_page() ignores this flag and always faults pages for > read-only

Re: [PATCH] hugetlb: follow_hugetlb_page for write access

2007-11-19 Thread Hoang-Nam Nguyen
On Wednesday 07 November 2007 20:51, Adam Litke wrote: When calling get_user_pages(), a write flag is passed in by the caller to indicate if write access is required on the faulted-in pages. Currently, follow_hugetlb_page() ignores this flag and always faults pages for read-only access.

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

2007-11-06 Thread Hoang-Nam Nguyen
Hi Adam! On Tuesday 06 November 2007 16:05, aglitke wrote: > Please try this patch and see if it helps. Tested on 2.6.22 (don't have the system with 2.6.23 at the moment) and the testcase ran perfectly. Thanks! Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

2007-11-06 Thread Hoang-Nam Nguyen
Hello Roland! > We currently see this when testing Infiniband on ppc64 with ehca + > hugetlbfs. > From reading the code this should also be an issue on other architectures. > Roland, Adam, are you aware of anything in this area with mellanox > Infiniband cards or other usages with I/O adapters?

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

2007-11-06 Thread Hoang-Nam Nguyen
Hello Roland! We currently see this when testing Infiniband on ppc64 with ehca + hugetlbfs. From reading the code this should also be an issue on other architectures. Roland, Adam, are you aware of anything in this area with mellanox Infiniband cards or other usages with I/O adapters? Below

Re: problem in follow_hugetlb_page on ppc64 architecture with get_user_pages

2007-11-06 Thread Hoang-Nam Nguyen
Hi Adam! On Tuesday 06 November 2007 16:05, aglitke wrote: Please try this patch and see if it helps. Tested on 2.6.22 (don't have the system with 2.6.23 at the moment) and the testcase ran perfectly. Thanks! Nam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [ofa-general] [PATCH 7/7] IB/ehca: Prevent overwriting QP init attributes given by caller

2007-08-16 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 16.08.2007 18:17:22: > I don't understand this patch. says this about > ib_create_qp(): > > * @qp_init_attr: A list of initial attributes required to create the > * QP. If QP creation succeeds, then the attributes are updated to > * the actual capabilities of

Re: [ofa-general] [PATCH 7/7] IB/ehca: Prevent overwriting QP init attributes given by caller

2007-08-16 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 16.08.2007 18:17:22: I don't understand this patch. rdma/ib_verbs.h says this about ib_create_qp(): * @qp_init_attr: A list of initial attributes required to create the * QP. If QP creation succeeds, then the attributes are updated to * the actual

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-08 Thread Hoang-Nam Nguyen
s Nam On Friday 03 August 2007 10:36, Hoang-Nam Nguyen wrote: > From: Hoang-Nam Nguyen > Date: Fri, 3 Aug 2007 09:44:56 +0200 > Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space > This patch utilizes remap_4k_pfn() as introduced by Paul M., > for details see

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-08 Thread Hoang-Nam Nguyen
Nguyen wrote: From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Fri, 3 Aug 2007 09:44:56 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-03 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen Date: Fri, 3 Aug 2007 09:44:56 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq, qp firmware context

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-03 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Fri, 3 Aug 2007 09:44:56 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq

[PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-02 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen Date: Thu, 2 Aug 2007 10:08:30 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq, qp firmware context

[PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-02 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Thu, 2 Aug 2007 10:08:30 +0200 Subject: [PATCH] ehca: map 4k firmware context of cq, qp to user space This patch utilizes remap_4k_pfn() as introduced by Paul M., for details see http://patchwork.ozlabs.org/linuxppc/patch?id=10281, to map ehca cq

Re: [PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-30 Thread Hoang-Nam Nguyen
Hi, > BTW, does your SRQ-capable hardware support generating the "last WQE > reached" event? There's not any reliable way to avoid problems when > destroying QPs attached to an SRQ without it, and the IB spec requires > CAs that support SRQs to generate it (o11-5.2.5 in chapter 11 of vol 1). > >

Re: [ofa-general] [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

2007-07-30 Thread Hoang-Nam Nguyen
Hi Roland! > the patch looks fine except your mailer seems to have mangled > it... can you resend so I can apply it? Was going to recreate this patch, but then I saw that you probably have incorporated it (manually) in your latest git. Just want to make sure I'm seeing it right. Anyway, appreciate

Re: [ofa-general] [PATCH 1/2] ehca: remove checkpatch.pl's warnings externs should be avoided in .c files

2007-07-30 Thread Hoang-Nam Nguyen
Hi Roland! the patch looks fine except your mailer seems to have mangled it... can you resend so I can apply it? Was going to recreate this patch, but then I saw that you probably have incorporated it (manually) in your latest git. Just want to make sure I'm seeing it right. Anyway, appreciate

Re: [PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-30 Thread Hoang-Nam Nguyen
Hi, BTW, does your SRQ-capable hardware support generating the last WQE reached event? There's not any reliable way to avoid problems when destroying QPs attached to an SRQ without it, and the IB spec requires CAs that support SRQs to generate it (o11-5.2.5 in chapter 11 of vol 1). I don't

[PATCH 2/2] ehca: correction include order according kernel coding style

2007-07-27 Thread Hoang-Nam Nguyen
>From a2794450cbee597cefd7b6e159257583c459d358 Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen Date: Fri, 27 Jul 2007 10:26:40 +0200 Subject: [PATCH] correction include order according kernel coding style Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniban

[PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

2007-07-27 Thread Hoang-Nam Nguyen
>From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen Date: Fri, 27 Jul 2007 10:24:49 +0200 Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided in .c files" Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTE

[PATCH 0/2] ehca: remove WARNING: externs should be avoided in .c files

2007-07-27 Thread Hoang-Nam Nguyen
Hello Roland! This small patch set fixes some coding-style related issues for ehca: [1/2] remove checkpatch.pl's warnings "externs should be avoided in .c files" [2/2] correction include order according kernel coding style Thanks Nam - To unsubscribe from this list: send the line "unsubscribe

[PATCH 1/2] ehca: remove checkpatch.pl's warnings externs should be avoided in .c files

2007-07-27 Thread Hoang-Nam Nguyen
From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Fri, 27 Jul 2007 10:24:49 +0200 Subject: [PATCH] remove checkpatch.pl's warnings externs should be avoided in .c files Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED

[PATCH 0/2] ehca: remove WARNING: externs should be avoided in .c files

2007-07-27 Thread Hoang-Nam Nguyen
Hello Roland! This small patch set fixes some coding-style related issues for ehca: [1/2] remove checkpatch.pl's warnings externs should be avoided in .c files [2/2] correction include order according kernel coding style Thanks Nam - To unsubscribe from this list: send the line unsubscribe

[PATCH 2/2] ehca: correction include order according kernel coding style

2007-07-27 Thread Hoang-Nam Nguyen
From a2794450cbee597cefd7b6e159257583c459d358 Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Fri, 27 Jul 2007 10:26:40 +0200 Subject: [PATCH] correction include order according kernel coding style Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-21 Thread Hoang-Nam Nguyen
Hi Roland! > I applied this, but I agree with checkpatch.pl: > > > WARNING: externs should be avoided in .c files > > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: > > +extern int ehca_mr_largepage; > > > > WARNING: externs should be avoided in .c files > > #949: FILE:

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-21 Thread Hoang-Nam Nguyen
Hi Roland! I applied this, but I agree with checkpatch.pl: WARNING: externs should be avoided in .c files #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: +extern int ehca_mr_largepage; WARNING: externs should be avoided in .c files #949: FILE:

[PATCH 5/5] ehca: Support small QP queues

2007-07-20 Thread Hoang-Nam Nguyen
with firmware, this code needs to manage bite-sized chunks of kernel pages, making sure that no kernel page is shared between different protection domains. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_classes.h | 41 -- drivers/infiniband/h

[PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:51:43 +0200 Subject: [PATCH 2/5] IB/ehca: Generate event when SRQ limit reached Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c | 42 ++--- 1 files

[PATCH 4/5] ehca: Make internal_create/destroy_qp() static

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:40:00 +0200 Subject: [PATCH 4/5] IB/ehca: Make internal_{create,destroy}_qp() static They're only used in ehca_qp.c Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c | 17

[PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:13:57 +0200 Subject: [PATCH 3/5] IB/ehca: Make ehca2ib_return_code() non-inline It's nowhere in the main path and making it non-inline saves ~1.5K of code. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> ---

[PATCH 1/5] ehca: Supports large page MRs

2007-07-20 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:48:04 +0200 Subject: [PATCH 1/5] IB/ehca: Support large page MRs Add support for MR pages larger than 4K on eHCA2. This reduces firmware memory consumption. If enabled via the mr_largepage module parameter, the MR pag

[PATCH 0/5] ehca: MR large page, small queue and fixes

2007-07-20 Thread Hoang-Nam Nguyen
Here is a patch set against Roland's git, branch for-2.6.23 for ehca. It adds support for MR large page and small queues. In addition of that it also contains various small fixes from previous comments and what we found. They are in details: [1/5] adds support for MR large page [2/5] generates

[PATCH 0/5] ehca: MR large page, small queue and fixes

2007-07-20 Thread Hoang-Nam Nguyen
Here is a patch set against Roland's git, branch for-2.6.23 for ehca. It adds support for MR large page and small queues. In addition of that it also contains various small fixes from previous comments and what we found. They are in details: [1/5] adds support for MR large page [2/5] generates

[PATCH 1/5] ehca: Supports large page MRs

2007-07-20 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen [EMAIL PROTECTED] Date: Thu, 19 Jul 2007 20:48:04 +0200 Subject: [PATCH 1/5] IB/ehca: Support large page MRs Add support for MR pages larger than 4K on eHCA2. This reduces firmware memory consumption. If enabled via the mr_largepage module parameter, the MR page size

[PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes [EMAIL PROTECTED] Date: Thu, 19 Jul 2007 21:13:57 +0200 Subject: [PATCH 3/5] IB/ehca: Make ehca2ib_return_code() non-inline It's nowhere in the main path and making it non-inline saves ~1.5K of code. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] ---

[PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes [EMAIL PROTECTED] Date: Thu, 19 Jul 2007 20:51:43 +0200 Subject: [PATCH 2/5] IB/ehca: Generate event when SRQ limit reached Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_irq.c | 42 ++--- 1 files changed, 28

[PATCH 4/5] ehca: Make internal_create/destroy_qp() static

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes [EMAIL PROTECTED] Date: Thu, 19 Jul 2007 21:40:00 +0200 Subject: [PATCH 4/5] IB/ehca: Make internal_{create,destroy}_qp() static They're only used in ehca_qp.c Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_qp.c | 17 +

[PATCH 5/5] ehca: Support small QP queues

2007-07-20 Thread Hoang-Nam Nguyen
-only QPs). Apart from dealing with firmware, this code needs to manage bite-sized chunks of kernel pages, making sure that no kernel page is shared between different protection domains. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- drivers/infiniband/hw/ehca/ehca_classes.h | 41

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-19 Thread Hoang-Nam Nguyen
Roland Dreier <[EMAIL PROTECTED]> wrote on 17.07.2007 19:52:55: > At a higher level, I'm left wondering why nobody talked about multiple > EQs during the last months of the 2.6.22 process and now all of a > sudden it becomes urgent in the last few days of the 2.6.23 merge > window. That's not

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-19 Thread Hoang-Nam Nguyen
Roland Dreier [EMAIL PROTECTED] wrote on 17.07.2007 19:52:55: At a higher level, I'm left wondering why nobody talked about multiple EQs during the last months of the 2.6.22 process and now all of a sudden it becomes urgent in the last few days of the 2.6.23 merge window. That's not really

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Hoang-Nam Nguyen
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 18:04:26: > Do you have any data on how well this round-robin assignment works? > It seems not quite right to me for the driver to advertise nr_eqs > completion vectors, but then if round-robin is turned on to ignore the > consumer's decision

Re: [PATCH 01/10] IB/ehca: Support for multiple event queues

2007-07-16 Thread Hoang-Nam Nguyen
Roland Dreier [EMAIL PROTECTED] wrote on 16.07.2007 18:04:26: Do you have any data on how well this round-robin assignment works? It seems not quite right to me for the driver to advertise nr_eqs completion vectors, but then if round-robin is turned on to ignore the consumer's decision about

Re: [PATCH] fix idr_get_new_above id alias bugs

2007-07-11 Thread Hoang-Nam Nguyen
> With this patch, idr.c should work as advertised allocating id > values in the range 0...0x7fff. Andrew had speculated that > it should allow the full range 0...0x to be used. I was > tempted to make changes to allow this, but it would require changes > to API, e.g. making the

Re: [PATCH] fix idr_get_new_above id alias bugs

2007-07-11 Thread Hoang-Nam Nguyen
With this patch, idr.c should work as advertised allocating id values in the range 0...0x7fff. Andrew had speculated that it should allow the full range 0...0x to be used. I was tempted to make changes to allow this, but it would require changes to API, e.g. making the starting

Re: idr_get_new_above() limitation?

2007-07-04 Thread Hoang-Nam Nguyen
On Tuesday 03 July 2007 02:31, Jim Houston wrote: > The problem is in idr_get_new_above_int() in the loop which > adds new layers to the top of the radix tree. It is failing > the "layers < (MAX_LEVEL - 1)" test. It doesn't allocate the > new layer but still calls sub_alloc() which relies on

Re: idr_get_new_above() limitation?

2007-07-04 Thread Hoang-Nam Nguyen
On Tuesday 03 July 2007 02:31, Jim Houston wrote: The problem is in idr_get_new_above_int() in the loop which adds new layers to the top of the radix tree. It is failing the layers (MAX_LEVEL - 1) test. It doesn't allocate the new layer but still calls sub_alloc() which relies on having

idr_get_new_above() limitation?

2007-07-02 Thread Hoang-Nam Nguyen
Hello, For ehca device driver we're intending to utilize idr_get_new_above() and have written a test case, which I'm attaching at the end. Basically it tries to get an idr token above a lower boundary by calling idr_get_new_above() and then uses idr_find() to check if the returned token can be

idr_get_new_above() limitation?

2007-07-02 Thread Hoang-Nam Nguyen
Hello, For ehca device driver we're intending to utilize idr_get_new_above() and have written a test case, which I'm attaching at the end. Basically it tries to get an idr token above a lower boundary by calling idr_get_new_above() and then uses idr_find() to check if the returned token can be

[PATCH 2.6.22] ehca: return proper error code if register_mr fails

2007-05-16 Thread Hoang-Nam Nguyen
This patch sets the return code of ehca_register_mr() to ENOMEM if corresponding firmware call fails due to out of resources. Some of error codes were mapped to EINVAL. They are now mapped to default case, which already returns EINVAL anyway. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTEC

[PATCH 2.6.22] ehca: return proper error code if register_mr fails

2007-05-16 Thread Hoang-Nam Nguyen
This patch sets the return code of ehca_register_mr() to ENOMEM if corresponding firmware call fails due to out of resources. Some of error codes were mapped to EINVAL. They are now mapped to default case, which already returns EINVAL anyway. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED

Re: [ofa-general] [PATCH][RFC] IB: Return "maybe missed event" hint from ib_req_notify_cq()

2007-04-30 Thread Hoang-Nam Nguyen
Hi Roland! As far as this concerns ehca this looks great. Thanks Nam [EMAIL PROTECTED] wrote on 27.04.2007 00:43:19: > > - "IB: Return "maybe missed event" hint from ib_req_notify_cq()" > > This extends the API in a way that lets us implement NAPI, but may > > be useful for other

Re: [ofa-general] [PATCH][RFC] IB: Return maybe missed event hint from ib_req_notify_cq()

2007-04-30 Thread Hoang-Nam Nguyen
Hi Roland! As far as this concerns ehca this looks great. Thanks Nam [EMAIL PROTECTED] wrote on 27.04.2007 00:43:19: - IB: Return maybe missed event hint from ib_req_notify_cq() This extends the API in a way that lets us implement NAPI, but may be useful for other things too.

Re: [PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq

2007-03-02 Thread Hoang-Nam Nguyen
> > +#include > This can just be , because you're only using > wait_queue_head_t and not struct completion, right? > I fixed this up before merging. Yes, right. Thanks for your help! Regards Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq

2007-03-02 Thread Hoang-Nam Nguyen
+#include linux/completion.h This can just be linux/wait.h, because you're only using wait_queue_head_t and not struct completion, right? I fixed this up before merging. Yes, right. Thanks for your help! Regards Nam - To unsubscribe from this list: send the line unsubscribe linux-kernel in

[PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq

2007-02-28 Thread Hoang-Nam Nguyen
ehca_cq_idr_lock. - Replace yield by wait_event on the counter above to become zero Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h |6 - ehca_cq.c | 16 +-- ehca_irq.c

[PATCH 2.6.21-rc2] ehca: fix mismatched sync between completion handler and destroy cq

2007-02-28 Thread Hoang-Nam Nguyen
ehca_cq_idr_lock. - Replace yield by wait_event on the counter above to become zero Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h |6 - ehca_cq.c | 16 +-- ehca_irq.c | 59 + ehca_main.c

[PATCH 1/2] ibmebus: dynamic addiiton/removal of adapters, uevent, root device based on struct device

2007-02-22 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> This adds two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT "ibm,loc-code" property) into the "probe"

[PATCH 2/2] ibmebus: whitespace fixes

2007-02-22 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> This fixes whitespacing in ibmebus.[ch] - no functionality changed. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 126 +- include/asm-powerpc/ibmebus.h | 42

[PATCH 1/2] ibmebus: dynamic addiiton/removal of adapters, uevent, root device based on struct device

2007-02-22 Thread Hoang-Nam Nguyen
From: Joachim Fenkes [EMAIL PROTECTED] This adds two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT ibm,loc-code property) into the probe attribute

[PATCH 2/2] ibmebus: dynamic add/remove, uevent, root device and whitespace

2007-02-21 Thread Hoang-Nam Nguyen
This is the aforementioned whitespace fix which applies on top of part 1/2. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- arch/powerpc/kernel/ibmebus.c | 126 +- include/asm-powerpc/ibmebus.h | 42 +++--- diff -urp

[PATCH 1/2] ibmebus: dynamic add/remove, uevent, root device and whitespace

2007-02-21 Thread Hoang-Nam Nguyen
The first part of this patch summarizes the patches of the previous days, namely: - Add dynamic addition/removal of adapters (with spiffy error reporting) - Implement the uevent interface using Sylvain's generic function - Base fake root device on device instead of of_device The first part

[PATCH 1/2] ibmebus: dynamic add/remove, uevent, root device and whitespace

2007-02-21 Thread Hoang-Nam Nguyen
The first part of this patch summarizes the patches of the previous days, namely: - Add dynamic addition/removal of adapters (with spiffy error reporting) - Implement the uevent interface using Sylvain's generic function - Base fake root device on device instead of of_device The first part

[PATCH 2/2] ibmebus: dynamic add/remove, uevent, root device and whitespace

2007-02-21 Thread Hoang-Nam Nguyen
This is the aforementioned whitespace fix which applies on top of part 1/2. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- arch/powerpc/kernel/ibmebus.c | 126 +- include/asm-powerpc/ibmebus.h | 42 +++--- diff -urp

[PATCH 2.6.21-rc1] ibmebus: more error reporting in dynamic add/remove code

2007-02-20 Thread Hoang-Nam Nguyen
Writing the ibmebus probe and remove attributes now throws an appropriate error if something goes wrong. This way, userspace tools can check for success or failure of an addition or removal. The write will block until the probe/remove operation completes, so, when the write operation returns

[PATCH 2.6.21-rc1] ibmebus: more error reporting in dynamic add/remove code

2007-02-20 Thread Hoang-Nam Nguyen
Writing the ibmebus probe and remove attributes now throws an appropriate error if something goes wrong. This way, userspace tools can check for success or failure of an addition or removal. The write will block until the probe/remove operation completes, so, when the write operation returns

[PATCH 2.6.21-rc1] ibmebus: make root device not of_device-based

2007-02-19 Thread Hoang-Nam Nguyen
The fake root device doesn't have an associated device tree node, so it should not be an of_device. This patch makes it a normal, bus-less device and thus saves a lot of checks later on. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- ibmebus.c | 33 ++---

[PATCH 2.6.21-rc1] ibmebus: make root device not of_device-based

2007-02-19 Thread Hoang-Nam Nguyen
The fake root device doesn't have an associated device tree node, so it should not be an of_device. This patch makes it a normal, bus-less device and thus saves a lot of checks later on. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- ibmebus.c | 33 ++--- 1

[PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Hoang-Nam Nguyen
ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent(). Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- of_device.c |4 1 files changed, 4 insertions(+) diff -urp a/arch/powerpc/kernel/of_device.c

[PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus

2007-02-17 Thread Hoang-Nam Nguyen
ibmebus has a fake root device that's not associated with an ofdt node. Filter out any such devices in of_device_uevent(). Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- of_device.c |4 1 files changed, 4 insertions(+) diff -urp a/arch/powerpc/kernel/of_device.c

[PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()

2007-02-16 Thread Hoang-Nam Nguyen
This patch replaces ibmebus_uevent() by Sylvain's generic function. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- ibmebus.c | 37 +++-- 1 file changed, 3 insertions(+), 34 deletions(-) diff -urp a/arch/powerpc/kernel/ibmebus.c

[PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent()

2007-02-16 Thread Hoang-Nam Nguyen
This patch replaces ibmebus_uevent() by Sylvain's generic function. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- ibmebus.c | 37 +++-- 1 file changed, 3 insertions(+), 34 deletions(-) diff -urp a/arch/powerpc/kernel/ibmebus.c

Re: [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-15 Thread Hoang-Nam Nguyen
Hi, > So I'm holding off on applying this for now. Please think it over and > either tell me the current patch is OK, or fix it up. There's not > really too much urgency because a change like this is something I > would be comfortable merging between 2.6.21-rc1 and -rc2. You're absolutely right.

[PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread Hoang-Nam Nguyen
This patch will add two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT "ibm,loc-code" property) into the "probe" attribute will notify ebus of addition

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-15 Thread Hoang-Nam Nguyen
set port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_hca.c |3 +++ 1 files changed, 3 insertions(+) diff --git a/d

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-15 Thread Hoang-Nam Nguyen
allow users to en/disable scaling code when loading ib_ehca module Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47 +-- ehca_main.c|4 4

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-15 Thread Hoang-Nam Nguyen
remove yield() and use wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h |3 +++ ehca_cq.c |5 +++-- ehca_irq.c |6 +++

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-15 Thread Hoang-Nam Nguyen
fix a race condition in find_next_cpu_online() and some other locking issues in scaling code Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c | 68 + 1 files changed, 33 insertions(+), 35 deletions(-) diff

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
reworked irq handler to avoid/reduce missed irq events Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 18 +++- ehca_eq.c |1 ehca_irq.c | 214 +++-- ehca_irq.h |1 ehca_main.c

Re: [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
> Looks fine but this patch at least has serious whitespace > damage... please resend a fixed version. Sorry for this. Resending the patches 1-5. Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread Hoang-Nam Nguyen
This patch will add two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT ibm,loc-code property) into the probe attribute will notify ebus of addition of

Re: [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
Looks fine but this patch at least has serious whitespace damage... please resend a fixed version. Sorry for this. Resending the patches 1-5. Nam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
reworked irq handler to avoid/reduce missed irq events Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++- ehca_eq.c |1 ehca_irq.c | 214 +++-- ehca_irq.h |1 ehca_main.c| 28

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-15 Thread Hoang-Nam Nguyen
fix a race condition in find_next_cpu_online() and some other locking issues in scaling code Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c | 68 + 1 files changed, 33 insertions(+), 35 deletions(-) diff --git

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-15 Thread Hoang-Nam Nguyen
allow users to en/disable scaling code when loading ib_ehca module Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47 +-- ehca_main.c|4 4 files changed

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-15 Thread Hoang-Nam Nguyen
remove yield() and use wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h |3 +++ ehca_cq.c |5 +++-- ehca_irq.c |6 +- 3

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-15 Thread Hoang-Nam Nguyen
set port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c |3 +++ 1 files changed, 3 insertions(+) diff --git a/drivers

Re: [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-15 Thread Hoang-Nam Nguyen
Hi, So I'm holding off on applying this for now. Please think it over and either tell me the current patch is OK, or fix it up. There's not really too much urgency because a change like this is something I would be comfortable merging between 2.6.21-rc1 and -rc2. You're absolutely right.

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch sets port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_hca.c |3 +++ 1 files changed, 3 inse

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch removes yield() and uses wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h |3 +++ ehca_cq.c

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca that allows users to en/disable scaling code when loading ib_ehca module. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch fixes a race condition in find_next_cpu_online() and some other locking issues in scaling code. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c | 68 + 1 files changed, 33 inse

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 200 - ehca_irq.h

  1   2   >