[PATCH v5 1/4] media: stm32-dcmi: add support of BT656 bus

2020-11-04 Thread Hugues Fruchet
ro codes, valid data vary from 0x1 to 0xfe, this is up to sensor to clip accordingly pixel data. As a consequence of this clipping, JPEG is not supported with this bus type. DCMI crop feature is also not available with this bus type. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm3

[PATCH v5 3/4] ARM: dts: stm32: set bus-type in DCMI endpoint for stm32mp157c-ev1 board

2020-11-04 Thread Hugues Fruchet
Explicitly set bus-type to parallel mode in DCMI endpoint (bus-type=5). Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stm32mp157c-ev1.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts index 85628e1

[PATCH v5 2/4] media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus

2020-11-04 Thread Hugues Fruchet
replacing them with synchro codes embedded in data stream, hence hsync-active & vsync-active properties are useless in this mode. With DCMI, BT656 bus mode is only compatible with 8 bits width data bus. Signed-off-by: Hugues Fruchet --- .../devicetree/bindings/media/st,stm32-dcmi.yaml | 38 +++

[PATCH v5 4/4] ARM: dts: stm32: set bus-type in DCMI endpoint for stm32429i-eval board

2020-11-04 Thread Hugues Fruchet
Explicitly set bus-type to parallel mode in DCMI endpoint (bus-type=5). Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stm32429i-eval.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index 67e7648..7e10ae7

[PATCH v5 0/4] DCMI BT656 parallel bus mode support

2020-11-04 Thread Hugues Fruchet
i remark, revisit commit message and document BT656 parallel bus mode in bindings version 1: - Initial submission Hugues Fruchet (4): media: stm32-dcmi: add support of BT656 bus media: dt-bindings: media: st,stm32-dcmi: add support of BT656 bus ARM: dts: stm32: set bus-type in DCMI endp

Re: [PATCH v4 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656

2020-10-22 Thread Hugues FRUCHET
Hi Sakari, + Jacopo for his work on ov772x binding related to BT656 On 10/21/20 11:40 PM, Sakari Ailus wrote: > Hi Hugues, > > On Wed, Oct 21, 2020 at 02:24:08PM +0000, Hugues FRUCHET wrote: >> Hi Sakari, >> >> On 10/21/20 3:00 PM, Sakari Ailus wrote: >>> Hi

Re: [PATCH v4 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656

2020-10-21 Thread Hugues FRUCHET
Hi Sakari, On 10/21/20 3:00 PM, Sakari Ailus wrote: > Hi Hugues, > > On Tue, Oct 20, 2020 at 12:14:49PM +0200, Hugues Fruchet wrote: >> Add support of BT656 parallel bus mode in DCMI. >> This mode is enabled when hsync-active & vsync-active >> fields are

[PATCH v4 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656

2020-10-20 Thread Hugues Fruchet
Add support of BT656 parallel bus mode in DCMI. This mode is enabled when hsync-active & vsync-active fields are not specified. Signed-off-by: Hugues Fruchet --- .../devicetree/bindings/media/st,stm32-dcmi.yaml | 30 ++ 1 file changed, 30 insertions(+) diff -

[PATCH v4 1/2] media: stm32-dcmi: add support of BT656 bus

2020-10-20 Thread Hugues Fruchet
ro codes, valid data vary from 0x1 to 0xfe, this is up to sensor to clip accordingly pixel data. As a consequence of this clipping, JPEG is not supported with this bus type. DCMI crop feature is also not available with this bus type. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm3

[PATCH v4 0/2] DCMI BT656 parallel bus mode support

2020-10-20 Thread Hugues Fruchet
history = === version 4: - Fix typo in commit message version 3: - Fix bus_width print to %u as per Sakari comment version 2: - As per Sakari remark, revisit commit message and document BT656 parallel bus mode in bindings version 1: - Initial submission Hugues Fruchet (2): medi

[PATCH v3 1/2] media: stm32-dcmi: add support of BT656 bus

2020-10-20 Thread Hugues Fruchet
bus type. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 37 +-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c index fd1c41c..770568

[PATCH v3 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656

2020-10-20 Thread Hugues Fruchet
Add support of BT656 parallel bus mode in DCMI. This mode is enabled when hsync-active & vsync-active fields are not specified. Signed-off-by: Hugues Fruchet --- .../devicetree/bindings/media/st,stm32-dcmi.yaml | 30 ++ 1 file changed, 30 insertions(+) diff -

[PATCH v3 0/2] DCMI BT656 parallel bus mode support

2020-10-20 Thread Hugues Fruchet
history = === version 3: - Fix bus_width print to %u as per Sakari comment version 2: - As per Sakari remark, revisit commit message and document BT656 parallel bus mode in bindings version 1: - Initial submission Hugues Fruchet (2): media: stm32-dcmi: add support of BT656 bus m

[PATCH v2 1/2] media: stm32-dcmi: add support of BT656 bus

2020-10-20 Thread Hugues Fruchet
bus type. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 37 +-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c index fd1c41c..d7d7cd

[PATCH v2 0/2] DCMI BT656 parallel bus mode support

2020-10-20 Thread Hugues Fruchet
history = === version 2: - As per Sakari remark, revisit commit message and document BT656 parallel bus mode in bindings version 1: - Initial submission Hugues Fruchet (2): media: stm32-dcmi: add support of BT656 bus media: dt-bindings: media: st,stm32-dcmi: Add support

[PATCH v2 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656

2020-10-20 Thread Hugues Fruchet
Add support of BT656 parallel bus mode in DCMI. This mode is enabled when hsync-active & vsync-active fields are not specified. Signed-off-by: Hugues Fruchet --- .../devicetree/bindings/media/st,stm32-dcmi.yaml | 30 ++ 1 file changed, 30 insertions(+) diff -

Re: [PATCH] media: stm32-dcmi: add support of BT656 bus

2020-10-19 Thread Hugues FRUCHET
Hi Sakari, I have questions about "bus-type" handling below. On 10/15/20 5:41 PM, Hugues FRUCHET wrote: > Hi Sakari, > > Thanks for reviewing, > > On 10/13/20 11:07 AM, Sakari Ailus wrote: >> Hi Hugues, >> >> On Wed, Oct 07, 2020 at 06:14:50PM +

Re: [PATCH] media: stm32-dcmi: add support of BT656 bus

2020-10-15 Thread Hugues FRUCHET
Hi Sakari, Thanks for reviewing, On 10/13/20 11:07 AM, Sakari Ailus wrote: > Hi Hugues, > > On Wed, Oct 07, 2020 at 06:14:50PM +0200, Hugues Fruchet wrote: >> Add support of BT656 embedded synchronization bus. >> This mode allows to save hardware synchro lines hsync & v

[PATCH] ARM: dts: stm32: fix DCMI DMA features on stm32mp15 family

2020-10-08 Thread Hugues Fruchet
Enable FIFO mode with half-full threshold. Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stm32mp151.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi index bfe2902..cfba9a1 100644 --- a/arch/arm

[PATCH] media: stm32-dcmi: add support of BT656 bus

2020-10-07 Thread Hugues Fruchet
ro codes, valid data only vary from 0x1 to 0xfe, this is up to sensor to clip accordingly pixel data. As a consequence of this clipping, JPEG is not supported when using this bus type. DCMI crop feature is also not available with this bus type. Signed-off-by: Hugues Fruchet --- drivers/media/platfo

[PATCH] media: stm32-dcmi: add 8-bit Bayer formats support

2020-10-07 Thread Hugues Fruchet
From: Alain Volmat Add BA81, GBRG, GRBG, RGGB formats in the list of supported capture formats. Signed-off-by: Alain Volmat Acked-by: Hugues FRUCHET Reviewed-by: Philippe CORNU --- drivers/media/platform/stm32/stm32-dcmi.c | 16 1 file changed, 16 insertions(+) diff --git

[PATCH] media: stm32-dcmi: remove deprecated dmaengine_terminate_all()

2020-10-07 Thread Hugues Fruchet
Replace dmaengine_terminate_all() by dmaengine_terminate_sync() to ensure that all pending dma operations are really finished. This is not ensured by dmaengine_terminate_all() and this API is deprecated, so better to use the _sync() variant. Signed-off-by: Hugues Fruchet Reviewed-by: Philippe

[PATCH] media: stm32-dcmi: don't print an error on probe deferral

2020-10-07 Thread Hugues Fruchet
From: Etienne Carriere Change stm32-dcmi driver to not print an error message when the device probe operation is deferred. Signed-off-by: Etienne Carriere Acked-by: Hugues Fruchet Tested-by: Alexandre TORGUE --- drivers/media/platform/stm32/stm32-dcmi.c | 4 +++- 1 file changed, 3

Re: [PATCH v2 3/4] media: i2c: ov5640: Add support for BT656 mode

2020-09-10 Thread Hugues FRUCHET
Hi Prabhakar, I'm currently testing the OV5640 CCIR656 embedded synchronisation mode on STM32MP1 running STM32 DCMI camera interface. Tests not yet fully completed but sounds good, more details below. On 8/3/20 4:31 PM, Lad Prabhakar wrote: > Enable support for BT656 mode. > > Signed-off-by:

Re: [PATCH v4 1/6] media: i2c: ov5640: Remain in power down for DVP mode unless streaming

2020-09-09 Thread Hugues FRUCHET
Hi Prabhakar, As discussed separately I would prefer to better understand issue before going to this patch. Nevertheless I have some remarks in code in case we'll need it at the end. On 9/4/20 10:18 PM, Lad Prabhakar wrote: > Keep the sensor in software power down mode and wake up only in >

Re: [PATCH v4 3/6] media: i2c: ov5640: Enable data pins on poweron for DVP mode

2020-09-09 Thread Hugues FRUCHET
Hi Prabhakar, I have checked quickly both OK and KO traces an some differences are ther that we have to understand, see bottom of this mail. On 9/7/20 4:35 PM, Lad, Prabhakar wrote: > Hi Hugues, > > Thank you for the review. > > On Mon, Sep 7, 2020 at 10:44 AM Hugues FRUCHET

Re: [PATCH v4 3/6] media: i2c: ov5640: Enable data pins on poweron for DVP mode

2020-09-07 Thread Hugues FRUCHET
Hi Prabhakar, Thanks for your patches, good to see one more OV5640 stakeholder upstreaming some fixes/features. I'm also using a parallel setup with OV5640 connected on STM32 DCMI camera interface. First basic tests have not shown any regressions on my side but I would like to better

Re: [PATCH 2/2] media: stm32-dcmi: fix probe error path & module remove

2020-07-28 Thread Hugues FRUCHET
Reviewed-by: Hugues Fruchet On 7/28/20 8:37 AM, Alain Volmat wrote: > This commit add missing vb2_queue_release calls with the > probe error path and module remove. > Missing v4l2_async_notifier_unregister is also added within > the probe error path > > Fixes: 37404f91ef8b (&

Re: [PATCH 1/2] media: stm32-dcmi: create video dev within notifier bound

2020-07-28 Thread Hugues FRUCHET
Reviewed-by: Hugues Fruchet On 7/28/20 8:37 AM, Alain Volmat wrote: > In case of an error during the initialization of the sensor, > the video device is still available since created at the > probe of the dcmi driver. Moreover the device wouldn't > be released even when removing the

Re: [PATCH v6 2/3] media: stm32-dcmi: Set minimum cpufreq requirement

2020-06-24 Thread Hugues FRUCHET
Hi Benjamin, test condition in set_min_frequency() to fix, appart from that: Acked-by: Hugues Fruchet BR, Hugues. On 6/10/20 2:24 PM, Benjamin Gaignard wrote: > Before start streaming set cpufreq minimum frequency requirement. > The cpufreq governor will adapt the frequencies and we wil

Re: [PATCH] media: stm32-dcmi: Set minimum cpufreq requirement

2020-06-02 Thread Hugues FRUCHET
Acked-by: Hugues Fruchet On 5/27/20 5:16 PM, Benjamin Gaignard wrote: > Before start streaming set cpufreq minimum frequency requirement. > The cpufreq governor will adapt the frequencies and we will have > no latency for handling interrupts. > > Signed-off-by: Be

Re: [PATCH] media: stm32-dcmi: Delete an unnecessary of_node_put() call in dcmi_probe()

2019-09-02 Thread Hugues FRUCHET
Acked-by: Hugues Fruchet On 8/27/19 4:09 PM, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 27 Aug 2019 16:00:13 +0200 > > A null pointer would be passed to a call of the function “of_node_put” > immediately after a call of the function “of_graph_get_next_endpoint”

Re: [PATCH v7 0/4] DCMI bridge support

2019-08-20 Thread Hugues FRUCHET
Hi Sakari, Hans, st-mipid02 changes are already merged, thanks Sakari and sorry for disturbance. Still remain the V4L2_CID_LINK_FREQ for OV5640. On 8/19/19 11:13 AM, Hugues FRUCHET wrote: > Hi Hans, Sakari, > > OK to push separately the 80 char fix. > > There was pending

Re: [PATCH v7 0/4] DCMI bridge support

2019-08-19 Thread Hugues FRUCHET
/19 10:41 AM, Hugues Fruchet wrote: >> This patch serie allows to connect non-parallel camera sensor to >> DCMI thanks to a bridge connected in between such as STMIPID02 [1]. >> >> Media controller support is introduced first, then support of >> several sub-devic

[PATCH v7 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code

2019-08-19 Thread Hugues Fruchet
Add a trace of the set of supported fourcc/mbus_code which intersect between DCMI and source sub-device. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/stm32

[PATCH v7 0/4] DCMI bridge support

2019-08-19 Thread Hugues Fruchet
/lists/arm-kernel/msg717676.html - Propagation of format set on video node to the sub-devices chain connected on camera interface version 1: - Initial submission Hugues Fruchet (4): media: stm32-dcmi: improve sensor subdev naming media: stm32-dcmi: trace the supported fourcc/mbus_code

[PATCH v7 1/4] media: stm32-dcmi: improve sensor subdev naming

2019-08-19 Thread Hugues Fruchet
Rename "subdev" entity struct field to "source" to prepare for several subdev support. Move asd field on top of entity struct. Acked-by: Sakari Ailus Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 46 +++ 1 file ch

[PATCH v7 3/4] media: stm32-dcmi: add media controller support

2019-08-19 Thread Hugues Fruchet
Add media controller support to dcmi in order to walk within remote subdevices pipeline. Signed-off-by: Hugues Fruchet --- drivers/media/platform/Kconfig| 2 +- drivers/media/platform/stm32/stm32-dcmi.c | 52 --- 2 files changed, 41 insertions(+), 13

[PATCH v7 4/4] media: stm32-dcmi: add support of several sub-devices

2019-08-19 Thread Hugues Fruchet
Add support of several sub-devices within pipeline instead of a single one. This allows to support a CSI-2 camera sensor connected through a CSI-2 to parallel bridge. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 217 +++--- 1 file changed

Re: [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code

2019-08-19 Thread Hugues FRUCHET
Hi Sakari, OK, I will change. Have you some other remarks on this serie in order that I group changes in the next version ? On 8/19/19 9:26 AM, Sakari Ailus wrote: > Hi Hugues, > > On Mon, Aug 19, 2019 at 07:23:17AM +0000, Hugues FRUCHET wrote: >> Hi Sakari, >> >>

Re: [PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code

2019-08-19 Thread Hugues FRUCHET
Hi Sakari, On 8/16/19 10:15 AM, Sakari Ailus wrote: > Hi Hugues, > > On Wed, Aug 14, 2019 at 03:48:51PM +0200, Hugues Fruchet wrote: >> Add a trace of the set of supported fourcc/mbus_code which >> intersect between DCMI and source sub-device. >> >&

Re: [PATCH v4 1/3] media: stm32-dcmi: improve sensor subdev naming

2019-08-14 Thread Hugues FRUCHET
Best regards, Hugues. On 8/9/19 6:01 PM, Sakari Ailus wrote: > Hi Hugues, > > Thanks for teh update. > > On Wed, Jul 31, 2019 at 02:56:21PM +0200, Hugues Fruchet wrote: >> Rename "subdev" entity struct field to "source" >> to prepare for several

[PATCH v6 3/4] media: stm32-dcmi: add media controller support

2019-08-14 Thread Hugues Fruchet
Add media controller support to dcmi in order to walk within remote subdevices pipeline. Signed-off-by: Hugues Fruchet --- drivers/media/platform/Kconfig| 2 +- drivers/media/platform/stm32/stm32-dcmi.c | 52 --- 2 files changed, 41 insertions(+), 13

[PATCH v6 4/4] media: stm32-dcmi: add support of several sub-devices

2019-08-14 Thread Hugues Fruchet
Add support of several sub-devices within pipeline instead of a single one. This allows to support a CSI-2 camera sensor connected through a CSI-2 to parallel bridge. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 217 +++--- 1 file changed

[PATCH v6 2/4] media: stm32-dcmi: trace the supported fourcc/mbus_code

2019-08-14 Thread Hugues Fruchet
Add a trace of the set of supported fourcc/mbus_code which intersect between DCMI and source sub-device. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/stm32

[PATCH v6 1/4] media: stm32-dcmi: improve sensor subdev naming

2019-08-14 Thread Hugues Fruchet
Rename "subdev" entity struct field to "source" to prepare for several subdev support. Move asd field on top of entity struct. Acked-by: Sakari Ailus Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 46 +++ 1 file ch

[PATCH v6 0/4] DCMI bridge support

2019-08-14 Thread Hugues Fruchet
n of format set on video node to the sub-devices chain connected on camera interface version 1: - Initial submission Hugues Fruchet (4): media: stm32-dcmi: improve sensor subdev naming media: stm32-dcmi: trace the supported fourcc/mbus_code media: stm32-dcmi: add media controller support

[PATCH v5 1/3] media: stm32-dcmi: improve sensor subdev naming

2019-08-12 Thread Hugues Fruchet
Rename "subdev" entity struct field to "source" to prepare for several subdev support. Move asd field on top of entity struct. Acked-by: Sakari Ailus Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 46 +++ 1 file ch

[PATCH v5 0/3] DCMI bridge support

2019-08-12 Thread Hugues Fruchet
on camera interface version 1: - Initial submission Hugues Fruchet (3): media: stm32-dcmi: improve sensor subdev naming media: stm32-dcmi: add media controller support media: stm32-dcmi: add support of several sub-devices drivers/media/platform/Kconfig| 2 +- drivers/media/

[PATCH v5 3/3] media: stm32-dcmi: add support of several sub-devices

2019-08-12 Thread Hugues Fruchet
Add support of several sub-devices within pipeline instead of a single one. This allows to support a CSI-2 camera sensor connected through a CSI-2 to parallel bridge. Acked-by: Sakari Ailus Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 195

[PATCH v5 2/3] media: stm32-dcmi: add media controller support

2019-08-12 Thread Hugues Fruchet
Add media controller support to dcmi in order to walk within remote subdevices pipeline. Acked-by: Sakari Ailus Signed-off-by: Hugues Fruchet --- drivers/media/platform/Kconfig| 2 +- drivers/media/platform/stm32/stm32-dcmi.c | 52 --- 2 files changed

Re: [PATCH v4 1/3] media: stm32-dcmi: improve sensor subdev naming

2019-08-12 Thread Hugues FRUCHET
Hi Sakari, Sorry for inconvenience, I will push a V5 with that fixed. May I put your "Acked-by" also on the 2 other commits ? Or just this one ? On 8/9/19 6:01 PM, Sakari Ailus wrote: > Hi Hugues, > > Thanks for teh update. > > On Wed, Jul 31, 2019 at 02:56:21PM +0

Re: [PATCH v4 0/3] DCMI bridge support

2019-08-08 Thread Hugues FRUCHET
Hi Hans, On 8/8/19 11:41 AM, Hans Verkuil wrote: > Hi Hugues, > > On 8/8/19 11:38 AM, Hugues FRUCHET wrote: >> Hi Hans, >> >> You're welcome, here it is: >> >> 1) v4l-utils master branch, commit >> 6aa15f7447d4aeca6af1ed7ee9644a0c7e891ece "v4

Re: [PATCH v4 0/3] DCMI bridge support

2019-08-08 Thread Hugues FRUCHET
Hi Hans, You're welcome, here it is: 1) v4l-utils master branch, commit 6aa15f7447d4aeca6af1ed7ee9644a0c7e891ece "v4l2-ctl: fix double decrementing of stream_count" 2) Cropping test is failed as usual because of OV5640 discrete framesizes 3) No more /dev/media* and /dev/v4l-*:

Re: [PATCH v3 3/3] media: stm32-dcmi: add support of several sub-devices

2019-07-31 Thread Hugues FRUCHET
Hi Hans, I've just pushed v4 with subdev nodes registry removal as per your suggestion. On 7/25/19 5:09 PM, Hans Verkuil wrote: > On 7/25/19 4:56 PM, Benjamin Gaignard wrote: >> Le jeu. 25 juil. 2019 à 13:40, Hans Verkuil a écrit : >>> >>> On 7/2/19 5:52 PM, Hug

[PATCH v4 1/3] media: stm32-dcmi: improve sensor subdev naming

2019-07-31 Thread Hugues Fruchet
Rename "subdev" entity struct field to "source" to prepare for several subdev support. Move asd field on top of entity struct. Signed-off-by: Hugues Fruchet Change-Id: I1545a1a29a8061ee67cc6e4b799e9a69071911e7 --- drivers/media/platform/stm32/stm32-dcmi.c | 46 ++

[PATCH v4 0/3] DCMI bridge support

2019-07-31 Thread Hugues Fruchet
media/msg153417.html version 2: - Fix bus_info not consistent between media and V4L: https://www.spinics.net/lists/arm-kernel/msg717676.html - Propagation of format set on video node to the sub-devices chain connected on camera interface version 1: - Initial submission Hugues Fruchet (3):

[PATCH v4 2/3] media: stm32-dcmi: add media controller support

2019-07-31 Thread Hugues Fruchet
Add media controller support to dcmi in order to walk within remote subdevices pipeline. Signed-off-by: Hugues Fruchet Change-Id: Id6280c58ea3c6f3d03da2027ac45df9f0e7a1da9 --- drivers/media/platform/Kconfig| 2 +- drivers/media/platform/stm32/stm32-dcmi.c | 52

[PATCH v4 3/3] media: stm32-dcmi: add support of several sub-devices

2019-07-31 Thread Hugues Fruchet
Add support of several sub-devices within pipeline instead of a single one. This allows to support a CSI-2 camera sensor connected through a CSI-2 to parallel bridge. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 195 +++--- 1 file changed

[PATCH v3 1/3] media: stm32-dcmi: improve sensor subdev naming

2019-07-02 Thread Hugues Fruchet
Rename "subdev" entity struct field to "source" to prepare for several subdev support. Move asd field on top of entity struct. Signed-off-by: Hugues Fruchet Change-Id: I1545a1a29a8061ee67cc6e4b799e9a69071911e7 --- drivers/media/platform/stm32/stm32-dcmi.c | 46 ++

[PATCH v3 3/3] media: stm32-dcmi: add support of several sub-devices

2019-07-02 Thread Hugues Fruchet
Add support of several sub-devices within pipeline instead of a single one. This allows to support a CSI-2 camera sensor connected through a CSI-2 to parallel bridge. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 204 +++--- 1 file changed

[PATCH v3 2/3] media: stm32-dcmi: add media controller support

2019-07-02 Thread Hugues Fruchet
Add media controller support to dcmi in order to walk within remote subdevices pipeline. Signed-off-by: Hugues Fruchet Change-Id: Id6280c58ea3c6f3d03da2027ac45df9f0e7a1da9 --- drivers/media/platform/Kconfig| 2 +- drivers/media/platform/stm32/stm32-dcmi.c | 52

[PATCH v3 0/3] DCMI bridge support

2019-07-02 Thread Hugues Fruchet
ernel/msg717676.html - Propagation of format set on video node to the sub-devices chain connected on camera interface version 1: - Initial submission Hugues Fruchet (3): media: stm32-dcmi: improve sensor subdev naming media: stm32-dcmi: add media controller support media: stm32-dcmi: add su

Re: [PATCH v2 2/3] media: stm32-dcmi: add media controller support

2019-07-02 Thread Hugues FRUCHET
Hi Sakari, On 6/20/19 6:13 PM, Sakari Ailus wrote: > Hi Hugues, > > On Tue, Jun 11, 2019 at 10:48:31AM +0200, Hugues Fruchet wrote: >> Add media controller support to dcmi. >> >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/platform/Kconfi

Re: [PATCH v2 3/3] media: stm32-dcmi: add support of several sub-devices

2019-07-02 Thread Hugues FRUCHET
Hi Sakari, On 6/20/19 5:54 PM, Sakari Ailus wrote: > Hi Hugues, > > Thank you for the update. > > On Tue, Jun 11, 2019 at 10:48:32AM +0200, Hugues Fruchet wrote: >> Add support of several sub-devices within pipeline instead >> of a single one. >> This allows

Re: [PATCH v2 1/3] media: stm32-dcmi: improve sensor subdev naming

2019-07-02 Thread Hugues FRUCHET
Hi Sakari, On 6/20/19 5:26 PM, Sakari Ailus wrote: > Hi Hugues, > > On Tue, Jun 11, 2019 at 10:48:30AM +0200, Hugues Fruchet wrote: >> Add a new "sensor" field to dcmi struct instead of >> reusing entity->subdev to address sensor subdev. As discussed on

Re: [PATCH v2 2/3] media: stm32-dcmi: add media controller support

2019-07-02 Thread Hugues FRUCHET
Hi Hans, On 6/20/19 2:01 PM, Hans Verkuil wrote: > On 6/11/19 10:48 AM, Hugues Fruchet wrote: >> Add media controller support to dcmi. >> >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/platform/Kconfig| 2 +- >> drivers

Re: [PATCH v2 0/3] DCMI bridge support

2019-06-27 Thread Hugues FRUCHET
Hi Laurent, Thanks for reviewing, On 6/26/19 7:25 PM, Laurent Pinchart wrote: > Hi Hugues, > > On Mon, Jun 24, 2019 at 10:10:05AM +0000, Hugues FRUCHET wrote: >> Hi Sakari, >> >> > - Where's the sub-device representing the bridge itself? >> This is pointed

Re: [PATCH v2 0/3] DCMI bridge support

2019-06-24 Thread Hugues FRUCHET
es. Having all that in mind, what should be reconsidered in your opinion Sakari ? Do you have some alternatives ? Best regards, Hugues. On 6/20/19 6:17 PM, Sakari Ailus wrote: > Hi Hugues, > > On Tue, Jun 11, 2019 at 10:48:29AM +0200, Hugues Fruchet wrote: >> This patch serie

[PATCH v2 3/3] media: st-mipid02: add support of JPEG

2019-06-17 Thread Hugues Fruchet
Add support of JPEG pixel format. This requires auto detection of data type from CSI-2 stream. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/st-mipid02.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media

[PATCH] media: st-mipid02: add support of V4L2_CID_LINK_FREQ

2019-06-17 Thread Hugues Fruchet
pixel rate is not possible. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/st-mipid02.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index 9369f38..8623f30 100644

[PATCH v2 0/3] Add support of RGB565, YUV and JPEG to MIPID02 bridge

2019-06-17 Thread Hugues Fruchet
Add support of RGB565, YUV and JPEG to MIPID02 bridge. === = history = === version 2: - Link frequency could not be computed from pixel rate for JPEG, remove JPEG case in bpp_from_code(). version 1: - Initial submission Hugues Fruchet (3): media: st-mipid02: add

[PATCH v2 2/3] media: st-mipid02: add support of YUYV8 and UYVY8

2019-06-17 Thread Hugues Fruchet
Add support of YUYV8 and UYVY8 pixel formats. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/st-mipid02.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index 76a9f52..35946ad 100644 --- a/drivers/media/i2c/st

[PATCH v2 1/3] media: st-mipid02: add support of RGB565

2019-06-17 Thread Hugues Fruchet
Add support of RGB565 pixel format. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/st-mipid02.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index 9369f38..76a9f52 100644 --- a/drivers/media/i2c

[PATCH 3/3] media: st-mipid02: add support of JPEG

2019-06-11 Thread Hugues Fruchet
Add support of JPEG pixel format. This requires auto detection of data type from CSI-2 stream. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/st-mipid02.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media

[PATCH 1/3] media: st-mipid02: add support of RGB565

2019-06-11 Thread Hugues Fruchet
Add support of RGB565 pixel format. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/st-mipid02.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index 9369f38..76a9f52 100644 --- a/drivers/media/i2c

[PATCH 2/3] media: st-mipid02: add support of YUYV8 and UYVY8

2019-06-11 Thread Hugues Fruchet
Add support of YUYV8 and UYVY8 pixel formats. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/st-mipid02.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index 76a9f52..35946ad 100644 --- a/drivers/media/i2c/st

[PATCH 0/3] Add support of RGB565, YUV and JPEG to MIPID02 bridge

2019-06-11 Thread Hugues Fruchet
Add support of RGB565, YUV and JPEG to MIPID02 bridge. Hugues Fruchet (3): media: st-mipid02: add support of RGB565 media: st-mipid02: add support of YUYV8 and UYVY8 media: st-mipid02: add support of JPEG drivers/media/i2c/st-mipid02.c | 32 ++-- 1 file changed

[PATCH v2 0/3] DCMI bridge support

2019-06-11 Thread Hugues Fruchet
media and V4L: https://www.spinics.net/lists/arm-kernel/msg717676.html - Propagation of format set on video node to the sub-devices chain connected on camera interface version 1: - Initial submission Hugues Fruchet (3): media: stm32-dcmi: improve sensor subdev naming media: stm32-dcmi

[PATCH v2 3/3] media: stm32-dcmi: add support of several sub-devices

2019-06-11 Thread Hugues Fruchet
Add support of several sub-devices within pipeline instead of a single one. This allows to support a CSI-2 camera sensor connected through a CSI-2 to parallel bridge. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 207 +++--- 1 file changed

[PATCH v2 2/3] media: stm32-dcmi: add media controller support

2019-06-11 Thread Hugues Fruchet
Add media controller support to dcmi. Signed-off-by: Hugues Fruchet --- drivers/media/platform/Kconfig| 2 +- drivers/media/platform/stm32/stm32-dcmi.c | 83 +++ 2 files changed, 63 insertions(+), 22 deletions(-) diff --git a/drivers/media/platform

[PATCH v2 1/3] media: stm32-dcmi: improve sensor subdev naming

2019-06-11 Thread Hugues Fruchet
Add a new "sensor" field to dcmi struct instead of reusing entity->subdev to address sensor subdev. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 37 --- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/

Re: [PATCH 10/17] delta: Fix buffer overrun in delta_ipc_open

2019-04-02 Thread Hugues FRUCHET
Hi Andi, So do both, memset then strscpy: + memset(msg.name, 0, sizeof(msg.name)); + if (strscpy(msg.name, name, sizeof(msg.name)) <= 0) + goto err; BR, Hugues. On 4/1/19 6:54 PM, Andi Kleen wrote: > On Mon, Apr 01, 2019 at 01:37:56PM +, Hugues FRUCHET wrote: >

Re: [PATCH 10/17] delta: Fix buffer overrun in delta_ipc_open

2019-04-01 Thread Hugues FRUCHET
Hi Andi, We have already discussed about that here: https://lore.kernel.org/patchwork/patch/866406/ Now that strscpy is largely deployed within kernel, could you retest with the change I suggested ? Best regards, Hugues. On 3/21/19 11:00 PM, Andi Kleen wrote: > From: Andi Kleen > >

[PATCH 0/2] Refine DCMI error messages

2019-04-01 Thread Hugues Fruchet
Cleanup and refine some DCMI error messages. Hugues Fruchet (2): media: stm32-dcmi: fix error messages media: stm32-dcmi: do not emit error trace in case of few overrun drivers/media/platform/stm32/stm32-dcmi.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions

[PATCH 2/2] media: stm32-dcmi: do not emit error trace in case of few overrun

2019-04-01 Thread Hugues Fruchet
Report overrun error only when it exceeds a given threshold. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32

Re: [PATCH] media: uvcvideo: Read support

2019-03-05 Thread Hugues FRUCHET
Hi Kieran, Laurent, On 3/4/19 4:44 PM, Laurent Pinchart wrote: > Hello, > > On Mon, Mar 04, 2019 at 03:36:32PM +, Kieran Bingham wrote: >> On 04/03/2019 12:35, Hugues Fruchet wrote: >>> Add support of read() call from userspace by implementing >>> uvc_v

[PATCH] media: uvcvideo: Read support

2019-03-04 Thread Hugues Fruchet
Add support of read() call from userspace by implementing uvc_v4l2_read() with vb2_read() helper. Signed-off-by: Hugues Fruchet --- drivers/media/usb/uvc/uvc_queue.c | 15 ++- drivers/media/usb/uvc/uvc_v4l2.c | 11 --- drivers/media/usb/uvc/uvcvideo.h | 2 ++ 3 files

[PATCH] Support of /dev/video read with USB camera devices

2019-03-04 Thread Hugues Fruchet
297390/read-function-for-webcam-device-in-v4l2-fails-with-invalid-argument https://stackoverflow.com/questions/31058571/reading-camera-input-from-dev-video0-in-python-or-c [2] https://www.mail-archive.com/linux-uvc-devel@lists.berlios.de/msg01258.html Hugues Fruchet (1): media: uvcvideo: Read s

[PATCH] media: stm32-dcmi: fix DMA corruption when stopping streaming

2019-02-28 Thread Hugues Fruchet
Avoid call of dmaengine_terminate_all() between dmaengine_prep_slave_single() and dmaengine_submit() by locking the whole DMA submission sequence. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH] media: stm32-dcmi: fix check of pm_runtime_get_sync return value

2019-02-28 Thread Hugues Fruchet
Start streaming was sometimes failing because of pm_runtime_get_sync() non-0 return value. In fact return value was not an error but a positive value (1), indicating that PM was already enabled. Fix this by going to error path only with negative return value. Signed-off-by: Hugues Fruchet

[PATCH 2/4] ARM: dts: stm32: add DCMI camera interface support on stm32mp157c

2019-02-28 Thread Hugues Fruchet
Add DCMI camera interface support on stm32mp157c. Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stm32mp157c.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index 10bf338..1ff331c 100644

[PATCH 3/4] ARM: dts: stm32: add DCMI pins to stm32mp157c

2019-02-28 Thread Hugues Fruchet
Add DCMI pins to stm32mp157c. Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 41 +++ 1 file changed, 41 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi index 6b3a9c6

[PATCH 1/4] ARM: dts: stm32: add 2v8 fixed regulator for stm32mp157c-ed1 board

2019-02-28 Thread Hugues Fruchet
Add 2v8 fixed regulator and enable it. Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot/dts/stm32mp157c-ed1.dts index 10dc7c0..4b5bcfd 100644 --- a/arch/arm

[PATCH 0/4] Enable stm32mp1 camera support

2019-02-28 Thread Hugues Fruchet
to be selected at kernel configuration time. This patchset depends on STMicroelectronics Multi-Function eXpander (STMFX) support [1]. [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1944108.html Hugues Fruchet (4): ARM: dts: stm32: add 2v8 fixed regulator for stm32mp157c-ed1 board ARM

[PATCH 4/4] ARM: dts: stm32: enable OV5640 camera on stm32mp157c-ev1 board

2019-02-28 Thread Hugues Fruchet
active low and pclk-sample is set to 1 for pixel clock polarity sampling data on rising edge of the pixel clock signal. Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stm32mp157c-ev1.dts | 56 +++ 1 file changed, 56 insertions(+) diff --git a/arch/arm/boot

Re: [PATCH 1/2] media: stm32-dcmi: drop unnecessary while(1) loop

2018-06-18 Thread Hugues FRUCHET
Hi Nicholas, thanks for patch ! On 06/12/2018 07:22 PM, Nicholas Mc Guire wrote: > The while(1) is effectively useless as all possible paths within it > return thus there is no way to loop. > > Signed-off-by: Nicholas Mc Guire Acked-by: Hugues Fruchet > --- > > This i

Re: [PATCH 1/2] media: stm32-dcmi: drop unnecessary while(1) loop

2018-06-18 Thread Hugues FRUCHET
Hi Nicholas, thanks for patch ! On 06/12/2018 07:22 PM, Nicholas Mc Guire wrote: > The while(1) is effectively useless as all possible paths within it > return thus there is no way to loop. > > Signed-off-by: Nicholas Mc Guire Acked-by: Hugues Fruchet > --- > > This i

[PATCH] media: stm32-dcmi: revisit stop streaming ops

2018-06-11 Thread Hugues Fruchet
Do not wait for interrupt completion when stopping streaming, stopping sensor and disabling interruptions are enough. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 29 + 1 file changed, 1 insertion(+), 28 deletions(-) diff --git

[PATCH] media: stm32-dcmi: revisit stop streaming ops

2018-06-11 Thread Hugues Fruchet
Do not wait for interrupt completion when stopping streaming, stopping sensor and disabling interruptions are enough. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 29 + 1 file changed, 1 insertion(+), 28 deletions(-) diff --git

  1   2   3   4   >