Re: [PATCH] net: myricom: myri10ge: use new api ethtool_{get|set}_link_ksettings

2017-02-09 Thread Hyong-Youb Kim
using a 2-port NIC. Works fine. Acked-by: Hyong-Youb Kim > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 23 + > 1 files changed, 10 insertions(+), 13 deletions(-) > > diff --git a/drivers/net/etherne

Re: [PATCH v3] ethernet: myri10ge: use arch_phys_wc_add()

2015-04-23 Thread Hyong-Youb Kim
On Thu, Apr 23, 2015 at 02:28:40PM -0400, David Miller wrote: > I can't wait forever for the driver maintainers to review this, so > I'm applying it. FWIW, I replied to Luis's patch yesterday. It appears on the netdev list and patchwork. Checked the recipient list, and it includes netdev, but no

Re: [PATCH v3] ethernet: myri10ge: use arch_phys_wc_add()

2015-04-22 Thread Hyong-Youb Kim
On Tue, Apr 21, 2015 at 01:09:45PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already uses ioremap_wc() on the same range > so when write-combining is available that will be used > instead. [...] > Signed-off-by: Luis R. Rodriguez Tested using the patched v4.0.

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-17 Thread Hyong-Youb Kim
On Thu, Apr 16, 2015 at 08:54:26PM +0200, Luis R. Rodriguez wrote: > > Without WC, descriptors would end up as multiple 4B or 8B MWr packets > > to the NIC, which has a pretty big performance impact on this > > particular NIC. > > How big are the descriptors? Some are 64B (a batch of eight 8B des

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Hyong-Youb Kim
On Thu, Apr 16, 2015 at 01:58:16AM +0200, Luis R. Rodriguez wrote: > > An alternative... is to just ioremap_wc() the entire region, including > MMIO registers for these old devices. I see one ethernet driver that does > this, myri10ge, and am curious how and why they ended up deciding this > and i

Re: [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add()

2015-03-21 Thread Hyong-Youb Kim
On Fri, Mar 20, 2015 at 04:18:11PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already uses ioremap_wc() on the same range > so when write-combining is available that will be used > instead. > [...] > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > +++ b/

Re: [PATCH 20/34] myri10ge: Use pci_enable_msix_range()

2014-02-01 Thread Hyong-Youb Kim
On 2/1/2014 4:24 AM, Sergei Shtylyov wrote: Hello. On 01/31/2014 06:08 PM, Alexander Gordeev wrote: [...] +if (status < 0) +goto disable_msix; Hm, if enabling MSI failed, we don't need to disable it, right? So, perhaps the label should be renamed? The code follow