Re: [PATCH] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-08 Thread Ian Campbell
On Thu, 2018-03-08 at 13:40 -0800, Kees Cook wrote: > > +#define __min(t1, t2, x, y) \ > + __builtin_choose_expr(__builtin_constant_p(x) &&\ > + __builtin_constant_p(y) &&\ > +

Re: [kernel-hardening] Re: [PATCH v3 2/2] Protected O_CREAT open in sticky directories

2017-11-30 Thread Ian Campbell
On Thu, 2017-11-30 at 15:39 +0100, Salvatore Mesoraca wrote: > 2017-11-27 1:26 GMT+01:00 Solar Designer : > > On Fri, Nov 24, 2017 at 12:43:47PM +0100, Salvatore Mesoraca wrote: > > > 2017-11-24 11:53 GMT+01:00 David Laight > > > : > > > > From: Alan

Re: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options

2017-10-04 Thread Ian Campbell
On Sun, 2017-10-01 at 11:06 +1100, Tobin C. Harding wrote: > Suggestion by Ian Campbell to add comments on the threat model being mitigated > by use of %pa vs %paP etc is not implemented because I do not know the threat > model (I'm only the janitor). Happy to add them if someone wr

Re: [PATCH] powerpc/44x/fsp2: correct dtb reg property for /sdhci@020c0000

2017-07-21 Thread Ian Campbell
On Fri, 2017-07-21 at 15:54 +0300, Ivan Mikhaylov wrote: > Hi Ian, > > Building the split device-tree tree[0] highlighted that upstream commit > > 9eec6cb142bd ("powerpc/44x/fsp2: Add device tree for FSP2 board") introduced > > this warning when building the device tree: > > > > $ make

[PATCH] powerpc/44x/fsp2: correct dtb reg property for /sdhci@020c0000

2017-07-15 Thread Ian Campbell
te: I have no access to or information about this platform so this is purely a guess as to the fix. An alternative would be to adjust #address-cells, but whether that is correct or not depends on the platform. [0] https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-

Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include

2017-05-16 Thread Ian Campbell
On Sat, 2017-05-13 at 17:43 +0200, Heiko Stuebner wrote: > Hi Ian, > > Am Samstag, 13. Mai 2017, 00:53:57 CEST schrieb Ian Campbell: > > It not necessary and counter to how all the other files are done. > > > > It also happens to break the build in the split

[PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include

2017-05-12 Thread Ian Campbell
It not necessary and counter to how all the other files are done. It also happens to break the build in the split device tree repo https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell <i...@hellion.org.uk> Cc: Brian Norris <

Re: [kernel-hardening] [RFC 3/6] lib: vsprintf: physical address kernel pointer filtering options

2017-05-06 Thread Ian Campbell
On Fri, 2017-05-05 at 21:07 -0700, Greg KH wrote: > From: Dave Weinstein > > Add the kptr_restrict setting of 4 which results in %pa and > %p[rR] values being replaced by zeros. Given that '%pa' is:  * - 'a[pd]' For address types [p] phys_addr_t, [d] dma_addr_t and

Re: [kernel-hardening] [PATCH v2 1/7] bug: Clarify help text for BUG_ON_DATA_CORRUPTION

2017-04-04 Thread Ian Campbell
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 77fadface4f9..5ac4d1148385 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1998,9 +1998,12 @@ config BUG_ON_DATA_CORRUPTION > >   bool "Trigger a BUG when data corruption is detected" > >   select DEBUG_LIST > >  

Re: [kernel-hardening] [RFC v2][PATCH 02/11] lkdtm: add test for rare_write() infrastructure

2017-03-30 Thread Ian Campbell
On Wed, 2017-03-29 at 11:15 -0700, Kees Cook wrote: > diff --git a/drivers/misc/lkdtm_perms.c b/drivers/misc/lkdtm_perms.c > index c7635a79341f..8fbadfa4cc34 100644 > --- a/drivers/misc/lkdtm_perms.c > +++ b/drivers/misc/lkdtm_perms.c > [...] > +/* This is marked __wr_rare, so it should ultimately

"sched/cpuacct: Show all possible CPUs in cpuacct output" broke Docker CPU usage accounting

2017-02-15 Thread Ian Campbell
Hello, It seems that the changes to cpuacct.usage(_percpu) in 5ca3726af7f6 ("sched/cpuacct: Show all possible CPUs in cpuacct output") have broken CPU usage accounting in Docker (https://github.com/docker/docker/issues/28941). The issue is the code at

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-12 Thread Ian Campbell
On Sat, 2016-12-10 at 13:41 +0100, Greg Kroah-Hartman wrote: > Now I don't work on a distro anymore, but I would think that something > like this would be really useful, pointing out exactly what changed is > very important for distro maintainers to determine what they want to do The .symvers

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-09 Thread Ian Campbell
On Fri, 2016-12-09 at 13:33 +1000, Nicholas Piggin wrote: >  > Well I simply tested the outcome. If you have: > > struct blah { >   int x; > }; > int foo(struct blah *blah) > { >   return blah->x; > } > EXPORT(foo); > > $ nm vmlinux | grep __crc_foo > a0cf13a0 A __crc_foo > > Now change

Re: [PATCH v2 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-09-09 Thread Ian Campbell
On Fri, 2016-09-09 at 17:47 +0200, Arnd Bergmann wrote: > On Friday, September 9, 2016 3:45:56 PM CEST Ian Campbell wrote: > > > > On Tue, 2016-08-23 at 12:09 +0200, Arnd Bergmann wrote: > > > > > > I had skipped the new message as well while sorting through 5000

Re: [PATCH v2 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-09-09 Thread Ian Campbell
On Tue, 2016-08-23 at 12:09 +0200, Arnd Bergmann wrote: > I had skipped the new message as well while sorting through 5000 > messages after my vacation, but I've now put it into my TODO folder > and will get to it eventually. Is it still on your TODO or should I do... > We sometimes miss stuff

Re: [PATCH v3 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-08-19 Thread Ian Campbell
On Thu, 2016-08-18 at 10:59 -0700, Eric Anholt wrote: > I'd lost track of these patches, sorry.  Both are: > > Acked-by: Eric Anholt Thanks! > They're going through the -soc tree, right? I think so. Ian.

[PATCH v3 2/2] ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm

2016-08-18 Thread Ian Campbell
: vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") use symlinks instead. [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell <i...@hellion.org.uk> Acked-by: Mark Rutland <mark.rutl...@arm.com> Cc: Catalin Mari

[PATCH v3 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-08-18 Thread Ian Campbell
reordering of the nodes in the DTBs (the /aliases and /memory nodes come later). This isn't supposed to matter but, again, I've no hardware to check if it is true in this particular case. Signed-off-by: Ian Campbell <i...@hellion.org.uk> Acked-by: Mark Rutland <mark.rutl...@arm.com> Te

Re: [PATCH v2 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-08-18 Thread Ian Campbell
On Tue, 2016-08-09 at 11:48 +0100, Ian Campbell wrote: > On Wed, 2016-08-03 at 15:48 +0100, Mark Rutland wrote: > >  > > > [...]Signed-off-by: Ian Campbell <i...@hellion.org.uk> > >  > > I also don't have the relevant hardware to test with, but this > looks

Re: [PATCH v2 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-08-09 Thread Ian Campbell
On Wed, 2016-08-03 at 15:48 +0100, Mark Rutland wrote: > > > [...]Signed-off-by: Ian Campbell <i...@hellion.org.uk> > > I also don't have the relevant hardware to test with, but this looks > generally like the right thing. So FWIW: > > Acked-by: Mark Rutland

Re: [PATCH] ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm

2016-08-03 Thread Ian Campbell
On Wed, 2016-08-03 at 14:30 +0100, Mark Rutland wrote: > On Wed, Aug 03, 2016 at 08:13:51AM -0500, Rob Herring wrote: > > > > > > On Wed, Aug 3, 2016 at 3:40 AM, Ian Campbell <i...@hellion.org.uk> > > > > wrote: > > > > > > These inclu

[PATCH v2 2/2] ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm

2016-08-03 Thread Ian Campbell
: vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") use symlinks instead. [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell <i...@hellion.org.uk> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc: Will Deaco

[PATCH v2 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-08-03 Thread Ian Campbell
reordering of the nodes in the DTBs (the /aliases and /memory nodes come later). This isn't supposed to matter but, again, I've no hardware to check if it is true in this particular case. Signed-off-by: Ian Campbell <i...@hellion.org.uk> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc:

[PATCH] ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm

2016-08-03 Thread Ian Campbell
evicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell <i...@hellion.org.uk> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc: Will Deacon <will.dea...@arm.com> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Rob Herring <robh...@kernel.org> Cc: Frank Rowand <frowand

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

2016-01-22 Thread Ian Campbell
On Fri, 2016-01-22 at 13:49 +, Wei Liu wrote: > On Fri, Jan 22, 2016 at 01:14:24PM +, David Vrabel wrote: > > On 22/01/16 12:34, Wei Liu wrote: > > > The comment at the beginning of the file is the canonical source of > > > licenses for this module. Currently it contains GPL and MIT

Re: [Xen-devel] crash tool - problem with new Xen linear virtual mapped sparse p2m list

2015-11-24 Thread Ian Campbell
On Tue, 2015-11-24 at 10:35 +, Andrew Cooper wrote: > On 24/11/15 10:17, Petr Tesarik wrote: > > On Tue, 24 Nov 2015 10:09:01 + > > David Vrabel wrote: > > > > > On 24/11/15 09:55, Malcolm Crossley wrote: > > > > On 24/11/15 08:59, Jan Beulich wrote: > > > > > >

Re: [Xen-devel] [PATCH v4 2/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64

2015-11-20 Thread Ian Campbell
On Fri, 2015-11-20 at 11:58 +, Stefano Stabellini wrote: > On Mon, 16 Nov 2015, Ian Campbell wrote: > > On Fri, 2015-11-13 at 18:10 +, Stefano Stabellini wrote: > > > > > > I agree with your point (I thought about it myself) but the current > > > as

Re: [Xen-devel] [PATCH v4 2/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64

2015-11-16 Thread Ian Campbell
On Fri, 2015-11-13 at 18:10 +, Stefano Stabellini wrote: > > I agree with your point (I thought about it myself) but the current > assembly scheme for hypercalls doesn't work well with that. I would have > to introduce, and maintain going forward, two special hypercall > implementations in

Re: [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread Ian Campbell
On Thu, 2015-10-15 at 12:26 -0400, Insu Yun wrote: > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun > --- > drivers/net/xen-netback/xenbus.c | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH] ARM64: dts: vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm

2015-10-12 Thread Ian Campbell
On Mon, 2015-10-05 at 12:53 +0100, Ian Campbell wrote: Ping? > Commit 9ccd608070b6 "arm64: dts: add device tree for ARM SMM-A53x2 on > LogicTile Express 20MG" added a new dts file to arch/arm64 which > included "../../../../arm/boot/dts/vexpress-v2m-rs1.dtsi", i.e. a

Re: [PATCH v4 00/20] xen/arm64: Add support for 64KB page in Linux

2015-10-06 Thread Ian Campbell
On Tue, 2015-10-06 at 11:28 +0200, Roger Pau Monné wrote: > El 22/09/15 a les 12.59, Ian Campbell ha escrit: > > On Mon, 2015-09-14 at 17:23 +0200, Roger Pau Monné wrote: > > > I'm not saying that we shouldn't take those patches, I'm just saying > > > that IMHO this i

[PATCH] ARM64: dts: vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm

2015-10-05 Thread Ian Campbell
tps://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Cc: Rob Herring <robh...@kernel.org> Cc: Pawel Moll <pawel.m...@arm.com> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Kumar Gala <

Re: [PATCH v4 00/20] xen/arm64: Add support for 64KB page in Linux

2015-09-22 Thread Ian Campbell
On Mon, 2015-09-14 at 17:23 +0200, Roger Pau Monné wrote: > I'm not saying that we shouldn't take those patches, I'm just saying > that IMHO this is a workaround, and I would like to see a plan and > somebody committed to have it fixed in a proper way, by introducing a > 64KB PV block protocol.

Re: [PATCH v5] dtb: Create a common home for cross-architecture dtsi files.

2015-09-17 Thread Ian Campbell
Hi Olof, On Mon, 2015-08-24 at 15:22 -0700, Olof Johansson wrote: A little while ago you were trying to explain the scheme you would like to see on IRC but my thick skull was getting in the way :-/ Then you had to run... So, ping? Ian. -- To unsubscribe from this list: send the line

Re: [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters

2015-09-11 Thread Ian Campbell
On Thu, 2015-09-10 at 17:10 +0100, Stefano Stabellini wrote: > > C) When you could go: > > > >DT -> Discover Xen -> Xen-specific stuff -> Xen-specific EFI/ACPI > > discovery > > I take you mean discovering Xen with the usual Xen hypervisor node on > device tree. There may be other options,

Re: [PATCH v4 3/4] irqchip: GIC: Convert to EOImode == 1

2015-09-11 Thread Ian Campbell
On Thu, 2015-09-10 at 17:23 +0100, Julien Grall wrote: > I applied the two patches on top of linus/master and I'm able to boot > correctly on X-gene. Thank you! Perhaps we should replicate this approach in Xen and get rid of PLATFORM_QUIRK_GIC_64K_STRIDE? Ian. -- To unsubscribe from this list:

Re: [PATCH] arm/xen: Enable user access to the kernel before issuing a privcmd call

2015-09-11 Thread Ian Campbell
On Fri, 2015-09-11 at 15:16 +0100, Julien Grall wrote: > When Xen is copyin data to/from the guest it will check if the kernel "copying" > has the right to do the access. If not, the hypercall will return an > error. > > After the commit a5e090acbf545c0a3b04080f8a488b17ec41fe02 "ARM: >

Re: [PATCH] arm/xen: Enable user access to the kernel before issuing a privcmd call

2015-09-11 Thread Ian Campbell
On Fri, 2015-09-11 at 15:45 +0100, Julien Grall wrote: > On 11/09/15 15:29, Ian Campbell wrote: > > On Fri, 2015-09-11 at 15:16 +0100, Julien Grall wrote: > > > When Xen is copyin data to/from the guest it will check if the kernel > > > > "copying" &

Re: [Xen-devel] [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters

2015-09-10 Thread Ian Campbell
On Thu, 2015-09-10 at 13:15 +0100, Mark Rutland wrote: > > In any case this should be separate from the shim ABI discussion. > > I disagree; I think this is very much relevant to the ABI discussion. > That's not to say that I insist on a particular approach, but I think > that they need to be

Re: [Xen-devel] [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters

2015-09-10 Thread Ian Campbell
On Thu, 2015-09-10 at 07:08 -0600, Jan Beulich wrote: > > > > On 10.09.15 at 14:58, wrote: > > On Thu, 2015-09-10 at 13:15 +0100, Mark Rutland wrote: > > > > > > In any case this should be separate from the shim ABI discussion. > > > > > > I disagree; I think this is

Re: [PATCH v5] dtb: Create a common home for cross-architecture dtsi files.

2015-09-01 Thread Ian Campbell
On Mon, 2015-08-24 at 15:22 -0700, Olof Johansson wrote: > Hi, > > On Mon, Aug 24, 2015 at 1:58 PM, Rob Herring > wrote: > > On Sun, Aug 23, 2015 at 6:52 PM, Olof Johansson wrote: > > > On Sun, Aug 23, 2015 at 4:42 PM, Rob Herring

Re: [PATCH v5] dtb: Create a common home for cross-architecture dtsi files.

2015-08-16 Thread Ian Campbell
On Fri, 2015-08-14 at 16:21 -0500, Rob Herring wrote: +arm-soc I could've sworn I did the same at one point. Obviously not. On Tue, Aug 11, 2015 at 5:07 AM, Ian Campbell ian.campb...@citrix.com wrote: On Mon, 2015-08-03 at 17:06 +0100, Ian Campbell wrote: Commit 9ccd608070b6 (arm64

Re: [PATCH v5] dtb: Create a common home for cross-architecture dtsi files.

2015-08-11 Thread Ian Campbell
On Mon, 2015-08-03 at 17:06 +0100, Ian Campbell wrote: Commit 9ccd608070b6 (arm64: dts: add device tree for ARM SMM-A53x2 on LogicTile Express 20MG) added a new dts file to arch/arm64 which included ../../../../arm/boot/dts/vexpress-v2m-rs1.dtsi, i.e. a .dtsi supplied by arch/arm

Re: [PATCH v4] dtb: Create a common home for cross-architecture dtsi files.

2015-08-11 Thread Ian Campbell
On Tue, 2015-08-11 at 13:00 +0900, Masahiro Yamada wrote: Hi 2015-08-04 1:06 GMT+09:00 Ian Campbell ian.campb...@citrix.com: Commit 9ccd608070b6 (arm64: dts: add device tree for ARM SMM-A53x2 on LogicTile Express 20MG) added a new dts file to arch/arm64 which included ../../../../arm

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-06 Thread Ian Campbell
On Tue, 2015-08-04 at 18:12 +0100, David Vrabel wrote: On 04/08/15 17:41, Jason A. Donenfeld wrote: Hi folks, Paul McKenney and I had an offline discussion about some rcu questions that eventually lead into me investigating a strange full lock-up I'm experiencing as a consequence of a

[PATCH net] net: thunderx: remove effective default y from Kconfig if ARCH_THUNDER=y

2015-08-04 Thread Ian Campbell
if ARCH_THUNDER. Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Sunil Goutham sgout...@cavium.com Cc: Robert Richter r...@kernel.org Cc: Derek Chickles derek.chick...@caviumnetworks.com Cc: Satanand Burla satananda.bu...@caviumnetworks.com Cc: Felix Manlunas felix.manlu...@caviumnetworks.com Cc: Raghu

Re: [PATCH v4] dtb: Create a common home for cross-architecture dtsi files.

2015-08-03 Thread Ian Campbell
On Mon, 2015-08-03 at 10:55 -0500, Rob Herring wrote: On Mon, Aug 3, 2015 at 3:55 AM, Ian Campbell ian.campb...@citrix.com wrote: Commit 9ccd608070b6 (arm64: dts: add device tree for ARM SMM-A53x2 on LogicTile Express 20MG) added a new dts file to arch/arm64 which included ../../../../arm

[PATCH v4] dtb: Create a common home for cross-architecture dtsi files.

2015-08-03 Thread Ian Campbell
in this case arm (the vendor, not the ARCH=). [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Kumar

[PATCH v5] dtb: Create a common home for cross-architecture dtsi files.

2015-08-03 Thread Ian Campbell
in this case arm (the vendor, not the ARCH=). [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Kumar

[PATCH v4] dtb: Create a common home for cross-architecture dtsi files.

2015-08-03 Thread Ian Campbell
#include instead of /include/. The dtsi file itself is moved into a vendor subdir in this case arm (the vendor, not the ARCH=). [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring robh...@kernel.org

Re: [PATCH v3] dtb: Create a common home for cross-architecture dtsi files.

2015-08-03 Thread Ian Campbell
On Sat, 2015-08-01 at 15:43 +0900, Masahiro Yamada wrote: 2015-08-01 15:21 GMT+09:00 Masahiro Yamada yamada.masah...@socionext.com : 2015-07-31 23:31 GMT+09:00 Ian Campbell ian.campb...@citrix.com: Commit 9ccd608070b6 arm64: dts: add device tree for ARM SMM-A53x2 on LogicTile Express

[PATCH v2] regulator: axp20x: Add module alias

2015-08-01 Thread Ian Campbell
This allows the module to be autoloaded. Together with 07949bf9c63c (cpufreq: dt: allow driver to boot automatically) this is sufficient to allow a modular kernel (such as Debian's) to enable cpufreq on a Cubietruck. Signed-off-by: Ian Campbell i...@hellion.org.uk Cc: Liam Girdwood lgirdw

[PATCH v3] dtb: Create a common home for cross-architecture dtsi files.

2015-07-31 Thread Ian Campbell
#include instead of /include/. The dtsi file itself is moved into a vendor subdir in this case arm (the vendor, not the ARCH=). [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring robh

Re: [PATCH 1/8] arm/xen: Remove helpers which are PV specific

2015-07-31 Thread Ian Campbell
On Fri, 2015-07-31 at 11:44 +0100, Stefano Stabellini wrote: On Tue, 28 Jul 2015, Julien Grall wrote: ARM guests are assimilated to HVM guest on ARM. The current implementation is assuming a 1:1 mapping which is only true for DOM0 and may not be at all in the future. Furthermore,

Re: [PATCH v2] dtb: Create a common home for cross-architecture dtsi files.

2015-07-29 Thread Ian Campbell
On Wed, 2015-07-29 at 20:07 +0900, Masahiro Yamada wrote: Hi Ian, 2015-07-27 19:35 GMT+09:00 Ian Campbell ian.campb...@citrix.com: Commit 9ccd608070b6 arm64: dts: add device tree for ARM SMM-A53x2 on LogicTile Express 20MG added a new dts file to arch/arm64 which included

Re: [PATCH v2] dtb: Create a common home for cross-architecture dtsi files.

2015-07-29 Thread Ian Campbell
On Wed, 2015-07-29 at 14:27 +0100, Mark Rutland wrote: On Wed, Jul 29, 2015 at 02:22:54PM +0100, Ian Campbell wrote: On Wed, 2015-07-29 at 20:07 +0900, Masahiro Yamada wrote: Hi Ian, 2015-07-27 19:35 GMT+09:00 Ian Campbell ian.campb...@citrix.com: Commit 9ccd608070b6 arm64

[PATCH v2] dtb: Create a common home for cross-architecture dtsi files.

2015-07-27 Thread Ian Campbell
#include instead of /include/. The dtsi file itself is moved into a vendor subdir in this case arm (the vendor, not the ARCH=). [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring robh

Re: [Xen-devel] [PATCH v2 01/20] xen: Add Xen specific page definition

2015-07-24 Thread Ian Campbell
On Fri, 2015-07-24 at 11:34 +0100, David Vrabel wrote: it would be better to think that: PFNs index guest-sized pages (which may be 64 KiB). GFNs index Xen-sized pages (which is always 4 KiB). This concept could be usefully added to the comment in xen/include/xen/mm.h IMHO. David --

Re: [PATCH] dtb: Create a common home for cross-architecture dtsi files.

2015-07-24 Thread Ian Campbell
On Fri, 2015-07-24 at 12:31 +0100, Mark Rutland wrote: On Wed, Jul 22, 2015 at 10:47:18AM +0100, Ian Campbell wrote: On Wed, 2015-07-22 at 09:47 +0100, Liviu Dudau wrote: Acked-by: Liviu Dudau liviu.du...@arm.com Thanks. Picking your brains here: would it be worth to have some

Re: [PATCH] dtb: Create a common home for cross-architecture dtsi files.

2015-07-22 Thread Ian Campbell
On Wed, 2015-07-22 at 09:47 +0100, Liviu Dudau wrote: Acked-by: Liviu Dudau liviu.du...@arm.com Thanks. Picking your brains here: would it be worth to have some vendor directories in this shared area or we can hope that there will be very few files living here? I'm honestly not sure. I

[PATCH] dtb: Create a common home for cross-architecture dtsi files.

2015-07-21 Thread Ian Campbell
to use cpp #include instead of /include/. [0] https://git.kernel.org/cgit/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Kumar

Re: 3.18.17 Xen regression

2015-07-17 Thread Ian Campbell
On Tue, 2015-07-07 at 15:54 -0400, Boris Ostrovsky wrote: Commit 63753fac67e1 (x86: Store a per-cpu shadow copy of CR4) in 3.18.y branch introduced a regression on PVH Xen guests. Please apply 5054daa285be (x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests) from mainline to fix this.

Re: [PATCH 3.4 000/172] 3.4.108-rc1 review

2015-06-18 Thread Ian Campbell
On Thu, 2015-06-18 at 11:19 +0800, Zefan Li wrote: On 2015/6/16 23:13, Ian Campbell wrote: On Tue, 2015-06-16 at 16:33 +0800, l...@kernel.org wrote: From: Zefan Li lize...@huawei.com This is the start of the stable review cycle for the 3.4.108 release. There are 172 patches

Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-17 Thread Ian Campbell
On Wed, 2015-06-17 at 10:30 +0100, Julien Grall wrote: I see different opinion on whether using 0x% or %#. As I plan to resend a version with the commit message update, shall I use %#? I think it's mostly pointless bike-shedding over a saving measured in single digit bytes, use whichever you

Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-17 Thread Ian Campbell
...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: net...@vger.kernel.org You meant s/Append/Prepend/, nonetheless: Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-17 Thread Ian Campbell
On Tue, 2015-06-16 at 16:55 -0700, Joe Perches wrote: 0x%x is easier and simpler to visualize than %#x. They also don't produce the same output if the value is 0 (0x%x=0x0, % #x=0), which can matter if you are trying to line up a column or whatever. Ian. -- To unsubscribe from this list: send

Re: [PATCH 3.4 000/172] 3.4.108-rc1 review

2015-06-16 Thread Ian Campbell
On Tue, 2015-06-16 at 16:33 +0800, l...@kernel.org wrote: From: Zefan Li lize...@huawei.com This is the start of the stable review cycle for the 3.4.108 release. There are 172 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being

Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code

2015-06-15 Thread Ian Campbell
On Sat, 2015-06-13 at 11:49 +0200, Ingo Molnar wrote: xen_mm_pin_all()/unpin_all() are used to implement full guest instance suspend/restore. It's a stop-all method that needs to iterate through all allocated pgds in the system to fix them up for Xen's use. This code uses pgd_list, probably

Re: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe

2015-06-12 Thread Ian Campbell
by implementing X-Gene PCIe specific xgene_pcie_config_read32 for CFG read accesses to replace the generic default pci_generic_config_read32 function. Signed-off-by: Duc Dang dhd...@apm.com Applied onto v4.1-rc7 and: Tested-by: Ian Campbell ian.campb...@citrix.com Thanks! -- To unsubscribe

Re: [linux-sunxi] [RFC 0/7] ARM: sun9i: SMP support with Multi-Cluster Power Management

2015-05-16 Thread Ian Campbell
On Thu, 2015-05-14 at 14:10 +0800, Chen-Yu Tsai wrote: This is my attempt to support SMP and CPU hot plugging on the Allwinner A80 SoC. The A80 is a big.Little processor with 2 clusters of 4x Cortex-A7 and 4x Cortex-A15 cores. I thought there was a preference these days to support this sort of

Re: [Xen-devel] [RFC 21/23] net/xen-netback: Make it running on 64KB page granularity

2015-05-15 Thread Ian Campbell
On Fri, 2015-05-15 at 16:31 +0100, Wei Liu wrote: On Fri, May 15, 2015 at 01:35:42PM +0100, Julien Grall wrote: Hi Wei, Thanks you for the review. On 15/05/15 03:35, Wei Liu wrote: On Thu, May 14, 2015 at 06:01:01PM +0100, Julien Grall wrote: The PV network protocol is using 4KB

Re: [Xen-devel] [PATCH] xen: Add __GFP_DMA flag when xen_swiotlb_init gets free pages.

2015-04-21 Thread Ian Campbell
On Mon, 2015-04-20 at 18:54 +0100, Stefano Stabellini wrote: This should definitely be done only on ARM and ARM64, as on x86 PVH assumes the presence of an IOMMU. We need an ifdef. Also we need to figure out a way to try without GFP_DMA in case no ram under 4g is available at all, as some

Re: [Xen-devel] [PATCH] xen: Add __GFP_DMA flag when xen_swiotlb_init gets free pages.

2015-04-21 Thread Ian Campbell
On Tue, 2015-04-21 at 11:36 +0100, Stefano Stabellini wrote: On Tue, 21 Apr 2015, Ian Campbell wrote: On Mon, 2015-04-20 at 18:54 +0100, Stefano Stabellini wrote: This should definitely be done only on ARM and ARM64, as on x86 PVH assumes the presence of an IOMMU. We need an ifdef

Re: [RFC PATCH] xen-netback: making the bandwidth limiter runtime settable

2015-03-17 Thread Ian Campbell
On Fri, 2015-03-13 at 13:51 +0100, Imre Palik wrote: [...] diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index 3aa8648..34d8038 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -463,6 +463,7 @@ int

Re: [Xen-devel] [PATCH v6 07/30] PCI: Pass PCI domain number combined with root bus number

2015-03-17 Thread Ian Campbell
On Tue, 2015-03-17 at 10:45 +0530, Manish Jaggi wrote: On Monday 09 March 2015 08:04 AM, Yijing Wang wrote: Now we could pass PCI domain combined with bus number in u32 argu. Because in arm/arm64, PCI domain number is assigned by pci_bus_assign_domain_nr(). So we leave pci_scan_root_bus()

Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend

2015-03-04 Thread Ian Campbell
On Wed, 2015-03-04 at 14:19 +, David Vrabel wrote: On 04/03/15 14:09, Juergen Gross wrote: The main question whether it is worth to consider this alternative is the performance aspect. Does anyone have an idea which USB devices would typically be used via pvusb? I'd suspect memory

Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend

2015-03-04 Thread Ian Campbell
On Wed, 2015-03-04 at 15:41 +0100, Juergen Gross wrote: On 03/04/2015 03:29 PM, Ian Campbell wrote: On Wed, 2015-03-04 at 14:19 +, David Vrabel wrote: On 04/03/15 14:09, Juergen Gross wrote: The main question whether it is worth to consider this alternative is the performance aspect

Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend

2015-03-04 Thread Ian Campbell
On Wed, 2015-03-04 at 14:31 +0100, Juergen Gross wrote: - move module to appropriate location in kernel tree drivers/xen/ is the correct location for this driver. Hmm, so you regard placement of xen-netback under drivers/net and xen-blkback under drivers/block as wrong? I've just

Re: [PATCH net-next 06/14] xen: Use eth_foo_addr instead of memset

2015-03-03 Thread Ian Campbell
On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: Use the built-in function instead of memset. Signed-off-by: Joe Perches j...@perches.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [Xen-devel] [PATCH 2/2] swiotlb-xen: pass dev_addr to swiotlb_tbl_unmap_single

2015-01-26 Thread Ian Campbell
On Fri, 2014-11-21 at 17:00 +, Stefano Stabellini wrote: Need to pass the pointer within the swiotlb internal buffer to the swiotlb library, that in the case of xen_unmap_single is dev_addr, not paddr. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com CC:

Re: [Xen-devel] [PATCH RFC] xen-time: decreasing the rating of the xen clocksource below that of the tsc clocksource for dom0's

2015-01-07 Thread Ian Campbell
On Wed, 2015-01-07 at 17:16 +0100, Imre Palik wrote: From: Palik, Imre im...@amazon.de In Dom0's the use of the TSC clocksource (whenever it is stable enough to be used) instead of the Xen clocksource should not cause any issues, as Dom0 VMs never live-migrated. Is this still true given

Re: [PATCH] xen-netback: fixing the propagation of the transmit shaper timeout

2015-01-06 Thread Ian Campbell
shaper. This patch fixes the issue. Cc: Anthony Liguori aligu...@amazon.com Signed-off-by: Imre Palik im...@amazon.de Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [Xen-devel] Regression in netfilter code under Xen

2014-11-26 Thread Ian Campbell
On Tue, 2014-11-25 at 15:23 -0500, Boris Ostrovsky wrote: We have a regression due to (5195c14c8: netfilter: conntrack: fix race in __nf_conntrack_confirm against get_next_corpse). I have not been able to reproduce this on baremetal but dom0 crashes reliably after a few seconds of idle

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Ian Campbell
On Tue, 2014-11-25 at 11:17 +, Leif Lindholm wrote: On Tue, Nov 25, 2014 at 10:35:04AM +, Mark Rutland wrote: On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: Support specifying console options (like with console=ttyXN,options) by appending them to the stdout-path

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Ian Campbell
On Tue, 2014-11-25 at 15:20 +, Grant Likely wrote: On Tue, Nov 25, 2014 at 3:15 PM, Leif Lindholm leif.lindh...@linaro.org wrote: On Tue, Nov 25, 2014 at 02:58:54PM +, Grant Likely wrote: + len = strchrnul(path, ':') - path; +

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Ian Campbell
On Tue, 2014-11-25 at 15:39 +, Grant Likely wrote: On Tue, Nov 25, 2014 at 3:24 PM, Ian Campbell i...@debian.org wrote: sed s/of_find_node_by_path\((.*)\)/of_find_node_by_path\(\1, NULL\) Coccinelle rules for this sort of transformation... /me still hasn't gotten his head around how

Re: [RFC PATCH 1/1] arm64: Fix up /proc/cpuinfo

2014-10-30 Thread Ian Campbell
On Thu, 2014-10-30 at 17:15 +, Will Deacon wrote: Hi Mark, On Fri, Oct 24, 2014 at 02:56:40PM +0100, Mark Rutland wrote: Commit d7a49086f263164a (arm64: cpuinfo: print info for all CPUs) attempted to clean up /proc/cpuinfo, but due to concerns regarding further changes was reverted

Re: [Xen-devel] [PATCH 0/2] xen: Switch to virtual mapped linear p2m list

2014-10-28 Thread Ian Campbell
On Tue, 2014-10-28 at 06:00 +0100, Juergen Gross wrote: On 10/27/2014 04:16 PM, David Vrabel wrote: On 27/10/14 14:52, Juergen Gross wrote: Paravirtualized kernels running on Xen use a three level tree for translation of guest specific physical addresses to machine global addresses. This

Re: [PATCH v4 3/7] [RFC] arm/arm64: introduce is_dma_coherent

2014-10-25 Thread Ian Campbell
On Sat, 2014-10-25 at 14:29 +0100, Stefano Stabellini wrote: Your suggestions and looking more at the code gave me another idea, that I think is clean and at the same time suitable for 3.18. What do you think of the following? It is simple, self-contained and doesn't need a new flag in

Re: [PATCH v5 2/6] xen/arm: remove outer_*_range call

2014-10-24 Thread Ian Campbell
On Thu, 2014-10-23 at 18:27 +0100, Stefano Stabellini wrote: Dom0 is not actually capable of issuing outer_inv_range or outer_clean_range calls. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from

Re: [PATCH v5 3/6] xen/arm: introduce xen_is_dma_coherent

2014-10-24 Thread Ian Campbell
to know that arm_coherent_dma_ops is the only possible one which doesn't set the hooks you were checking before. Either way this should be mentioned in the commit log. With that done: Acked-by: Ian Campbell ian.campb...@citrix.com --- Changes in v5: - introduce xen_is_dma_coherent as a xen

Re: [PATCH v5 4/6] xen/arm/arm64: merge xen/mm32.c into xen/mm.c

2014-10-24 Thread Ian Campbell
from the xen_dma wrappers in page-coherent.h to handle non-coherent devices. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v5 5/6] xen/arm/arm64: introduce xen_arch_need_swiotlb

2014-10-24 Thread Ian Campbell
you added. Looks like you have ts=4 or something. The actual changes look ok though, so with the coding style fixed you can add: Acked-by: Ian Campbell ian.campb...@citrix.com --- Changes in v5: - fix indentation. --- arch/arm/include/asm/xen/page.h |4 arch/arm/xen/mm.c

Re: [PATCH v4 1/7] xen/arm: remove handling of XENFEAT_grant_map_identity

2014-10-20 Thread Ian Campbell
On Fri, 2014-10-10 at 12:51 +0100, Stefano Stabellini wrote: The feature has been removed from Xen. Also Linux cannot use it on ARM32 without CONFIG_ARM_LPAE. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: David Vrabel david.vra...@citrix.com Acked-by: Ian

Re: [PATCH v4 4/7] xen/arm: use is_dma_coherent

2014-10-20 Thread Ian Campbell
...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 5/7] xen/arm/arm64: merge xen/mm32.c into xen/mm.c

2014-10-20 Thread Ian Campbell
-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 7/7] xen/arm: introduce GNTTABOP_cache_flush

2014-10-20 Thread Ian Campbell
+static bool hypercall_flush = false; Would be nice to include the word cache (or at least cflush) in this. -arch_initcall(xen_mm_init); +arch_initcall(xen_mm_init) I think this is stray? Acked-by: Ian Campbell ian.campb...@citrix.com -- To unsubscribe from this list: send the line

Re: [PATCH v2 2/2] xen/arm: introduce GNTTABOP_cache_flush

2014-10-03 Thread Ian Campbell
On Fri, 2014-10-03 at 17:20 +0100, Stefano Stabellini wrote: On Fri, 3 Oct 2014, David Vrabel wrote: On 03/10/14 15:53, Stefano Stabellini wrote: Introduce support for new hypercall GNTTABOP_cache_flush. Use it to perform cache flashing on pages used for dma when necessary. [..] /*

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

2014-08-20 Thread Ian Campbell
On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote: The rest of the Xen device drivers use an module alias to load devices when they shop up in XenBus. show. MODULE_LICENSE(Dual BSD/GPL); MODULE_ALIAS(xen-backend:pci); +MODULE_ALIAS(xen:pci); Isn't that xen-backend:pci

Re: [Xen-devel] [PATCH] xen-pciback: Add MODULE_ALIAS for pciback.

2014-08-20 Thread Ian Campbell
On Wed, 2014-08-20 at 13:20 -0400, Konrad Rzeszutek Wilk wrote: On Wed, Aug 20, 2014 at 06:18:52PM +0100, Ian Campbell wrote: On Wed, 2014-08-20 at 12:40 -0400, Konrad Rzeszutek Wilk wrote: The rest of the Xen device drivers use an module alias to load devices when they shop up in XenBus

  1   2   3   4   5   6   >