Re: [PATCH] autofs: drop dentry reference only when it is never used

2018-11-26 Thread Ian Kent
On Mon, 2018-11-26 at 09:58 +0800, Pan Bian wrote: > The function autofs_expire_run calls dput(dentry) to drop the reference > count of dentry. However, dentry is read via autofs_dentry_ino(dentry) > after that. This may result in a use-free-bug. The patch drops the > reference count of dentry

Re: [PATCH v2 1/5] autofs - improve ioctl sbi checks

2018-11-25 Thread Ian Kent
On Fri, 2018-11-23 at 15:29 -0800, Andrew Morton wrote: > On Fri, 23 Nov 2018 18:41:50 +0800 Ian Kent wrote: > > > Al Viro made some suggestions to improve the implementation > > of commit 0633da48f0 "fix autofs_sbi() does not check super > > block type". > &

[PATCH v2 5/5] autofs - add strictexpire mount option

2018-11-23 Thread Ian Kent
t updating the last use on path walk access). Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |1 + fs/autofs/inode.c|8 +++- fs/autofs/root.c |5 - include/uapi/linux/auto_fs.h |2 +- 4 files changed, 13 insertions(+), 3 deletions(-) diff

[PATCH v2 4/5] autofs - change catatonic setting to a bit flag

2018-11-23 Thread Ian Kent
Change the super block info. catatonic setting to be part of a flags bit field. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |7 +-- fs/autofs/dev-ioctl.c |4 ++-- fs/autofs/inode.c |4 ++-- fs/autofs/root.c | 11 ++- fs/autofs/waitq.c | 10

[PATCH v2 2/5] autofs - fix possible inode leak in autofs_fill_super()

2018-11-23 Thread Ian Kent
There is no check at all for a failure to allocate the root inode in autofs_fill_super(), handle it. Signed-off-by: Ian Kent --- fs/autofs/inode.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c index 846c052569dd

[PATCH v2 3/5] autofs - simplify parse_options() function call

2018-11-23 Thread Ian Kent
The parse_options() function uses a long list of parameters, most of which are present in the super block info structure already. The mount parameters set in parse_options() options don't require cleanup so using the super block info struct directly is simpler. --- fs/autofs/inode.c | 55

[PATCH v2 1/5] autofs - improve ioctl sbi checks

2018-11-23 Thread Ian Kent
ommon case where it isn't needed. So it's sufficient to do this in the ioctl code only. Also the check in the ioctl code is needlessly complex. Signed-off-by: Ian Kent Cc: Al Viro --- fs/autofs/autofs_i.h |3 +-- fs/autofs/dev-ioctl.c | 25 +++-- fs/autofs/init.c |

[PATCH v2 0/5] autofs updates

2018-11-23 Thread Ian Kent
- improve file system verification for ioctl case. - fix potential inode leak in mount code. - add "strictexpire" autofs mount option. v2 changes: - fix compile error. - deffer some of the mount option re-factoring to try and avoid any conflicts with linux-next. --- Ian Kent (5):

Re: [PATCH 4/6] autofs - use struct for mount params

2018-11-13 Thread Ian Kent
e wrong git tree, please drop us a note to help > improve the system] > > url: > https://github.com/0day-ci/linux/commits/Ian-Kent/autofs-improve-ioctl-sbi-checks/20181114-021150 > config: i386-allmodconfig (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 > rep

[PATCH 6/6] autofs - add strictexpire mount option

2018-11-12 Thread Ian Kent
t updating the last use on path walk accesses). Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |1 + fs/autofs/inode.c| 13 - fs/autofs/root.c |5 - include/uapi/linux/auto_fs.h |2 +- 4 files changed, 18 insertions(+), 3 deletions(-)

[PATCH 5/6] autofs - change catatonic setting to a bit flag

2018-11-12 Thread Ian Kent
Change the super block info. catatonic setting to be part of a flags bit field. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |7 +-- fs/autofs/dev-ioctl.c |4 ++-- fs/autofs/inode.c |4 ++-- fs/autofs/root.c | 11 ++- fs/autofs/waitq.c | 10

[PATCH 2/6] autofs - fix possible inode leak in autofs_fill_super()

2018-11-12 Thread Ian Kent
There is no check at all for a failure to allocate the root inode in autofs_fill_super(), handle it. Signed-off-by: Ian Kent --- fs/autofs/inode.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c index 846c052569dd

[PATCH 4/6] autofs - use struct for mount params

2018-11-12 Thread Ian Kent
Use a structure to hold parsed parameters to simplify the autofs_parse_options() function call. Also seperate option parsing and applying the options into seperate functions. Signed-off-by: Ian Kent --- fs/autofs/inode.c | 193 - 1 file

[PATCH 3/6] autofs - refactor super block info init

2018-11-12 Thread Ian Kent
Move the allocation and initialisation of the super block info struct to its own function. Signed-off-by: Ian Kent --- fs/autofs/inode.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c

[PATCH 1/6] autofs - improve ioctl sbi checks

2018-11-12 Thread Ian Kent
ommon case where it isn't needed. So it's sufficient to do this in the ioctl code only. Also the check in the ioctl code is needlessly complex. Signed-off-by: Ian Kent Cc: Al Viro --- fs/autofs/autofs_i.h |3 +-- fs/autofs/dev-ioctl.c | 25 +++-- fs/autofs/init.c |

[ANNOUNCE] autofs 5.1.5 release

2018-10-30 Thread Ian Kent
Hi all, It's time for a release, autofs-5.1.5. A few changes of note are: With the deprecation of the fedfs-utils package it was necessary to add a couple of binaries from that package for fedfs users to give them time to migrate away from using fedfs. The binaries included in autofs are

Re: [PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-29 Thread Ian Kent
On Mon, 2018-08-27 at 02:03 +0100, Al Viro wrote: > On Mon, Aug 20, 2018 at 04:37:09PM +0800, Ian Kent wrote: > > The autofs_sbi() inline function does not check the super block > > magic number to verify it has been given an autofs super block. > > IMO it's the wrong wa

[PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-20 Thread Ian Kent
The autofs_sbi() inline function does not check the super block magic number to verify it has been given an autofs super block. Reported-by: syzbot+87c3c541582e56943...@syzkaller.appspotmail.com Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |4 +++- fs/autofs/inode.c|1 - 2 files

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-25 Thread Ian Kent
On Wed, 2018-07-25 at 08:48 -0700, Casey Schaufler wrote: > On 7/24/2018 10:39 PM, Ian Kent wrote: > > On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: > > > On 7/24/2018 9:00 AM, David Howells wrote: > > > > Casey Schaufler wrote: > >

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-24 Thread Ian Kent
On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote: > On 7/24/2018 9:00 AM, David Howells wrote: > > Casey Schaufler wrote: > > > > > > (1) Mount topology and reconfiguration change events. > > > > > > With the possibility of unprivileged mounting you're going to have to > > > address

Re: [RFC][PATCH 0/5] Mount, Filesystem and Keyrings notifications

2018-07-23 Thread Ian Kent
On Mon, 2018-07-23 at 09:31 -0700, Casey Schaufler wrote: > On 7/23/2018 8:25 AM, David Howells wrote: > > Hi Al, > > > > Here's a set of patches to add a general variable-length notification queue > > concept and to add sources of events for: > > Overall I approve. The interface is a bit

Re: [PATCH] autofs - fix slab out of bounds read in getname_kernel()

2018-07-05 Thread Ian Kent
On Thu, 2018-07-05 at 16:58 -0700, Andrew Morton wrote: > On Tue, 03 Jul 2018 14:45:15 +0800 Ian Kent wrote: > > > Initial patch contributed by Tomas Bortoli. > > > > The autofs subsystem does not check that the "path" parameter is > > present

[PATCH] autofs - fix slab out of bounds read in getname_kernel()

2018-07-03 Thread Ian Kent
l command. To solve it, modify validate_dev_ioctl() function to check that a path has been provided for ioctl commands that require it. Signed-off-by: Tomas Bortoli Signed-off-by: Ian Kent Reported-by: syzbot+60c837b428dc84e83...@syzkaller.appspotmail.com --- fs/autofs/dev-ioctl.c | 22 ++

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-03 Thread Ian Kent
On Tue, 2018-07-03 at 07:48 +0200, Dmitry Vyukov wrote: > On Tue, Jul 3, 2018 at 3:34 AM, Ian Kent wrote: > > On Mon, 2018-07-02 at 14:15 +0200, Dmitry Vyukov wrote: > > > On Mon, Jul 2, 2018 at 1:55 PM, tomas wrote: > > > > Yes, thanks. Please u

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Ian Kent
t; > from the original bug report. This this help to keep automatic testing > process running. Umm ... should I include this email address on the actual cc when submitting the patch? > > Thanks > > > > > > On 07/02/2018 12:20 PM, Ian Kent wrote: > > &

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-02 Thread Ian Kent
s a dumb mistake. I'll send it to Andrew Morton, after some fairly simple sanity testing, with both our Signed-off-by added. > > Tomas > > > On 07/02/2018 03:42 AM, Ian Kent wrote: > > On Mon, 2018-07-02 at 09:10 +0800, Ian Kent wrote: > > > On Mon, 20

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-01 Thread Ian Kent
On Mon, 2018-07-02 at 09:10 +0800, Ian Kent wrote: > On Mon, 2018-07-02 at 00:04 +0200, tomas wrote: > > Hi, > > > > I've looked into this issue found by Syzbot and I made a patch: > > > > https://syzkaller.appspot.com/bug?id=d03abd8b42847f7f69b1d1d7f97208

Re: [PATCH upstream] KASAN: slab-out-of-bounds Read in getname_kernel

2018-07-01 Thread Ian Kent
On Mon, 2018-07-02 at 00:04 +0200, tomas wrote: > Hi, > > I've looked into this issue found by Syzbot and I made a patch: > > https://syzkaller.appspot.com/bug?id=d03abd8b42847f7f69b1d1d7f97208ae425b1163 Umm ... oops! Thanks for looking into this Tomas. > > > The autofs subsystem does not

[PATCH 3/6] autofs - make autofs_expire_direct() static

2018-06-18 Thread Ian Kent
autofs_expire_direct() isn't used outside of fs/autofs/expire.c so make it static. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |3 --- fs/autofs/expire.c |8 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/autofs/autofs_i.h b/fs/autofs/autofs_i.h index

[PATCH 6/6] autofs - add AUTOFS_EXP_FORCED flag

2018-06-18 Thread Ian Kent
to allow implemention of the feature and bump the protocol version so user space can check if it's implemented if needed. Signed-off-by: Ian Kent --- fs/autofs/expire.c | 62 ++ include/uapi/linux/auto_fs.h |8 +++-- 2 files changed, 55

[PATCH 5/6] autofs - make expire flags usage consistent with v5 params

2018-06-18 Thread Ian Kent
Make the usage of the expire flags consistent by naming the expire flags the same as it is named in the version 5 miscelaneous ioctl parameters and only check the bit flags when needed. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |2 +- fs/autofs/expire.c | 61

[PATCH 4/6] autofs - make autofs_expire_indirect() static

2018-06-18 Thread Ian Kent
autofs_expire_indirect() isn't used outside of fs/autofs/expire.c so make it static. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |3 --- fs/autofs/expire.c |8 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/autofs/autofs_i.h b/fs/autofs/autofs_i.h

[PATCH 1/6] autofs - fix inconsistent use of now variable

2018-06-18 Thread Ian Kent
or during expire so jiffies can be used directly and the global variable "now" removed. Signed-off-by: Ian Kent --- fs/autofs/expire.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c index b332d3f6e730..295fe

[PATCH 2/6] autofs - fix clearing AUTOFS_EXP_LEAVES in autofs_expire_indirect()

2018-06-18 Thread Ian Kent
it rather than remove the expire leaves functionality. Signed-off-by: Ian Kent --- fs/autofs/expire.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c index 295feec10ea6..41855cdc5630 100644 --- a/fs/autofs/expire.c +++ b/fs/autofs/expire.c

Re: [PATCH 1/7] autofs - fix directory and symlink access

2018-06-18 Thread Ian Kent
Andrew, Very sorry, clearly I have already sent this to you. Unfortunately I didn't stop this in time, please ignore. On Tue, 2018-06-19 at 10:50 +0800, Ian Kent wrote: > Depending on how it is configured the autofs user space daemon can > leave in use mounts mounted at exit and re-c

[PATCH 1/7] autofs - fix directory and symlink access

2018-06-18 Thread Ian Kent
directories and symlinks which can be a problem at restart, as described above. So return EACCES in the directory, symlink and unlink methods if the autofs file system is catatonic. Signed-off-by: Ian Kent --- fs/autofs/root.c | 33 ++--- 1 file changed, 30

Re: [PATCH] autofs - fix directory and symlink access

2018-06-14 Thread Ian Kent
On Fri, 2018-06-15 at 08:06 +0800, Ian Kent wrote: Opps, missing Signed-off-by, please add it! > Depending on how it is configured the autofs user space daemon can > leave in use mounts mounted at exit and re-connect to them at start > up. But for this to work best the state of the au

[PATCH] autofs - fix directory and symlink access

2018-06-14 Thread Ian Kent
Depending on how it is configured the autofs user space daemon can leave in use mounts mounted at exit and re-connect to them at start up. But for this to work best the state of the autofs file system needs to be left intact over the restart. Also, at system shutdown, mounts in an autofs file

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-06-01 Thread Ian Kent
On Fri, 2018-06-01 at 09:35 +0800, Ian Kent wrote: > On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote: > > On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote: > > > > > > I actually had an alternative approach that I tried out successfully > > > > bu

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-31 Thread Ian Kent
On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote: > On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote: > > > > I actually had an alternative approach that I tried out successfully > > > but discarded as being too different from the original code. Just for > &g

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-30 Thread Ian Kent
On Wed, 2018-05-30 at 10:41 +0200, Arnd Bergmann wrote: > On Wed, May 30, 2018 at 2:48 AM, Ian Kent wrote: > > On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote: > > > The autofs4 implementation is just a redirect to autofs now, but that > > > also mea

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-29 Thread Ian Kent
On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote: > The autofs4 implementation is just a redirect to autofs now, but that > also means we can't have both built into the same kernel: > > fs/autofs/inode.o: In function `autofs_new_ino': > inode.c:(.text+0x1b8): multiple definition of

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-28 Thread Ian Kent
On Mon, 2018-05-28 at 12:39 +0800, Ian Kent wrote: > On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot > > > wrote: > > > > > > &g

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-27 Thread Ian Kent
On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot <l...@intel.com> wrote: > > > > > Hi Andrey, > > > > > > I love your patch! Ye

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-27 Thread Ian Kent
On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot wrote: > > > Hi Andrey, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on mmotm/master] > > [cannot apply to v4.17-rc6] > > [if

[REPOST PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
attention to it. It also results in AUTOFS4_FS being removed from .config for any setting of AUTOFS_FS except n. Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise awareness of the change to smooth the transition. Signed-off-by: Ian Kent <ra...@themaw.net> Reported-by: Randy Dun

Re: [PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
On 21/05/18 10:08, Randy Dunlap wrote: > On 05/20/2018 06:04 PM, Ian Kent wrote: >> Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile >> failure. >> >> It isn't possible to unset one if the other is set because it >> introduces a circular depe

[PATCH] autofs - comment on selinux changes needed for module autoload

2018-05-20 Thread Ian Kent
that prohibit autoloading of the autofs module which need to be changed. Add a comment about this to "possible changes" section of the autofs4 module help. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/Kconfig |6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/auto

[PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
which should call attention to it. It also results in AUTOFS4_FS being removed from .config for any setting of AUTOFS_FS except n. Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise awareness of the change to smooth the transition. Signed-off-by: Ian Kent <ra...@the

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-20 Thread Ian Kent
On 21/05/18 08:43, Ian Kent wrote: >>> >>> It looks like adding: >>> depends on AUTOFS_FS = n && AUTOFS_FS != m >> >> Hi. Is there a typo on the line above? LOL, but your point is what does the AUTOFS_FS != m do! The answer should be no

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-20 Thread Ian Kent
On 19/05/18 00:22, Randy Dunlap wrote: > On 05/17/2018 11:09 PM, Ian Kent wrote: >> On 18/05/18 12:38, Ian Kent wrote: >>> On 18/05/18 12:23, Randy Dunlap wrote: >>>> On 05/17/2018 08:50 PM, Ian Kent wrote: >>>>> On 18/05/18 08:21, Randy Dunlap wro

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-18 Thread Ian Kent
On 18/05/18 12:38, Ian Kent wrote: > On 18/05/18 12:23, Randy Dunlap wrote: >> On 05/17/2018 08:50 PM, Ian Kent wrote: >>> On 18/05/18 08:21, Randy Dunlap wrote: >>>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >>>>> The mm-of-the-momen

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-17 Thread Ian Kent
On 18/05/18 12:23, Randy Dunlap wrote: > On 05/17/2018 08:50 PM, Ian Kent wrote: >> On 18/05/18 08:21, Randy Dunlap wrote: >>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >>>> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >>&g

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-17 Thread Ian Kent
On 18/05/18 08:21, Randy Dunlap wrote: > On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >>

[PATCH] autofs - clean up includes

2018-05-14 Thread Ian Kent
Remove includes that aren't needed from autofs (and fs/compat_ioctl.c). Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs/autofs_i.h |2 +- fs/autofs/dev-ioctl.c | 13 - fs/autofs/inode.c |6 +- fs/autofs/root.c |6 -- fs/autofs/w

Re: [PATCH 01/10] autofs4 - merge auto_fs.h and auto_fs4.h

2018-05-13 Thread Ian Kent
On 14/05/18 11:15, Al Viro wrote: > On Mon, May 14, 2018 at 11:03:50AM +0800, Ian Kent wrote: >> The autofs module has long since been removed so there's no need to have >> two separate include files for autofs. > > Umm... Why does fs/compat_ioctl.c need either include, act

[PATCH 03/10] autofs - copy autofs4 to autofs

2018-05-13 Thread Ian Kent
Copy source files from the autofs4 directory to the autofs directory. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs/autofs_i.h | 273 ++ fs/autofs/dev-ioctl.c | 761 fs/autofs/expire.c

[PATCH 02/10] autofs4 - use autofs instead of autofs4 everywhere

2018-05-13 Thread Ian Kent
Update naming within autofs source to be consistent by changing occurrences of autofs4 to autofs. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/autofs_i.h | 88 fs/autofs4/dev-ioctl.c | 18 ++- fs/autofs4/expire.c| 132 --- fs/a

[PATCH 07/10] autofs - delete fs/autofs4 source files

2018-05-13 Thread Ian Kent
Delete the now unused autofs4 module files. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/autofs_i.h | 273 -- fs/autofs4/dev-ioctl.c | 761 --- fs/autofs4/expire.c| 632 fs/autofs4/

[PATCH 05/10] autofs - update fs/autofs4/Kconfig

2018-05-13 Thread Ian Kent
Update Kconfig and add a depricated warning. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/Kconfig | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 44727bf18297..53bc592a250d

[PATCH 09/10] autofs - use autofs instead of autofs4 in documentation

2018-05-13 Thread Ian Kent
Finally remove autofs4 references in the filesystems documentation. Signed-off-by: Ian Kent <ra...@themaw.net> --- Documentation/filesystems/00-INDEX |4 ++-- Documentation/filesystems/autofs-mount-control.txt |8 Documentation/filesystems/auto

[PATCH 04/10] autofs - create autofs Kconfig and Makefile

2018-05-13 Thread Ian Kent
Create Makefile and Kconfig for autofs module. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/Kconfig |1 + fs/Makefile|1 + fs/autofs/Kconfig | 20 fs/autofs/Makefile |7 +++ 4 files changed, 29 insertions(+) create mode 100

[PATCH 08/10] autofs - rename autofs documentation files

2018-05-13 Thread Ian Kent
There are two files in Documentation/filsystems that should now use autofs rather than autofs4 in their names. Signed-off-by: Ian Kent <ra...@themaw.net> --- Documentation/filesystems/autofs-mount-control.txt | 407 +++ Documentation/filesystems/autofs.txt

[PATCH 10/10] autofs - update MAINTAINERS entry for autofs

2018-05-13 Thread Ian Kent
Update the autofs entry in MAINTAINERS to reflect the rename of autofs4 to autofs. Signed-off-by: Ian Kent <ra...@themaw.net> --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 58b9861ccf99..6189ff91fda7

[PATCH 01/10] autofs4 - merge auto_fs.h and auto_fs4.h

2018-05-13 Thread Ian Kent
The autofs module has long since been removed so there's no need to have two separate include files for autofs. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/autofs_i.h |2 fs/compat_ioctl.c |1 include/uapi/linux/auto_fs.h

[PATCH 06/10] autofs - update fs/autofs4/Makefile

2018-05-13 Thread Ian Kent
Update Makefile to build from source in fs/autofs instead of fs/autofs4. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/Makefile |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/Makefile b/fs/autofs4/Makefile index a811c1f7d9ab..417dd726d9ef

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-04-02 Thread Ian Kent
On 01/04/18 14:21, Andrei Vagin wrote: > On Sun, Apr 01, 2018 at 10:01:41AM +0800, Ian Kent wrote: >> On 01/04/18 09:31, Ian Kent wrote: >>> On 31/03/18 10:28, Andrei Vagin wrote: >>>> In "autofs4: use wait_event_killable", wait_event_interruptible()

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-03-31 Thread Ian Kent
On 01/04/18 09:31, Ian Kent wrote: > On 31/03/18 10:28, Andrei Vagin wrote: >> In "autofs4: use wait_event_killable", wait_event_interruptible() was >> replaced by wait_event_killable(), but in this case we have to use >> wake_up() instead of wake_up_interrupt

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-03-31 Thread Ian Kent
r a mount, they all should be woken up when the daemon signals mount completion. > > Cc: Matthew Wilcox <mawil...@microsoft.com> > Cc: Ian Kent <ra...@themaw.net> > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: Stephen Rothwell <s...@canb.auug.org.au> >

Re: [PATCH] autofs4: Use wait_event_killable

2018-03-19 Thread Ian Kent
On 20/03/18 03:25, David Rientjes wrote: > On Mon, 19 Mar 2018, Matthew Wilcox wrote: > >> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c >> index a0c57c37fa21..c160e9b3aa0f 100644 >> --- a/fs/autofs4/waitq.c >> +++ b/fs/autofs4/waitq.c >> @@ -19,9 +19,6 @@ >> */ >> static autofs_wqt_t

Re: [PATCH] autofs4: Use wait_event_killable

2018-03-19 Thread Ian Kent
ble is what was meant to happen here. Predates is an understatement, this is really, really old code. Do I need to forward this to Al or Andrew? > > Signed-off-by: Matthew Wilcox <mawil...@microsoft.com> Signed-off-by: Ian Kent <ra...@themaw.net> > --- > fs/autofs4/waitq.c | 27

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 21/12/17 09:09, NeilBrown wrote: > 8<--- > Subject: use_hostname_for_mounts shouldn't prevent selection among replica > > If several replicas have been specified for a mount point, and > use_hostname_for_mount is set to "yes", the selection between > these replicas is

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 03/01/18 06:14, NeilBrown wrote: > On Thu, Dec 21 2017, Ian Kent wrote: > >> On 21/12/17 19:06, Ian Kent wrote: >>> On 21/12/17 09:09, NeilBrown wrote: >>>> On Wed, Dec 20 2017, Ian Kent wrote: >>>> >>>>> On 20/12/17 13:5

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-21 Thread Ian Kent
On 21/12/17 19:06, Ian Kent wrote: > On 21/12/17 09:09, NeilBrown wrote: >> On Wed, Dec 20 2017, Ian Kent wrote: >> >>> On 20/12/17 13:52, Ian Kent wrote: >>>> On 20/12/17 11:29, NeilBrown wrote: >>>>> >>>>> Hi Ian, >>>&g

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-21 Thread Ian Kent
On 21/12/17 09:09, NeilBrown wrote: > On Wed, Dec 20 2017, Ian Kent wrote: > >> On 20/12/17 13:52, Ian Kent wrote: >>> On 20/12/17 11:29, NeilBrown wrote: >>>> >>>> Hi Ian, >>>> I've been looking at: >>>> >>>>

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 13:52, Ian Kent wrote: > On 20/12/17 11:29, NeilBrown wrote: >> >> Hi Ian, >> I've been looking at: >> >>> - add configuration option to use fqdn in mounts. >> >> (commit 9aeef772604) because using this new option causes a regres

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 14:10, Ian Kent wrote: > On 20/12/17 13:52, Ian Kent wrote: >> On 20/12/17 11:29, NeilBrown wrote: >>> >>> Hi Ian, >>> I've been looking at: >>> >>>> - add configuration option to use fqdn in mounts. >>> >>

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 13:52, Ian Kent wrote: > On 20/12/17 11:29, NeilBrown wrote: >> >> Hi Ian, >> I've been looking at: >> >>> - add configuration option to use fqdn in mounts. >> >> (commit 9aeef772604) because using this new option causes a regres

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 11:29, NeilBrown wrote: > > Hi Ian, > I've been looking at: > >> - add configuration option to use fqdn in mounts. > > (commit 9aeef772604) because using this new option causes a regression. > If you are using the "replicated server" functionality, then > use_hostname_for_mounts

Re: [ANNOUNCE] autofs 5.1.4 release

2017-12-19 Thread Ian Kent
On 19/12/17 17:45, Patrick Goetz wrote: > On 12/19/2017 02:29 AM, Ian Kent wrote: >> A new amd mount type has been added. The amd mount type "program" >> has been added which allows a user provided program to be given >> in a map entry that will be used for perform

[ANNOUNCE] autofs 5.1.4 release

2017-12-19 Thread Ian Kent
Hi all, It's finally time for a release, autofs-5.1.4. Unfortunately there were a couple of annoying regressions in 5.1.3. I believe they have been resolved in this release. Also, the startup retry on the master map not available logic has been improved so that should function properly now and

Re: [PATCH 0/2] userns: automount cleanups

2017-11-30 Thread Ian Kent
On 30/11/17 13:21, Eric W. Biederman wrote: > Ian Kent <ra...@themaw.net> writes: > >> On 30/11/17 08:01, Eric W. Biederman wrote: >>> >>> While reviewing some code I realized that in getting d_automount working >>> with s_user_ns I had left behind so

Re: [PATCH 0/2] userns: automount cleanups

2017-11-29 Thread Ian Kent
On 30/11/17 08:01, Eric W. Biederman wrote: > > While reviewing some code I realized that in getting d_automount working > with s_user_ns I had left behind some unnecessary relics of the blind > path I started down. Here are two patches that remove those relics. > > Unless someone has another

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-29 Thread Ian Kent
On 29/11/17 15:39, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> On 29/11/17 11:45, NeilBrown wrote: >>> On Wed, Nov 29 2017, Ian Kent wrote: >>> >>>> Adding Al Viro to the Cc list as I believe Stephen Whitehouse and >>>>

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 11:45, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> Adding Al Viro to the Cc list as I believe Stephen Whitehouse and >> Al have discussed something similar, please feel free to chime in >> with your thoughts Al. >> >> On 29/11/1

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 10:48, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> On 29/11/17 10:13, Mike Marion wrote: >>> On Wed, Nov 29, 2017 at 12:17:27PM +1100, NeilBrown wrote: >>> >>>> How big do people see /proc/self/mount* getting? What size

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
Adding Al Viro to the Cc list as I believe Stephen Whitehouse and Al have discussed something similar, please feel free to chime in with your thoughts Al. On 29/11/17 09:17, NeilBrown wrote: > On Tue, Nov 28 2017, Mike Marion wrote: > >> On Tue, Nov 28, 2017 at 07:43:05AM +0800, Ia

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 10:13, Mike Marion wrote: > On Wed, Nov 29, 2017 at 12:17:27PM +1100, NeilBrown wrote: > >> How big do people see /proc/self/mount* getting? What size reads >> does 'strace' show the various programs using to read it? > > We already have line counts into 5 figures. This wasn't an

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-27 Thread Ian Kent
On 28/11/17 00:01, Mike Marion wrote: > On Thu, Nov 23, 2017 at 08:36:49AM +0800, Ian Kent wrote: > >> And with the move of userspace to use /proc based mount tables (one >> example being the symlink of /etc/mtab into /proc) even modest sized >> direct mount maps will

[PATCH 2/2] autofs: revert fix AT_NO_AUTOMOUNT not being honored

2017-11-26 Thread Ian Kent
modifications. So that will be done instead and the autofs module documentation updated with a description of the problem and what needs to be done by module users for this specific case. Reverts: 42f4614821 Signed-off-by: Ian Kent <ra...@themaw.net> Cc: Neil Brown <ne...@suse.com> Cc

[PATCH 1/2] autofs: revert take more care to not update last_used on path walk

2017-11-26 Thread Ian Kent
the patch being reverted introduces a regression which should be fixed. Reverts: 092a53452b Signed-off-by: Ian Kent <ra...@themaw.net> Cc: Neil Brown <ne...@suse.com> Cc: Al Viro <v...@zeniv.linux.org.uk> --- fs/autofs4/root.c | 17 ++--- 1 file changed, 6 insertion

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 12:49, NeilBrown wrote: > On Thu, Nov 23 2017, Ian Kent wrote: > >> On 23/11/17 10:21, NeilBrown wrote: >>> On Thu, Nov 23 2017, Ian Kent wrote: >>> >>>> >>>> Hey Neil, I'm looking at this again because RH QE have complained about

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 11:04, NeilBrown wrote: > On Thu, Nov 23 2017, Ian Kent wrote: > >> On 23/11/17 08:47, NeilBrown wrote: >>> On Wed, Nov 22 2017, Ian Kent wrote: >>> >>>> On 21/11/17 09:53, NeilBrown wrote: >>>>> On Wed, May 10 2017, Ian Kent

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 10:46, Ian Kent wrote: > On 23/11/17 10:21, NeilBrown wrote: >> On Thu, Nov 23 2017, Ian Kent wrote: >> >>> >>> Hey Neil, I'm looking at this again because RH QE have complained about >>> a regression test failing with a kernel that has this

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 10:21, NeilBrown wrote: > On Thu, Nov 23 2017, Ian Kent wrote: > >> >> Hey Neil, I'm looking at this again because RH QE have complained about >> a regression test failing with a kernel that has this change. >> >> Maybe I'm just dumb but I though

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 09:43, Ian Kent wrote: > On 23/11/17 08:47, NeilBrown wrote: >> On Wed, Nov 22 2017, Ian Kent wrote: >> >>> On 21/11/17 09:53, NeilBrown wrote: >>>> On Wed, May 10 2017, Ian Kent wrote: >>>> >>>>> The fstatat(2) and statx

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 08:47, NeilBrown wrote: > On Wed, Nov 22 2017, Ian Kent wrote: > >> On 21/11/17 09:53, NeilBrown wrote: >>> On Wed, May 10 2017, Ian Kent wrote: >>> >>>> The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT >>>

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 22/11/17 12:28, Ian Kent wrote: > On 21/11/17 09:53, NeilBrown wrote: >> On Wed, May 10 2017, Ian Kent wrote: >> >>> The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT >>> which is meant to clear the LOOKUP_AUTOMOUNT flag and prevent triggerin

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-21 Thread Ian Kent
On 21/11/17 09:53, NeilBrown wrote: > On Wed, May 10 2017, Ian Kent wrote: > >> The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT >> which is meant to clear the LOOKUP_AUTOMOUNT flag and prevent triggering >> of an automount by the call. But this flag is

Re: [PATCH] autofs: don't fail mount for transient error

2017-11-03 Thread Ian Kent
On 03/11/17 09:40, NeilBrown wrote: > Hi Neil, and thanks taking the time to post the patch. > Currently if the autofs kernel module gets an error when > writing to the pipe which links to the daemon, then it > marks the whole moutpoint as catatonic, and it will stop working. > > It is

  1   2   3   4   5   6   >