[PATCH v7 8/8] selftests/pcie_bwctrl: Create selftests

2024-09-10 Thread Ilpo Järvinen
the cur_state of the cooling device one-by-one from max_state to what the cur_state was initially. The speed change is confirmed by observing the current_link_speed for the corresponding PCIe Port. Signed-off-by: Ilpo Järvinen --- MAINTAINERS | 1 + tools

Re: [PATCH 2/6] selftests/resctrl: Ensure measurements skip initialization of default benchmark

2024-09-09 Thread Ilpo Järvinen
On Fri, 6 Sep 2024, Reinette Chatre wrote: > On 9/6/24 3:00 AM, Ilpo Järvinen wrote: > > On Thu, 5 Sep 2024, Reinette Chatre wrote: > > > On 9/5/24 5:10 AM, Ilpo Järvinen wrote: > > > > On Wed, 4 Sep 2024, Reinette Chatre wrote: > > > > > On 9/4/24 4:5

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-09 Thread Ilpo Järvinen
On Fri, 6 Sep 2024, Reinette Chatre wrote: > On 9/6/24 1:44 AM, Ilpo Järvinen wrote: > > On Thu, 5 Sep 2024, Reinette Chatre wrote: > > > On 9/5/24 4:45 AM, Ilpo Järvinen wrote: > > > > On Wed, 4 Sep 2024, Reinette Chatre wrote: > > > > > On 9/4/24 4:4

Re: [PATCH] selftests:resctrl: Fix build failure on archs without __cpuid_count()

2024-09-06 Thread Ilpo Järvinen
ftest.h:74:9: error: impossible constraint in ‘asm’ >74 | __asm__ __volatile__ ("cpuid\n\t" > \ > | ^~~ > cat_test.c:306:17: note: in expansion of macro ‘__cpuid_count’ > 306 | __cpuid_count(0x10, 2, eax, ebx, ecx, edx); > > Reported-by: Muhamma

Re: [PATCH 2/6] selftests/resctrl: Ensure measurements skip initialization of default benchmark

2024-09-06 Thread Ilpo Järvinen
On Thu, 5 Sep 2024, Reinette Chatre wrote: > On 9/5/24 5:10 AM, Ilpo Järvinen wrote: > > On Wed, 4 Sep 2024, Reinette Chatre wrote: > > > On 9/4/24 4:57 AM, Ilpo Järvinen wrote: > > > > On Fri, 30 Aug 2024, Reinette Chatre wrote: > > > > > On 8/30/24

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-06 Thread Ilpo Järvinen
On Thu, 5 Sep 2024, Reinette Chatre wrote: > On 9/5/24 4:45 AM, Ilpo Järvinen wrote: > > On Wed, 4 Sep 2024, Reinette Chatre wrote: > > > On 9/4/24 4:43 AM, Ilpo Järvinen wrote: > > > > On Fri, 30 Aug 2024, Reinette Chatre wrote: > > > > > On 8/30/24

Re: [PATCH 2/6] selftests/resctrl: Ensure measurements skip initialization of default benchmark

2024-09-05 Thread Ilpo Järvinen
On Wed, 4 Sep 2024, Reinette Chatre wrote: > On 9/4/24 4:57 AM, Ilpo Järvinen wrote: > > On Fri, 30 Aug 2024, Reinette Chatre wrote: > > > On 8/30/24 3:56 AM, Ilpo Järvinen wrote: > > > > On Thu, 29 Aug 2024, Reinette Chatre wrote: > > > > > @@ -69

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-05 Thread Ilpo Järvinen
On Wed, 4 Sep 2024, Reinette Chatre wrote: > On 9/4/24 4:43 AM, Ilpo Järvinen wrote: > > On Fri, 30 Aug 2024, Reinette Chatre wrote: > > > On 8/30/24 4:42 AM, Ilpo Järvinen wrote: > > > > On Thu, 29 Aug 2024, Reinette Chatre wrote: > > > > > > &

Re: [PATCH v4 3/4] selftests/x86: don't clobber CFLAGS

2024-09-04 Thread Ilpo Järvinen
On Tue, 3 Sep 2024, Reinette Chatre wrote: > On 9/3/24 7:45 AM, Ilpo Järvinen wrote: > > The x86 selftests makefile clobbers CFLAGS preventing lib.mk from > > making the necessary adjustments into CFLAGS. This would lead to a > > build failure after upcoming change which want

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-04 Thread Ilpo Järvinen
On Wed, 4 Sep 2024, Shuah Khan wrote: > On 9/4/24 06:18, Ilpo Järvinen wrote: > > On Tue, 3 Sep 2024, Shuah Khan wrote: > > > > > On 9/3/24 08:45, Ilpo Järvinen wrote: > > > > This series first generalizes resctrl selftest non-contiguous CAT check > >

Re: [PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-04 Thread Ilpo Järvinen
On Tue, 3 Sep 2024, Shuah Khan wrote: > On 9/3/24 08:45, Ilpo Järvinen wrote: > > This series first generalizes resctrl selftest non-contiguous CAT check > > to not assume non-AMD vendor implies Intel. Second, it improves > > selftests such that the use of __cpuid_count()

Re: [PATCH 2/6] selftests/resctrl: Ensure measurements skip initialization of default benchmark

2024-09-04 Thread Ilpo Järvinen
On Fri, 30 Aug 2024, Reinette Chatre wrote: > > Thank you for taking a look. > > On 8/30/24 3:56 AM, Ilpo Järvinen wrote: > > On Thu, 29 Aug 2024, Reinette Chatre wrote: > > > > ... > > > > @@ -684,11 +622,13 @@ int resctrl_val(const struct resctrl

Re: [PATCH 5/6] selftests/resctrl: Do not compare performance counters and resctrl at low bandwidth

2024-09-04 Thread Ilpo Järvinen
On Fri, 30 Aug 2024, Reinette Chatre wrote: > On 8/30/24 4:42 AM, Ilpo Järvinen wrote: > > On Thu, 29 Aug 2024, Reinette Chatre wrote: > > > > > The MBA test incrementally throttles memory bandwidth, each time > > > followed by a comparison between the memor

[PATCH v4 4/4] kselftest: Provide __cpuid_count() stub on non-x86 archs

2024-09-03 Thread Ilpo Järvinen
uire it using uname -m. Provide a stub for __cpuid_count() if HAVE_CPUID is not present to allow build to succeed. The stub casts its arguments to void to avoid causing "unused variable" or "set but not used" warnings. Fixes: ae638551ab64 ("selftests/resctrl: Add non-contig

[PATCH v4 3/4] selftests/x86: don't clobber CFLAGS

2024-09-03 Thread Ilpo Järvinen
initialization before inclusion of lib.mk but leave adding KHDR_INCLUDES into CFLAGS into the existing position because KHDR_INCLUDES might be generated inside lib.mk. Signed-off-by: Ilpo Järvinen --- v4: - New patch tools/testing/selftests/x86/Makefile | 4 +++- 1 file changed, 3 insertions

[PATCH v4 2/4] selftests/resctrl: Always initialize ecx to avoid build warnings

2024-09-03 Thread Ilpo Järvinen
To avoid warnings when __cpuid_count() is an empty stub, always initialize ecx because it is used in the return statement. Signed-off-by: Ilpo Järvinen Reviewed-by: Muhammad Usama Anjum --- tools/testing/selftests/resctrl/cat_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v4 1/4] selftests/resctrl: Generalize non-contiguous CAT check

2024-09-03 Thread Ilpo Järvinen
vendors. Signed-off-by: Ilpo Järvinen Reviewed-by: Muhammad Usama Anjum --- tools/testing/selftests/resctrl/cat_test.c | 26 +- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl

[PATCH v4 0/4] selftests: Fix cpuid / vendor checking build issues

2024-09-03 Thread Ilpo Järvinen
reason for void casts in the stub Ilpo Järvinen (4): selftests/resctrl: Generalize non-contiguous CAT check selftests/resctrl: Always initialize ecx to avoid build warnings selftests/x86: don't clobber CFLAGS kselftest: Provide __cpuid_count() stub on non-x86 archs tools/testing

Re: [PATCH v3 3/3] kselftest: Provide __cpuid_count() stub on non-x86 archs

2024-09-03 Thread Ilpo Järvinen
On Thu, 29 Aug 2024, Ilpo Järvinen wrote: > Building resctrl selftest fails on ARM because it uses __cpuid_count() > that fails the build with error: > > CC resctrl_tests > In file included from resctrl.h:24, > from cat_test.c:11: > In function '

[PATCH 0/5] selftests/resctrl: Fixes to failing tests

2023-09-11 Thread Ilpo Järvinen
developed and should apply cleanly at least on top the benchmark cleanup series (might apply cleanly also w/o the benchmark series, I didn't test). Ilpo Järvinen (5): selftests/resctrl: Extend signal handler coverage to unmount on receiving signal selftests/resctrl: Remove duplicate fe

Re: [RFC PATCH 0/8]: uninline & uninline

2008-02-23 Thread Ilpo Järvinen
On Sat, 23 Feb 2008, Andi Kleen wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: > > > >> -41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR > > > > This is a surprise. I expect that the -mm-only > > profile-likely-unlikely-macros.patch is the cause of this and mainline > > doesn't have t

Re: [RFC PATCH 0/8]: uninline & uninline

2008-02-23 Thread Ilpo Järvinen
On Sat, 23 Feb 2008, Andrew Morton wrote: > On Wed, 20 Feb 2008 15:47:10 +0200 "Ilpo J__rvinen" <[EMAIL PROTECTED]> wrote: > > > -41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR > > This is a surprise. It surprised me as well, there were something like 10 bytes I just couldn't explain i

Re: [RFC PATCH 8/8] Jhash in too big for inlining, move under lib/

2008-02-23 Thread Ilpo Järvinen
On Sat, 23 Feb 2008, Andrew Morton wrote: > On Wed, 20 Feb 2008 15:47:18 +0200 "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote: > > > vmlinux.o: > > 62 functions changed, 66 bytes added, 10935 bytes removed, diff: -10869 > > > > ...+ these to lib/jh

Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Ilpo Järvinen
On Wed, 20 Feb 2008, Vlad Yasevich wrote: > Ilpo Järvinen wrote: > > I added inline to sctp_add_cmd and appropriate comment there to > > avoid adding another call into the call chain. This works at least > > with "gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)". Al

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Ilpo Järvinen
On Wed, 20 Feb 2008, Jan Engelhardt wrote: > > On Feb 20 2008 17:27, Patrick McHardy wrote: > >> Striking. How can this even happen? A callsite which calls > >> > >> dev_alloc_skb(n) > >> > >> is just equivalent to > >> > >> __dev_alloc_skb(n, GFP_ATOMIC); > >> > >> which means there's like

[RFC PATCH 5/8] [NET]: uninline dst_release

2008-02-20 Thread Ilpo Järvinen
Codiff stats: -16420 187 funcs, 103 +, 16523 -, diff: -16420 --- dst_release Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/dst.h | 10 +- net/core/dst.c| 10 ++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/include/net/dst.h b/i

[RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf

2008-02-20 Thread Ilpo Järvinen
es removed, diff: -6593 Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Cc: Vlad Yasevich <[EMAIL PROTECTED]> --- include/net/sctp/sm.h |8 ++-- net/sctp/command.c| 12 +++- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/include/net/sctp/sm.h b

[RFC PATCH 8/8] Jhash in too big for inlining, move under lib/

2008-02-20 Thread Ilpo Järvinen
vmlinux.o: 62 functions changed, 66 bytes added, 10935 bytes removed, diff: -10869 ...+ these to lib/jhash.o: jhash_3words: 112 jhash2: 276 jhash: 475 select for networking code might need a more fine-grained approach. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- drivers/infi

[RFC PATCH 2/8] [NET]: uninline skb_pull, de-bloats a lot

2008-02-20 Thread Ilpo Järvinen
-28162 354 funcs, 3005 +, 31167 -, diff: -28162 --- skb_pull Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/skbuff.h | 15 +-- net/core/skbuff.c | 16 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/include

[RFC PATCH 6/8] [NET]: uninline skb_trim, de-bloats

2008-02-20 Thread Ilpo Järvinen
-10976 209 funcs, 123 +, 11099 -, diff: -10976 --- skb_trim Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/skbuff.h | 16 +--- net/core/skbuff.c | 16 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/include

[RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Ilpo Järvinen
-23668 392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/skbuff.h | 17 + net/core/skbuff.c | 18 ++ 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include

[RFC PATCH 1/8] [NET]: uninline skb_put, de-bloats a lot

2008-02-20 Thread Ilpo Järvinen
() should be rethought but I don't have a clue how to do that. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/skbuff.h | 20 +--- net/core/skbuff.c | 21 + 2 files changed, 22 insertions(+), 19 deletions(-) diff --git a/in

[RFC PATCH 4/8] [NET]: uninline skb_push, de-bloats a lot

2008-02-20 Thread Ilpo Järvinen
-21593 356 funcs, 2418 +, 24011 -, diff: -21593 --- skb_push Again, current_text_addr() needs to addressed. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/skbuff.h | 18 +- net/core/skbuff.c | 19 +++ 2 files changed, 20 inse

[RFC PATCH 0/8]: uninline & uninline

2008-02-20 Thread Ilpo Järvinen
Hi all, I run some lengthy tests to measure cost of inlines in headers under include/, simple coverage calculations yields to 89% but most of the failed compiles are due to preprocessor cutting the tested block away anyway. Test setup: v2.6.24-mm1, make allyesconfig, 32-bit x86, gcc (GCC) 4.1.2 20

[RFC PATCH 0/8]: uninline & uninline

2008-02-20 Thread Ilpo Järvinen
Hi all, I run some lengthy tests to measure cost of inlines in headers under include/, simple coverage calculations yields to 89% but most of the failed compiles are due to preprocessor cutting the tested block away anyway. Test setup: v2.6.24-mm1, make allyesconfig, 32-bit x86, gcc (GCC) 4.1.2 20

Re: [PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread Ilpo Järvinen
On Wed, 13 Feb 2008, linux-os (Dick Johnson) wrote: > > On Wed, 13 Feb 2008, [iso-8859-1] Ilpo Järvinen wrote: > > > They're defined later on in the same file with bodies and > > nothingin between needs them. > > > > Signed-off-by: Ilpo Järvinen <[EM

[PATCH] fs/coda: remove static inline forward declarations

2008-02-13 Thread Ilpo Järvinen
They're defined later on in the same file with bodies and nothingin between needs them. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/linux/coda_linux.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/coda_linux.h b/in

Re: git tree urls

2008-02-08 Thread Ilpo Järvinen
On Fri, 8 Feb 2008, Jan Engelhardt wrote: > > On Feb 8 2008 22:34, ael wrote: > > > >Sure, I looked there in some depth. But some/most are special purpose or > > 'locals'. One needs a map for the "main" repositories... > > Indeed, a page on kernelnewbies.org with the most important repositories

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Ilpo Järvinen
On Thu, 24 Jan 2008, Ilpo Järvinen wrote: > And anyway, there were some fackets_out related > problems reported as well and this doesn't help for that but I think I've > lost track of who was seeing it due to large number of reports :-), could > somebody refresh my memo

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Ilpo Järvinen
its which won't be set with it at all. Effectively, NewReno should always exists after the first iteration anyway (or immediately if there's already head in lost_out. This was fixed earlier in net-2.6.25 but got reverted among other stuff and I didn't notice that this is still ne

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Ilpo Järvinen wrote: > On Wed, 23 Jan 2008, Dave Young wrote: > > > On Jan 23, 2008 3:41 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > > > On Tue, 22 Jan 2008, David Miller wrote: > > > > > > > From: "Dav

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-23 Thread Ilpo Järvinen
On Wed, 23 Jan 2008, Dave Young wrote: > On Jan 23, 2008 3:41 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > On Tue, 22 Jan 2008, David Miller wrote: > > > > > From: "Dave Young" <[EMAIL PROTECTED]> > > > Date: Wed, 23 Jan 20

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Ilpo Järvinen
On Tue, 22 Jan 2008, David Miller wrote: > From: "Dave Young" <[EMAIL PROTECTED]> > Date: Wed, 23 Jan 2008 09:44:30 +0800 > > > On Jan 22, 2008 6:47 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > [PATCH] [TCP]: debug S+L > > >

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Ilpo Järvinen
On Tue, 22 Jan 2008, Dave Young wrote: > On Jan 22, 2008 12:37 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > > > On Jan 22, 2008 5:14 AM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > > > On Mon, 21 Jan 2008, Dave Young wrote: > > > >

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-21 Thread Ilpo Järvinen
On Mon, 21 Jan 2008, Dave Young wrote: > Please see the kernel messages following,(trigged while using some qemu > session) > BTW, seems there's some e100 error message as well. > > PCI: Setting latency timer of device :00:1b.0 to 64 > e100: Intel(R) PRO/100 Network Driver, 3.5.23-k4-NAPI >

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-14 Thread Ilpo Järvinen
On Mon, 14 Jan 2008, Ilpo Järvinen wrote: > On Fri, 11 Jan 2008, Zhang, Yanmin wrote: > > > On Wed, 2008-01-09 at 17:35 +0800, Zhang, Yanmin wrote: > > > > > > As a matter of fact, 2.6.23 has about 6% regression and 2.6.24-rc's > > > regression is

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-14 Thread Ilpo Järvinen
On Fri, 11 Jan 2008, Zhang, Yanmin wrote: > On Wed, 2008-01-09 at 17:35 +0800, Zhang, Yanmin wrote: > > The regression is: > > 1)stoakley with 2 qual-core processors: 11%; > > 2)Tulsa with 4 dual-core(+hyperThread) processors:13%; > I have new update on this issue and also cc to netdev maillist.

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Ilpo Järvinen
On Thu, 20 Dec 2007, James Nichols wrote: > > You'd probably should also investigate the Linux kernel, > > especially the size and locks of the components of the Sack data > > structures and what happens to those data structures after Sack is > > disabled (presumably the Sack data structure is in

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Ilpo Järvinen
On Thu, 20 Dec 2007, James Nichols wrote: > > I still dont understand. > > > > "tcpdump -p -n -s 1600 -c 1" doesnt reveal User data at all. > > > > Without any exact data from you, I am afraid nobody can help. > > Oh, I didn't see that you specified specific options. I'll still have > to ano

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-19 Thread Ilpo Järvinen
On Wed, 19 Dec 2007, Eric Dumazet wrote: > James Nichols a écrit : > > On 12/19/07, Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > James Nichols a écrit : > > > > > So you see outgoing SYN packets, but no SYN replies coming from the > > > > > remote > > > > > peer ? (you mention ACKS, but the firs

[PATCH net-2.6.25] Revert recent TCP work

2007-12-14 Thread Ilpo Järvinen
On Fri, 14 Dec 2007, Ilpo Järvinen wrote: > So, I might soon prepare a revert patch for most of the questionable > TCP parts and ask Dave to apply it (and drop them fully during next > rebase) unless I suddently figure something out soon which explains > all/most of the problems,

Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment

2007-12-13 Thread Ilpo Järvinen
On Thu, 13 Dec 2007, Cedric Le Goater wrote: > I got this one while compiling on NFS. > > C. > > kernel BUG at /home/legoater/linux/2.6.24-rc4-mm1/include/net/tcp.h:1480! I'm not exactly sure what patches you have applied and which patches are not, with rc4-mm1 there are two patches (first one

Re: 2.6.24-rc4-mm1

2007-12-10 Thread Ilpo Järvinen
On Mon, 10 Dec 2007, Ilpo Järvinen wrote: > Dave, please include this one to net-2.6.25. ... > -- > [PATCH] [TCP]: Fix fack_count miscountings (multiple places) I've better version of this coming up, so Dave please don't put this one into net-2.6.25 (noticed that both t

Re: 2.6.24-rc4-mm1

2007-12-10 Thread Ilpo Järvinen
x27;t return it because it's on the other list already). These manifest as fackets_out counting error later on, the second-order effects are very hard to track, so it may fix all out-standing TCP bug reports. 2) Prev == NULL check was wrong way around 3) Last skb's fack count was incorrectly

Re: 2.6.24-rc4-mm1

2007-12-07 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, David Miller wrote: > From: Reuben Farrelly <[EMAIL PROTECTED]> > Date: Thu, 06 Dec 2007 17:59:37 +1100 > > > On 5/12/2007 4:17 PM, Andrew Morton wrote: > > > - Lots of device IDs have been removed from the e1000 driver and moved > > > over > > > to e1000e. So if your e100

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-08 Thread Ilpo Järvinen
On Thu, 8 Nov 2007, Rainer Jochem wrote: > @@ -620,6 +622,17 @@ ic_dhcp_init_options(u8 *options) > *e++ = sizeof(ic_req_params); > memcpy(e, ic_req_params, sizeof(ic_req_params)); > e += sizeof(ic_req_params); > + > + // Send it only if the ac

Re: [2.6 patch] make tcp_match_skb_to_sack() static

2007-10-24 Thread Ilpo Järvinen
On Wed, 24 Oct 2007, Adrian Bunk wrote: > tcp_match_skb_to_sack() can become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > [...snip...] Thanks, I should have noticed that right from the beginning... Added DaveM to recipients. -- i. - To unsubscribe from this list: send the lin

Re: latest checkpatch

2007-10-19 Thread Ilpo Järvinen
On Thu, 18 Oct 2007, Ingo Molnar wrote: > > * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > > it's perfectly legitimate, in fact more robust. So if checkpatch.pl > > > wants to make any noise about such constructs it should warn about > > > the _lack_ of curly braces in every multi-line cond

[PATCH] Fix if (...) \n #if... cases missing semicolons when false

2007-10-19 Thread Ilpo Järvinen
A good candidate to checkpatch.pl's check list, btw. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- drivers/char/watchdog/wdt.c |3 ++- drivers/char/watchdog/wdt_pci.c |3 ++- drivers/scsi/osst.c |6 -- 3 files changed, 8 insertions(+), 4 deletio

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

2007-10-14 Thread Ilpo Järvinen
On Sat, 13 Oct 2007, Willy Tarreau wrote: > On Sat, Oct 13, 2007 at 07:50:36PM +0200, Adrian Bunk wrote: > > On Sat, Oct 13, 2007 at 07:22:14PM +0200, Willy Tarreau wrote: > > >... > > > Thanks for your help, I really appreciate it. In fact, I've reviewed them > > > four, but two of them did not ap

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

2007-10-13 Thread Ilpo Järvinen
On Sat, 13 Oct 2007, Willy Tarreau wrote: > It's possible that new SACK blocks that should trigger new LOST > markings arrive with new data (which previously made is_dupack > false). In addition, I think this fixes a case where we get > a cumulative ACK with enough SACK blocks to trigger the fast

Re: top displaying 9999% CPU usage

2007-10-03 Thread Ilpo Järvinen
On Wed, 3 Oct 2007, Ilpo Järvinen wrote: > On Wed, 3 Oct 2007, Frans Pop wrote: > > > The only change is in 2 consecutive columns: "2911 502" -> "2912 500". > > Is processor usage calculated from those? Can someone explain how? > > The latte

Re: top displaying 9999% CPU usage

2007-10-03 Thread Ilpo Järvinen
On Wed, 3 Oct 2007, Frans Pop wrote: > On Wednesday 03 October 2007, you wrote: > > Try to capture the i/o log with the following command: > > strace -o top.log top > > Thanks for the suggestion. > > > This will show for sure whether the kernel gives out incorrect data or > > top misinterprets t

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-10-02 Thread Ilpo Järvinen
> On Tue, 2 Oct 2007, Ilpo Järvinen wrote: > > > I'm currently out of ideas where it could come from... Hmm, there seems to be off-by-one in tcp_retrans_try_collapse after all, or in fact, two of them. I'll post patch for this tomorrow... -- i.

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-10-02 Thread Ilpo Järvinen
On Tue, 2 Oct 2007, Ilpo Järvinen wrote: > I'm currently out of ideas where it could come from... so lets try > brute-force checking as your test case is not very high-speed... This > could hide it though... :-( > > Please put the patch below on top of clean rc8-mm2 (it in

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-10-02 Thread Ilpo Järvinen
On Mon, 1 Oct 2007, Cedric Le Goater wrote: > got it ! > > r3-06.test.meiosys.com login: WARNING: at > /home/legoater/linux/2.6.23-rc8-mm2/net/ipv4/tcp_input.c:2314 > tcp_fastretrans_alert() > > Call Trace: >[] tcp_ack+0xcd6/0x18af [...snip...] > > TCP 0 Hmm, so it's SACK then... > I w

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-29 Thread Ilpo Järvinen
On Sat, 29 Sep 2007, Cedric Le Goater wrote: > Ilpo Järvinen wrote: > > On Fri, 28 Sep 2007, Ilpo Järvinen wrote: > >> On Fri, 28 Sep 2007, Cedric Le Goater wrote: > >> > >>> I just found that warning in my logs. It seems that it's

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-29 Thread Ilpo Järvinen
On Fri, 28 Sep 2007, Ilpo Järvinen wrote: > On Fri, 28 Sep 2007, Cedric Le Goater wrote: > > > I just found that warning in my logs. It seems that it's been > > happening since rc7-mm1 at least. > > > > WARNING: at /home/legoater/linux/2.6.2

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-28 Thread Ilpo Järvinen
On Fri, 28 Sep 2007, Cedric Le Goater wrote: > Hello ! > > Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ > > I just found that warning in my logs. It seems that it's been > happening since rc7-mm1 at least. > > Thanks ! > >

Re: TCP Spike

2007-09-27 Thread Ilpo Järvinen
On Thu, 27 Sep 2007, Majumder, Rajib wrote: > We have observed 40ms latency spikes in TCP connections in "burst" type of > traffic. > This affects regular TCP sockets. Are segments being sent full-sized, or is there perhaps some Nagle component in it as well? I.e., are the applications using TC

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-16 Thread Ilpo Järvinen
On Thu, 16 Aug 2007, Herbert Xu wrote: > We've been through that already. If it's a busy-wait it > should use cpu_relax. I looked around a bit by using some command lines and ended up wondering if these are equal to busy-wait case (and should be fixed) or not: ./drivers/telephony/ixj.c 6674:

Re: drivers/infiniband/mlx/mad.c misplaced ;

2007-08-16 Thread Ilpo Järvinen
...I guess those guys hunting for broken busyloops in the other thread could also benefit from similar searching commands introduced in this thread... ...Ccing Satyam to caught their attention too. > On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > > > > There's more than a few

Re: v2.6.23-rc2 locks up during boot (without acpi=off)

2007-08-12 Thread Ilpo Järvinen
On Sun, 12 Aug 2007, Andrew Morton wrote: > On Sun, 12 Aug 2007 20:15:51 +0300 (EEST) "Ilpo Järvinen" <[EMAIL PROTECTED]> > wrote: > > > Hmm, it was really worth of it, I did: > > $ git-fetch linus > > $ git-reset --hard linus > > [...make &

Re: v2.6.23-rc2 locks up during boot (without acpi=off)

2007-08-12 Thread Ilpo Järvinen
On Sun, 12 Aug 2007, Andrew Morton wrote: > On Sun, 12 Aug 2007 14:20:46 +0300 (EEST) "Ilpo Järvinen" <[EMAIL PROTECTED]> > wrote: > > On Sun, 12 Aug 2007, Andrew Morton wrote: > > > On Sat, 11 Aug 2007 15:39:30 +0300 (EEST) "Ilpo Järvinen" <

Re: v2.6.23-rc2 locks up during boot (without acpi=off)

2007-08-12 Thread Ilpo Järvinen
On Sun, 12 Aug 2007, Andrew Morton wrote: > On Sat, 11 Aug 2007 15:39:30 +0300 (EEST) "Ilpo Järvinen" <[EMAIL PROTECTED]> > wrote: > > > I noticed that v2.6.23-rc1 locks up during boot, same thing happens now > > with the latest linus' tree (+net-2.6.2

v2.6.23-rc2 locks up during boot (without acpi=off)

2007-08-11 Thread Ilpo Järvinen
I noticed that v2.6.23-rc1 locks up during boot, same thing happens now with the latest linus' tree (+net-2.6.24 and tcp-2.6 tree stuff on top of it; in -rc1 test they weren't though). The exact location of hang varies a bit though. No OOPS, does not respond to sysrq or anything else besides res

Re: [PATCH 00/23] per device dirty throttling -v8

2007-08-04 Thread Ilpo Järvinen
On Sat, 4 Aug 2007, Ingo Molnar wrote: > * Alan Cox <[EMAIL PROTECTED]> wrote: > > > People just need to know about the performance differences - very few > > realise its more than a fraction of a percent. I'm sure Gentoo will > > use relatime the moment anyone knows its > 5% 8) > > noatime,no

Re: TCP SACK issue, hung connection, tcpdump included

2007-08-02 Thread Ilpo Järvinen
On Tue, 31 Jul 2007, Darryl L. Miles wrote: > I've been able to capture a tcpdump from both ends during the problem and its > my belief there is a bug in 2.6.20.1 (at the client side) in that it issues a > SACK option for an old sequence which the current window being advertised is > beyond it. T

Re: TCP SACK issue, hung connection, tcpdump included

2007-07-29 Thread Ilpo Järvinen
On Sun, 29 Jul 2007, Willy Tarreau wrote: > On Sun, Jul 29, 2007 at 12:28:04PM +0300, Ilpo Järvinen wrote: > > > [...snip...] > > > > > BTW, some information are missing. It would have been better if the trace > > > had been read with tcpdump -Svv. W

Re: TCP SACK issue, hung connection, tcpdump included

2007-07-29 Thread Ilpo Järvinen
On Sun, 29 Jul 2007, Willy Tarreau wrote: > On Sun, Jul 29, 2007 at 11:26:00AM +0300, Ilpo Järvinen wrote: > > On Sun, 29 Jul 2007, Willy Tarreau wrote: > > > > > On Sun, Jul 29, 2007 at 06:59:26AM +0100, Darryl L. Miles wrote: > > > > CLIENT = Linux 2.6.20.1

Re: TCP SACK issue, hung connection, tcpdump included

2007-07-29 Thread Ilpo Järvinen
On Sun, 29 Jul 2007, Willy Tarreau wrote: > On Sun, Jul 29, 2007 at 06:59:26AM +0100, Darryl L. Miles wrote: > > CLIENT = Linux 2.6.20.1-smp [Customer build] > > SERVER = Linux 2.6.9-55.ELsmp [Red Hat Enterprise Linux AS release 4 > > (Nahant Update 5)] > > > > The problems start around time ind

Re: kernel BUG at include/net/tcp.h:739

2007-05-02 Thread Ilpo Järvinen
otentially a negative packets in flight (= large one) disturbing cwnd compares. [PATCH] [TCP]: Use S+L catcher only with SACK for now TCP has a transitional state when SACK is not in use during which this invariant is temporarily broken. Without SACK, tcp_clean_rtx_queue does not decrement sac