Re: [PATCH next v2 5/5] locking/osq_lock: Optimise decode_cpu() and per_cpu_ptr().

2024-01-02 Thread Ingo Molnar
* David Laight wrote: > per_cpu_ptr() indexes __per_cpu_offset[] with the cpu number. > This requires the cpu number be 64bit. > However the value is osq_lock() comes from a 32bit xchg() and there > isn't a way of telling gcc the high bits are zero (they are) so > there will always be an

Re: [PATCH next v2 4/5] locking/osq_lock: Avoid writing to node->next in the osq_lock() fast path.

2024-01-02 Thread Ingo Molnar
* David Laight wrote: > When osq_lock() returns false or osq_unlock() returns static > analysis shows that node->next should always be NULL. > This means that it isn't necessary to explicitly set it to NULL > prior to atomic_xchg(>tail, curr) on extry to osq_lock(). > > Just in case there a

Re: [PATCH next 4/5] locking/osq_lock: Optimise per-cpu data accesses.

2023-12-30 Thread Ingo Molnar
* Waiman Long wrote: > On 12/29/23 15:57, David Laight wrote: > > this_cpu_ptr() is rather more expensive than raw_cpu_read() since > > the latter can use an 'offset from register' (%gs for x86-84). > > > > Add a 'self' field to 'struct optimistic_spin_node' that can be > > read with

Re: [PATCH v3] x86/platform/uv: refactor deprecated strcpy and strncpy

2023-09-14 Thread Ingo Molnar
* Hans de Goede wrote: > >> Which IMHO is much more readable then what has landed now. But since > >> v2 has already landed I guess the best thing is just to stick with > >> what we have upstream now... > > > > Well, how about we do a delta patch with all the changes you suggested? > > I'm

Re: [PATCH v7] x86/mce: retrieve poison range from hardware

2022-08-03 Thread Ingo Molnar
ad of consulting the input > struct cper_sec_mem_err record. So change to rely on hardware whenever > support is available. > > Link: > https://lore.kernel.org/r/7ed50fd8-521e-cade-77b1-738b8bfb8...@oracle.com > > Reviewed-by: Dan Williams > Reviewed-by: Ingo Mol

Re: [PATCH v6] x86/mce: retrieve poison range from hardware

2022-08-02 Thread Ingo Molnar
& CPER_MEM_VALID_PA_MASK) > + lsb = find_first_bit((const unsigned long *) > + _err->physical_addr_mask, PAGE_SHIFT); I think we can write this in a shorter form and in a single line: lsb = find_first_bit((void *)_err->physical_addr_mas

[tip: x86/platform] x86/platform/uv: Fix !KEXEC build failure

2021-04-20 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the x86/platform branch of tip: Commit-ID: c2209ea55612efac75de0a58ef5f7394fae7fa0f Gitweb: https://git.kernel.org/tip/c2209ea55612efac75de0a58ef5f7394fae7fa0f Author:Ingo Molnar AuthorDate:Tue, 20 Apr 2021 09:47:42 +02:00

[tip: x86/platform] x86/platform/uv: Remove dead !CONFIG_KEXEC_CORE code

2021-04-20 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the x86/platform branch of tip: Commit-ID: 27743f01e391ee1d80e3be2a09237507b965f91b Gitweb: https://git.kernel.org/tip/27743f01e391ee1d80e3be2a09237507b965f91b Author:Ingo Molnar AuthorDate:Tue, 20 Apr 2021 10:03:02 +02:00

Re: [GIT PULL tip/core/rcu] RCU, LKMM, and KCSAN commits for v5.13

2021-04-11 Thread Ingo Molnar
* Paul E. McKenney wrote: > Hello, Ingo! > > This pull request contains changes for RCU, KCSAN, and LKMM. You can > pull the entire group using branch for-mingo. Or, if you prefer, you > can pull them separately, using for-mingo-rcu to pull the RCU changes, > for-mingo-kcsan to pull the

[GIT PULL] locking fixes

2021-04-11 Thread Ingo Molnar
Linus, Please pull the latest locking/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-2021-04-11 # HEAD: 6d48b7912cc72275dc7c59ff961c8bac7ef66a92 lockdep: Address clang -Wformat warning printing for %hd Two minor fixes: one for a Clang

[GIT PULL] x86 fixes

2021-03-28 Thread Ingo Molnar
with new GCC packages that turn on -fcf-protection - Fix SME memory encryption PTE encoding bug - AFAICT the code worked on 4K page sizes (level 1) but had the wrong shift at higher page level orders (level 2 and higher). Signed-off-by: Ingo Molnar Thanks, Ingo

[GIT PULL] locking fix

2021-03-28 Thread Ingo Molnar
Linus, Please pull the latest locking/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-2021-03-28 # HEAD: 291da9d4a9eb3a1cb0610b7f4480f5b52b1825e7 locking/mutex: Fix non debug version of mutex_lock_io_nested() Fix the non-debug

Re: [PATCH v3 07/11] perf: Add breakpoint information to siginfo on SIGTRAP

2021-03-25 Thread Ingo Molnar
* Marco Elver wrote: > > Yeah, so why cannot we allocate enough space from the signal > > handler user-space stack and put the attr there, and point to it > > from sig_info? > > > > The idea would be to create a stable, per-signal snapshot of > > whatever the perf_attr state is at the

Re: [PATCH v3 07/11] perf: Add breakpoint information to siginfo on SIGTRAP

2021-03-25 Thread Ingo Molnar
* Dmitry Vyukov wrote: > On Wed, Mar 24, 2021 at 3:05 PM Marco Elver wrote: > > > > On Wed, 24 Mar 2021 at 15:01, Peter Zijlstra wrote: > > > > > > One last try, I'll leave it alone now, I promise :-) > > > > This looks like it does what you suggested, thanks! :-) > > > > I'll still need to

Re: [PATCH] x86/apic: Rudimentary typo fixes

2021-03-25 Thread Ingo Molnar
* Bhaskar Chowdhury wrote: > s/preferrable/preferable/ > s/serivced/serviced/ > s/distributon/distribution/ > > Signed-off-by: Bhaskar Chowdhury > --- > arch/x86/kernel/apic/apic.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/apic/apic.c

Re: [PATCH, -v2] tracing: Fix various typos in comments

2021-03-23 Thread Ingo Molnar
* Steven Rostedt wrote: > On Tue, 23 Mar 2021 12:11:50 +0100 > Ingo Molnar wrote: > > > -v2 attached - I preemptively added your Reviewed-by as well, if > > that's fine. :-) > > > > Thanks, > > > > Ingo > > > >

[PATCH v3] tracing: Fix various typos in comments

2021-03-23 Thread Ingo Molnar
Fix ~59 single-word typos in the tracing code comments, and fix the grammar in a handful of places. Signed-off-by: Ingo Molnar Reviewed-by: Randy Dunlap Link: https://lore.kernel.org/r/2021034546.ga1981...@gmail.com --- arch/microblaze/include/asm/ftrace.h | 2 +- arch/nds32/kernel

Re: [PATCH] perf tools: Fix various typos in comments

2021-03-23 Thread Ingo Molnar
Here's the delta between -v1 and -v2, in case you already have -v1 or want to review the changes only: --- tools/perf/arch/arm64/util/machine.c | 8 tools/perf/examples/bpf/augmented_raw_syscalls.c | 4 ++--

[PATCH, -v2] perf tools: Fix various typos in comments

2021-03-23 Thread Ingo Molnar
* Ingo Molnar wrote: > Fix ~81 single-word typos in the perf tooling code - accumulated over the > years. Found a few more: => From: Ingo Molnar Date: Sun, 21 Mar 2021 12:37:34 +0100 Subject: [PATCH] perf tools: Fix various typos in comments Fix ~124 single-w

Re: [PATCH] locking/mutex: Remove repeated declaration

2021-03-23 Thread Ingo Molnar
* Shaokun Zhang wrote: > Commit 0cd39f4600ed ("locking/seqlock, headers: Untangle the spaghetti > monster") > introduces 'struct ww_acquire_ctx' again, remove the repeated declaration. > > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Will Deacon > Cc: Waima

Re: [PATCH] rcu: Fix various typos in comments

2021-03-23 Thread Ingo Molnar
* Paul E. McKenney wrote: > > > * there are no read-side primitives analogous to rcu_read_lock() and > > > * rcu_read_unlock() because this primitive is intended to determine > > > * that all tasks have passed through a safe state, not so much for > > > - * data-strcuture synchronization. >

[PATCH, -v2] tracing: Fix various typos in comments

2021-03-23 Thread Ingo Molnar
ling too, I'll leave this one alone. > > * trace_array_printk() can be used, as it will not add noise to the > > * top level tracing buffer. > > and at first I skipped over these, but I'll go back and mention them anyway: Fixed. -v2 attached - I preemptively added your Revie

Re: [PATCH -next] x86: Fix unused variable 'msr_val' warning

2021-03-22 Thread Ingo Molnar
* Michael Kelley wrote: > From: Ingo Molnar Sent: Monday, March 22, 2021 > 2:08 PM > > > > * Xu Yihang wrote: > > > > > Fixes the following W=1 kernel build warning(s): > > > arch/x86/hyperv/hv_spinlock.c:28:16: warning: variable 'msr_val' set

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Ingo Molnar
* Martin Sebor wrote: > > I.e. the real workaround might be to turn off the > > -Wstringop-overread-warning, > > until GCC-11 gets fixed? > > In GCC 10 -Wstringop-overread is a subset of -Wstringop-overflow. > GCC 11 breaks it out as a separate warning to make it easier to > control. Both

[tip: timers/core] timekeeping, clocksource: Fix various typos in comments

2021-03-22 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the timers/core branch of tip: Commit-ID: 4bf07f6562a01a488877e05267808da7147f44a5 Gitweb: https://git.kernel.org/tip/4bf07f6562a01a488877e05267808da7147f44a5 Author:Ingo Molnar AuthorDate:Mon, 22 Mar 2021 22:39:03 +01:00

[PATCH] rcu: Fix various typos in comments

2021-03-22 Thread Ingo Molnar
Hi Paul, Was working on automation to make it a bit more straightforward to fix typos within comments (which we tend to reintroduce during development), and here are the ones it found in the RCU code. Thanks, Ingo => From: Ingo Molnar Date: Mon, 22 Mar 2021 23:57:26 +0

[PATCH] tracing: Fix various typos in comments

2021-03-22 Thread Ingo Molnar
Fix ~59 single-word typos in the tracing code comments. Signed-off-by: Ingo Molnar Cc: Steven Rostedt Cc: linux-kernel@vger.kernel.org --- arch/microblaze/include/asm/ftrace.h | 2 +- arch/nds32/kernel/ftrace.c | 2 +- arch/powerpc/include/asm/ftrace.h| 4 ++-- arch/sh

[PATCH, -v3] mm: Fix typos in comments

2021-03-22 Thread Ingo Molnar
===> From: Ingo Molnar Date: Mon, 22 Mar 2021 21:52:03 +0100 Subject: [PATCH] mm: Fix typos in comments Fix ~94 single-word typos in locking code comments, plus a few very obvious grammar mistakes. Signed-off-by: Ingo Molnar Reviewed-by: Matthew Wilcox (Oracle) Reviewed-by: Randy D

Re: [PATCH -next] x86: Fix unused variable 'msr_val' warning

2021-03-22 Thread Ingo Molnar
* Xu Yihang wrote: > Fixes the following W=1 kernel build warning(s): > arch/x86/hyperv/hv_spinlock.c:28:16: warning: variable ‘msr_val’ set but not > used [-Wunused-but-set-variable] > unsigned long msr_val; > > As Hypervisor Top-Level Functional Specification states in chapter 7.5 >

[PATCH, -v2] mm: Fix typos in comments

2021-03-22 Thread Ingo Molnar
* Matthew Wilcox wrote: > On Mon, Mar 22, 2021 at 03:51:52AM +0100, Ingo Molnar wrote: > > +++ b/mm/huge_memory.c > > @@ -1794,7 +1794,7 @@ bool move_huge_pmd(struct vm_area_struct *vma, > > unsigned long old_addr, > > /* > > * Returns > > * - 0

Re: [PATCH] mm: Fix typos in comments

2021-03-22 Thread Ingo Molnar
* Randy Dunlap wrote: > On 3/21/21 7:51 PM, Ingo Molnar wrote: > > > > Fix ~93 single-word typos in locking code comments, plus a few very > > obvious grammar mistakes. > > > > Signed-off-by: Ingo Molnar > > Cc: Andrew Morton > > Cc: Rik van R

Re: [PATCH] x86: math-emu: Fix function cast warning

2021-03-22 Thread Ingo Molnar
* Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with 'make W=1', gcc points out that casting between > incompatible function types can be dangerous: > > arch/x86/math-emu/fpu_trig.c:1638:60: error: cast between incompatible > function types from ‘int (*)(FPU_REG *, u_char)’ {aka

Re: [PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Ingo Molnar
* Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns about using string operations on pointers that are > defined at compile time as offsets from a NULL pointer. Unfortunately > that also happens on the result of fix_to_virt(), which is a > compile-time constant for a constantn

Re: [PATCH V2] KVM: x86: A typo fix

2021-03-22 Thread Ingo Molnar
* Bhaskar Chowdhury wrote: > s/resued/reused/ > > > Signed-off-by: Bhaskar Chowdhury > --- > Changes from V1: > As Ingo found the correct word for replacement, so incorporating. > > arch/x86/include/asm/kvm_host.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] x86/entry: Fix a typo

2021-03-21 Thread Ingo Molnar
* Bhaskar Chowdhury wrote: > On 23:55 Sun 21 Mar 2021, Ingo Molnar wrote: > > > > * Randy Dunlap wrote: > > > > > > > > > > > On Mon, 22 Mar 2021, Bhaskar Chowdhury wrote: > > > > > > > > > > > s/swishes/

[tip: irq/core] irq: Fix typos in comments

2021-03-21 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the irq/core branch of tip: Commit-ID: a359f757965aafd0f58570de95dc6bc06cf12a9c Gitweb: https://git.kernel.org/tip/a359f757965aafd0f58570de95dc6bc06cf12a9c Author:Ingo Molnar AuthorDate:Mon, 22 Mar 2021 04:21:30 +01:00 Committer

[tip: core/entry] entry: Fix typos in comments

2021-03-21 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the core/entry branch of tip: Commit-ID: 97258ce902d1e1c396a4d7c38f6ae7085adb73c5 Gitweb: https://git.kernel.org/tip/97258ce902d1e1c396a4d7c38f6ae7085adb73c5 Author:Ingo Molnar AuthorDate:Mon, 22 Mar 2021 03:55:50 +01:00 Committer

[tip: sched/core] sched: Fix various typos

2021-03-21 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the sched/core branch of tip: Commit-ID: 3b03706fa621ce31a3e9ef6307020fde4e6aae16 Gitweb: https://git.kernel.org/tip/3b03706fa621ce31a3e9ef6307020fde4e6aae16 Author:Ingo Molnar AuthorDate:Thu, 18 Mar 2021 13:38:50 +01:00 Committer

[tip: locking/core] locking: Fix typos in comments

2021-03-21 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the locking/core branch of tip: Commit-ID: e2db7592be8e83df47519116621411e1056b21c7 Gitweb: https://git.kernel.org/tip/e2db7592be8e83df47519116621411e1056b21c7 Author:Ingo Molnar AuthorDate:Mon, 22 Mar 2021 02:35:05 +01:00

[PATCH] mm: Fix typos in comments

2021-03-21 Thread Ingo Molnar
Fix ~93 single-word typos in locking code comments, plus a few very obvious grammar mistakes. Signed-off-by: Ingo Molnar Cc: Andrew Morton Cc: Rik van Riel Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- include/linux/mm.h | 2 +- include/linux/vmalloc.h | 4 ++-- mm

Re: [PATCH] x86/entry: Fix a typo

2021-03-21 Thread Ingo Molnar
* Randy Dunlap wrote: > > > On Mon, 22 Mar 2021, Bhaskar Chowdhury wrote: > > > > > s/swishes/switch/ > > should be 'switches' Correct - this patch exchanged a typo for a grammar mistake... Thanks, Ingo

Re: [PATCH] KVM: x86: A typo fix

2021-03-21 Thread Ingo Molnar
* Randy Dunlap wrote: > > > On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: > > > > > s/resued/resumed/ > > > > Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap > > > > --- > > arch/x86/include/asm/kvm_host.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >

[tip: x86/cleanups] x86: Fix various typos in comments, take #2

2021-03-21 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 163b099146b85d1b05bd2eaa045acbeee25c29e4 Gitweb: https://git.kernel.org/tip/163b099146b85d1b05bd2eaa045acbeee25c29e4 Author:Ingo Molnar AuthorDate:Sun, 21 Mar 2021 22:28:53 +01:00

[tip: x86/cleanups] x86: Remove unusual Unicode characters from comments

2021-03-21 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: c681df88dcb12b1efd7e4efcfe498c5e9c31ce02 Gitweb: https://git.kernel.org/tip/c681df88dcb12b1efd7e4efcfe498c5e9c31ce02 Author:Ingo Molnar AuthorDate:Sun, 21 Mar 2021 23:32:33 +01:00

[GIT PULL] IRQ updates & fixes

2021-03-21 Thread Ingo Molnar
Linus, Please pull the latest irq/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-2021-03-21 # HEAD: 81e2073c175b887398e5bca6c004efa89983f58d genirq: Disable interrupts for force threaded handlers A change to robustify force-threaded IRQ

[PATCH] perf tools: Fix various typos in comments

2021-03-21 Thread Ingo Molnar
Fix ~81 single-word typos in the perf tooling code - accumulated over the years. Signed-off-by: Ingo Molnar --- tools/perf/Documentation/perf-buildid-cache.txt | 2 +- tools/perf/Documentation/perf-report.txt| 2 +- tools/perf/Documentation/perf-top.txt | 2 +- tools/perf

[GIT PULL] perf fixes

2021-03-21 Thread Ingo Molnar
Linus, Please pull the latest perf/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-2021-03-21 # HEAD: 2dc0572f2cef87425147658698dce2600b799bd3 perf/x86/intel: Fix unchecked MSR access error caused by VLBR_EVENT Boundary condition fixes for

[GIT PULL] locking fixes

2021-03-21 Thread Ingo Molnar
Linus, Please pull the latest locking/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-2021-03-21 # HEAD: 38c93587375053c5b9ef093f4a5ea754538cba32 static_call: Fix static_call_update() sanity check Locking fixes: - Get static calls &

[GIT PULL] EFI fixes

2021-03-21 Thread Ingo Molnar
Linus, Please pull the latest efi/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git efi-urgent-2021-03-21 # HEAD: 429257a430a0e81e9979256e0db718e35e7d9cee Merge tag 'efi-urgent-for-v5.12-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi into

Re: [PATCH v7 0/6] x86: Improve Minimum Alternate Stack Size

2021-03-20 Thread Ingo Molnar
* Len Brown wrote: > On Wed, Mar 17, 2021 at 6:45 AM Ingo Molnar wrote: > > > > > > * Ingo Molnar wrote: > > > > > > > > * Chang S. Bae wrote: > > > > > > > During signal entry, the kernel pushes data onto the normal us

Re: [PATCH v7 4/6] x86/entry: Enable random_kstack_offset support

2021-03-20 Thread Ingo Molnar
* Kees Cook wrote: > Allow for a randomized stack offset on a per-syscall basis, with roughly > 5-6 bits of entropy, depending on compiler and word size. Since the > method of offsetting uses macros, this cannot live in the common entry > code (the stack offset needs to be retained for the

Re: [PATCH-tip 0/5] locking/locktorture: Fix locktorture ww_mutex test problems

2021-03-19 Thread Ingo Molnar
* Waiman Long wrote: > This is a follow-up patch series for the previous patchset on fixing > locktorture ww_mutex test problem [1]. The first 3 patches of that > series were merged into tip. It turns out that the last one of the > three wasn't quite right. So this patch series revert the last

Re: [PATCH-tip 0/5] locking/locktorture: Fix locktorture ww_mutex test problems

2021-03-19 Thread Ingo Molnar
* Waiman Long wrote: > This is a follow-up patch series for the previous patchset on fixing > locktorture ww_mutex test problem [1]. The first 3 patches of that > series were merged into tip. It turns out that the last one of the > three wasn't quite right. So this patch series revert the last

[tip: x86/cleanups] x86: Fix various typos in comments

2021-03-18 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: d9f6e12fb0b7fcded0bac34b8293ec46f80dfc33 Gitweb: https://git.kernel.org/tip/d9f6e12fb0b7fcded0bac34b8293ec46f80dfc33 Author:Ingo Molnar AuthorDate:Thu, 18 Mar 2021 15:28:01 +01:00

[tip: sched/core] sched: Fix various typos

2021-03-18 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the sched/core branch of tip: Commit-ID: 7aacb8c62f621e9f6f1b5f11bb19eb37ddbf00e2 Gitweb: https://git.kernel.org/tip/7aacb8c62f621e9f6f1b5f11bb19eb37ddbf00e2 Author:Ingo Molnar AuthorDate:Thu, 18 Mar 2021 13:38:50 +01:00 Committer

Re: [PATCH -next] x86: Fix unused variable 'hi'

2021-03-18 Thread Ingo Molnar
* Xu Yihang wrote: > Fixes the following W=1 kernel build warning(s): > arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used > [-Wunused-but-set-variable] > > Reported-by: Hulk Robot > Signed-off-by: Xu Yihang > --- > arch/x86/hyperv/hv_apic.c | 3 ++- > 1 file

Re: [PATCH v2] smp: kernel/panic.c - silence warnings

2021-03-17 Thread Ingo Molnar
* Peter Zijlstra wrote: > Now, the C people figured that distinction was useless and allowed > sloppiness. But I still think there's merrit to that. And as > mentioned earlier, it is consistent with variable declarations. Fully agreed, and my other point was that it's also consistent with

Re: [PATCH] sched: replace if (cond) BUG() with BUG_ON()

2021-03-17 Thread Ingo Molnar
* Arnd Bergmann wrote: > On Wed, Mar 17, 2021 at 9:45 AM Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > * Jiapeng Chong wrote: > > > > > > > Fix the following coccicheck warnings: > > > > > > > > ./kernel/sched/core.c:8039:2-

Re: linux-next: build failure after merge of the tip tree

2021-03-17 Thread Ingo Molnar
* Borislav Petkov wrote: > On Thu, Mar 18, 2021 at 05:49:21AM +1100, Stephen Rothwell wrote: > > That fixes the powerpc build for me, thanks. > > Thx, adding your Tested-by and pushing out. I've pushed this out into tip:auto-latest as well, so that tomorrow's -next should pick this up

Re: [tip: sched/core] sched/wait_bit, mm/filemap: Increase page and bit waitqueue hash size

2021-03-17 Thread Ingo Molnar
; > https://git.kernel.org/tip/873d7c4c6a920d43ff82e44121e54053d4edba93 > > Author:Nicholas Piggin > > AuthorDate:Wed, 17 Mar 2021 17:54:27 +10:00 > > Committer: Ingo Molnar > > CommitterDate: Wed, 17 Mar 2021 09:32:30 +01:00 > > Groan. This does not even compile and Nichola

Re: [PATCH v7 0/6] x86: Improve Minimum Alternate Stack Size

2021-03-17 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Chang S. Bae wrote: > > > During signal entry, the kernel pushes data onto the normal userspace > > stack. On x86, the data pushed onto the user stack includes XSAVE state, > > which has grown over time as new features and larger re

Re: [PATCH v7 0/6] x86: Improve Minimum Alternate Stack Size

2021-03-17 Thread Ingo Molnar
* Chang S. Bae wrote: > During signal entry, the kernel pushes data onto the normal userspace > stack. On x86, the data pushed onto the user stack includes XSAVE state, > which has grown over time as new features and larger registers have been > added to the architecture. > > MINSIGSTKSZ is a

Re: [PATCH v2] smp: kernel/panic.c - silence warnings

2021-03-17 Thread Ingo Molnar
* He Ying wrote: > We found these warnings in kernel/panic.c by using sparse tool: > warning: symbol 'panic_smp_self_stop' was not declared. > warning: symbol 'nmi_panic_self_stop' was not declared. > warning: symbol 'crash_smp_send_stop' was not declared. > > To avoid them, add declarations

Re: [PATCH] sched: swait: use wake_up_process() instead of wake_up_state()

2021-03-17 Thread Ingo Molnar
* Mike Galbraith wrote: > On Tue, 2021-03-16 at 19:20 +0800, Wang Qing wrote: > > Why not just use wake_up_process(). > > IMO this is not an improvement. There are other places where explicit > TASK_NORMAL is used as well, and they're all perfectly clear as is. Arguably those could all be

Re: [PATCH v23 00/28] Control-flow Enforcement: Shadow Stack

2021-03-17 Thread Ingo Molnar
* Yu, Yu-cheng wrote: > On 3/16/2021 2:15 PM, Peter Zijlstra wrote: > > On Tue, Mar 16, 2021 at 08:10:26AM -0700, Yu-cheng Yu wrote: > > > Control-flow Enforcement (CET) is a new Intel processor feature that > > > blocks > > > return/jump-oriented programming attacks. Details are in "Intel

Re: unknown NMI on AMD Rome

2021-03-17 Thread Ingo Molnar
* Kim Phillips wrote: > On 3/16/21 2:53 PM, Peter Zijlstra wrote: > > On Tue, Mar 16, 2021 at 04:45:02PM +0100, Jiri Olsa wrote: > >> hi, > >> when running 'perf top' on AMD Rome (/proc/cpuinfo below) > >> with fedora 33 kernel 5.10.22-200.fc33.x86_64 > >> > >> we got unknown NMI messages: >

Re: [PATCH] sched: replace if (cond) BUG() with BUG_ON()

2021-03-17 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Jiapeng Chong wrote: > > > Fix the following coccicheck warnings: > > > > ./kernel/sched/core.c:8039:2-5: WARNING: Use BUG_ON instead of if > > condition followed by BUG. > > > > Reported-by: Abaci Robot > >

Re: [PATCH] sched: replace if (cond) BUG() with BUG_ON()

2021-03-17 Thread Ingo Molnar
* Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./kernel/sched/core.c:8039:2-5: WARNING: Use BUG_ON instead of if > condition followed by BUG. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > kernel/sched/core.c | 3 +-- > 1 file changed, 1

Re: [PATCH v2] Increase page and bit waitqueue hash size

2021-03-17 Thread Ingo Molnar
* Nicholas Piggin wrote: > The page waitqueue hash is a bit small (256 entries) on very big systems. A > 16 socket 1536 thread POWER9 system was found to encounter hash collisions > and excessive time in waitqueue locking at times. This was intermittent and > hard to reproduce easily with the

Re: [PATCH] sched: Warn on long periods of pending need_resched

2021-03-17 Thread Ingo Molnar
* Josh Don wrote: > +static inline u64 resched_latency_check(struct rq *rq) > +{ > + int latency_warn_ms = READ_ONCE(sysctl_resched_latency_warn_ms); > + bool warn_only_once = (latency_warn_ms == > RESCHED_DEFAULT_WARN_LATENCY_MS); > + u64 need_resched_latency, now = rq_clock(rq);

Re: [PATCH] sched: Warn on long periods of pending need_resched

2021-03-17 Thread Ingo Molnar
* Josh Don wrote: > From: Paul Turner > > CPU scheduler marks need_resched flag to signal a schedule() on a > particular CPU. But, schedule() may not happen immediately in cases > where the current task is executing in the kernel mode (no > preemption state) for extended periods of time. >

Re: linux-next: Fixes tags need some work in the tip tree

2021-03-08 Thread Ingo Molnar
* Stephen Rothwell wrote: > Hi all, > > In commit > > eca8f0c80a00 ("hrtimer: Update softirq_expires_next correctly after > __hrtimer_get_next_event()") > > Fixes tag > > Fixes: da70160462e ("hrtimer: Implement support for softirq based hrtimers") > > has these problem(s): > > -

Re: "struct perf_sample_data" alignment

2021-03-06 Thread Ingo Molnar
* Alexei Starovoitov wrote: > > This seems to be it... (completely untested) > > > > --- > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > > index 3f7f89ea5e51..918a296d2ca2 100644 > > --- a/include/linux/perf_event.h > > +++ b/include/linux/perf_event.h > > @@ -1032,7

Re: A note on the 5.12-rc1 tag

2021-03-06 Thread Ingo Molnar
* Linus Torvalds wrote: > But I also can heartily just recommend that people who already _did_ > start on rc1 to rebase their current - hopefully not extensive - work. Thanks for the heads-up - we just rebased about 50 commits in -tip to avoid this bug: our normal workflow is to jump on -rc1

[tip: x86/mm] smp: Micro-optimize smp_call_function_many_cond()

2021-03-02 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the x86/mm branch of tip: Commit-ID: dd75cba56151cb3b9dc7eac0221c9b1967f6ddb5 Gitweb: https://git.kernel.org/tip/dd75cba56151cb3b9dc7eac0221c9b1967f6ddb5 Author:Ingo Molnar AuthorDate:Tue, 02 Mar 2021 08:02:43 +01:00 Committer

Re: [PATCH v2 3/3] kernel/smp: add more data to CSD lock debugging

2021-03-02 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Mon, Mar 01, 2021 at 08:16:12PM +0100, Jürgen Groß wrote: > > > >https://lkml.kernel.org/r/20210220231712.2475218-2-na...@vmware.com > > > > > > They are already in tip locking/core (

Re: [PATCH v2 3/3] kernel/smp: add more data to CSD lock debugging

2021-03-02 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Mon, Mar 01, 2021 at 08:16:12PM +0100, Jürgen Groß wrote: > > >https://lkml.kernel.org/r/20210220231712.2475218-2-na...@vmware.com > > > > They are already in tip locking/core (Ingo applied them). > > I'm very tempted to undo that :-( Sorry about that - I'm

[PATCH] smp: Micro-optimize smp_call_function_many_cond()

2021-03-02 Thread Ingo Molnar
arch_send_call_function_ipi_mask(cfd->cpumask_ipi); > > Which will avoid the IPI when @last_cpu is idle. I turned this into the additional patch below, on top of Nadav's series. Thanks, Ingo ===> From: Ingo Molnar Date: Tue, 2 Mar 20

[GIT PULL] Performance events updates for v5.12

2021-02-17 Thread Ingo Molnar
Linus, Please pull the latest perf/core git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-core-2021-02-17 # HEAD: 8bcfdd7cad3dffdd340f9a79098cbf331eb2cd53 Merge branch 'perf/kprobes' into perf/core, to pick up finished branch The performance event updates

[GIT PULL] scheduler updates for v5.12

2021-02-17 Thread Ingo Molnar
Linus, Please pull the latest sched/core git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-core-2021-02-17 # HEAD: c5e6fc08feb2b88dc5dac2f3c817e1c2a4cafda4 sched,x86: Allow !PREEMPT_DYNAMIC Scheduler updates for v5.12: [ NOTE: unfortunately this tree had

[GIT PULL] core/mm: Fix (soft-)dirty bit management & clean up the TLB gather API

2021-02-17 Thread Ingo Molnar
Linus, Please pull the latest core/mm git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-mm-2021-02-17 # HEAD: 8cf55f24ce6cf90eb8828421e15e9efcd508bd2c x86/ldt: Use tlb_gather_mmu_fullmm() when freeing LDT page-tables These changes fix MM (soft-)dirty bit

[GIT PULL] locking updates for v5.12

2021-02-17 Thread Ingo Molnar
Linus, Please pull the latest locking/core git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-core-2021-02-17 # HEAD: 3765d01bab73bdb920ef711203978f02cd26e4da Merge branch 'for-mingo-lkmm' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu

[GIT PULL] RCU updates for v5.12

2021-02-17 Thread Ingo Molnar
Linus, Please pull the latest core/rcu git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-rcu-2021-02-17 # HEAD: 2b392cb11c0db645ba81a08b6a2e96c56ec1fc64 Merge branch 'for-mingo-nolibc' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu into

Re: linux-next: qemu boot failure after merge of the tip tree

2021-02-15 Thread Ingo Molnar
* Stephen Rothwell wrote: > Hi Peter, > > On Mon, 1 Feb 2021 15:40:12 +0100 Peter Zijlstra wrote: > > > > On Mon, Feb 01, 2021 at 01:04:30PM +, Valentin Schneider wrote: > > > On 01/02/21 20:09, Stephen Rothwell wrote: > > > > Hi all, > > > > > > > > > > Hi Stephen, > > > > > > >

Re: [GIT PULL tip/core/rcu] RCU, LKMM, and KCSAN commits for v5.12

2021-02-12 Thread Ingo Molnar
* Paul E. McKenney wrote: > Hello, Ingo! > > This pull request contains changes for RCU, KCSAN, LKMM, and nolibc. > You can pull the entire group using branch for-mingo. Or, if you prefer, > you can pull them separately, using for-mingo-rcu to pull the RCU changes, > for-mingo-kcsan to pull

Re: [tip: x86/entry] x86/entry: Build thunk_$(BITS) only if CONFIG_PREEMPTION=y

2021-01-21 Thread Ingo Molnar
Andrea Righi > AuthorDate:Thu, 14 Jan 2021 12:48:35 +01:00 > Committer: Ingo Molnar > CommitterDate: Thu, 21 Jan 2021 08:11:52 +01:00 > > x86/entry: Build thunk_$(BITS) only if CONFIG_PREEMPTION=y > > With CONFIG_PREEMPTION disabled, arch/x86/entry/th

[GIT PULL] locking fixes

2020-12-27 Thread Ingo Molnar
Linus, Please pull the latest locking/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-2020-12-27 # HEAD: 91ea62d58bd661827c328a2c6c02a87fa4aae88b softirq: Avoid bad tracing / lockdep interaction Misc fixes/updates: - Fix static keys usage

[GIT PULL] objtool fix

2020-12-27 Thread Ingo Molnar
Linus, Please pull the latest objtool/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git objtool-urgent-2020-12-27 # HEAD: 44f6a7c0755d8dd453c70557e11687bb080a6f21 objtool: Fix seg fault with Clang non-section symbols Fix a segfault that occurs when built

[GIT PULL] timer fixes

2020-12-27 Thread Ingo Molnar
Linus, Please pull the latest timers/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-2020-12-27 # HEAD: f6f5cd840ae782680c5e94048c72420e4e6857f9 timekeeping: Fix spelling mistake in Kconfig "fullfill" -> "fulfill" Update/fix two CPU sanity

[GIT PULL] scheduler fix

2020-12-27 Thread Ingo Molnar
Linus, Please pull the latest sched/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-2020-12-27 # HEAD: ae7927023243dcc7389b2d59b16c09cbbeaecc36 sched: Optimize finish_lock_switch() Fix a context switch performance regression. Thanks,

[tip: timers/core] ntp: Fix prototype in the !CONFIG_GENERIC_CMOS_UPDATE case

2020-12-13 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the timers/core branch of tip: Commit-ID: 3cabca87b329cbcbdf295be0094adbd72c7b1f67 Gitweb: https://git.kernel.org/tip/3cabca87b329cbcbdf295be0094adbd72c7b1f67 Author:Ingo Molnar AuthorDate:Sat, 12 Dec 2020 18:29:20 +01:00

[tip: timers/core] ntp: Fix build error

2020-12-12 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the timers/core branch of tip: Commit-ID: a3356a079da268cd35460d9bfe052c74383e179b Gitweb: https://git.kernel.org/tip/a3356a079da268cd35460d9bfe052c74383e179b Author:Ingo Molnar AuthorDate:Sat, 12 Dec 2020 18:29:20 +01:00

Re: linux-next: build failure after merge of the tip tree

2020-11-27 Thread Ingo Molnar
* Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > kernel/smp.c: In function 'csd_lock_wait_getcpu': > kernel/smp.c:133:13: error: 'call_single_data_t' {aka 'struct > __call_single_data'} has no member

Re: [RFC] Are you good with Lockdep?

2020-11-11 Thread Ingo Molnar
* Byungchul Park wrote: > PROBLEM 1) First of all, Lockdep gets disabled on the first detection. Lockdep disabling itself after the first warning was an intentional and deliberate design decision. (See more details below.) >What if there are more than two problems? So the usual way

Re: [tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

2020-11-08 Thread Ingo Molnar
* Borislav Petkov wrote: > On Sat, Nov 07, 2020 at 03:13:58PM -, tip-bot2 for Ingo Molnar wrote: > > The following commit has been merged into the perf/kprobes branch of tip: > > > > Commit-ID: a70a04b3844f59c29573a8581d5c263225060dd6 > > Gitweb: >

[tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

2020-11-07 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the perf/kprobes branch of tip: Commit-ID: a70a04b3844f59c29573a8581d5c263225060dd6 Gitweb: https://git.kernel.org/tip/a70a04b3844f59c29573a8581d5c263225060dd6 Author:Ingo Molnar AuthorDate:Sat, 07 Nov 2020 12:54:49 +01:00

Re: [GIT PULL] RCU changes for v5.10

2020-10-19 Thread Ingo Molnar
* Linus Torvalds wrote: > On Mon, Oct 12, 2020 at 7:14 AM Ingo Molnar wrote: > > > > Please pull the latest core/rcu git tree from: > > > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > > core-rcu-2020-10-12 > > I'v

Re: [PATCH 1/2] x86/insn: Fix some potential undefined behavior.

2020-10-15 Thread Ingo Molnar
* Ian Rogers wrote: > From: Numfor Mbiziwo-Tiapo > > If insn_init is given a NULL kaddr and 0 buflen then validate_next will > perform arithmetic on NULL, add a guard to avoid this. > > Don't perform unaligned loads in __get_next and __peek_nbyte_next as > these are forms of undefined

Re: [PATCH v1 00/15] Introduce threaded trace streaming for basic perf record operation

2020-10-14 Thread Ingo Molnar
* Alexey Budankov wrote: > > Patch set provides threaded trace streaming for base perf record > operation. Provided streaming mode (--threads) mitigates profiling > data losses and resolves scalability issues of serial and asynchronous > (--aio) trace streaming modes on multicore server

Re: [PATCH v6 02/25] objtool: Add a pass for generating __mcount_loc

2020-10-14 Thread Ingo Molnar
* Sami Tolvanen wrote: > From: Peter Zijlstra > > Add the --mcount option for generating __mcount_loc sections > needed for dynamic ftrace. Using this pass requires the kernel to > be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined > in Makefile. > > Link: >

  1   2   3   4   5   6   7   8   9   10   >