On 1/23/2024 8:46 PM, Andrew Davis wrote:
Use the device lifecycle managed allocation function. This helps prevent
mistakes like freeing out of order in cleanup functions and forgetting to
free on error paths.
Signed-off-by: Andrew Davis
Reviewed-by: Iuliana Prodan
Thanks,
Iulia
On 1/23/2024 8:46 PM, Andrew Davis wrote:
Use the device lifecycle managed allocation function. This helps prevent
mistakes like freeing out of order in cleanup functions and forgetting to
free on error paths.
Signed-off-by: Andrew Davis
Reviewed-by: Iuliana Prodan
Thanks,
Iulia
On 1/5/2024 6:01 PM, Ulf Hansson wrote:
Let's avoid the boilerplate code to manage the multiple PM domain case, by
converting into using dev_pm_domain_attach|detach_list().
Cc: Mathieu Poirier
Cc: Bjorn Andersson
Cc: Shawn Guo
Cc: Sascha Hauer
Cc: Iuliana Prodan
Cc: Daniel Baluta
Cc
On 1/5/2024 6:01 PM, Ulf Hansson wrote:
Let's avoid the boilerplate code to manage the multiple PM domain case, by
converting into using dev_pm_domain_attach|detach_list().
Cc: Mathieu Poirier
Cc: Bjorn Andersson
Cc: Shawn Guo
Cc: Sascha Hauer
Cc: Iuliana Prodan
Cc: Daniel Baluta
Cc
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
Signed-off-by: Iuliana Prodan
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 22
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp
From: Iuliana Prodan
Add the .find_loaded_rsc_table operation for i.MX DSP.
We need it for inter-process communication between DSP
and main core.
This callback is used to find the resource table (defined
in remote processor linker script) where the address of the
vrings along with the other
From: Iuliana Prodan
These patches are needed in order to support rpmsg on DSP when a
resource table is available.
Changes since v3:
- add reserve-memory nodes in imx8mp-evk.dts rather than .dtsi (patch 2/2)
Changes since v2:
- add newline between nodes in dtsi (patch 2/2)
Changes since v1
Hi Alexander,
On 10/11/2023 8:37 AM, Alexander Stein wrote:
Hi Iuliana,
Am Dienstag, 10. Oktober 2023, 11:09:29 CEST schrieb Iuliana Prodan (OSS):
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
Signed-off-by: Iuliana Prodan
---
arch
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
Signed-off-by: Iuliana Prodan
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
b/arch
From: Iuliana Prodan
Add the .find_loaded_rsc_table operation for i.MX DSP.
We need it for inter-process communication between DSP
and main core.
This callback is used to find the resource table (defined
in remote processor linker script) where the address of the
vrings along with the other
From: Iuliana Prodan
These patches are needed in order to support rpmsg on DSP when a
resource table is available.
Changes since v2:
- add newline between nodes in dtsi (patch 2/2)
Changes since v1:
- add missing bracket in dtsi (patch 2/2)
Iuliana Prodan (2):
remoteproc: imx_dsp_rproc
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
Signed-off-by: Iuliana Prodan
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
b/arch
From: Iuliana Prodan
Add the .find_loaded_rsc_table operation for i.MX DSP.
We need it for inter-process communication between DSP
and main core.
This callback is used to find the resource table (defined
in remote processor linker script) where the address of the
vrings along with the other
From: Iuliana Prodan
These patches are needed in order to support rpmsg on DSP when a
resource table is available.
Changes since v1:
- add missing bracket in dtsi (patch 2/2)
Iuliana Prodan (2):
remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op
arm64: dts: imx8mp: add
On 9/12/2023 2:30 PM, Marco Felsch wrote:
Hi Iuliana,
On 23-09-12, Iuliana Prodan (OSS) wrote:
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
These can be later used in a dsp node, like:
dsp: dsp@3b6e8000 {
compatible = "fsl,i
On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote:
On 12/09/2023 10:49, Iuliana Prodan wrote:
Should I test this on other tree(s)?
You test the patch on the tree you send it. What is the point to test it
on some old code, cherry-pick with bugs and then send?
If you have cross-tree dependencies
On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote:
On 12/09/2023 10:13, Iuliana Prodan wrote:
On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled
On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
These can be later used in a dsp node, like:
dsp: dsp@3b6e8000 {
compatible = "fsl,i
From: Iuliana Prodan
Add the .find_loaded_rsc_table operation for i.MX DSP.
We need it for inter-process communication between DSP
and main core.
This callback is used to find the resource table (defined
in remote processor linker script) where the address of the
vrings along with the other
From: Iuliana Prodan
These patches are needed in order to support rpmsg on DSP when a
resource table is available.
Iuliana Prodan (2):
remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op
arm64: dts: imx8mp: add reserve-memory nodes for DSP
arch/arm64/boot/dts/freescale
From: Iuliana Prodan
Add the reserve-memory nodes used by DSP when the rpmsg
feature is enabled.
These can be later used in a dsp node, like:
dsp: dsp@3b6e8000 {
compatible = "fsl,imx8mp-dsp";
reg = <0x3b6e8000 0x88000>;
mbox-names = "tx0", &quo
From: Iuliana Prodan
Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory
needed by the driver, to fulfil a request, within the crypto
request object.
The extra size needed for base extended descriptor, hw
descriptor commands and link tables is computed in frontend
driver (caamalg_qi2
From: Iuliana Prodan
Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory
needed by the driver, to fulfil a request, within the crypto
request object.
The extra size needed for base extended descriptor, hw
descriptor commands and link tables is computed in frontend
driver (caamalg_qi
From: Iuliana Prodan
Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory
needed by the driver, to fulfil a request, within the crypto
request object.
The extra size needed for base extended descriptor and link tables
is computed in frontend driver (caamhash) initialization and saved
From: Iuliana Prodan
Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory
needed by the driver, to fulfil a request, within the crypto
request object.
The extra size needed for base extended descriptor, hw
descriptor commands and link tables is computed in frontend
driver (caamalg
From: Iuliana Prodan
Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory
needed by the driver, to fulfil a request, within the crypto
request object.
The extra size needed for base extended descriptor and hw
descriptor commands, link tables, IV is computed in frontend
driver (caamalg
From: Iuliana Prodan
This series removes CRYPTO_ALG_ALLOCATES_MEMORY flag and
allocates the memory needed by the driver, to fulfil a
request, within the crypto request object.
The extra size needed for base extended descriptor, hw
descriptor commands and link tables is added to the reqsize
field
On 11/26/2020 7:12 PM, Ard Biesheuvel wrote:
On Thu, 26 Nov 2020 at 17:00, Iuliana Prodan wrote:
On 11/26/2020 9:09 AM, Ard Biesheuvel wrote:
On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote:
On 11/25/2020 11:16 PM, Ard Biesheuvel wrote:
On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan
On 11/26/2020 9:09 AM, Ard Biesheuvel wrote:
On Wed, 25 Nov 2020 at 22:39, Iuliana Prodan wrote:
On 11/25/2020 11:16 PM, Ard Biesheuvel wrote:
On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS)
wrote:
From: Iuliana Prodan
Add the option to allocate the crypto request object plus any
On 11/25/2020 11:16 PM, Ard Biesheuvel wrote:
On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS)
wrote:
From: Iuliana Prodan
Add the option to allocate the crypto request object plus any extra space
needed by the driver into a DMA-able memory.
Add CRYPTO_TFM_REQ_DMA flag to be used
From: Iuliana Prodan
Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory
needed by the driver, to fulfil a request, within the crypto
request object.
The extra size needed for base extended descriptor, hw
descriptor commands and link tables is computed in frontend
driver (caamalg
From: Iuliana Prodan
Remove CRYPTO_ALG_ALLOCATES_MEMORY flag and allocate the memory
needed by the driver, to fulfil a request, within the crypto
request object.
The extra size needed for base extended descriptor and hw
descriptor commands, link tables, IV is computed in frontend
driver (caamalg
From: Iuliana Prodan
Some crypto backends might require the requests' private contexts
to be allocated in DMA-able memory.
Signed-off-by: Horia Geanta
---
net/ipv4/esp4.c | 7 ++-
net/ipv6/esp6.c | 7 ++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/esp4.c
From: Iuliana Prodan
The CRYPTO_TFM_REQ_DMA flag can be used by backend implementations to
indicate to crypto API the need to allocate GFP_DMA memory
for private contexts of the crypto requests.
For public key encryption add the needed functions to
set/get/clear flags.
Signed-off-by: Horia
From: Iuliana Prodan
Add the option to allocate the crypto request object plus any extra space
needed by the driver into a DMA-able memory.
Add CRYPTO_TFM_REQ_DMA flag to be used by backend implementations to
indicate to crypto API the need to allocate GFP_DMA memory
for private contexts
;)
Signed-off-by: Horia Geantă
Reviewed-by: Iuliana Prodan
---
drivers/crypto/caam/caamalg.c | 4 ++--
drivers/crypto/caam/caamalg_qi.c | 4 ++--
drivers/crypto/caam/caamalg_qi2.c | 3 ++-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/caam/caamalg.c b/drive
-engine).
The callback for do_batch_requests is NULL, since CAAM
doesn't support linked requests.
Signed-off-by: Iuliana Prodan
---
Changes since v1:
- add comment for THRESHOLD define;
- update max size for crypto-engine queue.
drivers/crypto/caam/intern.h | 8
drivers/crypto/caam/jr.c
On 10/26/2020 5:36 PM, Horia Geantă wrote:
On 10/21/2020 11:07 PM, Iuliana Prodan wrote:
Use the new crypto_engine_alloc_init_and_set() function to
initialize crypto-engine and enable retry mechanism.
Set the maximum size for crypto-engine software queue based on
Job Ring size (JOBR_DEPTH
-engine).
The callback for do_batch_requests is NULL, since CAAM
doesn't support linked requests.
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/intern.h | 3 +++
drivers/crypto/caam/jr.c | 6 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/intern.h
caam_hash_ctx'
drivers/crypto/caam/ctrl.c:449: warning: Function parameter or member 'ctrl'
not described in 'caam_get_era'
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Iuliana Prodan
---
Changes since v1:
1. Fix more warnings
---
drivers/crypto/caam/caamalg_desc.c | 1 +
drivers/crypto
On 9/2/2020 6:05 PM, Krzysztof Kozlowski wrote:
Fix kerneldoc warnings:
drivers/crypto/caam/caamalg_qi2.c:73: warning: cannot understand function
prototype: 'struct caam_ctx '
drivers/crypto/caam/caamalg_qi2.c:2962: warning: cannot understand function
prototype: 'struct caam_hash_ctx '
On 9/2/2020 6:05 PM, Krzysztof Kozlowski wrote:
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Iuliana Prodan
---
drivers/crypto/caam/caamalg_qi2.c | 3 +--
1
, e.g. using dmsetup:
dmsetup -v create encrypted --table "0 $(blockdev --getsz /dev/mmcblk2p10)
crypt capi:tk(cbc(aes))-plain :32:logon:seckey 0 /dev/mmcblk2p10 0 1
sector_size:512".
Signed-off-by: Franck LENORMAND
Signed-off-by: Iuliana Prodan
---
drivers/cr
ations will know how to handle tagged keys, by loading the
proper settings for KEY command.
Iuliana Prodan (2):
crypto: caam - add tag object functionality
crypto: caam - support tagged keys for skcipher algorithms
drivers/crypto/caam/Kconfig| 9 +++
drivers/crypto/caam/Makefile
configuration or tag object data.
This API expects that the object (the actual data) from a tag object
to be a buffer (defined by address and size).
Signed-off-by: Franck LENORMAND
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/Kconfig | 9 +++
drivers/crypto/caam/Makefile
Signed-off-by: Anson Huang
Reviewed-by: Iuliana Prodan
---
Changes since V2:
- add one more fix tag for original patch before file name is changed.
---
drivers/soc/imx/soc-imx8m.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/imx/soc-imx8m.c b
On 6/10/2020 10:57 AM, Anson Huang wrote:
Subject: RE: [PATCH V2] soc: imx8m: Correct i.MX8MP UID fuse offset
From: Anson Huang
Sent: Wednesday, June 10, 2020 6:42 AM
Correct i.MX8MP UID fuse offset according to fuse map:
UID_LOW: 0x420
UID_HIGH: 0x430
Fixes: fc40200ebf82 ("soc: imx:
On 6/9/2020 4:15 PM, Anson Huang wrote:
Correct i.MX8MP UID fuse offset according to fuse map:
UID_LOW: 0x420
UID_HIGH: 0x430
Signed-off-by: Anson Huang
If this patch corrects the imx8mp UID shouldn't have a Fixes tag?
---
drivers/soc/imx/soc-imx8m.c | 8 ++--
1 file changed, 6
be pass back and forth between
crypto-engine and hardware.
Fixes: 6a89f492f8e5 ("crypto: engine - support for parallel requests based on
retry mechanism")
Signed-off-by: Iuliana Prodan
---
crypto/crypto_engine.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --gi
Add crypto_enqueue_request_head function that enqueues a
request in front of queue.
This will be used in crypto-engine, on error path. In case a request
was not executed by hardware, enqueue it back in front of queue (to
keep the order of requests).
Signed-off-by: Iuliana Prodan
---
crypto
for multiple request.
Signed-off-by: Iuliana Prodan
---
crypto/crypto_engine.c | 27 ++-
include/crypto/engine.h | 5 +
2 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c
index ee19273..412149e 100644
freed, since it will be enqueued back
into crypto-engine's queue.
When all drivers, that use crypto-engine now, will be updated for
retry mechanism, the retry_support variable can be removed.
Signed-off-by: Iuliana Prodan
---
crypto/crypto_engine.c | 146 ++---
engine is used).
- added a new patch with support for batch requests.
Changes since V0 (RFC):
- removed max_no_req and no_req, as the number of request that can be
processed in parallel;
- added a new callback, can_enqueue_more, to check whether the hardware
can process a new request.
Iuliana Pro
On 4/28/2020 8:14 AM, Zhenzhong Duan wrote:
> In both aead_crypt_done and skcipher_crypt_done, edesc->bklog is
> referenced after the structure pointed by edesc is freed.
>
> Fix them by moving kfree(edesc) to the end of function call.
>
> Signed-off-by: Zhenzhong Duan
These issues were
Check the return value of the hardware registration for caam_rng and free
resources in case of failure.
Fixes: e24f7c9e87d4 ("crypto: caam - hwrng support")
Signed-off-by: Iuliana Prodan
Reviewed-by: Horia Geanta
---
drivers/crypto/caam/caamrng.c | 5 -
1 file changed, 4 insert
aries")
Signed-off-by: Iuliana Prodan
Reviewed-by: Horia Geanta
---
drivers/crypto/caam/caampkc.c | 49 ++-
1 file changed, 30 insertions(+), 19 deletions(-)
diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c
index e00a470..5b12
ion.
Note: in most error cases caam/qi and caam/qi2 returned -EIO; align all
caam drivers to return -EINVAL.
While here, ratelimit prints triggered by fuzz testing, such that
console is not flooded.
Signed-off-by: Horia Geantă
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/caamalg.
Check authsize to solve the extra tests that expect -EINVAL to be
returned when the authentication tag size is not valid.
Validated authsize for GCM, RFC4106 and RFC4543.
Signed-off-by: Iuliana Prodan
Reviewed-by: Horia Geanta
---
drivers/crypto/caam/caamalg.c | 13 +
drivers
On 5/30/2019 1:16 AM, Ard Biesheuvel wrote:
> On Wed, 29 May 2019 at 22:27, Eric Biggers wrote:
>>
>> On Wed, May 29, 2019 at 08:10:56PM +0300, Iuliana Prodan wrote:
>>> The generic GCM driver should ensure that whatever it passes into
>>> scatterlists i
with zeros
until the modulus size is reached.
Signed-off-by: Iuliana Prodan
---
Changes since V1:
- remove not needed initialization of a variable;
- free resources on error path.
---
drivers/crypto/caam/caampkc.c | 84 +++
drivers/crypto/caam
a fixup input pointer and length.
Signed-off-by: Iuliana Prodan
---
Changes since V1:
- changed the commit message and summary.
---
drivers/crypto/caam/caampkc.c | 39 ++-
drivers/crypto/caam/caampkc.h | 7 ++-
2 files changed, 32 insertions(+), 14
with zeros
until the modulus size is reached.
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/caampkc.c | 84 +++
drivers/crypto/caam/caampkc.h | 2 ++
2 files changed, 71 insertions(+), 15 deletions(-)
diff --git a/drivers/crypto/caam/caampkc.c b
ple is:
{
.tap= { 17, 15, 8 },
.psize = 40,
.np = 3,
.ksize = 16,
}
Cc:
Fixes: 12b8567f6fa4 ("crypto: caam - add support for xcbc(aes)")
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/caamhash.c | 13 ++---
1 file changed, 6 ins
The mapped_{src,dst}_nents _returned_ from the dma_map_sg call (which
could be less than src/dst_nents) have to be used to generate the aead,
skcipher job descriptors.
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/caamalg.c | 27 ---
1 file changed, 20 insertions
Some arc4 cipher algorithm defines show up in two places:
crypto/arc4.c and drivers/crypto/bcm/cipher.h.
Let's export them in a common header and update their users.
Signed-off-by: Iuliana Prodan
---
crypto/arc4.c | 5 +
drivers/crypto/bcm/cipher.h | 4 +---
include/crypto
header
-update cbc des and 3des to check for weak keys
Iuliana Prodan (4):
crypto: caam - use mapped_{src,dst}_nents for job descriptor
crypto: export arc4 defines
crypto: caam - add ecb(*) support
crypto: caam - weak key checking for cbc des, 3des
crypto/arc4.c | 5
Add ecb mode support for aes, des, 3des and arc4 ciphers.
ecb(*) reuses existing skcipher implementation, updating it with support
for no IV.
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/Kconfig| 1 +
drivers/crypto/caam/caamalg.c | 190
Modify setkey callback for cbc des and 3des to check for weak keys.
Signed-off-by: Iuliana Prodan
---
drivers/crypto/caam/caamalg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
index 90d83ae..9eac509 100644
68 matches
Mail list logo
