_get_ps_timeout' and 'wfx_update_pm' static" (merged
in master in version 5.8). Can you check you are working on the last tree?
--
Jérôme Pouiller
On Tuesday 23 March 2021 15:11:56 CET Ulf Hansson wrote:
> On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller
> wrote:
> > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote:
> > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
> > > wrote:
> &g
Hello Ulf,
On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote:
> On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/bus_sdio
"genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
Hi Leon,
On Monday 15 March 2021 16:11:52 CET Leon Romanovsky wrote:
> On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > drivers/net/wireless/silabs/wfx/Kconfig
On Tuesday 9 March 2021 14:07:43 CET Greg KH wrote:
> On Thu, Mar 04, 2021 at 10:43:45AM +0100, Jérôme Pouiller wrote:
> > Hello Greg,
> >
> > On Tuesday 2 March 2021 16:01:25 CET Jérôme Pouiller wrote:
> > > Hello Muhammad,
> > >
> > > Sorry, I a
Hello Greg,
On Tuesday 2 March 2021 16:01:25 CET Jérôme Pouiller wrote:
> Hello Muhammad,
>
> Sorry, I am a bit late for the review of this patch. Thank you for your
> contribution.
>
> On Thursday 11 February 2021 15:36:37 CET Muhammad Usama Anjum wrote:
> >
> &g
completion. If you try to compile bh.h alone (with something like
gcc -xc .../bh.h) it won't work.
Maybe it works now because we are lucky in the order the headers are
included, but I think it is not sufficient.
[... same problem repeats multiple times in the following ...]
--
Jérôme Pouiller
ging/wfx/hif_api_cmd.h
> @@ -100,7 +100,7 @@ struct hif_req_update_ie {
> u8 reserved1:5;
> u8 reserved2;
> __le16 num_ies;
> - struct element ie[];
> + u8 ie[];
> } __packed;
>
> struct hif_cnf_update_ie {
> --
> 2.25.1
&
n in
provided by PDS (Platform Data Set, this is the wording used in WF200
documentation) files. For hardware integrators, the full process to create
PDS files is described here:
https://github.com/SiliconLabs/wfx-firmware/blob/master/PDS/README.md
So this function aims to send PDS to the device. However, the PDS file is
often bigger than Rx buffers of the chip, so it has to be sent in multiple
parts.
In add, the PDS data cannot be split anywhere. The PDS files contains tree
structures. Braces are used to enter/leave a level of the tree (in a JSON
fashion). PDS files can only been split between root nodes.
--
Jérôme Pouiller
ning on.
Just to be curious, why these platforms don't support DMA in a stack
allocated area? If the memory is contiguous (= not vmalloced), correctly
aligned and in the first 4GB of physical memory, it should be sufficient,
shouldn't?
--
Jérôme Pouiller
On Tuesday 22 December 2020 16:02:38 CET Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
>
> [...]
>
> > +wfx-$(CONFIG_SPI) += bus_spi.o
> > +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdi
t; +#include
> > +#else
> > +#include
> > +#include
> > +#define __packed __attribute__((__packed__))
> > +#endif
>
> Why check for __KERNEL__ and redefined __packed? These don't belong to a
> wireless driver.
In the old days, this file was shared with other projects. I though I had
cleaned all these things.
--
Jérôme Pouiller
*/
> >
> > This sounds very hacky to me, I have understood that you should never
> > use stack with DMA.
>
> You should never do that because some platforms do not support it, so no
> driver should ever try to do that as they do not know what platform they
> are
In), dataIn);
> + if (ret == 0) {
> + result->CHIPREV = dataIn[0];
> + memcpy(>PART, [1],sizeof(result->PART));
> + result->PBUILD = dataIn[3];
> + memcpy(>ID, [4], sizeof(result->ID));
> + result->CUSTOMER = dataIn[6];
> + result->ROMID = dataIn[7];
> + result->BOND = dataIn[8];
... it would avoid all these lines.
> + } else {
> + dev_err(port->dev,
> + "%s: si4455_send_command_get_response error(%i)",
> + __func__,
> + ret);
> + }
> + return ret;
> +}
[...]
--
Jérôme Pouiller
On Wednesday 4 November 2020 20:15:54 CET Rob Herring wrote:
> On Wed, 04 Nov 2020 16:51:45 +0100, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > Signed-off-by: Jérôme Pouiller
> > ---
> > .../bindings/net/wireless/silabs,wfx.yaml | 131 ++
1609180-1-jerome.pouil...@silabs.com/
--
Jérôme Pouiller
[...]
7 .rodata 002d 0000 1dd4 2**2
CONTENTS, ALLOC, LOAD, READONLY, DATA
The difference of .rodata is exactly what is expected (24 bytes) and we
save 115 bytes of code.
Reviewed-by: Jérôme Pouiller
--
Jérôme Pouiller
Hello Ulf,
On Friday 16 October 2020 13:30:30 CEST Ulf Hansson wrote:
> On Mon, 12 Oct 2020 at 12:47, Jerome Pouiller
> wrote:
> >
> > From: Jérôme Pouiller
>
> Please fill out this commit message to explain a bit more about the
> patch and the HW it enables suppo
On Wednesday 14 October 2020 14:43:34 CEST Pali Rohár wrote:
> On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote:
> > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote:
> > > On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote:
> > > >
On Tuesday 13 October 2020 18:49:35 CEST Rob Herring wrote:
> On Mon, Oct 12, 2020 at 12:46:26PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
[...]
> > + Note that in add of the properties below, the WFx driver also supports
> > + `mac-address` and `local-mac-
).
Anyway, if we choose to rely on the DT, should we also check the VID/PID?
Personally, I am in favor to probe the device only if VID/PID match and if
a DT node is found, even if it is not the usual way.
--
Jérôme Pouiller
ies on the last
development tree.
To get the development tree to use, you can run:
./scripts/get_maintainer.pl --scm -f drivers/staging/wfx/debug.c
--
Jérôme Pouiller
On Saturday 10 October 2020 14:40:34 CEST Greg Kroah-Hartman wrote:
> On Sat, Oct 10, 2020 at 02:22:13PM +0200, Jérôme Pouiller wrote:
> > On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote:
> > > Jerome Pouiller writes:
> > >
> > > > From: Jérôme Pou
On Friday 9 October 2020 20:51:01 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> Jerome Pouiller writes:
>
>
On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > From: Jérôme Pouiller
> >
> > Smatch complains:
> >
> >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn:
> > potential NULL parameter der
it, or it would be an unnecessary effort?
[1]
https://lore.kernel.org/driverdev-devel/20190919142527.31797-1-jerome.pouil...@silabs.com/
or commits a7a91ca5a23d^..40115bbc40e2
--
Jérôme Pouiller
tmp = buf;
> > }
> > ret = sram_buf_write(wdev, addr, tmp, len);
> > - if (!virt_addr_valid(buf))
> > + if (tmp != buf)
> > kfree(tmp);
> > return ret;
> > }
>
> Jerome, any thoughts?
Looks correct.
Reviewed-by: Jérôme Pouiller
--
Jérôme Pouiller
On Monday 24 August 2020 11:50:42 CEST Dan Carpenter wrote:
> On Thu, Aug 20, 2020 at 05:58:47PM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > The protection of the management frames is mainly done by mac80211.
> > However, frames for the manageme
ing: wfx: fix a handful of
spelling mistakes"). But, I am sure there still are spell mistakes in code
of wfx driver :)
--
Jérôme Pouiller
et < 0)
> return context->ret;
> - // Be carefull, write() is waiting for a full message while read()
> + // Be careful, write() is waiting for a full message while read()
Already fixed by commit c9638363f02d ("staging: wfx: fix a handful of
spelling mistakes").
--
Jérôme Pouiller
e staging tree before to send it. You can use the script
get_maintainer.pl to get this information:
$ ./scripts/get_maintainer.pl --scm drivers/staging/wfx
[...]
git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
--
Jérôme Pouiller
This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to
> any
> // request anymore. We need to slightly hack struct wfx_hif_cmd for that
> job. Be
> -// carefull to only call this funcion during device unregister.
> +// careful to only call this function during device unregister.
Not related to the rest of the patch.
[...]
As it stands, I think this change does not improve the code. Obviously, it
is a subjective opinion. What the other developers think about it?
--
Jérôme Pouiller
const char *file_pds;
> struct gpio_desc *gpio_wakeup;
> diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
> index 4e30ab17a93d..ad63332f690c 100644
> --- a/drivers/staging/wfx/sta.c
> +++ b/drivers/staging/wfx/sta.c
> @@ -214,7 +214,7 @@ static int wfx_get_ps_timeout(struct wfx_vif *wvif, bool
> *enable_ps)
> if (chan0 && chan1 && chan0->hw_value != chan1->hw_value &&
> wvif->vif->type != NL80211_IFTYPE_AP) {
> // It is necessary to enable powersave if channels
> - // are differents.
> + // are different.
> if (enable_ps)
> *enable_ps = true;
> if (wvif->wdev->force_ps_timeout > -1)
> --
> 2.27.0
>
>
Reviewed-by: Jérôme Pouiller
--
Jérôme Pouiller
lized value.
> Fix this by initializing bytes_done to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: a9408ad79ff3 ("staging: wfx: load the firmware faster")
> Signed-off-by: Colin Ian King
Good catch!
I am surprised that my gcc hasn't caught th
In some specific usages (RT-mutex? lock proving?), acquire
mutex from a context and release it from another can produce some errors.
In contrary a boolean semaphore does not have this restriction.
(can anyone confirm that?)
--
Jérôme Pouiller
dev_dbg(dev, "using gpio %d for %s\n",
> desc_to_gpio(ret), label);
> 54 }
> 55 return ret;
> 56 }
> 57
Hello,
This warning seems to be a false positive (the variable "ret" is affected in
all branches of the if/else).
--
Jérôme Pouiller
. Also do note
> that we have special rules for nl80211 vendor commands:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api
I hoped to suggest the move of this driver outside of staging in some
weeks (the last items in TODO list are either non-essential or easy to
fix). So, you suggest me to resend these patches after that change?
--
Jérôme Pouiller
gt; * with a dummy element:
> *
The subject of the mail should have been "[PATCH v2]" (it is automatic if
use the -v option of "git send-email").
Apart from that:
Reviewed-by: Jérôme Pouiller
--
Jérôme Pouiller
On Friday 15 May 2020 15:53:59 CEST Greg Kroah-Hartman wrote:
> On Fri, May 15, 2020 at 10:33:11AM +0200, Jerome Pouiller wrote:
> > From: Jérôme Pouiller
> >
> > The function hif_scan() return the timeout for the completion of the
> > scan request. It is the
an now nearlu be used with __print_symbolic() but,
> + * 5. list_name can now nearly be used with __print_symbolic() but,
> * __print_symbolic() dislike last comma of list. So we define a new
> list
> * with a dummy element:
Ok.
Thank you for your contribution.
--
Jérôme Pouiller
On Tuesday 12 May 2020 09:43:34 CEST Geert Uytterhoeven wrote:
> Hi Jerome,
>
> On Mon, May 11, 2020 at 5:53 PM Jerome Pouiller
> wrote:
> > From: Jérôme Pouiller
> >
> > The struct hif_msg is received from the hardware. So, it declared as
> > little endia
Obviously "Engicam i.CoreM6 DualLite/Solo RQS" include an imx6dl, not
an imx6q.
Signed-off-by: Jérôme Pouiller <j...@sysmic.org>
---
arch/arm/boot/dts/imx6dl-icore-rqs.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-icore-rqs.dts
Obviously "Engicam i.CoreM6 DualLite/Solo RQS" include an imx6dl, not
an imx6q.
Signed-off-by: Jérôme Pouiller
---
arch/arm/boot/dts/imx6dl-icore-rqs.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-icore-rqs.dts
b/arch/arm/boot/dts/im
44 matches
Mail list logo