[RESEND PATCH] Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"

2021-04-08 Thread Jae Hyun Yoo
48>] (ret_from_fork+0x14/0x2c) [7.399607] Exception stack(0x818cdfb0 to 0x818cdff8) [7.405243] dfa0: [7.414371] dfc0: 0000 0000 [7.423499] dfe0:

Re: [PATCH 3/3] aspeed-video: add COMP_READY to VE_SPURIOUS_IRQS

2021-03-09 Thread Jae Hyun Yoo
in commit 65d270acb2d662c3346793663ac3a759eb4491b8. Signed-off-by: Zev Weiss I have less experience with this part of the chip, so I defer to Jae or Ryan for an ack. I didn't see unexpected VE_INTERRUPT_COMP_READY events in my system but it seems a fix good to have. Acked-by: Jae Hyun Yoo

Re: [PATCH 0/2] peci: aspeed: Add AST2600 compatible

2019-10-03 Thread Jae Hyun Yoo
On 10/2/2019 7:35 PM, ChiaWei Wang wrote: Hi Jae Hyun, Thanks for the feedback. For now should I use GitHub pull-request to submit the patches of PECI-related change to OpenBMC dev-5.3 tree only? You could submit this patch series to OpenBMC mailing list with [PATCH linux dev-5.3] prefix.

Re: [PATCH 0/2] peci: aspeed: Add AST2600 compatible

2019-10-02 Thread Jae Hyun Yoo
On 10/2/2019 3:05 PM, Joel Stanley wrote: On Wed, 2 Oct 2019 at 18:11, Jae Hyun Yoo wrote: Hi Chia-Wei, On 10/1/2019 11:11 PM, Chia-Wei, Wang wrote: Update the Aspeed PECI driver with the AST2600 compatible string. A new comptabile string is needed for the extended HW feature of AST2600

Re: [PATCH 0/2] peci: aspeed: Add AST2600 compatible

2019-10-02 Thread Jae Hyun Yoo
Hi Chia-Wei, On 10/1/2019 11:11 PM, Chia-Wei, Wang wrote: Update the Aspeed PECI driver with the AST2600 compatible string. A new comptabile string is needed for the extended HW feature of AST2600. Chia-Wei, Wang (2): peci: aspeed: Add AST2600 compatible string dt-bindings: peci: aspeed:

[PATCH v2] i2c: aspeed: Add multi-master use case support

2019-02-11 Thread Jae Hyun Yoo
slave operation properly. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins --- Changes since v9: * Removed cppcheck warnings. drivers/i2c/busses/i2c-aspeed.c | 119 +--- 1 file changed, 93 insertions(+), 26 deletions(-) diff --git a/drivers/i2c/busses/i2c

Re: [PATCH] i2c: aspeed: Add multi-master use case support

2019-02-11 Thread Jae Hyun Yoo
On 2/11/2019 10:16 AM, Wolfram Sang wrote: Can you please apply above changes on top of this patch? Or I can submit v2 with it. Please send v2. Okay, I'll send v2. Thanks, Jae

Re: [PATCH] i2c: aspeed: Add multi-master use case support

2019-02-11 Thread Jae Hyun Yoo
Hmmm, the #ifdeffery quite increases with this patch. Maybe it is easier to select I2C_SLAVE in Kconfig? I'll let you decide. My code checkers found this: CPPCHECK drivers/i2c/busses/i2c-aspeed.c:694:10: warning: Variable 'ret' is assigned a value that is never used. [unreadVariable]

Re: [PATCH] i2c: aspeed: Add multi-master use case support

2019-01-31 Thread Jae Hyun Yoo
Hi Brendan, Can you please review this patch? Thanks, Jae On 1/16/2019 11:39 AM, Jae Hyun Yoo wrote: In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so cases can be happened that this master tries sending data through

[PATCH] i2c: aspeed: Add multi-master use case support

2019-01-16 Thread Jae Hyun Yoo
slave operation properly. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/busses/i2c-aspeed.c | 118 +--- 1 file changed, 92 insertions(+), 26 deletions(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index 8dc9161ced38..9253ebccb008

[PATCH] i2c: aspeed: Remove hard-coded bus timeout value setting

2019-01-16 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

Re: [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-15 Thread Jae Hyun Yoo
On 1/15/2019 3:14 PM, Joel Stanley wrote: On Tue, 15 Jan 2019 at 09:49, Jae Hyun Yoo wrote: + /** +* We check that the regmap works on this very first access, +* but as this is an MMIO-backed regmap, subsequent regmap +* access is not going to fail and we skip

Re: [PATCH i2c-next v9 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2019-01-15 Thread Jae Hyun Yoo
On 1/15/2019 2:47 PM, Wolfram Sang wrote: On Tue, Oct 30, 2018 at 02:09:11PM -0700, Jae Hyun Yoo wrote: In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so a case can be happened that this master tries to send data

Re: [PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:42 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds PECI client driver. It looks like it's a PECI driver for the three CPU families, and it implements cpu and dimm temp, with sideband functions deferred to the future. If you add

Re: [PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:43 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Cc: Guenter Roeck Cc: Jean Delvare Cc: Jonathan Corbet Cc: Jason M Biils Cc: Randy Dunlap Signed-off-by: Jae Hyun Yoo

Re: [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:37 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: + ret = of_property_read_u32(priv->dev->of_node, "cmd-timeout-ms", + >cmd_timeout_ms); + if (ret || priv->cmd_timeout_ms >

Re: [PATCH v10 03/12] peci: Add support for PECI bus driver core

2019-01-14 Thread Jae Hyun Yoo
Hello Joel, On 1/14/2019 3:13 AM, Joel Stanley wrote: Hello Jae, On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus core into linux driver framework. I would like to help you get this merged next release cycle, as we are now carrying

Re: [PATCH v10 05/12] ARM: dts: aspeed: peci: Add PECI node

2019-01-14 Thread Jae Hyun Yoo
Hi Joel, On 1/13/2019 9:45 PM, Joel Stanley wrote: Hi Jae, On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. This looks good, aside from the alias. It will go via my aspeed tree once the bindings

[PATCH v10 05/12] ARM: dts: aspeed: peci: Add PECI node

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Cc: Rob Herring Cc: Mark Rutland Cc: Joel Stanley Cc: Andrew Jeffery Cc: Jason M Biils Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon

[PATCH v10 00/12] PECI device driver introduction

2019-01-07 Thread Jae Hyun Yoo
Jae Hyun Yoo (12): dt-bindings: Add a document of PECI subsystem Documentation: ioctl: Add ioctl numbers for PECI subsystem peci: Add support for PECI bus driver core dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs ARM: dts: aspeed: peci: Add PECI node p

[PATCH v10 03/12] peci: Add support for PECI bus driver core

2019-01-07 Thread Jae Hyun Yoo
: Viresh Kumar Cc: Randy Dunlap Cc: Cyrille Pitchen Cc: Juergen Gross Cc: Alan Cox Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc: Fengguang Wu Cc: Jason M Biils Cc: Julia Cartwright Signed-off-by: Jae Hyun Yoo Signed-off-by: Fengguang Wu Reviewed

[PATCH v10 02/12] Documentation: ioctl: Add ioctl numbers for PECI subsystem

2019-01-07 Thread Jae Hyun Yoo
: Bryant G. Ly Cc: Arnd Bergmann Cc: James Feist Cc: Jason M Biils Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- Documentation/ioctl/ioctl-number.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt index

[PATCH v10 01/12] dt-bindings: Add a document of PECI subsystem

2019-01-07 Thread Jae Hyun Yoo
This commit adds a document of generic PECI bus, adapter and client driver. Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: Joel Stanley Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring

[PATCH v10 10/12] hwmon: Add PECI cputemp driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI cputemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang

[PATCH v10 12/12] Add maintainers for the PECI subsystem

2019-01-07 Thread Jae Hyun Yoo
This commit adds maintainer information for the PECI subsystem. Cc: David S. Miller Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Linus Walleij Cc: Randy Dunlap Cc: Jason M Biils Signed-off-by: Jae Hyun Yoo --- MAINTAINERS | 22 ++ 1 file

[PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx SoCs. Cc: Joel Stanley Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Robin Murphy Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed

[PATCH v10 07/12] dt-bindings: mfd: Add a document for PECI client driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds a dt-bindings document for PECI client driver. Cc: Lee Jones Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo Reviewed-by: Rob Herring --- .../bindings/mfd/intel-peci

[PATCH v10 11/12] hwmon: Add PECI dimmtemp driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI dimmtemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue

[PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2019-01-07 Thread Jae Hyun Yoo
This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Cc: Guenter Roeck Cc: Jean Delvare Cc: Jonathan Corbet Cc: Jason M Biils Cc: Randy Dunlap Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Acked-by: Guenter

[PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI client driver. Cc: Lee Jones Cc: Randy Dunlap Cc: Rob Herring Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- drivers/mfd/Kconfig | 14 +++ drivers/mfd/Makefile

[PATCH v10 04/12] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs

2019-01-07 Thread Jae Hyun Yoo
Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring --- .../devicetree/bindings/peci/peci-aspeed.txt | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/peci

Re: [PATCH v9 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2019-01-02 Thread Jae Hyun Yoo
Hi Lee, On 12/21/2018 6:47 AM, Lee Jones wrote: On Tue, 18 Dec 2018, Jae Hyun Yoo wrote: This commit adds a dt-bindings document for PECI client MFD. +* Intel PECI client bindings +PECI (Platform Environment Control Interface) is a one-wire bus interface that +provides a communication

Re: [PATCH v9 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2019-01-02 Thread Jae Hyun Yoo
Hi Lee, On 12/21/2018 6:46 AM, Lee Jones wrote: On Tue, 18 Dec 2018, Jae Hyun Yoo wrote: This commit adds PECI client MFD driver. +config MFD_INTEL_PECI_CLIENT + bool "Intel PECI client" + depends on (PECI || COMPILE_TEST) + select MFD_CORE +

[PATCH v9 02/12] Documentation: ioctl: Add ioctl numbers for PECI subsystem

2018-12-18 Thread Jae Hyun Yoo
: Bryant G. Ly Cc: Arnd Bergmann Cc: James Feist Cc: Jason M Biils Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- Documentation/ioctl/ioctl-number.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt index

[PATCH v9 03/12] peci: Add support for PECI bus driver core

2018-12-18 Thread Jae Hyun Yoo
: Viresh Kumar Cc: Randy Dunlap Cc: Cyrille Pitchen Cc: Juergen Gross Cc: Alan Cox Cc: Andrew Lunn Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc: Fengguang Wu Cc: Jason M Biils Cc: Julia Cartwright Signed-off-by: Jae Hyun Yoo Signed-off-by: Fengguang Wu Reviewed

[PATCH v9 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2018-12-18 Thread Jae Hyun Yoo
This commit adds a dt-bindings document for PECI client MFD. Cc: Lee Jones Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo Reviewed-by: Rob Herring --- .../bindings/mfd/intel-peci

[PATCH v9 11/12] hwmon: Add PECI dimmtemp driver

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI dimmtemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue

[PATCH v9 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx SoCs. Cc: Joel Stanley Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Robin Murphy Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed

[PATCH v9 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2018-12-18 Thread Jae Hyun Yoo
This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Cc: Guenter Roeck Cc: Jean Delvare Cc: Jonathan Corbet Cc: Jason M Biils Cc: Randy Dunlap Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Acked-by: Guenter

[PATCH v9 12/12] Add maintainers for the PECI subsystem

2018-12-18 Thread Jae Hyun Yoo
This commit adds maintainer information for the PECI subsystem. Cc: David S. Miller Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Linus Walleij Cc: Randy Dunlap Cc: Jason M Biils Signed-off-by: Jae Hyun Yoo --- MAINTAINERS | 22 ++ 1 file

[PATCH v9 10/12] hwmon: Add PECI cputemp driver

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI cputemp hwmon driver. Cc: Guenter Roeck Cc: Jean Delvare Cc: Alan Cox Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Jason M Biils Cc: Joel Stanley Cc: Miguel Ojeda Cc: Andrew Lunn Cc: Stef van Os Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang

[PATCH v9 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI client MFD driver. Cc: Lee Jones Cc: Randy Dunlap Cc: Rob Herring Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery Signed-off-by: Jae Hyun Yoo --- drivers/mfd/Kconfig | 14 +++ drivers/mfd/Makefile

[PATCH v9 05/12] ARM: dts: aspeed: peci: Add PECI node

2018-12-18 Thread Jae Hyun Yoo
This commit adds PECI bus/adapter node of AST24xx/AST25xx into aspeed-g4 and aspeed-g5. Cc: Rob Herring Cc: Mark Rutland Cc: Joel Stanley Cc: Andrew Jeffery Cc: Jason M Biils Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon

[PATCH v9 04/12] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs

2018-12-18 Thread Jae Hyun Yoo
Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring --- .../devicetree/bindings/peci/peci-aspeed.txt | 55 +++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/peci

[PATCH v9 00/12] PECI device driver introduction

2018-12-18 Thread Jae Hyun Yoo
ent of Intel CPU target. - Added a maintainer of PECI subsystem into MAINTAINERS document. Jae Hyun Yoo (12): dt-bindings: Add a document of PECI subsystem Documentation: ioctl: Add ioctl numbers for PECI subsystem peci: Add support for PECI bus driver core dt-bindings: Add a document of P

[PATCH v9 01/12] dt-bindings: Add a document of PECI subsystem

2018-12-18 Thread Jae Hyun Yoo
This commit adds a document of generic PECI bus, adapter and client driver. Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: Joel Stanley Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Vernon Mauery Reviewed-by: Rob Herring

Re: [PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-14 Thread Jae Hyun Yoo
Hi Vijay, On 12/14/2018 10:11 AM, Vijay Khemka wrote: On 12/13/18, 2:56 PM, "Joel Stanley" wrote: > + oemname0 = "MB_P3V3"; > + oemname1 = "MB_P5V"; > + oemname2 = "MB_P12V"; > + oemname3 = "MB_P1V05"; > +

Re: [PATCH 2/2] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-11 Thread Jae Hyun Yoo
Hi Vijay, On 12/10/2018 12:07 PM, Vijay Khemka wrote: Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi

Re: [PATCH i2c-next v9 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-11-28 Thread Jae Hyun Yoo
On 11/28/2018 3:54 PM, Wolfram Sang wrote: On Tue, Oct 30, 2018 at 02:09:12PM -0700, Jae Hyun Yoo wrote: This commit adds 'bus-timeout-ms' and '#retries' properties as common optional properties that can be used for setting 'timeout' and 'retries' values of 'struct i2c_adapter'. With this patch

Re: [PATCH i2c-next v9 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-11-28 Thread Jae Hyun Yoo
On 11/28/2018 3:54 PM, Wolfram Sang wrote: On Tue, Oct 30, 2018 at 02:09:12PM -0700, Jae Hyun Yoo wrote: This commit adds 'bus-timeout-ms' and '#retries' properties as common optional properties that can be used for setting 'timeout' and 'retries' values of 'struct i2c_adapter'. With this patch

Re: [PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-11-28 Thread Jae Hyun Yoo
On 11/28/2018 3:54 PM, Wolfram Sang wrote: On Tue, Oct 30, 2018 at 02:09:16PM -0700, Jae Hyun Yoo wrote: In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so a case can be happened that this master tries to send data

Re: [PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-11-28 Thread Jae Hyun Yoo
On 11/28/2018 3:54 PM, Wolfram Sang wrote: On Tue, Oct 30, 2018 at 02:09:16PM -0700, Jae Hyun Yoo wrote: In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so a case can be happened that this master tries to send data

Re: [PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-11-01 Thread Jae Hyun Yoo
the system] url: https://github.com/0day-ci/linux/commits/Jae-Hyun-Yoo/dt-bindings-i2c-Add-bus-timeout-ms-and-retries-properties-as-common-optional/20181031-051152 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: i386-allyesconfig (attached as .config

Re: [PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-11-01 Thread Jae Hyun Yoo
the system] url: https://github.com/0day-ci/linux/commits/Jae-Hyun-Yoo/dt-bindings-i2c-Add-bus-timeout-ms-and-retries-properties-as-common-optional/20181031-051152 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: i386-allyesconfig (attached as .config

[PATCH] i2c: aspeed: Fix an incorrect error log printing

2018-11-01 Thread Jae Hyun Yoo
, so this commit fixes the incorrect error log printing and makes the handler initialize slave state if an incorrect state actually happens. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/busses/i2c-aspeed.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses

[PATCH] i2c: aspeed: Fix an incorrect error log printing

2018-11-01 Thread Jae Hyun Yoo
, so this commit fixes the incorrect error log printing and makes the handler initialize slave state if an incorrect state actually happens. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/busses/i2c-aspeed.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses

Re: [PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
the system] url: https://github.com/0day-ci/linux/commits/Jae-Hyun-Yoo/dt-bindings-i2c-Add-bus-timeout-ms-and-retries-properties-as-common-optional/20181031-051152 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: xtensa-allyesconfig (attached

Re: [PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
the system] url: https://github.com/0day-ci/linux/commits/Jae-Hyun-Yoo/dt-bindings-i2c-Add-bus-timeout-ms-and-retries-properties-as-common-optional/20181031-051152 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: xtensa-allyesconfig (attached

[PATCH i2c-next v9 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-30 Thread Jae Hyun Yoo
at the registration time of an adapter. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in this document. Signed-off-by: Jae Hyun

[PATCH i2c-next v9 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
name to 'aspeed,timeout' and made it to update the adapter's timeout configuration. Changes since v1: - Changed define names of timeout related. Jae Hyun Yoo (5): dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional i2c: core: Add support reading of 'bus

[PATCH i2c-next v9 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-30 Thread Jae Hyun Yoo
at the registration time of an adapter. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in this document. Signed-off-by: Jae Hyun

[PATCH i2c-next v9 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
name to 'aspeed,timeout' and made it to update the adapter's timeout configuration. Changes since v1: - Changed define names of timeout related. Jae Hyun Yoo (5): dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional i2c: core: Add support reading of 'bus

[PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
. To prevent any state corruption in the case, this patch adds checking code if any slave operation is ongoing and it waits up to the bus timeout duration before starting a master_xfer operation. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 55

[PATCH i2c-next v9 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-30 Thread Jae Hyun Yoo
not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in the dt-bindings document. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/i2c-core-base.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core

[PATCH i2c-next v9 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-30 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

[PATCH i2c-next v9 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-30 Thread Jae Hyun Yoo
ioctl on cdev at runtime too. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation

[PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
. To prevent any state corruption in the case, this patch adds checking code if any slave operation is ongoing and it waits up to the bus timeout duration before starting a master_xfer operation. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 55

[PATCH i2c-next v9 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-30 Thread Jae Hyun Yoo
not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in the dt-bindings document. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/i2c-core-base.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core

[PATCH i2c-next v9 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-30 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

[PATCH i2c-next v9 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-30 Thread Jae Hyun Yoo
ioctl on cdev at runtime too. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation

[PATCH i2c-next v8 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-29 Thread Jae Hyun Yoo
not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in the dt-bindings document. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/i2c-core-base.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core

[PATCH i2c-next v8 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-29 Thread Jae Hyun Yoo
not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in the dt-bindings document. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/i2c-core-base.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core

[PATCH i2c-next v8 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-29 Thread Jae Hyun Yoo
ioctl on cdev at runtime too. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation

[PATCH i2c-next v8 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-29 Thread Jae Hyun Yoo
ioctl on cdev at runtime too. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-aspeed.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation

[PATCH i2c-next v8 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-29 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

[PATCH i2c-next v8 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-29 Thread Jae Hyun Yoo
. To prevent any state corruption in the case, this patch adds checking code if any slave operation is ongoing and it waits up to the bus timeout duration before starting a master_xfer operation. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 52

[PATCH i2c-next v8 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-29 Thread Jae Hyun Yoo
at the registration time of an adapter. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in this document. Signed-off-by: Jae Hyun

[PATCH i2c-next v8 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-29 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

[PATCH i2c-next v8 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-29 Thread Jae Hyun Yoo
. To prevent any state corruption in the case, this patch adds checking code if any slave operation is ongoing and it waits up to the bus timeout duration before starting a master_xfer operation. Signed-off-by: Jae Hyun Yoo Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 52

[PATCH i2c-next v8 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-29 Thread Jae Hyun Yoo
at the registration time of an adapter. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in this document. Signed-off-by: Jae Hyun

[PATCH i2c-next v8 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-29 Thread Jae Hyun Yoo
configuration. Changes since v1: - Changed define names of timeout related. Jae Hyun Yoo (5): dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties dt-bindings: i2c: aspeed: Add 'bus

[PATCH i2c-next v8 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-29 Thread Jae Hyun Yoo
configuration. Changes since v1: - Changed define names of timeout related. Jae Hyun Yoo (5): dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties dt-bindings: i2c: aspeed: Add 'bus

Re: [PATCH i2c-next v7 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-11 Thread Jae Hyun Yoo
On 10/11/2018 3:12 PM, Rob Herring wrote: Reviewed-by: Rob Herring Thanks much for your review, Rob! -Jae

Re: [PATCH i2c-next v7 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-11 Thread Jae Hyun Yoo
On 10/11/2018 3:12 PM, Rob Herring wrote: Reviewed-by: Rob Herring Thanks much for your review, Rob! -Jae

Re: [PATCH i2c-next v7 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-11 Thread Jae Hyun Yoo
On 10/11/2018 3:11 PM, Rob Herring wrote: Reviewed-by: Rob Herring Thanks for the review, Rob!

Re: [PATCH i2c-next v7 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-11 Thread Jae Hyun Yoo
On 10/11/2018 3:11 PM, Rob Herring wrote: Reviewed-by: Rob Herring Thanks for the review, Rob!

Re: [PATCH i2c-next v7 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-10 Thread Jae Hyun Yoo
On 10/9/2018 5:00 PM, Brendan Higgins wrote: Reviewed-by: Brendan Higgins Thanks for putting all the work in to do it this way! Thanks a lot for your review, Brendan!

Re: [PATCH i2c-next v7 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-10 Thread Jae Hyun Yoo
On 10/9/2018 5:00 PM, Brendan Higgins wrote: Reviewed-by: Brendan Higgins Thanks for putting all the work in to do it this way! Thanks a lot for your review, Brendan!

Re: [PATCH i2c-next v7 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-10 Thread Jae Hyun Yoo
On 10/9/2018 5:00 PM, Brendan Higgins wrote: Reviewed-by: Brendan Higgins Thank you!

Re: [PATCH i2c-next v7 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-10 Thread Jae Hyun Yoo
On 10/9/2018 5:00 PM, Brendan Higgins wrote: Reviewed-by: Brendan Higgins Thank you!

Re: [PATCH i2c-next v7 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-10 Thread Jae Hyun Yoo
On 10/9/2018 5:08 PM, Brendan Higgins wrote: Reviewed-by: Brendan Higgins Thanks for the review, Brendan!

Re: [PATCH i2c-next v7 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-10 Thread Jae Hyun Yoo
On 10/9/2018 5:08 PM, Brendan Higgins wrote: Reviewed-by: Brendan Higgins Thanks for the review, Brendan!

[PATCH i2c-next v7 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-05 Thread Jae Hyun Yoo
the property name to 'timeout' and made it use the default setting in i2c-core when not specified. Changes since v2: - Changed the property name to 'aspeed,timeout' and made it to update the adapter's timeout configuration. Changes since v1: - Changed define names of timeout related. Jae Hyun Yoo (5

[PATCH i2c-next v7 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-05 Thread Jae Hyun Yoo
not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in the dt-bindings document. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/i2c-core-base.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core

[PATCH i2c-next v7 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-05 Thread Jae Hyun Yoo
the property name to 'timeout' and made it use the default setting in i2c-core when not specified. Changes since v2: - Changed the property name to 'aspeed,timeout' and made it to update the adapter's timeout configuration. Changes since v1: - Changed define names of timeout related. Jae Hyun Yoo (5

[PATCH i2c-next v7 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-05 Thread Jae Hyun Yoo
not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in the dt-bindings document. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/i2c-core-base.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core

[PATCH i2c-next v7 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-05 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c

[PATCH i2c-next v7 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-05 Thread Jae Hyun Yoo
. To prevent any state corruption in the case, this patch adds checking code if any slave operation is ongoing and it waits up to the bus timeout duration before starting a master_xfer operation. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/busses/i2c-aspeed.c | 53 +++-- 1 file

[PATCH i2c-next v7 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-05 Thread Jae Hyun Yoo
at the registration time of an adapter. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in this document. Signed-off-by: Jae Hyun

[PATCH i2c-next v7 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-05 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c

  1   2   3   4   5   6   >