Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-02 Thread Jaehoon Chung
Hi, On 05/02/2018 03:19 AM, Liming Sun wrote: > This commit adds extension to the dw_mmc driver for Mellanox BlueField > SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on > this SoC. Could you heck Shawn's comments? And add the minor comment. > > Cc: sta...@kernel.org >

Re: [RFC 0/2] dw_mmc: add multislot support

2018-04-26 Thread Jaehoon Chung
n each slot structure instead of common field in >host structure. > * Add locks to serialize access to registers. Sorry for late. :( Well, I will read the other comments..and reply soon. Best Regards, Jaehoon Chung > > NOTE: this patch is based off of v4.17-rc1 > > N

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

2018-03-15 Thread Jaehoon Chung
On 03/15/2018 07:22 PM, Ulf Hansson wrote: > On 23 February 2018 at 07:41, Jaehoon Chung <jh80.ch...@samsung.com> wrote: >> 'clock-freq-min-max' property had already deprecated. >> Remove the 'clock-freq-min-max' property that is kept to maintain >> the compatibility. &

Re: [RFC 1/2] pci: dwc: pci-exynos: modify the Kconfig dependency

2018-03-13 Thread Jaehoon Chung
Dear Lorenzo, On 03/13/2018 08:12 PM, Lorenzo Pieralisi wrote: > Hi Jaehoon, > > On Thu, Dec 21, 2017 at 09:14:06PM +0900, Jaehoon Chung wrote: >> PCI_EXYNOS has the dependency with SOC_EXYNOS5440. >> It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

2018-03-12 Thread Jaehoon Chung
gwoo. https://patchwork.kernel.org/patch/9344477/ Best Regards, Jaehoon Chung > > Signed-off-by: Jinbum Park <jinb.p...@samsung.com> > --- > arch/arm/Kconfig | 1 + > arch/arm/boot/compressed/Makefile | 1 + > arch/arm/vdso/Makefile|

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

2018-03-12 Thread Jaehoon Chung
On 03/13/2018 01:53 PM, Jinbum Park wrote: > To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected. > > Basic test has passed on Raspberry Pi2, Raspbian jessi lite with > CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL. > > Signed-off-by: Jinbum Park >

Re: [PATCH v4] mmc: dw_mmc: Fix the DTO/CTO timeout overflow calculation for 32-bit systems

2018-03-02 Thread Jaehoon Chung
bgcc and so >> code gets compiled on all 32-bit platforms as opposed to usage >> of DIV_ROUND_UP when we may only compile stuff on a very few arches. >> >> Lets cast this multiply to u64 type which prevents overflow. > > Reviewed-by: Jisheng Zhang <jisheng.zh...@sy

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

2018-02-27 Thread Jaehoon Chung
On 02/27/2018 08:36 PM, Jaehoon Chung wrote: > On 02/27/2018 08:28 PM, Ulf Hansson wrote: >> On 23 February 2018 at 07:30, Jaehoon Chung <jh80.ch...@samsung.com> wrote: >>> On 02/23/2018 10:40 AM, Shawn Lin wrote: >>>> Hi Alexey, >>>> >>>&g

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

2018-02-27 Thread Jaehoon Chung
On 02/27/2018 08:28 PM, Ulf Hansson wrote: > On 23 February 2018 at 07:30, Jaehoon Chung <jh80.ch...@samsung.com> wrote: >> On 02/23/2018 10:40 AM, Shawn Lin wrote: >>> Hi Alexey, >>> >>> On 2018/2/23 3:45, Alexey Roslyakov wrote: >>>> cur_

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

2018-02-25 Thread Jaehoon Chung
On 02/24/2018 01:16 AM, Andy Shevchenko wrote: > On Fri, Feb 23, 2018 at 4:19 PM, Shawn Lin <shawn@rock-chips.com> wrote: >> On 2018/2/23 21:27, Andy Shevchenko wrote: >>> On Fri, Feb 23, 2018 at 8:41 AM, Jaehoon Chung <jh80.ch...@samsung.com> >>> wrote:

[PATCH 4/6] arm64: dts: stratix10: remove 'num-slots' property for dwmmc

2018-02-22 Thread Jaehoon Chung
Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/

[PATCH 3/6] ARM: dts: socfpga: remove 'num-slots' property for dwmmc

2018-02-22 Thread Jaehoon Chung
Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dts | 1 - arch/arm/boot/dts/socfpga_arria5.dtsi | 1 - arch/arm/boot/dts/socfpga_cyclone

[PATCH 6/6] arm64: dts: hi3660: remove 'num-slots' property for dwmmc

2018-02-22 Thread Jaehoon Chung
Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm6

[PATCH 5/6] ARM: dts: lpc18xx: remove 'num-slots' property for dwmmc

2018-02-22 Thread Jaehoon Chung
Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/lpc18xx.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi

[PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

2018-02-22 Thread Jaehoon Chung
'clock-freq-min-max' property had already deprecated. Remove the 'clock-freq-min-max' property that is kept to maintain the compatibility. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 4 drivers/mmc/host/dw

[PATCH 2/6] mmc: dw_mmc: remove the deprecated "num-slots"

2018-02-22 Thread Jaehoon Chung
'num-slots' property had already deprecated. Remove the 'nom-slots' property that is kept to maintain the compatibility. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 5 - drivers/mmc/host/dw_mmc

Re: [PATCH] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

2018-02-20 Thread Jaehoon Chung
i3660") Could you resend the patch with changing commit-msg? Then i will pick yours. Best Regards, Jaehoon Chung > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org >

Re: [PATCH] PCI: exynos: remove the deprecated phy codes

2018-01-02 Thread Jaehoon Chung
On 01/03/2018 01:34 AM, Lorenzo Pieralisi wrote: > On Wed, Dec 27, 2017 at 06:43:27PM +0900, Jaehoon Chung wrote: >> pci-exynos had updated to use the PHY framework. >> (drivers/phy/samsung/phy-exynos-pcie.c) >> Removed the depreccated codes relevant to phy in pci-exynos.c. &g

[PATCH] PCI: exynos: remove the deprecated phy codes

2017-12-27 Thread Jaehoon Chung
pci-exynos had updated to use the PHY framework. (drivers/phy/samsung/phy-exynos-pcie.c) Removed the depreccated codes relevant to phy in pci-exynos.c. Instead, use the phy-exynos-pcie.c file. Modified the binding documentation. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

2017-12-26 Thread Jaehoon Chung
On 12/27/2017 06:11 AM, Rob Herring wrote: > On Thu, Dec 21, 2017 at 09:14:07PM +0900, Jaehoon Chung wrote: >> Exynos5433 has the PCIe for WiFi. >> Added the codes relevant to PCIe for supporting the exynos5433. >> Also changed the binding documentation name to >&g

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

2017-12-21 Thread Jaehoon Chung
Hi Jingoo, On 12/22/2017 01:12 AM, Jingoo Han wrote: > On Thursday, December 21, 2017 7:14 AM, Jaehoon Chung wrote: >> >> Exynos5433 has the PCIe for WiFi. >> Added the codes relevant to PCIe for supporting the exynos5433. >> Also changed the binding documentation

[RFC 2/2] pci: dwc: pci-exynos: add the coedes to support the exynos5433

2017-12-21 Thread Jaehoon Chung
Exynos5433 has the PCIe for WiFi. Add the codes relevant to PCIe for supporting the exynos5433. Also changed the binding documentation name to 'samsung,exynos-pcie.txt'. (It's not only exynos5440 anymore.) Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- ...exynos5440-pc

[RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

2017-12-21 Thread Jaehoon Chung
Exynos5433 has the PCIe for WiFi. Added the codes relevant to PCIe for supporting the exynos5433. Also changed the binding documentation name to 'samsung,exynos-pcie.txt'. (It's not only exynos5440 anymore.) Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- ...exynos5440-pc

[RFC 1/2] pci: dwc: pci-exynos: modify the Kconfig dependency

2017-12-21 Thread Jaehoon Chung
PCI_EXYNOS has the dependency with SOC_EXYNOS5440. It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other SoCs needs to use this driver. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/pci/dwc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 3/5] mmc: dw_mmc: Add locking to the CTO timer

2017-10-23 Thread Jaehoon Chung
. I'm happy to re-post with > collected tags or anything else you'd like. It would be nice to get > the regression fixed sooner rather than later... Sorry. I didn't find this email in my mail-box. so i lost this. Current i'm reading the comment history..Sorry for late. Best Regards, Jaehoon Chung > > Thanks! :) > > -Doug > > >

Re: [PATCH 0/9] Enable dw-mmc multi-card support

2017-10-20 Thread Jaehoon Chung
t->num_slots will be > set to 1. So the logic of setting default num_slots seems already there. But > correct me if I am wrong. > > Thanks, > Liming > > -Original Message- > From: Shawn Lin [mailto:shawn@rock-chips.com] > Sent: Monday, Octob

Re: [PATCH v5] mmc: dw_mmc-k3: add sd support for hi3660

2017-07-05 Thread Jaehoon Chung
nts. > > Major changes in v3: > - solve review comments from Heiner Kallweit. >*use the GENMASK and FIELD_PREP macros replace the bit shift operation. >*use usleep_range() replace udelay() and mdelay(). > > Major changes in v4: > - solve review comments from J

Re: [PATCH v3] mmc: dw_mmc-k3: add sd support for hi3660

2017-06-12 Thread Jaehoon Chung
Hi, On 06/12/2017 11:27 PM, Jaehoon Chung wrote: > Hi Li, > > On 2017년 06월 12일 16:46, liwei wrote: >> Add sd card support for hi3660 soc >> >> Major changes in v3: >> - solve review comments from Heiner Kallweit. >>*use the GENMASK and FIELD_PREP

[PATCH v2] ARM: dts: rv1108: change to "max-frequency" from "clock-freq-min-max"

2017-06-09 Thread Jaehoon Chung
"clock-freq-min-max" was deprecated. There is only using in rv1108.dtsi. Use the "max-frequency" for removiing "clock-freq-min-max" in future. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Changelog on V2: - Rebased on Heiko's git repository (v4.13-

Re: [PATCH] ARM: dts: rk1108: change to "max-frequency" from "clock-freq-min-max"

2017-06-07 Thread Jaehoon Chung
Hi, On 06/06/2017 10:15 AM, Andy Yan wrote: > Hi Jaehoon: > > > 2017-06-01 12:43 GMT+08:00 Jaehoon Chung <jh80.ch...@samsung.com>: > >> "clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi. >> Use the "max-frequency" for r

[PATCH] ARM: dts: rk1108: change to "max-frequency" from "clock-freq-min-max"

2017-05-31 Thread Jaehoon Chung
"clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi. Use the "max-frequency" for removiing "clock-freq-min-max" in future. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/rk1108.dtsi | 6 +++--- 1 file changed, 3

Re: [PATCH v3 1/2] mmc: dw_mmc: Use device_property_read instead of of_property_read

2017-05-28 Thread Jaehoon Chung
@mellanox.com> > Cc: sta...@vger.linux.org Acked-by: Jaehoon Chung <jh80.ch...@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/host/dw_mmc.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/mmc/host/d

Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

2017-04-20 Thread Jaehoon Chung
hat previously used to > print the message. I think you are not using the latest kernel. which version do you use? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9 Could you check this? Best Regards, Jaehoon Chung > > Fixes

Re: [PATCH] mmc: dw_mmc: Don't allow Runtime PM for SDIO cards

2017-04-11 Thread Jaehoon Chung
t to fully runtime > suspend in this case though--at least not with the current > dw_mci_runtime_resume() which basically fully resets the controller at > resume time. > > Fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback") > Cc: <sta...@vger.kernel.org>

Re: [PATCH] mmc: core: add mmc-card hardware reset enable support

2017-04-04 Thread Jaehoon Chung
EXT_CSD_RST_N_FUNCTION, EXT_CSD_RST_N_ENABLED, > + card->ext_csd.generic_cmd6_time); > + if (err && err != -EBADMSG) > + pr_warn("%s: Enabling RST_N feature failed\n", > + mmc_hostname(card->host)); > + } If enabled hw-reset, it doesn't need to re-enable this bit. i didn't check the mmc-util.. If mmc-util provides the changing this, the using mmc-util is better than this. Best Regards, Jaehoon Chung > + > if (!oldcard) > host->card = card; > >

Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs

2017-03-21 Thread Jaehoon Chung
ext_csd.rev); I'm not sure but if someone want to know ext_csd revision information, attribute name might be more clearly. e,g) ext_csd_rev? It's my preference. :) Best Regards, Jaehoon Chung > MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); > MMC_DE

[PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

2017-03-21 Thread Jaehoon Chung
There are same conditions for checking whether supporting clkscaling or not. When ufshcd is supporting clkscaling, active_reqs should be decreased by two. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/scsi/ufs/ufshcd.c | 2 -- 1 file changed, 2 deletions(-) diff

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

2017-03-21 Thread Jaehoon Chung
gt;> In dw_mmc.c file there are also unconditional calls to >>> reset_control_assert, with disabled RESET_CONTROLLER it will cause >>> unexpected WARNs. >>> Anyway if you change reset API as above I think you should remove all >>> warns from reset stubs, because

Re: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-14 Thread Jaehoon Chung
lectrons.com> > Cc: Chen-Yu Tsai <w...@csie.org> > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Cc: Krzysztof Kozlowski <k...@kernel.org> > Cc: Jaehoon Chung <jh80.ch...@samsung.com> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-arm-...@vger.kerne

Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

2017-03-12 Thread Jaehoon Chung
Hi Vivek, On 03/12/2017 06:18 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Thu, Mar 9, 2017 at 5:26 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: >> Hi, >> >> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote: >>> Make the "sams

Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

2017-03-09 Thread Jaehoon Chung
Hi All, On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote: > On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: >> Hi, >> >> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote: >>> Make the "samsung"

[RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

2017-03-09 Thread Jaehoon Chung
Make the "samsung" directory and move the Samsung specific files to there for maintaining the files relevant to Samsung. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/phy/Kconfig | 96 +-- driv

[PATCH] phy: phy-exynos-pcie: fix the wrong error return

2017-03-08 Thread Jaehoon Chung
When it doesn't get the blk_base's resource, it was returned the error about phy_base, not blk_base. This patch is for fixing the wrong error return about blk_base. Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY") Signed-off-by: Jaehoon Chung <jh80.ch..

[PATCH] PCI: exynos: fix the NULL pointer dereference about elbi_base

2017-03-07 Thread Jaehoon Chung
Even though using phy framework, it has to get the elbi_base. Before this patch, elbi_base should be NULL pointer. Fixes: e7cd7ef58e1f ("PCI: exynos: Support the PHY generic framework") Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/pci/dwc/pci-exynos.c | 8

Re: [PATCH v4 2/2] mmc: host: s3cmci: allow probing from device tree

2017-03-05 Thread Jaehoon Chung
On 03/03/2017 08:38 PM, Sergio Prado wrote: > On Fri, Mar 03, 2017 at 11:14:29AM +0900, Jaehoon Chung wrote: >> On 03/02/2017 10:18 AM, Sergio Prado wrote: >>> Allows configuring Samsung S3C24XX MMC/SD/SDIO controller using a device >>> tree. >>> >>>

Re: [PATCH v4 1/2] dt-bindings: mmc: add DT binding for S3C24XX MMC/SD/SDIO controller

2017-03-02 Thread Jaehoon Chung
-gpios: gpio for card detection (see mmc.txt) > +- wp-gpios: gpio for write protection (see mmc.txt) I think these properties don't need to describe at here. It's common properties. Best Regards, Jaehoon Chung > + > +Example: > + > + mmc0: mmc@5a00 { > +

Re: [PATCH v4 2/2] mmc: host: s3cmci: allow probing from device tree

2017-03-02 Thread Jaehoon Chung
mci_variant_data { > + int s3c2440_compatible; > +}; I didn't understand why this structure needs. Before this patch, host->is2440; After this patch, host->variant->s3c2440_compatible; Just add the one pointer for checking s3c2400 compatible.. Is it really meaningful? (I d

[PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for pcie

2017-02-27 Thread Jaehoon Chung
bi", "config". - Can know the purpose of use with reg-names. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> --- Changelog on V3: - Split from the patches relevant to pcie - Modify the commit-message - Keep the original

Re: [PATCH V3 0/4] PCI: exynos: use the PHY generic framework

2017-02-15 Thread Jaehoon Chung
Dear Bjorn, On 02/16/2017 06:11 AM, Bjorn Helgaas wrote: > On Mon, Feb 13, 2017 at 05:26:09PM +0900, Jaehoon Chung wrote: >> This patcheset is for using PHY generic framework. >> Current pci-exyns doesn't use the phy framework since there haven't been on >> PHY subsystem whe

Re: [PATCH V3 2/4] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

2017-02-15 Thread Jaehoon Chung
Hi Vivek, On 02/15/2017 02:24 PM, Vivek Gautam wrote: > > On 02/13/2017 01:56 PM, Jaehoon Chung wrote: >> This patch adds support for Generic PHY framework about Exynos SoCs. >> Current Exynos PCIe driver doesn't use the PHY framework. >> It's making a difficult to u

[PATCH V3 0/4] PCI: exynos: use the PHY generic framework

2017-02-13 Thread Jaehoon Chung
- Removes the unnecessary codes - Change the patch's sequence - Based on latest PCI git repository.(next branch) Jaehoon Chung (4): Documetation: samsung-phy: add the exynos-pcie-phy binding phy: phy-exynos-pcie: Add support for Exynos PCIe phy Documetation: binding: modify the exynos5440 pc

[PATCH V3 3/4] Documetation: binding: modify the exynos5440 pcie binding

2017-02-13 Thread Jaehoon Chung
y, can see "mssing *config* reg space" message. Because the getting configuration space address from range is old way. NOTE: When use the "config" property, first name of 'reg-names' must be set to "elbi". Otherwise driver can't maintain the backward capability

[PATCH V3 1/4] Documetation: samsung-phy: add the exynos-pcie-phy binding

2017-02-13 Thread Jaehoon Chung
Adds the exynos-pcie-phy binding for Exynos PCIe PHY. This is for using generic PHY framework. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- Changelog on V3: - None Changelog on V2: - Remove the child node. - Add 2nd address to th

[PATCH V3 2/4] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

2017-02-13 Thread Jaehoon Chung
PCIe driver. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Acked-by: Krzysztof Kozlowski <k...@kernel.org> Reviewed-by: Jingoo Han <jingooh...@gmail.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> --- Changelog on V3: - Remove the dependency abot PCI

[PATCH V3 4/4] PCI: exynos: support the using PHY generic framework

2017-02-13 Thread Jaehoon Chung
Switch the pci-exynos driver to generic PHY framework. At the same time backward compatibility is preserved: Warning will be printed for old DTB. Refer to the binding file: - Documentation/devictree/bindings/pci/samsung,exynos5440-pcie.txt Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.

Re: [PATCH V3 0/5] PCI: exynos: cleans the minor things

2017-01-31 Thread Jaehoon Chung
On 02/01/2017 06:16 AM, Jingoo Han wrote: > On Saturday, January 28, 2017 4:28 PM, Bjorn Helgaas wrote: >> On Mon, Jan 16, 2017 at 03:31:33PM +0900, Jaehoon Chung wrote: >>> Current pci-exynos.c is used for only EXYNOS5440. >>> It's too complex to support the ot

Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support"

2017-01-23 Thread Jaehoon Chung
Hi John, On 01/23/2017 08:24 PM, John Keeping wrote: > Hi, > > On Fri, 20 Jan 2017 15:08:57 +0900, Jaehoon Chung wrote: >> On 01/17/2017 10:38 PM, Romain Perier wrote: >>> In my case I can reproduce the issue on the rock2 and the firefly-rk3288. A >>> workarou

Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support"

2017-01-19 Thread Jaehoon Chung
that, i will decide whether revert or not. Best Regards, Jaehoon Chung > > Thanks, > Romain > > > Le 17/01/2017 à 14:28, Romain Perier a écrit : >> Hello, >> >> This commit also breaks reboot and poweroff (the pmic no longer turn the >> power supply o

Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

2017-01-16 Thread Jaehoon Chung
Hi, On 01/16/2017 05:37 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 04 January 2017 06:04 PM, Jaehoon Chung wrote: >> This patch supports to use Generic Phy framework for Exynos PCIe phy. >> When Exynos that supported the pcie want to use the PCIe, >>

[PATCH V3 4/5] PCI: exynos: Use the bitops API to operate the bit shifting

2017-01-15 Thread Jaehoon Chung
Just use the bitops api to operate the bit. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof Kozlowski <k...@kernel.org> --- Changelog on V3: - None Changelog on V2: - None drivers/pci/host

[PATCH V3 3/5] PCI: exynos: Remove the unnecessary variables

2017-01-15 Thread Jaehoon Chung
Remove the unnecessary variables(elbi/phy/block_base). It needs one resource structure for assigning each resource. So it replaces with one 'res' variable. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof

[PATCH V3 0/5] PCI: exynos: cleans the minor things

2017-01-15 Thread Jaehoon Chung
- Changes the all pointer names as "ep" instead of "exynos_pcie" Jaehoon Chung (5): PCI: exynos: Rename all pointer names from "exynos_pcie" to "ep" PCI: exynos: Replace the *_blk/*_phy/*_elb accessors PCI: exynos: Remove the unnecessary variables

[PATCH V3 2/5] PCI: exynos: Replace the *_blk/*_phy/*_elb accessors

2017-01-15 Thread Jaehoon Chung
There is no reason to maintain *_blk/phy/elbi_* as register accessors. It can be replaced to one accessor for maintaining more easier. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof Kozlowski <

[PATCH V3 5/5] PCI: exynos: remove the duplicated codes

2017-01-15 Thread Jaehoon Chung
Removed the duplicated codes. It can use the more simply than now. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof Kozlowski <k...@kernel.org> --- Changelog on V3: - None Changelog on V2: - None dr

[PATCH V3 1/5] PCI: exynos: Rename all pointer names from "exynos_pcie" to "ep"

2017-01-15 Thread Jaehoon Chung
Rename the simple pointer name as "ep" instead of "exynos_pcie". After applying this patch, it can save the 10 characthers within one line. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzy

[PATCH V2 4/4] PCI: exynos: remove the duplicated codes

2017-01-11 Thread Jaehoon Chung
Removed the duplicated codes. It can use the more simply than now. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof Kozlowski <k...@kernel.org> --- Changelog on V2: - None drivers/pci/host

[PATCH V2 2/4] PCI: exynos: Remove the unnecessary variables

2017-01-11 Thread Jaehoon Chung
Remove the unnecessary variables(elbi/phy/block_base). It needs one resource structure for assigning each resource. So it replaces with one 'res' variable. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof

[PATCH V2 1/4] PCI: exynos: replace to one register accessor from each accessors

2017-01-11 Thread Jaehoon Chung
There is no reason to maintain *_blk/phy/elbi_* as register accessors. It can be replaced to one register accessor. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof Kozlowski <k...@kernel.org> -

[PATCH V2 3/4] PCI: exynos: Use the bitops API to operate the bit shifting

2017-01-11 Thread Jaehoon Chung
Just use the bitops api to operate the bit. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> Reviewed-by: Pankaj Dubey <pankaj.du...@samsung.com> Acked-by: Krzysztof Kozlowski <k...@kernel.org> --- Changelog on V2: - None drivers/pci/host/pci-exynos.c | 24 --

Re: [PATCH 1/4] PCI: exynos: replace to one register accessor from each accessors

2017-01-11 Thread Jaehoon Chung
Hi Bjorn, On 01/12/2017 03:50 AM, Bjorn Helgaas wrote: > Hi Jaehoon, > > On Mon, Dec 19, 2016 at 05:16:11PM +0900, Jaehoon Chung wrote: >> There is no reason to maintain *_blk/phy/elbi_* as register accessors. >> It can be replaced to one register accessor. >> >

Re: [BUG] Boot failure since df9bcc2bc on veyron_speedy

2017-01-09 Thread Jaehoon Chung
on as needed. >>> The fix is on the way, >>> >>> https://patchwork.kernel.org/patch/9498527/ >> Great - thanks for letting me know. > > Can you share the result ? Sorry for late. If it's working fine, I will apply it on fixes. Best Regards, Jaehoon Chung &g

Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

2017-01-09 Thread Jaehoon Chung
Hi Vivek, On 01/10/2017 03:07 PM, Vivek Gautam wrote: > Hi Jaehoon, > > > On 01/04/2017 06:04 PM, Jaehoon Chung wrote: >> This patch supports to use Generic Phy framework for Exynos PCIe phy. >> When Exynos that supported the pcie want to use the PCIe, >> it need

Re: [PATCH v4] mmc: dw_mmc: force setup bus if active slots exist

2017-01-08 Thread Jaehoon Chung
k output */ >>> +dw_mci_setup_bus(slot, true); >> >> So the spamming message about >> >> "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n" >> >> will always be there, right? So you could append a new patch to shut >> up it as I think it's useless no matter for system pm or rpm to print >> it. How about? > > Fine, it's favourable with dev_vdbg if the dw_mmc rpm is enabled. > Hi Jaehoon, > What's your opinion? If you think this patch and shawn's advice are > acceptable, I will send the v5 patch. I don't agreed to use dev_vdbg()..but it needs not to display at everytime. Hmm..It needs to consider more..because we needs to see the clock value when it's initialized. Best Regards, Jaehoon Chung > > BR > Ziyuan Xu > >> >>> } >>> >>> /* Now that slots are all setup, we can enable card detect */ >>> >> >> > > > > >

Re: [PATCH v2] PCI: exynos: refactor exynos pcie driver

2017-01-04 Thread Jaehoon Chung
pport the > differences in resources in different Exynos SoC. > > No functional change intended. > > Signed-off-by: Niyas Ahmed S T <niyas.ah...@samsung.com> > Signed-off-by: Pankaj Dubey <pankaj.du...@samsung.com> > Acked-by: Krzysztof Kozlowski <k...@kernel.org> >

Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework

2017-01-04 Thread Jaehoon Chung
On 01/05/2017 02:50 AM, Krzysztof Kozlowski wrote: > On Wed, Jan 04, 2017 at 09:34:34PM +0900, Jaehoon Chung wrote: >> This patch is for using PHY generic framework. >> To maintain backward compatibility, check whether phy is supported or >> not with 'using_phy'. >> &g

Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie

2017-01-04 Thread Jaehoon Chung
On 01/05/2017 02:58 AM, Krzysztof Kozlowski wrote: > On Wed, Jan 04, 2017 at 09:34:35PM +0900, Jaehoon Chung wrote: >> Add phy-pcie node for using Exynos5440 pcie. >> And use the reg-names as "elbi" and "config". > > 'and' is only for joining in comp

Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

2017-01-04 Thread Jaehoon Chung
On 01/05/2017 02:52 AM, Krzysztof Kozlowski wrote: > On Wed, Jan 04, 2017 at 09:34:32PM +0900, Jaehoon Chung wrote: >> This patch supports to use Generic Phy framework for Exynos PCIe phy. >> When Exynos that supported the pcie want to use the PCIe, >> it needs to cont

Re: [PATCH v2] mmc: dw_mmc: revise the reset path in runtime resume

2017-01-04 Thread Jaehoon Chung
6.321125] [] (process_one_work) from [] > (worker_thread+0x60/0x548) > [6.329215] [] (worker_thread) from [] > (kthread+0x128/0x158) > [6.336614] [] (kthread) from [] > (ret_from_fork+0x14/0x24) > [6.343836] Code: e52de004 e8bd4000 e3035d00 e34c50c0 (e5909004) &

Re: [PATCH v2] mmc: dw_mmc: revise the reset path in runtime resume

2017-01-04 Thread Jaehoon Chung
; Signed-off-by: Ziyuan Xu <xzy...@rock-chips.com> Doesn't it need Shawn's Signed-off tag? Best Regards, Jaehoon Chung > > --- > > Changes in v2: > - update the commit message > - use dw_mci_reset instead of dw_mci_ctrl_reset > > drivers/mmc/host/dw_mmc.c | 2 +-

Re: [PATCH] mmc: dw_mmc: Fix some coding style

2017-01-04 Thread Jaehoon Chung
keeping better than changing. When someone contribute the patches relevant to these, it can be also changed, (It's more meaningful.) Best Regards, Jaehoon Chung > > Signed-off-by: Ziyuan Xu <xzy...@rock-chips.com> > --- > > drivers/mmc/host/dw_mmc.c | 33 +++

[PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie

2017-01-04 Thread Jaehoon Chung
Add phy-pcie node for using Exynos5440 pcie. And use the reg-names as "elbi" and "config". Because the getting configuratioin space address from ranges is old way. It also is helpful to distinguish more clearly. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> ---

[PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy binding

2017-01-04 Thread Jaehoon Chung
Adds the exynos-pcie-phy binding for Exynos PCIe PHY. This is for using generic PHY framework. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Changelog on V2: - Remove the child node. - Add 2nd address to the parent reg prop. Documentation/devicetree/bindings/phy/samsung-phy.tx

[PATCH V2 0/5] PCI: exynos: use the PHY generic framework

2017-01-04 Thread Jaehoon Chung
the dependency - Removes the unnecessary codes - Change the patch's sequence - Based on latest PCI git repository.(next branch) Jaehoon Chung (5): Documetation: samsung-phy: add the exynos-pcie-phy binding phy: phy-exynos-pcie: Add support for Exynos PCIe phy Documetation: binding: modify

[PATCH V2 4/5] PCI: exynos: support the using PHY generic framework

2017-01-04 Thread Jaehoon Chung
This patch is for using PHY generic framework. To maintain backward compatibility, check whether phy is supported or not with 'using_phy'. And if someone use the old dt-file, display the "deprecated" message. But it's still working fine with it. Signed-off-by: Jaehoon Chun

[PATCH V2 3/5] Documetation: binding: modify the exynos5440 pcie binding

2017-01-04 Thread Jaehoon Chung
y, can see "mssing *config* reg space" message. Because the getting configuration space address from range is old way. NOTE: When use the "config" property, first name of 'reg-names' must be set to "elbi". Otherwise driver can't maintain the backward capability

[PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

2017-01-04 Thread Jaehoon Chung
the pcie. So this driver is based on Exynos5440 PCIe. In future, will support the Other exynos SoCs likes exynos5433, exynos7. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Changelog on V2: - Not include the codes relevant to pci-exynos. - Remove the getting child node. drivers/phy/K

Re: [PATCH 3/4] Documetation: binding: modify the exynos5440 pcie binding

2017-01-04 Thread Jaehoon Chung
On 01/04/2017 04:51 AM, Rob Herring wrote: > On Wed, Dec 28, 2016 at 07:34:53PM +0900, Jaehoon Chung wrote: >> According to using PHY framework, modified the exynos5440-pcie binding. >> And use "config" property to follow the designware-pcie binding. > > You

Re: [PATCH 2/4] Documetation: samsung-phy: add the exynos-pcie-phy binding

2017-01-04 Thread Jaehoon Chung
On 01/04/2017 03:05 AM, Rob Herring wrote: > On Wed, Dec 28, 2016 at 07:34:52PM +0900, Jaehoon Chung wrote: >> Adds the exynos-pcie-phy binding for Exynos PCIe PHY. >> This is for using generic PHY framework. >> >> Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.

Re: [PATCH 0/4] PCI: exynos: use the PHY generic framework

2017-01-02 Thread Jaehoon Chung
On 12/31/2016 12:56 AM, Krzysztof Kozlowski wrote: > On Wed, Dec 28, 2016 at 07:34:50PM +0900, Jaehoon Chung wrote: >> This patch is for using PHY generic framework. >> When Exynos5440 had upstreamed, there was no PHY subsytem. >> Now the using PHY framework is mandantory.

Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support"

2016-12-29 Thread Jaehoon Chung
On 12/30/2016 11:44 AM, Randy Li wrote: > > > On 12/30/2016 10:35 AM, Jaehoon Chung wrote: >> On 12/30/2016 12:07 AM, ayaka wrote: >>> >>> >>> On 12/29/2016 10:04 PM, Jaehoon Chung wrote: >>>> Hi, >>>> >>>> On 12/29/20

Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support"

2016-12-29 Thread Jaehoon Chung
On 12/30/2016 12:07 AM, ayaka wrote: > > > On 12/29/2016 10:04 PM, Jaehoon Chung wrote: >> Hi, >> >> On 12/29/2016 09:55 PM, ayaka wrote: >>> [5.849733] rk_gmac-dwmac ff29.ethernet (unnamed net_device) >>> (uninitialized): Enable RX Mitig

Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support"

2016-12-29 Thread Jaehoon Chung
(slot req > 10Hz, actual 93750HZ div = 1) > > looping here > > If I revert that patch, there are still lots of Bus speed messages, but > finally would enter into system. > Plz..Don't put the comment on the top. Which kernel did you use? > > On 12/29

Re: [1/4] pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433

2016-12-29 Thread Jaehoon Chung
V3 2 > +#define EXYNOS5433_PIN_DRV_LV4 3 Well, i'm not sure..but you needs to compare the other Exynos5 series. it's difference bit Offset. Did you check it? I didn't check pinctrl file..if it doesn't apply any exynos5433 pinctrl for drv_strength. it will work wr

Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support"

2016-12-28 Thread Jaehoon Chung
On 12/29/2016 12:02 PM, Jaehoon Chung wrote: > Hi Randy, > > On 12/29/2016 12:34 AM, Randy Li wrote: >> This reverts commit f90142683f04bcb0729bf0df67a5e29562b725b9. >> It is reported that making RK3288 can't boot from eMMC/MMC. > > Could you explain in more

Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support"

2016-12-28 Thread Jaehoon Chung
od way should be that finds the main reason and fixes it. Not just revert. Best Regards, Jaehoon Chung > > Signed-off-by: Randy Li <ay...@soulik.info> > --- > drivers/mmc/host/dw_mmc-rockchip.c | 41 > +++--- > 1 file changed, 3 insertions

[PATCH 2/4] Documetation: samsung-phy: add the exynos-pcie-phy binding

2016-12-28 Thread Jaehoon Chung
Adds the exynos-pcie-phy binding for Exynos PCIe PHY. This is for using generic PHY framework. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- .../devicetree/bindings/phy/samsung-phy.txt| 23 ++ 1 file changed, 23 insertions(+) diff --git a/Documen

[PATCH 0/4] PCI: exynos: use the PHY generic framework

2016-12-28 Thread Jaehoon Chung
://patchwork.ozlabs.org/patch/706998/ http://patchwork.ozlabs.org/patch/706997/ http://patchwork.ozlabs.org/patch/706995/ http://patchwork.ozlabs.org/patch/706994/ - Srinivas's patch http://patchwork.ozlabs.org/patch/703530/ - Pankaj's patch http://patchwork.ozlabs.org/patch/708414/ Jaehoon Chung (4): phy: exynos

[PATCH 3/4] Documetation: binding: modify the exynos5440 pcie binding

2016-12-28 Thread Jaehoon Chung
According to using PHY framework, modified the exynos5440-pcie binding. And use "config" property to follow the designware-pcie binding. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- .../bindings/pci/samsung,exynos5440-pcie.txt | 29 +- 1

[PATCH 1/4] phy: exynos-pcie: Add support for Exynos PCIe phy

2016-12-28 Thread Jaehoon Chung
-exynos.c. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/pci/host/pci-exynos.c | 198 - drivers/phy/Kconfig | 9 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-exynos-pcie.c | 289 +++

[PATCH 4/4] ARM: dts: exynos5440: support the phy-pcie node for pcie

2016-12-28 Thread Jaehoon Chung
Add phy-pcie node for using Exynos5440 pcie. And some properies are changed to generic usage. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/exynos5440.dtsi | 44 ++- 1 file changed, 34 insertions(+), 10 deletions(-) diff

  1   2   3   4   5   >