James Pearson wrote:
> Arvin Moezzi wrote:
>
>> I think that's not true. 'count' is changing through the iteration.
>> The difference in the mem_read():
>>
>> * while (count > 0) {
>> * int this_len, retval;
>> *
>> * this_len = (count
James Pearson wrote:
Arvin Moezzi wrote:
I think that's not true. 'count' is changing through the iteration.
The difference in the mem_read():
* while (count 0) {
* int this_len, retval;
*
* this_len = (count PAGE_SIZE) ? PAGE_SIZE : count;
* retval = access_process_vm
fix
through your iteration but 'count' is changing. Or am i missing
something?
Yes, you are correct ...
Thanks
James Pearson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vge
Arvin Moezzi wrote:
2007/9/19, James Pearson <[EMAIL PROTECTED]>:
+ while (count > 0) {
+ int this_len, retval;
+
+ this_len = mm->env_end - (mm->env_start + src);
+
+ if (this_len <= 0)
+
Andrew Morton wrote:
On Wed, 19 Sep 2007 14:35:29 +0100
"James Pearson" <[EMAIL PROTECTED]> wrote:
From: James Pearson <[EMAIL PROTECTED]>
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
patch needs to be c
Arvin Moezzi wrote:
2007/9/19, James Pearson [EMAIL PROTECTED]:
+ while (count 0) {
+ int this_len, retval;
+
+ this_len = mm-env_end - (mm-env_start + src);
+
+ if (this_len = 0)
+ break;
+
+ if (this_len
Andrew Morton wrote:
On Wed, 19 Sep 2007 14:35:29 +0100
James Pearson [EMAIL PROTECTED] wrote:
From: James Pearson [EMAIL PROTECTED]
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
patch needs to be carefully reviewed from the security POV
iteration but 'count' is changing. Or am i missing
something?
Yes, you are correct ...
Thanks
James Pearson
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: James Pearson <[EMAIL PROTECTED]>
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Signed-off-by: James Pearson <[EMAIL PROTECTED]>
---
Patch against 2.6.23-rc6-mm1
--- ./fs/proc/base.c.dist 2007-09-19 12:29:46.244
From: James Pearson [EMAIL PROTECTED]
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Signed-off-by: James Pearson [EMAIL PROTECTED]
---
Patch against 2.6.23-rc6-mm1
--- ./fs/proc/base.c.dist 2007-09-19 12:29:46.244929651 +0100
+++ ./fs
H. Peter Anvin wrote:
>
> Right, also please use use checkpatch.pl.
>
OK - how about:
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Patch against 2.6.23-rc5
Signed-off-by: James Pearson <[EMAIL PROTECTED]>
--- ./fs/p
Alexey Dobriyan wrote:
On Wed, Sep 05, 2007 at 06:00:57PM +0100, James Pearson wrote:
H. Peter Anvin wrote:
Anton Arapov wrote:
Hey guys, the future of this patch is important for me. What do you
think, has this patch any chances to be committed to upstream?
James Pearson <[EM
to my mail app mangled the patch - I'll
re-submit it 'cleanly' ...
Thanks
James Pearson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
H. Peter Anvin wrote:
Right, also please use use checkpatch.pl.
OK - how about:
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Patch against 2.6.23-rc5
Signed-off-by: James Pearson [EMAIL PROTECTED]
--- ./fs/proc/base.c.dist 2007
H. Peter Anvin wrote:
Anton Arapov wrote:
Hey guys, the future of this patch is important for me. What do you
think, has this patch any chances to be committed to upstream?
James Pearson <[EMAIL PROTECTED]> writes:
H. Peter Anvin wrote:
There isn't that much that is dupl
H. Peter Anvin wrote:
Anton Arapov wrote:
Hey guys, the future of this patch is important for me. What do you
think, has this patch any chances to be committed to upstream?
James Pearson [EMAIL PROTECTED] writes:
H. Peter Anvin wrote:
There isn't that much that is duplicated
H. Peter Anvin wrote:
Guy Streeter wrote:
On 6/1/06, James Pearson <[EMAIL PROTECTED]> wrote:
H. Peter Anvin wrote:
I think this is the wrong approach.
Many of these should probably be converted to seq_file, but in the
particular case of environ, the right approach is to observe th
H. Peter Anvin wrote:
Guy Streeter wrote:
On 6/1/06, James Pearson [EMAIL PROTECTED] wrote:
H. Peter Anvin wrote:
I think this is the wrong approach.
Many of these should probably be converted to seq_file, but in the
particular case of environ, the right approach is to observe the fact
Eric Dumazet wrote:
On Fri, 04 May 2007 15:30:57 +0100
James Pearson <[EMAIL PROTECTED]> wrote:
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Signed-off-by: James Pearson <[EMAIL PROTECTED]>
What about latency when read
Eric Dumazet wrote:
On Fri, 04 May 2007 15:30:57 +0100
James Pearson [EMAIL PROTECTED] wrote:
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Signed-off-by: James Pearson [EMAIL PROTECTED]
What about latency when reading one *big* environ
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Signed-off-by: James Pearson <[EMAIL PROTECTED]>
--- ./fs/proc/base.c.dist 2007-04-26 04:08:32.0 +0100
+++ ./fs/proc/base.c2007-04-27 16:32:44.277664457 +0100
@@ -196,22
/proc/PID/environ currently truncates at 4096 characters, patch based on
the /proc/PID/mem code.
Signed-off-by: James Pearson [EMAIL PROTECTED]
--- ./fs/proc/base.c.dist 2007-04-26 04:08:32.0 +0100
+++ ./fs/proc/base.c2007-04-27 16:32:44.277664457 +0100
@@ -196,22 +196,6
Antonino A. Daplas wrote:
On Tue, 2007-05-01 at 13:17 +0100, James Pearson wrote:
Antonino A. Daplas wrote:
On Mon, 2007-04-30 at 13:58 +0100, James Pearson wrote:
Antonino A. Daplas wrote:
On Fri, 2007-04-27 at 18:08 +0100, James Pearson wrote:
It does indeed seem
Antonino A. Daplas wrote:
On Mon, 2007-04-30 at 13:58 +0100, James Pearson wrote:
Antonino A. Daplas wrote:
On Fri, 2007-04-27 at 18:08 +0100, James Pearson wrote:
I have a problem whereby the X display 'shifts' to left when anything
writes to /dev/console - where console screen blanking
Antonino A. Daplas wrote:
On Mon, 2007-04-30 at 13:58 +0100, James Pearson wrote:
Antonino A. Daplas wrote:
On Fri, 2007-04-27 at 18:08 +0100, James Pearson wrote:
I have a problem whereby the X display 'shifts' to left when anything
writes to /dev/console - where console screen blanking
Antonino A. Daplas wrote:
On Tue, 2007-05-01 at 13:17 +0100, James Pearson wrote:
Antonino A. Daplas wrote:
On Mon, 2007-04-30 at 13:58 +0100, James Pearson wrote:
Antonino A. Daplas wrote:
On Fri, 2007-04-27 at 18:08 +0100, James Pearson wrote:
It does indeed seem
Antonino A. Daplas wrote:
On Fri, 2007-04-27 at 18:08 +0100, James Pearson wrote:
I have a problem whereby the X display 'shifts' to left when anything
writes to /dev/console - where console screen blanking has been disabled
i.e. doing something like:
boot to run level 3
If not root
Antonino A. Daplas wrote:
On Fri, 2007-04-27 at 18:08 +0100, James Pearson wrote:
I have a problem whereby the X display 'shifts' to left when anything
writes to /dev/console - where console screen blanking has been disabled
i.e. doing something like:
boot to run level 3
If not root
and running X, but something isn't right somewhere ...
Any ideas?
Thanks
James Pearson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pleas
, but something isn't right somewhere ...
Any ideas?
Thanks
James Pearson
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
something/some setting(s) that can do this in a multi-CPU machine?
Thanks
James Pearson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please r
setting(s) that can do this in a multi-CPU machine?
Thanks
James Pearson
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
I've worked out what the problem is - this machine has more than 4GB
memory and I didn't have IOMMU compiled in - rebuilding the kernel with
this set and the problem goes away.
James Pearson
James Pearson wrote:
I'm using a Dell PowerEdge 2850 with dual 3.6Ghz Xeon EM64T CPUs.
Using a vanilla
I've worked out what the problem is - this machine has more than 4GB
memory and I didn't have IOMMU compiled in - rebuilding the kernel with
this set and the problem goes away.
James Pearson
James Pearson wrote:
I'm using a Dell PowerEdge 2850 with dual 3.6Ghz Xeon EM64T CPUs.
Using a vanilla
I'm using a Dell PowerEdge 2850 with dual 3.6Ghz Xeon EM64T CPUs.
Using a vanilla 2.4.30 SMP x86_64 kernel, when I try to modprobe
usb-uhci I get:
kernel BUG in header file at line 160
Kernel BUG at panic:149
invalid operand:
dmesg and ksymoops output below.
Thanks
James Pearson
dmesg
I'm using a Dell PowerEdge 2850 with dual 3.6Ghz Xeon EM64T CPUs.
Using a vanilla 2.4.30 SMP x86_64 kernel, when I try to modprobe
usb-uhci I get:
kernel BUG in header file at line 160
Kernel BUG at panic:149
invalid operand:
dmesg and ksymoops output below.
Thanks
James Pearson
dmesg
36 matches
Mail list logo
