Re: [PATCH v3] scripts/gdb: fix lx-version

2018-11-05 Thread Jan Kiszka
, and this is it. Fixes: 2d061d999424 ("scripts/gdb: add version command") Reviewed-by: Kieran Bingham And for reference, this already has an early LGTM from Jan as well. [0] https://sourceware.org/bugzilla/show_bug.cgi?id=20077 Acked-by: Jan Kiszka Jan --- scripts/gdb/linux/proc.py | 2 +- 1 fi

[tip:x86/urgent] x86/entry/32: Clear the CS high bits

2018-10-18 Thread tip-bot for Jan Kiszka
Commit-ID: 04f4f954b69526d7af8ffb8e5780f08b8a6cda2d Gitweb: https://git.kernel.org/tip/04f4f954b69526d7af8ffb8e5780f08b8a6cda2d Author: Jan Kiszka AuthorDate: Mon, 15 Oct 2018 16:09:29 +0200 Committer: Ingo Molnar CommitDate: Wed, 17 Oct 2018 12:30:20 +0200 x86/entry/32: Clear the CS

Re: [PATCH] scripts/gdb: fix lx-version for gdb 7.3-

2018-10-17 Thread Jan Kiszka
On 17.10.18 04:36, Du Changbin wrote: For gdb version less than 7.3, lx-version only one character. ^^^ prints? (gdb) lx-version L(gdb) This can be fixed by casting 'linux_banner' as (char *). (gdb) lx-version Linux version 4.19.0-rc1+

[tip:x86/urgent] x86/entry/32: Clear the CS high bits

2018-10-15 Thread tip-bot for Jan Kiszka
Commit-ID: 8cad6c58c9effb59b830bcf0103d8267ad2e312d Gitweb: https://git.kernel.org/tip/8cad6c58c9effb59b830bcf0103d8267ad2e312d Author: Jan Kiszka AuthorDate: Mon, 15 Oct 2018 16:09:29 +0200 Committer: Borislav Petkov CommitDate: Mon, 15 Oct 2018 16:54:28 +0200 x86/entry/32: Clear

[PATCH v2] x86/entry/32: Fix setup of CS high bits

2018-10-15 Thread Jan Kiszka
Entry-Stack") Signed-off-by: Jan Kiszka Acked-by: Joerg Roedel Reviewed-by: Joerg Roedel --- Changes in v2: - adjust comment according to Andy's feedback - added Jörg's ack/review (assuming the comment change does not affect it) arch/x86/entry/entry_32.S | 13 +++-- 1 file

Re: [PATCH] x86/entry/32: Fix setup of CS high bits

2018-10-15 Thread Jan Kiszka
On 15.10.18 15:14, David Laight wrote: From: Jan Kiszka Sent: 15 October 2018 14:09 ... Those fields are genuinely 16 bit. So the comment should say something like "Those high bits are used for CS_FROM_ENTRY_STACK and CS_FROM_USER_CR3". /* * The high bits of the CS dw

Re: [PATCH] x86/entry/32: Fix setup of CS high bits

2018-10-15 Thread Jan Kiszka
On 13.10.18 17:12, Andy Lutomirski wrote: On Sat, Oct 13, 2018 at 3:02 AM Jan Kiszka wrote: From: Jan Kiszka Even if we are not on an entry stack, we have to initialize the CS high bits because we are unconditionally evaluating them PARANOID_EXIT_TO_KERNEL_MODE. Failing to do so broke

[PATCH] x86/entry/32: Fix setup of CS high bits

2018-10-13 Thread Jan Kiszka
From: Jan Kiszka Even if we are not on an entry stack, we have to initialize the CS high bits because we are unconditionally evaluating them PARANOID_EXIT_TO_KERNEL_MODE. Failing to do so broke the boot on Galileo Gen2 and IOT2000 boards. Fixes: b92a165df17e ("x86/entry/32: Handle Entry

Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-10-12 Thread Jan Kiszka
On 18.07.18 11:40, Joerg Roedel wrote: From: Joerg Roedel It can happen that we enter the kernel from kernel-mode and on the entry-stack. The most common way this happens is when we get an exception while loading the user-space segment registers on the kernel-to-userspace exit path. The

Re: [PATCH] serial: mvebu-uart: Fix reporting of effective CSIZE to userspace

2018-08-27 Thread Jan Kiszka
On 2018-08-26 19:49, Jan Kiszka wrote: > From: Jan Kiszka > > Apparently, this driver (or the hardware) does not support character > length settings. It's apparently running in 8-bit mode, but it makes > userspace believe it's in 5-bit mode. That makes tcsetattr with CS8 >

[PATCH] serial: mvebu-uart: Fix reporting of effective CSIZE to userspace

2018-08-26 Thread Jan Kiszka
From: Jan Kiszka Apparently, this driver (or the hardware) does not support character length settings. It's apparently running in 8-bit mode, but it makes userspace believe it's in 5-bit mode. That makes tcsetattr with CS8 incorrectly fail, breaking e.g. getty from busybox, thus the login shell

Re: [PATCH v2] PCI: controller: Move PCI_DOMAINS selection to arch Kconfig

2018-06-20 Thread Jan Kiszka
> Link: https://lkml.kernel.org/r/20180612170229.ga10...@roeck-us.net > Reported-by: Guenter Roeck > Signed-off-by: Lorenzo Pieralisi > Cc: Scott Branden > Cc: Will Deacon > Cc: Bjorn Helgaas > Cc: Rob Herring > Cc: Russell King > Cc: Jan Kiszka > Cc: Guenter Roeck &

Re: [PATCH] arm: Initialize hrtimer-based broadcast clockevent

2018-06-10 Thread Jan Kiszka
On 2018-04-04 17:54, Jan Kiszka wrote: > On 2018-03-01 07:04, Jan Kiszka wrote: >> On 2018-01-22 07:06, Jan Kiszka wrote: >>> Analogously to 9358d755bd5c, this registers a broadcast clockevent in >>> case no hardware broadcast timer is available and the per-CPU timers

Re: [PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device

2018-05-28 Thread Jan Kiszka
On 2018-05-28 12:00, Vladimir Zapolskiy wrote: > Hi Jan, Bjorn, > > On 05/15/2018 12:07 PM, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> Another step towards a managed version of >> of_pci_get_host_bridge_resources(): Feed in the

[PATCH] PCI: Clean up resource allocation in devm_of_pci_get_host_bridge_resources()

2018-05-16 Thread Jan Kiszka
Instead of first allocating and then freeing memory for struct resource in case we cannot parse a PCI resource from the device tree, work against a local struct and kmemdup it when we decide to go with it. Suggested-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jan

[PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Another step towards a managed version of of_pci_get_host_bridge_resources(): Feed in the underlying device, rather than just the OF node. This will allow to use managed resource allocation internally later on. CC: Jingoo Han <jingooh...@gmai

[PATCH v4 3/8] PCI: Rename device node parameter of of_pci_get_host_bridge_resources()

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> We will add a real device parameter to this function soon. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/of.c | 18 +- include/linux/of_pci.h | 4 ++-- 2 files changed, 11 insertions(+), 11 deleti

[PATCH v4 1/8] PCI: Make pci_get_new_domain_nr() static

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> The only user of pci_get_new_domain_nr() is of_pci_bus_find_domain_nr(). Since they are defined in the same compilation unit, pci_get_new_domain_nr() can be made static, which also simplifies preprocessor conditionals. No functional change in

[PATCH v4 0/8] PCI: leak fixes, removable generic PCI host, assorted stuff

2018-05-15 Thread Jan Kiszka
/hypermail/linux/kernel/1606.3/00072.html CC: Jingoo Han <jingooh...@gmail.com> CC: Joao Pinto <joao.pi...@synopsys.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> CC: Will Deacon <will.dea...@arm.com> Jan Kiszka (8): PCI: Make pci_get_new_domain_nr() stati

[PATCH v4 8/8] PCI: Enable PCI_DOMAINS along with generic PCI host controller

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> This controller is often instantiated by hypervisors, and they may add multiple of them or add them in addition to a physical host controller like the Jailhouse hypervisor is doing. Therefore allow for multiple domains so that we can handle th

[PATCH v4 7/8] PCI: Add support for unbinding the generic PCI host controller

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Particularly useful when working in virtual environments where the controller may come and go, but possibly not only there. CC: Will Deacon <will.dea...@arm.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Signed-off-by: J

[PATCH v4 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> of_pci_get_host_bridge_resources() allocates the resource structures it fills dynamically, but none of its callers care to release them so far. Rather than requiring everyone to do this explicitly, convert the existing function to a managed versio

[PATCH v4 2/8] PCI: Fix memory leak of devm_pci_alloc_host_bridge()

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> devm_pci_release_host_bridge_dev() failed to release the resource list. Fixes: 5c3f18cce083 ("PCI: Add devm_pci_alloc_host_bridge() interface") Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/probe.c | 4 +

[PATCH v4 5/8] PCI: Replace pr_*() with dev_*() in of_pci_get_host_bridge_resources()

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Now that we have a device reference, make use of it for printing. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/of.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/driver

Re: [PATCH v3 0/8] PCI: leak fixes, removable generic PCI host, assorted stuff

2018-05-15 Thread Jan Kiszka
On 2018-05-15 09:58, Vladimir Zapolskiy wrote: > Hi Jan, > > On 05/15/2018 08:58 AM, Jan Kiszka wrote: >> Changes in v3: >> - refactor series to be both bisectable and simpler while reworking >>of_pci_get_host_bridge_resources() >> - include of_pci_ge

Re: [PATCH v3 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Jan Kiszka
On 2018-05-15 09:54, Vladimir Zapolskiy wrote: > Hi Jan, > > On 05/15/2018 08:58 AM, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> of_pci_get_host_bridge_resources() allocates the resource structures it >> fills dynamically, but none

[PATCH v3 2/8] PCI: Fix memory leak of devm_pci_alloc_host_bridge()

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> devm_pci_release_host_bridge_dev() failed to release the resource list. Fixes: 5c3f18cce083 ("PCI: Add devm_pci_alloc_host_bridge() interface") Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/probe.c | 4 +

[PATCH v3 8/8] PCI: Enable PCI_DOMAINS along with generic PCI host controller

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> This controller is often instantiated by hypervisors, and they may add multiple of them or add them in addition to a physical host controller like the Jailhouse hypervisor is doing. Therefore allow for multiple domains so that we can handle th

[PATCH v3 5/8] PCI: Replace pr_*() with dev_*() in of_pci_get_host_bridge_resources()

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Now that we have a device reference, make use of it for printing. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/of.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/driver

[PATCH v3 1/8] PCI: Make pci_get_new_domain_nr() static

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> The only user of pci_get_new_domain_nr() is of_pci_bus_find_domain_nr(). Since they are defined in the same compilation unit, pci_get_new_domain_nr() can be made static, which also simplifies preprocessor conditionals. No functional change in

[PATCH v3 0/8] PCI: leak fixes, removable generic PCI host, assorted stuff

2018-05-15 Thread Jan Kiszka
t;joao.pi...@synopsys.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> CC: Will Deacon <will.dea...@arm.com> Jan Kiszka (8): PCI: Make pci_get_new_domain_nr() static PCI: Fix memory leak of devm_pci_alloc_host_bridge() PCI: Rename device node parameter of of_pci_get_host_

[PATCH v3 7/8] PCI: Add support for unbinding the generic PCI host controller

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Particularly useful when working in virtual environments where the controller may come and go, but possibly not only there. CC: Will Deacon <will.dea...@arm.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Signed-off-by: J

[PATCH v3 6/8] PCI: Rework of_pci_get_host_bridge_resources() to devm_of_pci_get_host_bridge_resources()

2018-05-15 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> of_pci_get_host_bridge_resources() allocates the resource structures it fills dynamically, but none of its callers care to release them so far. Rather than requiring everyone to do this explicitly, convert the existing function to a managed versio

[PATCH v3 3/8] PCI: Rename device node parameter of of_pci_get_host_bridge_resources()

2018-05-14 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> We will add a real device parameter to this function soon. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/of.c | 18 +- include/linux/of_pci.h | 4 ++-- 2 files changed, 11 insertions(+), 11 deleti

[PATCH v3 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device

2018-05-14 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Another step towards a managed version of of_pci_get_host_bridge_resources(): Feed in the underlying device, rather than just the OF node. This will allow to use managed resource allocation internally later on. CC: Jingoo Han <jingooh...@gmai

[PATCH v3 08/10] PCI: Remove of_pci_get_host_bridge_resources()

2018-05-09 Thread Jan Kiszka
There are no in-tree users remaining, all are converted to the managed variant. And it is unlikely that any out-of-tree user got the resource management right as well. So remove the interface. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- This replaces "PCI

Re: [PATCH v2] KVM: X86: Limit timer frequency to 200ms

2018-05-05 Thread Jan Kiszka
On 2018-05-05 01:44, Wanpeng Li wrote: > ping, > 2018-05-01 7:35 GMT+08:00 Wanpeng Li : >> From: Wanpeng Li >> >> Anthoine reported: >> The period used by Windows change over time but it can be 1 milliseconds >> or less. I saw the

Re: [PATCH v2 08/10] PCI: Deprecate of_pci_get_host_bridge_resources()

2018-05-03 Thread Jan Kiszka
On 2018-05-02 14:39, Christoph Hellwig wrote: > On Mon, Apr 30, 2018 at 07:48:42AM +0200, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> There are no in-tree users remaining, all are converted to the managed >> variant. And it is unlik

Re: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff

2018-05-03 Thread Jan Kiszka
Hey Vladimir, On 2018-05-03 09:12, Vladimir Zapolskiy wrote: > Hi Jan, > > On 04/30/2018 08:48 AM, Jan Kiszka wrote: >> Changes in v2: >> - patch 1: commit message reworking as suggested by Lorenzo >> - patch 3-6: split-up as suggested by Bjorn >> - pa

Re: [PATCH 3/6] PCI: Introduce devm_of_pci_get_host_bridge_resources

2018-05-01 Thread Jan Kiszka
On 2018-04-30 20:43, Sinan Kaya wrote: > On 4/30/2018 2:40 PM, Bjorn Helgaas wrote: >> On Sat, Apr 28, 2018 at 09:28:47AM +0200, Jan Kiszka wrote: >>> On 2018-04-28 00:24, Bjorn Helgaas wrote: >>>> On Tue, Apr 24, 2018 at 05:13:39PM +0200, Jan Kiszka wrote: &

[PATCH v2 01/10] PCI: Make pci_get_new_domain_nr() static

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> The only user of pci_get_new_domain_nr() is of_pci_bus_find_domain_nr(). Since they are defined in the same compilation unit, pci_get_new_domain_nr() can be made static, which also simplifies preprocessor conditionals. No functional change in

[PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff

2018-04-29 Thread Jan Kiszka
Pinto <joao.pi...@synopsys.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> CC: Will Deacon <will.dea...@arm.com> Jan Kiszka (10): PCI: Make pci_get_new_domain_nr() static PCI: Fix memory leak of devm_pci_alloc_host_bridge() PCI: Factor out __of_pci_get_host_bridge_re

[PATCH v2 10/10] PCI: Enable PCI_DOMAINS along with generic PCI host controller

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> This controller is often instantiated by hypervisors, and they may add multiple of them or add them in addition to a physical host controller like the Jailhouse hypervisor is doing. Therefore allow for multiple domains so that we can handle th

[PATCH v2 05/10] PCI: Replace pr_*() with dev_*() in __of_pci_get_host_bridge_resources()

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Now that we have a device reference, make use of it for printing. And as long as dev can still be NULL, we will still get some reasonable output nevertheless. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/p

[PATCH v2 08/10] PCI: Deprecate of_pci_get_host_bridge_resources()

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> There are no in-tree users remaining, all are converted to the managed variant. And it is unlikely that any out-of-tree user got the resource management right as well. So deprecate the interface and push users to the managed version instead. To

[PATCH v2 04/10] PCI: Add dev parameter to __of_pci_get_host_bridge_resources()

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> When non-NULL, use the new dev parameter of __of_pci_get_host_bridge_resources() to allocate the resource data structures via devm_kzalloc. That allows to release them automatically during device destruction. Signed-off-by: Jan Kiszka &l

[PATCH v2 06/10] PCI: Introduce devm_of_pci_get_host_bridge_resources()

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> of_pci_get_host_bridge_resources() allocates the resource structures it fills dynamically, but none of its callers care to release them so far. Rather than requiring everyone to do this explicitly, introduce a managed version of that service. This d

[PATCH v2 03/10] PCI: Factor out __of_pci_get_host_bridge_resources()

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> This will be needed for sharing the core logic between current of_pci_get_host_bridge_resources() and upcoming devm_of_pci_get_host_bridge_resources(). Already rename the dev parameter to dev_node in order to free the namespace for a real

[PATCH v2 09/10] PCI: Add support for unbinding the generic PCI host controller

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Particularly useful when working in virtual environments where the controller may come and go, but possibly not only there. CC: Will Deacon <will.dea...@arm.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Signed-off-by: J

[PATCH v2 02/10] PCI: Fix memory leak of devm_pci_alloc_host_bridge()

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> devm_pci_release_host_bridge_dev() failed to release the resource list. Fixes: 5c3f18cce083 ("PCI: Add devm_pci_alloc_host_bridge() interface") Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/probe.c | 4 +

[PATCH v2 07/10] PCI: Convert of_pci_get_host_bridge_resources() users to devm variant

2018-04-29 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Straightforward for all of them, no more leaks afterwards. CC: Jingoo Han <jingooh...@gmail.com> CC: Joao Pinto <joao.pi...@synopsys.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Signed-off-by: Jan Kiszka <ja

Re: [PATCH 3/6] PCI: Introduce devm_of_pci_get_host_bridge_resources

2018-04-28 Thread Jan Kiszka
On 2018-04-28 00:24, Bjorn Helgaas wrote: > On Tue, Apr 24, 2018 at 05:13:39PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> of_pci_get_host_bridge_resources allocates the resource structures it >> fills dynamically, but none of its ca

Re: [PATCH] [v3] x86: Convert x86_platform_ops to timespec64

2018-04-28 Thread Jan Kiszka
tic void xen_read_wallclock(struct timespec64 *ts) > { > struct shared_info *s = HYPERVISOR_shared_info; > struct pvclock_wall_clock *wall_clock = &(s->wc); > @@ -68,12 +68,12 @@ static void xen_read_wallclock(struct timespec *ts) > put_cpu_var(xen_vcpu); > } > > -static void xen_get_wallclock(struct timespec *now) > +static void xen_get_wallclock(struct timespec64 *now) > { > xen_read_wallclock(now); > } > > -static int xen_set_wallclock(const struct timespec *now) > +static int xen_set_wallclock(const struct timespec64 *now) > { > return -ENODEV; > } > @@ -461,7 +461,7 @@ static void __init xen_time_init(void) > { > struct pvclock_vcpu_time_info *pvti; > int cpu = smp_processor_id(); > - struct timespec tp; > + struct timespec64 tp; > > /* As Dom0 is never moved, no penalty on using TSC there */ > if (xen_initial_domain()) > @@ -479,7 +479,7 @@ static void __init xen_time_init(void) > > /* Set initial system time with full resolution */ > xen_read_wallclock(); > - do_settimeofday(); > + do_settimeofday64(); > > setup_force_cpu_cap(X86_FEATURE_TSC); > > For the few Jailhouse bits. Acked-by: Jan Kiszka <jan.kis...@siemens.com>

[PATCH v2] of: overlay: Stop leaking resources on overlay removal

2018-04-26 Thread Jan Kiszka
of ovcs->overlay_tree and ovcs->fdt from free_overlay_changeset. See also https://lkml.org/lkml/2018/4/23/1063 and following. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- Documentation/devicetree/overlay-notes.txt | 8 drivers/of/overlay.c

Re: [PATCH] of: overlay: Stop leaking resources on overlay removal

2018-04-26 Thread Jan Kiszka
On 2018-04-26 02:44, Frank Rowand wrote: > On 04/25/18 17:32, Frank Rowand wrote: >> Hi Jan, >> >> On 04/24/18 13:58, Frank Rowand wrote: >>> On 04/24/18 10:50, Jan Kiszka wrote: >>>> On 2018-04-24 19:44, Frank Rowand wrote: >>>>> On

Re: [PATCH 6/6] arm: Allow to enable PCI_DOMAINS manually

2018-04-26 Thread Jan Kiszka
On 2018-04-25 19:54, Lorenzo Pieralisi wrote: > On Tue, Apr 24, 2018 at 05:13:42PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> Required when running over Jailhouse, and there is already a physical >> host controller that Jailhouse d

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-25 Thread Jan Kiszka
On 2018-04-25 21:53, Geert Uytterhoeven wrote: > Hi Jan, > > On Wed, Apr 25, 2018 at 9:40 PM, Jan Kiszka <jan.kis...@web.de> wrote: >> What other pointers are we talking about? > > There's also the issue that some data has been allocated using kmalloc(), > w

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-25 Thread Jan Kiszka
On 2018-04-25 20:40, Frank Rowand wrote: > On 04/24/18 22:23, Jan Kiszka wrote: >> On 2018-04-24 22:56, Frank Rowand wrote: >>> Hi Alan, >>> >>> On 04/23/18 15:38, Frank Rowand wrote: >>>> Hi Jan, >>>> >>>> + Alan

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-25 Thread Jan Kiszka
On 2018-04-25 21:02, Frank Rowand wrote: > On 04/25/18 11:56, Frank Rowand wrote: >> On 04/24/18 22:22, Jan Kiszka wrote: >>> On 2018-04-24 23:15, Frank Rowand wrote: >>>> On 04/23/18 22:29, Jan Kiszka wrote: >>>>> On 2018-04-24 00:38, Frank Rowand wr

Re: [PATCH 1/6] PCI: Make pci_get_new_domain_nr static

2018-04-25 Thread Jan Kiszka
On 2018-04-25 18:27, Lorenzo Pieralisi wrote: > On Tue, Apr 24, 2018 at 05:13:37PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> The only user of that function is of_pci_bus_find_domain_nr. Pure >> cleanup. > >

Re: [PATCH 3/6] PCI: Introduce devm_of_pci_get_host_bridge_resources

2018-04-25 Thread Jan Kiszka
On 2018-04-24 17:13, Jan Kiszka wrote: > From: Jan Kiszka <jan.kis...@siemens.com> > > of_pci_get_host_bridge_resources allocates the resource structures it > fills dynamically, but none of its callers care to release them so far. > Rather than requiring everyone to do this

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-24 Thread Jan Kiszka
On 2018-04-24 20:26, Alan Tull wrote: > On Tue, Apr 24, 2018 at 11:08 AM, Alan Tull <at...@kernel.org> wrote: >> On Tue, Apr 24, 2018 at 12:29 AM, Jan Kiszka <jan.kis...@web.de> wrote: >>> >>> We have drivers/fpga/of-fpga-region.c in-tree, and that

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-24 Thread Jan Kiszka
On 2018-04-24 22:56, Frank Rowand wrote: > Hi Alan, > > On 04/23/18 15:38, Frank Rowand wrote: >> Hi Jan, >> >> + Alan Tull for fpga perspective >> >> On 04/22/18 03:30, Jan Kiszka wrote: >>> On 2018-04-11 07:42, Jan Kiszka wrote: >>>>

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-24 Thread Jan Kiszka
On 2018-04-24 23:15, Frank Rowand wrote: > On 04/23/18 22:29, Jan Kiszka wrote: >> On 2018-04-24 00:38, Frank Rowand wrote: >>> Hi Jan, >>> >>> + Alan Tull for fpga perspective >>> >>> On 04/22/18 03:30, Jan Kiszka wrote: >>>> On

Re: [PATCH] of: overlay: Stop leaking resources on overlay removal

2018-04-24 Thread Jan Kiszka
On 2018-04-24 19:44, Frank Rowand wrote: > On 04/24/18 09:19, Jan Kiszka wrote: >> Only the overlay notifier callbacks have a chance to potentially get >> hold of references to those two resources, but they do not store them. >> So it is safe to stop the intentional leaking.

[PATCH] of: overlay: Stop leaking resources on overlay removal

2018-04-24 Thread Jan Kiszka
Only the overlay notifier callbacks have a chance to potentially get hold of references to those two resources, but they do not store them. So it is safe to stop the intentional leaking. See also https://lkml.org/lkml/2018/4/23/1063 and following. Signed-off-by: Jan Kiszka <jan.

Re: [PATCH] kmemleak: Report if we need to tune KMEMLEAK_EARLY_LOG_SIZE

2018-04-24 Thread Jan Kiszka
On 2018-04-24 17:55, Catalin Marinas wrote: > On Tue, Apr 24, 2018 at 05:51:15PM +0200, Jan Kiszka wrote: >> ...rather than just mysteriously disabling it. >> >> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> >> --- >> mm/kmemleak.c | 1 + >> 1

[PATCH] kmemleak: Report if we need to tune KMEMLEAK_EARLY_LOG_SIZE

2018-04-24 Thread Jan Kiszka
...rather than just mysteriously disabling it. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- mm/kmemleak.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 9a085d525bbc..156c0c69cc5c 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -863,6

[PATCH 1/6] PCI: Make pci_get_new_domain_nr static

2018-04-24 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> The only user of that function is of_pci_bus_find_domain_nr. Pure cleanup. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/pci.c | 6 ++ include/linux/pci.h | 3 --- 2 files changed, 2 insertions(+), 7 deletions(-)

[PATCH 4/6] PCI: Convert of_pci_get_host_bridge_resources users to devm variant

2018-04-24 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Straightforward for all of them, no more leaks afterwards. CC: Jingoo Han <jingooh...@gmail.com> CC: Joao Pinto <joao.pi...@synopsys.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Signed-off-by: Jan Kiszka <jan.kis..

[PATCH 6/6] arm: Allow to enable PCI_DOMAINS manually

2018-04-24 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Required when running over Jailhouse, and there is already a physical host controller that Jailhouse does not intercept and rather adds a virtual one. That is the case for the Tegra TK1, e.g. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com&g

[PATCH 0/6] PCI: leak fixes, removable generic PCI host, assorted stuff

2018-04-24 Thread Jan Kiszka
<jingooh...@gmail.com> CC: Joao Pinto <joao.pi...@synopsys.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> CC: Will Deacon <will.dea...@arm.com> Jan Kiszka (6): PCI: Make pci_get_new_domain_nr static PCI: Fix memory leak of devm_pci_alloc_host

[PATCH 5/6] PCI: Add support for unbinding the generic PCI host controller

2018-04-24 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Particularly useful when working in virtual environments where the controller may come and go, but possibly not only there. CC: Will Deacon <will.dea...@arm.com> CC: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> Signed-off-by: J

[PATCH 3/6] PCI: Introduce devm_of_pci_get_host_bridge_resources

2018-04-24 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> of_pci_get_host_bridge_resources allocates the resource structures it fills dynamically, but none of its callers care to release them so far. Rather than requiring everyone to do this explicitly, introduce a managed version of that service. This d

[PATCH 2/6] PCI: Fix memory leak of devm_pci_alloc_host_bridge

2018-04-24 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> devm_pci_release_host_bridge_dev failed to release the resource list. Fixes: 5c3f18cce083 ("PCI: Add devm_pci_alloc_host_bridge() interface") Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- drivers/pci/probe.c | 4 +

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-23 Thread Jan Kiszka
On 2018-04-24 00:38, Frank Rowand wrote: > Hi Jan, > > + Alan Tull for fpga perspective > > On 04/22/18 03:30, Jan Kiszka wrote: >> On 2018-04-11 07:42, Jan Kiszka wrote: >>> On 2018-04-05 23:12, Rob Herring wrote: >>>> On Thu, Apr 5, 2018 at 2:2

Re: BUG: KASAN: global-out-of-bounds in unmap_kernel_at_el0+0x70/0x1a0

2018-04-23 Thread Jan Kiszka
On 2018-04-23 12:29, Mark Rutland wrote: > On Mon, Apr 23, 2018 at 07:00:52AM +0200, Jan Kiszka wrote: >> On 2018-04-22 21:06, Mark Rutland wrote: > >>> Does the below help? > >>> From ade322407e3d6d1f50e558ebd50d2c1c7bd811c2 Mon Sep 17 00:00:00 2001 >>>

Re: [patch 1/9] x86/jailhouse: Fix incorrect SPDX identifier

2018-04-23 Thread Jan Kiszka
On 2018-04-23 00:02, Thomas Gleixner wrote: > GPL2.0 is not a valid SPDX identiier. Replace it with GPL-2.0. > > Fixes: 4a362601baa6 ("x86/jailhouse: Add infrastructure for running in > non-root cell") > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Cc:

Re: BUG: KASAN: global-out-of-bounds in unmap_kernel_at_el0+0x70/0x1a0

2018-04-22 Thread Jan Kiszka
On 2018-04-22 21:06, Mark Rutland wrote: > On Sun, Apr 22, 2018 at 12:47:57PM +0200, Jan Kiszka wrote: >> Hi, >> >> this can be triggered simply by running >> >> # echo 0 > /sys/devices/system/cpu/cpu3/online >> # echo 1 > /sys/devic

BUG: KASAN: global-out-of-bounds in unmap_kernel_at_el0+0x70/0x1a0

2018-04-22 Thread Jan Kiszka
Hi, this can be triggered simply by running # echo 0 > /sys/devices/system/cpu/cpu3/online # echo 1 > /sys/devices/system/cpu/cpu3/online [ 455.904854] == [ 455.906108] BUG: KASAN: global-out-of-bounds in

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-22 Thread Jan Kiszka
On 2018-04-11 07:42, Jan Kiszka wrote: > On 2018-04-05 23:12, Rob Herring wrote: >> On Thu, Apr 5, 2018 at 2:28 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >>> On 04/05/18 12:13, Jan Kiszka wrote: >>>> On 2018-04-05 20:59, Frank Rowand wrote: >>>

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-10 Thread Jan Kiszka
On 2018-04-05 23:12, Rob Herring wrote: > On Thu, Apr 5, 2018 at 2:28 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 04/05/18 12:13, Jan Kiszka wrote: >>> On 2018-04-05 20:59, Frank Rowand wrote: >>>> Hi Jan, >>>> >>

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-05 Thread Jan Kiszka
On 2018-04-05 21:28, Frank Rowand wrote: > On 04/05/18 12:13, Jan Kiszka wrote: >> On 2018-04-05 20:59, Frank Rowand wrote: >>> Hi Jan, >>> >>> On 04/04/18 15:35, Jan Kiszka wrote: >>>> Hi Frank, >>>> >>>> On 2018-03-04

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-05 Thread Jan Kiszka
On 2018-04-05 21:13, Frank Rowand wrote: > On 04/04/18 17:55, Rob Herring wrote: >> On Wed, Apr 4, 2018 at 5:35 PM, Jan Kiszka <jan.kis...@web.de> wrote: >>> Hi Frank, >>> >>> On 2018-03-04 01:17, frowand.l...@gmail.com wrote: >>>> Fro

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-05 Thread Jan Kiszka
On 2018-04-05 20:59, Frank Rowand wrote: > Hi Jan, > > On 04/04/18 15:35, Jan Kiszka wrote: >> Hi Frank, >> >> On 2018-03-04 01:17, frowand.l...@gmail.com wrote: >>> From: Frank Rowand <frank.row...@sony.com> >>> >>> Move duplicating

Re: [PATCH] uapi: fix asm/bootparam.h userspace compilation errors

2018-04-05 Thread Jan Kiszka
> + __u16 compatible_version; > + __u16 pm_timer_address; > + __u16 num_cpus; > + __u64 pci_mmconfig_base; > + __u32 tsc_khz; > + __u32 apic_khz; > + __u8standard_ioapic; > + __u8cpu_ids[255]; > } __attribute__((pack

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-05 Thread Jan Kiszka
On 2018-04-05 02:55, Rob Herring wrote: > On Wed, Apr 4, 2018 at 5:35 PM, Jan Kiszka <jan.kis...@web.de> wrote: >> Hi Frank, >> >> On 2018-03-04 01:17, frowand.l...@gmail.com wrote: >>> From: Frank Rowand <frank.row...@sony.com> >>> >>&g

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-04 Thread Jan Kiszka
Hi Frank, On 2018-03-04 01:17, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Move duplicating and unflattening of an overlay flattened devicetree > (FDT) into the overlay application code. To accomplish this, > of_overlay_apply() is replaced by

Re: [PATCH] arm: Initialize hrtimer-based broadcast clockevent

2018-04-04 Thread Jan Kiszka
On 2018-03-01 07:04, Jan Kiszka wrote: > On 2018-01-22 07:06, Jan Kiszka wrote: >> Analogously to 9358d755bd5c, this registers a broadcast clockevent in >> case no hardware broadcast timer is available and the per-CPU timers can >> be stopped in deep power states. >> >

Re: [PATCH net] e1000e: Remove Other from EIAC.

2018-04-01 Thread Jan Kiszka
On 2018-01-31 08:26, Benjamin Poirier wrote: > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > overrun interrupt bursts", v4.15-rc1). Some tracing shows that after > e1000e_trigger_lsc() is called,

Re: [PATCH] builddeb: Fix header package regarding dtc source links

2018-03-22 Thread Jan Kiszka
On 2018-03-22 15:45, Riku Voipio wrote: > On 21 March 2018 at 07:15, Jan Kiszka <jan.kis...@siemens.com> wrote: >> Since d5d332d3f7e8, a couple of links in scripts/dtc/include-prefixes >> are additionally required in order to build device trees with the header >> pack

[PATCH] builddeb: Fix header package regarding dtc source links

2018-03-20 Thread Jan Kiszka
Since d5d332d3f7e8, a couple of links in scripts/dtc/include-prefixes are additionally required in order to build device trees with the header package. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- scripts/package/builddeb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[tip:x86/platform] MAINTAINERS: Add entry for Jailhouse

2018-03-08 Thread tip-bot for Jan Kiszka
Commit-ID: e21c963c0fe3dc6d8a5c23474eb8f560b184132a Gitweb: https://git.kernel.org/tip/e21c963c0fe3dc6d8a5c23474eb8f560b184132a Author: Jan Kiszka <jan.kis...@siemens.com> AuthorDate: Wed, 7 Mar 2018 08:39:18 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate

[tip:x86/platform] x86/jailhouse: Allow to use PCI_MMCONFIG without ACPI

2018-03-08 Thread tip-bot for Jan Kiszka
Commit-ID: 8364e1f8379c7f9d3e63f127a585f889906b3e10 Gitweb: https://git.kernel.org/tip/8364e1f8379c7f9d3e63f127a585f889906b3e10 Author: Jan Kiszka <jan.kis...@siemens.com> AuthorDate: Wed, 7 Mar 2018 08:39:17 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate

[tip:x86/platform] x86: Consolidate PCI_MMCONFIG configs

2018-03-08 Thread tip-bot for Jan Kiszka
Commit-ID: b45c9f3656b691ab7324c7eaefb3416bea0326d8 Gitweb: https://git.kernel.org/tip/b45c9f3656b691ab7324c7eaefb3416bea0326d8 Author: Jan Kiszka <jan.kis...@siemens.com> AuthorDate: Wed, 7 Mar 2018 08:39:16 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate

[tip:x86/platform] x86: Align x86_64 PCI_MMCONFIG with 32-bit variant

2018-03-08 Thread tip-bot for Jan Kiszka
Commit-ID: 55027a7772b1a9c36fb9731fc6c847b6a59c5bef Gitweb: https://git.kernel.org/tip/55027a7772b1a9c36fb9731fc6c847b6a59c5bef Author: Jan Kiszka <jan.kis...@siemens.com> AuthorDate: Wed, 7 Mar 2018 08:39:15 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate

[tip:x86/platform] PCI: Scan all functions when running over Jailhouse

2018-03-08 Thread tip-bot for Jan Kiszka
Commit-ID: 690f4304104f37e473bd5e43fc5247f5cd35b225 Gitweb: https://git.kernel.org/tip/690f4304104f37e473bd5e43fc5247f5cd35b225 Author: Jan Kiszka <jan.kis...@siemens.com> AuthorDate: Wed, 7 Mar 2018 08:39:13 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate

[tip:x86/platform] jailhouse: Provide detection for non-x86 systems

2018-03-08 Thread tip-bot for Jan Kiszka
Commit-ID: 63338a38db955cb4e0352c11b78732157c78d30b Gitweb: https://git.kernel.org/tip/63338a38db955cb4e0352c11b78732157c78d30b Author: Jan Kiszka <jan.kis...@siemens.com> AuthorDate: Wed, 7 Mar 2018 08:39:12 +0100 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate

[PATCH v5 4/7] x86: Align x86_64 PCI_MMCONFIG with 32-bit variant

2018-03-06 Thread Jan Kiszka
From: Jan Kiszka <jan.kis...@siemens.com> Allow to enable PCI_MMCONFIG when only SFI is present and make this option default on. This will help consolidating both into one Kconfig statement. Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- arch/x86/Kconfig | 3 ++- 1 fil

[PATCH v5 3/7] x86/jailhouse: Enable PCI mmconfig access in inmates

2018-03-06 Thread Jan Kiszka
CONFIG, used pcibios_last_bus] Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> --- arch/x86/include/asm/pci_x86.h | 2 ++ arch/x86/kernel/jailhouse.c| 8 arch/x86/pci/mmconfig-shared.c | 4 ++-- 3 files changed, 12 in

  1   2   3   4   5   6   7   8   9   10   >