On Thu, 07 Feb 2008 21:24:47 +0100
Peter Zijlstra <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-02-07 at 20:49 +0100, Peter Zijlstra wrote:
> > On Wed, 2008-02-06 at 18:23 -0800, Andrew Morton wrote:
> > > On Wed, 06 Feb 2008 20:10:50 -0600 "J. K. Cliburn"
> > > <[EMAIL PROTECTED]> wrote:
> > >
>
On Thu, 07 Feb 2008 21:24:47 +0100
Peter Zijlstra [EMAIL PROTECTED] wrote:
On Thu, 2008-02-07 at 20:49 +0100, Peter Zijlstra wrote:
On Wed, 2008-02-06 at 18:23 -0800, Andrew Morton wrote:
On Wed, 06 Feb 2008 20:10:50 -0600 J. K. Cliburn
[EMAIL PROTECTED] wrote:
Zan Lynx wrote:
In preparation for a future atl2 driver for the Atheros L2 10/100 chip,
we propose to move the existing atl1 driver to a new directory
(drivers/net/atlx), then split out functions and definitions that both
atl1 and atl2 can share. The final structure will look like this:
drivers/net/atl1
Make needlessly global functions static. In a couple of cases this
requires removing forward declarations and reordering functions.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
Rearrange functions to allow removal of some forward declarations.
Make certain global functions static along the way.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
Use skb->csum_start for tx checksum offload preparation. Also swap
the variables css and cso so they hold the intended values of csum
start and offset, respectively.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atl
. Finally, shorten some variable names in the transmit
processing path to reduce line lengths, rename some variables to better
describe their purpose (e.g., nseg versus m), and add a comment or two
to better describe what the code is doing.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by:
Add some debug printks if we encounter a potentially bad receive
return descriptor.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 26 ++
1 files changed, 22 insertions(+), 4 deleti
In preparation for a future Atheros L2 NIC driver (called atl2), relocate
the atl1 driver into a new /drivers/net/atlx directory that will ultimately
be shared with the future atl2 driver.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Add the ethtool register dump option to the atl1 driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 53 +++
drivers/net/atlx/atl1.h |1 +
2 files changed, 5
it to the tpd.
Also, some of our bit assignments are made to the wrong tpd words. Change
those to the correct words.
Finally, since all this fixes TSO, enable TSO by default.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/a
it to the tpd.
Also, some of our bit assignments are made to the wrong tpd words. Change
those to the correct words.
Finally, since all this fixes TSO, enable TSO by default.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Acked-by: Chris Snook [EMAIL PROTECTED]
---
drivers/net/atlx/atl1.c | 29
Add the ethtool register dump option to the atl1 driver.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Acked-by: Chris Snook [EMAIL PROTECTED]
---
drivers/net/atlx/atl1.c | 53 +++
drivers/net/atlx/atl1.h |1 +
2 files changed, 54 insertions(+), 0
In preparation for a future Atheros L2 NIC driver (called atl2), relocate
the atl1 driver into a new /drivers/net/atlx directory that will ultimately
be shared with the future atl2 driver.
Signed-off-by: Chris Snook [EMAIL PROTECTED]
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net
Add some debug printks if we encounter a potentially bad receive
return descriptor.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Acked-by: Chris Snook [EMAIL PROTECTED]
---
drivers/net/atlx/atl1.c | 26 ++
1 files changed, 22 insertions(+), 4 deletions(-)
diff --git
Use skb-csum_start for tx checksum offload preparation. Also swap
the variables css and cso so they hold the intended values of csum
start and offset, respectively.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Acked-by: Chris Snook [EMAIL PROTECTED]
---
drivers/net/atlx/atl1.c | 11
. Finally, shorten some variable names in the transmit
processing path to reduce line lengths, rename some variables to better
describe their purpose (e.g., nseg versus m), and add a comment or two
to better describe what the code is doing.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Acked-by: Chris
Rearrange functions to allow removal of some forward declarations.
Make certain global functions static along the way.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Acked-by: Chris Snook [EMAIL PROTECTED]
---
drivers/net/atlx/atl1.c | 1406 +++---
drivers
Make needlessly global functions static. In a couple of cases this
requires removing forward declarations and reordering functions.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Acked-by: Chris Snook [EMAIL PROTECTED]
---
drivers/net/atlx/atl1.c | 101
In preparation for a future atl2 driver for the Atheros L2 10/100 chip,
we propose to move the existing atl1 driver to a new directory
(drivers/net/atlx), then split out functions and definitions that both
atl1 and atl2 can share. The final structure will look like this:
drivers/net/atl1
>From de0e1eddb6a4dd7673f84c472812b062aaea2f39 Mon Sep 17 00:00:00 2001
From: Jay Cliburn <[EMAIL PROTECTED]>
Date: Wed, 30 Jan 2008 19:21:10 -0600
Subject: [PATCH] atl1: fix frame length bug
Upstream commit: 2a49128f0a6edee337174ea341c1d6d7565be350
The driver sets up the hardware
From de0e1eddb6a4dd7673f84c472812b062aaea2f39 Mon Sep 17 00:00:00 2001
From: Jay Cliburn [EMAIL PROTECTED]
Date: Wed, 30 Jan 2008 19:21:10 -0600
Subject: [PATCH] atl1: fix frame length bug
Upstream commit: 2a49128f0a6edee337174ea341c1d6d7565be350
The driver sets up the hardware to accept a frame
On Tue, 22 Jan 2008 18:31:09 -0600
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> On Tue, 22 Jan 2008 04:58:17 -0500
> Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
[...]
> > for such a huge patch, this description is very tiny. [describe]
> > what is refactored, and why.
On Tue, 22 Jan 2008 18:31:09 -0600
Jay Cliburn [EMAIL PROTECTED] wrote:
On Tue, 22 Jan 2008 04:58:17 -0500
Jeff Garzik [EMAIL PROTECTED] wrote:
[...]
for such a huge patch, this description is very tiny. [describe]
what is refactored, and why.
Is this one any better?
From
On Tue, 22 Jan 2008 04:56:11 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > From: Jay Cliburn <[EMAIL PROTECTED]>
> >
> > Update initialization parameters to match the current vendor driver
> > version 1.2.40.2.
[.
On Tue, 22 Jan 2008 04:58:17 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > From: Jay Cliburn <[EMAIL PROTECTED]>
> >
> > Refactor tx processing to use a less convoluted tx packet
> > descriptor and to conform generally with th
On Tue, 22 Jan 2008 04:58:17 -0500
Jeff Garzik [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] wrote:
From: Jay Cliburn [EMAIL PROTECTED]
Refactor tx processing to use a less convoluted tx packet
descriptor and to conform generally with the vendor's current
version 1.2.40.2.
Signed
On Tue, 22 Jan 2008 04:56:11 -0500
Jeff Garzik [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] wrote:
From: Jay Cliburn [EMAIL PROTECTED]
Update initialization parameters to match the current vendor driver
version 1.2.40.2.
[...]
ACK without any better knowledge... but is any addition
Thanks for your comments Stephen and Joonwoo. Here's the revised
version of the atl1 NAPI patch.
>From 9c3a8944220287671f983557099bc329f02fda9b Mon Sep 17 00:00:00 2001
From: Jay Cliburn <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 11:55:24 -0600
Subject: [PATCH 25/26] atl1: add NAPI sup
Thanks for your comments Stephen and Joonwoo. Here's the revised
version of the atl1 NAPI patch.
From 9c3a8944220287671f983557099bc329f02fda9b Mon Sep 17 00:00:00 2001
From: Jay Cliburn [EMAIL PROTECTED]
Date: Tue, 1 Jan 2008 11:55:24 -0600
Subject: [PATCH 25/26] atl1: add NAPI support
Add
On Sat, 8 Dec 2007 21:14:09 +0100
Sam Ravnborg <[EMAIL PROTECTED]> wrote:
> Jay - can I ask you to try out following patch.
Hello Sam,
Yes, your patch works for me.
Thank you very much.
> diff --git a/Makefile b/Makefile
> index a5252f4..7fb1a2c 100644
> --- a/Makefile
> +++ b/Makefile
> @@
On Sat, 8 Dec 2007 21:14:09 +0100
Sam Ravnborg [EMAIL PROTECTED] wrote:
Jay - can I ask you to try out following patch.
Hello Sam,
Yes, your patch works for me.
Thank you very much.
diff --git a/Makefile b/Makefile
index a5252f4..7fb1a2c 100644
--- a/Makefile
+++ b/Makefile
@@ -118,9
On Thu, 6 Dec 2007 15:57:38 +0100 (CET)
Jan Engelhardt <[EMAIL PROTECTED]> wrote:
>
> On Dec 4 2007 21:04, Jay Cliburn wrote:
> >
> >This piece of the top-level Makefile in current git causes an
> >out-of-tree driver Makefile to fail.
> >
> >101 ifde
On Thu, 6 Dec 2007 15:57:38 +0100 (CET)
Jan Engelhardt [EMAIL PROTECTED] wrote:
On Dec 4 2007 21:04, Jay Cliburn wrote:
This piece of the top-level Makefile in current git causes an
out-of-tree driver Makefile to fail.
101 ifdef O
102 ifeq ($(origin O), command line)
103
On Wed, 5 Dec 2007 22:00:03 +0100
Sam Ravnborg <[EMAIL PROTECTED]> wrote:
> On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote:
> > Sam,
> >
> > This piece of the top-level Makefile in current git causes an
> > out-of-tree driver Makefile to fail.
&g
On Wed, 5 Dec 2007 22:00:03 +0100
Sam Ravnborg [EMAIL PROTECTED] wrote:
On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote:
Sam,
This piece of the top-level Makefile in current git causes an
out-of-tree driver Makefile to fail.
101 ifdef O
102 ifeq ($(origin O
Sam,
This piece of the top-level Makefile in current git causes an
out-of-tree driver Makefile to fail.
101 ifdef O
102 ifeq ("$(origin O)", "command line")
103 KBUILD_OUTPUT := $(O)
104 endif
105 endif
The out-of-tree driver Makefile contains an O=... directive that
(correctly) does
Sam,
This piece of the top-level Makefile in current git causes an
out-of-tree driver Makefile to fail.
101 ifdef O
102 ifeq ($(origin O), command line)
103 KBUILD_OUTPUT := $(O)
104 endif
105 endif
The out-of-tree driver Makefile contains an O=... directive that
(correctly) does _not_
be used at a time.
As a result, we need to confine the driver to a 32-bit DMA mask, otherwise
we see occasional data corruption errors in systems containing 4 or more
gigabytes of RAM.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Cc: Luca Tettamanti <[EMAIL PROTECTED]>
Cc: Chris S
be used at a time.
As a result, we need to confine the driver to a 32-bit DMA mask, otherwise
we see occasional data corruption errors in systems containing 4 or more
gigabytes of RAM.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
Cc: Luca Tettamanti [EMAIL PROTECTED]
Cc: Chris Snook [EMAIL PROTECTED
From: Ingo Molnar <[EMAIL PROTECTED]>
use the simpler spin_trylock_irqsave() API to get the adapter lock.
[ this is also a fix for -rt where adapter->lock is a sleeping lock. ]
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
From: Ingo Molnar [EMAIL PROTECTED]
use the simpler spin_trylock_irqsave() API to get the adapter lock.
[ this is also a fix for -rt where adapter-lock is a sleeping lock. ]
Signed-off-by: Ingo Molnar [EMAIL PROTECTED]
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1
Use constants already provided by the kernel for ethernet related lengths.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |5 -
drivers/net/atl1/atl1_main.c | 13 +++--
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drive
s/dam/dma
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h
index 100c09c..f0d7e82 100644
--- a/drivers/net/atl1/atl1_hw.h
+++ b/d
The DMA engine setup contains a typo that can result in an incorrect
dmaw_block setting.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/ne
-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index 3b8f633..6aa2dc3 100644
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/ne
Please accept the following patches for the atl1 driver. Thanks.
atl1: use kernel provided ethernet length constants
atl1: fix typo in dma_req_block
atl1: change cmb write threshold
atl1: fix typo in DMA engine setup
atl1: change tpd_avail function name
drivers/net/atl1/atl1_hw.h |9
Change tpd_avail() to atl1_tpd_avail().
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index fd1e156..79d60e1
Please accept the following patches for the atl1 driver. Thanks.
atl1: use kernel provided ethernet length constants
atl1: fix typo in dma_req_block
atl1: change cmb write threshold
atl1: fix typo in DMA engine setup
atl1: change tpd_avail function name
drivers/net/atl1/atl1_hw.h |9
Change tpd_avail() to atl1_tpd_avail().
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index fd1e156..79d60e1 100644
The DMA engine setup contains a typo that can result in an incorrect
dmaw_block setting.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1
-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index 3b8f633..6aa2dc3 100644
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/net/atl1
Use constants already provided by the kernel for ethernet related lengths.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_hw.h |5 -
drivers/net/atl1/atl1_main.c | 13 +++--
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/net
s/dam/dma
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_hw.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h
index 100c09c..f0d7e82 100644
--- a/drivers/net/atl1/atl1_hw.h
+++ b/drivers
Fix indentation, remove dead code, improve some comments, change dev_dbg to
dev_printk.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c | 278 +-
1 files changed, 137 insertions(+), 141 deletions(-)
diff --git a/d
Remove unused structure members, improve comments, break long comment lines,
rename a constant to be consistent with others in the file.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h | 155 ++
drivers/net/atl1/atl1_
Remove unnecessary irq_sem code.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1.h |1 -
drivers/net/atl1/atl1_main.c |6 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/driv
Move excessively indented code to separate functions. Also move ring
pointer initialization to its own function.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c | 86 -
1 files changed, 50 insertions(+), 36 del
Please accept the following patches for the atl1 driver.
atl1: remove irq_sem
atl1: header file cleanup
atl1: cleanup atl1_main
atl1: fix excessively indented code
atl1: reorder atl1_main functions
drivers/net/atl1/atl1.h | 156 ++--
drivers/net/atl1/atl1_main.c | 2176
Please accept the following patches for the atl1 driver.
atl1: remove irq_sem
atl1: header file cleanup
atl1: cleanup atl1_main
atl1: fix excessively indented code
atl1: reorder atl1_main functions
drivers/net/atl1/atl1.h | 156 ++--
drivers/net/atl1/atl1_main.c | 2176
Remove unnecessary irq_sem code.
Signed-off-by: Chris Snook [EMAIL PROTECTED]
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1.h |1 -
drivers/net/atl1/atl1_main.c |6 ++
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/atl1/atl1.h
Move excessively indented code to separate functions. Also move ring
pointer initialization to its own function.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c | 86 -
1 files changed, 50 insertions(+), 36 deletions
Remove unused structure members, improve comments, break long comment lines,
rename a constant to be consistent with others in the file.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1.h | 155 ++
drivers/net/atl1/atl1_main.c
Fix indentation, remove dead code, improve some comments, change dev_dbg to
dev_printk.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c | 278 +-
1 files changed, 137 insertions(+), 141 deletions(-)
diff --git a/drivers/net
How do I turn on dev_dbg messaging in the kernel? I can get
printk(KERN_DEBUG ...) to work just fine, but I don't know how to
enable dev_dbg.
Thanks,
Jay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
How do I turn on dev_dbg messaging in the kernel? I can get
printk(KERN_DEBUG ...) to work just fine, but I don't know how to
enable dev_dbg.
Thanks,
Jay
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Mon, 25 Jun 2007 23:18:55 +0200
Luca Tettamanti <[EMAIL PROTECTED]> wrote:
> Il Mon, Jun 25, 2007 at 07:42:44AM -0500, Jay Cliburn ha scritto:
> > Jay L. T. Cornwall wrote:
> > >Jay Cliburn wrote:
> > >
> > >>For reasons not yet clear to
On Mon, 25 Jun 2007 23:18:55 +0200
Luca Tettamanti [EMAIL PROTECTED] wrote:
Il Mon, Jun 25, 2007 at 07:42:44AM -0500, Jay Cliburn ha scritto:
Jay L. T. Cornwall wrote:
Jay Cliburn wrote:
For reasons not yet clear to me, it appears the L1 driver has a
bug or the device itself has
On Mon, 25 Jun 2007 17:57:20 -0400
Chris Snook <[EMAIL PROTECTED]> wrote:
> Jay L. T. Cornwall wrote:
> > Chris Snook wrote:
> >
> >> What boards have we seen this on? It's quite possible this is:
> >
> > I can reproduce on an Asus P5K with a Core 2 Duo E6600.
> >
> > lspci identifies the
Jay L. T. Cornwall wrote:
Jay Cliburn wrote:
For reasons not yet clear to me, it appears the L1 driver has a bug or
the device itself has trouble with DMA in high memory. This patch,
drafted by Luca Tettamanti, is being explored as a workaround. I'd be
interested to know if it fixes your
Jay L. T. Cornwall wrote:
Jay Cliburn wrote:
For reasons not yet clear to me, it appears the L1 driver has a bug or
the device itself has trouble with DMA in high memory. This patch,
drafted by Luca Tettamanti, is being explored as a workaround. I'd be
interested to know if it fixes your
On Mon, 25 Jun 2007 17:57:20 -0400
Chris Snook [EMAIL PROTECTED] wrote:
Jay L. T. Cornwall wrote:
Chris Snook wrote:
What boards have we seen this on? It's quite possible this is:
I can reproduce on an Asus P5K with a Core 2 Duo E6600.
lspci identifies the controller as:
On Sun, 24 Jun 2007 21:31:36 +0100
"Jay L. T. Cornwall" <[EMAIL PROTECTED]> wrote:
> Jay Cliburn wrote:
>
> >> The common factor here seems to be the buffer_head circular list
> >> leading to invalid pointers in bh->b_this_page.
> >>
> >&
On Sat, 23 Jun 2007 13:14:40 +0100
"Jay L. T. Cornwall" <[EMAIL PROTECTED]> wrote:
> The common factor here seems to be the buffer_head circular list
> leading to invalid pointers in bh->b_this_page.
>
> I'm beginning to suspect the Attansic L1 Gigabit Etherner driver
> (marked as EXPERIMENTAL
On Sat, 23 Jun 2007 13:14:40 +0100
Jay L. T. Cornwall [EMAIL PROTECTED] wrote:
The common factor here seems to be the buffer_head circular list
leading to invalid pointers in bh-b_this_page.
I'm beginning to suspect the Attansic L1 Gigabit Etherner driver
(marked as EXPERIMENTAL in
On Sun, 24 Jun 2007 21:31:36 +0100
Jay L. T. Cornwall [EMAIL PROTECTED] wrote:
Jay Cliburn wrote:
The common factor here seems to be the buffer_head circular list
leading to invalid pointers in bh-b_this_page.
I'm beginning to suspect the Attansic L1 Gigabit Etherner driver
(marked
On Wed, 30 May 2007 15:07:39 -0700
Greg KH <[EMAIL PROTECTED]> wrote:
> Sorry, I'm catching up on PCI stuff right now (am traveling in Tokyo
> right now, gotta love jet lag...)
>
> thanks for your patience.
Thanks a lot for the note, Greg. I appreciate it. I'll be patient.
Jay
-
To
On Wed, 30 May 2007 02:00:25 +0200
Jose Alberto Reguero <[EMAIL PROTECTED]> wrote:
> I have problems with a M2V motherboard and atl1 driver with msi and
> kernel 2.6.22-rc3. With kernel 2.6.21 I had no problems.
> I must add in drivers/pci/quirks.c (line 1723):
>
>
On Wed, 30 May 2007 15:07:39 -0700
Greg KH [EMAIL PROTECTED] wrote:
Sorry, I'm catching up on PCI stuff right now (am traveling in Tokyo
right now, gotta love jet lag...)
thanks for your patience.
Thanks a lot for the note, Greg. I appreciate it. I'll be patient.
Jay
-
To unsubscribe
On Wed, 30 May 2007 02:00:25 +0200
Jose Alberto Reguero [EMAIL PROTECTED] wrote:
I have problems with a M2V motherboard and atl1 driver with msi and
kernel 2.6.22-rc3. With kernel 2.6.21 I had no problems.
I must add in drivers/pci/quirks.c (line 1723):
On Sun, 27 May 2007 02:20:52 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Sat, May 26, 2007 at 05:01:04PM -0500, Jay Cliburn wrote:
> >
> > The Via VT3351 APIC does not play well with MSI and unleashes a
> > flood of APIC errors when MSI is used to deliver i
VT3351.
See http://bugzilla.kernel.org/show_bug.cgi?id=8472 for additional
details on this bug.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/pci/quirks.c|1 +
include/linux/pci_ids.h |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/qu
VT3351.
See http://bugzilla.kernel.org/show_bug.cgi?id=8472 for additional
details on this bug.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/pci/quirks.c|1 +
include/linux/pci_ids.h |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/quirks.c b
On Sun, 27 May 2007 02:20:52 +0200
Adrian Bunk [EMAIL PROTECTED] wrote:
On Sat, May 26, 2007 at 05:01:04PM -0500, Jay Cliburn wrote:
The Via VT3351 APIC does not play well with MSI and unleashes a
flood of APIC errors when MSI is used to deliver interrupts. The
problem was recently
Can someone (Greg K-H?) tell me the status of the below patch? Is it
planned for 2.6.22? It looks like a useful generic "let's disable msi
on board x" that I might want to use for the atl1 network driver.
Thanks,
Jay
On Wed, 09 May 2007 14:23:02 +0200
Tejun Heo <[EMAIL PROTECTED]> wrote:
>
Can someone (Greg K-H?) tell me the status of the below patch? Is it
planned for 2.6.22? It looks like a useful generic let's disable msi
on board x that I might want to use for the atl1 network driver.
Thanks,
Jay
On Wed, 09 May 2007 14:23:02 +0200
Tejun Heo [EMAIL PROTECTED] wrote:
MSI
Thank you very much for looking at this, Len.
On Fri, 11 May 2007 23:28:58 -0400
Len Brown <[EMAIL PROTECTED]> wrote:
> > > [ 94.754852] APIC error on CPU0: 08(40)
> > > [ 94.806045] APIC error on CPU0: 40(08)
>
> /* Here is what the APIC error bits mean:
>0: Send CS
Thank you very much for looking at this, Len.
On Fri, 11 May 2007 23:28:58 -0400
Len Brown [EMAIL PROTECTED] wrote:
[ 94.754852] APIC error on CPU0: 08(40)
[ 94.806045] APIC error on CPU0: 40(08)
/* Here is what the APIC error bits mean:
0: Send CS error
Jeff Garzik wrote:
Chuck Ebbert wrote:
Tejun Heo wrote:
FWIW several distros have turned off MSI by default and added
a "pci=msi" option to enable it.
Yeah, it seem to cause a lot of problems on certain chips but I think
the correct path is to add PCI quirks for those. Most MSI problems I've
Jeff Garzik wrote:
Chuck Ebbert wrote:
Tejun Heo wrote:
FWIW several distros have turned off MSI by default and added
a pci=msi option to enable it.
Yeah, it seem to cause a lot of problems on certain chips but I think
the correct path is to add PCI quirks for those. Most MSI problems I've
Use dev_printk macros for PCI related errors, warnings, debug and info
console messages.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 22 +--
drivers/net/atl1/atl1_main.c
Please accept the following trivial patches to the atl1 driver.
- use dev_printk macros
- fix whitespace damage
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 44 ++---
drivers/net/atl1/atl1_main.c| 83
Remove trailing whitespace and spaces preceding tabs.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
Please accept the following trivial patches to the atl1 driver.
- use dev_printk macros
- fix whitespace damage
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 44 ++---
drivers/net/atl1/atl1_main.c| 83
Remove trailing whitespace and spaces preceding tabs.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_hw.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
index 5b9dd3c
Use dev_printk macros for PCI related errors, warnings, debug and info
console messages.
Signed-off-by: Jay Cliburn [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_ethtool.c | 19 +++--
drivers/net/atl1/atl1_hw.c | 22 +--
drivers/net/atl1/atl1_main.c| 83
Chuck Ebbert wrote:
Where is the text of the oops?
In one of the files on the website I referenced. Here's the text...
[ 173.584000] APIC error on CPU1: 08(08)
[ 173.665000] APIC error on CPU0: 08(08)
[ 173.665000] APIC error on CPU1: 08(08)
[ 173.746000] APIC error on CPU0: 08(08)
[
Chuck Ebbert wrote:
Where is the text of the oops?
In one of the files on the website I referenced. Here's the text...
[ 173.584000] APIC error on CPU1: 08(08)
[ 173.665000] APIC error on CPU0: 08(08)
[ 173.665000] APIC error on CPU1: 08(08)
[ 173.746000] APIC error on CPU0: 08(08)
[
[Adding linux-kernel to the cc list, hoping for wider exposure.]
On Fri, 23 Mar 2007 20:08:17 -0500
Jay Cliburn <[EMAIL PROTECTED]> wrote:
> We're trying to track down the source of a problem that occurs
> whenever the atl1 network driver is activated on a 32-bit 2.6.21-rc4
an
[Adding linux-kernel to the cc list, hoping for wider exposure.]
On Fri, 23 Mar 2007 20:08:17 -0500
Jay Cliburn [EMAIL PROTECTED] wrote:
We're trying to track down the source of a problem that occurs
whenever the atl1 network driver is activated on a 32-bit 2.6.21-rc4
and -rc5, -rc6, 2.6.20.x
1 - 100 of 192 matches
Mail list logo
