The kmalloc(sizeof(struct foo), ...) => kmalloc(sizeof(*foo), ...)
ones are OK.
The rest is cargo-cult programming.
Jeff
--
Jeff Dike
AddToIt
978-254-0789 (o)
978-394-8986 (c)
y standard kernel coding style. The inline
fd = -ERESTARTSYS;
is likely free, or close to it, and I believe that having anything
besides a goto inside the if could make it significantly more
expensive.
Jeff
--
Jeff Dike
AddToIt
978-254-0789 (o)
978-394-8986 (c)
= fd,
I don't see how this eliminates a possible error. It should behave
exactly the same. To me, this is an expressiveness issue.
!x is something you use with something that is conceptually a Boolean.
x == NULL is a question about a pointer, which is the case here.
Jeff
--
Jeff Dike
AddToIt
978-254-0789 (o)
978-394-8986 (c)
On Mon, Feb 25, 2008 at 09:49:43AM -0500, Theodore Ts'o wrote:
> I've noticed that if I try to use a 32-bit x86 gdb to debug a
> 32-bit program under a 64-bit x86_64 kernel, gdb (version 6.6-debian,
> from Ubuntu Gutsy) immediately core dumps as soon as I run the test
> program under the debu
On Thu, Feb 21, 2008 at 06:20:23PM +0100, Miklos Szeredi wrote:
> Bisected it down to
>
> good e7b5e11eaaa8ef93a34e68016de51152d0d62911
> bad bde6f5f59c2b2b48a7a849c129d5b48838fe77ee
>
> I strongly suspect it's one of the ptrace cleanup patches. Roland,
> could you please have a look?
I agree.
On Wed, Feb 20, 2008 at 07:19:13PM +0800, WANG Cong wrote:
> Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Looks good - you should add some sort of changelog though.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the l
On Fri, Feb 15, 2008 at 08:52:04PM +0100, Miklos Szeredi wrote:
> > What does it do?
>
> See below.
> [0.42] Checking host MADV_REMOVE support...<3>MADV_REMOVE failed, err
> = -38
Where'd MADV_REMOVE go? I have it on 2.6.24.
> [0.42] Failed to get registers from stub, errno =
On Fri, Feb 15, 2008 at 12:43:45PM +0100, Miklos Szeredi wrote:
> - UML doesn't boot: guest is 2.6.24-mm1 also, haven't tried any
>other. Same guest boots fine on 2.6.24 host.
What does it do?
Any chance you can bisect it?
Jeff
--
Work email - jdike at lin
mp;q=raw
http://marc.info/?l=user-mode-linux-devel&m=120223046325197&q=raw
http://marc.info/?l=user-mode-linux-devel&m=120223005624238&q=raw
These are against 2.6.24. Build both host and guest from this tree.
Jeff
--
Work email
On Fri, Feb 15, 2008 at 10:07:42PM +0800, WANG Cong wrote:
>
> Make some small improvements for arch/um/kernel/um_arch.c.
>
> Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
> Cc: Jeff Dike <[EMAIL PROTECTED]>
ACK
Jeff
--
Work email - jdike at linux dot inte
On Thu, Feb 14, 2008 at 12:13:09PM +0100, Ph. Marek wrote:
> make -C linux-2.6.24.2/ O=output_path/build ARCH=um bzImage
> make[2]: *** No rule to make target `bzImage'. Stop.
This seems pretty clear, no?
bzImage is a x86-ism. Just leave it off, and you'll get linux and vmlinux.
, ia64, mips, and powerpc.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
include/asm-generic/futex.h |2 +-
include/asm-ia64/futex.h|2 +-
include/asm-mips/futex.h|2 +-
include/asm-parisc/futex.h |2 +-
include/asm-powerpc/futex.h |2 +-
include/asm-sh/f
/arch/um/drivers/harddog_user.c:82: error: too many arguments to function
'helper_wait'
/arch/um/drivers/harddog_user.c:89: error: too many arguments to function
'helper_wait'
Signed-off-by: Johann Felix Soden <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
--
From: Johann Felix Soden <[EMAIL PROTECTED]>
If the initrd file has zero-length, the error message should contain
the filepath.
Cc: WANG Cong <[EMAIL PROTECTED]>
Signed-off-by: Johann Felix Soden <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/u
essentially sleeping
forever.
This patch saves the FP state before entering the SIGSEGV handler and
restores it afterwards.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/include/registers.h |2 ++
arch/um/include/sysdep-i386/ptrace_user.h |3 +++
arc
The macros which extract registers from a struct sigcontext are no
longer needed and can be removed. They are starting not to build
anyway, given the removal of the 'e' and 'r' from register names
during the x86 merge.
Cc: Jiri Olsa <[EMAIL PROTECTED]>
Signed-off-by: J
These should go to Linus - there are three build fixes and a serious bug fix.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majord
On Mon, Feb 11, 2008 at 02:44:21PM -0800, Christoph Lameter wrote:
> UML defined its own external __kmalloc and things. Isnt there some other
> way to fix it? I guess including slab.h is not possible here?
This is definitely dubious code on my part and I wouldn't support
Pekka's patch unless you'
[ This is 2.6.25 fodder ]
Update defconfig.
Cc: Christoph Hellwig <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/defconfig | 280 --
1 file changed, 187 insertions(+), 93 deletions(-)
Index: linux-
leanups, deleted obsolete comment ]
Signed-off-by: Jim Meyering <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/mem.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
Index: linux-2.
longer needed.
create_tmp_file was also made static.
checkpatch moans about an EXPORT_SYMBOL in user_syms.c which is part
of a macro definition - this is copying a bit of kernel infrastructure
into the libc side of UML because the kernel headers can't be included
there.
Signed-off-by: Jeff
Miklos ran into.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/Kconfig | 11 --
arch/um/Kconfig.i386| 37 -
arch/um/Kconfig.x86_64 |4 -
arch/um/Makefile| 11 --
a
This batch should go into the 2.6.25 merge window.
There are a couple of patches which had been sitting in -mm waiting
for this merge window, but got lost somehow:
runtime host vmsplit detection - Miklos spotted a bug, since
fixed, with a 32-bit UML on a 64-bit host
style fixes in
[ Spotted by Miklos ]
Fix a memory leak in init_new_context. The struct page ** buffer
allocated for install_special_mapping was never recorded, and thus
leaked when the mm_struct was freed. Fix it by saving the pointer in
mm_context_t and freeing it in arch_exit_mmap.
Signed-off-by: Jeff Dike
%fs needs to be copied from parent to child during fork.
Tidied up some whitespace while I was here.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
include/asm-um/processor-x86_64.h |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6-git/include/asm-um/pro
On Tue, Feb 05, 2008 at 05:25:06PM +0100, Jim Meyering wrote:
>
> An alternative: make find_tempdir set tempdir to default_tempdir
> upon malloc failure.
>
> * arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir.
> Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption.
>
>
On Wed, Feb 06, 2008 at 12:25:57AM +0800, WANG Cong wrote:
>
> Fix a missed conversion specifier of a printk in
> arch/um/kernel/initrd.c.
>
> Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
> Cc: Jeff Dike <[EMAIL PROTECTED]>
ACK - 2.6.25 material. Sigh.
mechananism that was used on x86_64 is gone.
arch/um/include/sysdep-i386/syscalls.h got some formatting since I was
looking at it.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
Cc: WANG Cong <[EMAIL PROTECTED]>
---
arch/um/include/sysdep-i386/syscalls.h |5 +++--
arch/u
m
init.h started breaking now for some reason. It turns out that there wasn't a
definition of __used. Fixed this by copying the relevant stuff from
compiler.h in the userspace case, and including compiler.h in the kernel case.
>From WANG Cong <[EMAIL PROTECTED]> - added def
Below is a patch which allows address spaces to be created,
manipulated, and destroyed independently of processes.
The additions are
two system calls, new_mm and switch_mm
/proc//mm
PTRACE_SWITCH_MM
new_mm() returns a file descriptor referencing a new address space
which i
On Mon, Jan 21, 2008 at 12:43:25PM -0600, Matt Mackall wrote:
> This conflicts just about everywhere with my latest code, but I'll fix
> that up.
Great, thanks.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe lin
if (fcntl(fd, F_SETOWN, getpid()) < 0) {
perror("Setting SIGIO");
exit(1);
}
printf("Drained the pool\n");
read(fd, &n, sizeof(n));
printf("Found more randomness\n");
return(0);
}
Sign
On Fri, Jan 18, 2008 at 03:42:54PM +0100, Miklos Szeredi wrote:
> uml:~# grep arch_dup_mmap /proc/slab_allocators
> size-32: 10861 arch_dup_mmap+0x9f/0x130
Whoops - try the patch below.
Jeff
--
Work email - jdike at linux dot intel dot com
Index: linux-2.6.22/a
On Thu, Jan 17, 2008 at 03:17:38PM -0800, Pallipadi, Venkatesh wrote:
> >#define X X
> >
> >is a no-op, yes?
> >
>
> Later there is code in generic.h which is doing
> #ifndef ioremap_wc
> #define ioremap_wc ioremap_nocache
> #endif
Ah, that makes a bit more sense.
It'd be nice if there was less
On Thu, Jan 17, 2008 at 01:41:50PM -0800, Venki Pallipadi wrote:
> > And while we're on the subject, what's the deal with these, in
> > include/asm-x86/io.h?
> >
> > #define ioremap_wc ioremap_wc
> > #define unxlate_dev_mem_ptr unxlate_dev_mem_ptr
> >
>
> If archs want to override the defaults f
From: Daniel Walker <[EMAIL PROTECTED]>
The port_sem is already used as a mutex since it's using DECLARE_MUTEX(),
but the underlying construct is still a semaphore .. This patch switches
it over to a struct mutex.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
Signed-off-by:
From: Joe Perches <[EMAIL PROTECTED]>
Spelling fix
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/sys-x86_64/signal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6-git/arch/um/s
Miklos ran into.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/Kconfig | 11 --
arch/um/Kconfig.i386| 37 -
arch/um/Kconfig.x86_64 |4 -
arch/um/Makefile| 11 --
a
te the stopping loop and resume the kernel.
This is a problem.
A better solution is to make the loop infinite and don't leave it
until we are explicitly told to.
Signed-off-by: Karol Swietlicki <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/drivers
Calling init_registers inside the skas3 checking causes mysterious
crashes if it doesn't happen because the skas3 checking is bypassed.
This patch moves it to os_early_checks.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/start_up.c | 10 +++---
1 file
longer needed.
create_tmp_file was also made static.
checkpatch moans about an EXPORT_SYMBOL in user_syms.c which is part
of a macro definition - this is copying a bit of kernel infrastructure
into the libc side of UML because the kernel headers can't be included
there.
Signed-off-by: Jeff
eter Anvin" <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/Kconfig|4
include/asm-um/param.h |2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
Index: linux-2.6.22/arch/um/Kconfig
==
The .a flags in openflags never had an implementation.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/file.c |2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.22/arch/um/os-Linux/file.c
===
---
The fakehd switch lost its implementation at some point. Since no one is
screaming for it, we might as well remove it.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/drivers/ubd_kern.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
Index: linux-
ome error cleanup in mconsole_init while I was there.
Cc: "Karol Swietlicki" <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/drivers/line.c |8 +---
arch/um/drivers/mconsole_kern.c |8 +++-
2 files changed, 12 insertions(
Style fixes in arch/um/sys-x86_64:
updated copyrights
CodingStyle fixes
added severities to printks which needed them
A bunch of functions in sys-*/ptrace_user.c turn out to be unused, so
they and their declarations are gone.
Signed-off-by: Jeff Dike <[EMAIL PROTEC
This is a lot of cleanup. There are style fixes, printk fixes,
spelling fixes, mutex conversions, and small bug fixes.
This is all obviously for 2.6.25.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubs
From: Daniel Walker <[EMAIL PROTECTED]>
The ldt.semaphore conforms to the new struct mutex requirments,
so I converted it to use the new API and changed the name.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/sys
From: WANG Cong <[EMAIL PROTECTED]>
TOPDIR is obsolete, use srctree instead.
This patch removes TOPDIR from all UML Makefiles.
Cc: Sam Ravnborg <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um
From: Daniel Walker <[EMAIL PROTECTED]>
The plug_mem_mutex is already used as a mutex since it's using DECLARE_MUTEX(),
but the underlying construct is still a semaphore .. This patch switches
it over to a struct mutex.
Signed-off-by: Daniel Walker <[EMAIL PROTECTED]>
Signed-
John Reiser noticed that a physical memory region was being mapped twice.
This patch fixes that, and it inlines the responsible function, as
that had only one caller.
Cc: John Reiser <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/kernel/mem.c |8
The 3-level page table fixes forgot to remove a couple now-unused
fields from struct mm_context.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/include/um_mmu.h |4
1 file changed, 4 deletions(-)
Index: linux-2.6.22/arch/um/include/um
Tweak the UML defconfig -
we probably don't need 256 old-style ptys - this slows down udev
noticably
enable hostfs
disable slab debugging - another noticable performance hit
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/defconfig |6 +++---
1 file
Downgrade one of the MAC validity checks. If it's one that could be
possibly assigned to a physical NIC, then nothing will break. So,
emit a warning in this case, but keep the requested MAC.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/drivers/net_kern.c |9 --
Some printks were missing newlines.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/skas/process.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Index: linux-2.6.22/arch/um/os-Linux/skas/pro
Add some more commentary about various pieces of global data not
needing locking.
Also got rid of unmap_physmem since that is no longer used.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/drivers/net_kern.c |7 ++-
arch/um/include/mem_user.h |1 -
arch/um/kernel
On Thu, Jan 17, 2008 at 11:38:53AM -0800, Pallipadi, Venkatesh wrote:
> Apart from unxlate, there is also ioremap_wc which is defined in the
> same way.
And while we're on the subject, what's the deal with these, in
include/asm-x86/io.h?
#define ioremap_wc ioremap_wc
#define unxlate_dev_mem_ptr u
On Thu, Jan 17, 2008 at 07:11:13PM +0100, Mariusz Kozlowski wrote:
> I see this on sparc64 as well:
>
> CC drivers/char/mem.o
> drivers/char/mem.c: In function 'read_mem':
> drivers/char/mem.c:136: error: implicit declaration of function
> 'unxlate_dev_mem_ptr'
> make[2]: *** [drivers/char
On Thu, Jan 17, 2008 at 09:21:08PM +0800, WANG Cong wrote:
> Building uml failed in current -mm tree. ;(
>
> The below patch fixes this building error:
> ...
> include/asm/arch/system.h:8:22: error: asm/nops.h: No such file or directory
> ...
>
> Cc: Jeff Dike <[EMAIL
On Thu, Jan 17, 2008 at 09:56:41PM +0800, WANG Cong wrote:
>
> This patch fixes this building error:
> ...
> drivers/char/mem.c: In function ‘read_mem’:
> drivers/char/mem.c:136: error: implicit declaration of function
> ‘unxlate_dev_mem_ptr’
> ...
>
> Cc: Jeff Dike &
On Sun, Jan 13, 2008 at 03:24:01PM +0100, [EMAIL PROTECTED] wrote:
> Any ideas what could be wrong here?
What was the problem, exactly?
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel
The compat PTRACE_SETREGS and PTRACE_GETREGS are verifying_area
one word too few.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/x86/ia32/ptrace32.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/ia32/ptrace32.c b/arch/x86/ia32/ptrace32.c
index 4
On Wed, Jan 09, 2008 at 10:50:48PM +0100, Miklos Szeredi wrote:
> > FASTCALL is useless and should not make a difference. It enables
> > regparm on specific functions, but that should not make a difference
> > if it works or not.
>
> __down_write() in include/asm-x86/rwsem.h seems to assume, that
On Thu, Jan 03, 2008 at 01:55:57PM +0100, Miklos Szeredi wrote:
> This is the one: uml-runtime-detection-of-host-vmsplit-on-i386.patch
>
> The relevant log line (both for successful and failed boots):
>
> Locating the top of the address space ... 0xffc0
Thanks for narrowing it down. It turn
On Wed, Jan 02, 2008 at 09:52:41PM +0100, Miklos Szeredi wrote:
> 32bit UML, 64bit host, config attached.
Hadn't tried that, but that works here too.
I'll see if your config reproduces it.
> Can't reproduce with plain -rc6.
Feel like bisecting -mm1?
Jeff
--
Wo
Perches <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/kernel/exitcode.c | 31 --
arch/um/kernel/gmon_syms.c | 11 +-
arch/um/kernel/gprof_syms.c | 13
arch/um/kernel/process
longer needed.
create_tmp_file was also made static.
checkpatch moans about an EXPORT_SYMBOL in user_syms.c which is part
of a macro definition - this is copying a bit of kernel infrastructure
into the libc side of UML because the kernel headers can't be included
there.
Signed-off-by: Jeff
From: Dominique Quatravaux <[EMAIL PROTECTED]>
To convert from tv_nsec to tv_usec, one needs to divide by 1000, not
multiply.
Signed-off-by: Dominique Quatravaux <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
fs/hostfs/hostfs_user.c |8
off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/kernel/process.c | 44
1 file changed, 44 deletions(-)
Index: linux-2.6.22/arch/um/kernel/process.c
===
--- linux-2.6.22.orig/ar
init_irq_signals doesn't need to be called from the context of a new
process. It initializes handlers, which are useless in process
context. With that call gone, init_irq_signals has only one caller,
so it can be inlined into init_new_thread_signals.
Signed-off-by: Jeff Dike <[EMAIL P
style cleanups.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/kernel/process.c |8
arch/um/sys-i386/signal.c| 18 --
arch/um/sys-x86_64/signal.c |4 ++--
include/asm-um/current.h | 23 ++-
include/asm-um/thread_in
: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/signal.c | 31 +++
1 file changed, 11 insertions(+), 20 deletions(-)
Index: linux-2.6-git/arch/um/os-Linux/signal.c
===
--- linux-2.6-git.orig/a
This set of patches should wait for 2.6.25.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.or
On Wed, Jan 02, 2008 at 06:53:00PM +0100, Miklos Szeredi wrote:
> The below patch was needed to make UML compile in latest -mm.
ACK on that - I've got the same patch on its way.
> But sometimes it doesn't boot and does weird things (this is a sample
> with init=/bin/bash):
> (none):/# ls
> Segme
On Sun, Dec 23, 2007 at 08:01:04PM +, Al Viro wrote:
> - helper_wait(pid);
> + helper_wait(pid, 1, NULL);
Thanks.
I know I fixed these - I probably forgot to quilt add the file.
Jeff
--
Work email - jdike at linux dot intel dot com
--
On Tue, Jan 01, 2008 at 09:01:25PM +0800, WANG Cong wrote:
> TOPDIR is obsolete, use srctree instead.
> This patch removes TOPDIR from all UML Makefiles.
Thanks, I'll send this to Andrew.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe fro
On Tue, Dec 18, 2007 at 06:04:58PM -0800, Andrew Morton wrote:
> Nobody seems to look after hppfs. I'll resend the fat and hostfs patches to
> maintainers for a review, please.
It's mine - I'll take a look at it.
Jeff
--
Work email - jdike at linux dot intel dot
On Fri, Dec 14, 2007 at 09:58:40AM -0800, Andrew Morton wrote:
> arch/um/include/um_uaccess.h already includes fixmap.h. Is this a -mm-only
> fix?
Whoops, it is. The include was removed by uml-header-untangling.patch,
so folding this into that would work.
Jeff
-
[ This needs to go into 2.6.24, as it fixes a build breakage seen on x86_64 ]
um_uaccess.h refers to FIXADDR_USER_*, so it should include fixmap.h.
I also changed the non-UML includes to use <> instead of "".
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/inclu
On Tue, Dec 11, 2007 at 05:42:53PM -0500, Kiyoshi Ueda wrote:
> This patch converts um to use blk_end_request interfaces.
> Related 'uptodate' arguments are converted to 'error'.
>
> As a result, the interface of internal function, ubd_end_request(),
> is changed.
Looks OK to me...
Get rid of some syscall counters which haven't been useful in ages.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/include/kern_util.h|1 -
arch/um/kernel/skas/syscall.c |3 ---
arch/um/kernel/syscall.c |3 ---
include/asm-um/processo
error message when something goes wrong.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/drivers/net_user.c |2
arch/um/drivers/slip_user.c |2
arch/um/drivers/slirp_user.c |2
arch/um/include/os.h |2
This series is all cleanups. They should wait for 2.6.25.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:/
This patch moves sig_handler_common_skas from
arch/um/os-Linux/skas/trap.c to its only caller in
arch/um/os-Linux/signal.c. trap.c is now empty, so it can be removed.
This is code movement only - the significant cleanup needed here is
done in the next patch.
Signed-off-by: Jeff Dike <[EM
be deleted.
The special treatment of SIGSEGV similarly goes away, but to
compensate, SA_NODEFER is added to sa_mask when registering a signal
handler.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/signal.c | 63 +-
1
whatsoever.
This patch add a check for pids less than 2, to also catch 1 and
negative pids.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/kernel/skas/mmu.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
Index: linux-2.6-git/arch/um/kernel/skas
haywire, so it's a good idea to get rid of it in
either case.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/skas/process.c |3 +++
1 file changed, 3 insertions(+)
Index: linux-2.6.22/arch/um/os-Linux/ska
instead of panicing on failure, with their callers doing something
appropriate.
There were also duplicate declarations of save_registers and restore_registers
in os.h - these are gone.
I noticed and fixed up some whitespace damage.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
a
ike - checkpatch fixes ]
Signed-off-by: Stanislaw Gruszka <[EMAIL PROTECTED]>
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/drivers/net_user.c |2 -
arch/um/drivers/slip_user.c | 12 +
arch/um/drivers/slirp_user.c | 15 +
On Sun, Dec 09, 2007 at 09:02:31PM +0100, Julia Lawall wrote:
> Recently, Wang Chen submitted a patch
> (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb)
> after a subsequent reference to skb, because netif_rx may call kfree_skb on
> its argument. The same problem occurs i
since the relocation of
the stubs makes it irrelevant. All the HOST_VMSPLIT stuff is gone.
All references to these in arch/um/Makefile are also gone.
I noticed and fixed a missing extern in os.h when adding
os_get_task_size.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
The interfaces which just free page tables, without actually changing
mappings, don't need to cause a TLB flush.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/kernel/tlb.c | 25 +++---
include/asm-um/tlb.h | 122 ++-
2 fi
t will ask alloc_bootmem for zero
bytes, and that will cause the panic.
While I was in initrd.c, I gave it a style makeover.
Prompted by checkpatch, I moved a couple extern declarations of
uml_exitcode to kern_util.h.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/include/ke
rapper and given a va_list from which it must extract its
arguments.
The actual setjmp is moved from buffer_op to do_op_one_page because
the copy operation is inside an atomic section (kmap_atomic to
kunmap_atomic) and it shouldn't be longjmp-ed out of.
Signed-off-by: Jeff Dike <[EMAIL PROTEC
This is a resend of the tlb.h patch from last week, plus four more
small fixes and cleanups.
They should wait for 2.6.25.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
declarations are gone and the mb()'s replaced
by barrier()'s.
One of the mb()'s was deleted because I see no problematic writes that
could be re-ordered past that point.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/os-Linux/signal.c | 28 --
On Thu, Dec 06, 2007 at 11:46:42AM -0800, Andrew Morton wrote:
> > +void flush_tlb_mm(struct mm_struct *mm)
> > +{
> > + struct vm_area_struct *vma = mm->mmap;
> > +
> > + if (atomic_read(&mm->mm_users) == 0)
> > + return;
>
> Under which circumstances does this test succeed?
Sigh,
called without checking the return
removed an obsolete comment
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/include/os.h|1
arch/um/os-Linux/file.c | 232
2 files changed, 118 insertions(+), 115 deletions(-)
use a TLB flush.
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/kernel/tlb.c | 28 ---
include/asm-um/tlb.h | 121 ++-
2 files changed, 141 insertions(+), 8 deletions(-)
Index: linux-2.6-git/arch/um/k
was unused, so it is removed
ptrace_child called _exit for historical reasons which are no
longer valid, so just calls exit instead
Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
---
arch/um/include/irq_user.h |1 -
arch/um/include/os.h|3 +--
arch/um/kernel/irq
1 - 100 of 885 matches
Mail list logo
