Re: state of the osdblk driver?

2014-10-21 Thread Jeff Garzik
On Tue, Oct 21, 2014 at 8:47 AM, Boaz Harrosh wrote: > [Just that I thought we don't do that. I can show you a dozen > ISA scsi LLD controllers which are a complete pain in the neck > with a all subsection core support. There is not a single system > on the planet that has this even possible,

Re: state of the osdblk driver?

2014-10-21 Thread Jeff Garzik
Drop it, if there are no users. It was simulating an OSD, but there did not seem to be much beyond academic interest, and some interest in the use of aforementioned block functions as a useful exercise in block driver writing. On Tue, Oct 21, 2014 at 8:06 AM, Christoph Hellwig wrote: > The

Re: state of the osdblk driver?

2014-10-21 Thread Jeff Garzik
Drop it, if there are no users. It was simulating an OSD, but there did not seem to be much beyond academic interest, and some interest in the use of aforementioned block functions as a useful exercise in block driver writing. On Tue, Oct 21, 2014 at 8:06 AM, Christoph Hellwig

Re: state of the osdblk driver?

2014-10-21 Thread Jeff Garzik
On Tue, Oct 21, 2014 at 8:47 AM, Boaz Harrosh o...@electrozaur.com wrote: [Just that I thought we don't do that. I can show you a dozen ISA scsi LLD controllers which are a complete pain in the neck with a all subsection core support. There is not a single system on the planet that has this

Re: TPMs and random numbers

2013-09-12 Thread Jeff Garzik
On Thu, Sep 12, 2013 at 5:57 PM, Jörn Engel wrote: > On Wed, 11 September 2013 14:47:04 -0400, David Safford wrote: >> But I also think that the existing (certified) TPMs are good enough >> for direct use. > That is equivalent to trusting the TPM chip not to be malicious. It Indeed. While it

Re: TPMs and random numbers

2013-09-12 Thread Jeff Garzik
On Thu, Sep 12, 2013 at 5:57 PM, Jörn Engel jo...@logfs.org wrote: On Wed, 11 September 2013 14:47:04 -0400, David Safford wrote: But I also think that the existing (certified) TPMs are good enough for direct use. That is equivalent to trusting the TPM chip not to be malicious. It Indeed.

Re: TPMs and random numbers

2013-09-11 Thread Jeff Garzik
On Wed, Sep 11, 2013 at 2:45 PM, Theodore Ts'o wrote: > We should definitely do this. If the TPM driver could fetch some > randomness and then call add_device_randomness() to feed this into the > random driver's entropy pool when it initializes itself, that would be > ***really*** cool. rngd

Re: TPMs and random numbers

2013-09-11 Thread Jeff Garzik
On Wed, Sep 11, 2013 at 2:45 PM, Theodore Ts'o ty...@mit.edu wrote: We should definitely do this. If the TPM driver could fetch some randomness and then call add_device_randomness() to feed this into the random driver's entropy pool when it initializes itself, that would be ***really*** cool.

Re: [PATCH libata/for-3.10-fixes] libata: update "Maintained by:" tags

2013-05-14 Thread Jeff Garzik
On Tue, May 14, 2013 at 2:15 PM, Tejun Heo wrote: > (Removed Linus from cc) > > The following patch has been applied to libata/for-3.10-fixes. Will > push out to Linus with the next batch of updates. > > Thanks! > > From 8c3d3d4b12bf8de8c59fe1eb1bf866a8676ca309 Mon Sep 17 00:00:00 2001 > From:

Re: [PATCH libata/for-3.10-fixes] libata: update Maintained by: tags

2013-05-14 Thread Jeff Garzik
On Tue, May 14, 2013 at 2:15 PM, Tejun Heo t...@kernel.org wrote: (Removed Linus from cc) The following patch has been applied to libata/for-3.10-fixes. Will push out to Linus with the next batch of updates. Thanks! From 8c3d3d4b12bf8de8c59fe1eb1bf866a8676ca309 Mon Sep 17 00:00:00 2001

Re: [GIT PULL] libata maintainership update

2013-05-07 Thread Jeff Garzik
/phantom.h SERIAL ATA (SATA) SUBSYSTEM -M: Jeff Garzik +M: Tejun Heo L:linux-...@vger.kernel.org T:git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git S:Supported You probably also want to change * the git tree URL quoted above * a ton of source

Re: [GIT PULL] libata maintainership update

2013-05-07 Thread Jeff Garzik
/phantom.h SERIAL ATA (SATA) SUBSYSTEM -M: Jeff Garzik jgar...@pobox.com +M: Tejun Heo t...@kernel.org L:linux-...@vger.kernel.org T:git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git S:Supported You probably also want to change * the git tree URL

libata maintainership change

2013-05-03 Thread Jeff Garzik
Linux has really found its groove. When I first got involved in Linux, there was no PCI API (now called the hotplug or device API), and patch submission was a moderately painful process of throwing spaghetti at a wall: sending and resending, with both Linus and maintainers having to manually

libata maintainership change

2013-05-03 Thread Jeff Garzik
Linux has really found its groove. When I first got involved in Linux, there was no PCI API (now called the hotplug or device API), and patch submission was a moderately painful process of throwing spaghetti at a wall: sending and resending, with both Linus and maintainers having to manually

Re: [PATCH] sata_highbank: Rename proc_name to the module name

2013-04-30 Thread Jeff Garzik
On 04/30/2013 12:57 PM, Robert Richter wrote: From: Robert Richter mkinitrd looks at /sys/class/scsi_host/host$hostnum/proc_name to find the module name of a disk driver. Current name is "highbank-ahci" but the module is "sata_highbank". Rename it to match the module name. Cc: Rob Herring

[git patches] libata updates

2013-04-30 Thread Jeff Garzik
Summary: 1) More ACPI fixes, cleanups 2) Minor cleanups for sata_highbank, pata_at32, pata_octeon_cf, sata_rcar 3) pata_legacy: small bug found in opti chipset code (untested fix, due to ancient h/w) 4) sata_fsl: RX water mark config knob, some h/w needs it 5) pata_imx: cleanups,

Re: [PATCH] AHCI: Make distinct names for ports in /proc/interrupts

2013-04-30 Thread Jeff Garzik
On 04/29/2013 06:12 AM, Alexander Gordeev wrote: Currently all interrupts assigned to AHCI ports show up in '/proc/interrupts' as 'ahci'. This fix adds port numbers as suffixes and hence makes the descriptions distinct. Reported-by: Jan Beulich Signed-off-by: Alexander Gordeev ---

Re: [PATCH] AHCI: Make distinct names for ports in /proc/interrupts

2013-04-30 Thread Jeff Garzik
On 04/29/2013 06:12 AM, Alexander Gordeev wrote: Currently all interrupts assigned to AHCI ports show up in '/proc/interrupts' as 'ahci'. This fix adds port numbers as suffixes and hence makes the descriptions distinct. Reported-by: Jan Beulich jbeul...@suse.com Signed-off-by: Alexander Gordeev

[git patches] libata updates

2013-04-30 Thread Jeff Garzik
Summary: 1) More ACPI fixes, cleanups 2) Minor cleanups for sata_highbank, pata_at32, pata_octeon_cf, sata_rcar 3) pata_legacy: small bug found in opti chipset code (untested fix, due to ancient h/w) 4) sata_fsl: RX water mark config knob, some h/w needs it 5) pata_imx: cleanups,

Re: [PATCH] sata_highbank: Rename proc_name to the module name

2013-04-30 Thread Jeff Garzik
On 04/30/2013 12:57 PM, Robert Richter wrote: From: Robert Richter robert.rich...@calxeda.com mkinitrd looks at /sys/class/scsi_host/host$hostnum/proc_name to find the module name of a disk driver. Current name is highbank-ahci but the module is sata_highbank. Rename it to match the module

Re: [PATCH] drivers: ata: rcar: use devm_ioremap_resource()

2013-04-12 Thread Jeff Garzik
On 04/12/2013 02:51 AM, Silviu-Mihai Popescu wrote: Convert use of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. This was found with coccinelle. Signed-off-by: Silviu-Mihai Popescu --- drivers/ata/sata_rcar.c |6

Re: [PATCH] drivers: ata: rcar: use devm_ioremap_resource()

2013-04-12 Thread Jeff Garzik
On 04/12/2013 02:51 AM, Silviu-Mihai Popescu wrote: Convert use of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. This was found with coccinelle. Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com ---

[git patches] libata fixes

2013-04-08 Thread Jeff Garzik
The HDIO_DRIVE_* fix is really the biggie. Please pull 6d3bfc7be6f80d0c6ee6800d58d573343bf6e260 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ata_piix.c| 14 +-

[git patches] libata fixes

2013-04-08 Thread Jeff Garzik
The HDIO_DRIVE_* fix is really the biggie. Please pull 6d3bfc7be6f80d0c6ee6800d58d573343bf6e260 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ata_piix.c| 14 +-

Re: [PATCH v0] Add SHA-3 hash algorithm

2013-04-03 Thread Jeff Garzik
On 10/03/2012 01:45 AM, Jeff Garzik wrote: Whee -- SHA-3 is out! I wanted to explore the new toy a bit, and so, here is a blatantly untested rough draft of SHA-3 kernel support. Why rough draft? Because answers to the questions below will inform a more polished version. Just to update

Re: [PATCH RFC 1/1] AHCI: Optimize interrupt processing

2013-04-03 Thread Jeff Garzik
On 03/06/2013 06:26 AM, Alexander Gordeev wrote: Split interrupt service routine into hardware context handler and threaded context handler. That allows to protect ports with individual locks rather than with a single host-wide lock, which results in better parallelism. Signed-off-by: Alexander

Re: [PATCH] drivers: ata: Use resource_size function

2013-04-03 Thread Jeff Garzik
On 03/16/2013 10:32 AM, Alexandru Gheorghiu wrote: Use resource_size function instead of explicit computation. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/ata/pata_octeon_cf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied -- To

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-04-03 Thread Jeff Garzik
On 03/29/2013 01:56 AM, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO.

Re: ata: HDIO_DRIVE_* ioctl() Linux 3.9 regression

2013-04-03 Thread Jeff Garzik
On 03/27/2013 08:51 AM, Krzysztof Mazur wrote: On Mon, Mar 25, 2013 at 06:26:50PM +0100, Ronald wrote: In reply to [1]: I have the same issue. Git bisect took 50+ rebuilds xD Smartd does not work anymore since 84a9a8cd9 ([libata] Set proper SK when CK_COND is set.). I hope I'm not stepping on

Re: [PATCH v3] ata: Fix DVD not dectected at some Haswell platforms

2013-04-03 Thread Jeff Garzik
On 03/06/2013 10:49 AM, Youquan Song wrote: There is a quirk patch 5e5a4f5d5a08c9c504fe956391ac3dae2c66556d "ata_piix: make DVD Drive recognisable on systems with Intel Sandybridge chipsets(v2)" fixing the 4 ports IDE controller 32bit PIO mode. We've hit a problem with DVD not recognized on

Re: [PATCH v3] ata: Fix DVD not dectected at some Haswell platforms

2013-04-03 Thread Jeff Garzik
On 03/06/2013 10:49 AM, Youquan Song wrote: There is a quirk patch 5e5a4f5d5a08c9c504fe956391ac3dae2c66556d ata_piix: make DVD Drive recognisable on systems with Intel Sandybridge chipsets(v2) fixing the 4 ports IDE controller 32bit PIO mode. We've hit a problem with DVD not recognized on

Re: ata: HDIO_DRIVE_* ioctl() Linux 3.9 regression

2013-04-03 Thread Jeff Garzik
On 03/27/2013 08:51 AM, Krzysztof Mazur wrote: On Mon, Mar 25, 2013 at 06:26:50PM +0100, Ronald wrote: In reply to [1]: I have the same issue. Git bisect took 50+ rebuilds xD Smartd does not work anymore since 84a9a8cd9 ([libata] Set proper SK when CK_COND is set.). I hope I'm not stepping on

Re: [PATCH] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-04-03 Thread Jeff Garzik
On 03/29/2013 01:56 AM, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accordingly. Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 instead of EIO.

Re: [PATCH] drivers: ata: Use resource_size function

2013-04-03 Thread Jeff Garzik
On 03/16/2013 10:32 AM, Alexandru Gheorghiu wrote: Use resource_size function instead of explicit computation. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu gheorghiuan...@gmail.com --- drivers/ata/pata_octeon_cf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH RFC 1/1] AHCI: Optimize interrupt processing

2013-04-03 Thread Jeff Garzik
On 03/06/2013 06:26 AM, Alexander Gordeev wrote: Split interrupt service routine into hardware context handler and threaded context handler. That allows to protect ports with individual locks rather than with a single host-wide lock, which results in better parallelism. Signed-off-by: Alexander

Re: [PATCH v0] Add SHA-3 hash algorithm

2013-04-03 Thread Jeff Garzik
On 10/03/2012 01:45 AM, Jeff Garzik wrote: Whee -- SHA-3 is out! I wanted to explore the new toy a bit, and so, here is a blatantly untested rough draft of SHA-3 kernel support. Why rough draft? Because answers to the questions below will inform a more polished version. Just to update

[git patches] libata minor updates

2013-03-22 Thread Jeff Garzik
Please pull b186affe0c9d39e4d3152cd34bffea8fe1fa17f4 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/Kconfig | 13 +++-- drivers/ata/ahci.c| 2 ++ drivers/ata/ata_piix.c

[git patches] libata minor updates

2013-03-22 Thread Jeff Garzik
Please pull b186affe0c9d39e4d3152cd34bffea8fe1fa17f4 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/Kconfig | 13 +++-- drivers/ata/ahci.c| 2 ++ drivers/ata/ata_piix.c

Re: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

2013-03-04 Thread Jeff Garzik
On 03/02/2013 12:00 AM, Aaron Lu wrote: ODD is not a common TLA for non-ATA people so they will get confused by its meaning when they are configuring the kernel. This patch fixed this problem by using ODD only after stating what it is. Signed-off-by: Aaron Lu --- v2: Add a space before open

Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:01 PM, Rado Vrbovsky wrote: From: Andrew Brownfield In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c "ata_piix: defer disks to the Hyper-V drivers by default", this trivial patch adds a description to prefer_ms_hyperv. [rvrbo...@redhat.com:

Re: [PATCH 1/1] ahci: Add Device IDs for Intel Wellsburg PCH

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:08 PM, James Ralston wrote: This patch adds the RAID-mode SATA Device IDs for the Intel Wellsburg PCH Signed-off-by: James Ralston --- drivers/ata/ahci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) applied [manually] -- To unsubscribe from this list:

Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

2013-03-04 Thread Jeff Garzik
On 03/01/2013 06:16 AM, Sander Eikelenboom wrote: Fix a copy and paste mistake introduced in: commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 "ACPI / PM: Rework the handling of devices depending on power resources" Signed-off-by: Sander Eikelenboom --- drivers/ata/libata-acpi.c |2 +-

Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

2013-03-04 Thread Jeff Garzik
On 03/01/2013 06:16 AM, Sander Eikelenboom wrote: Fix a copy and paste mistake introduced in: commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 ACPI / PM: Rework the handling of devices depending on power resources Signed-off-by: Sander Eikelenboom li...@eikelenboom.it ---

Re: [PATCH 1/1] ahci: Add Device IDs for Intel Wellsburg PCH

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:08 PM, James Ralston wrote: This patch adds the RAID-mode SATA Device IDs for the Intel Wellsburg PCH Signed-off-by: James Ralston james.d.rals...@intel.com --- drivers/ata/ahci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) applied [manually] -- To

Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:01 PM, Rado Vrbovsky wrote: From: Andrew Brownfield abrow...@redhat.com In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c ata_piix: defer disks to the Hyper-V drivers by default, this trivial patch adds a description to prefer_ms_hyperv. [rvrbo...@redhat.com:

Re: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

2013-03-04 Thread Jeff Garzik
On 03/02/2013 12:00 AM, Aaron Lu wrote: ODD is not a common TLA for non-ATA people so they will get confused by its meaning when they are configuring the kernel. This patch fixed this problem by using ODD only after stating what it is. Signed-off-by: Aaron Lu aaron...@intel.com --- v2: Add a

Re: [PATCH 2/2] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type

2013-02-28 Thread Jeff Garzik
|6 -- include/acpi/acpi_bus.h |3 --- 3 files changed, 1 insertion(+), 34 deletions(-) patches 1-2 Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 2/2] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type

2013-02-28 Thread Jeff Garzik
+- drivers/ata/libata-acpi.c |6 -- include/acpi/acpi_bus.h |3 --- 3 files changed, 1 insertion(+), 34 deletions(-) patches 1-2 Acked-by: Jeff Garzik jgar...@pobox.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

2013-02-26 Thread Jeff Garzik
On 02/26/2013 11:58 AM, Tejun Heo wrote: On Tue, Feb 26, 2013 at 08:47:30AM -0800, Linus Torvalds wrote: Anyway, in the US it is definitely not a common term for normal people. Googling "odd" doesn't give anything on optical drives on the first page. On the other hand, >70% is about optical

Re: Reproduceable SATA lockup on 3.7.8 with SSD

2013-02-26 Thread Jeff Garzik
On 02/25/2013 07:27 PM, Marc MERLIN wrote: Howdy, I seem to have the same problem (or similar) as Mathieu Desnoyers in https://lkml.org/lkml/2013/2/22/437 I can reliably get my SSD to drop from the SATA bus given the right workload on linux. How can I tell if it's linux's fault of the drive's

Re: Reproduceable SATA lockup on 3.7.8 with SSD

2013-02-26 Thread Jeff Garzik
On 02/25/2013 07:27 PM, Marc MERLIN wrote: Howdy, I seem to have the same problem (or similar) as Mathieu Desnoyers in https://lkml.org/lkml/2013/2/22/437 I can reliably get my SSD to drop from the SATA bus given the right workload on linux. How can I tell if it's linux's fault of the drive's

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

2013-02-26 Thread Jeff Garzik
On 02/26/2013 11:58 AM, Tejun Heo wrote: On Tue, Feb 26, 2013 at 08:47:30AM -0800, Linus Torvalds wrote: Anyway, in the US it is definitely not a common term for normal people. Googling odd doesn't give anything on optical drives on the first page. On the other hand, 70% is about optical

Re: [PATCH 2/3] ahci: AHCI-mode SATA patch for Intel Avoton DeviceIDs

2013-01-25 Thread Jeff Garzik
On 01/25/2013 03:01 PM, Seth Heasley wrote: This patch adds the AHCI and RAID-mode SATA DeviceIDs for the Intel Avoton SOC. Signed-off-by: Seth Heasley --- drivers/ata/ahci.c | 16 1 file changed, 16 insertions(+) applied 1-2 -- To unsubscribe from this list: send the

Re: [PATCH 2/3] ahci: AHCI-mode SATA patch for Intel Avoton DeviceIDs

2013-01-25 Thread Jeff Garzik
On 01/25/2013 03:01 PM, Seth Heasley wrote: This patch adds the AHCI and RAID-mode SATA DeviceIDs for the Intel Avoton SOC. Signed-off-by: Seth Heasley seth.heas...@intel.com --- drivers/ata/ahci.c | 16 1 file changed, 16 insertions(+) applied 1-2 -- To unsubscribe

[git patches] libata fixes

2013-01-21 Thread Jeff Garzik
Please pull 803739d25c2343da6d2f95eebdcbc08bf67097d4 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ahci.c| 8 +++- drivers/ata/libahci.c | 6 +++--- drivers/ata/libata-core.c | 22

[git patches] libata fixes

2013-01-21 Thread Jeff Garzik
Please pull 803739d25c2343da6d2f95eebdcbc08bf67097d4 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ahci.c| 8 +++- drivers/ata/libahci.c | 6 +++--- drivers/ata/libata-core.c | 22

Re: [3.8-{rc1,rc2}] ata1.00: failed to get Identify Device Data, Emask 0x1

2013-01-16 Thread Jeff Garzik
On 01/16/2013 05:10 AM, Sedat Dilek wrote: On Sat, Jan 5, 2013 at 3:20 AM, Huang, Shane wrote: OK, I see the patch I mentioned to fix the problem was later reverted [1]. The real fix is "libata: replace sata_settings with devslp_timing" [2]. Yes, please use [2] which can also be found in

Re: [3.8-{rc1,rc2}] ata1.00: failed to get Identify Device Data, Emask 0x1

2013-01-16 Thread Jeff Garzik
On 01/16/2013 05:10 AM, Sedat Dilek wrote: On Sat, Jan 5, 2013 at 3:20 AM, Huang, Shane shane.hu...@amd.com wrote: OK, I see the patch I mentioned to fix the problem was later reverted [1]. The real fix is libata: replace sata_settings with devslp_timing [2]. Yes, please use [2] which can

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-09 Thread Jeff Garzik
On 01/08/2013 01:16 PM, Joshua Coombs wrote: Add a call to the IDE LED Trigger within the Marvell SATA driver to allow Marvell SoC devices to show SATA activity via GPIO connected LEDs. Signed-off-by: Joshua Coombs --- drivers/ata/sata_mv.c | 3 +++ drivers/leds/Kconfig | 3 +-- 2 files

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-09 Thread Jeff Garzik
On 01/08/2013 01:16 PM, Joshua Coombs wrote: Add a call to the IDE LED Trigger within the Marvell SATA driver to allow Marvell SoC devices to show SATA activity via GPIO connected LEDs. Signed-off-by: Joshua Coombs josh.coo...@gmail.com --- drivers/ata/sata_mv.c | 3 +++ drivers/leds/Kconfig

[git patches] libata updates for 3.8

2012-12-14 Thread Jeff Garzik
use pci_get_drvdata() helper pata_of_platform: fix compile error ahci_platform: make structs static Christian Gmeiner (1): pata_cs5536: add quirk for broken udma Jeff Garzik (3): Revert "libata: check SATA_SETTINGS log with HW Feature Ctrl" Revert "pata_octeo

Re: [PATCH] [libata] scsi: fix Null pointer dereference on disk error

2012-12-14 Thread Jeff Garzik
-by: Xiaotian Feng Cc: Jeff Garzik Cc: James Bottomley Cc: sta...@kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/libata-scsi.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) applied -- To unsubscribe from this list: send the line

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Jeff Garzik
idia MCP61 chipset, sata hdd and ide dvd-rom. Signed-off-by: Konstantin Khlebnikov Signed-off-by: Borislav Petkov Signed-off-by: Jeff Garzik --- Sep 27 13:48:23 buzz kernel: [ 63.815060] ACPI: PCI Interrupt Link [APSI] enabled at IRQ 20 Sep 27 13:48:23 buzz kernel: [ 63.987035] scsi0 :

Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW

2012-12-14 Thread Jeff Garzik
chipset, sata hdd and ide dvd-rom. Signed-off-by: Konstantin Khlebnikov khlebni...@openvz.org Signed-off-by: Borislav Petkov b...@alien8.de Signed-off-by: Jeff Garzik jgar...@redhat.com --- Sep 27 13:48:23 buzz kernel: [ 63.815060] ACPI: PCI Interrupt Link [APSI] enabled at IRQ 20 Sep 27 13:48

Re: [PATCH] [libata] scsi: fix Null pointer dereference on disk error

2012-12-14 Thread Jeff Garzik
-by: Xiaotian Feng dannyf...@tencent.com Cc: Jeff Garzik jgar...@redhat.com Cc: James Bottomley jbottom...@parallels.com Cc: sta...@kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/libata-scsi.c |6 -- 1 file changed, 4 insertions(+), 2 deletions

[git patches] libata updates for 3.8

2012-12-14 Thread Jeff Garzik
pci_get_drvdata() helper pata_of_platform: fix compile error ahci_platform: make structs static Christian Gmeiner (1): pata_cs5536: add quirk for broken udma Jeff Garzik (3): Revert libata: check SATA_SETTINGS log with HW Feature Ctrl Revert pata_octeon_cf: perform host

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 12/03/2012 02:29 PM, Sergei Shtylyov wrote: Hello. On 11/30/2012 01:56 PM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ata_piix: re-oder code and remove prototypes You meant "re-order", I think. Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH v4 -tip 3/3] AHCI: Support multiple MSIs

2012-12-03 Thread Jeff Garzik
|6 +++ drivers/ata/libahci.c | 118 ++--- 3 files changed, 207 insertions(+), 10 deletions(-) Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 11/30/2012 05:56 AM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ata_piix: re-oder code and remove prototypes Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- Jeff, please apply. Thanks! drivers/ata/ata_piix.c | 419

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 11/30/2012 05:56 AM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH] ata_piix: re-oder code and remove prototypes Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v4 -tip 3/3] AHCI: Support multiple MSIs

2012-12-03 Thread Jeff Garzik
+-- drivers/ata/ahci.h|6 +++ drivers/ata/libahci.c | 118 ++--- 3 files changed, 207 insertions(+), 10 deletions(-) Acked-by: Jeff Garzik jgar...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 12/03/2012 02:29 PM, Sergei Shtylyov wrote: Hello. On 11/30/2012 01:56 PM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Subject: [PATCH] ata_piix: re-oder code and remove prototypes You meant re-order, I think. Signed-off-by: Bartlomiej

Re: [PATCH] ata_piix: reenable MS Virtual PC guests

2012-11-28 Thread Jeff Garzik
On 09/18/2012 11:48 AM, Olaf Hering wrote: An earlier commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c ("ata_piix: defer disks to the Hyper-V drivers by default") broke MS Virtual PC guests. Hyper-V guests and Virtual PC guests have nearly identical DMI info. As a result the driver does currently

Re: [PATCH 02/16] ata: Convert dev_printk(KERN_ to dev_(

2012-11-28 Thread Jeff Garzik
On 10/28/2012 04:05 AM, Joe Perches wrote: dev_ calls take less code than dev_printk(KERN_ and reducing object size is good. Coalesce formats for easier grep. Signed-off-by: Joe Perches --- drivers/ata/pata_cmd64x.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) applied

Re: [PATCH 02/16] ata: Convert dev_printk(KERN_LEVEL to dev_level(

2012-11-28 Thread Jeff Garzik
On 10/28/2012 04:05 AM, Joe Perches wrote: dev_level calls take less code than dev_printk(KERN_LEVEL and reducing object size is good. Coalesce formats for easier grep. Signed-off-by: Joe Perches j...@perches.com --- drivers/ata/pata_cmd64x.c |6 +++--- 1 files changed, 3 insertions(+),

Re: [PATCH] ata_piix: reenable MS Virtual PC guests

2012-11-28 Thread Jeff Garzik
On 09/18/2012 11:48 AM, Olaf Hering wrote: An earlier commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c (ata_piix: defer disks to the Hyper-V drivers by default) broke MS Virtual PC guests. Hyper-V guests and Virtual PC guests have nearly identical DMI info. As a result the driver does currently

[git patches] libata fixes

2012-11-16 Thread Jeff Garzik
If you were going to shoot me for not sending these earlier, you would be right. -rc6 beat me by ~2 hours it seems, and they really should have gone out to libata-dev.git and you long before that. These have been in libata-dev.git for a day or so (unfortunately linux-next is on vacation). The

Re: ata4.00: failed to get Identify Device Data, Emask 0x1

2012-11-16 Thread Jeff Garzik
On 11/16/2012 11:02 AM, Huang, Shane wrote: I tried word 78 bit 5(Hardware Feature Control) which does not work, it is 0 on my HDD sample with log 30h page 08h and DevSlp supported. Seems that word 78 bit 5 is only the sufficient condition, not the essential condition. Do you guys have

Re: ata4.00: failed to get Identify Device Data, Emask 0x1

2012-11-16 Thread Jeff Garzik
On 11/16/2012 11:02 AM, Huang, Shane wrote: I tried word 78 bit 5(Hardware Feature Control) which does not work, it is 0 on my HDD sample with log 30h page 08h and DevSlp supported. Seems that word 78 bit 5 is only the sufficient condition, not the essential condition. Do you guys have

[git patches] libata fixes

2012-11-16 Thread Jeff Garzik
If you were going to shoot me for not sending these earlier, you would be right. -rc6 beat me by ~2 hours it seems, and they really should have gone out to libata-dev.git and you long before that. These have been in libata-dev.git for a day or so (unfortunately linux-next is on vacation). The

Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-11-15 Thread Jeff Garzik
SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM). Cc: Jeff Garzik Cc: Viresh Kumar Cc: linux-...@vger.kernel.org Signed-off-by: Yuanhan Liu Signed-off-by: Fengguang Wu --- drivers/ata/ahci_platform.c |2 +- drivers/ata/pata_arasan_cf.c

Re: [PATCH 7/8] ata: highbank: mark ahci_highbank_probe as __devinit

2012-11-15 Thread Jeff Garzik
is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Signed-off-by: Arnd Bergmann Cc: Mark Langsdorf Cc: Rob Herring Cc: Jeff Garzik --- drivers/ata/sata_highbank.c |2 +- 1

Re: [PATCH] ata: pata_arasan: Initialize cf clock to 166MHz

2012-11-15 Thread Jeff Garzik
On 11/08/2012 10:09 AM, Viresh Kumar wrote: From: Vipul Kumar Samar PATA arasan driver expects the clock to be set to 166 MHz for proper functioning. This patch sets clk to 166 MHz in probe. Signed-off-by: Vipul Kumar Samar Signed-off-by: Viresh Kumar --- drivers/ata/pata_arasan_cf.c | 6

Re: [patch,v3 06/10] ata: use scsi_host_alloc_node

2012-11-15 Thread Jeff Garzik
On 11/09/2012 02:18 PM, Jeff Moyer wrote: Signed-off-by: Jeff Moyer --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] pata_cs5536: add quirk for broken udma

2012-11-15 Thread Jeff Garzik
On 11/15/2012 05:03 PM, Christian Gmeiner wrote: I am working on a device which uses the cs5536 pata driver. There are some broken hardware revisions out in the field, which can be detected via DMI. On older versions with an embedded BIOS I used libata.dma=0 to disable dma completely. Now we are

Re: [PATCH] pata_cs5536: add quirk for broken udma

2012-11-15 Thread Jeff Garzik
On 11/15/2012 05:03 PM, Christian Gmeiner wrote: I am working on a device which uses the cs5536 pata driver. There are some broken hardware revisions out in the field, which can be detected via DMI. On older versions with an embedded BIOS I used libata.dma=0 to disable dma completely. Now we are

Re: [patch,v3 06/10] ata: use scsi_host_alloc_node

2012-11-15 Thread Jeff Garzik
On 11/09/2012 02:18 PM, Jeff Moyer wrote: Signed-off-by: Jeff Moyer jmo...@redhat.com --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Acked-by: Jeff Garzik jgar...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] ata: pata_arasan: Initialize cf clock to 166MHz

2012-11-15 Thread Jeff Garzik
On 11/08/2012 10:09 AM, Viresh Kumar wrote: From: Vipul Kumar Samar vipulkumar.sa...@st.com PATA arasan driver expects the clock to be set to 166 MHz for proper functioning. This patch sets clk to 166 MHz in probe. Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com Signed-off-by: Viresh

Re: [PATCH 7/8] ata: highbank: mark ahci_highbank_probe as __devinit

2012-11-15 Thread Jeff Garzik
: Jeff Garzik jgar...@redhat.com --- drivers/ata/sata_highbank.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-11-15 Thread Jeff Garzik
SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM). Cc: Jeff Garzik jgar...@pobox.com Cc: Viresh Kumar viresh.li...@gmail.com Cc: linux-...@vger.kernel.org Signed-off-by: Yuanhan Liu yuanhan@linux.intel.com Signed-off-by: Fengguang Wu fengguang

Re: [PATCH 2/8] aoe: provide ATA identify device content to user on request

2012-11-08 Thread Jeff Garzik
On 11/08/2012 11:32 AM, Ed Cashin wrote: This patch makes the aoe driver follow expected behavior when the user uses ioctl to get the ATA device identify information. Signed-off-by: Ed Cashin --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoeblk.c | 30

Re: [PATCH 2/8] aoe: provide ATA identify device content to user on request

2012-11-08 Thread Jeff Garzik
On 11/08/2012 11:32 AM, Ed Cashin wrote: This patch makes the aoe driver follow expected behavior when the user uses ioctl to get the ATA device identify information. Signed-off-by: Ed Cashin ecas...@coraid.com --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoeblk.c | 30

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-03 Thread Jeff Garzik
On 10/03/2012 03:11 AM, Herbert Xu wrote: On Wed, Oct 03, 2012 at 02:53:27AM -0400, Jeff Garzik wrote: Maybe my patch is the best we can do in the current kernel, if dynamic digest size is not currently possible. Register "sha3_224", "sha3_256", ... as you describe, and w

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-03 Thread Jeff Garzik
On 10/03/2012 02:06 AM, David Miller wrote: From: Jeff Garzik Date: Wed, 3 Oct 2012 01:45:42 -0400 1) tcrypt setup blatantly wrong. What is the best setup here? Define a separate entry for each digest length? Is there some special string descriptor format that is desired, like "sha

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-03 Thread Jeff Garzik
On 10/03/2012 02:06 AM, David Miller wrote: From: Jeff Garzik j...@garzik.org Date: Wed, 3 Oct 2012 01:45:42 -0400 1) tcrypt setup blatantly wrong. What is the best setup here? Define a separate entry for each digest length? Is there some special string descriptor format that is desired

Re: [PATCH v0] Add SHA-3 hash algorithm

2012-10-03 Thread Jeff Garzik
On 10/03/2012 03:11 AM, Herbert Xu wrote: On Wed, Oct 03, 2012 at 02:53:27AM -0400, Jeff Garzik wrote: Maybe my patch is the best we can do in the current kernel, if dynamic digest size is not currently possible. Register sha3_224, sha3_256, ... as you describe, and wait for actual users

[PATCH v0] Add SHA-3 hash algorithm

2012-10-02 Thread Jeff Garzik
es appear. Commit e52113b7b4ace50ab586b426098c6d69d75c263a Branch sha3 Repo git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/linux.git References: http://keccak.noekeon.org/ http://www.mjos.fi/dist/readable_keccak.tgz http://www.nist.gov/itl/csd/sha-100212.cfm Not-signed-off-by: Jeff Garzik crypto/K

Re: [git patches] libata fixes for 3.7

2012-10-02 Thread Jeff Garzik
On 10/02/2012 03:44 PM, Michael Tokarev wrote: On 02.10.2012 23:40, Jeff Garzik wrote: Minor libata updates, nothing notable. 1) Apply -- and then revert -- the FUA feature. Caused disk corruption in linux-next, proving it cannot be turned on by default. Any details on that? Disk

[git patches] libata fixes for 3.7

2012-10-02 Thread Jeff Garzik
_base + HCONTROL); + iowrite32(hcontrol | CLEAR_ERROR, + hcr_base + HCONTROL); + + /* Clear HControl[27] */ + iowrite32(hcontrol & ~CLEAR_ERROR, +

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-02 Thread Jeff Garzik
On 10/02/2012 12:42 PM, Alexander Gordeev wrote: On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) +{ + struct ata_port *ap_this = dev_instance; + struct ahci_port_priv *pp = ap_this->private_data; + struct

  1   2   3   4   5   6   7   8   9   10   >