Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

Jason Xing wrote: > On Wed, Apr 14, 2021 at 12:27 AM Jesse Brandeburg > wrote: > > > > kerneljasonx...@gmail.com wrote: > > > > > From: Jason Xing > > > > Hi Jason, > > > > Sorry, I missed this on the first time: Added intel-wired-la

Re: [PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode

ed/0x120 > [2160294.719365] rtnl_newlink+0x73b/0x860 > > Fixes: 41c445ff0f48 ("i40e: main driver core") > Co-developed-by: Shujin Li > Signed-off-by: Shujin Li > Signed-off-by: Jason Xing Reviewed-by: Jesse Brandeburg @Jakub/@DaveM - feel free to apply this directly.

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

Nitesh Narayan Lal wrote: > > The original issue as seen, was that if you rmmod/insmod a driver > > *without* irqbalance running, the default irq mask is -1, which means > > any CPU. The older kernels (this issue was patched in 2014) used to use > > that affinity mask, but the value programmed

Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

kerneljasonx...@gmail.com wrote: > From: Jason Xing Hi Jason, Sorry, I missed this on the first time: Added intel-wired-lan, please include on any future submissions for Intel drivers. get-maintainers script might help here? > > Fix this panic by adding more rules to calculate the value of

Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode

kerneljasonx...@gmail.com wrote: > From: Jason Xing > > Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode Please use netdev style subject lines when patching net kernel to indicate which kernel tree this is targeted at, "net" or "net-next" [PATCH net v2] i40e: ... > Fix this by

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

Continuing a thread from a bit ago... Nitesh Narayan Lal wrote: > > After a little more digging, I found out why cpumask_local_spread change > > affects the general/initial smp_affinity for certain device IRQs. > > > > After the introduction of the commit: > > > >     e2e64a932 genirq: Set

Re: [PATCH] net: ethernet: intel: Fix a typo in the file ixgbe_dcb_nl.c

Bhaskar Chowdhury wrote: > > s/Reprogam/Reprogram/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Jesse Brandeburg

Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS

ot;net: stmmac: Add support for CBS QDISC") > Suggested-by: Gomes, Vinicius > Signed-off-by: Mohammad Athari Bin Ismail > Signed-off-by: Song, Yoong Siang Reviewed-by: Jesse Brandeburg

Re: [net-next v3 00/14] Add Marvell CN10K support

Geetha sowjanya wrote: > v2-v3 > Reposting as a single thread. FYI, it didn't work, suggest you try adding the git-send-email option (via git-config) sendemail.thread=true sendemail.chainreplyto=false And you can test locally by using first using git send-email to export to mbox and checking

Re: [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions

t; > Suggested-by: David Rientjes > Suggested-by: Jakub Kicinski > Cc: John Hubbard > Signed-off-by: Alexander Lobakin I don't know why it was missed in the series update, but: Reviewed-by: Jesse Brandeburg

Re: [PATCH net-next] net: Return the correct errno code

Zheng Yongjun wrote: > When kzalloc failed, should return ENOMEM rather than ENOBUFS. All these patches have the same subject and description, couldn't they just be part of a single series with a good cover letter? I'm not saying make them a single patch, because that is bad for bisection, but

Re: [PATCH] octeontx2-af: remove unneeded semicolon

ding like [PATCH net-next] otherwise, for net-next: Reviewed-by: Jesse Brandeburg

Re: [PATCH net] hv_netvsc: Reset the RSC count if NVSP_STAT_FAIL in netvsc_receive()

uot;hv_netvsc: Add validation for untrusted Hyper-V > values") Reviewed-by: Jesse Brandeburg

Re: [PATCH][next] net: hns3: remove redundant null check of an array

gainst 0") > Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority > and qset info") > Signed-off-by: Colin Ian King Reviewed-by: Jesse Brandeburg

Re: [PATCH][next] net/mlx5e: Fix spelling mistake "Unknouwn" -> "Unknown"

Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a netdev_warn message. Fix it. > > Signed-off-by: Colin Ian King Trivial patch, looks fine! Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

d 10 duplex full autoneg on > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

pause frame use: No > Advertised auto-negotiation: No > Advertised FEC modes: None > > ethtool lbk0 > Settings for lbk0: > Speed: 10Mb/s > Duplex: Full > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-

Re: [Patch v3 net-next 5/7] octeontx2-af: advertised link modes support on cgx

gt; Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 4/7] octeontx2-af: Physical link configuration support

adds mailbox handler set_link_mode, fw_data_get to > configure and read these parameters. > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

- ethtool --show-fec eth0 > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

CMD_GET_PHY_FEC_STATS, also add CGX_CMD_PRBS and > CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync > with firmware's enum list. > > Signed-off-by: Felix Manlunas > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Kovvuri Goutham > Signed-off

Re: [Patch v3 net-next 1/7] octeontx2-af: forward error correction configuration

t; Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration

ied to the previous posting of v3 that it looked good. Reviewed-by: Jesse Brandeburg

Re: [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage

rst argument of > skb_propagate_pfmemalloc(). > In Page Pool core code, it can be simply inlined instead. > Most of the callers from NIC drivers were just doppelgangers of > the same condition tests. Derive them into a new common function > do deduplicate the code. This is a useful cleanup! Thanks. For the

Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()

ellanox/mlx5/core/en_rx.c | 7 +-- > include/linux/skbuff.h| 15 +++ > 11 files changed, 27 insertions(+), 83 deletions(-) For the patch, and esp. for the Intel drivers: Reviewed-by: Jesse Brandeburg

Re: [PATCH 1/1] ice: fix array overflow on receiving too many fragments for a packet

Xiaohui Zhang wrote: > From: Zhang Xiaohui > > If the hardware receives an oversized packet with too many rx fragments, > skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. > This becomes especially visible if it corrupts the freelist pointer of > a slab page. As I

Re: [PATCH 1/1] ionic: fix array overflow on receiving too many fragments for a packet

Xiaohui Zhang wrote: > From: Zhang Xiaohui > > If the hardware receives an oversized packet with too many rx fragments, > skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. > This becomes especially visible if it corrupts the freelist pointer of > a slab page. > >

Re: [PATCH V4 net-next 0/4] net: hns3: updates for -next

h needs more discussion. > V3 - fix a typo error in #1 reported by Jakub Kicinski. > rewrite #9 commit log. > remove #11 from this series. > V2 - reorder #2 & #3 to fix compiler error. > fix some checkpatch warnings in #10 & #11. For the series: Reviewed-by: Jesse Brandeburg

Re: [PATCH net] iavf: fix error return code in iavf_init_get_resources()

Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong

Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

Jakub Kicinski wrote: > On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > > These are tested to be the latest as part of the tools/lib/bpf build. > > > > But you didn't mention why you're making these changes, and you're > > removing a lot of comment

Re: [PATCH net-next v2 0/9] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

Grygorii Strashko wrote: > Hi > > This series adds multi-port support in mac-only mode (multi MAC mode) to TI > AM65x CPSW driver in preparation for enabling support for multi-port devices, > like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC. For the series Rev

Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

Hi Ian, Ian Rogers wrote: > These are tested to be the latest as part of the tools/lib/bpf build. But you didn't mention why you're making these changes, and you're removing a lot of comments without explaining why/where there might be a replacement or why the comments are useless. I now see

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

ight? I'm sure ixgbe and ice both have this problem too, you should fix them as well, at a minimum, and probably other vendors drivers: $ rg -c --stats num_online_cpus drivers/net/ethernet ... 50 files contained matches for this patch i40e Acked-by: Jesse Brandeburg

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

Nitesh Narayan Lal wrote: > Introduce a new API num_housekeeping_cpus(), that can be used to retrieve > the number of housekeeping CPUs by reading an atomic variable > __num_housekeeping_cpus. This variable is set from housekeeping_setup(). > > This API is introduced for the purpose of drivers

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

Wang Hai wrote: > Wang Hai (3): > i40e: Fix some kernel-doc warnings in i40e_client.c > i40e: Fix some kernel-doc warnings in i40e_common.c > i40e: Fix a kernel-doc warning in i40e_ptp.c > > drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- >

Re: [Intel-wired-lan] VRRP not working on i40e X722 S2600WFT

Lennart Sorensen wrote: > On Thu, Aug 27, 2020 at 02:30:39PM -0400, Lennart Sorensen wrote: > > I have hit a new problem with the X722 chipset (Intel R1304WFT server). > > VRRP simply does not work. > > > > When keepalived registers a vmac interface, and starts transmitting > > multicast packets

Re: [net v2 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port

Murali Karicheri wrote: > To flush the vid + mc entries from ALE, which is required when a VLAN > interface is removed, driver needs to call cpsw_ale_flush_multicast() > with ALE_PORT_HOST for port mask as these entries are added only for > host port. Without this, these entries remain in the ALE

Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

Murali Karicheri wrote: > To flush the vid + mc entries from ALE, which is required when a VLAN > interface is removed, driver needs to call cpsw_ale_flush_multicast() > with ALE_PORT_HOST for port mask as these entries are added only for > host port. Without this, these entries remain in the ALE

Re: NETDEV WATCHDOG: WARNING: at net/sched/sch_generic.c:442 dev_watchdog

Steven Rostedt wrote: > On Wed, 19 Aug 2020 17:01:06 +0530 > Naresh Kamboju wrote: > > > kernel warning noticed on x86_64 while running LTP tracing > > ftrace-stress-test > > case. started noticing on the stable-rc linux-5.8.y branch. > > > > This device booted with KASAN config and DYNAMIC

Re: [PATCH] qed_main: Remove unnecessary cast in kfree

On Tue, 18 Aug 2020 09:10:56 + Xu Wang wrote: > Remove unnecassary casts in the argument to kfree. > > Signed-off-by: Xu Wang You seem to have several of these patches, they should be sent in a series with the series patch subject (for example): [PATCH net-next 0/n] fix up casts on kfree

Re: [PATCH] net/bluetooth/hidp/sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 16:21:03 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > > Signed-off-by: Qingyu Li Please see my replies to your previous patches.

Re: [PATCH] net/bluetooth/cmtp/sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 16:15:55 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. Please see my previous replies.

Re: [PATCH] net/bluetooth/bnep/sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 16:07:03 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > These changes should be part of a series (patch 0,1,2 at least), and all my replies on your other patch apply to this one as well.

Re: [PATCH] net/bluetooth/hci_sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 15:56:48 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > Thanks for the patch! Your subject doesn't need to end in a period. In your commit message, I can guess why you'd want this patch, but your commit message

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

On Mon, 17 Aug 2020 16:27:01 +0300 Kalle Valo wrote: > I was surprised to see that someone was using this driver in 2015, so > I'm not sure anymore what to do. Of course we could still just remove > it and later revert if someone steps up and claims the driver is still > usable. Hmm. Does anyone

Re: [PATCH 4.19 47/48] i40e: Memory leak in i40e_config_iwarp_qvlist

On Tue, 11 Aug 2020 14:46:14 +0200 Pavel Machek wrote: > > --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > > +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > > @@ -449,16 +450,19 @@ static int i40e_config_iwarp_qvlist(stru > > "Incorrect number of iwarp

Re: [PATCH v5] x86: bitops: fix build regression

appreciate the work done to find the right fix and clean up the code while not breaking sparse! I had a look at the assembly from gcc 9.3.1 and it looks good. Thanks! Reviewed-by: Jesse Brandeburg

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

On Mon, 4 May 2020 12:51:12 -0700 Nick Desaulniers wrote: > Sorry for the very late report. It turns out that if your config > tickles __builtin_constant_p just right, this now produces invalid > assembly: > > $ cat foo.c > long a(long b, long c) { > asm("orb\t%1, %0" : "+q"(c): "r"(b)); >

Re: [PATCH net-next 0/6] net: stmmac: Improvements for -next

mmac: ARP Offload for GMAC4+ Cores For the series, looks good to me. Reviewed-by: Jesse Brandeburg

Re: [PATCH] team: Add vlan tx offload to hw_enc_features

On Wed, 7 Aug 2019 10:38:08 +0800 YueHaibing wrote: > We should also enable bonding's vlan tx offload in hw_enc_features, You mean team's vlan tx offload? > pass the vlan packets to the slave devices with vlan tci, let them s/let them to/let the slave/ > to handle vlan tunneling offload

Re: [PATCH] myri10ge: remove unneeded variable

On Wed, 31 Jul 2019 16:53:46 +0800 Ding Xiang wrote: > "error" is unneeded,just return 0 > > Signed-off-by: Ding Xiang Reviewed-by: Jesse Brandeburg

Re: [PATCH 2/2] net: ag71xx: Use GFP_KERNEL instead of GFP_ATOMIC in 'ag71xx_rings_init()'

On Wed, 31 Jul 2019 10:06:48 +0200 Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here, GFP_KERNEL should be enough. > The 'kcalloc()' just a few lines above, already uses GFP_KERNEL. > > Signed-off-by: Christophe JAILLET Reviewed-by: Jesse Brandeburg

Re: [PATCH 1/2] net: ag71xx: Slighly simplify code in 'ag71xx_rings_init()'

Christophe JAILLET Reviewed-by: Jesse Brandeburg

Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

EL which should be enough. > > Signed-off-by: Christophe JAILLET Sure, but generally I'd say GFP_ATOMIC is ok if you're in an init path and you can afford to have the allocation thread sleep while memory is being found by the kernel. Reviewed-by: Jesse Brandeburg

Re: [PATCH net-next] net: Drop unlikely before IS_ERR(_OR_NULL)

On Wed, 5 Jun 2019 22:24:26 +0800 Kefeng wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag, > so no need to do that again from its callers. Drop it. > > segs = __skb_gso_segment(skb, features, false); > - if (unlikely(IS_ERR_OR_NULL(segs))) { > + if

Re: [PATCH net-next v4] hinic: add LRO support

On Tue, 4 Jun 2019 01:16:08 + Xue wrote: > This patch adds LRO support for the HiNIC driver. > > Reported-by: kbuild test robot > Reviewed-by: Jesse Brandeburg > Signed-off-by: Xue Chaojing Hm, you added my reviewed-by tag, but I didn't add it myself, I only comment

Re: [PATCH net-next v3] hinic: add LRO support

some review comments below... On Mon, 3 Jun 2019 04:35:36 + Xue Chaojing wrote: > This patch adds LRO support for the HiNIC driver. > > Signed-off-by: Xue Chaojing > --- > .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 + > .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 8 +- >

Re: [RFC PATCH net-next 10/12] vhost_net: build xdp buff

On Mon, 21 May 2018 17:04:31 +0800 Jason wrote: > This patch implement build XDP buffers in vhost_net. The idea is do > userspace copy in vhost_net and build XDP buff based on the > page. Vhost_net can then submit one or an array of XDP buffs to > underlayer socket (e.g TUN). TUN can choose to do

Re: [RFC PATCH net-next 10/12] vhost_net: build xdp buff

On Mon, 21 May 2018 17:04:31 +0800 Jason wrote: > This patch implement build XDP buffers in vhost_net. The idea is do > userspace copy in vhost_net and build XDP buff based on the > page. Vhost_net can then submit one or an array of XDP buffs to > underlayer socket (e.g TUN). TUN can choose to do

Re: [RFC PATCH net-next 04/12] vhost_net: split out datacopy logic

On Mon, 21 May 2018 17:04:25 +0800 Jason wrote: > Instead of mixing zerocopy and datacopy logics, this patch tries to > split datacopy logic out. This results for a more compact code and > specific optimization could be done on top more easily. > > Signed-off-by: Jason Wang

Re: [RFC PATCH net-next 04/12] vhost_net: split out datacopy logic

On Mon, 21 May 2018 17:04:25 +0800 Jason wrote: > Instead of mixing zerocopy and datacopy logics, this patch tries to > split datacopy logic out. This results for a more compact code and > specific optimization could be done on top more easily. > > Signed-off-by: Jason Wang > --- >

Re: [RFC PATCH net-next 03/12] vhost_net: introduce vhost_has_more_pkts()

On Mon, 21 May 2018 17:04:24 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index de544ee..4ebac76 100644 > ---

Re: [RFC PATCH net-next 03/12] vhost_net: introduce vhost_has_more_pkts()

On Mon, 21 May 2018 17:04:24 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index de544ee..4ebac76 100644 > --- a/drivers/vhost/net.c >

Re: [RFC PATCH net-next 02/12] vhost_net: introduce vhost_exceeds_weight()

On Mon, 21 May 2018 17:04:23 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 15d191a..de544ee 100644 > ---

Re: [RFC PATCH net-next 02/12] vhost_net: introduce vhost_exceeds_weight()

On Mon, 21 May 2018 17:04:23 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 15d191a..de544ee 100644 > --- a/drivers/vhost/net.c >

Re: [RFC PATCH net-next 01/12] vhost_net: introduce helper to initialize tx iov iter

Hi Jason, a few nits. On Mon, 21 May 2018 17:04:22 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/net.c

Re: [RFC PATCH net-next 01/12] vhost_net: introduce helper to initialize tx iov iter

Hi Jason, a few nits. On Mon, 21 May 2018 17:04:22 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index

Re: [uml-devel] [PATCH] uml: Fix build with recent glibc

e.com/user-mode-linux-devel@lists.sourceforge.net/msg10071.html Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [uml-devel] [PATCH] uml: Fix build with recent glibc

se the typedefs which are still available. They also work on > older glibcs. > > Signed-off-by: Andi Kleen same patch that I sent on Feb 1st. Hope you can get more traction than I did. https://www.mail-archive.com/user-mode-linux-devel@lists.sourceforge.net/msg10071.html Reviewed-by: Jesse Brandeburg

[PATCH] um: fix user mode linux build

ger <rich...@nod.at> Cc: user-mode-linux-de...@lists.sourceforge.net Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> --- arch/um/os-Linux/signal.c | 2 +- arch/x86/um/stub_segv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/signal

[PATCH] um: fix user mode linux build

-de...@lists.sourceforge.net Signed-off-by: Jesse Brandeburg --- arch/um/os-Linux/signal.c | 2 +- arch/x86/um/stub_segv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/signal.c b/arch/um/os-Linux/signal.c index a86d7cc2c2d8..a5c0c909c48b 100644 --- a/arch/um

Re: [Intel-wired-lan] [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()

> This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks for the patch. Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [Intel-wired-lan] [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()

d-off-by: Markus Elfring Thanks for the patch. Acked-by: Jesse Brandeburg

Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size

0, x86-64) > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks good, thanks Colin! Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size

ex filename >1953 496 02449 991 i40e_diag.o > > After: >text data bss dec hex filename >1798 584 02382 94e i40e_diag.o > > (gcc 6.3.0, x86-64) > > Signed-off-by: Colin Ian King Looks good, thanks Colin! Acked-by: Jesse Brandeburg

Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment

is > updated at line 1602 just before return, so assigning a value to this > variable in this code block is useless. > > Addresses-Coverity-ID: 1397693 > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Thanks for the fix, looks reasonable. Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment

just before return, so assigning a value to this > variable in this code block is useless. > > Addresses-Coverity-ID: 1397693 > Signed-off-by: Gustavo A. R. Silva Thanks for the fix, looks reasonable. Acked-by: Jesse Brandeburg

Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices

t to the device. > Extend the device IDs to include these so that we hide that the > device supports INTx at all to the user. > Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [PATCH] vfio/pci: Add Intel XXV710 to hidden INTx devices

e device IDs to include these so that we hide that the > device supports INTx at all to the user. > Acked-by: Jesse Brandeburg

Re: [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk

irq xx: nobody cared..." > errors from the spurious interrupt handler when we try to use it > with device assignment. Thanks for doing this Alex, Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [PATCH] PCI: Add Intel XXV710 to broken INTx masking quirk

rors from the spurious interrupt handler when we try to use it > with device assignment. Thanks for doing this Alex, Acked-by: Jesse Brandeburg

Re: [Intel-wired-lan] [PATCH] igb: add missing fields to TXDCTL-register

On Wed, 19 Oct 2016 14:37:59 +0200 Henrik Austad wrote: > The current list of E1000_TXDCTL-registers is incomplete. This adds > the missing parts for the Transmit Descriptor Control (TXDCTL) > register. > > The rest of these values (threshold for descriptor read/write) for >

Re: [Intel-wired-lan] [PATCH] igb: add missing fields to TXDCTL-register

On Wed, 19 Oct 2016 14:37:59 +0200 Henrik Austad wrote: > The current list of E1000_TXDCTL-registers is incomplete. This adds > the missing parts for the Transmit Descriptor Control (TXDCTL) > register. > > The rest of these values (threshold for descriptor read/write) for > TXDCTL seems to be

Re: [Intel-wired-lan] [PATCH v2 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

On Sat, 23 Jul 2016 12:44:32 -0400 Jarod Wilson wrote: > This little series factors out the systim sanitization code first, then > adds e1000_pch_lpt as a new case in the switch that calls the sanitize > function, fixing PTP clock issues I've had reported against an Intel >

Re: [Intel-wired-lan] [PATCH v2 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

On Sat, 23 Jul 2016 12:44:32 -0400 Jarod Wilson wrote: > This little series factors out the systim sanitization code first, then > adds e1000_pch_lpt as a new case in the switch that calls the sanitize > function, fixing PTP clock issues I've had reported against an Intel > I-218V NIC in an

Re: [PATCH] irq: revert non-working patch to affinity defaults

On Fri, 3 Apr 2015 08:55:57 +0200 Ingo Molnar wrote: > So the original commit also has the problem that it unnecessary > drops/retakes the descriptor lock: > > > irq_put_desc_unlock(desc, flags); > > - /* set the initial affinity to prevent every interrupt being on CPU0 */ > > - if (m)

Re: [PATCH] irq: revert non-working patch to affinity defaults

On Fri, 3 Apr 2015 08:55:57 +0200 Ingo Molnar mi...@kernel.org wrote: So the original commit also has the problem that it unnecessary drops/retakes the descriptor lock: irq_put_desc_unlock(desc, flags); - /* set the initial affinity to prevent every interrupt being on CPU0 */ -

[PATCH] irq: revert non-working patch to affinity defaults

e else can help me debug what is going wrong, we can pick up the change later. This commit would also revert commit 4fe7ffb7e17ca ("genirq: Fix null pointer reference in irq_set_affinity_hint()") which was a bug fix to the original patch. Signed-off-by: Jesse Brandeburg CC: Ingo Molnar

[PATCH] irq: revert non-working patch to affinity defaults

help me debug what is going wrong, we can pick up the change later. This commit would also revert commit 4fe7ffb7e17ca (genirq: Fix null pointer reference in irq_set_affinity_hint()) which was a bug fix to the original patch. Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com CC: Ingo

[tip:irq/core] genirq: Fix null pointer reference in irq_set_affinity_hint()

Commit-ID: 4fe7ffb7e17ca6ad9173b8de35f260c9c8fc2f79 Gitweb: http://git.kernel.org/tip/4fe7ffb7e17ca6ad9173b8de35f260c9c8fc2f79 Author: Jesse Brandeburg AuthorDate: Wed, 28 Jan 2015 10:57:39 -0800 Committer: Ingo Molnar CommitDate: Mon, 9 Feb 2015 18:47:42 +0100 genirq: Fix null

[tip:irq/core] genirq: Fix null pointer reference in irq_set_affinity_hint()

Commit-ID: 4fe7ffb7e17ca6ad9173b8de35f260c9c8fc2f79 Gitweb: http://git.kernel.org/tip/4fe7ffb7e17ca6ad9173b8de35f260c9c8fc2f79 Author: Jesse Brandeburg jesse.brandeb...@intel.com AuthorDate: Wed, 28 Jan 2015 10:57:39 -0800 Committer: Ingo Molnar mi...@kernel.org CommitDate: Mon, 9 Feb

Re: [tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

On Tue, 27 Jan 2015 22:36:23 -0800 Yinghai Lu wrote: > On Fri, Jan 23, 2015 at 2:42 AM, tip-bot for Jesse Brandeburg > wrote: > > Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa > > Gitweb: > > http://git.kernel.org/tip/e2e64a932556cdfae455497dbe94a8db151fc9

[tip:irq/core PATCH] genirq: fix null pointer reference in irq_set_affinity_hint()

inity in irq_set_affinity_hint()") Reported-by: Yinghai Lu Signed-off-by: Jesse Brandeburg CC: Thomas Gleixner CC: net...@vger.kernel.org --- kernel/irq/manage.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index f038e58..196a

Re: [tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

On Tue, 27 Jan 2015 22:36:23 -0800 Yinghai Lu wrote: > On Fri, Jan 23, 2015 at 2:42 AM, tip-bot for Jesse Brandeburg > wrote: > > Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa > > Gitweb: > > http://git.kernel.org/tip/e2e64a932556cdfae455497dbe94a8db151fc9

Re: [tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

On Tue, 27 Jan 2015 22:36:23 -0800 Yinghai Lu ying...@kernel.org wrote: On Fri, Jan 23, 2015 at 2:42 AM, tip-bot for Jesse Brandeburg tip...@zytor.com wrote: Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa Gitweb: http://git.kernel.org/tip

[tip:irq/core PATCH] genirq: fix null pointer reference in irq_set_affinity_hint()

in irq_set_affinity_hint()) Reported-by: Yinghai Lu ying...@kernel.org Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com CC: Thomas Gleixner t...@linutronix.de CC: net...@vger.kernel.org --- kernel/irq/manage.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/irq

Re: [tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

On Tue, 27 Jan 2015 22:36:23 -0800 Yinghai Lu ying...@kernel.org wrote: On Fri, Jan 23, 2015 at 2:42 AM, tip-bot for Jesse Brandeburg tip...@zytor.com wrote: Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa Gitweb: http://git.kernel.org/tip

[tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa Gitweb: http://git.kernel.org/tip/e2e64a932556cdfae455497dbe94a8db151fc9fa Author: Jesse Brandeburg AuthorDate: Thu, 18 Dec 2014 17:22:06 -0800 Committer: Thomas Gleixner CommitDate: Fri, 23 Jan 2015 11:38:25 +0100 genirq: Set

[tip:irq/core] genirq: Set initial affinity in irq_set_affinity_hint()

Commit-ID: e2e64a932556cdfae455497dbe94a8db151fc9fa Gitweb: http://git.kernel.org/tip/e2e64a932556cdfae455497dbe94a8db151fc9fa Author: Jesse Brandeburg jesse.brandeb...@intel.com AuthorDate: Thu, 18 Dec 2014 17:22:06 -0800 Committer: Thomas Gleixner t...@linutronix.de CommitDate: Fri, 23

Re: [PATCH] genirq: set initial affinity when hinting

+netdev, as network driver developers might be interested in this functionality. On Thu, Dec 18, 2014 at 5:22 PM, Jesse Brandeburg wrote: > Problem: > The default behavior of the kernel is somewhat undesirable as all > requested interrupts end up on CPU0 after registration. A user

  1   2   >