Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

So should I change this into a revert patch, or you will revert commit 6efb21d6d0e7 ("staging:mt29f_spinand: MT29F2G failing as only 16 bits used for addressing.") by yourself? Thanks. Best Regards, Jheng-Jhong Wu (Victor Wu)

Re: [PATCH v2] staging: mt29f_spinand: fix memory leak while programming pages

each programming page, right? In fact, OOM indeed occurred when I tested programming multi-pages by mtd_debug tool. Erased first, then programmed pages. Best Regards, ─ Jheng-Jhong Wu (Victor Wu) E-mail: goodwater...@gmail.com ─ Greg Kroah-Hartman 於

[PATCH v2] staging: mt29f_spinand: fix memory leak while programming pages

This leads to a memory leak issue when internal ECC is on. Changelog: v2: - use kzalloc()/kfree() to replace devm_kzalloc()/devm_kfree() - add some descriptions to commit message Signed-off-by: Jheng-Jhong Wu --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 4 +++- 1 file changed, 3 inser

Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

indeed occured when I tested programming multi-pages by mtd_debug tool. If OOM was not caused by devm_kzalloc() in spinand_program_page(), what may exhaust memory? Best Regards, ─ Jheng-Jhong Wu (Victor Wu) E-mail: goodwater...@gmail.com ─

Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

if memory is not large enough. In fact, OOM indeed occured when I tested programming multi-pages by mtd_debug tool. If OOM was not caused by devm_kzalloc() in spinand_program_page(), what may exhaust memory? *Best Regards,* *─* *Jheng-Jhong Wu

[PATCH] staging: mt29f_spinand: fix memory leak while programming pages

In spinand_program_page(), it uses devm_kzalloc() to allocate memory to wbuf dynamically if internal ECC is on, but it doesn't free memory allocated to wbuf at the end of this function. This leads to a memory leak issue when internal ECC is on. Signed-off-by: Jheng-Jhong Wu --- drivers/st

[PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

arguments and variables cannot deal with more than 16-bit address. Signed-off-by: Jheng-Jhong Wu --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging